[Koha-bugs] [Bug 6554] Broken encoding in members home/search page

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
         QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

--- Comment #38 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Good to see this patch!
I once tried to get a similar change into Koha with bug 8872. I stumbled over
the numerous occurrences where url parameters in scripts are not properly
decoded. Finally, the change in Templates was obsoleted.

Note that I see you working with binmode in Output.pm; wouldn't it be better to
just utf8-encode the data before you print in output_with_http_headers to
prevent some kind of improper use?

Furthermore, are you really sure you covered all instances in scripts?
When using XSLT, I now have a lot of troubled characters. Note that the xslt
files now do contain UTF-8 in the headers. Probably, we are mixing encoded data
with decoded data now.

Could you please have a look and send a followup?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.