[Koha-bugs] [Bug 6554] Broken encoding in members home/search page

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 28 16:00:20 CET 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #66 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
M. de Rooy thanks a lot for your effort in locating places which need
additional utf-8 encoding and follow-up patches.

I would prefer to leave utf-8 decoding of parameters to CGI module using:

use CGI qw(-utf8);

This ensures that we are decoding all parameters and produce much less code.
Additional benefit is that we are not missing any parameters, possibly creating
undecoded params which can break encoding down the road.

Extract from CGI documentation:

       -utf8
           This makes CGI.pm treat all parameters as UTF-8 strings. Use this
with care, as it will interfere with the processing of binary uploads. It is
           better to manually select which fields are expected to return utf-8
strings and convert them using code like this:

            use Encode;
            my $arg = decode utf8=>param('foo');

Can I squash your followups in one patch and use CGI qw(-utf8) to solve it?

I think we might also benefit from README.utf-8 which explains how to handle
encoding in Koha for easier reference in future.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list