[Koha-bugs] [Bug 9902] item subfields not populating in 3.10

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902

--- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> ---
Comment on attachment 16938
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16938
Bug 9902 - item subfields not populating in 3.10

Review of attachment 16938:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9902&attachment=16938)
-----------------------------------------------------------------

::: C4/Items.pm
@@ +2663,1 @@
>                          $defaultvalue = $defaultvalues->{callnumber};

Hmm this doesn't make sense to me

We have if do something
else
do the exact same thing 

couldnt that just be 
do the thing

IE couldnt that just be $defaultvalue = $defaultvalues->{callnumber};

The comments do not match the code, that else will be triggered even if the
item record does exist, if the has a callnumber, it will match the else. IE the
whole IF and ELSE is a no op

-- 
You are receiving this mail because:
You are watching all bug changes.