From bugzilla-daemon at bugs.koha-community.org Wed May 1 00:11:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2013 22:11:09 +0000 Subject: [Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I am not sure I understand your example, but I think this would need to be an option. If you are using analytics for bound together things or other printed materials the hold on the analytic should go on the item of the record it's linked to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 00:17:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2013 22:17:08 +0000 Subject: [Koha-bugs] [Bug 9949] Tidy up the intranet set up and fix a potential security issue when running from git In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9949 --- Comment #11 from Brendan Gallagher --- (In reply to comment #10) > (In reply to comment #7) > > Tested this again and ran tests on this. > > > > Also did a quick grep check for other spots where kohaversion.pl does not > > have a intranet/ infront of it. > > > > Tests Passed this time. > > > > Marking as Singed off - Brendan > > > QA-comment: i also got Jared's error too... > > $ perl ./Makefile.PL > Could not open 'kohaversion.pl': No such file or directory at > /usr/share/perl/5.10.1/ExtUtils/MM_Unix.pm line 2639. > > marking failed-QA Mason - I just tried this on a completely new VM blank debian install with nothing else on it - cloned and then added these patches. It worked fine for me. Looking at the error message - that path needs to be updated for 'intranet/kohaversion.pl' - Any chance you could try one more time. I'm sure that we got all of the places in the MakeFile.PL that reference kohaversion.pl Thanks, Brendan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 00:54:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2013 22:54:44 +0000 Subject: [Koha-bugs] [Bug 10145] The acquisition details block is badly placed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|Serials |Templates Assignee|jonathan.druart at biblibre.co |oleonard at myacpl.org |m | --- Comment #2 from Katrin Fischer --- Can we get a sign off for this? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 00:57:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 30 Apr 2013 22:57:35 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #19 from Bernardo Gonzalez Kriegel --- Hi, it works with search, but... 1) --batch option continues to ask confirmation 2) koha-qa complains. You are using Modern::Perl, so you must change the way to open a file change this open( FILE, "$biblios" ) || die("Can't open $biblios"); to this open my $FILE,"<","$biblios" or die("Can't open $biblios"); and the closing/reading accordingly. 3) You are checking for a filename assuming a '/' in filename (absolute) if ( $biblios =~ m|/| ) change to if ( -e $filename ) to allow any file name, then, if not exists, check if the resulting string is composed by numbers. 4) You are reading the file with @bibliofile = ; that reads 1 line only 5) --where filename do not work I put 3 biblionumber on a file, run command and the result was weird, prints that was about to check 100 bibs, and enter endless loop Not ready yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 02:57:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 00:57:07 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 03:28:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 01:28:33 +0000 Subject: [Koha-bugs] [Bug 10163] New: batch-mod items tool fails on files over 1000 lines long Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Bug ID: 10163 Summary: batch-mod items tool fails on files over 1000 lines long Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com CC: m.de.rooy at rijksmuseum.nl if you attempt to upload a file with more than 1000 lines, you get an error... ---------------------------------------- Batch item modification - Too many items (1001): not displaying each one individually. Return to batch item modification ---------------------------------------- looking that the code its obvious that the intended behavior is to not display the items, yet still allow the items to be edited this functionality seems broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 03:30:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 01:30:54 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 --- Comment #1 from Mason James --- Created attachment 17859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17859&action=edit pic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:15:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:15:25 +0000 Subject: [Koha-bugs] [Bug 9957] Missing cancel link on subfield editing page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:15:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:15:27 +0000 Subject: [Koha-bugs] [Bug 9957] Missing cancel link on subfield editing page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17858|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 17860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17860&action=edit [PASSED QA] Bug 9957 - Missing cancel link on subfield editing page The subfield edit page has an edit bottom at the top of the page. Almost no other edit screens do this. It would be more consistent to put it at the bottom. Also missing is a "cancel" link. This patch fixes both issues. The patch also adds "Default" to the breadcrumbs when editing a subfield in the default framework. To test, apply the patch and edit a subfield: MARC frameworks -> MARC structure -> Subfields -> Edit. The "Save changes" button should appear at the bottom of the page alonside a "Cancel" link. Both should work correctly. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Template change only, improves consistency and works nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:23:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:23:55 +0000 Subject: [Koha-bugs] [Bug 10111] Layout on basket summary page a bit inconsistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10111 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:23:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:23:57 +0000 Subject: [Koha-bugs] [Bug 10111] Layout on basket summary page a bit inconsistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10111 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17688|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 17861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17861&action=edit [PASSED QA] Bug 10111 - Layout on basket summary page a bit inconsistent Some details in the summary of basket information were not marked up consistently with others on the page. This patch makes the markup consistent for a consistent appearance. To test, view a basket in Acquisitions which is part of a basketgroup. Information should be displayed consistently for baksets in both open and closed basket groups. Signed-off-by: Mirko Tietgen Works as expected Signed-off-by: Katrin Fischer Template change only, works nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:31:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:31:12 +0000 Subject: [Koha-bugs] [Bug 10143] Fix FSF address in license headers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:31:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:31:15 +0000 Subject: [Koha-bugs] [Bug 10143] Fix FSF address in license headers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17849|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 17862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17862&action=edit [PASSED QA] Bug 10143 - Fixing license headers Some files have the old 59 Temple address instead of the 51 Franklin street. Signed-off-by: Owen Leonard I see lots more which will need to be corrected as well. Signed-off-by: Katrin Fischer Corrects addresses in 3 files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:32:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:32:33 +0000 Subject: [Koha-bugs] [Bug 10145] The acquisition details block is badly placed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17787|0 |1 is obsolete| | --- Comment #3 from David Cook --- Created attachment 17863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17863&action=edit [SIGNED OFF] Bug 10145: The acquisition details block is badly placed. Bug 5335 introduced a new "Acquisition details" block on the subscription details page. It is placed between to tabs and causes an ergonomic issue. Test plan: - Order a subscription. - Go on the subscription detail page and select a tab. - The "Acquisition details" block is moved from the bottom to the top of the table. - Apply the patch - The "Acquisition details" block is always on the bottom of the table. Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:33:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:33:24 +0000 Subject: [Koha-bugs] [Bug 10145] The acquisition details block is badly placed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook at prosentient.com.au --- Comment #4 from David Cook --- Works great. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:34:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:34:18 +0000 Subject: [Koha-bugs] [Bug 10152] Default sorting wrong in parcels.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10152 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:34:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:34:20 +0000 Subject: [Koha-bugs] [Bug 10152] Default sorting wrong in parcels.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10152 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17848|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 17864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17864&action=edit [PASSED QA] Bug 10152: Default sorting wrong in parcels.pl When you are receiving an order, the list of existing invoices should appear in reverse chronological order. Unfortunately, right now it appears in regular chronological order. To test: 1) Make sure you have multiple invoices that have varying shipment dates for a vendor. We will assume this vendor is called "Example Vendor." 2) Choose the "Receive shipments" button on the Example Vendor page. 3) Note that the invoices are sorted by regular chronological order. 4) Apply patch. 5) Refresh "Receive shipment" page. Note that invoices are now sorted in reverse chronological order. 6) Sign off. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:40:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:40:42 +0000 Subject: [Koha-bugs] [Bug 9719] Changing the rows per page on a custom report fails if it has user supplied parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:40:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:40:45 +0000 Subject: [Koha-bugs] [Bug 9719] Changing the rows per page on a custom report fails if it has user supplied parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17851|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 17865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17865&action=edit [PASSED QA] Bug 9719 - Changing the rows per page on a custom report fails if it has user supplied parameters If you create an SQL report that includes one or more parameters, using the 'rows per page' pulldown does not work. Instead, it will prompt for the parameters again and shows the first page of output. Test Plan: 1) Create a new report from sql as follows: SELECT * FROM borrowers WHERE surname LIKE <> AND firstname LIKE <> 2) Run this report 3) Change the 'Rows per page' and click 'Update' 4) This should kick you back to the start where the report asks you for your parameters 5) Apply the patch 6) Repeat step 3, this time is should work correctly Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Works nicely now. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:46:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:46:17 +0000 Subject: [Koha-bugs] [Bug 10145] The acquisition details block is badly placed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:46:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:46:20 +0000 Subject: [Koha-bugs] [Bug 10145] The acquisition details block is badly placed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17863|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 17866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17866&action=edit [PASSED QA] Bug 10145: The acquisition details block is badly placed. Bug 5335 introduced a new "Acquisition details" block on the subscription details page. It is placed between to tabs and causes an ergonomic issue. Test plan: - Order a subscription. - Go on the subscription detail page and select a tab. - The "Acquisition details" block is moved from the bottom to the top of the table. - Apply the patch - The "Acquisition details" block is always on the bottom of the table. Signed-off-by: David Cook Signed-off-by: Katrin Fischer Fixes display problem, passes all tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:59:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 06:59:24 +0000 Subject: [Koha-bugs] [Bug 9852] Add interlibrary loan request form to the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9852 --- Comment #1 from Magnus Enger --- It looks like PTFS Europe is already doing some work that is quite similar to the suggestions here: https://github.com/PTFS-Europe/koha/commits/3.8.ptfs_ILL -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 10:33:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 08:33:03 +0000 Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Katrin Fischer --- Hi Matthias, looking again at your answers ant the new patch I still spot some problems: 1) Yes, I think it's worth it. We should not introduce new MySQLisms. 4) C4:Dates is deprecated as we are trying to get rid of it in favour of the new modules. Also I was wondering about the display of dates in the templates, it looks to me like this line should be using the TT plugin? + [% IF (moddatecount) %]
[% moddatecount %] items modified : datelastseen set to [% date %]
[% END %] 5) Terms might be wrong already, but it would be good to always use 'library' instead of branch or location when it's actually referring to home branch, holding branch etc. in the database. 6) There are some terms where capitalization is wrong: Clear All etc. Sorry :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 10:56:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 08:56:34 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #8 from Janusz Kaczmarek --- Test plan ========= The story with indicators, especially in MARC-21, is not straightforward, but one can point four main cases: 1. MARC-21 formal heading -- other than unified title 2. MARC-21 formal heading -- unified title 3. MARC-21 subject heading 4. UNIMARC 1. MARC-21 formal heading -- other than unified title 1st indicator from field 1XX (100/110/111) in the authority record should be copied to 1st indicator of controlled field in the bibliographic record, 2nd indicator is not defined (hence no action is taken) 2. MARC-21 formal heading -- unified title 1st indicator in authority record is not defined (hence no action is taken) 2nd indicator from field 130 in the authority record should be copied to 1st indicator of controlled field in the bibliographic record if it is 130 or 730 (or 630 ? se bellow), or to 2nd indicator of controlled field in the bibliographic record, if it is 830 3. MARC-21 subject heading (6XX in bibliographic record) a) 1st indicator: 600, 610, 611: 1st indicator from field 1XX (100/110/111) in the authority record should be copied to 1st indicator of controlled field in the bibliographic record 630: 2nd indicator from field 130 in the authority record should be copied to 1st indicator of controlled field in the bibliographic record b) 2nd indicator ? the thesaurus a mapping should be made from 008/11 in authority record (http://www.loc.gov/marc/authority/ad008.html) to the 2nd indictor (http://www.loc.gov/marc/bibliographic/bd600.html), e.g. 008/11=a --> 2nd. ind. = 0 In case when 008/11=~/[rsz]/ 2nd ind. should be set to 7, and subfield $2 should be added (for r --> aat, for s --> sears, for z the cataloger has to put a value by himself) 4. UNIMARC Indicators from the authority record should be copied directly to the controlled field in the bibliographic record. References: http://www.loc.gov/marc/bibliographic/ http://www.loc.gov/marc/authority/ http://archive.ifla.org/VI/3/p1996-1/sec-uni.htm http://www.ifla.org/files/assets/uca/unimarc-authorities-format.pdf -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:34:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 09:34:27 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |januszop at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:22:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 10:22:25 +0000 Subject: [Koha-bugs] [Bug 8264] local cover images not working in IE8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8264 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:24:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 10:24:03 +0000 Subject: [Koha-bugs] [Bug 10153] Patron header search form is too wide In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10153 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:26:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 10:26:27 +0000 Subject: [Koha-bugs] [Bug 10152] Default sorting wrong in parcels.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10152 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:28:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 10:28:59 +0000 Subject: [Koha-bugs] [Bug 10145] The acquisition details block is badly placed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:29:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 10:29:49 +0000 Subject: [Koha-bugs] [Bug 10164] New: way to do substrings on notices/slips Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10164 Bug ID: 10164 Summary: way to do substrings on notices/slips Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com Often when people print hold notices they do partial names - like the first 3 letters of the last name or something similar for privacy reasons. It would be nice to have a way to do substrings of fields in the notices and slips, something like: substring(<>,1,3) Just an idea - I don't care about the formatting, just the implementation :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:34:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 10:34:03 +0000 Subject: [Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:39:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 10:39:33 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #3 from mathieu saby --- Fridolyn, I suppose the 1st attachment is obsolete? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:40:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 10:40:37 +0000 Subject: [Koha-bugs] [Bug 10017] Opac CCSR template do not cope well with right-to-left languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10017 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:44:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 10:44:44 +0000 Subject: [Koha-bugs] [Bug 10022] Multiple tags moderation doesn't work on translated page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:48:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 10:48:10 +0000 Subject: [Koha-bugs] [Bug 10143] Fix FSF address in license headers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10143 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:53:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 10:53:58 +0000 Subject: [Koha-bugs] [Bug 10044] Doubled up paging on order receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10044 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #3 from mathieu saby --- After applying the patch, I can see no more the useless pagination under the table. Reception works well. I sign off. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:55:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 10:55:14 +0000 Subject: [Koha-bugs] [Bug 10044] Doubled up paging on order receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10044 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17697|0 |1 is obsolete| | --- Comment #4 from mathieu saby --- Created attachment 17867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17867&action=edit [PATCH][SIGNED OFF] MT10144: Remove duplicate pagination on the pending orders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:56:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 10:56:51 +0000 Subject: [Koha-bugs] [Bug 6709] marc21_field_006.xml and marc21_field_008.xml can't be translated. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6709 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:02:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:02:17 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #8 from mathieu saby --- Hello Jonathan. I signed off 10044. For the improvement of filters, I think your patch is a duplicate of a patch I wrote some weeks ago : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9560 Could you take a look at it please? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:09:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:09:55 +0000 Subject: [Koha-bugs] [Bug 10111] Layout on basket summary page a bit inconsistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10111 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:16:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:16:07 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #91 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:19:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:19:44 +0000 Subject: [Koha-bugs] [Bug 9266] Untranslated strings in tags moderation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:20:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:20:41 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #36 from mathieu saby --- My first tests are good, but in search results, you add an column for ordernumber in the html table. Ordernumber is already present in the table on 1st column. So I suppose you wanted to display funds, and not ordernumber ? M. Saby -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:22:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:22:58 +0000 Subject: [Koha-bugs] [Bug 9957] Missing cancel link on subfield editing page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:27:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:27:59 +0000 Subject: [Koha-bugs] [Bug 9719] Changing the rows per page on a custom report fails if it has user supplied parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:29:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:29:05 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:35:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:35:02 +0000 Subject: [Koha-bugs] [Bug 10097] Hide framework selection when importing staged authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10097 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:37:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:37:44 +0000 Subject: [Koha-bugs] [Bug 10053] borrowers.branchcode cannot be null In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10053 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:45:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:45:41 +0000 Subject: [Koha-bugs] [Bug 7055] NORMARC: Links and defaults for 008 position 15-17 and 35-37 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7055 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:48:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:48:12 +0000 Subject: [Koha-bugs] [Bug 7054] NORMARC: wrong default for 000 position 17 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7054 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:57:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:57:38 +0000 Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 --- Comment #31 from Jared Camins-Esakov --- This does not work with Plack, of course, since importing records doesn't work under Plack, but I am pushing the patch anyway as it could be useful for people who use Apache. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:57:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:57:48 +0000 Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #32 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:58:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 11:58:55 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #81 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:01:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 12:01:00 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #4 from Jared Camins-Esakov --- More relevant error messages: seek() on closed filehandle _GEN_3 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 31. Undefined subroutine &CGI::Emulate::PSGI::croak called at /usr/share/perl5/CGI/Emulate/PSGI.pm line 31 CGI::Emulate::PSGI::__ANON__('HASH(0x38efca0)') called at /usr/share/perl5/Plack/App/WrapCGI.pm line 83 Plack::App::WrapCGI::call('Plack::App::WrapCGI=HASH(0x419fd50)', 'HASH(0x38efca0)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x38efca0)') called at /usr/share/perl5/Plack/App/CGIBin.pm line 50 Plack::App::CGIBin::serve_path('Plack::App::CGIBin=HASH(0x34ea1f0)', 'HASH(0x38efca0)', '/home/jcamins/kohaclone/tools/stage-marc-import.pl') called at /usr/shar e/perl5/Plack/App/File.pm line 34 Plack::App::File::call('Plack::App::CGIBin=HASH(0x34ea1f0)', 'HASH(0x38efca0)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x38efca0)') called at /usr/share/perl5/Plack/App/URLMap.pm line 71 Plack::App::URLMap::call('Plack::App::URLMap=HASH(0x34ea5f8)', 'HASH(0x38efca0)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x38efca0)') called at /usr/share/perl5/Plack/Middleware/ReverseProxy.pm line 68 Plack::Middleware::ReverseProxy::call('Plack::Middleware::ReverseProxy=HASH(0x35cd768)', 'HASH(0x38efca0)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x38efca0)') called at /usr/share/perl5/Plack/Middleware/Conditional.pm line 19 Plack::Middleware::Conditional::call('Plack::Middleware::Conditional=HASH(0x35cd540)', 'HASH(0x38efca0)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Middleware::StackTrace::__ANON__ at /usr/share/perl5/Try/Tiny.pm line 71 eval {...} at /usr/share/perl5/Try/Tiny.pm line 67 Plack::Middleware::StackTrace::call('Plack::Middleware::StackTrace=HASH(0x35cd900)', 'HASH(0x38efca0)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x38efca0)') called at /home/jcamins/perl5/lib/perl5/Plack/Middleware/Debug/Base.pm line 23 Plack::Middleware::Debug::Base::call('Plack::Middleware::Debug::Memory=HASH(0x366a150)', 'HASH(0x38efca0)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x38efca0)') called at /home/jcamins/perl5/lib/perl5/Plack/Middleware/Debug/Base.pm line 23 Plack::Middleware::Debug::Base::call('Plack::Middleware::Debug::Timer=HASH(0x366aaf8)', 'HASH(0x38efca0)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x38efca0)') called at /home/jcamins/perl5/lib/perl5/Plack/Middleware/Debug/Base.pm line 23 Plack::Middleware::Debug::Base::call('Plack::Middleware::Debug::Response=HASH(0x35d2498)', 'HASH(0x38efca0)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x38efca0)') called at /home/jcamins/perl5/lib/perl5/Plack/Middleware/Debug/Base.pm line 23 Plack::Middleware::Debug::Base::call('Plack::Middleware::Debug::Environment=HASH(0x35d2630)', 'HASH(0x38efca0)') called at /usr/share/perl5/Plack/Component.pm li ne 39 Plack::Component::__ANON__('HASH(0x38efca0)') called at /home/jcamins/perl5/lib/perl5/Plack/Middleware/Debug.pm line 138 Plack::Middleware::Debug::call('Plack::Middleware::Debug=HASH(0x35cdaf8)', 'HASH(0x38efca0)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x38efca0)') called at /usr/share/perl5/Plack/Middleware/AccessLog.pm line 21 Plack::Middleware::AccessLog::call('Plack::Middleware::AccessLog=HASH(0xbe4de0)', 'HASH(0x38efca0)') called at /usr/share/perl5/Plack/Component.pm line 39 Plack::Component::__ANON__('HASH(0x38efca0)') called at /usr/share/perl5/Plack/Util.pm line 165 eval {...} at /usr/share/perl5/Plack/Util.pm line 165 Plack::Util::run_app('CODE(0xbe4d08)', 'HASH(0x38efca0)') called at /usr/share/perl5/Starman/Server.pm line 223 Starman::Server::process_request('Starman::Server=HASH(0xbe4f18)') called at /usr/share/perl5/Net/Server.pm line 142 Net::Server::run_client_connection('Starman::Server=HASH(0xbe4f18)') called at /usr/share/perl5/Net/Server/PreFork.pm line 273 eval {...} at /usr/share/perl5/Net/Server/PreFork.pm line 273 Net::Server::PreFork::run_child('Starman::Server=HASH(0xbe4f18)') called at /usr/share/perl5/Net/Server/PreFork.pm line 229 Net::Server::PreFork::run_n_children('Starman::Server=HASH(0xbe4f18)', 2) called at /usr/share/perl5/Net/Server/PreFork.pm line 144 Net::Server::PreFork::loop('Starman::Server=HASH(0xbe4f18)') called at /usr/share/perl5/Net/Server.pm line 117 Net::Server::run('Starman::Server=HASH(0xbe4f18)', 'port', 'ARRAY(0xbec948)', 'host', 'ARRAY(0x13ff188)', 'proto', 'ARRAY(0x3877180)', 'serialize', 'flock', 'log _level', 2, 'log_file', '/home/jcamins/koha-dev/var/log/koha-error.log', 'min_servers', 2, 'min_spare_servers', 1, 'max_spare_servers', 1, 'max_servers', 2, 'max_request s', 50, 'user', 1001, 'group', '1003 33 999 1003', 'listen', 1024, 'leave_children_open_on_hup', 1, 'no_client_stdout', 1, 'pid_file', '/home/jcamins/koha-dev/var/run/pl ack.pid', 'setsid', 1, 'background', 1) called at /usr/share/perl5/Starman/Server.pm line 61 Starman::Server::run('Starman::Server=HASH(0xbe4f18)', 'CODE(0xbe4d08)', 'HASH(0x34ea3a0)') called at /usr/share/perl5/Plack/Handler/Starman.pm line 18 Plack::Handler::Starman::run('Plack::Handler::Starman=HASH(0x34e9f20)', 'CODE(0xbe4d08)') called at /usr/share/perl5/Plack/Loader.pm line 88 Plack::Loader::run('Plack::Loader=HASH(0xb5f448)', 'Plack::Handler::Starman=HASH(0x34e9f20)') called at /usr/share/perl5/Plack/Runner.pm line 263 Plack::Runner::run('Plack::Runner=HASH(0x8d46e0)') called at /usr/bin/starman line 31 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:03:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 12:03:51 +0000 Subject: [Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from M. de Rooy --- (In reply to comment #5) > Marcel, this is due to the way pacakges handle yui stuff Thanks for your reply. This is not completely clear to me. I switch this back to Signed off. Could Robin qa this kind of patches perhaps? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:15:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 12:15:31 +0000 Subject: [Koha-bugs] [Bug 8419] Suspended holds appear on the daily holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:17:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 12:17:23 +0000 Subject: [Koha-bugs] [Bug 10033] dangerous query in _koha_modify_item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10033 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:22:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 12:22:55 +0000 Subject: [Koha-bugs] [Bug 7228] can't order more than 1 when importing all from staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:43:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 12:43:55 +0000 Subject: [Koha-bugs] [Bug 6506] deleting patron history missing errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6506 --- Comment #21 from Jared Camins-Esakov --- With DEBUG turned on, having AnonymousPatron blank still causes a fatal error, but I will report a separate bug for that, and push this as-is, since it helps when DEBUG is off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:44:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 12:44:49 +0000 Subject: [Koha-bugs] [Bug 6506] deleting patron history missing errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6506 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:48:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 12:48:06 +0000 Subject: [Koha-bugs] [Bug 10165] New: Trying to clear reading history when AnonymousPatron unset and DEBUG is on causes fatal error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10165 Bug ID: 10165 Summary: Trying to clear reading history when AnonymousPatron unset and DEBUG is on causes fatal error Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jcamins at cpbibliography.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 6506 Blocks: 9944 I get the following error: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha`.`old_issues`, CONSTRAINT `old_issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE SET NULL) at /home/jcamins/kohaclone/C4/Circulation.pm line 2859. at /home/jcamins/kohaclone/opac/opac-privacy.pl line 77 This should be addressed by catching any errors thrown by that query, and setting $anonymisation_err appropriately. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:48:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 12:48:06 +0000 Subject: [Koha-bugs] [Bug 6506] deleting patron history missing errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6506 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10165 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:48:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 12:48:06 +0000 Subject: [Koha-bugs] [Bug 9944] cleanborrowers.pl does not check for anonymisation errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9944 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10165 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 15:30:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 13:30:20 +0000 Subject: [Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 --- Comment #7 from Tom?s Cohen Arazi --- (In reply to comment #6) > (In reply to comment #5) > > Marcel, this is due to the way pacakges handle yui stuff > > Thanks for your reply. This is not completely clear to me. I switch this > back to Signed off. Could Robin qa this kind of patches perhaps? You could see the fix this way: we already did this for the 'prog' theme, I just added the relevant lines so the same is done for 'ccsr'. Anyway, I think Robin should take a look too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:02:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 15:02:46 +0000 Subject: [Koha-bugs] [Bug 10044] Doubled up paging on order receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:08:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 15:08:19 +0000 Subject: [Koha-bugs] [Bug 10044] Doubled up paging on order receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:08:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 15:08:21 +0000 Subject: [Koha-bugs] [Bug 10044] Doubled up paging on order receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10044 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17867|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 17868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17868&action=edit [PASSED QA] MT10144: Remove duplicate pagination on the pending orders page. Test plan: Check that there is just one pagination on the pending orders page. http://bugs.koha-community.org/show_bug.cgi?id=10044 Signed-off-by: Mathieu Saby Signed-off-by: Katrin Fischer Works and deletes the old pagination that was replaced by datatables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:23:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 15:23:05 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:23:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 15:23:06 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17500|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 17869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17869&action=edit Bug 9533 - batch item modification should ignore defaults This patch makes the pre-population of the fields for the batch item editor with the default values from the default framework optional and off by default. Test Plan: 1) Apply patch 2) Add default values for cost and replacement cost to the default framework. 3) Browse to Tools / Batch item modification 4) Choose a file, or entire some barcodes in the text area 5) Ensure that the 'Populate fields with default values from default framework' is *not* checked 6) Click 'Continue' 7) Observe that the fields for cost and replacement cost are blank 8) Click the 'back' button on your browser 9) Check the checkbox to enable the default value 10) Click 'Continue' 11) Observe that the fields for cost and replacement cost now contain the default values you assigned them in the default MARC framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:24:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 15:24:03 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17869|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 17870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17870&action=edit Bug 9533 - batch item modification should ignore defaults This patch makes the pre-population of the fields for the batch item editor with the default values from the default framework optional and off by default. Test Plan: 1) Apply patch 2) Add default values for cost and replacement cost to the default framework. 3) Browse to Tools / Batch item modification 4) Choose a file, or entire some barcodes in the text area 5) Ensure that the 'Populate fields with default values from default framework' is *not* checked 6) Click 'Continue' 7) Observe that the fields for cost and replacement cost are blank 8) Click the 'back' button on your browser 9) Check the checkbox to enable the default value 10) Click 'Continue' 11) Observe that the fields for cost and replacement cost now contain the default values you assigned them in the default MARC framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:41:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 15:41:19 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|chrish at catalyst.net.nz |fcapovilla at live.ca --- Comment #3 from Fr?d?rick Capovilla --- Created attachment 17871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17871&action=edit Add new features and tests to the budget duplication My colleague Maxime did a patch adding this feature to the budget duplication form. The patch also adds an option to transfer the ordered acquisitions into the new budget. Unit tests were also added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:44:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 15:44:31 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fcapovilla at live.ca |pelletiermaxime at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:48:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 15:48:41 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fcapovilla at live.ca Change sponsored?|--- |Sponsored --- Comment #4 from Fr?d?rick Capovilla --- Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 18:22:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 16:22:19 +0000 Subject: [Koha-bugs] [Bug 10166] New: Can't place holds on multiple titles if one or more are un-holdable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Bug ID: 10166 Summary: Can't place holds on multiple titles if one or more are un-holdable Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Hold requests Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org CC: gmcharlt at gmail.com Created attachment 17872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17872&action=edit Screenshot showing all holds blocked because 2 out of 3 are un-holdable When placing holds on multiple titles in the OPAC the entire operation is blocked if any one of those multiple titles cannot be placed on hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:51:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 18:51:14 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion --- Comment #103 from Galen Charlton --- Following Jared, I have also reverted the patches for this bug (and related bugs) from master. This should not be viewed as a permanent reversion, although I have reservations about turning on CGI.pm's -utf8 switch across the board -- but I have even stronger reservations about the ensuant game of whack-a-mole we've been playing with new bugs arising from this patch. By next week I will put together a separate integration branch to use as a basis for testing this more thoroughly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:56:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 18:56:41 +0000 Subject: [Koha-bugs] [Bug 10167] New: payment not showing what's paid for if not an item Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10167 Bug ID: 10167 Summary: payment not showing what's paid for if not an item Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When paying fines in 3.10.x it shows what was paid for if you pay for an item (something with a barcode). But if you pay for a line that you entered manually without an item it does not say what you paid for. For example: I created a manual invoice for Copier fees and then clicked 'Pay' on the line for the Copier fees and it recorded that as just 'Payment Thanks' instead of 'Payment Thanks - Copier Fees' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:57:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 18:57:59 +0000 Subject: [Koha-bugs] [Bug 10168] New: text myself a call number Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10168 Bug ID: 10168 Summary: text myself a call number Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com It would be cool if we could click a button to text ourselves (or someone else) a call number at the library. This should be an option from the cart next to each item or a way to send the entire cart this way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:59:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 18:59:48 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:59:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 18:59:49 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 --- Comment #1 from Owen Leonard --- Created attachment 17873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17873&action=edit Bug 10166 - Can't place holds on multiple titles if one or more are un-holdable opac-reserve.pl tries to check whether all selected titles in a multiple-hold batch are unavailable to be placed on hold. However, the logic is flawed in such a way that if the last item in the batch cannot be placed on hold the script assumes none can be placed on hold. This patch modifies the way the script tracks the "no titles available for holds" variable in order to correct the error. To test, place multiple holds by selecting titles from a list of search results. Test three conditions: - All titles are available to be placed on hold You should see no onscreen warnings, and all titles should be selectable on the place hold screen. A "Place hold" button should appear at the bottom. - Some titles can be placed on hold, some cannot The titles which can be placed on hold should be selectable. Titles which cannot be placed on hold should show a warning message. A "Place hold" button should appear at the bottom. - No titles can be placed on hold "Sorry, none of these items can be placed on hold." should appear at the top of the page. All titles should appear with warning messages. There should be no "Place hold" button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 21:03:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 19:03:20 +0000 Subject: [Koha-bugs] [Bug 10169] New: Software error if one of multiple titles selected for hold in the OPAC has no items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10169 Bug ID: 10169 Summary: Software error if one of multiple titles selected for hold in the OPAC has no items Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org CC: gmcharlt at gmail.com If you select multiple titles to place on hold in the OPAC and at least one of them has no items you will get a nasty error: Can't call method "field" on an undefined value at C4/Items.pm line 1398. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 1 21:50:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 19:50:19 +0000 Subject: [Koha-bugs] [Bug 10169] Software error if one of multiple titles selected for hold in the OPAC has no items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10169 --- Comment #1 from Owen Leonard --- Created attachment 17874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17874&action=edit Bug 10169 [Incomplete] Software error if one of multiple titles selected for hold in the OPAC has no items This patch contains changes suggested by Jared on IRC. This eliminates the ugly error but raises a new problem: The 'Place hold' screen is now blank except for a warning: "ERROR: No biblio record found for biblionumber 5638." The warning is triggered by the variable "bad_biblionumber," set here (opac-reserve.pl lines 362+): # Get relevant biblio data. my $biblioData = $biblioDataHash{$biblioNum}; if (! $biblioData) { $template->param(message=>1, bad_biblionumber=>$biblioNum); &get_out($query, $cookie, $template->output); } I assume this is proper error-handling in the case of placing a single hold, but has never been revised to accommodate multiple holds? Not sure where to go next with it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 00:32:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 01 May 2013 22:32:18 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #9 from Bernardo Gonzalez Kriegel --- Janusz, I don't know much about catalographic rules, but I can check if values verify expected behaviour. I tested every combination suggested by current mapping in Koha, could you check if those are the expected values? Test - Bug 5262 - MARC21 1) Add one authority for each kind, with values in both indicators (ind1=1, ind2=2) PERSO_NAME 100a CORPO_NAME 110a MEETI_NAME 111a UNIF_TITLE 130a CHRON_TERM 148a TOPIC_TERM 150a GENRE/FORM 155a GEOGR_NAME 151a 2) New biblio record, default framework all indicators clean 3) Use cases, mapping from default MARC21 framework, for each auth kind, results ( 1, 2, 7, - for empty) 008/11 = a and r (results separated by |) a) PERSO_NAME 100 BIB IND1 IND2 100 1 -|- 600 1 0|7 696 1 0|7 700 1 -|- 796 1 -|- 800 1 -|- 896 1 -|- b) CORPO_NAME 110 BIB IND1 IND2 110 1 -|- 610 1 0|7 697 1 0|7 710 1 -|- 797 1 -|- 810 1 -|- 897 1 -|- c) MEETI_NAME 111 BIB IND1 IND2 111 1 -|- 611 1 0|7 698 1 0|7 711 1 -|- 798 1 -|- 811 1 -|- 898 1 -|- d) CHRON_TERM 148 BIB IND1 IND2 648 1 0|7 e) GENRE/FOMR 155 BIB IND1 IND2 655 - 0|7 f) GEOGR_NAME 151 BIB IND1 IND2 651 1 0|7 662 1 0|7 691 1 0|7 h) UNIF_TITLE 130 BIB IND1 IND2 130 2 -|- 440 2 -|- 490 2 -|- 630 2 0|7 699 2 0|7 730 2 -|- 799 2 -|- 830 - 2|2 899 2 -|- i) TOPIC_TERM 150 BIB IND1 IND2 650 1 0|7 654 1 0|7 656 1 0|7 657 1 0|7 658 1 0|7 690 1 0|7 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 03:21:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 01:21:15 +0000 Subject: [Koha-bugs] [Bug 10141] Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #1 from Bernardo Gonzalez Kriegel --- One fast (albeit ugly) solution could be add in xml an individual entry for each position. xmlControlfield.js write a input text without options if description has a '-' (dash). Result in attached image. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 03:22:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 01:22:18 +0000 Subject: [Koha-bugs] [Bug 10141] Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 17875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17875&action=edit field 008 with decomposed Illustration options -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 03:56:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 01:56:01 +0000 Subject: [Koha-bugs] [Bug 10141] Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 --- Comment #3 from Bernardo Gonzalez Kriegel --- Created attachment 17876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17876&action=edit field 008 with multiple options This image describe another possible solution, but this requires some JS wizardry to work. Something like this could also be used to dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 04:33:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 02:33:52 +0000 Subject: [Koha-bugs] [Bug 10149] koha-restart-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10149 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 04:33:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 02:33:51 +0000 Subject: [Koha-bugs] [Bug 10104] koha-disable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10104 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 04:33:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 02:33:53 +0000 Subject: [Koha-bugs] [Bug 10101] koha-enable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10101 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 04:33:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 02:33:53 +0000 Subject: [Koha-bugs] [Bug 10041] Provide a koha-translate script to aid package users on installing translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10041 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 04:33:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 02:33:53 +0000 Subject: [Koha-bugs] [Bug 10144] koha-start-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10144 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 04:33:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 02:33:54 +0000 Subject: [Koha-bugs] [Bug 9250] Provide commands to allow handling of SIP servers in the packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9250 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 04:39:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 02:39:32 +0000 Subject: [Koha-bugs] [Bug 10070] History of anonymous searches is not kept In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #16 from Jared Camins-Esakov --- This patch only works on 3.12.x for me, even after 6554 has been reverted from master. I am going to push it to master, and defer a decision about what to do with this bug in master to the 3.14 RM. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 04:40:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 02:40:41 +0000 Subject: [Koha-bugs] [Bug 10070] History of anonymous searches is not kept In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |3.14 --- Comment #17 from Jared Camins-Esakov --- This patch has been pushed directly to 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 04:59:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 02:59:03 +0000 Subject: [Koha-bugs] [Bug 10044] Doubled up paging on order receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10044 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 06:04:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 04:04:04 +0000 Subject: [Koha-bugs] [Bug 10141] Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 --- Comment #4 from David Cook --- (In reply to comment #2) > Created attachment 17875 [details] > field 008 with decomposed Illustration options Visually, I think that this [the decomposed options] might be the best option. It allows users to see the code and the description of the code, so as to easily make informed decisions. My only concern might be in the label for the positions. "18 - Illustrations - code 1" might be better than "18 - Illustrations position 1". It's not very optimal to have separate entries for 18, 19, 20, 21, but I assume it might not be possible to give one XML element several position attributes. I suppose the 18-21 and 24-27 positions might be special cases, so maybe having separate XML elements for each position within those ranges is acceptable...especially if it means that we're providing a validated list of options to users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 06:09:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 04:09:38 +0000 Subject: [Koha-bugs] [Bug 10150] koha-email-disable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10150 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 06:09:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 04:09:41 +0000 Subject: [Koha-bugs] [Bug 10150] koha-email-disable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10150 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17826|0 |1 is obsolete| | --- Comment #4 from Mason James --- Created attachment 17877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17877&action=edit Bug 10150 - koha-email-disable error handling koha-email-disable now - Checks the instance exists. - Checks if email is already disabled. Regards To+ Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Chris Cormack Signed-off-by: Mason James -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 06:10:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 04:10:13 +0000 Subject: [Koha-bugs] [Bug 10150] koha-email-disable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10150 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #5 from Mason James --- > Signed-off-by: Chris Cormack > Signed-off-by: Mason James passing QA on this patch... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 06:48:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 04:48:52 +0000 Subject: [Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 06:48:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 04:48:55 +0000 Subject: [Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17567|0 |1 is obsolete| | --- Comment #8 from Mason James --- Created attachment 17878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17878&action=edit Bug 10084 - YUI path wrong in CCSR theme with packages Bug 9052 fixed this for prog, CCSR was left aline in the dark (it's friday). Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Worked fine in my test package, good work Tomas Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 08:43:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 06:43:41 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #104 from M. de Rooy --- (In reply to comment #103) > Following Jared, I have also reverted the patches for this bug (and related > bugs) from master. This should not be viewed as a permanent reversion, > although I have reservations about turning on CGI.pm's -utf8 switch across > the board -- but I have even stronger reservations about the ensuant game of > whack-a-mole we've been playing with new bugs arising from this patch. > > By next week I will put together a separate integration branch to use as a > basis for testing this more thoroughly. Here is my reaction on this action from you as new RM: I have spent a lot of time on helping to resolve the side-effects of this patch and you revert this without any discussion! I triggered a discussion on the subject by mailing the list and you did not even respond. Jared planned to revert the patch for 3.12.x but leave it in master. And even more, this work is being compared with some game I do not know about. On the whole: This is very discouraging and highly unmotivating. Please communicate with other developers and team members instead of starting your RM term with one-sided actions like this one. Do you think that this makes me spend more time on the subject? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 08:46:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 06:46:44 +0000 Subject: [Koha-bugs] [Bug 10128] Encoding problem when Search for an Authority to add to a bib record with non-latin characters the data re filled in form looks bad but the results good In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10128 --- Comment #2 from M. de Rooy --- (In reply to comment #1) > I test this on 3.12 the problem is not exist > > the problem is just on master . > > Regards See bug 6554. It is reverted now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 09:04:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 07:04:03 +0000 Subject: [Koha-bugs] [Bug 10114] Encoding problems in Search url's In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10114 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6554 Summary|Double encoding problems |Encoding problems in Search |caused by uri_escape_utf8 |url's --- Comment #1 from M. de Rooy --- I have been working on this while its base was reverted. My first comment is not the whole story: it looks like the uri_escape_utf8 calls can be left alone but some attention needs to be given at the other side. Will suspend further work on this for now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 09:04:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 07:04:04 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10114 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 09:54:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 07:54:38 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17870|0 |1 is obsolete| | --- Comment #6 from David Cook --- Created attachment 17879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17879&action=edit [Signed Off] Bug 9533 - batch item modification should ignore defaults This patch makes the pre-population of the fields for the batch item editor with the default values from the default framework optional and off by default. Test Plan: 1) Apply patch 2) Add default values for cost and replacement cost to the default framework. 3) Browse to Tools / Batch item modification 4) Choose a file, or entire some barcodes in the text area 5) Ensure that the 'Populate fields with default values from default framework' is *not* checked 6) Click 'Continue' 7) Observe that the fields for cost and replacement cost are blank 8) Click the 'back' button on your browser 9) Check the checkbox to enable the default value 10) Click 'Continue' 11) Observe that the fields for cost and replacement cost now contain the default values you assigned them in the default MARC framework Signed-off-by: David Cook -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 09:55:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 07:55:03 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook at prosentient.com.au --- Comment #7 from David Cook --- Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:22:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:22:07 +0000 Subject: [Koha-bugs] [Bug 10170] New: non translatable strings in manage-marc-import (actions and table values) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Bug ID: 10170 Summary: non translatable strings in manage-marc-import (actions and table values) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: adrien.saurat at biblibre.com Created attachment 17880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17880&action=edit non translatable strings The bug 9215 enabled the translation of the "Status" information in the manage-marc-import page. But the same problem remains with other strings in this page. See screenshot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:22:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:22:53 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |9215 Assignee|oleonard at myacpl.org |adrien.saurat at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:22:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:22:53 +0000 Subject: [Koha-bugs] [Bug 9215] non translatable string in manage-marc-import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9215 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10170 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:30:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:30:38 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #9 from Jonathan Druart --- (In reply to comment #8) > Hello Jonathan. > I signed off 10044. > For the improvement of filters, I think your patch is a duplicate of a patch > I wrote some weeks ago : > http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9560 > Could you take a look at it please? > > Mathieu Mathieu, My patch adds a filter for the basket group *name*, not number. So it is not really the same filter. I think it is more useful to search by name instead of number. Moreover, my patches add filter on the table itself too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:35:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:35:06 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |dcook at prosentient.com.au --- Comment #20 from David Cook --- Hey Kyle, I couldn't get the patch to apply on the latest master. Applying: Bug 8735 - Expire holds waiting only on days the library is open Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Failed to merge in the changes. As for the actual bug, I'm not sure that I could reproduce it. Before applying the patch, I used your test plan to the letter (expecting for my hold to disappear on a holiday), but when I set my "waiting date" to yesterday and ran "misc/cronjobs/holds/cancel_expired_holds.pl", it didn't clear out the reserve (regardless of the day being a holiday). If I set it for the day before yesterday (both as a holiday and not), I got: DBD::mysql::st execute failed: Duplicate entry '60' for key 'PRIMARY' at dev/lib//C4/Reserves.pm line 1051. It cleared out the entry from the reserves table, but that doesn't seem very elegant. Is that how it's supposed to look? -- I guess what I'm asking is...could your test plan include a "Before patch" and an "After patch" so that I can see what buggy behaviour is being fixed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:35:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:35:16 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #10 from mathieu saby --- I think searching by basketgroup number could be a good option too. For example, it is needed in Rennes 2, because we classify printed basketgroups using there number, and we use this number in our relations with vendors ;-) But I am ok with your patch. I could rewrite mine later, only to add a filter by bg number, and we will see if the community agrees. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:40:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:40:15 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #17 from Julian Maurice --- Created attachment 17881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17881&action=edit Bug 8918: Fix the transit case in HoldItem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:40:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:40:20 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #18 from Julian Maurice --- Created attachment 17882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17882&action=edit Bug 8918: Move $rank and $found calculation into AddReserve and update scripts that call it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:40:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:40:26 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #37 from Jonathan Druart --- (In reply to comment #36) > My first tests are good, but in search results, you add an column for > ordernumber in the html table. > Ordernumber is already present in the table on 1st column. > So I suppose you wanted to display funds, and not ordernumber ? > > M. Saby Mathieu, In fact the first column is the parent order number, not the order number. I agree with you, it is not clear. The fund column is already added by the first patch. A patch is coming... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:40:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:40:37 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #38 from Jonathan Druart --- Created attachment 17883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17883&action=edit Bug 5336: Merge parent ordernumber and ordernumber columns -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:40:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:40:52 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:45:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:45:41 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #19 from Julian Maurice --- To test: - Try to hold a title with ILS-DI - Try to hold an item with ILS-DI (with syspref ReservesNeedReturns on and off) - Try to hold a title from the staff interface - Try to hold an item from the staff interface (with syspref ReservesNeedReturns on and off) - Try to hold a title from OPAC - Try to hold an item from OPAC (with syspref ReservesNeedReturns on and off For each test, check that the rank is correctly set. If ReservesNeedReturns is off and you hold a specific item, check that reserves.found is correctly to set to 'W' (waiting to be pulled) or 'T' (in transit), depending on the chosen pickup location -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:58:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:58:01 +0000 Subject: [Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 --- Comment #3 from Jonathan Druart --- (In reply to comment #2) > This patch breaks display of existing approved tags and of local star > ratings. When I apply this patch I no longer see approved tags in search > results, and all star ratings indicators are grey even for titles which have > ratings. Owen, thanks for testing. I cannot reproduce but I found some inconsistent things. There are 3 'next' statements which might cause problems. I will provide a new patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:58:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:58:17 +0000 Subject: [Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 10:58:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 08:58:19 +0000 Subject: [Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17716|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 17884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17884&action=edit Bug 10129: Babeltheque does not depend on COinSinOPACResults This patch groups all loops on the new_results array into one. It is useless to loop on the same results array several times. Test plan: Quite hard to test all cases. This patch deals with 5 sysprefs: COinSinOPACResults, Babeltheque, TagsEnabled, TagsShowOnList and OpacStarRatings. Try to enable/disable all of them and verify there is no difference with and without this patch. The only different will be: The Babeltheque information should be displayed even if the COinSinOPACResults syspref is disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:03:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:03:21 +0000 Subject: [Koha-bugs] [Bug 10171] New: Add a header in Advanced Search (staff interface) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171 Bug ID: 10171 Summary: Add a header in Advanced Search (staff interface) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: mathieu.saby at univ-rennes2.fr There is no header in Advanced Search page (search.pl) I don't see why, as it could be interesting to have the ability to make a checkin or checkout from this page. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:06:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:06:52 +0000 Subject: [Koha-bugs] [Bug 10171] Add a header in Advanced Search (staff interface) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10171 --- Comment #1 from mathieu saby --- (The design of advanced search page could be improved too : lot of wasted space, need to scroll for accessing the buttons.... But it deserves an other bug) M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:12:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:12:16 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17824|0 |1 is obsolete| | --- Comment #5 from David Cook --- Created attachment 17885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17885&action=edit [Signed off] Bug 10120 : Adding a syspref to control if overdue charges are updated /on return On by default, To Test 1/ Create an overdue item, that should get fines 2/ Return the item 3/ Check the borrowers record to see if the fine has been added/updated Apply patch 1/ Make sure preference is set to do Repeat steps 1-3 above 2/ Switch the preference to don't Repeat stes 1-2 3/ Check the fine hasn't been added/updated Signed-off-by: David Cook -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:15:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:15:05 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17885|0 |1 is obsolete| | --- Comment #6 from David Cook --- Created attachment 17886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17886&action=edit [Signed off] Bug 10120 : Adding a syspref to control if overdue charges are updated /on return On by default, To Test 1/ Create an overdue item, that should get fines 2/ Return the item 3/ Check the borrowers record to see if the fine has been added/updated Apply patch 1/ Make sure preference is set to do Repeat steps 1-3 above 2/ Switch the preference to don't Repeat stes 1-2 3/ Check the fine hasn't been added/updated Signed-off-by: David Cook -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:15:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:15:15 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17825|0 |1 is obsolete| | --- Comment #7 from David Cook --- Created attachment 17887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17887&action=edit [Signed off] Bug 10120 : Tidy up the code so we can see what is going on Signed-off-by: David Cook -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:17:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:17:20 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook at prosentient.com.au --- Comment #8 from David Cook --- Works as described. I doubt a library would want to have this system preference on for any case except hourly loans, but since there is no way to tell if a loan is hourly or not, this binary method is the best we've got. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:24:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:24:12 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13472|0 |1 is obsolete| | Attachment #15435|0 |1 is obsolete| | Attachment #17376|0 |1 is obsolete| | --- Comment #20 from Julian Maurice --- Created attachment 17888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17888&action=edit [SIGNED-OFF] Bug 8918: ILS-DI: Calculate rank when placing hold This is a squash of the 3 following patches Bug 8918: ILS-DI: Calculate rank when placing hold Signed-off-by: Srikanth Dhondi -- Bug 8918: QA fixes - Move C4::ILSDI::_get_reserve_next_rank to C4::Reserves::GetReserveNextRank - Do not calculate rank if ReservesNeedReturns = 0 Signed-off-by: Chris Cormack -- 8918 QA Followup for pref descriptions Updating pref descriptions for ReservesNeedReturns and ILS-DI:AuthorizedIPs. Just sideway related to this report, but not important enough to separate. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:24:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:24:21 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17881|0 |1 is obsolete| | --- Comment #21 from Julian Maurice --- Created attachment 17889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17889&action=edit Bug 8918: Fix the transit case in HoldItem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:24:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:24:27 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17882|0 |1 is obsolete| | --- Comment #22 from Julian Maurice --- Created attachment 17890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17890&action=edit Bug 8918: Move $rank and $found calculation into AddReserve and update scripts that call it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:25:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:25:51 +0000 Subject: [Koha-bugs] [Bug 9826] Missing fields in MARC21 authority framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9826 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- (In reply to comment #1) > Created attachment 16174 [details] [review] > Bug 9826 - Missing fields in MARC21 authority framework > > This patch updates MARC21 authority framework adding > missing tags/subtags up to Update No. 15 (September 2012) > > Missing tags and corresponding subtags only added to > default authority framework. > > For present authtypes only missing subtags are added. > > Also updates a few legends to match those from LOC. > > No deletions except for a few not relevant tags in > present authtypes without subfields. > > Only to new installs. > > To test: > 1) Delete present authority frameworks > 2) Load new frameworks. On default there are > many new tags/subtags. On present authtypes > only a few new/renamed subtags. Could you give some more detailed instructions on how to go about deleting and loading authority frameworks? Am I clearing out "auth_types", "auth_tag_structure" and "auth_subfield_structure" and then running ".../marc21/mandatory/authorities_normal_marc21.sql"? Also, what are some new tags/subtags that I should be looking for? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:30:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:30:25 +0000 Subject: [Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook --- Jonathan: I'm interested in testing your patch, but I'm not sure how to get Babeltheque information to display (is it simply enough to turn on the system preference? Are there some known items that I could import via z39.50 to use to test this?). Also, what types of information should be displaying? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:31:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:31:28 +0000 Subject: [Koha-bugs] [Bug 10118] [MASTER_ONLY] Problem with diacritics on 'pay fines' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10118 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- Aren't there currently diacritic problems across the whole of master at the moment? I think Jared posted something about 3.12 being ok, but there being issues across master. I noticed that the French diacritics weren't displaying correctly in the system preferences for Babeltheque... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:31:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:31:47 +0000 Subject: [Koha-bugs] [Bug 9169] Wrap relator code in to allow for CSS customization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #10 from mathieu saby --- I think a followup would be usefull for Unimarc. I will make a new bug for it. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:43:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:43:34 +0000 Subject: [Koha-bugs] [Bug 10172] New: The MARC Preview link could be hidden when printing a record Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Bug ID: 10172 Summary: The MARC Preview link could be hidden when printing a record Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: mathieu.saby at univ-rennes2.fr When you print a record, you can see the new "MARC Preview" link under the record. It is useless, as you can click on your sheet of paper ;-) M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:47:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:47:02 +0000 Subject: [Koha-bugs] [Bug 10070] History of anonymous searches is not kept In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #18 from M. de Rooy --- (In reply to comment #16) > This patch only works on 3.12.x for me, even after 6554 has been reverted > from master. I am going to push it to master, and defer a decision about > what to do with this bug in master to the 3.14 RM. The binmode line in C4/Output.pm makes the difference in sub output_html_with_http_headers. Remove it from master. I wasn't too happy with a binmode there anyway.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:49:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:49:29 +0000 Subject: [Koha-bugs] [Bug 10118] [MASTER_ONLY] Problem with diacritics on 'pay fines' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10118 --- Comment #3 from M. de Rooy --- (In reply to comment #2) > Aren't there currently diacritic problems across the whole of master at the > moment? I think Jared posted something about 3.12 being ok, but there being > issues across master. > > I noticed that the French diacritics weren't displaying correctly in the > system preferences for Babeltheque... Bug 6554 has been reverted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:54:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:54:07 +0000 Subject: [Koha-bugs] [Bug 10173] New: Followup of 9169 for Unimarc: Wrap function code in Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10173 Bug ID: 10173 Summary: Followup of 9169 for Unimarc: Wrap function code in Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: mathieu.saby at univ-rennes2.fr In UNIMARC, it could be usefull to add a span arroud $4 of 7XX fields, like bug 9169 did for Marc21. Files to change : opac-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl intranet-tmpl/prog/en/xslt/UNIMARCslimUtils.xsl M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:54:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:54:13 +0000 Subject: [Koha-bugs] [Bug 10173] Followup of 9169 for Unimarc: Wrap function code in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10173 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 11:54:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 09:54:19 +0000 Subject: [Koha-bugs] [Bug 10173] Followup of 9169 for Unimarc: Wrap function code in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10173 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 12:35:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 10:35:20 +0000 Subject: [Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7470 --- Comment #6 from Jonathan Druart --- (In reply to comment #5) > Jonathan: > > I'm interested in testing your patch, but I'm not sure how to get > Babeltheque information to display (is it simply enough to turn on the > system preference? Are there some known items that I could import via z39.50 > to use to test this?). > > Also, what types of information should be displaying? David, Babeltheque is a service for french libraries. It requires a account for testing it, so it is not possible to test this feature. But it is possible to test features related to others syspref. I apply the patch on a vm where the feature is configured: http://catalogue.master33-dev.biblibre.com/cgi-bin/koha/opac-search.pl?q=harry Syspref values are: COinSinOPACResults = 0 Babeltheque = 1 TagsEnabled = 1 TagsShowOnList = 6 OpacStarRatings = all Code is based on master + this patch. I just found a bug on the detail page when Babeltheque is enabled (js error), I will open a new report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 12:35:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 10:35:20 +0000 Subject: [Koha-bugs] [Bug 7470] Babeltheque improvement and social networks links (like, +1, ...) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7470 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10129 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 13:28:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 11:28:37 +0000 Subject: [Koha-bugs] [Bug 10141] Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 17891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17891&action=edit Bug 10141 - Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin Easy workaround This patch expands both options, Illustrations and Nature of.., so each position could be filled independently. To test: 1) edit or add a new recod 2) click on field 008 value builder, positions 18-21 and 24-27 only show an input text box 3) apply the patch 4) reload value_builder page, now each position (18-21,24-27) has it's own pulldown. A similar fix could be used in a similar problem in 006 value builder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 13:31:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 11:31:50 +0000 Subject: [Koha-bugs] [Bug 10141] Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 13:48:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 11:48:32 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16508|0 |1 is obsolete| | Attachment #17625|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 17892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17892&action=edit Bug 8735 - Expire holds waiting only on days the library is open Signed-off-by: Leila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 13:48:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 11:48:44 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 13:48:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 11:48:46 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 --- Comment #22 from Kyle M Hall --- Created attachment 17893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17893&action=edit Bug 8735 - Expire holds waiting only on days the library is open - Followup - Switch from C4::Calendar to Koha::Calendar Test Plan: 1) Set ExpireReservesMaxPickUpDelay 2) Set ReservesMaxPickUpDelay to 1 3) Place a hold, set it to waiting 4) Using the MySQL console, modify the waiting date and set it to the day before yesterday. 5) Set today as a holiday for the pickup branch in question. 6) Run misc/cronjobs/holds/cancel_expired_holds.pl 7) The hold should remain unchanged 8) Remove today as a holiday 9) Run misc/cronjobs/holds/cancel_expired_holds.pl again 10) The hold should now be canceled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 13:53:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 11:53:16 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 --- Comment #23 from Kyle M Hall --- > As for the actual bug, I'm not sure that I could reproduce it. Before > applying the patch, I used your test plan to the letter (expecting for my > hold to disappear on a holiday), but when I set my "waiting date" to > yesterday and ran "misc/cronjobs/holds/cancel_expired_holds.pl", it didn't > clear out the reserve (regardless of the day being a holiday). If I set it > for the day before yesterday (both as a holiday and not), I got: > > DBD::mysql::st execute failed: Duplicate entry '60' for key 'PRIMARY' at > dev/lib//C4/Reserves.pm line 1051. > > It cleared out the entry from the reserves table, but that doesn't seem very > elegant. Is that how it's supposed to look? The test plan should have had "the day before yesterday" instead of "yesterday". I don't know why you would be getting an error like that ( I get no errors when I test this patch ), but it sounds like your reserves and old_reserves tables are messed up. I think you may have duplicate reserve_id's between the two tables, which would cause that error. I do not believe your error has anything to do with this patch though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 13:59:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 11:59:37 +0000 Subject: [Koha-bugs] [Bug 9826] Missing fields in MARC21 authority framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9826 --- Comment #3 from Bernardo Gonzalez Kriegel --- This patch only touch 'default' framework, perhaps I can do another bug that updates example frameworks. For bib frameworks there are 2 files, for auth there is only one. To delete present auth framework: mysql -ukohauser -pkohapass kohadb -e "delete from auth_subfield_structure; delete from auth_tag_structure; delete from auth_types;" To add the new ones: mysql -ukohauser -pkohapass kohadb < $PATH/authorities_normal_marc21.sql What's new: Look in diff view, http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16174&action=diff All green is new + subtags for 368~384 All lightBlue is modification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 15:06:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 13:06:20 +0000 Subject: [Koha-bugs] [Bug 10174] New: Digest is confusing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 Bug ID: 10174 Summary: Digest is confusing Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com At every training I get asked what 'Digest' means in reference to notices. I always explain it and people still aren't sure they get it. If you don't subscribe to a lot of mailing lists you're not really used to that language. The concern is that patrons will also be confused by this. The library I'm at suggested 'Group' instead of 'Digest' - can anyone else think of other language that might work? Or even a reason why we wouldn't want all enhanced messages to be digests? As it is only 2 have the option of being a 'Digest' or not - so not make them all Digests and be done with it? Just starting a discussion here to try and make this the most user-friendly for the patrons. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 15:18:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 13:18:52 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #4 from Fridolyn SOMERS --- (In reply to comment #3) > Fridolyn, I suppose the 1st attachment is obsolete? No, 1st attachement is the main patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 15:37:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 13:37:58 +0000 Subject: [Koha-bugs] [Bug 9979] convert ./C4/Installer/PerlDependencies.pm into a YAML file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Mason, could you rebase your patch against master please? qa comment: I think the yaml file should be somewhere else than into a C4 sub-directory. But I don't have a better suggestion... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 15:54:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 13:54:19 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- Maybe should we enable the checkbox by default? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 15:57:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 13:57:11 +0000 Subject: [Koha-bugs] [Bug 10173] Followup of 9169 for Unimarc: Wrap function code in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10173 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9169 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 15:57:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 13:57:11 +0000 Subject: [Koha-bugs] [Bug 9169] Wrap relator code in to allow for CSS customization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9169 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10173 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 16:02:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 14:02:41 +0000 Subject: [Koha-bugs] [Bug 10175] New: Software error in opac-detail.pl when CGISESSID cookie is not set Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10175 Bug ID: 10175 Summary: Software error in opac-detail.pl when CGISESSID cookie is not set Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: julian.maurice at biblibre.com Steps to reproduce: 1. Remove CGISESSID cookie (for Firefox: Edit ? Preferences ? Privacy ? Remove specific cookie) 2. Go directly to this URL: http://YOUROPACBASEURL/cgi-bin/koha/opac-detail.pl?biblionumber=X (where X is a valid biblionumber) Message: Software error: Can't use an undefined value as a HASH reference at /home/koha/src/opac/opac-detail.pl line 445. This is related to bug 8197 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 16:03:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 14:03:15 +0000 Subject: [Koha-bugs] [Bug 8197] Software error when you have cleaned cookies in your browser and try to past the url to opac-topissues.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8197 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10175 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 16:03:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 14:03:15 +0000 Subject: [Koha-bugs] [Bug 10175] Software error in opac-detail.pl when CGISESSID cookie is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10175 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8197 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 16:26:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 14:26:31 +0000 Subject: [Koha-bugs] [Bug 10176] New: Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176 Bug ID: 10176 Summary: Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: karamqubsi at gmail.com When we have list of results with UNICODE symbols, like Arabic or other The URLs in the 'Refine Search' is looks like this : http://5.0.85.204:75/cgi-bin/koha/opac-search.pl?idx=kw&q=????&sort_by=relevance_dsc&limit=au: ?? ? ? ? ??? ? ? ? . so no results when click on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 16:46:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 14:46:03 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #113 from Jonathan Druart --- All still looks good. I rebased patches (some conflicts). I will provide a followup in order to fix an ergonomic issue: on the course detail page, if ccode, location, etc. are unchanged and no value exist, the cell contains "Unchanged ()". I don't see any reasons not to pass QA this feature: all remarks had taken into account. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 16:47:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 14:47:07 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17333|0 |1 is obsolete| | Attachment #17334|0 |1 is obsolete| | Attachment #17377|0 |1 is obsolete| | Attachment #17378|0 |1 is obsolete| | Attachment #17379|0 |1 is obsolete| | --- Comment #114 from Jonathan Druart --- Created attachment 17894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17894&action=edit Bug 8215 - Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Test Plan: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. Signed-off-by: Kyle M Hall Signed-off-by: Corinne Bulac Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 16:47:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 14:47:16 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #115 from Jonathan Druart --- Created attachment 17895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17895&action=edit Bug 8215 follow-up encoding for branches & itemtypes Signed-off-by: Kyle M Hall Signed-off-by: Corinne Bulac Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 16:47:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 14:47:21 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #116 from Jonathan Druart --- Created attachment 17896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17896&action=edit Bug 8215: Followup FIX QA issues Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 16:47:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 14:47:27 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #117 from Jonathan Druart --- Created attachment 17897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17897&action=edit Bug 8215 - Add Course Reserves - QA Followup Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 16:47:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 14:47:32 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #118 from Jonathan Druart --- Created attachment 17898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17898&action=edit Bug 8215: Followup Fix confirmation links for delete course and item Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 16:47:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 14:47:38 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #119 from Jonathan Druart --- Created attachment 17899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17899&action=edit Bug 8215: FIX ergonomic issue : 'Unchanged()' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:02:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:02:22 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 --- Comment #1 from Adrien SAURAT --- Created attachment 17900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17900&action=edit proposed patch #1 [MT11604] Like in bug 9215, the new strings begin with a capital letter. It's thus possible to check the new behaviour even if you stay in English mode. The five fields showed in the screenshot use now string in templates which can be translated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:04:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:04:10 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:10:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:10:06 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14977|0 |1 is obsolete| | Attachment #14978|0 |1 is obsolete| | Attachment #14979|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall --- Created attachment 17901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17901&action=edit Bug 7441 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:10:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:10:15 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #37 from Kyle M Hall --- Created attachment 17902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17902&action=edit Bug 7441: Followup search results showing wrong branch [UNIMARC] Unimarc modifications Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:10:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:10:27 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:10:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:10:29 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #38 from Kyle M Hall --- Created attachment 17903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17903&action=edit Bug 7441 - search results showing wrong branch? - Followup - Use syspref for XSLT and non-XSLT Signed-off-by: Bernardo Gonzalez Kriegel Comment: Applied all patches. Tested with and without XLST display. Works as described. No errors. Not tested with UNIMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:11:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:11:10 +0000 Subject: [Koha-bugs] [Bug 10101] koha-enable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10101 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:11:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:11:11 +0000 Subject: [Koha-bugs] [Bug 4876] Rewrite koha-* scripts in Perl, with error checking - omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4876 Bug 4876 depends on bug 10101, which changed state. Bug 10101 Summary: koha-enable error handling http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10101 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:11:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:11:58 +0000 Subject: [Koha-bugs] [Bug 10104] koha-disable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10104 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:11:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:11:58 +0000 Subject: [Koha-bugs] [Bug 4876] Rewrite koha-* scripts in Perl, with error checking - omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4876 Bug 4876 depends on bug 10104, which changed state. Bug 10104 Summary: koha-disable error handling http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10104 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:12:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:12:41 +0000 Subject: [Koha-bugs] [Bug 10144] koha-start-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10144 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:12:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:12:42 +0000 Subject: [Koha-bugs] [Bug 4876] Rewrite koha-* scripts in Perl, with error checking - omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4876 Bug 4876 depends on bug 10144, which changed state. Bug 10144 Summary: koha-start-zebra error handling http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10144 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:13:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:13:33 +0000 Subject: [Koha-bugs] [Bug 4876] Rewrite koha-* scripts in Perl, with error checking - omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4876 Bug 4876 depends on bug 10149, which changed state. Bug 10149 Summary: koha-restart-zebra error handling http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10149 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:13:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:13:31 +0000 Subject: [Koha-bugs] [Bug 10149] koha-restart-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10149 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:15:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:15:58 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #39 from Kyle M Hall --- > * in the 3rd patch, the Koha/Template/Plugin/Koha.pm is improperly named I > think, it should be Systempreference.pm or something more meaningful than > "Koha". I think we need a Koha-level TT plugin the same way we have a Koha.pm. It should be a place to put all the once-off plugin logic that does not have multiple functions. If we have a separate TT plugin for each action like this, we will end up with a dozen or more plugins, each of which will need a USE line at the top of each template. That seems unnecessary, doesn't it? [% Koha.Preference( PrefName ) %] seems more clean and sensible than [% KohaPreferences.Preference( PrefName ) %]. If you disagree with my logic here, just reset the status to Failed QA and I will make the requested modifications. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:18:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:18:16 +0000 Subject: [Koha-bugs] [Bug 10094] koha-list should have an --disabled option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10094 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4876 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:18:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:18:16 +0000 Subject: [Koha-bugs] [Bug 4876] Rewrite koha-* scripts in Perl, with error checking - omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4876 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10094 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 17:20:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 15:20:35 +0000 Subject: [Koha-bugs] [Bug 10094] koha-list should have an --disabled option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10094 --- Comment #4 from Tom?s Cohen Arazi --- I have set this bug as blocker for bug 4876 as it comprises a rewrite of the koha-list script also. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 18:05:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 16:05:00 +0000 Subject: [Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 --- Comment #1 from Jared Camins-Esakov --- Created attachment 17904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17904&action=edit Bug 9961: Add truncation support to QP driver The original implementation of QueryParser did not handle truncation based on the QueryAutoTruncate system preference. This patch adds support. To test: 1) Apply patch. 2) Turn on UseQueryParser. 3) Set QueryAutoTruncate to "automatically." 4) Search for "har". Note that it returns results with words like "Harry" (i.e. with right truncation). 5) Search for "har*". Note that it still returns results with right truncation. 6) Set QueryAutoTruncate to "only when * is added." 7) Search for "har". Note that it returns only records that have the exact word "har" in them (most likely there will be none unless you have Hebrew items). 8) Search for "har*". Note that once again it returns results for "Harry" (i.e. right truncated results). 9) Sign off. This patch also reindents a hash in Koha/QueryParser/Driver/PQF.pm because it was hard to read before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 18:04:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 16:04:59 +0000 Subject: [Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 19:21:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 17:21:43 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 19:21:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 17:21:48 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14744|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall --- Created attachment 17905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17905&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 19:25:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 17:25:10 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11430|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 19:25:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 17:25:16 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11431|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 19:27:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 17:27:39 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17905|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 17906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17906&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 19:34:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 17:34:16 +0000 Subject: [Koha-bugs] [Bug 10107] opacbookbag shouldn't prevent from adding items to a list in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10107 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 20:18:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 18:18:38 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17517|0 |1 is obsolete| | Attachment #17518|0 |1 is obsolete| | --- Comment #46 from Kyle M Hall --- Created attachment 17907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17907&action=edit Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set "Block expired patrons" to "Don't block" 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set "Block expired patrons" to "Follow system preference BlockExpiredPatronOpacActions" 9) Set the system preference BlockExpiredPatronOpacActions to "Block" 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to "Don't block" 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall Signed-off-by: Melia Meggs -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 20:18:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 18:18:52 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #47 from Kyle M Hall --- Created attachment 17908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17908&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 20:19:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 18:19:06 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #48 from Kyle M Hall --- Created attachment 17909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17909&action=edit Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 20:19:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 18:19:04 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 20:23:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 18:23:06 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #49 from Kyle M Hall --- Comment on attachment 17909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17909 Bug 6739 - expired patrons not blocked from opac actions - Followup 2 Review of attachment 17909: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6739&attachment=17909) ----------------------------------------------------------------- Most of the changes in opac-user.tt are whitespace cleanup. I've marked out the actual changes. ::: koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt @@ +70,3 @@ > }); > + > + [% IF ( canrenew && !userdebarred && OpacRenewalAllowed && !( borrower.is_expired && borrower.BlockExpiredPatronOpacActions ) ) %] This line fixes the renewal links bug. @@ +132,4 @@ > Please note: > > Your account renewal failed because of the following: > + [% FOREACH error IN RENEW_ERROR.split('\|') %] The pipe character needed escaping, otherwise it was split into an array of single characters. @@ +205,5 @@ > + [% END %] > + > + Call No. > + > + [% IF OpacRenewalAllowed && !( borrower.is_expired && borrower.BlockExpiredPatronOpacActions ) %] Here is another actual change. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 20:34:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 18:34:40 +0000 Subject: [Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 20:34:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 18:34:42 +0000 Subject: [Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14186|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 17910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17910&action=edit Bug 9231 - Batch revert staged MARC records fails if one or more records in a batch have been deleted. If a record in an imported batch is dleted, any attempt to revert the batch will result in the progress bar never reaching 100%. The background job dies when it hits the already deleted record, with the error occurring in C4::Items::DelItem for the line: $copy2deleted->execute( $record->as_usmarc(), $itemnumber ); which fails because $record is undefined. To keep the failure from causing the script to die, we just need to eval it. Then, even if it fails, the batch revert will keep going. Test Plan: 1) Stage a batch of marc records 2) Import those records 3) Delete one of those records 4) Attempt to revert the batch, it will hang. 5) Apply this patch 6) Repeat steps 1-4, the revert should succeed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 20:39:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 18:39:22 +0000 Subject: [Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 20:39:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 18:39:23 +0000 Subject: [Koha-bugs] [Bug 8004] Items on hold lose transfer after being scanned twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13537|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 17911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17911&action=edit Bug 8004 - Followup - Rename KohaBranchName filter to BranchName This patch renames the TT filter KohaBranchName to just BranchName, as the Koha is superfluous. Test Plan: 1) Apply patch 2) Attempt to transfer an item to the incorrect branch, you should see the name of the branch in the "please return to" message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 21:13:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 19:13:54 +0000 Subject: [Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #9 from Mason James --- (In reply to comment #8) > Created attachment 17878 [details] [review] > Bug 10084 - YUI path wrong in CCSR theme with packages > > Bug 9052 fixed this for prog, CCSR was left aline in the dark (it's friday). > > Regards > To+ > > Sponsored-by: Universidad Nacional de Cordoba > Signed-off-by: Chris Cormack > > Worked fine in my test package, good work Tomas > Signed-off-by: Mason James passing QA - works as promised -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 21:20:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 19:20:30 +0000 Subject: [Koha-bugs] [Bug 10122] jQueryUI tabs on my summary page not highlighted in CCSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10122 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #1 from Mason James --- (In reply to comment #0) > Created attachment 17689 [details] > my summary > > When logged in to the, opac the tabs on 'my summary' aren't > highlighted/selected like they used to be. This is tested in CCSR only so > far. hmmmm, screenshot? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 21:38:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 19:38:47 +0000 Subject: [Koha-bugs] [Bug 10122] jQueryUI tabs on my summary page not highlighted in CCSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10122 --- Comment #2 from Owen Leonard --- I can't post a screenshot at the moment, but I can confirm that this bug is present in CCSR. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 22:01:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 20:01:37 +0000 Subject: [Koha-bugs] [Bug 10177] New: Koha Accepts Seven "Space" Characters as a Valid Password Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Bug ID: 10177 Summary: Koha Accepts Seven "Space" Characters as a Valid Password Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: glawson at rhcl.org CC: dpavlin at rot13.org Koha 3.10.03 and presumably earlier versions accept seven "space" characters as a valid password. Concerns: 1. Some third party software using SIP to check the Koha database to authenticate users may interpret all blank characters, or even a single terminal blank character, as an invalid password. 2. gmcharlt suggests that patches submitted in the future may strip trailing whitespace characters in form input, causing pernicious perturbations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 22:21:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 20:21:52 +0000 Subject: [Koha-bugs] [Bug 9934] OPAC info tooltip doesn't appear in CCSR theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9934 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 23:24:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 21:24:58 +0000 Subject: [Koha-bugs] [Bug 9891] Current suspend holds have disappeared In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9891 jdemuth at roseville.ca.us changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth at roseville.ca.us --- Comment #2 from jdemuth at roseville.ca.us --- This happened to us as well, we went to 3.10.5 on 4/24/2013 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 23:30:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 21:30:15 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #105 from Liz Rea --- Regarding whack a mole: http://www.youtube.com/watch?v=D0n8N98mpes This may be the only time in bugzilla history where a link to a video of a game is appropriate. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 23:37:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 21:37:19 +0000 Subject: [Koha-bugs] [Bug 10178] New: Typos in plugins for 006 and 008 in MARC21 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Bug ID: 10178 Summary: Typos in plugins for 006 and 008 in MARC21 Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de CC: m.de.rooy at rijksmuseum.nl While translating I noticed a few typos in the 2 plugins for 006 and 008, I missed to note them, except for this one: 008: Inclusive dates of colletion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 23:47:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 21:47:12 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #106 from Galen Charlton --- (In reply to comment #104) > Here is my reaction on this action from you as new RM: I am also an _old_ RM, and stand by my decision on the following basis: - This was reverted in 3.12.x. Jared would have been perfectly in his rights to revert in master as well. If the patch series was too problematic to include in the main release, it does not necessarily belong in master, either. - Side-effects of this patch series were *getting in the way* of applying other patches necessary for the 3.12.x release. - The basis of the patch series relies on use of a flag to CGI.pm that it's own documentation warns against. Further, please bear in mind what I said: "This should not be viewed as a permanent reversion" And I mean it. I do not disagree that the underlying bug needs to be dealt with, but the number of side-effects shows that the current patch series is not ready for prime time. The integration branch will provide an opportunity for more thorough testing. > On the whole: This is very discouraging and highly unmotivating. Please > communicate with other developers and team members instead of starting your > RM term with one-sided actions like this one. Do you think that this makes > me spend more time on the subject? Considering the discussion and advance warning over IRC, I reject your implication that this decision was not communicated. The reversion is not meant as a personal slight against anybody. I do understand that you have put a lot of effort into this, and I understand that having patches that one has worked on getting reverted stings. I hope to encourage a different approach to patches and reversions: that they be treated as experiments and learning opportunities, and that credit be given to those who make the experiment, even if their patch doesn't end up getting committed in its original form. However, I acknowledge that this is not an easy thing. But I will also be blunt: I would not be doing my job as RM well if, when necessary, I didn't exercise my own judgment. One of the things I've learned the hard way is that at times, it is necessary to force a pause to recheck assumptions. I believe this is one of the moments for this bug. I encourage you to work on the integration branch, but if you prefer to take a break from this bug, I have every confidence that we will not lack for hands and eyes to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 2 23:50:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 21:50:49 +0000 Subject: [Koha-bugs] [Bug 7003] canned report to show patrons and permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7003 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature --- Comment #1 from Nicole C. Engard --- I still think this is a good idea :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 00:07:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 22:07:33 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 --- Comment #1 from Katrin Fischer --- 008: Instrutional materials -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 00:09:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 22:09:38 +0000 Subject: [Koha-bugs] [Bug 10150] koha-email-disable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10150 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 00:10:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 22:10:42 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 --- Comment #2 from Katrin Fischer --- 008: Law reorts and digests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 00:20:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 22:20:21 +0000 Subject: [Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master. Thanks, Tom?s! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 00:39:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 22:39:56 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 --- Comment #3 from Katrin Fischer --- Teatries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 00:54:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 02 May 2013 22:54:31 +0000 Subject: [Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- I too am getting merge conflicts applying this to master: git bz apply 9508 Bug 9508 - the dateformat variable is not standardized in template files [PASSED QA] Bug 9508: Standardize the dateformat value from C4::Auth Apply? [yn] y Applying: Bug 9508: Standardize the dateformat value from C4::Auth Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Auth.pm Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt Auto-merging members/memberentry.pl Failed to merge in the changes. Patch failed at 0001 Bug 9508: Standardize the dateformat value from C4::Auth When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 03:14:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 01:14:22 +0000 Subject: [Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 --- Comment #2 from Nicole C. Engard --- Katrin, I'll use your example. Let's say we have a bound volume with the titles in that bound volume linked to it using Analytics. If I place a hold on the 'next available item' on one of the titles in the bound volume then the hold isn't on the bound volume, it's on the individual title, but you can't get just the title without the entire bound volume, so that hold shouldn't be allowed or should be forced to the bound volume if placed on the individual title. I'll do a screencast to try and explain too. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 03:34:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 01:34:55 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 --- Comment #4 from Bernardo Gonzalez Kriegel --- Created attachment 17912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17912&action=edit Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Well, not only typos. There is also a NEW update for 008 Music on April 2013. And a missing value in 006 Consider this patch as an interim fix. I will re-check all values. As it change strings, it will not be considered right now. So, no need to sign yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 07:45:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 05:45:23 +0000 Subject: [Koha-bugs] [Bug 10179] New: [master] Umlauts on maintenance page broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10179 Bug ID: 10179 Summary: [master] Umlauts on maintenance page broken Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de To reproduce: - check out current master branch - install German translations with po files from pootle - activate opacmaintenance - verify maintenance message shows a broken umlaut in 'zur?ck' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 07:46:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 05:46:03 +0000 Subject: [Koha-bugs] [Bug 10179] [master] Umlauts on maintenance page broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10179 --- Comment #1 from Katrin Fischer --- Diacritics display correctly for the current 3.12.x branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 08:07:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 06:07:49 +0000 Subject: [Koha-bugs] [Bug 10180] New: [master] Diacritics in Z39.50 search results in acquisitions are broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10180 Bug ID: 10180 Summary: [master] Diacritics in Z39.50 search results in acquisitions are broken Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de To reproduce: - Create a basket - Add order line from external source - Search LOC for "wetter" - Verify that diacritics in the result list are broken This only occurs on the current master branch, not on 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 08:09:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 06:09:18 +0000 Subject: [Koha-bugs] [Bug 10180] [master] Diacritics in Z39.50 search results in acquisitions are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #1 from Katrin Fischer --- This is especially bad because the data imported has broken diacritics too, so it's not only a display problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 08:12:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 06:12:38 +0000 Subject: [Koha-bugs] [Bug 10180] [master] Diacritics in Z39.50 search results in acquisitions are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10180 --- Comment #2 from Katrin Fischer --- There are a lot more problems I note now while testing - like XSLT detail pages. I think something is seriously going wrong here and will stop filing bugs for now until someone had a chance to look into this one and bug 10179. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 08:24:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 06:24:24 +0000 Subject: [Koha-bugs] [Bug 10181] New: Improve message shown for deleted records in basket summary page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Bug ID: 10181 Summary: Improve message shown for deleted records in basket summary page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de When you delete a record that is used in an order, the basket summary displays: Deleted bibliographic notice, can't find title. While it would be nice if it showed a note about the deletion and the title from the deletedbilbio table, it would be better if it used 'record' instead of notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 08:29:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 06:29:09 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 08:29:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 06:29:11 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17700|0 |1 is obsolete| | Attachment #17833|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer --- Created attachment 17913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17913&action=edit [PASSED QA] Bug 7593: Move orders on the destination record when merging 2 records Revised patch according to QA comments. No more dependent from bz 9780. At present, merging records breaks the link order/record, except if an item of the deleted record is used in the order. This is a serious issue for libraries creating items on receipt. This patch moves existing orders from deleted record to destination record. It creates a new function Acquisitions::GetOrdersByBiblionumber, that could be used by other patches later. To test : Check the problem : 1. Set syspref AcqCreateItem = Create an item when receiving an order 1. Create a basket with one order 2. Put the record used by this order in a list 3. Put an other record in the list 4. Merge the 2 records, keeping as a reference the record NOT used in the order 5. In the order, you will see for that order "Deleted bibliographic information..." 6. Apply the patch 7. Repeat steps 1-4 8. In the order, you will see the title/author of the kept record. 9. Set syspref AcqCreateItem = Create an item when placing an order 10. Repeat steps 1-4 (an item will be created) 11. In the oreder, you will see the title/author of the kept record (it is already the case at present. the patch should not alter this behavior) Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Test plan, test suite and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 08:29:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 06:29:24 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #33 from Katrin Fischer --- Created attachment 17914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17914&action=edit [PASSED QA] Bug 7593 : QA followup : restores deleted line in C4::Acquisition This patch restores the line exporting GetOrderNumber that I accidentally suppressed. Signed-off-by: Katrin Fischer Restores a line that was deleted by the first patch. Was not sure if patches should be squashed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 08:30:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 06:30:47 +0000 Subject: [Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 09:31:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 07:31:23 +0000 Subject: [Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 --- Comment #3 from Katrin Fischer --- So the problem is, that the biblionumber is wrong for the hold placed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 09:39:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 07:39:45 +0000 Subject: [Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16815|0 |1 is obsolete| | Attachment #16816|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 17915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17915&action=edit Bug 9508: Standardize the dateformat value from C4::Auth - the dateformat value is send to all templates (from C4::Auth::get_template_and_user) - remove all assignment of dateformat in all .pl files - Remove "all" occurrences (those I found!) of dateformat_* >From now the only way to get the date format is a string comparaison (dateformat == "metric") Checked with the command: git grep "\(dateformat_us\|dateformat_metric\|dateformat_iso\)" | grep -v translator Signed-off-by: Kyle M Hall Tested all the datepickers I could find, looks good. Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 09:39:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 07:39:48 +0000 Subject: [Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508 --- Comment #13 from Jonathan Druart --- Created attachment 17916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17916&action=edit Bug 9508 follow-up : replacing tabs by spaces This patch fixes tabs and replace them by spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 09:40:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 07:40:15 +0000 Subject: [Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 09:45:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 07:45:07 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #5 from Paul Poulain --- Feedback: we're running plack in production at SAN Ouest Provence since last week. They are facing this problem. I can reproduce it on their test platform too. However, when trying to reproduce it on a master/3.11, it's working well. I spent more than 3 hours trying to understand the differences, and can't find any patch that explain this behaviour change. Jared, is your comment 4 applying on master or 3.10 ? (I fear it's master, that would just add some mystery...) Side comment = it seems that, despite the error, the file is uploaded correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 10:10:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 08:10:31 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #6 from Paul Poulain --- Feedback 2 : suspecting a problem with background jobs, I've tested tools/upload-cover-image.pl, on a 3.10 and got the same problem. So it relies on background-job. I tried on a master, and it worked ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 10:13:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 08:13:03 +0000 Subject: [Koha-bugs] [Bug 10010] Use jQueryUI Accordion to display constraints in MARC subfield editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10010 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 10:43:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 08:43:21 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #53 from Jonathan Druart --- Could you export the 2 dataTable sorting functions into the datatables.js file please? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 10:43:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 08:43:24 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #7 from Paul Poulain --- still trying to figure out why it works for me on a master. Here are the log I get on plack: seek() on closed filehandle _GEN_5 at /usr/share/perl5/CGI/Emulate/PSGI.pm line 31. Undefined subroutine &CGI::Emulate::PSGI::croak called at /usr/share/perl5/CGI/Emulate/PSGI.pm line 31. (and nothing more) I checked configurations files on both servers, and couldn't see any difference. How I run starman: starman -M FindBin --max-requests 50 --workers 6 --port 5001 --pid /path/starman_pro.pid koha.psgi my koha.psgi is: #!/usr/bin/perl use Plack::Builder; use Plack::App::CGIBin; use Plack::Middleware::Debug; use Plack::App::Directory; #use Plack::Middleware::Debug::MemLeak; use lib("/home/paul/koha.dev/koha-community"); use C4::Context; use C4::Languages; use C4::Members; use C4::Dates; use C4::Boolean; use C4::Letters; use C4::Koha; use C4::XSLT; use C4::Branch; use C4::Category; my $app=Plack::App::CGIBin->new(root => "/home/paul/koha.dev/koha-community/"); builder { # enable 'Debug', panels => [ # qw(Environment Response Timer Memory), # [ 'Profiler::NYTProf', exclude => [qw(.*\.css .*\.png .*\.ico .*\.js .*\.gif)] ], # [ 'DBITrace', level => 1 ], # ]; enable "Plack::Middleware::Static", path => qr{^/intranet-tmpl/}, root => '/home/paul/koha.dev/koha-community/koha-tmpl/'; enable "Plack::Middleware::Static::Minifier", path => qr{^/intranet-tmpl/}, root => './koha-tmpl/'; # enable 'StackTrace'; mount "/cgi-bin/koha" => $app; }; (note that I also tried to uncommand "enable 'StackTrace', no difference, still work on my laptop) my laptop is running Ubuntu 12.04LTS. Plack version is 0.9985 On the (faulty) server : Debian + Plack version 1.0013 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 10:43:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 08:43:53 +0000 Subject: [Koha-bugs] [Bug 9231] Batch revert staged MARC records fails if one or more records in a batch have been deleted. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9231 --- Comment #5 from Chris Cormack --- Comment on attachment 17910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17910 Bug 9231 - Batch revert staged MARC records fails if one or more records in a batch have been deleted. Review of attachment 17910: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9231&attachment=17910) ----------------------------------------------------------------- ::: C4/Items.pm @@ +619,4 @@ > > # backup the record > my $copy2deleted = $dbh->prepare("UPDATE deleteditems SET marc=? WHERE itemnumber=?"); > + eval { $copy2deleted->execute( $record->as_usmarc(), $itemnumber ); }; warn $@ if $@; If the error is caused by $record being undefined, wouldn't it be better to do if ($record){ my $copy2deleted = $dbh->prepare("UPDATE deleteditems SET marc=? WHERE itemnumber=?"); $copy2deleted->execute( $record->as_usmarc(), $itemnumber ); } To save creating a handle and hitting the db when we don't need to, could even do an else { log deleted one here to tell the user } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 10:46:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 08:46:54 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #15 from Jonathan Druart --- I agree with the Fridolyn's proposal. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 10:53:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 08:53:36 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 10:53:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 08:53:38 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 --- Comment #2 from Chris Cormack --- Created attachment 17917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17917&action=edit Bug 10170: strings in MARC import made translatable Following bug 9215: non translatable strings are now present in the template and translatable Signed-off-by: Chris Cormack Not only does this make the strings translatable it makes the template a lot easier to read -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:06:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:06:53 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17444|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 17918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17918&action=edit Bug 10052: Db revision for intranetstylesheet Report 10052 makes the intranetstylesheet prefs behave like the opac ones. This patch contains an optional db revision: If the pref intranetstylesheet is not blank, and does not start with http, https or /, then prefix it with a slash to make it an absolute path. Test plan: Before applying this patch: 1) Put intranet-tmpl/prog/en/css/staff-global.css into intranetstylesheet. This works in the current staff client, but will be interpreted as relative as soon as both patches for this report have been applied. Apply the patch. And run: /cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Check the webinstaller warning and the pref value. There should be a slash in front now. The css should still work. Continue after applying this patch with: 2) Clear the intranetstylesheet pref. Run updatestructure again. No message: OK 3) Put /intranet-tmpl/prog/en/css/staff-global.css in intranetstylesheet. Run updatestructure again. No message: OK 4) Prefix intranetstylesheet with http://[your-server-here]. Test again. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:07:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:07:57 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #16 from mathieu saby --- I had forgotten this bug... Will take a look later and rewrite it. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:13:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:13:18 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17445|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 17919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17919&action=edit Bug 10052: Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts Allow a relative path (within theme/css) in intranetstylesheet too. Allow a full path, local or remote with http(s), in intranetcolorstylesheet. This restores consistency between opac and staff. Test plan: First: the patch with the db revision should have been applied. And also the updatestructure step from the web installer should have been run. Clear intranetstylesheet. Check included stylesheet with page source in browser. Enter a full path with http or / in intranetstylesheet. Check again. Enter a relative path (such as staff-global.css). Check again. Clear intranetcolorstylesheet. Check if there is no reference with page source. Enter a full path with http or / in intranetcolorstylesheet. Check reference. Enter a relative path (such as blue.css). Check again. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:14:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:14:04 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:14:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:14:06 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17465|0 |1 is obsolete| | --- Comment #12 from Chris Cormack --- Created attachment 17920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17920&action=edit Bug 10052 Followup for edithelp.tt and help-top.inc A grep on the stylesheet names revealed that similar code was used in those template files. This patch moves the code from doc-head-close.inc to a new include file. Now, doc-head-close and the help templates refer to that one file. Test plan: If you tested the preceding two patches, now you only need to: 1) Check included css via page source in browser from staff main page. 2) Check it also from some other location. 3) Check again from Help: e.g. /cgi-bin/koha/help.pl 4) Check again from Edit Help: /cgi-bin/koha/edithelp.pl Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:19:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:19:53 +0000 Subject: [Koha-bugs] [Bug 9891] Current suspend holds have disappeared In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- What was the version you updated from? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:48:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:48:53 +0000 Subject: [Koha-bugs] [Bug 7883] save and continue editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- QA comment: Works as expected. This patch allows to do a save and to continue editing the same notice. An improvement could be to stay on the same tab after saving. I will open a new report for that. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:49:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:49:15 +0000 Subject: [Koha-bugs] [Bug 7883] save and continue editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16224|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 17921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17921&action=edit Bug 7883 - Save and continue editing for cataloging Patch reworked from Elliot Davis' original patch - but using bootstrap instead of YUI. This patch adds the ability for catalogers to save and continue editing when adding new biblios. To Test: Select an existing item or create a new item in cataloging using your favorite framework. Edit the bib >From the save menu in the dropdown, select the new option of "Save and continue editing" If you are missing required fields you should still be prompted to fill them in before saving Once all required fields are in place you should be allowed to save, and you will be redirected to tab 0. The original patch claims to redirect to the original tab, but I never observed that behaviour from it - this patch merely takes what was in the original and makes it boostrap. Signed-off-by: Alex Arnaud Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:52:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:52:01 +0000 Subject: [Koha-bugs] [Bug 10182] New: Save and continue editing should be improved Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10182 Bug ID: 10182 Summary: Save and continue editing should be improved Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com CC: m.de.rooy at rijksmuseum.nl When editing a biblio, the bug 7883 introduces the "save and continue editing" feature. After saving, the page is loaded with the first tab selected. It would be great to stay on the same tab after saving. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:52:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:52:16 +0000 Subject: [Koha-bugs] [Bug 10182] Save and continue editing should be improved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10182 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |7883 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:52:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:52:16 +0000 Subject: [Koha-bugs] [Bug 7883] save and continue editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10182 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:56:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:56:03 +0000 Subject: [Koha-bugs] [Bug 10182] Save and continue editing should be improved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10182 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:56:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:56:05 +0000 Subject: [Koha-bugs] [Bug 10182] Save and continue editing should be improved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10182 --- Comment #1 from Jonathan Druart --- Created attachment 17922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17922&action=edit Bug 10182: Stay on the same tab after saving a biblio When editing a biblio, the bug 7883 introduces the "save and continue editing" feature. After saving, the page is loaded with the first tab selected. This patch refresh the page with the same tab selected. Test plan: 1/ Edit a biblio. 2/ Clic on the 5th tab. 3/ Clic on the "Save and continue editing" button. 4/ You are redirected on the same page with the same tab selected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 11:56:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 09:56:25 +0000 Subject: [Koha-bugs] [Bug 10182] Save and continue editing should be improved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10182 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 12:13:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 10:13:44 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 12:20:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 10:20:00 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #5 from mathieu saby --- Your followup looks strange : it contains the same strings as the main patch. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 12:22:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 10:22:47 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15615|0 |1 is obsolete| | --- Comment #18 from Koha Team Lyon 3 --- Created attachment 17923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17923&action=edit Bug 9593 Prices not imported correctly from a staged file Hello I redid test with prices like $2 and ?24, and it worked well for me. As far as regex is concerned, I see no reason that it would work for a price like '? 22' and not for '$42'. I suspect an error during importation process, may be an encoding issue ? So I 've kept this part of the patch as it was, but, following your different observations, I restablished the possibility of choosing an 'active currency' when existing. I also add the ability to choose it from the isocode instead of symbol currency. However, I fear that it couldn 't treat every possible form of not normalized multicurrency price strings that may appear in price zone. So it's a little better than it was under this aspect but not completly satisfying. For example, it will work for string like this $2, ?5 2$, 6? $2 USD, $4 LRD 2 EUR, 5 GBP 13.5 EUR, 15 GBP but it will not for : $800 LRD, $10 US $15, 18 EUR Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 12:23:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 10:23:14 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 12:27:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 10:27:10 +0000 Subject: [Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 --- Comment #4 from Nicole C. Engard --- Video: http://www.screencast.com/t/3ASTIyJ6JSB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 12:27:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 10:27:38 +0000 Subject: [Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 --- Comment #5 from Nicole C. Engard --- Yes! I think that's the problem - great way to boil it down :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 12:56:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 10:56:36 +0000 Subject: [Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 --- Comment #6 from Katrin Fischer --- I guess the problem is that it's not a general yes/no thing. If your analytic has not only the analytics item, but also a real item, that can be placed on hold, a biblio level hold on this would be ok. But we have no way to decide which record should be chosen then. If the record has only the analytical item, only a bib level hold on the parent would be ok. Maybe we could say that analyticals should only be availabable for item level holds? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 12:58:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 10:58:56 +0000 Subject: [Koha-bugs] [Bug 10162] holds shouldn't be allowed on the title level of analytics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10162 --- Comment #7 from Nicole C. Engard --- I'd be okay with that. I do see how this is a very difficult issue ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 13:46:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 11:46:35 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #8 from Jared Camins-Esakov --- (In reply to comment #5) > Jared, is your comment 4 applying on master or 3.10 ? (I fear it's master, > that would just add some mystery...) Master. > Side comment = it seems that, despite the error, the file is uploaded > correctly. Confirmed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 13:53:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 11:53:19 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #107 from Jonathan Druart --- Galen, I don't know why, a remainder of the first patch still exists on master, which cause some trouble with encoding. The binmode routine is called in master: sub output_html_with_http_headers { binmode( STDOUT, ":encoding(utf8)" ); my ( $query, $cookie, $data, $status ) = @_; output_with_http_headers( $query, $cookie, $data, 'html', $status ); } This line was not deleted by the revert commit. commit d542740ab8877234d043c8a11cb19a6004e72656 Author: Dobrica Pavlinusic Date: Sun Jun 10 15:18:42 2012 +0100 Bug 6554 - make Koha internally utf-8 clean git show d542740ab8877234d043c8a11cb19a6004e72656 C4/Output.pm +++ b/C4/Output.pm @@ -308,6 +308,7 @@ sub output_with_http_headers { } sub output_html_with_http_headers { + binmode( STDOUT, ":encoding(utf8)" ); commit a7eb34f2c8a281ef83f711e581079a2232296c88 Author: Galen Charlton CommitDate: Mon Apr 29 15:12:32 2013 -0700 Revert "Bug 6554 - make Koha internally utf-8 clean" git show a7eb34f2c8a281ef83f711e581079a2232296c88 C4/Output.pm returns nothing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 14:29:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 12:29:46 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Janusz Kaczmarek changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17850|0 |1 is obsolete| | --- Comment #10 from Janusz Kaczmarek --- Created attachment 17924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17924&action=edit Improved patch - v. 0.3 I have omitted one case: it could be, that UNIF_TITLE authority will used to control bibliographic 240. In this case 2nd indicator from UNIF_TITLE authority should be copied to 2nd indicator of bibliographic 240. A modified patch is provided. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 14:32:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 12:32:21 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #11 from Janusz Kaczmarek --- Bernardo, Thank you for your efforts in testing this patch. In general, the results are correct, i.e. it is what I would expect?with one exception: e) GENRE/FOMR 155 BIB IND1 IND2 655 - 0|7 With your data set (GENRE/FORM 155a, ind1=1, ind2=2), according to my code and to my tests results, the 1st indicator should become 1. So, please, could you check it again. BUT in fact the 1st indicator in authority records 148, 150, 151, 158 is undefined by definition (and should be your records), so I do not pay attention on it (precisely speaking, a default action is taken, i.e. to copy). Now, I have omitted one case: it could be, that UNIF_TITLE authority will used to control bibliographic 240. In this case 2nd indicator from UNIF_TITLE authority should be copied to 2nd indicator of bibliographic 240. A modified patch has been provided. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 14:37:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 12:37:01 +0000 Subject: [Koha-bugs] [Bug 10183] New: Serials collection table is displayed with a single pixel before and after Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Bug ID: 10183 Summary: Serials collection table is displayed with a single pixel before and after Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com CC: colin.campbell at ptfs-europe.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 14:37:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 12:37:09 +0000 Subject: [Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 14:37:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 12:37:10 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #108 from Dobrica Pavlinusic --- (In reply to comment #103) > This should not be viewed as a permanent reversion, > although I have reservations about turning on CGI.pm's -utf8 switch across > the board -- but I have even stronger reservations about the ensuant game of > whack-a-mole we've been playing with new bugs arising from this patch. Would you mind to elaborate your objections to CGI.pm's -utf8 switch? I think that it's cleaner to take extra care about code which uses file upload than to hand-decode every single parameter we are passing into Koha code. This is only my personal preference, and I am fine with whatever solution gets eventually prefered, but I main question is if I should re-submit my patches without -utf8 in them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 14:37:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 12:37:22 +0000 Subject: [Koha-bugs] [Bug 9791] Some tables are displayed with a pixel before and after In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9791 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10183 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 14:37:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 12:37:22 +0000 Subject: [Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9791 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 14:39:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 12:39:24 +0000 Subject: [Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 --- Comment #1 from Jonathan Druart --- Created attachment 17925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17925&action=edit Bug 10183: Remove single pixel on the serials collection page Test plan: Go on the serials collection page Check that the single pixels before and after the table have disappeared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 14:39:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 12:39:42 +0000 Subject: [Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 14:41:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 12:41:11 +0000 Subject: [Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 15:04:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 13:04:02 +0000 Subject: [Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #21 from Jonathan Druart --- QA comment: The patches works as expected. But it does not change the data in the DB, so the issue still exists until user change status for a missing serial. It's too bad not to deal with existing data. I pass QA this patch until it fixes a bug but it would be great to have a followup. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 15:04:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 13:04:36 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14433|0 |1 is obsolete| | --- Comment #34 from Koha Team Lyon 3 --- Created attachment 17926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17926&action=edit Bug 8236 Block renewing for overdue items At the end , I found more convenient to deal with the restriction case in same patch. I keep what seems to be the existing logic - a patron can't renew when he's restricted (his opac file is freezen) - making it more consistent. Any renewal for a restricted patron is now also blocked from webservice and clearly not possible from the pro interface unless by checking 'override_limit'. If someone would like to allowed renewal for restricted patrons, I think it would be not very complicated to add a syspref ( a line of code in HasWhateverRenewalToBeBlocked and some addings in opac-user.tt) As for the main object of the patch - blocking for late document - I made some ajustements you pointed out and one change in the logic : rather than hiding the 'Renew all' button, I move the checking in renewscript.pl. So, this button is always available in case of big list of checkouts items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 15:04:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 13:04:46 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 15:05:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 13:05:36 +0000 Subject: [Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17365|0 |1 is obsolete| | Attachment #17577|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 17927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17927&action=edit Bug 8896: Delete serials no more missing from missinglist When manual history is disabled in subscription history section if a serial has been previously set as missing and is received or set as expected, late or claimed, it will be deleted from missinglist Signed-off-by: Marcel de Rooy Regex needs a followup. More comments on Bugzilla. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 15:05:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 13:05:40 +0000 Subject: [Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 --- Comment #23 from Jonathan Druart --- Created attachment 17928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17928&action=edit Bug 8896 QA Followup for regex Making sure that the regex does not kill more than it should. Amended: does now only look at separating colons(;) not commas(,). Amended: two index expressions in direct context replaced by same regex for consistency. Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 15:06:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 13:06:15 +0000 Subject: [Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 15:33:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 13:33:23 +0000 Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16301|0 |1 is obsolete| | --- Comment #6 from Koha Team Lyon 3 --- Created attachment 17929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17929&action=edit Bug 9836 Filtering sort1 list according to patron category in patron data Hello Patch modified. It's now possible to link a sort1 criteria to several borrower categories -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 15:33:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 13:33:32 +0000 Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 15:43:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 13:43:46 +0000 Subject: [Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 15:43:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 13:43:47 +0000 Subject: [Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17925|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 17930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17930&action=edit [SIGNED-OFF] Bug 10183: Remove single pixel on the serials collection page Test plan: Go on the serials collection page Check that the single pixels before and after the table have disappeared. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 16:15:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 14:15:30 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 --- Comment #9 from Jonathan Druart --- Created attachment 17931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17931&action=edit Bug 9533: Use default values by default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 16:15:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 14:15:45 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 16:23:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 14:23:26 +0000 Subject: [Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17884|0 |1 is obsolete| | --- Comment #7 from Owen Leonard --- Created attachment 17932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17932&action=edit [SIGNED-OFF] Bug 10129: Babeltheque does not depend on COinSinOPACResults This patch groups all loops on the new_results array into one. It is useless to loop on the same results array several times. Test plan: Quite hard to test all cases. This patch deals with 5 sysprefs: COinSinOPACResults, Babeltheque, TagsEnabled, TagsShowOnList and OpacStarRatings. Try to enable/disable all of them and verify there is no difference with and without this patch. The only different will be: The Babeltheque information should be displayed even if the COinSinOPACResults syspref is disabled. Signed-off-by: Owen Leonard This revised patch works fine for me, thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 16:23:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 14:23:25 +0000 Subject: [Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 16:31:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 14:31:46 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #35 from Koha Team AMU --- So sad. It seems we can't test it on a sandbox : Something went wrong ! Applying: Bug 8236 Block renewing for overdue items Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Circulation.pm Auto-merging circ/circulation.pl Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt Auto-merging opac/opac-renew.pl CONFLICT (content): Merge conflict in opac/opac-renew.pl Auto-merging opac/opac-user.pl Auto-merging reserve/renewscript.pl Failed to merge in the changes. Patch failed at 0001 Bug 8236 Block renewing for overdue items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 16:32:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 14:32:27 +0000 Subject: [Koha-bugs] [Bug 10184] New: Circulation History reverses sort order Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Bug ID: 10184 Summary: Circulation History reverses sort order Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The script members/readingrec.pl specifically requests the users issues ordered with the most recent (by due date) first. But they are displayed in approximately the reverse order to this. The cause is that unless explicitly disabled the datatables sort their data and not being given a specification they do so in ascending order by the first column. The pre display sort of already sorted data needs disabling -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 16:47:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 14:47:02 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #36 from Koha Team Lyon 3 --- Yes, I think it's not possible, on the sandbox because of the versioning in updatedatabase.pl file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 16:48:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 14:48:29 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #37 from Jonathan Druart --- (In reply to comment #36) > Yes, I think it's not possible, on the sandbox because of the versioning in > updatedatabase.pl file. Yes it is possible, but you should provide a patch rebased against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 16:56:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 14:56:29 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 17933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17933&action=edit proposed patch Patch: to test Without the patch issues in patron circulation history will show oldest first. With patch applied issues will initially display most recent first (ordered by duedate) Users ability to sort the table should not be impaired. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 16:57:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 14:57:31 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Severity|enhancement |trivial --- Comment #2 from Colin Campbell --- oops forgot to change status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:01:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:01:47 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #109 from Galen Charlton --- (In reply to comment #107) > Galen, > I don't know why, a remainder of the first patch still exists on master, > which cause some trouble with encoding. > > The binmode routine is called in master: Thanks for catching this. I've pushed a patch to master to complete the revert. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:13:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:13:00 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #14 from Paul Poulain --- I think there's something wrong with attachments: the #2 is "octet-stream", it should be a patch I think. isn't the #1 obsoleted by the #2 too ? To answer the main question : I think it's more a bugfix than an ENH : baskets that are 100% received are supposed not to be displayed anymore on this page. Side comment: we must display baskets that are not closed, whatever the # of items still to receive. Otherwise, empty baskets will disappear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:13:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:13:07 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:18:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:18:34 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #38 from Koha Team Lyon 3 --- ?! I am surely missing something (much indeed) about git, but I did this patch today on top of master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:19:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:19:59 +0000 Subject: [Koha-bugs] [Bug 10185] New: updatedatabase.pl remove all reserves Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Bug ID: 10185 Summary: updatedatabase.pl remove all reserves Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: Database Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com Update number 3.09.00.025 can remove all reserves from reserves table when there is no entries in old_reserves. This is due to @ai which is set to NULL in SET @ai = ( SELECT MAX( reserve_id ) FROM tmp_reserves ) and reserve_id > NULL returns no results in INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id > @ai This can be fixed easily by using COALESCE INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id > COALESCE(@ai, 0) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:20:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:20:38 +0000 Subject: [Koha-bugs] [Bug 10186] New: Typo in subscription-add.tt (years vs year) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 Bug ID: 10186 Summary: Typo in subscription-add.tt (years vs year) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: mathieu.saby at univ-rennes2.fr Typo to fix in koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt replace "2/years" with "2/year" in this block : [% IF ( periodicity9 ) %] [% ELSE %] [% END %] M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:21:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:21:11 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 --- Comment #1 from Julian Maurice --- Created attachment 17934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17934&action=edit Bug 10185: Fix update 3.09.00.025 It can remove all reserves from reserves table when there is no entries in old_reserves. This is due to @ai which is set to NULL in SET @ai = ( SELECT MAX( reserve_id ) FROM tmp_reserves ) and reserve_id > NULL returns no results in INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id > @ai -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:21:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:21:31 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:21:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:21:42 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:24:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:24:31 +0000 Subject: [Koha-bugs] [Bug 10187] New: precision needed in subscription-add.tt (1/quarter) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 Bug ID: 10187 Summary: precision needed in subscription-add.tt (1/quarter) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: mathieu.saby at univ-rennes2.fr A precision is needed in subscription-add.tt : "1/quarter" is used 2 times. I suppose there is some difference, but I do not know which... [% IF ( subscription.periodicity7 ) %] 1/quarter [% END %] [% IF ( subscription.periodicity8 ) %] 1/quarter [% END %] M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:28:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:28:21 +0000 Subject: [Koha-bugs] [Bug 10187] precision needed in subscription-add.tt (1/quarter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from mathieu saby --- Oups, not in subscription-add.tt but in serials-collection.tt ! In subscription-add.tt there are the same values, but with this comment : "periodicity8 is 1/quarter, exactly like periodicity7 but will use it for seasonal option" So in serials-collection.tt we should have : periodicity7 1/3 months (1/quarter) periodicity8 1/quarter (seasonal) M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:28:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:28:28 +0000 Subject: [Koha-bugs] [Bug 10187] precision needed in subscription-add.tt (1/quarter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:29:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:29:03 +0000 Subject: [Koha-bugs] [Bug 10187] precision needed in serials-collection.tt (1/quarter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|precision needed in |precision needed in |subscription-add.tt |serials-collection.tt |(1/quarter) |(1/quarter) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:30:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:30:11 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 --- Comment #2 from Julian Maurice --- Note that this bug concern version 3.10, but also 3.12 and master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 17:39:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 15:39:05 +0000 Subject: [Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17904|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov --- Created attachment 17935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17935&action=edit Bug 9961: Add truncation support to QP driver The original implementation of QueryParser did not handle truncation based on the QueryAutoTruncate system preference. This patch adds support. To test: 1) Apply patch. 2) Turn on UseQueryParser. 3) Set QueryAutoTruncate to "automatically." 4) Search for "har". Note that it returns results with words like "Harry" (i.e. with right truncation). 5) Search for "har*". Note that it still returns results with right truncation. 6) Set QueryAutoTruncate to "only when * is added." 7) Search for "har". Note that it returns only records that have the exact word "har" in them (most likely there will be none unless you have Hebrew items). 8) Search for "har*". Note that once again it returns results for "Harry" (i.e. right truncated results). 9) Sign off. This patch also reindents a hash in Koha/QueryParser/Driver/PQF.pm because it was hard to read before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 18:01:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 16:01:23 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #9 from Paul Poulain --- I suspect the difference does not come from Koha version, but from Plack version. > my laptop is running Ubuntu 12.04LTS. Plack version is 0.9985 > On the (faulty) server : Debian + Plack version 1.0013 I suspect that it's Plack that is responsible of the different behaviour. Jared, which plack version do you have ? (i'll try to update, but on ubuntu, by default, it's 0.9985) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 18:10:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 16:10:06 +0000 Subject: [Koha-bugs] [Bug 8970] MARC import gives error under Starman/Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8970 --- Comment #10 from Jared Camins-Esakov --- (In reply to comment #9) > I suspect the difference does not come from Koha version, but from Plack > version. > > my laptop is running Ubuntu 12.04LTS. Plack version is 0.9985 > > On the (faulty) server : Debian + Plack version 1.0013 > > I suspect that it's Plack that is responsible of the different behaviour. > > Jared, which plack version do you have ? > (i'll try to update, but on ubuntu, by default, it's 0.9985) I have Plack 0.9985 and Starman 0.2014. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 18:58:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 16:58:05 +0000 Subject: [Koha-bugs] [Bug 10127] Printoverdues.sh should tar only pdf files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10127 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #6 from Kyle M Hall --- Tried to test. Pre-patch the nested tar.gz file are created. Post-patch no tar.gz files of any kind are created. Any ideas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:01:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:01:25 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:01:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:01:26 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17873|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 17936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17936&action=edit Bug 10166 - Can't place holds on multiple titles if one or more are un-holdable opac-reserve.pl tries to check whether all selected titles in a multiple-hold batch are unavailable to be placed on hold. However, the logic is flawed in such a way that if the last item in the batch cannot be placed on hold the script assumes none can be placed on hold. This patch modifies the way the script tracks the "no titles available for holds" variable in order to correct the error. To test, place multiple holds by selecting titles from a list of search results. Test three conditions: - All titles are available to be placed on hold You should see no onscreen warnings, and all titles should be selectable on the place hold screen. A "Place hold" button should appear at the bottom. - Some titles can be placed on hold, some cannot The titles which can be placed on hold should be selectable. Titles which cannot be placed on hold should show a warning message. A "Place hold" button should appear at the bottom. - No titles can be placed on hold "Sorry, none of these items can be placed on hold." should appear at the top of the page. All titles should appear with warning messages. There should be no "Place hold" button. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:05:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:05:47 +0000 Subject: [Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:05:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:05:48 +0000 Subject: [Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17597|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 17937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17937&action=edit [Signed-Off] Bug 8278: build the structure with to_json instead of manually. Test plan: Same as previously. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:11:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:11:00 +0000 Subject: [Koha-bugs] [Bug 10036] adding header search to additem page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10036 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:11:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:11:01 +0000 Subject: [Koha-bugs] [Bug 10036] adding header search to additem page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10036 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17854|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 17938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17938&action=edit Bug 10036 - adding header search to additem page The add item screen lacks a header search form. This patch adds the cataloging header search include to additem.tt. To test, apply the patch and add items to or edit items of an existing record. The header search form should appear with options for cataloging search and circulation. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:18:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:18:52 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:18:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:18:53 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17934|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 17939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17939&action=edit Bug 10185: Fix update 3.09.00.025 It can remove all reserves from reserves table when there is no entries in old_reserves. This is due to @ai which is set to NULL in SET @ai = ( SELECT MAX( reserve_id ) FROM tmp_reserves ) and reserve_id > NULL returns no results in INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id > @ai Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:20:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:20:04 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #19 from Kyle M Hall --- Comment on attachment 17923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17923 Bug 9593 Prices not imported correctly from a staged file Review of attachment 17923: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9593&attachment=17923) ----------------------------------------------------------------- ::: installer/data/mysql/updatedatabase.pl @@ +6785,5 @@ > } > > +$DBversion = "3.11.00.XXX"; > +if ( CheckVersion($DBversion) ) { > + $dbh->do("ALTER TABLE currncy ADD isocode VARCHAR(5) default NULL AFTER symbol;"); Typo! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:20:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:20:18 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:22:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:22:45 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:22:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:22:46 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17931|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 17940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17940&action=edit Bug 9533: Use default values by default Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:24:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:24:56 +0000 Subject: [Koha-bugs] [Bug 10188] New: Top Most-circulated items doesn't count current loans Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 Bug ID: 10188 Summary: Top Most-circulated items doesn't count current loans Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com Right now, the 'calculate' function only counts circulation from the old_issues table, and not issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 19:25:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 17:25:09 +0000 Subject: [Koha-bugs] [Bug 10188] Top Most-circulated items doesn't count current loans In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10188 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 23:09:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 21:09:50 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17601|0 |1 is obsolete| | --- Comment #15 from Fr?d?rick Capovilla --- Created attachment 17941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17941&action=edit Improvements in the overdue_notices.pl script (new version) Sending a new version of the patch to corrects some errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 23:09:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 21:09:50 +0000 Subject: [Koha-bugs] [Bug 10189] New: French values in cataloging plugins for unimarc 128b and 128c fields Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 Bug ID: 10189 Summary: French values in cataloging plugins for unimarc 128b and 128c fields Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: mathieu.saby at univ-rennes2.fr Values in cataloging plugins for unimarc 128b and 128c fields are only in french. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 23:10:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 21:10:03 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 23:10:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 21:10:18 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mathieu.saby at univ-rennes2.f | |r Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 23:10:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 21:10:25 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 23:20:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 21:20:26 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 --- Comment #1 from mathieu saby --- Created attachment 17942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17942&action=edit [PATCH] Bug 10189 : Translate values in unimarc 128b/c cataloguing plugins in english Cataloguing plugins for UNIMARC 128b and 128c fields are only in french. This patch translates them. Source : http://blue.lins.fju.edu.tw/mao/marc/unicon.htm Note : 128b and 128c are deprecated in last version of UNIMARC Manual (field 145 used instread). But they are still used in French Sudoc network. To test : in a UNIMARC english Koha, edit a record and use 128b and 128c cataloguing plugins. Check everything is in english. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 23:20:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 21:20:39 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 23:21:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 21:21:27 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 --- Comment #2 from mathieu saby --- Wrong attachment :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 23:22:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 21:22:58 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17942|0 |1 is obsolete| | --- Comment #3 from mathieu saby --- Created attachment 17943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17943&action=edit [PATCH] Bug 10189 : Translate values in unimarc 128b/c cataloguing plugins in english Right file Cataloguing plugins for UNIMARC 128b and 128c fields are only in french. This patch translates them. Source : http://blue.lins.fju.edu.tw/mao/marc/unicon.htm Note : 128b and 128c are deprecated in last version of UNIMARC Manual (field 145 used instread). But they are still used in French Sudoc network. To test : in a UNIMARC english Koha, edit a record and use 128b and 128c cataloguing plugins. Check everything is in english. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 23:27:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 21:27:04 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #3 from mathieu saby --- Made for Rennes 2. Thank you Adrien & Chris ;-) M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 23:28:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 21:28:25 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 23:28:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 21:28:32 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 3 23:47:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 03 May 2013 21:47:34 +0000 Subject: [Koha-bugs] [Bug 10190] New: notices based on item type Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10190 Bug ID: 10190 Summary: notices based on item type Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: melia at bywatersolutions.com Many libraries in my system lend DVDs out for a shorter period than their normal checkout period, like 2 days versus 14 or 21 days for other items. They also charge larger fines on DVDs than other items. They would like to be able to generate overdue notices for DVDs on the first day overdue, unlike the first notice generation of 7 days on their other items. So this is an enhancement request to allow libraries to generate an overdue notice for a particular item type separate from the three notice triggers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 10:44:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 08:44:12 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Can you please write a test plan for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 11:05:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 09:05:42 +0000 Subject: [Koha-bugs] [Bug 10187] precision needed in serials-collection.tt (1/quarter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 --- Comment #2 from mathieu saby --- Created attachment 17944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17944&action=edit [PATCH] Bug 10187 : Make a distinction between 2 forms of quarterly in serials-collection.tt This patch changes the description of periodicity7 and periodicity8 in serials-collection.tt. The descriptions are now the same as in subscription-add.tt To test : - Find or create 2 serials subscriptions, with "1/3 months (1/quarter)" and "1/quarter (seasonal)" periodicity - Go on serial collection informations (serials-collection.pl) for the 1st subscription - You must see in Periodiciy column "1/3 months (1/quarter)" - Go on serial collection informations (serials-collection.pl) for the 2d subscription - You must see in Periodiciy column "1/quarter (seasonal)" M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 11:05:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 09:05:56 +0000 Subject: [Koha-bugs] [Bug 10187] precision needed in serials-collection.tt (1/quarter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 11:16:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 09:16:37 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 --- Comment #1 from mathieu saby --- Created attachment 17945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17945&action=edit [PATCH] Bug 10186: Fix a typo in subscription-add.tt : 2/years should be 2/year In subscription-add.tt dropdown list for periodiciy, the description for 9 value should be "2/year" (2 issues each year) At present, if the option value is selected, it is "2/years". This patch supresses the "s" after "year". To test : - in a subscription, change periodicity to "2/year" - save the subscription - reopen it and check the value is labelled "2/year" M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 11:16:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 09:16:51 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 11:33:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 09:33:19 +0000 Subject: [Koha-bugs] [Bug 10191] New: 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Bug ID: 10191 Summary: 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: mathieu.saby at univ-rennes2.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 11:38:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 09:38:50 +0000 Subject: [Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 11:39:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 09:39:32 +0000 Subject: [Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 --- Comment #1 from mathieu saby --- Created attachment 17946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17946&action=edit Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt This patch close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt. To test : - in a UNIMARC Koha instance, edit a record - open the plugin for 115a subfield - check the "Form of release - visual projection, motion picture" option list is correct, especially the value "other film type" - ope the plugin for 116 field - check the "Technique (prints) 2" option list is correct, especially the value "lithography" M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 11:39:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 09:39:47 +0000 Subject: [Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 15:26:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 13:26:27 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 15:26:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 13:26:29 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17936|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 17947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17947&action=edit [PASSED QA] Bug 10166 - Can't place holds on multiple titles if one or more are un-holdable opac-reserve.pl tries to check whether all selected titles in a multiple-hold batch are unavailable to be placed on hold. However, the logic is flawed in such a way that if the last item in the batch cannot be placed on hold the script assumes none can be placed on hold. This patch modifies the way the script tracks the "no titles available for holds" variable in order to correct the error. To test, place multiple holds by selecting titles from a list of search results. Test three conditions: - All titles are available to be placed on hold You should see no onscreen warnings, and all titles should be selectable on the place hold screen. A "Place hold" button should appear at the bottom. - Some titles can be placed on hold, some cannot The titles which can be placed on hold should be selectable. Titles which cannot be placed on hold should show a warning message. A "Place hold" button should appear at the bottom. - No titles can be placed on hold "Sorry, none of these items can be placed on hold." should appear at the top of the page. All titles should appear with warning messages. There should be no "Place hold" button. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 15:31:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 13:31:01 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I have run through the test plan before and after applying the patch. I couldn't reproduce the problem, but I also can't find any problems with the patch. Leaving this for Jared as I think he was involved in solving the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 15:40:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 13:40:04 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 --- Comment #5 from Owen Leonard --- Sorry if I didn't provide enough information to reproduce the problem. The screenshot helps explain: If the last item in the list of multiple titles to hold is unavailable it prevents all from being placed on hold. The problem doesn't exist if the last item in the list *is* available to be placed on hold. To reproduce you have to make sure the last title you check in the search results list is not available to be placed on hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 15:55:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 13:55:15 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17923|0 |1 is obsolete| | --- Comment #20 from Koha Team Lyon 3 --- Created attachment 17948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17948&action=edit Bug 9593 Prices not imported correctly from a staged file typo corrected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 15:55:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 13:55:24 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 16:23:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 14:23:48 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17948|0 |1 is obsolete| | --- Comment #21 from Koha Team Lyon 3 --- Created attachment 17949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17949&action=edit Bug 9593 Prices not imported correctly from a staged file Oups, sorry I corrected another stupidity : if ( substr($price,0,1) =~/\s*[0-9]/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 16:48:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 14:48:28 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #22 from mathieu saby --- Olivier, could you be more explicit in your commit message about what exactly your patch is supposed to do, and add a test plan ? Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 17:29:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 15:29:42 +0000 Subject: [Koha-bugs] [Bug 10089] Prevent renewing for restricted patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10089 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #4 from Koha Team Lyon 3 --- I would have add Lyon3 right away in the list copy of this bug , I 'm confused. I didn't see you had already worked on it and also treated the restricted problem in the patch I proposed yesterday for bug 8236 (unlike I was supposed to do, I changed my mind). Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 17:37:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 15:37:42 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17912|0 |1 is obsolete| | --- Comment #5 from Bernardo Gonzalez Kriegel --- Created attachment 17950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17950&action=edit Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Well, not only typos. There is also a NEW update for 006/8 Music on April 2013. And 3 missing values in 006. Revised descriptions and labels, source LOC page. Strings spell checked. To test: 1) Apply the patch 2) Test that MARC21 006 and 008 value builders works properly. Small string changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 17:39:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 15:39:39 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 18:05:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 16:05:22 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Assignee|gmcharlt at gmail.com |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 20:23:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 18:23:28 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 --- Comment #12 from Bernardo Gonzalez Kriegel --- > e) GENRE/FOMR 155 > BIB IND1 IND2 > 655 - 0|7 Tested again, good result. Also tested 240, so using similar notation of comment 9 GENRE/FOMR 155 BIB IND1 IND2 655 1 0|7 UNIF_TITLE 130 BIB IND1 IND2 240 - 2|2 All ok then. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 20:26:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 18:26:52 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17924|0 |1 is obsolete| | --- Comment #13 from Bernardo Gonzalez Kriegel --- Created attachment 17951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17951&action=edit [SIGNED-OFF] Bug 5262 - authority plugin doesn't copy indicators -- ver. 0.3 With this patch Koha should Koha should correctly copy indicators (and create $2 subfield in MARC-21 if need) from the chosen authority record to the edited bibliographic record (according to discussion in bugzilla). UNIMARC and MARC-21 flavors are covered. Signed-off-by: Bernardo Gonzalez Kriegel Comment: work as described, testing in comments 9 and 12. No errors. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 20:27:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 18:27:37 +0000 Subject: [Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 23:11:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 21:11:26 +0000 Subject: [Koha-bugs] [Bug 10176] Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176 Karam Qubsi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |karamqubsi at gmail.com --- Comment #1 from Karam Qubsi --- Created attachment 17952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17952&action=edit Solve-the-Invalid-URLs-in-Refine-Search-Results I just add use utf8; to the Search.pm and the problem was solved . Test plan : 1- Add bib records with non-latin characters 2- search for some of these records 3- try to refine your search using Subject / Author -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 23:14:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 21:14:01 +0000 Subject: [Koha-bugs] [Bug 9579] Incorrect display of UNICODE symbols in 'Refine Search Results' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9579 Karam Qubsi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10176 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 4 23:14:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 04 May 2013 21:14:01 +0000 Subject: [Koha-bugs] [Bug 10176] Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176 Karam Qubsi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karamqubsi at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9579 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 03:53:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 01:53:14 +0000 Subject: [Koha-bugs] [Bug 10176] Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17952|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel --- Created attachment 17953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17953&action=edit [SIGNED-OFF] Bug-10176 Solve the Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols I just add use utf8; to the Search.pm and the problem was solved . Test plan : 1- Add bib records with non-latin characters 2- search for some of these records 3- try to refine your search using Subject / Author Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work fixing URLs in facets. Now they work correctly. No errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 04:48:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 02:48:16 +0000 Subject: [Koha-bugs] [Bug 10176] Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel at gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 04:48:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 02:48:38 +0000 Subject: [Koha-bugs] [Bug 10176] Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176 --- Comment #3 from Bernardo Gonzalez Kriegel --- Also works on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 10:48:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 08:48:24 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 --- Comment #5 from Julian Maurice --- 1/ Do a fresh 3.8 install 2/ Do some reserves 3/ Check your old_reserves table is empty 4/ Update your sources to 3.10 5/ Run updatedatabase.pl 6/ Your reserves table is now empty! Now repeat steps 1 to 4, then apply the patch and run updatedatabase.pl Your reserves table should still contains the reserves made at step 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 12:43:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 10:43:50 +0000 Subject: [Koha-bugs] [Bug 10192] New: Add {ISBN13} as new parameter to OPACSearchForTitleIn Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10192 Bug ID: 10192 Summary: Add {ISBN13} as new parameter to OPACSearchForTitleIn Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de The {ISBN} will only provide you with a ISBN10, never with a ISBN13, even if one is present in the record. This is because we actually force ISBN10 in GetNormalizedISBN. Some newer services need ISBN13 to work correctly, so we should also make that available in the templates and OPACSearchForTitleIn. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 13:18:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 11:18:58 +0000 Subject: [Koha-bugs] [Bug 10176] Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 13:19:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 11:19:00 +0000 Subject: [Koha-bugs] [Bug 10176] Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17953|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 17954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17954&action=edit [PASSED QA] Bug 10176: Solve the Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols I just add use utf8; to the Search.pm and the problem was solved . Test plan : 1- Add bib records with non-latin characters 2- search for some of these records 3- try to refine your search using Subject / Author Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work fixing URLs in facets. Now they work correctly. No errors. Signed-off-by: Katrin Fischer Passes all tests and QA script. I tested facets with the 22 Arabic records provided on bug 9579 successfully. Before the patch the links are not correct, after applying the patch the links work as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 15:22:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 13:22:26 +0000 Subject: [Koha-bugs] [Bug 10193] New: Copies should be holdings as label for items on MARC view Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10193 Bug ID: 10193 Summary: Copies should be holdings as label for items on MARC view Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de The MARC view in the OPAC shows the heading "Copies" above the items table in the OPAC. We never use copies and it's also a bit confusing in translation. I think it would be better to match the other tables and use 'holdings' instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 15:24:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 13:24:56 +0000 Subject: [Koha-bugs] [Bug 10194] New: OpacHiddenItems doesn't work for MARC view Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10194 Bug ID: 10194 Summary: OpacHiddenItems doesn't work for MARC view Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de When using OpacHiddenItems the settings only hide items in the normal view, but not in the MARC view (labelled and plain). Also the items are not removed from the exported MARCXML/MARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 15:25:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 13:25:04 +0000 Subject: [Koha-bugs] [Bug 10194] OpacHiddenItems doesn't work for MARC view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10194 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 15:37:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 13:37:02 +0000 Subject: [Koha-bugs] [Bug 10195] New: Records hidden with OpacSuppression can still be accessed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10195 Bug ID: 10195 Summary: Records hidden with OpacSuppression can still be accessed Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de It's possible to access an OpacSuppression hidden record in the OPAC with a direct link to the record: Example: localhost/cgi-bin/koha/opac-detail.pl?biblionumber=299 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 15:45:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 13:45:10 +0000 Subject: [Koha-bugs] [Bug 10196] New: items table partially hidden in marc view in ccsr Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10196 Bug ID: 10196 Summary: items table partially hidden in marc view in ccsr Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com Created attachment 17955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17955&action=edit item table cut off in marc view See attached. When viewing the marc in the opac when using ccsr the items table goes behind the grey border on the right and there is not right to left scrollbar (not that I want one - but I do want to see the rest of that table). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 15:46:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 13:46:33 +0000 Subject: [Koha-bugs] [Bug 10197] New: add id tags to patron info list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197 Bug ID: 10197 Summary: add id tags to patron info list Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com Created attachment 17956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17956&action=edit element view on patron record On the patron record (and all related tabs) in the staff client the patron info appears on the top left in a list (
    ) it would be nice if that list and the list items had ID tags so you could style them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 22:06:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 20:06:17 +0000 Subject: [Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 22:06:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 20:06:19 +0000 Subject: [Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17930|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 17957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17957&action=edit [PASSED QA] Bug 10183: Remove single pixel on the serials collection page Test plan: Go on the serials collection page Check that the single pixels before and after the table have disappeared. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Pixels are removed, table functions work as before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 22:06:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 20:06:51 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 --- Comment #6 from Katrin Fischer --- Thank you, Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 23:20:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 21:20:37 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 --- Comment #7 from Katrin Fischer --- Hi Julian, thx for the test plan. It works as described, but I found something that is weird here - we are losing the suspended holds in the update process. The reserves seem ok, but the suspend_until is empty after the update. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 23:39:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 21:39:39 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 --- Comment #8 from Katrin Fischer --- Ok, I guess I found it: suspend_until is missing from the update? http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/updatedatabase.pl;h=be4dfa267c465d0e039ad2f72771892dfc41cadb;hb=92f289e9a19a61ca2bd509a0f251b13de5e4c773#l5478 Could you take a look at that and add a follow up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 5 23:47:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 21:47:43 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker --- Comment #9 from Katrin Fischer --- 2 evil data loss bugs caused by "3.09.00.025" - marking this blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 01:43:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 23:43:14 +0000 Subject: [Koha-bugs] [Bug 10089] Prevent renewing for restricted patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10089 --- Comment #5 from David Cook --- (In reply to comment #4) > I would have add Lyon3 right away in the list copy of this bug , I 'm > confused. I didn't see you had already worked on it and also treated the > restricted problem in the patch I proposed yesterday for bug 8236 (unlike I > was supposed to do, I changed my mind). > > Olivier Crouzet Olivier, I added a link to this bug on bug 8236 (see comment #32) when I opened this one. I thought it might be rude to add Lyon3's email to the CC list, but I'll keep it in mind for next time ;). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 01:54:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 05 May 2013 23:54:43 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #39 from David Cook --- (In reply to comment #34) > Created attachment 17926 [details] [review] > Bug 8236 Block renewing for overdue items > > At the end , I found more convenient to deal with the restriction case in > same patch. > I keep what seems to be the existing logic - a patron can't renew when he's > restricted (his opac file is freezen) - > making it more consistent. Any renewal for a restricted patron is now also > blocked from webservice and clearly not possible from the pro interface > unless by checking 'override_limit'. > If someone would like to allowed renewal for restricted patrons, I think it > would be not very complicated to add a syspref ( a line of code in > HasWhateverRenewalToBeBlocked and some addings in opac-user.tt) > As for the main object of the patch - blocking for late document - I made > some ajustements you pointed out and one change in the logic : > rather than hiding the 'Renew all' button, I move the checking in > renewscript.pl. So, this button is always available in case of big list of > checkouts items. Olivier, I'm not sure that I completely understand what you are saying, but I think it's quite important to not allow any renewals for restricted patrons at all and that the button should not be visible for a restricted patron, as Owen mentioned in bug 10089. In Comment 33, you mention that we should leave renewals for restricted patrons up to the discretion of the librarian, but I don't think this is a good idea. First, we block all check outs for restricted patrons. Renewals really are just another type of check out, so logically it makes sense to block these too. Second, even though there is red text saying the patron is blocked, I have reported cases where library staff have accidentally ignored this and renewed patrons away (much to the chagrin of their co-workers/supervisors). I think it's necessary to enforce the prevention of renewals for restricted patrons. In any case, I think these are still conceptually two different issues that should probably be handled by different patches. That said, I haven't looked at your newest code. If you prevent all renewals for restricted patrons in all cases and hide the renew buttons, as Owen suggested in bug 10089, then I would have no problem using your patch instead of mine. In all honesty, another reason I separated the patches is because I wanted the "prevent renewals for restricted patrons" behaviour to be introduced as quickly as possible. The more atomic the patch, the easier it is to test/QA, and the faster it gets into the codebase. Rant aside, once you rebase this patch, I'd be more than happy to test it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 08:08:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 06:08:42 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9891 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 08:08:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 06:08:42 +0000 Subject: [Koha-bugs] [Bug 9891] Current suspend holds have disappeared In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10185 --- Comment #4 from Katrin Fischer --- I think I found the reason for this. When we introduced a unique key for the reserves and old_reserves table the statements were missing the suspend_until column as far as I can see. There is another problem with this peculiar database update that is on bug 10185. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 08:09:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 06:09:56 +0000 Subject: [Koha-bugs] [Bug 9891] Current suspend holds have disappeared In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9891 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 08:36:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 06:36:57 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff Severity|blocker |critical --- Comment #10 from Julian Maurice --- It seems that 'suspend' is missing too http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/updatedatabase.pl;h=be4dfa267c465d0e039ad2f72771892dfc41cadb;hb=92f289e9a19a61ca2bd509a0f251b13de5e4c773#l5109 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 08:45:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 06:45:39 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 --- Comment #11 from Julian Maurice --- Created attachment 17958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17958&action=edit Bug 10185: Add missing columns in update 3.09.00.025 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:08:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:08:28 +0000 Subject: [Koha-bugs] [Bug 10105] Gate register module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105 --- Comment #2 from vimal kumar --- Thank you for accepting this feature to add in Koha 3.14. University Grants Commission in India instructed to college libraries to implement automatic gate register in libraries. This feature will be an addon advantage for Koha users. Suggestions ............................ Need interface / provision to record entry and exit of library user. If so, library staff can collect statistics of how much time students spend in library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:09:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:09:47 +0000 Subject: [Koha-bugs] [Bug 10105] Gate register module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105 --- Comment #3 from Chris Cormack --- (In reply to comment #2) > Thank you for accepting this feature to add in Koha 3.14. > University Grants Commission in India instructed to college libraries to > implement automatic gate register in libraries. This feature will be an > addon advantage for Koha users. > > Suggestions > ............................ > > Need interface / provision to record entry and exit of library user. > If so, library staff can collect statistics of how much time students spend > in library. Actually what I said was that it sounds like a great candidate for a plugin, not being part of Koha proper. >From 3.12 on Koha will support plugins. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:18:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:18:57 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #51 from Magnus Enger --- I think the main objection to using DBIx::Class in Koha has been concerns about speed? It looks like the newest release addresses that: http://jjnapiorkowski.typepad.com/modern-perl/2013/05/perl-dbixclass-an-awesome-orm-now-with-super-speed.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:26:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:26:13 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #110 from M. de Rooy --- (In reply to comment #105) > This may be the only time in bugzilla history where a link to a video of a game is appropriate. :-) (In reply to comment #106) Thanks for your reply, but I still disagree. Nevertheless I propose to end that discussion here.. (In reply to comment #107) > I don't know why, a remainder of the first patch still exists on master, which cause some trouble with encoding. Communicated this with Jared on bug 10070. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:29:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:29:43 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:29:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:29:54 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17187|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:35:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:35:21 +0000 Subject: [Koha-bugs] [Bug 9897] members/member.pl double encoded utf-8 strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9897 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from M. de Rooy --- (In reply to comment #1) > Fortunately bug 6554 has nice side-effect of side-stepping this problem > completely because it fixes encoding all over koha. Unfortunately :) this has been reverted.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:36:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:36:25 +0000 Subject: [Koha-bugs] [Bug 10019] Encoding problem with utf8 chars in userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10019 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |WONTFIX --- Comment #10 from M. de Rooy --- Reverted. Closing this report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:37:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:37:03 +0000 Subject: [Koha-bugs] [Bug 10074] Encoding problems for login and installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10074 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |WONTFIX --- Comment #24 from M. de Rooy --- Reverted. Closing this report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:37:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:37:46 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 --- Comment #52 from Paul Poulain --- (In reply to comment #51) > I think the main objection to using DBIx::Class in Koha has been concerns > about speed? It looks like the newest release addresses that: > http://jjnapiorkowski.typepad.com/modern-perl/2013/05/perl-dbixclass-an- > awesome-orm-now-with-super-speed.html The other concern, if i'm not wrong, is that the schema requires a lot of time to load. In persistent mode, it can be ignored, as it's made one. So we must have plack working before introducing DBIx::Class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:37:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:37:54 +0000 Subject: [Koha-bugs] [Bug 10118] [MASTER_ONLY] Problem with diacritics on 'pay fines' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10118 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from M. de Rooy --- (In reply to comment #3) > Bug 6554 has been reverted. Closing this report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:38:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:38:27 +0000 Subject: [Koha-bugs] [Bug 10114] Encoding problems in Search url's In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10114 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from M. de Rooy --- (In reply to comment #1) > I have been working on this while its base was reverted. Closing this report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:41:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:41:27 +0000 Subject: [Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 --- Comment #14 from Jonathan Druart --- (In reply to comment #7) > Created attachment 17110 [details] [review] > Bug 8278 : Follow up, fixing the permissions on cataloguing/ysearch.pl Katrin, could you confirm this patch fixes your issue please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:44:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:44:48 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16168|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:48:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:48:30 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16639|application/octet-stream |text/plain mime type| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:53:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:53:50 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 --- Comment #12 from Katrin Fischer --- Good catch, Julian! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 09:57:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 07:57:18 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- Kyle, I just see you wrote in your commit message "off by default". So maybe my patch is useless? I don't want to impose this choice :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 11:52:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 09:52:14 +0000 Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range for fields 1xx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252 --- Comment #11 from Paul Poulain --- hi Mathieu, Trying to investigate this patch, because it's a useful improvement I haven't tested it yet, but i'm QAing first. (disclaimer : when I say "MARC21", I mean MARC21 and NORMAC, that are very close) I find some strange things: * Country of publication + 'Country-publication', => you add this entry, just for UNIMARC. Isn't it relevant for MARC21 ? The LoC use Country-publication for 1053, so your choice is OK (http://www.loc.gov/z3950/agency/defns/bib1.html) * in MARC21, there's a use of Date/time-last-modified, not Date-time-last-modified : etc/zebradb/marc_defs/normarc/biblios/record.abs:# NiN melm 005 Date/time-last-modified etc/zebradb/marc_defs/marc21/biblios/record.abs:melm 005 Date/time-last-modified etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml: etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml: Date/time-last-modified:w etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl: => WHY this change ? * music publisher: you change -att 51 Number-music-publisher +att 51 Music-number but number-music-publisher is used by MARC21, so why do you remove it ? I think we could/should use Identifier-publisher-for-music everywhere, as it's bib1 attribute name for LoC (http://www.loc.gov/z3950/agency/bib1.html) I have no other comments, except a general one = it would have been much easier to test this patch if it had been splitted in smaller ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 11:57:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 09:57:42 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 12:02:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 10:02:26 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 --- Comment #6 from Katrin Fischer --- Hi Owen, maybe I got a bit lot between records and items here - does it mean the last item on the record or the last entry in the list of records? I think I tried both and it worked, but I could try to reproduce again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 12:08:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 10:08:42 +0000 Subject: [Koha-bugs] [Bug 9833] New shelves permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |matthias.meusburger at biblibr |ity.org |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 12:19:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 10:19:08 +0000 Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range for fields 1xx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252 --- Comment #12 from mathieu saby --- Hello Paul For 1. Country of publication In UNIMARC, country of publication is stored in 102$a In MARC21 in 044a and 044c in 2 different formats (http://www.loc.gov/marc/bibliographic/bd044.html) In current UNIMARC record.abs, there is melm 102$a Country-heading In current MARC21 record.abs, there is nothing for 044 So countries are supposed to be indexed in UNIMARC Koha. BUT, this is not working, because : In Bib1, there is this attribute "att 1053 Country-publication", and no attribute "Country-heading" In current ccl.properties, there is neither Country-heading nor Country-publication I don't know how to index countries in MARC21. It could be done by some MARC21 guy in an other patch if they find it useful. For 2. music publisher I took this page as a reference the name of the index in UNIMARC record.abs, but you are true, we would better use the name defined in bib1. For 3. "Date/time-last-modified" I found some cases where the "/" was changed to a "-", so I supposed there were some reason for that. for ex : the "official" bib1 1011 is "Date/time added to db " but in Koha it is "date-entered-on-file" But in Koha we have other att names with "/" att 1013 Authority/format-id and att 1075 Subject-genre/form Can you confirm me the "/" in an attribute name is not breaking anything ? If it not the case, my change was not useful, and that we can keep the "/". I will make a followup for 2 and 3. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 12:35:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 10:35:46 +0000 Subject: [Koha-bugs] [Bug 10198] New: Add the ability to import and export authorized values Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10198 Bug ID: 10198 Summary: Add the ability to import and export authorized values Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: mathieu.saby at univ-rennes2.fr CC: gmcharlt at gmail.com We can not import and export easily from staff interface a list of authorized values (in CSV or SQL). It would be useful. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 13:45:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 11:45:12 +0000 Subject: [Koha-bugs] [Bug 10199] New: Move fields type, options and explanation from systempreferences table? Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10199 Bug ID: 10199 Summary: Move fields type, options and explanation from systempreferences table? Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: In Discussion Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl CC: gmcharlt at gmail.com Currently, only local use preferences use the fields options and explanation. The normal preferences ignore these fields; they come from the YAML file now (.pref file). The use of type is somewhat hybrid. There are still some references in the code (especially for YesNo), but the preferences script again looks at the YAML file. My question is: Saving a pref file for the local use prefs does not seem an option (at least from the web interface). But could we move them elsewhere? Separate table? Another idea? If you would delete a regular pref from the yaml file now, but not from the database, it will popup without an explanation or an older one and perhaps without options or older options in the local use tab. How do you think that we should resolve this situation best? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 14:23:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 12:23:29 +0000 Subject: [Koha-bugs] [Bug 10176] Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. This problem actually occurs only with Arabic characters as far as I can tell- Cyrillic works fine even without the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 14:24:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 12:24:18 +0000 Subject: [Koha-bugs] [Bug 8798] Add the use of DBIx::Class In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8798 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #53 from Kyle M Hall --- I had a conversation with Chris Cormack about this and he didn't raise any such concerns. Maybe we should ask him if he thinks this is not a problem or if it was something neither of us thought about at the time. Chris's primary concern was that we should always be able to make direct SQL queries when we need to for speed, but DBIx::Class allows for that quite easily. This conversation took place when I wrote my proof of concept using DBIx::SearchBuilder as an alternative. After the conversation I deprecated that patch in favor of using DBIx::Class. (In reply to comment #52) > (In reply to comment #51) > > I think the main objection to using DBIx::Class in Koha has been concerns > > about speed? It looks like the newest release addresses that: > > http://jjnapiorkowski.typepad.com/modern-perl/2013/05/perl-dbixclass-an- > > awesome-orm-now-with-super-speed.html > > The other concern, if i'm not wrong, is that the schema requires a lot of > time to load. In persistent mode, it can be ignored, as it's made one. > > So we must have plack working before introducing DBIx::Class. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 14:25:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 12:25:25 +0000 Subject: [Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 14:40:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 12:40:00 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. I did a small follow-up which I am pretty sure will be necessary when someone addresses the maxholds issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 14:52:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 12:52:38 +0000 Subject: [Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. I was unable to test this, because between the revised serials history patches and previously applying these patches the Serials module in my test installation is wholly unusable. I will revert from 3.12.x at the first complaint, but I did not want to bump it to 3.14 if that isn't necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 15:05:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 13:05:16 +0000 Subject: [Koha-bugs] [Bug 9681] Add some indexes in database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9681 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com QA Contact| |paul.poulain at biblibre.com Severity|enhancement |normal --- Comment #4 from Paul Poulain --- QA comments : * this patch just adds some indexes, no possible side effect * it will speed up a lot some of the statistics SQL queries, so bumping severity from "ENH" to "NOR". Including this patch for 3.12 is RM choice, but I think it's worth it * tested updatedatabase and kohastructure.sql, everything OK Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 15:05:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 13:05:56 +0000 Subject: [Koha-bugs] [Bug 10068] Move from the utf8:: pragma methods to Encode:: In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10068 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17501|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 15:06:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 13:06:12 +0000 Subject: [Koha-bugs] [Bug 10068] Move from the utf8:: pragma methods to Encode:: In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10068 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17502|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 15:07:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 13:07:27 +0000 Subject: [Koha-bugs] [Bug 9681] Add some indexes in database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9681 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15642|0 |1 is obsolete| | --- Comment #5 from Paul Poulain --- Created attachment 17959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17959&action=edit Bug 9681: Add some indexes in database Some table columns should have an index to speed SQL queries : - statistics table has only one index (used to make heavy queries for reports) - itemtype should have an index in items and biblioitems (this is used in circulation to check the number of existing issues of a specific item type) - issue.branchcode and issue.issuingbranch Test plan : - Create a new database using kohastructure.pl => check there is no SQL error and that new indexes are present (mysql> show create table) Apply update database on a master version => check there is no SQL error and that new indexes are present (mysql> show create table) Signed-off-by: Bernardo Gonzalez Kriegel Comment: Indexes created as described. No errors. Fixing small merge conflict. Test presence of new indexes on all affected tables. Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 15:26:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 13:26:57 +0000 Subject: [Koha-bugs] [Bug 9951] Resolve encoding problems where script parameters are not decoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9951 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |WONTFIX --- Comment #10 from M. de Rooy --- Has been reverted. Closing this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 15:27:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 13:27:49 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #43 from Owen Leonard --- Why "In discussion?" Sounds to me like a correction is needed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 15:41:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 13:41:20 +0000 Subject: [Koha-bugs] [Bug 10200] New: Add more Independent Branches options Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Bug ID: 10200 Summary: Add more Independent Branches options Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com * Hide from the staff client search results any records that do not have an item owned by the library of the logged in user, controlled by the system preference IndependentBranchesIntranetSearch. Note, this will not hide any items from other libraries, it will just filter out any records that are not "relevant" to the logged in library. * Hide from the OPAC search results any records that do not have an item owned by the library defined in the environment variable BRANCHCODE defined in the VirtualHost configuration for a given OPAC. * Prevent any library from editing a MARC record unless that user's branchcode matches the branchcode in the MARC subfield which is defined as the owning branch of that MARC record (951$o). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 15:47:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 13:47:58 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 --- Comment #1 from Kyle M Hall --- Created attachment 17960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17960&action=edit Bug 10200 - Add more Independent Branches options - Part 1 - IndependentBranchesIntranetSearch Enabling IndependentBranchesIntranetSearch will automatically add a branch limit filter to the search results thus hiding all records without one or more items owned by the logged in library, including records with no items attached. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Perform a search that will give results for both records which have items owned by the logged in library, and records which have no items owned by the logged in library. 4) Enable the new system preference IndependentBranchesIntranetSearch 5) Perform the same search again, any records without items owned by the currently logged in library should not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 15:50:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 13:50:57 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17960|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 17961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17961&action=edit Bug 10200 - Add more Independent Branches options - Part 1 - IndependentBranchesIntranetSearch Enabling IndependentBranchesIntranetSearch will automatically add a branch limit filter to the search results thus hiding all records without one or more items owned by the logged in library, including records with no items attached. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Perform a search that will give results for both records which have items owned by the logged in library, and records which have no items owned by the logged in library. 4) Enable the new system preference IndependentBranchesIntranetSearch 5) Perform the same search again, any records without items owned by the currently logged in library should not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 15:50:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 13:50:56 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 16:00:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 14:00:36 +0000 Subject: [Koha-bugs] [Bug 10201] New: Old OPAC patron update system should be removed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Bug ID: 10201 Summary: Old OPAC patron update system should be removed Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org With the addition of opac-memberentry.pl and the patron update moderation system in the staff client the old system should be removed: opac-userdetails.pl and opac-userupdate.pl. Several OPAC templates link to these pages even though they should be obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 16:01:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 14:01:25 +0000 Subject: [Koha-bugs] [Bug 10202] New: series searching searches author Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10202 Bug ID: 10202 Summary: series searching searches author Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com Created attachment 17962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17962&action=edit series link in the opac See attached. When you have series info cataloged in the 800: 800 1# - SERIES ADDED ENTRY--PERSONAL NAME Personal name No?l, Alyson. Title of a work Soul seekers ; Volume/sequential designation bk. 2. It shows on the bib record linked (which is good) but it's searching for the author in the series instead of the series title (which is bad). The link is: /cgi-bin/koha/opac-search.pl?q=se,phr:%22No%C3%ABl,%20Alyson.%22 but it should be /cgi-bin/koha/opac-search.pl?q=se,phr:%22Soul%20seekers%22 Or both the author and the series name - but not just the author. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 16:05:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 14:05:44 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 16:07:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 14:07:26 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 16:32:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 14:32:00 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 --- Comment #3 from Kyle M Hall --- Created attachment 17963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17963&action=edit Bug 10200 - Add more Independent Branches options - Part 2 - IndependentBranchesOpacSearch Enabling IndependentBranchesIntranetSearch will automatically add a branch limit filter to the search results thus hiding all records without one of more items owned by the library as defined by the webserver environment variable BRANCHCODE for the given OPAC, including records with no items attach. Test Plan: 1) Apply the patch 2) Run updatedatabase.pl 3) Add this line to the http-conf for your OPAC: SetEnv BRANCHCODE "MPL" Replace MPL with the branchcode you want to use for this test 4) Perform a search that will give results for both records which have items owned by the set library, and records which have no items owned by the set library. 5) Enable the new system preference IndependentBranchesOpacSearch 6) Perform the same search again, any records without items owned by the library set in the BRANCHCODE environment variable should not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 16:38:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 14:38:49 +0000 Subject: [Koha-bugs] [Bug 10105] Gate register module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105 --- Comment #4 from Jared Camins-Esakov --- (In reply to comment #2) > Thank you for accepting this feature to add in Koha 3.14. If you want this feature in Koha 3.14, you might want look into finding a developer to write a plugin to provide it (or consider writing one yourself, if you are able to do this sort of development in your current position). Chris did not volunteer to spend any time on it, just suggested a way for this to be implemented by someone else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 17:41:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 15:41:16 +0000 Subject: [Koha-bugs] [Bug 10203] New: print labels based on range of barcodes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10203 Bug ID: 10203 Summary: print labels based on range of barcodes Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label printing Assignee: cnighswonger at foundations.edu Reporter: nengard at gmail.com It would be nice to enter a first and last barcode on the label creator to add barcodes in a batch to the label creator for printing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 17:51:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 15:51:41 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 17:51:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 15:51:43 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 --- Comment #1 from Owen Leonard --- Created attachment 17964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17964&action=edit Bug 10201 - Old OPAC patron update system should be removed The old pages for viewing and updating patron details in the OPAC have been superceded by the new script opac-memberentry.pl. This patch removes he old scripts and templates and corrects links to them. This patch also removes reference to opac-userupdate.tt from opac-patron-image.pl and replaces the authentication process with one which uses check_cookie_auth, based on the example of opac-tags.pl. To test, edit a patron record and set the "Gone no address" flag. Log in to the OPAC with that account and view the patron details page. The warning about out of date contact information should link to the new update page. Next, attempt to place a hold. You should see the same warning, and it should also link to the new update page. Test the display of patron images: Log in as a user who has an image associated with their account and navigate to /cgi-bin/koha/opac-patron-image.pl. Their patron image should display. A search of Koha source files should return no results for the missing scripts or templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 17:57:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 15:57:20 +0000 Subject: [Koha-bugs] [Bug 10204] New: Patron image no longer appears in the OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10204 Bug ID: 10204 Summary: Patron image no longer appears in the OPAC Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org With the replacement of opac-userupdate.pl with opac-memberentry.pl there is now no place where the patron will see their patron image. The patron image should be added to opac-memberentry.pl in order to maintain the functionality of the previous version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 18:37:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 16:37:48 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 18:40:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 16:40:21 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 18:43:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 16:43:54 +0000 Subject: [Koha-bugs] [Bug 10204] Patron image no longer appears in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10204 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 18:44:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 16:44:12 +0000 Subject: [Koha-bugs] [Bug 10204] Patron image no longer appears in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10204 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 18:44:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 16:44:14 +0000 Subject: [Koha-bugs] [Bug 10204] Patron image no longer appears in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10204 --- Comment #1 from Owen Leonard --- Created attachment 17965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17965&action=edit Bug 10204 - Patron image no longer appears in the OPAC With the addition of opac-memberentry.pl to the OPAC we lost a way to display the image associated with a patron's account. This patch adds display of the patron image to opac-memberentry.pl now that opac-userdetails.pl and opac-userupdate.pl are deprecated. To test: 1. Log into the OPAC as a patron who has an image associated with their account. View the "my personal details" tab and confirm that the patron image appears with and without OPACPatronDetails enabled. 2. Log into the OPAC as a patron who has no image associated with their account. View the "my personal details" tab and confirm that the layout looks correct. 3. Turn off OPACpatronimages and confirm that the "my personal details" page looks correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 19:16:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 17:16:31 +0000 Subject: [Koha-bugs] [Bug 9906] Holds Return Policy and Local Hold Item Types not working as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9906 --- Comment #2 from Heather Braum --- Created attachment 17966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17966&action=edit Basehor's Local Hold Settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 19:17:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 17:17:03 +0000 Subject: [Koha-bugs] [Bug 9906] Holds Return Policy and Local Hold Item Types not working as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9906 --- Comment #3 from Heather Braum --- Created attachment 17967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17967&action=edit Leavenworth's hold policy settings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 19:17:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 17:17:48 +0000 Subject: [Koha-bugs] [Bug 9906] Holds Return Policy and Local Hold Item Types not working as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9906 --- Comment #4 from Heather Braum --- Katrin, I just saw your response when I came back to relook at this bug report. When you check in a local hold item from library A at library B, if a patron at library B has a hold on it, a hold is triggered for a patron at library B. This is unexpected behavior. Items with the local hold item type are only supposed to trigger holds for patrons at the item's HOME library. I screencasted an example, but can't attach the video file here and also realized I don't want all the patrons names exposed online, so I can't even share the video file. The testing process: I set my home library to Leavenworth and checked in a Basehor local hold item. The process triggered a hold for a Leavenworth patron. The expected behavior should have been to trigger a hold for ONLY a Basehor patron OR prompt the library to return the item back to Basehor. That behavior has always been previously how local holds worked in the past on Koha. I am also attaching screenshots of the holds policy by item type for the two libraries I was using to test this situation with. Please let me know if you need further detail for testing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 19:24:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 17:24:03 +0000 Subject: [Koha-bugs] [Bug 10205] New: koha-create error handling Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10205 Bug ID: 10205 Summary: koha-create error handling Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com CC: robin at catalyst.net.nz koha-create should do more error checking. It should be more clear when failing to do some task. - Parameter combinations should be checked. - Instancename lenght check. - -h|--help switch with better output. - Database name lenght/validity check (for --database and passwd file). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 19:24:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 17:24:29 +0000 Subject: [Koha-bugs] [Bug 10205] koha-create error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10205 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #1 from Tom?s Cohen Arazi --- *** Bug 7428 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 19:24:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 17:24:29 +0000 Subject: [Koha-bugs] [Bug 7428] koha-create should check for length of instancename In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7428 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |tomascohen at gmail.com Resolution|--- |DUPLICATE --- Comment #3 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 10205 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 20:01:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 18:01:56 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #40 from Kyle M Hall --- Created attachment 17968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17968&action=edit Bug 7441 - search results showing wrong branch? - Followup - Delete Koha TT Plugin Deletes the Koha TT Plugin from this patch series, to move it to it's own bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 20:28:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 18:28:17 +0000 Subject: [Koha-bugs] [Bug 10206] New: Add Koha TT Plugin Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Bug ID: 10206 Summary: Add Koha TT Plugin Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com This plugin is meant to be a place to put general purpose TT functions directly related to Koha. If a plugin is not a filter, and does not have more than one subroutine, that subroutine most likely belongs in this TT plugin. This first and only function the plugin currently has is Preference, which allows a template to get the value of a system preference without, it needing to be passed in from a perl script. This plugin was already tested and signed off as part of bug 7441. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 20:29:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 18:29:16 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10206 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 20:29:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 18:29:16 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7441 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 20:29:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 18:29:35 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 20:29:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 18:29:55 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 20:29:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 18:29:56 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 --- Comment #1 from Kyle M Hall --- Created attachment 17969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17969&action=edit Bug 10206 - Add Koha TT Plugin - Koha.Preference This plugin is meant to be a place to put general purpose TT functions directly related to Koha. If a plugin is not a filter, and does not have more than one subroutine, that subroutine most likely belongs in this TT plugin. This first and only function the plugin currently has is Preference, which allows a template to get the value of a system preference without, it needing to be passed in from a perl script. This plugin was already tested and signed off as part of bug 7441. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 20:30:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 18:30:58 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #41 from Kyle M Hall --- This patch now depends on bug 10206 for the Koha TT Plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 20:31:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 18:31:10 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10206 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 20:31:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 18:31:10 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10200 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 20:34:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 18:34:34 +0000 Subject: [Koha-bugs] [Bug 9737] Local Covers sometimes appear then disappear on OPAC Search Results/Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9737 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #17 from Manos PETRIDIS --- Will this fix be added to 3.08? I'm at 3.08.12.000 but the problem persists. Having reported this behaviour back in August ( http://lists.katipo.co.nz/public/koha/2012-August/033902.html up to http://lists.katipo.co.nz/public/koha/2012-August/033936.html ) I feel happy that it finally got to be solved, but I have no idea on how to push my installation up the release ladder. Manos PETRIDIS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 20:40:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 18:40:23 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 21:21:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 19:21:25 +0000 Subject: [Koha-bugs] [Bug 10207] New: can't renew if holds waiting to be triggered Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10207 Bug ID: 10207 Summary: can't renew if holds waiting to be triggered Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Received from a library: "I have place a hold on Fox in Socks, we have 3 copies available and the rest are checked out. Everyone who has one of the items from that record checked out can renew the item because it claims there is a hold on it, but there is 3 copies available, we just have not triggered the pending hold yet. A patron should be allowed to renew items that have holds on them if we have available copies to satisfy the pending holds." I'm thinking maybe it should be a sys pref or a circ rule or something to control if you can renew or not if there are holds. That's the only solution I can think of in this case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 21:33:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 19:33:35 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #12 from Kyle M Hall --- (In reply to comment #11) > Kyle, I just see you wrote in your commit message "off by default". So maybe > my patch is useless? I don't want to impose this choice :) I personally think it should be off by default, but it can be switched by a bit of jquery either way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 21:57:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 19:57:33 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 22:25:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 20:25:03 +0000 Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range for fields 1xx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16945|0 |1 is obsolete| | --- Comment #13 from mathieu saby --- Created attachment 17970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17970&action=edit [PATCH 1] Bug 8252: Fix indexing of UNIMARC 1xx for GRS-1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 22:25:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 20:25:42 +0000 Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range for fields 1xx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16946|0 |1 is obsolete| | --- Comment #14 from mathieu saby --- Created attachment 17971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17971&action=edit [PATCH 2] Bug 8252: Fix indexing of UNIMARC 1xx for DOM -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 22:26:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 20:26:45 +0000 Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range for fields 1xx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252 --- Comment #15 from mathieu saby --- Created attachment 17972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17972&action=edit [PATCH 3] Bug 8252 : Followup for Date/time-last-modified and Music number This followup restores the original wording of "Date/time-last-modified" index, and change the name of "Music-number" index to "Number-music-publisher" To test : 1. In a UNIMARC Koha instance 2. apply patchs #1, #2 and this followup 3. copy from src/etc/zebradb directory to the etc/zebradb/ in your main koha directory the following files : -- zebradb/biblios/etc/bib1.att -- zebradb/ccl.properties -- zebradb/marc_defs/unimarc/biblios/record.abs -- zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml -- zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl 4. rebuild zebra with -b -x -v -r options 5. write a value like "test071a" in 071$a field in a record 6. check if you can find this record with this search : "ccl=Number-music-publisher:test071a" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 22:28:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 20:28:40 +0000 Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range for fields 1xx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252 --- Comment #16 from mathieu saby --- I added some precisions to test plans for patch 1 and 2 (for example to test patch 2 you need to apply patch 1 before) patch 3 is a followup reverting the change of Date/time-last-modified index, and renaming Music-number index. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 6 22:36:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 20:36:52 +0000 Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range for fields 1xx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252 --- Comment #17 from mathieu saby --- There is a warn when you rebuild zebra, but I think it is not linked with my patches (22:03:02-06/05 zebraidx(13748) [warn] Unknown register type: ) M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 01:17:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 23:17:51 +0000 Subject: [Koha-bugs] [Bug 10208] New: The ability to order multiple copies of the same title Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10208 Bug ID: 10208 Summary: The ability to order multiple copies of the same title Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: amit.gupta at osslabs.biz The ability to order multiple copies of the same title, from the same fund class on the same order number, by inserting a number in the quantity box and not having to use the plus sign. It is very tedious when ordering 12 copies of a reading group title to have to click on the plus sign twelve times to order 12 copies. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 01:18:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 23:18:18 +0000 Subject: [Koha-bugs] [Bug 10208] The ability to order multiple copies of the same title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10208 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com Assignee|koha-bugs at lists.koha-commun |amit.gupta at osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 01:19:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 23:19:12 +0000 Subject: [Koha-bugs] [Bug 10209] New: The ability to order multiple copies of the same item, from different fund classes, on the same order number Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Bug ID: 10209 Summary: The ability to order multiple copies of the same item, from different fund classes, on the same order number Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: amit.gupta at osslabs.biz The ability to order multiple copies of the same item, from different fund classes, on the same order number -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 01:19:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 06 May 2013 23:19:50 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes, on the same order number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com Assignee|koha-bugs at lists.koha-commun |amit.gupta at osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 04:50:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 02:50:17 +0000 Subject: [Koha-bugs] [Bug 10210] New: how to checkout an item without barcode Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10210 Bug ID: 10210 Summary: how to checkout an item without barcode Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: dmuralikrishna555 at gmail.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com i need to check out an item without using barcode....i want to checkout an item by using serial number or accession number..... Please help me in this regard. Awaiting reply thanks in advance.... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 08:17:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 06:17:29 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master --- Comment #13 from Katrin Fischer --- We will need this fix in all versions that have this database update - setting version to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 08:36:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 06:36:59 +0000 Subject: [Koha-bugs] [Bug 10211] New: Remove deprecated Z39.50.pm code Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10211 Bug ID: 10211 Summary: Remove deprecated Z39.50.pm code Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au CC: m.de.rooy at rijksmuseum.nl I think that Z39.50.pm is all deprecated code and that it can safely be removed. I grepped for a reference to it, and only noticed references in Makefile and Makefile.old. When I grepped for the subs in the module, I only found references within the same module: grep -R -i "getz3950servers" * --exclude-dir="translator" --exclude-dir="installer" --exclude-dir="ar-Arab" --exclude-dir="fr-FR" --exclude-dir="blib" C4/Z3950.pm: &getz3950servers C4/Z3950.pm:=item getz3950servers C4/Z3950.pm: @servers= &getz3950servers(checked); C4/Z3950.pm:sub getz3950servers { t/db_dependent/lib/KohaTest/Z3950.pm: my @methods = qw( getz3950servers C4/Z3950.pm: &z3950servername C4/Z3950.pm:=item z3950servername C4/Z3950.pm: $name = &z3950servername($dbh, $server_id, $default_name); C4/Z3950.pm:sub z3950servername { C4/Z3950.pm:} # sub z3950servername t/db_dependent/lib/KohaTest/Z3950.pm: z3950servername C4/Z3950.pm: &addz3950queue C4/Z3950.pm:=item addz3950queue C4/Z3950.pm: $errmsg = &addz3950queue($query, $type, $request_id, @servers); C4/Z3950.pm:C<&addz3950queue> sends a SIGHUP to the daemon to tell it to process C4/Z3950.pm:C<&addz3950queue> returns an error message. If it was successful, the C4/Z3950.pm:sub addz3950queue { C4/Z3950.pm:} # sub addz3950queue t/db_dependent/lib/KohaTest/Z3950.pm: addz3950queue C4/Z3950.pm: &checkz3950searchdone C4/Z3950.pm:=item &checkz3950searchdone C4/Z3950.pm: $numberpending= & &checkz3950searchdone($random); C4/Z3950.pm:sub checkz3950searchdone { t/db_dependent/lib/KohaTest/Z3950.pm: checkz3950searchdone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 08:45:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 06:45:19 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 --- Comment #14 from Katrin Fischer --- Created attachment 17973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17973&action=edit [PASSED QA] Bug 10185: Add missing columns in update 3.09.00.025 Signed-off-by: Katrin Fischer SQL only changes fixing an important database update. IMPORTANT: Patches must be backported to all versions containing the database update 3.09.00.025. I used the test plan provided by Julian with some additions: 1/ Do a fresh 3.8 install 2/ Do some reserves 3/ Check your old_reserves table is empty 4/ Update your sources to 3.10 5/ Run updatedatabase.pl 6/ Your reserves table is now empty! I made sure I had item level and title level holds, also suspended holds. I repeated the test with entries in my old_reserves table (cancelled and filled holds) to make sure this is also still working correctly. Before the patch we lost all suspended holds and when the old_reserves table was empty also all holds in general. After the patch the reserve_id is added but the other data in both tables is not altered. NOTE: Adding the reserve_id first to old_reserves and then to reserves we are missing one id in between. old_reserves: 1,2,3 reserves: 5,6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 08:47:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 06:47:33 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 08:47:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 06:47:43 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17958|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 08:47:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 06:47:57 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17973|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 08:48:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 06:48:16 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off QA Contact| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 08:48:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 06:48:31 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 --- Comment #15 from Katrin Fischer --- Created attachment 17974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17974&action=edit [PASSED QA] Bug 10185: Fix update 3.09.00.025 It can remove all reserves from reserves table when there is no entries in old_reserves. This is due to @ai which is set to NULL in SET @ai = ( SELECT MAX( reserve_id ) FROM tmp_reserves ) and reserve_id > NULL returns no results in INSERT INTO reserves SELECT * FROM tmp_reserves WHERE reserve_id > @ai Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Test plan and comments on second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 08:48:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 06:48:40 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 --- Comment #16 from Katrin Fischer --- Created attachment 17975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17975&action=edit [PASSED QA] Bug 10185: Add missing columns in update 3.09.00.025 Signed-off-by: Katrin Fischer SQL only changes fixing an important database update. IMPORTANT: Patches must be backported to all versions containing the database update 3.09.00.025. I used the test plan provided by Julian with some additions: 1/ Do a fresh 3.8 install 2/ Do some reserves 3/ Check your old_reserves table is empty 4/ Update your sources to 3.10 5/ Run updatedatabase.pl 6/ Your reserves table is now empty! I made sure I had item level and title level holds, also suspended holds. I repeated the test with entries in my old_reserves table (cancelled and filled holds) to make sure this is also still working correctly. Before the patch we lost all suspended holds and when the old_reserves table was empty also all holds in general. After the patch the reserve_id is added but the other data in both tables is not altered. NOTE: Adding the reserve_id first to old_reserves and then to reserves we are missing one id in between. old_reserves: 1,2,3 reserves: 5,6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 08:50:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 06:50:06 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Katrin Fischer --- Treating the second patch as a QA follow up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 09:56:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 07:56:21 +0000 Subject: [Koha-bugs] [Bug 9737] Local Covers sometimes appear then disappear on OPAC Search Results/Lists In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9737 --- Comment #18 from Chris Cormack --- (In reply to comment #17) > Will this fix be added to 3.08? I'm at 3.08.12.000 but the problem persists. > > Having reported this behaviour back in August ( > http://lists.katipo.co.nz/public/koha/2012-August/033902.html up to > http://lists.katipo.co.nz/public/koha/2012-August/033936.html ) I feel happy > that it finally got to be solved, but I have no idea on how to push my > installation up the release ladder. > > Manos PETRIDIS No, the fix does not apply to 3.8.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 09:59:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 07:59:09 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #111 from Chris Cormack --- (In reply to comment #108) > (In reply to comment #103) > > This should not be viewed as a permanent reversion, > > although I have reservations about turning on CGI.pm's -utf8 switch across > > the board -- but I have even stronger reservations about the ensuant game of > > whack-a-mole we've been playing with new bugs arising from this patch. > > Would you mind to elaborate your objections to CGI.pm's -utf8 switch? I > think that it's cleaner to take extra care about code which uses file upload > than to hand-decode every single parameter we are passing into Koha code. > > This is only my personal preference, and I am fine with whatever solution > gets eventually prefered, but I main question is if I should re-submit my > patches without -utf8 in them. >From the man page -utf8 This makes CGI.pm treat all parameters as UTF-8 strings. Use this with care, as it will interfere with the processing of binary uploads. It is better to manually select which fields are expected to return utf-8 strings and convert them using code like this: use Encode; my $arg = decode utf8=>param('foo'); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 12:21:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 10:21:12 +0000 Subject: [Koha-bugs] [Bug 9134] There is no previous link on the second page of the search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9134 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #8 from mathieu saby --- It is a bugfix, not an enhancement. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 12:22:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 10:22:53 +0000 Subject: [Koha-bugs] [Bug 9134] There is no previous link on the second page of the search results page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9134 --- Comment #9 from Chris Cormack --- Not sure that matters now, it was released 4 months ago :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 12:24:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 10:24:47 +0000 Subject: [Koha-bugs] [Bug 5992] Biblibre various improvements for 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5992 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Some of the tickets linked to this are still open - should we rename the bug/change the version or maybe better close it? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 12:41:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 10:41:03 +0000 Subject: [Koha-bugs] [Bug 8657] Default sort by call number does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8657 Manos PETRIDIS changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis at yahoo.com --- Comment #5 from Manos PETRIDIS --- I note that even in 3.08.12.000 the issue reported by Liz Rea still applies, i.e. one needs to set sort order to descending and then back to ascending for the fix to work. I had tried changing sort field (but not the sort order) several times in the past - on each version update - with no luck, and only now noticed her caveat note. Manos Petridis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 13:26:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 11:26:46 +0000 Subject: [Koha-bugs] [Bug 10211] Remove deprecated Z39.50.pm code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10211 --- Comment #1 from M. de Rooy --- Looks like you are right about it. Please do not forget some references in the unit tests (also in your grep). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 13:57:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 11:57:14 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #20 from Sophie MEYNIEUX --- Katrin, you need to give permission to your apache user to use at On your server, you should have a file /etc/at.allow containing the name of this user (www-data most of the time) and/or a file /etc/at.deny *not* containing the name of you user I'll take care to provide a new patch for QA issues -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 14:06:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 12:06:09 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #21 from Katrin Fischer --- Hi Sophie, switch back to signed off when the follow-up patch is ready for testing. Thx! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 14:45:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 12:45:04 +0000 Subject: [Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17935|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen --- Created attachment 17976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17976&action=edit Bug 9961: Add truncation support to QP driver The original implementation of QueryParser did not handle truncation based on the QueryAutoTruncate system preference. This patch adds support. To test: 1) Apply patch. 2) Turn on UseQueryParser. 3) Set QueryAutoTruncate to "automatically." 4) Search for "har". Note that it returns results with words like "Harry" (i.e. with right truncation). 5) Search for "har*". Note that it still returns results with right truncation. 6) Set QueryAutoTruncate to "only when * is added." 7) Search for "har". Note that it returns only records that have the exact word "har" in them (most likely there will be none unless you have Hebrew items). 8) Search for "har*". Note that once again it returns results for "Harry" (i.e. right truncated results). 9) Sign off. This patch also reindents a hash in Koha/QueryParser/Driver/PQF.pm because it was hard to read before. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 14:45:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 12:45:46 +0000 Subject: [Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 15:04:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 13:04:10 +0000 Subject: [Koha-bugs] [Bug 10212] New: Columns configuration for tables Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Bug ID: 10212 Summary: Columns configuration for tables Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com Some libraries would want to hide columns in tables. A configuration page would allow to select specific columns to show/hide in tables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 15:04:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 13:04:17 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 15:09:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 13:09:23 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17964|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 17977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17977&action=edit Bug 10201 - Old OPAC patron update system should be removed The old pages for viewing and updating patron details in the OPAC have been superceded by the new script opac-memberentry.pl. This patch removes he old scripts and templates and corrects links to them. This patch also removes reference to opac-userupdate.tt from opac-patron-image.pl and replaces the authentication process with one which uses check_cookie_auth, based on the example of opac-tags.pl. To test, edit a patron record and set the "Gone no address" flag. Log in to the OPAC with that account and view the patron details page. The warning about out of date contact information should link to the new update page. Next, attempt to place a hold. You should see the same warning, and it should also link to the new update page. Test the display of patron images: Log in as a user who has an image associated with their account and navigate to /cgi-bin/koha/opac-patron-image.pl. Their patron image should display. A search of Koha source files should return no results for the missing scripts or templates. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 15:09:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 13:09:43 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 15:14:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 13:14:25 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #1 from Jonathan Druart --- Created attachment 17978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17978&action=edit Bug 10212: Columns configuration for tables - Add Colvis files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 15:14:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 13:14:28 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 --- Comment #2 from Jonathan Druart --- Created attachment 17979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17979&action=edit Bug 10212: Columns configuration for tables This development introduces ColVis into Koha and provides a configuration page for columns visibility. ColVis is a plugin for DataTables. It allows to change the visibility of the columns in the table. * This development adds: - the js and css file for ColVis - a new DB table 'columns_settings' - a new template plugin 'ColumnsSettings' - a new package C4::Utils::DataTables::ColumnsSettings - a new admin page admin/columns_settings.pl * How it works: A yaml file is created (admin/columns_settings.yml) in order to take an inventory of all tables where ColVis is implemented. This file is read to create the list of modules, pages and tables in the configuration page. There are 3 possible keys in the yml: - is_hidden: default is 0 The column will be hidden. - cannot_be_toggled: default is 0. ColVis will allow to hide/show the column. - cannot_be_modified: default is 0 Default values (in the yml) won't be modifiable. When a user changes (or saves) the configuration for one module, all columns are added to the DB table. The values in the DB get the upper hand on the yaml values. * Humm, strange? It seems weird to have 2 storages for the same values. But I think it will be easy to add an entry and maintain the yaml rather than adding a new row (and new entry in updatedatabase script) in the DB. * Test plan: 1/ Execute the updatedatabase in order to create the new table. 2/ Take a look to the yml structure. 3/ Go on the checkouts page (circ/circulation.pl). 4/ Check that you cannot hide the 3 last columns on the issues table. 5/ Check that you cannot hide the 2 last columns on the holds table. 6/ Try to hide/show columns. 7/ Go on the columns configuration page (admin/columns_settings.pl). 8/ Only the last tab are filled with data. Check/uncheck checkboxes and save. 9/ Go on the checkouts/holds page and check that the behavior is what you expected. 10/ Give me some feedback :) * To go further: We can imagine that the configuration is saved for each user (and not globally like it is made with this patch). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 15:15:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 13:15:54 +0000 Subject: [Koha-bugs] [Bug 10212] Columns configuration for tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch --- Comment #3 from Jonathan Druart --- This enhancement is not ready for QA (UT and doc are missing). I would like to have some feedback about it before completing it. I switch the status to "Needs SO" for the visibility but it could be "Needs Feedback" :) Note: - I don't know if "accordion" is the best choice for the configuration page. - Tables don't have a good width in some cases. This should be fixed with some css. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 15:23:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 13:23:07 +0000 Subject: [Koha-bugs] [Bug 10204] Patron image no longer appears in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10204 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17965|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen --- Created attachment 17980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17980&action=edit Bug 10204 - Patron image no longer appears in the OPAC With the addition of opac-memberentry.pl to the OPAC we lost a way to display the image associated with a patron's account. This patch adds display of the patron image to opac-memberentry.pl now that opac-userdetails.pl and opac-userupdate.pl are deprecated. To test: 1. Log into the OPAC as a patron who has an image associated with their account. View the "my personal details" tab and confirm that the patron image appears with and without OPACPatronDetails enabled. 2. Log into the OPAC as a patron who has no image associated with their account. View the "my personal details" tab and confirm that the layout looks correct. 3. Turn off OPACpatronimages and confirm that the "my personal details" page looks correct. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 15:23:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 13:23:25 +0000 Subject: [Koha-bugs] [Bug 10204] Patron image no longer appears in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10204 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:04:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:04:17 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 --- Comment #4 from Kyle M Hall --- Created attachment 17981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17981&action=edit Bug 10200 - Add more Independent Branches options - Part 1 - IndependentBranchesIntranetSearch Enabling IndependentBranchesIntranetSearch will automatically add a branch limit filter to the search results thus hiding all records without one or more items owned by the logged in library, including records with no items attached. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Perform a search that will give results for both records which have items owned by the logged in library, and records which have no items owned by the logged in library. 4) Enable the new system preference IndependentBranchesIntranetSearch 5) Perform the same search again, any records without items owned by the currently logged in library should not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:04:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:04:33 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 --- Comment #5 from Kyle M Hall --- Created attachment 17982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17982&action=edit Bug 10200 - Add more Independent Branches options - Part 3 - IndependentBranchesMarcEditing Adds a new system preference IndependentBranchesMarcEditing. If this new syspref is enabled, a librarian can only edit or delete a bib record if his or her logged in branch code matches the branchcode in biblio.branchcode. This feature does not affect the ability to edit or delete items, as that functionality is determined by IndependantBranches. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Map a nonrepeatable field/subfield to biblio.branchcode Pro-tip: Use the authorised value 'branches' to get a pulldown of libraries instead of entering the branchcode manually. 4) Edit a record, and add a branchcode. 5) Log in as a non-superlibrarian with cataloging priveleges 6) Change the logged in branch to a branch other than the one you entered in the record. 7) You should note the 'edit' pulldown for the record is missing the "Edit record" and "Delete record" options. 8) Switch the logged in branch to match the branchcode of the record. 9) You should now see the edit and delete options for that record. 10) Attempt to edit a record with no branchcode defined, you should be able to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:04:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:04:42 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 --- Comment #6 from Kyle M Hall --- Created attachment 17983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17983&action=edit Bug 10200 - Add more Independent Branches options - Part 4 - Add branches_optional for MARC field authorised values This patch adds the branches_optional field to the authorised values pulldown for MARC fields and subfields in the MARC frameworks editor. 'branches_optional' behaves exactly like 'branches' except it includes an "empty" choice so the branch does not have to be set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:05:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:05:01 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17981|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:11:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:11:34 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart at biblibre.co | |m | --- Comment #13 from Jonathan Druart --- I prefer someone else qa the last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:27:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:27:10 +0000 Subject: [Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:36:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:36:50 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17961|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 17984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17984&action=edit Bug 10200 - Add more Independent Branches options - Part 1 - IndependentBranchesIntranetSearch Enabling IndependentBranchesIntranetSearch will automatically add a branch limit filter to the search results thus hiding all records without one or more items owned by the logged in library, including records with no items attached. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Perform a search that will give results for both records which have items owned by the logged in library, and records which have no items owned by the logged in library. 4) Enable the new system preference IndependentBranchesIntranetSearch 5) Perform the same search again, any records without items owned by the currently logged in library should not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:38:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:38:43 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17963|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 17985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17985&action=edit Bug 10200 - Add more Independent Branches options - Part 2 - IndependentBranchesOpacSearch Enabling IndependentBranchesIntranetSearch will automatically add a branch limit filter to the search results thus hiding all records without one of more items owned by the library as defined by the webserver environment variable BRANCHCODE for the given OPAC, including records with no items attach. Test Plan: 1) Apply the patch 2) Run updatedatabase.pl 3) Add this line to the http-conf for your OPAC: SetEnv BRANCHCODE "MPL" Replace MPL with the branchcode you want to use for this test 4) Perform a search that will give results for both records which have items owned by the set library, and records which have no items owned by the set library. 5) Enable the new system preference IndependentBranchesOpacSearch 6) Perform the same search again, any records without items owned by the library set in the BRANCHCODE environment variable should not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:39:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:39:03 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17982|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 17986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17986&action=edit Bug 10200 - Add more Independent Branches options - Part 3 - IndependentBranchesMarcEditing Adds a new system preference IndependentBranchesMarcEditing. If this new syspref is enabled, a librarian can only edit or delete a bib record if his or her logged in branch code matches the branchcode in biblio.branchcode. This feature does not affect the ability to edit or delete items, as that functionality is determined by IndependantBranches. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Map a nonrepeatable field/subfield to biblio.branchcode Pro-tip: Use the authorised value 'branches' to get a pulldown of libraries instead of entering the branchcode manually. 4) Edit a record, and add a branchcode. 5) Log in as a non-superlibrarian with cataloging priveleges 6) Change the logged in branch to a branch other than the one you entered in the record. 7) You should note the 'edit' pulldown for the record is missing the "Edit record" and "Delete record" options. 8) Switch the logged in branch to match the branchcode of the record. 9) You should now see the edit and delete options for that record. 10) Attempt to edit a record with no branchcode defined, you should be able to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:39:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:39:15 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:39:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:39:16 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17983|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 17987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17987&action=edit Bug 10200 - Add more Independent Branches options - Part 4 - Add branches_optional for MARC field authorised values This patch adds the branches_optional field to the authorised values pulldown for MARC fields and subfields in the MARC frameworks editor. 'branches_optional' behaves exactly like 'branches' except it includes an "empty" choice so the branch does not have to be set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:40:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:40:29 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #22 from Sophie MEYNIEUX --- Created attachment 17988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17988&action=edit Bug 1993: Improving task scheduler Remove "url" as format as it is not implemented Add csv as output format Use MIME:Lite to send email Call runreport.pl with right parameters Signed-off-by: Kyle M Hall Bug 1993 followup : get_saved_report API has changed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:41:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:41:10 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:57:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:57:46 +0000 Subject: [Koha-bugs] [Bug 10213] New: UniqueItemFields should be implemented for creating items in cataloguing and serials Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10213 Bug ID: 10213 Summary: UniqueItemFields should be implemented for creating items in cataloguing and serials Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de CC: m.de.rooy at rijksmuseum.nl The system preference UniqueItemFields helps to guarantee that some fields in the item table are filled with unique values on ordering and receiving items. It would be consistent to have the same functionality also available when adding items in cataloguing and in serials. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 16:57:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 14:57:54 +0000 Subject: [Koha-bugs] [Bug 10213] UniqueItemFields should be implemented for creating items in cataloguing and serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10213 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 17:09:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 15:09:09 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16721|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 17:09:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 15:09:55 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 17:11:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 15:11:52 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #23 from Sophie MEYNIEUX --- I have squashed the previously signed off patch and my followup This latter modifies get_saved_report function call whose API has changed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 17:25:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 15:25:22 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #24 from Katrin Fischer --- Hi Sophie, please don't squash signed off patches together with new changes. This way we don't know what was texted by the sign offer and the sign offer also might not be happy with it :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 17:26:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 15:26:14 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #25 from Katrin Fischer --- That said - can you maybe provide the original patches? The signed off patch could be unobsoleted, but not sure about how to divide out the newer changes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 17:49:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 15:49:54 +0000 Subject: [Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPACViewOthersSuggestions |OPACViewOthersSuggestions |is not working nicely |does not work -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:08:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:08:52 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16197|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 17989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17989&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable MaxFineIsReplacementPrice 4) Pick an item, set it's replacementprice to some amount ( e.g. $6.50 ) 5) Check it out to a patron, back date the due date by an amount such that the fine should exceed the replacement price ( a year ago should be good ). 6) Run fines.pl 7) Verify the fine for the item is not exceeded the replacement price. Signed-off-by: Chris Cormack Make sure that you also have maximum fine amount to be higher than the replacement price you set, otherwise it will stop at that amount. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:09:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:09:21 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:09:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:09:22 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17989|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 17990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17990&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:09:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:09:38 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17990|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 17991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17991&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable MaxFineIsReplacementPrice 4) Pick an item, set it's replacementprice to some amount ( e.g. $6.50 ) 5) Check it out to a patron, back date the due date by an amount such that the fine should exceed the replacement price ( a year ago should be good ). 6) Run fines.pl 7) Verify the fine for the item is not exceeded the replacement price. Signed-off-by: Chris Cormack Make sure that you also have maximum fine amount to be higher than the replacement price you set, otherwise it will stop at that amount. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:09:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:09:44 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #14 from Kyle M Hall --- Created attachment 17992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17992&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:10:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:10:48 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #15 from Kyle M Hall --- (In reply to comment #10) > The logic on this syspref is backwards. When set to "Don't allow," the fine > assessed will be equal to the maximum fine allowed by the circ rules, and > when set to "Allow" the fine assessed will be equal to the replacement price > of the item. I've attached a trivial followup to fix this issue. I've set "Passed QA" under the assumption that this is the only issue you found. If I am mistaken, please reset the status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:15:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:15:17 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 --- Comment #3 from Owen Leonard --- Created attachment 17993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17993&action=edit Bug 10201 [Follow-up] Old OPAC patron update system should be removed The previous patch missed removal of one template, kohaerror.tt, which was used only by opac-userupdate.pl. This patch removes it. To test, apply the patch and search Koha source files for references to kohaerror. There should be none. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:16:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:16:15 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17977|Bug 10201 - Old OPAC patron |[SIGNED OFF] Bug 10201 - description|update system should be |Old OPAC patron update |removed |system should be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:22:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:22:01 +0000 Subject: [Koha-bugs] [Bug 10214] New: malformed syspref.po file Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10214 Bug ID: 10214 Summary: malformed syspref.po file Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: paul.poulain at biblibre.com CC: frederic at tamil.fr The ln-LN-pref.po file (in misc/translator/po/, generated by ./translate install|update ln-LN is malformed. It lacks the .po header that is in other i18n files: # SOME DESCRIPTIVE TITLE. # Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER # This file is distributed under the same license as the PACKAGE package. # FIRST AUTHOR , YEAR. # #, fuzzy msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "POT-Creation-Date: 2013-05-07 08:52+0200\n" "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" "Last-Translator: FULL NAME \n" "Language-Team: LANGUAGE \n" "Language: \n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" Without this header, a tool like transifex complains (and refuses to upload the file). Adding it fixes the problem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:25:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:25:54 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:25:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:25:55 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #54 from Kyle M Hall --- Created attachment 17994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17994&action=edit Bug 9456 - Add callnumber column to the cart - Followup - Move sort filters to datatables.js Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:29:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:29:47 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16630|0 |1 is obsolete| | Attachment #16734|0 |1 is obsolete| | Attachment #17994|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall --- Created attachment 17995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17995&action=edit Bug 9456 - Add callnumber column to the cart This patch adds call-number sorting to the staff client cart. Sortining is enabled on the 'Items' column which uses a custom sorting routine to sort the callnumbers. If the sort is ascending, each column will be sorted by the highest ordered callnumber for that row. Likewise, if the sort is descending the table will be sorted by the lowest valued callnumber for that row. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:29:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:29:56 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #56 from Kyle M Hall --- Created attachment 17996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17996&action=edit Bug 9456 - Add callnumber column to the cart - add tooltip Signed-off-by: Cedric Vita -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:30:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:30:03 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 --- Comment #57 from Kyle M Hall --- Created attachment 17997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17997&action=edit Bug 9456 - Add callnumber column to the cart - Followup - Move sort filters to datatables.js Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:48:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:48:58 +0000 Subject: [Koha-bugs] [Bug 10215] New: Increase the size of opacnote and librariannote for table subscriptionhistory Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Bug ID: 10215 Summary: Increase the size of opacnote and librariannote for table subscriptionhistory Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com CC: colin.campbell at ptfs-europe.com We have librarians that are regularly hitting the maximum number of characters for the note fields in subscription history. They would like to be able to store at least 1000 characters here. Converting the varchar(150) to text should do it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:49:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:49:47 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:49:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:49:48 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 --- Comment #1 from Kyle M Hall --- Created attachment 17998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17998&action=edit Bug 10215 - Increase the size of opacnote and librariannote for table subscriptionhistory -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 18:53:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 16:53:55 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17998|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 17999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17999&action=edit Bug 10215 - Increase the size of opacnote and librariannote for table subscriptionhistory We have librarians that are regularly hitting the maximum number of characters for the note fields in subscription history. They would like to be able to store at least 1000 characters here. Converting the varchar(150) to text should do it. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Add public and private notes to a subscription history entry where each note is greater than 150 characters. 4) Save and view the notes, the notes should not be truncated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 21:03:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 19:03:28 +0000 Subject: [Koha-bugs] [Bug 10214] malformed syspref.po file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10214 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #1 from Zeno Tajoli --- The header is useful also for a GUI tool like Poedit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 21:15:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 19:15:21 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17977|0 |1 is obsolete| | --- Comment #4 from Mirko Tietgen --- Created attachment 18000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18000&action=edit Bug 10201 [Follow-up] Old OPAC patron update system should be removed The previous patch missed removal of one template, kohaerror.tt, which was used only by opac-userupdate.pl. This patch removes it. To test, apply the patch and search Koha source files for references to kohaerror. There should be none. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 21:15:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 19:15:56 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17977|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 21:16:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 19:16:13 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17993|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 21:16:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 19:16:45 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 21:16:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 19:16:57 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 7 22:19:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 20:19:15 +0000 Subject: [Koha-bugs] [Bug 10216] New: Request for a more in-depth report Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10216 Bug ID: 10216 Summary: Request for a more in-depth report Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: PC OS: Windows Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: lisenbee at uiwtx.edu Hello, We need some assistance with a report. We would like to run the following Patron Fines SQL report: SELECT b.surname, b.firstname, b.email, bib.title, i.barcode, a.amountoutstanding, ni.issuedate, ni.date_due, IF ( ni.returndate IS NULL , " ", ni.returndate ) AS returndate FROM accountlines a LEFT JOIN borrowers b ON ( b.borrowernumber = a.borrowernumber ) LEFT JOIN items i ON ( a.itemnumber = i.itemnumber ) LEFT JOIN biblio bib ON ( i.biblionumber = bib.biblionumber ) LEFT JOIN ( SELECT * FROM issues UNION SELECT * FROM old_issues ) ni ON ( ni.itemnumber = i.itemnumber AND ni.borrowernumber = a.borrowernumber ) WHERE a.amountoutstanding > 0 GROUP BY a.description ORDER BY b.surname, b.firstname, ni.timestamp DESC But we need more information. We need there to be two additional fields: year of graduation (i.e., Class of 2016), and ID/Card number. Is this possible? Thank you in advance for your assistance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 00:47:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 22:47:41 +0000 Subject: [Koha-bugs] [Bug 10216] Request for a more in-depth report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10216 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |liz at catalyst.net.nz Resolution|--- |INVALID --- Comment #1 from Liz Rea --- Hi Diana, It would probably be better if you sent this to the Koha Mailing list as a question - you can find out how to subscribe here: http://koha-community.org/support/koha-mailing-lists/ Bugzilla is really a place for defects in Koha, not general support questions. :) I'll look forward to seeing your question on the Koha list! Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 01:45:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 07 May 2013 23:45:20 +0000 Subject: [Koha-bugs] [Bug 10211] Remove deprecated Z39.50.pm code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10211 --- Comment #2 from David Cook --- (In reply to comment #1) > Looks like you are right about it. Please do not forget some references in > the unit tests (also in your grep). Thanks for pointing that out, Marcel. I was going to comment on that but forgot. I figure that unit test in the grep could just be removed all together, although there are likely references to it somewhere in the installer directory (which I excluded just because it was flooding my screen with seemingly irrelevant matches). I'll have to make sure to be thorough. The more deprecated code gone, the better :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 02:26:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 00:26:13 +0000 Subject: [Koha-bugs] [Bug 7003] canned report to show patrons and permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7003 --- Comment #2 from Nicole C. Engard --- Okay, a partner of ours came up with this report - I'm not sure how to wrap it in Perl to make it a canned report - but maybe someone else can take this as a start. If you do please credit Christopher Brannon for his amazing report: SELECT surname AS 'Last Name',firstname AS 'First Name',cardnumber AS 'Card Number',userid AS 'UserID',branchcode AS 'Library',Super AS 'superlibrarian',A AS 'circulate',SubA AS 'circulate subs',B AS 'catalogue',C AS 'parameters',SubC AS 'parameters subs',D AS 'borrowers',E AS 'permissions',F AS 'reserveforothers',SubF AS 'reserveforothers subs',G AS 'borrow',I AS 'editcatalogue',SubI AS 'editcatalogue subs',J AS 'updatecharges',K AS 'acquisition',SubK AS 'acquisition subs',L AS 'management',M AS 'tools',SubM AS 'tools subs',N AS 'editauthorities',O AS 'serials',SubO AS 'serials subs',P AS 'reports',SubP AS 'reports subs',Q AS 'staffaccess' FROM (SELECT b.surname,b.firstname,b.cardnumber,b.userid,b.branchcode,b.categorycode, at Check:=b.flags AS 'CheckQ',if(@Check-131072>=0, at Q:="On", at Q:="Off") AS 'Q', if(@Check-131072>=0, at Check:=@Check-131072, at Check) AS 'CheckP',if(@Check-65536>=0, at P:="On", at P:="Off") AS 'P',(SELECT group_concat(up.code) FROM user_permissions up WHERE up.module_bit='16' AND borrowernumber=b.borrowernumber) As SubP, if(@Check-65536>=0, at Check:=@Check-65536, at Check) AS 'CheckO',if(@Check-32768>=0, at O:="On", at O:="Off") AS 'O',(SELECT group_concat(up.code) FROM user_permissions up WHERE up.module_bit='15' AND borrowernumber=b.borrowernumber) As SubO, if(@Check-32768>=0, at Check:=@Check-32768, at Check) AS 'CheckN',if(@Check-16384>=0, at N:="On", at N:="Off") AS 'N', if(@Check-16384>=0, at Check:=@Check-16384, at Check) AS 'CheckM',if(@Check-8192>=0, at M:="On", at M:="Off") AS 'M',(SELECT group_concat(up.code) FROM user_permissions up WHERE up.module_bit='13' AND borrowernumber=b.borrowernumber) As SubM, if(@Check-8192>=0, at Check:=@Check-8192, at Check) AS 'CheckL',if(@Check-4096>=0, at L:="On", at L:="Off") AS 'L', if(@Check-4096>=0, at Check:=@Check-4096, at Check) AS 'CheckK',if(@Check-2048>=0, at K:="On", at K:="Off") AS 'K',(SELECT group_concat(up.code) FROM user_permissions up WHERE up.module_bit='11' AND borrowernumber=b.borrowernumber) As SubK, if(@Check-2048>=0, at Check:=@Check-2048, at Check) AS 'CheckJ',if(@Check-1024>=0, at J:="On", at J:="Off") AS 'J', if(@Check-1024>=0, at Check:=@Check-1024, at Check) AS 'CheckI',if(@Check-512>=0, at I:="On", at I:="Off") AS 'I',(SELECT group_concat(up.code) FROM user_permissions up WHERE up.module_bit='9' AND borrowernumber=b.borrowernumber) As SubI, if(@Check-512>=0, at Check:=@Check-512, at Check) AS 'CheckH',if(@Check-256>=0, at H:="On", at H:="Off") AS 'H', if(@Check-256>=0, at Check:=@Check-256, at Check) AS 'CheckG',if(@Check-128>=0, at G:="On", at G:="Off") AS 'G', if(@Check-128>=0, at Check:=@Check-128, at Check) AS 'CheckF',if(@Check-64>=0, at F:="On", at F:="Off") AS 'F',(SELECT group_concat(up.code) FROM user_permissions up WHERE up.module_bit='6' AND borrowernumber=b.borrowernumber) As SubF, if(@Check-64>=0, at Check:=@Check-64, at Check) AS 'CheckE',if(@Check-32>=0, at E:="On", at E:="Off") AS 'E', if(@Check-32>=0, at Check:=@Check-32, at Check) AS 'CheckD',if(@Check-16>=0, at D:="On", at D:="Off") AS 'D', if(@Check-16>=0, at Check:=@Check-16, at Check) AS 'CheckC',if(@Check-8>=0, at C:="On", at C:="Off") AS 'C',(SELECT group_concat(up.code) FROM user_permissions up WHERE up.module_bit='3' AND borrowernumber=b.borrowernumber) As SubC, if(@Check-8>=0, at Check:=@Check-8, at Check) AS 'CheckB',if(@Check-4>=0, at B:="On", at B:="Off") AS 'B', if(@Check-4>=0, at Check:=@Check-4, at Check) AS 'CheckA',if(@Check-2>=0, at A:="On", at A:="Off") AS 'A',(SELECT group_concat(up.code) FROM user_permissions up WHERE up.module_bit='1' AND borrowernumber=b.borrowernumber) As SubA, if(@Check-2>=0, at Check:=@Check-2, at Check) AS 'CheckSuper',if(b.flags=1,"On","Off") AS "Super" FROM borrowers b LEFT JOIN categories USING (categorycode) WHERE b.branchcode=<> AND b.categorycode=<>) AS MainFlags ORDER BY surname, firstname ASC -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 02:31:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 00:31:47 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 --- Comment #2 from David Cook --- Created attachment 18001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18001&action=edit Bug 10096 - Add a Z39.50 interface for authority searching This patch introduces a new Z39.50 interface for searching z39.50 compliant databases for MARC authority records. These databases aren't as common as their bibliographic equivalents, but they're out there and very useful. I have included info at the bottom of this messsage for sample authority databases you can try. To test this patch: 1) Set up Z39.50 client targets for authority databases. (I've included information at the bottom of this message for LibrariesAustralia's test server for authorities as well as instructions on how to use your Koha's z39.50 authority server as well. The Library of Congress also has authority databases available (unsure if these are test or prod), and you might have access to others through OCLC or RLIN. OCLC provides login credentials for their test databases. 2) Go to the Authorities module 3) Click on the new "Z39.50 search button" 4) Select your authoriy search targets from the list (N.B. bibliographic targets will also display. These are of no use to you.) 5) Do a search for an authority you would like using either the "Raw" input box or the more specific input boxes for names, subjects, subject sub divisions, or titles. (I like searching Name (personal): Eric on the LibrariesAustralia test DB.) 6) You should see a table listing the server, heading, authority type, and two other columns (MARC and a nameless column). "Authority type" is the type of authority it will become when imported in to Koha. In the Eric example, "PERSO_NAME". 7) Click on "MARC" next to the results of interest to review the MARC authority record. 8) When you're satisfied with a record, click on "Import". 9) The pop-up window will close and your original Koha window will change to the "Adding authority Personal Name" screen (in the Eric example). 10) All the relevant fields should be filled out for the record. Review them and make any changes as necessary. (N.B. The 001 will be cleared when saved, so if you have a use for the imported control number, move it to the 010, 016, or 035 as appropriate. If you have a default value for the 003, this will also likely be overwritten. Move it if necessary. The 005 will also be updated when saved, so do not worry about that.) 11) When you're satisfied, click save. 12) Presto! You've imported your first authority record via Z39.50! -- Here is the info for the LibrariesAustralia test Z39.50 authority database: Z39.50 server: LibrariesAustralia Authorities Hostname: z3950-test.librariesaustralia.nla.gov.au Port: 210 Database: AuthTraining Userid: ANLEZ Password: z39.50 Syntax: MARC21/USMARC Encoding: utf8 For testing purposes, you can also set up a Z39.50 client target, which points at your own Koha instance's Z39.50 authority server. To find the hostname, go to /etc/koha-conf.xml and find the value for the element. Depending on your configuration, this could be something like the following: unix:/zebra/koha/var/run/zebradb/authoritysocket (N.B. You might be using a different scheme than unix sockets...) To find the database, scroll down to the bottom of koha-conf.xml until you reach the element. Within this, look for the value of the element . It should probably be "authorities". To set up this Z39.50 client target in Koha... Z39.50 server: my koha authorities Hostname: unix:/zebra/koha/var/run/zebradb/authoritysocket Port: Database: authorities Userid: Password: Syntax: MARC21/USMARC (or whichever flavour you need) Encoding: utf8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 02:38:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 00:38:06 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from David Cook --- While I have no doubt about the functionality of this feature (I think it works quite well), I'm sure that the code could benefit from closer scrutiny by eyes other than mine. My code is almost entirely based off of the Z39.50 bibliographic searching, so there might be some vestigial code that I missed which can be removed or perhaps just an optimization of the code that I have included. Ideally, in the future, it would be nice if the Bib-1 attributes used for searching could be configurable rather than hard-coded as they are at present. They attributes represent what works for LibrariesAustralia and are a best guess. There are more specific Bib-1 attributes out there for subjects (e.g. geographic terms, topical terms, etc.), but these weren't supported by LibrariesAustralia and they might not be supported by other major organizations like OCLC, so I did not include them. I'm open to changing that though. Jared also suggested using the QueryParser to allow the creation of configurable attributes/indexes, and this is something I would really be interested in doing in the future, since it would allow for different Z39.50 targets to use different Bib-1 attributes (which are often published by the target providers). As the QueryParser becomes more integrated into Koha, I would like it to become more a part of the external Z39.50 searches as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 04:49:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 02:49:07 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 --- Comment #4 from David Cook --- I think it might supposed to be ModAuthorityInBatch not ModAuthInBatch in the ImportBreedingAuth sub... It never gets called, but worth fixing that mistake...I think this same typo might exist elsewhere in Koha as well... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 07:18:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 05:18:27 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 --- Comment #5 from David Cook --- Looks like there's lots of trailing whitespace and a typo in ImportBreedingAuth where controlnumber should be control_number... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 07:34:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 05:34:58 +0000 Subject: [Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 07:35:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 05:35:00 +0000 Subject: [Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17480|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 07:35:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 05:35:03 +0000 Subject: [Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16441|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 07:35:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 05:35:05 +0000 Subject: [Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 07:35:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 05:35:07 +0000 Subject: [Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17937|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 07:35:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 05:35:25 +0000 Subject: [Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 --- Comment #15 from Katrin Fischer --- Created attachment 18002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18002&action=edit [PASSED QA] Bug 8278 - Replace YUI autocomplete in UNIMARC 210c plugin This plugin, for pseudo-authority-control of publisher information, used YUI autocomplete to pull existing publisher data from the biblioitems table. Despite its name it is not UNIMARC-specific. It assumes publisher name data is saved in biblioitems. This patch converts the autocomplete to jQueryUI. The search script has been amended to return valid JSON. The template has been modified to enable the jQueryUI autocomplete and to add structure more consistent with other popups. To test, link the publisher name field in your MARC structure to the unimarc_field_210c_bis.pl plugin. Open a MARC record for editing and click the "tag editor" link to launch the plugin. Type the first few letters of a publisher which exists in your database. You should get an autocomplete menu of publishers which match your search. Select one and click the "choose" button to fill the field in the MARC editor. Signed-off-by: Bernardo Gonzalez Kriegel Comment: work as described. No errors. Test: link 260b to plugin. Edit record and search first letters of present editors. Men? appears and can select and fill value. Why plugin 210c_bis talk about field 225a? Signed-off-by: Katrin Fischer Plugin now works correctly for me, even when linked to 260$b in a MARC21 installation. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 07:35:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 05:35:35 +0000 Subject: [Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 --- Comment #16 from Katrin Fischer --- Created attachment 18003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18003&action=edit [PASSED QA] Bug 8278 : Follow up, fixing the permissions on cataloguing/ysearch.pl Signed-off-by: Bernardo Gonzalez Kriegel Comment: Works. No errors. Without patch and normal staff user, logged out With patch, normal staff, valid output. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 07:35:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 05:35:42 +0000 Subject: [Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 --- Comment #17 from Katrin Fischer --- Created attachment 18004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18004&action=edit [PASSED QA] Bug 8278 [Follow-up] Replace YUI autocomplete in UNIMARC 210c plugin This follow-up corrects the heading of the plugin pop-up window to match the UNIMARC field it targets. To test, trigger the plugin and confirm that the pop-up window refers to 210c. Signed-off-by: Bernardo Gonzalez Kriegel Smple patch, fixes label. No errors. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 07:35:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 05:35:49 +0000 Subject: [Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 --- Comment #18 from Katrin Fischer --- Created attachment 18005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18005&action=edit [PASSED QA] Bug 8278: build the structure with to_json instead of manually. Test plan: Same as previously. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 07:52:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 05:52:55 +0000 Subject: [Koha-bugs] [Bug 10204] Patron image no longer appears in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10204 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 07:52:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 05:52:57 +0000 Subject: [Koha-bugs] [Bug 10204] Patron image no longer appears in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10204 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17980|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 18006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18006&action=edit [PASSED QA] Bug 10204 - Patron image no longer appears in the OPAC With the addition of opac-memberentry.pl to the OPAC we lost a way to display the image associated with a patron's account. This patch adds display of the patron image to opac-memberentry.pl now that opac-userdetails.pl and opac-userupdate.pl are deprecated. To test: 1. Log into the OPAC as a patron who has an image associated with their account. View the "my personal details" tab and confirm that the patron image appears with and without OPACPatronDetails enabled. 2. Log into the OPAC as a patron who has no image associated with their account. View the "my personal details" tab and confirm that the layout looks correct. 3. Turn off OPACpatronimages and confirm that the "my personal details" page looks correct. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer Tested with OpacPatronDetails and OpacPatronImags turned on/off and it's working well. Template only changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 07:54:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 05:54:37 +0000 Subject: [Koha-bugs] [Bug 10204] Patron image no longer appears in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10204 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- I ran the translate update process after applying this patch and 3 strings go fuzzy, but those don't contain translatable text. Example: "%s [%% UNLESS hidden.defined('title') && hidden.defined('surname') && hidden.defined('firstname') && hidden.defined('dateofbirth') && hidden.defined('initials') && hidden.defined('othernames') && hidden.defined('sex') %%] " So I guess this should be safe for 3.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 08:10:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 06:10:06 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 --- Comment #5 from Katrin Fischer --- Created attachment 18007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18007&action=edit [PASSED QA] Bug 10201 [Follow-up] Old OPAC patron update system should be removed The previous patch missed removal of one template, kohaerror.tt, which was used only by opac-userupdate.pl. This patch removes it. To test, apply the patch and search Koha source files for references to kohaerror. There should be none. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer All tests and QA script pass. Updating the German po files with this patch applied no new strings appeared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 08:11:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 06:11:14 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 08:11:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 06:11:17 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17977|0 |1 is obsolete| | Attachment #18000|0 |1 is obsolete| | Attachment #18007|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 18008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18008&action=edit [PASSED QA] Bug 10201 - Old OPAC patron update system should be removed The old pages for viewing and updating patron details in the OPAC have been superceded by the new script opac-memberentry.pl. This patch removes he old scripts and templates and corrects links to them. This patch also removes reference to opac-userupdate.tt from opac-patron-image.pl and replaces the authentication process with one which uses check_cookie_auth, based on the example of opac-tags.pl. To test, edit a patron record and set the "Gone no address" flag. Log in to the OPAC with that account and view the patron details page. The warning about out of date contact information should link to the new update page. Next, attempt to place a hold. You should see the same warning, and it should also link to the new update page. Test the display of patron images: Log in as a user who has an image associated with their account and navigate to /cgi-bin/koha/opac-patron-image.pl. Their patron image should display. A search of Koha source files should return no results for the missing scripts or templates. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer Comments on second patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 08:11:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 06:11:26 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 --- Comment #7 from Katrin Fischer --- Created attachment 18009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18009&action=edit [PASSED QA] Bug 10201 [Follow-up] Old OPAC patron update system should be removed The previous patch missed removal of one template, kohaerror.tt, which was used only by opac-userupdate.pl. This patch removes it. To test, apply the patch and search Koha source files for references to kohaerror. There should be none. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer All tests and QA script pass. Updating the German po files with this patch applied no new strings appeared. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 08:25:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 06:25:25 +0000 Subject: [Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 08:25:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 06:25:27 +0000 Subject: [Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17976|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 18010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18010&action=edit [PASSED QA] Bug 9961: Add truncation support to QP driver The original implementation of QueryParser did not handle truncation based on the QueryAutoTruncate system preference. This patch adds support. To test: 1) Apply patch. 2) Turn on UseQueryParser. 3) Set QueryAutoTruncate to "automatically." 4) Search for "har". Note that it returns results with words like "Harry" (i.e. with right truncation). 5) Search for "har*". Note that it still returns results with right truncation. 6) Set QueryAutoTruncate to "only when * is added." 7) Search for "har". Note that it returns only records that have the exact word "har" in them (most likely there will be none unless you have Hebrew items). 8) Search for "har*". Note that once again it returns results for "Harry" (i.e. right truncated results). 9) Sign off. This patch also reindents a hash in Koha/QueryParser/Driver/PQF.pm because it was hard to read before. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer All tests and QA script pass. Thx for fixing this Jared! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 08:34:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 06:34:57 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 08:35:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 06:35:47 +0000 Subject: [Koha-bugs] [Bug 9891] Current suspend holds have disappeared In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9891 --- Comment #5 from Katrin Fischer --- Bug 10185 has a fix for this problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 09:21:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 07:21:20 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18001|0 |1 is obsolete| | --- Comment #6 from David Cook --- Created attachment 18011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18011&action=edit Bug 10096 - Add a Z39.50 interface for authority searching (2) This updated patch fixes the whitespace errors, SQL typo, incorrect sub reference, and changes the Bib-1 attributes a bit (adds 1002, renames the other name attributes, and changes 1006 to 3), so that the Z39.50 searches have a higher success/correspondence rate. I've also included some information about how to set up the Library of Congress Z39.50 client targets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 09:39:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 07:39:27 +0000 Subject: [Koha-bugs] [Bug 8264] local cover images not working in IE8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8264 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 09:45:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 07:45:30 +0000 Subject: [Koha-bugs] [Bug 10153] Patron header search form is too wide In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10153 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 09:48:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 07:48:37 +0000 Subject: [Koha-bugs] [Bug 10152] Default sorting wrong in parcels.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10152 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 09:51:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 07:51:55 +0000 Subject: [Koha-bugs] [Bug 10145] The acquisition details block is badly placed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Doesn't apply to 3.10.x please rebase if it is needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 09:53:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 07:53:10 +0000 Subject: [Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 --- Comment #8 from Chris Cormack --- Doesn't apply to 3.10.x please resubmit if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 09:54:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 07:54:55 +0000 Subject: [Koha-bugs] [Bug 10022] Multiple tags moderation doesn't work on translated page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10022 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 10:09:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 08:09:52 +0000 Subject: [Koha-bugs] [Bug 10156] Fix usr/bin/perl path for get_report_social_data.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10156 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au --- Comment #1 from David Cook --- Created attachment 18012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18012&action=edit Bug 10156 - Fix usr/bin/perl path for get_report_social_data.pl Currently, the perl path for get_report_social_data.pl is "#!/bin/perl" when it should be "#!/usr/bin/perl". While I'm not entirely sure how to test this, rangi did mention: 23:47 (it wouldnt work on my debian install) 23:48 zsh: no such file or directory: /bin/perl It's a pretty trivial change, so I'm not sure it needs much of a test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 10:17:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 08:17:43 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 --- Comment #2 from David Cook --- Created attachment 18013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18013&action=edit Bug 10186: Fix a typo in subscription-add.tt : 2/years should be 2/year In subscription-add.tt dropdown list for periodiciy, the description for 9 value should be "2/year" (2 issues each year) At present, if the option value is selected, it is "2/years". This patch supresses the "s" after "year". To test : - in a subscription, change periodicity to "2/year" - save the subscription - reopen it and check the value is labelled "2/year" Signed-off-by: David Cook Trivial change. Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 10:18:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 08:18:09 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17945|0 |1 is obsolete| | Attachment #18013|0 |1 is obsolete| | --- Comment #3 from David Cook --- Created attachment 18014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18014&action=edit Bug 10186: Fix a typo in subscription-add.tt : 2/years should be 2/year In subscription-add.tt dropdown list for periodiciy, the description for 9 value should be "2/year" (2 issues each year) At present, if the option value is selected, it is "2/years". This patch supresses the "s" after "year". To test : - in a subscription, change periodicity to "2/year" - save the subscription - reopen it and check the value is labelled "2/year" Signed-off-by: David Cook Trivial change. Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 10:18:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 08:18:36 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 10:53:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 08:53:12 +0000 Subject: [Koha-bugs] [Bug 10156] Fix usr/bin/perl path for get_report_social_data.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10156 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18012|0 |1 is obsolete| | --- Comment #2 from Magnus Enger --- Created attachment 18015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18015&action=edit Bug 10156 - Fix usr/bin/perl path for get_report_social_data.pl Currently, the perl path for get_report_social_data.pl is "#!/bin/perl" when it should be "#!/usr/bin/perl". While I'm not entirely sure how to test this, rangi did mention: 23:47 (it wouldnt work on my debian install) 23:48 zsh: no such file or directory: /bin/perl It's a pretty trivial change, so I'm not sure it needs much of a test plan. Signed-off-by: Magnus Enger Before the patch "grep -r '#!/bin/perl' in the misc dir shows one file with this line, and it is indeed get_report_social_data.pl. After the patch there are no occurrences left. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 10:54:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 08:54:08 +0000 Subject: [Koha-bugs] [Bug 10156] Fix usr/bin/perl path for get_report_social_data.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10156 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |magnus at enger.priv.no -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 11:14:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 09:14:39 +0000 Subject: [Koha-bugs] [Bug 10134] set XSLT usage ON as default, for new Koha installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10134 --- Comment #2 from Magnus Enger --- Created attachment 18016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18016&action=edit Bug 10134 - set XSLT usage ON as default, for new Koha installs Currently, new installs are created with XSLT display set to "off", but XSLT seems to be the preferred way to display records, so having the default be "on" instead seems to make sense. This patch will of course only affect new installs. To test: - Apply the patch - Run through the webinstaller on an empty database - Log in to the staff client and search for "xslt" in system preferences - Verify that XSLTDetailsDisplay, XSLTResultsDisplay, OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are all set to "default" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 11:15:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 09:15:21 +0000 Subject: [Koha-bugs] [Bug 10134] set XSLT usage ON as default, for new Koha installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10134 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 11:56:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 09:56:50 +0000 Subject: [Koha-bugs] [Bug 10217] New: Make sure direct links to detail views work when there is no session Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10217 Bug ID: 10217 Summary: Make sure direct links to detail views work when there is no session Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: critical Priority: P5 - low Component: OPAC Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no On current master, if you do not have a session and try to visit a detail view page you will get an error: Can't use an undefined value as a HASH reference at /home/magnus/scripts/kohadev/opac/opac-detail.pl line 445. The offending line looks like this: my $branch = C4::Context->userenv->{branch}; This will typically happen if you follow a direct link to a detail view in an OPAC you have not visited before, or not visited in such a long time that the session expired. If you get the error, visit the front page and go back to the detail view that gave the error it will work, because visiting the front page establishes a new session: you dont have a userenv if you arent logged in that makes sense :-) but... do you get one by visiting the front page, then? yep starts an anonymous session and that only happens on the front page? or search results doesnt happen on detail page and it shouldnt cos else google would spawn a zillion sessions Huge thanks to Chris C. who suggested the fix for this, but did not want to submit a patch for it. :-) The problem was caused by Bug 7740. There was a similar problem in opac-serach.pl, fixed on Bug 9980. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 12:00:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 10:00:50 +0000 Subject: [Koha-bugs] [Bug 9980] Anonymous searches in the OPAC entirely broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8198 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 12:00:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 10:00:50 +0000 Subject: [Koha-bugs] [Bug 8198] Need to track the call to "C4::Context->userenv->{'xxxx'} without check if it is undefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8198 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9980 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 12:01:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 10:01:25 +0000 Subject: [Koha-bugs] [Bug 10217] Make sure direct links to detail views work when there is no session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10217 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9980 Blocks| |8198 Depends on| |7740 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 12:01:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 10:01:25 +0000 Subject: [Koha-bugs] [Bug 7740] Highlight items in own library in search results/detail page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7740 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10217 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 12:01:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 10:01:25 +0000 Subject: [Koha-bugs] [Bug 8198] Need to track the call to "C4::Context->userenv->{'xxxx'} without check if it is undefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8198 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10217 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 12:01:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 10:01:25 +0000 Subject: [Koha-bugs] [Bug 9980] Anonymous searches in the OPAC entirely broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9980 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10217 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 12:07:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 10:07:53 +0000 Subject: [Koha-bugs] [Bug 10217] Make sure direct links to detail views work when there is no session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10217 --- Comment #1 from Magnus Enger --- Created attachment 18017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18017&action=edit Bug 10217 - Make sure direct links to detail views work when there is no session To reproduce: - Make sure you do not have a session for the OPAC you will be testing with. Delete the CGISESSID session cookie if you have one. - Go directly to a detail view, e.g.: /cgi-bin/koha/opac-detail.pl?biblionumber=1 - Observe the error "Can't use an undefined value as a HASH reference at /home/magnus/scripts/kohadev/opac/opac-detail.pl line 445." To test: - Apply the patch - Reload the page with the error - You should now see the detail view of the record, as usual Thanks to Chris Cormack who suggested the fix for this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 12:08:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 10:08:22 +0000 Subject: [Koha-bugs] [Bug 10217] Make sure direct links to detail views work when there is no session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10217 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 13:46:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 11:46:09 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18014|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 18018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18018&action=edit Bug 10186: Fix a typo in subscription-add.tt : 2/years should be 2/year In subscription-add.tt dropdown list for periodiciy, the description for 9 value should be "2/year" (2 issues each year) At present, if the option value is selected, it is "2/years". This patch supresses the "s" after "year". To test : - in a subscription, change periodicity to "2/year" - save the subscription - reopen it and check the value is labelled "2/year" Signed-off-by: David Cook Trivial change. Works as described. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 13:46:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 11:46:08 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 13:46:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 11:46:26 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 13:47:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 11:47:00 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 --- Comment #5 from M. de Rooy --- Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 13:47:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 11:47:15 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 13:49:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 11:49:28 +0000 Subject: [Koha-bugs] [Bug 10156] Fix usr/bin/perl path for get_report_social_data.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10156 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 13:49:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 11:49:29 +0000 Subject: [Koha-bugs] [Bug 10156] Fix usr/bin/perl path for get_report_social_data.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10156 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18015|0 |1 is obsolete| | --- Comment #3 from M. de Rooy --- Created attachment 18019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18019&action=edit Bug 10156 - Fix usr/bin/perl path for get_report_social_data.pl Currently, the perl path for get_report_social_data.pl is "#!/bin/perl" when it should be "#!/usr/bin/perl". While I'm not entirely sure how to test this, rangi did mention: 23:47 (it wouldnt work on my debian install) 23:48 zsh: no such file or directory: /bin/perl It's a pretty trivial change, so I'm not sure it needs much of a test plan. Signed-off-by: Magnus Enger Before the patch "grep -r '#!/bin/perl' in the misc dir shows one file with this line, and it is indeed get_report_social_data.pl. After the patch there are no occurrences left. Passed-QA-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 13:52:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 11:52:21 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17900|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 13:58:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 11:58:57 +0000 Subject: [Koha-bugs] [Bug 8277] item form not always showing when ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8277 --- Comment #11 from Nicole C. Engard --- We are still seeing this in 3.10.3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 14:35:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 12:35:35 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 14:36:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 12:36:14 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 14:36:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 12:36:15 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17917|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 18020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18020&action=edit Bug 10170: strings in MARC import made translatable Following bug 9215: non translatable strings are now present in the template and translatable Signed-off-by: Chris Cormack Not only does this make the strings translatable it makes the template a lot easier to read Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 14:36:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 12:36:33 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 14:38:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 12:38:59 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from M. de Rooy --- QA Comment: Clear changes to template! Table design still refers to value 'use_template' for overlay_action. This seems to be obsolete? Followup for table needed? record_lis.status: you do not include 'error' ,'staged','items_reverted'? See table design. If needed, please send a followup. record_lis.overlay_status: Same for 'auto_match','manual_match'? It seems that Stage-marc-import does not correctly save my actions. When I choose Ignore, manage-marc-import comes back with Add. If I change the values on manage-marc-import, it looks okay though. So this is outside scope of this report. Can you confirm this error? Although this may still need some attention, we are improving the template. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 14:41:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 12:41:28 +0000 Subject: [Koha-bugs] [Bug 10216] Request for a more in-depth report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10216 --- Comment #2 from Diana --- Hi Liz, Thank you for pointing me in the right direction! Sorry about that. :) Thank you again! Diana (In reply to comment #1) > Hi Diana, > > It would probably be better if you sent this to the Koha Mailing list as a > question - you can find out how to subscribe here: > http://koha-community.org/support/koha-mailing-lists/ > > Bugzilla is really a place for defects in Koha, not general support > questions. :) > > I'll look forward to seeing your question on the Koha list! > > Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:08:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:08:36 +0000 Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:08:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:08:37 +0000 Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16635|0 |1 is obsolete| | Attachment #16749|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall --- Created attachment 18021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18021&action=edit Bug 8037 - Add holds and funds to items already received in parcel.pl Adds a column to indicate holds on recieved items, as well as adding a new column for fund and showing the subtotals per fund above the total subtotal. Signed-off-by: Pierre Angot -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:08:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:08:41 +0000 Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037 --- Comment #30 from Kyle M Hall --- Created attachment 18022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18022&action=edit Bug 8037 - Add holds and funds to items already received in parcel.pl - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:08:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:08:44 +0000 Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037 --- Comment #31 from Kyle M Hall --- Created attachment 18023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18023&action=edit Bug 8037 - Add holds and funds to items already received in parcel.pl - QA Followup 2 Adds the note "GST exc." for subtotals by fund. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:09:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:09:37 +0000 Subject: [Koha-bugs] [Bug 8037] Add holds and funds to items already received in parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8037 --- Comment #32 from Kyle M Hall --- (In reply to comment #28) > OK, after some more explanations in french from Sonia, I think I've got the > point she wanted to explain: whatever is the GIST status of the prices > you've setup, the final cost for you will be the "all taxes included" price, > so it's the "all included" price that must be removed from the budget. > In other terms, it means that the budget split should not just sum all lines. > > How to fix this problem ? The best option, imo, would be to completely > relook this screen to have both GIST excluded&included prices & totals & > sub-total > But that's a long term goal. > So, at the end, I feel what would be enough is to just display a message if > the vendor is "prices exclude GIST" saying ("GIST not summed", or something > like that) > > In the meantime, failed QA. Paul, is this second followup what you are looking for? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:39:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:39:52 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:39:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:39:53 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14908|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 18024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18024&action=edit Bug 7882 - move or reorder 6xx and 7xx fields Adds jQueryUI sortable features to fields. Converts list items from div's to ul's Added Image files to be used for Drag and drop in frameworks added CSS changes for images To Test: Go into catalogging and choose to add a new item with your favorite framework. You should be able to move the fields and the subfields around After making your desired number of changes choose to save You should notice the marc record saved in the order that you arranged the fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:40:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:40:49 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18024|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 18025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18025&action=edit Bug 7882 - move or reorder 6xx and 7xx fields Adds jQueryUI sortable features to fields. Converts list items from div's to ul's Added Image files to be used for Drag and drop in frameworks added CSS changes for images To Test: Go into catalogging and choose to add a new item with your favorite framework. You should be able to move the fields and the subfields around After making your desired number of changes choose to save You should notice the marc record saved in the order that you arranged the fields Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:40:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:40:58 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #22 from Kyle M Hall --- Created attachment 18026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18026&action=edit Bug 7882 - move or reorder 6xx and 7xx fields - Followup - Remove placeholder highlighting This followup removes the yellow placeholder box when moving fields. To me, it looks and behaves far more sensibly without it. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:42:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:42:25 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18026|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 18027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18027&action=edit Bug 7882 - move or reorder 6xx and 7xx fields - Followup - Remove placeholder highlighting This followup removes the yellow placeholder box when moving fields. To me, it looks and behaves far more sensibly without it. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:44:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:44:46 +0000 Subject: [Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:49:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:49:31 +0000 Subject: [Koha-bugs] [Bug 10204] Patron image no longer appears in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10204 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:50:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:50:43 +0000 Subject: [Koha-bugs] [Bug 8278] Replace YUI autocomplete in UNIMARC 210c plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:52:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:52:41 +0000 Subject: [Koha-bugs] [Bug 10156] Fix usr/bin/perl path for get_report_social_data.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10156 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:55:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:55:18 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:55:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:55:40 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:56:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:56:42 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 15:57:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 13:57:55 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 16:01:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 14:01:13 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 16:04:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 14:04:10 +0000 Subject: [Koha-bugs] [Bug 9681] Add some indexes in database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9681 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 16:07:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 14:07:59 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 16:29:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 14:29:54 +0000 Subject: [Koha-bugs] [Bug 9998] Import/export and compare system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Backup, compare or restore |Import/export and compare |system preferences (from |system preferences |file) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 16:30:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 14:30:20 +0000 Subject: [Koha-bugs] [Bug 10218] New: label 'online access' with id for css Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Bug ID: 10218 Summary: label 'online access' with id for css Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com Created attachment 18028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18028&action=edit online access id See attached. It would be nice to be able to style the 'online access' text but the label doesn't have a unique ID. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 16:30:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 14:30:48 +0000 Subject: [Koha-bugs] [Bug 9998] Import/export and compare system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 --- Comment #1 from M. de Rooy --- # Two interesting features are: # 1) It may help you to compare systempreferences between Koha instances. # 2) You can also quickly restore subsets of preferences while testing. # Just leave only e.g. some circulations prefs in a file and compare with # the update flag. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 16:40:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 14:40:43 +0000 Subject: [Koha-bugs] [Bug 10219] New: No way for patron to unsubscribe from subscription alert in the OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10219 Bug ID: 10219 Summary: No way for patron to unsubscribe from subscription alert in the OPAC Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/opac-alert-subscribe.pl?externalid=2&ale rttype=issue&biblionumber=XXX OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org CC: colin.campbell at ptfs-europe.com If subscription alerts are enabled, a patron can sign up for subscription alerts from opac-serial-issues.pl. Although opac-alert-subscribe.pl contains code for unsubscribing, there is nothing in the interface which offers the patron an unsubscribe link. opac-serial-issues.pl should be aware of whether a logged-in user is already subscribed, and show an unsubscribe link instead of a subscribe link. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 16:46:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 14:46:33 +0000 Subject: [Koha-bugs] [Bug 9998] Import/export and compare system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 --- Comment #2 from M. de Rooy --- Created attachment 18029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18029&action=edit Bug 9998: Import/export and compare system preferences This patch adds a new maintenance script: cmp_sysprefs.pl Test plan: 1 Run with -cmd backup -file zz01. Check that file. Run with -cmd test -file zz01. Check zz01.sav. 2 Run with -cmd compare -file zz01. No differences expected. 3 Edit zz01: delete two prefs, change two prefs and add two new prefs. 4 Run with -cmd compare -file zz01. Are all six changes reported? 5 Add local use preference zz02 in the staff client (no explanation, options). 6 Run with -cmd backup -file zz02. 7 Delete local use pref zz02 from the staff client. 8 Run with -cmd restore -file zz02. Check if local pref zz02 came back. 9 Delete local use pref zz02 again from the staff client. 10 Run with -cmd compare -file zz02 -add. Check if local pref zz02 came back. 11 Change the value of zz02 in the staff client. 12 Run with -cmd compare -file zz02 -add. Check the value: not updated? 13 Run with -cmd compare -file zz02 -upd. Check the value: updated now? 14 Edit file zz02. Add a comment line and delete the line for pref zz02. 15 Run with -cmd compare -file zz02 -del. Is pref zz02 deleted? 16 Add local use preference zz02 in the staff client (WITH explanation). 17 Run with -cmd compare -file zz02 -del. pref zz02 should not be deleted. 18 Run with -cmd compare -file zz02 -del -ign-opt. zz02 should be deleted now. Do the next steps only on a restorable test db: 19 Create file zz03. Leave it empty. Compare with: -cmd compare -file zz03 -del -ign-opt. All prefs gone except Version? 20 Restore with: -cmd restore -file zz01.sav. Compare with -cmd compare -file zz01.sav. Nothing reported? Note: The explanation or options are not recovered. (See also BZ 10199.) This affects local use preferences only. If you need them, restore your test db. Remove the zz files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 16:46:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 14:46:32 +0000 Subject: [Koha-bugs] [Bug 9998] Import/export and compare system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 16:54:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 14:54:44 +0000 Subject: [Koha-bugs] [Bug 9998] Import/export and compare system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9998 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10199 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 16:54:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 14:54:44 +0000 Subject: [Koha-bugs] [Bug 10199] Move fields type, options and explanation from systempreferences table? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10199 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9998 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 17:12:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 15:12:38 +0000 Subject: [Koha-bugs] [Bug 5292] Google Preview Option for OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- --- Comment #14 from Owen Leonard --- (In reply to comment #13) > Excuse my ignorance, but in current master we already have Google preview > link when using google book covers. Why do we need another implementation of > it? The link we have now opens a new tab/window to the Google Books page. This patch tried to implement this feature for opening an embedded preview within the OPAC: https://developers.google.com/books/docs/preview-wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 18:00:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 16:00:42 +0000 Subject: [Koha-bugs] [Bug 10220] New: IDs on checkin columns Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10220 Bug ID: 10220 Summary: IDs on checkin columns Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com Created attachment 18030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18030&action=edit view source I have a request to style the shelving location text on the checkin screen, but it doesn't have an ID - all columns should have ID tags on this page so that they can be styled easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 18:30:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 16:30:23 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16644|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall --- Created attachment 18031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18031&action=edit Bug 9673 - Track when items are marked as lost or withdrawn Add date fields to track when an item was marked as lost or withdrawn. Display those fields on catalogue/moredetail.pl Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a record with items, browse to the 'items' tab ( moredetail.pl ) 4) Mark an item as lost, verify the field "Lost on:" displays below the "Lost status" field with todays date. 5) Mark the item as not lost, verify the field no longer displays 6) Repeat steps 4 and 5 with the Withdrawn field. Signed-off-by: Mathieu Saby Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 18:30:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 16:30:33 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16646|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall --- Created attachment 18032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18032&action=edit Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 18:31:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 16:31:13 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 18:31:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 16:31:15 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 --- Comment #22 from Kyle M Hall --- Created attachment 18033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18033&action=edit Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup 2 * Reduces the possible cass to GetItem from 2 to 1 * Uses dt_from_string to get the DateTime object, so the time zone is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 18:36:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 16:36:29 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18033|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall --- Created attachment 18034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18034&action=edit Bug 9673 - Track when items are marked as lost or withdrawn - QA Followup 2 * Reduces the possible cass to GetItem from 2 to 1 * Uses dt_from_string to get the DateTime object, so the time zone is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 18:42:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 16:42:23 +0000 Subject: [Koha-bugs] [Bug 6413] Notes in Fines doing wonky things In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 18:42:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 16:42:25 +0000 Subject: [Koha-bugs] [Bug 6413] Notes in Fines doing wonky things In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 --- Comment #67 from Kyle M Hall --- Created attachment 18035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18035&action=edit Bug 6413 - QA Followup - Remove extra table column header Trivial fix, switching back to passed qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 19:07:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 17:07:21 +0000 Subject: [Koha-bugs] [Bug 6685] circ rules by groups of items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6685 --- Comment #6 from Nicole C. Engard --- *** Bug 8327 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 19:07:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 17:07:21 +0000 Subject: [Koha-bugs] [Bug 8327] group item types together In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8327 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Nicole C. Engard --- *** This bug has been marked as a duplicate of bug 6685 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 19:15:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 17:15:49 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 19:15:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 17:15:51 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14888|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 18036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18036&action=edit Bug 5544 - All Notices from Branch Email Address Right now overdues come from the branch, but the others come from the admin email address - this is a problem in multi-branch systems because they have to come up with one email address that all branches have access to. C4::Letters::_send_message_by_email currently sets the from address in the following order: 1) Address specified in message 2) Koha admin email address The order will now be: 1) Address specified in message 2) Borrowers home library email address 3) Koha admin email address Test Plan: 1) Set your branch email addresses, and the KohaAdminEmailAddress Make sure each of them are unqiue 2) Choose a borrower, enable the enhanced messaging and enable the checkout and checkin email notices. Use your email address for the borrower's email so you can recieve the emails. 3) Check out an item, check the from address of the email, it should be the email addres set in KohaAdminEmailAddress 4) Apply the patch 5) Return the item, check the from address of the email, it should match the email address set for the borrowers home library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 19:50:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 17:50:26 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #24 from Bernardo Gonzalez Kriegel --- Kyle, I could move subfields but not fields (ej a <-> b, but not 610 <-> 611) Is that the expected behavior? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 21:18:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 19:18:58 +0000 Subject: [Koha-bugs] [Bug 10221] New: hold expiration doesn't show on patron's list of holds Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221 Bug ID: 10221 Summary: hold expiration doesn't show on patron's list of holds Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All URL: /cgi-bin/koha/circ/circulation.pl?borrowernumber=51 OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com When looking at the patron details in the staff client you don't see the holds expiration date, but you do see all the other dates (placed, suspension) We should see the same here: /cgi-bin/koha/circ/circulation.pl?borrowernumber=51 that we see here: /cgi-bin/koha/reserve/request.pl?biblionumber=3174 When it relates to hold dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 21:41:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 19:41:12 +0000 Subject: [Koha-bugs] [Bug 8661] break out additional authors in opac like in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15212|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 21:43:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 19:43:28 +0000 Subject: [Koha-bugs] [Bug 8661] break out additional authors in opac like in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org --- Comment #22 from Owen Leonard --- Sorry, I give up on this. I can't untangle the necessary changes now that the OPAC version has had so many revisions. I hope someone else can solve this one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 21:43:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 19:43:36 +0000 Subject: [Koha-bugs] [Bug 8661] break out additional authors in opac like in staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8661 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 22:11:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 20:11:57 +0000 Subject: [Koha-bugs] [Bug 10217] Make sure direct links to detail views work when there is no session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10217 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 22:11:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 20:11:59 +0000 Subject: [Koha-bugs] [Bug 10217] Make sure direct links to detail views work when there is no session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10217 --- Comment #2 from Owen Leonard --- Created attachment 18037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18037&action=edit [SIGNED-OFF] Bug 10217 - Make sure direct links to detail views work when there is no session To reproduce: - Make sure you do not have a session for the OPAC you will be testing with. Delete the CGISESSID session cookie if you have one. - Go directly to a detail view, e.g.: /cgi-bin/koha/opac-detail.pl?biblionumber=1 - Observe the error "Can't use an undefined value as a HASH reference at /home/magnus/scripts/kohadev/opac/opac-detail.pl line 445." To test: - Apply the patch - Reload the page with the error - You should now see the detail view of the record, as usual Thanks to Chris Cormack who suggested the fix for this! Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 8 22:17:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 08 May 2013 20:17:31 +0000 Subject: [Koha-bugs] [Bug 10220] IDs on checkin columns In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10220 Helen Linda changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |helen.linda at goddard.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 02:43:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 00:43:43 +0000 Subject: [Koha-bugs] [Bug 6413] Notes in Fines doing wonky things In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 --- Comment #68 from Jared Camins-Esakov --- This patch has string changes and will therefore be held for 3.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 06:30:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 04:30:44 +0000 Subject: [Koha-bugs] [Bug 9212] Parentheses in subject headings break search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9212 --- Comment #12 from Liz Rea --- The search is not broken on the staff side - and it seems that the same thing happens with Author authorities as well as subjects, I discovered today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 08:24:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 06:24:11 +0000 Subject: [Koha-bugs] [Bug 6709] marc21_field_006.xml and marc21_field_008.xml can't be translated. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6709 --- Comment #19 from Chris Cormack --- Doesn't apply in 3.10.x (not sure it is needed anyway) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 08:25:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 06:25:59 +0000 Subject: [Koha-bugs] [Bug 10111] Layout on basket summary page a bit inconsistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10111 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 08:53:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 06:53:33 +0000 Subject: [Koha-bugs] [Bug 9266] Untranslated strings in tags moderation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9266 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 08:55:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 06:55:45 +0000 Subject: [Koha-bugs] [Bug 9957] Missing cancel link on subfield editing page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9957 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 09:03:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 07:03:19 +0000 Subject: [Koha-bugs] [Bug 9719] Changing the rows per page on a custom report fails if it has user supplied parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Does not apply to 3.10.x please rebase if needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 09:08:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 07:08:18 +0000 Subject: [Koha-bugs] [Bug 10097] Hide framework selection when importing staged authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10097 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 09:09:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 07:09:48 +0000 Subject: [Koha-bugs] [Bug 10053] borrowers.branchcode cannot be null In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10053 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Does not apply to 3.10.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 09:12:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 07:12:22 +0000 Subject: [Koha-bugs] [Bug 7055] NORMARC: Links and defaults for 008 position 15-17 and 35-37 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7055 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 09:15:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 07:15:05 +0000 Subject: [Koha-bugs] [Bug 7054] NORMARC: wrong default for 000 position 17 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7054 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 09:20:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 07:20:53 +0000 Subject: [Koha-bugs] [Bug 8419] Suspended holds appear on the daily holds queue In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8419 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 09:25:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 07:25:22 +0000 Subject: [Koha-bugs] [Bug 10033] dangerous query in _koha_modify_item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10033 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 11:02:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 09:02:17 +0000 Subject: [Koha-bugs] [Bug 7228] can't order more than 1 when importing all from staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #18 from Chris Cormack --- Does not apply to 3.10.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 11:16:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 09:16:18 +0000 Subject: [Koha-bugs] [Bug 10149] koha-restart-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10149 --- Comment #10 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 11:17:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 09:17:15 +0000 Subject: [Koha-bugs] [Bug 10144] koha-start-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10144 --- Comment #8 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 11:18:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 09:18:28 +0000 Subject: [Koha-bugs] [Bug 10104] koha-disable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10104 --- Comment #13 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 11:21:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 09:21:02 +0000 Subject: [Koha-bugs] [Bug 10101] koha-enable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10101 --- Comment #13 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 11:22:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 09:22:19 +0000 Subject: [Koha-bugs] [Bug 10041] Provide a koha-translate script to aid package users on installing translations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10041 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #12 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 11:25:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 09:25:00 +0000 Subject: [Koha-bugs] [Bug 9250] Provide commands to allow handling of SIP servers in the packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9250 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 11:26:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 09:26:20 +0000 Subject: [Koha-bugs] [Bug 10044] Doubled up paging on order receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10044 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 11:27:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 09:27:39 +0000 Subject: [Koha-bugs] [Bug 10150] koha-email-disable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10150 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 12:55:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 10:55:07 +0000 Subject: [Koha-bugs] [Bug 6709] marc21_field_006.xml and marc21_field_008.xml can't be translated. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6709 --- Comment #20 from Bernardo Gonzalez Kriegel --- (In reply to comment #19) > Doesn't apply in 3.10.x (not sure it is needed anyway) In case you think it's needed first apply Bug 9358, then this patch applies cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 13:17:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 11:17:52 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 13:26:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 11:26:33 +0000 Subject: [Koha-bugs] [Bug 9541] Opac-user doesn't load correct CSS for multiple branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9541 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 13:26:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 11:26:34 +0000 Subject: [Koha-bugs] [Bug 9541] Opac-user doesn't load correct CSS for multiple branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9541 --- Comment #4 from Kyle M Hall --- Created attachment 18038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18038&action=edit Bug 9541 - Opac-user doesn't load correct CSS for multiple branches When clicking the login link for opac-user.pl in a multiple branch scenario the environment variable for OPAC_CSS_OVERRIDE is ignored from the koha-conf.xml file. It seems like is is working on every page in the opac except for the login page. Test Plan: 1) Set up a Koha server with 2 separate catalog configurations ( e.g. opac1.kohatest, opac2.kohatest ) 2) Set the OPAC_CSS_OVERRIDE directive for separate css files in each opac 3) Browse to the opac login page, note the css is not applied 4) Apply this patch 5) Reload the page, note the css is now applied -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 13:27:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 11:27:16 +0000 Subject: [Koha-bugs] [Bug 9541] Opac-user doesn't load correct CSS for multiple branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9541 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15553|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 14:23:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 12:23:51 +0000 Subject: [Koha-bugs] [Bug 10217] Make sure direct links to detail views work when there is no session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10217 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18017|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 14:33:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 12:33:35 +0000 Subject: [Koha-bugs] [Bug 10222] New: Error when saving Demco label templates Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10222 Bug ID: 10222 Summary: Error when saving Demco label templates Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label printing Assignee: cnighswonger at foundations.edu Reporter: oleonard at myacpl.org If you open either of the Demco label templates (loaded by the sample data) and click "save" without making any changes you will get an error: Can't bless non-reference value at C4/Creators/Profile.pm line 92. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 14:37:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 12:37:03 +0000 Subject: [Koha-bugs] [Bug 5383] Test of Process to Submit a Feature Request In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5383 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 14:41:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 12:41:06 +0000 Subject: [Koha-bugs] [Bug 9965] Improve integration of report plugins with existing reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9965 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 14:44:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 12:44:39 +0000 Subject: [Koha-bugs] [Bug 10134] set XSLT usage ON as default, for new Koha installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 14:49:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 12:49:27 +0000 Subject: [Koha-bugs] [Bug 9965] Improve integration of report plugins with existing reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9965 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17108|0 |1 is obsolete| | --- Comment #2 from Paola Rossi --- Created attachment 18039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18039&action=edit sign off of the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 14:52:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 12:52:53 +0000 Subject: [Koha-bugs] [Bug 9965] Improve integration of report plugins with existing reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9965 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 14:54:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 12:54:21 +0000 Subject: [Koha-bugs] [Bug 10134] set XSLT usage ON as default, for new Koha installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 14:54:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 12:54:22 +0000 Subject: [Koha-bugs] [Bug 10134] set XSLT usage ON as default, for new Koha installs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10134 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18016|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 18040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18040&action=edit [SIGNED-OFF] Bug 10134 - set XSLT usage ON as default, for new Koha installs Currently, new installs are created with XSLT display set to "off", but XSLT seems to be the preferred way to display records, so having the default be "on" instead seems to make sense. This patch will of course only affect new installs. To test: - Apply the patch - Run through the webinstaller on an empty database - Log in to the staff client and search for "xslt" in system preferences - Verify that XSLTDetailsDisplay, XSLTResultsDisplay, OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are all set to "default" Signed-off-by: Owen Leonard Passes test plan correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 15:38:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 13:38:35 +0000 Subject: [Koha-bugs] [Bug 9906] Holds Return Policy and Local Hold Item Types not working as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9906 Diana Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dianajweaver at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 15:51:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 13:51:01 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17907|0 |1 is obsolete| | --- Comment #50 from Owen Leonard --- Created attachment 18041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18041&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a patron, note the patron's category 5) Issue an item to this patron 4) Edit that category, set "Block expired patrons" to "Block" 5) Verify the patron cannot renew or place holds in the opac 6) Edit the category again, set "Block expired patrons" to "Don't block" 7) Verify the patron *can* renew and place holds in the opac 8) Edit the category again, set "Block expired patrons" to "Follow system preference BlockExpiredPatronOpacActions" 9) Set the system preference BlockExpiredPatronOpacActions to "Block" 10) Verify the patron cannot renew or place holds in the opac 11) Set the system preference BlockExpiredPatronOpacActions to "Don't block" 12) Verify the patron *can* renew and place holds in the opac Signed-off-by: Kyle M Hall Signed-off-by: Melia Meggs Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 15:52:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 13:52:00 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17908|0 |1 is obsolete| | --- Comment #51 from Owen Leonard --- Created attachment 18042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18042&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup Signed-off-by: Melia Meggs Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 15:53:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 13:53:15 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 15:53:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 13:53:18 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17909|0 |1 is obsolete| | --- Comment #52 from Owen Leonard --- Created attachment 18043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18043&action=edit [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions - Followup 2 * Hide renewal column, buttons and links * Fixes minor bug where upper-right table links would show even if renewal impossible * Cleans up some of the template formatting ( whitespace changes only ) Signed-off-by: Owen Leonard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 16:04:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 14:04:04 +0000 Subject: [Koha-bugs] [Bug 10223] New: No suggestions showing in 3.10 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10223 Bug ID: 10223 Summary: No suggestions showing in 3.10 Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com With the release of 3.10.5 a new bug appeared. If a patron has purchase suggestions they no longer show in the OPAC on their account. It always says no suggestions but the suggestions are submitted and visible in the staff client. This is both themes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 16:10:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 14:10:12 +0000 Subject: [Koha-bugs] [Bug 10160] Add z39.50 command line tester In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10160 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 16:25:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 14:25:32 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #15 from Owen Leonard --- This patch doesn't apply for me through git-bz, but did apply using "git am -i3u" after saving the patch. I just wanted to mention it if others are testing too. It works correctly to hide baskets with no items to be received, but I have one worry: Are librarians going to be confused about how to access those baskets? Should there be a "show all" link or something like that? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 16:29:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 14:29:47 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master --- Comment #16 from Owen Leonard --- (In reply to comment #11) > I'm anticipating some questions from our librarian colleagues. They might > ask us how to see all baskets from a vendor. I think it would be difficult > for them to use acquisition module. Whoops, I see someone else has asked this already! I'm not a regular acquisitions user, so it's hard for me to say, however, I would think a "show all" link would be useful? Anyone else? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 16:56:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 14:56:22 +0000 Subject: [Koha-bugs] [Bug 10223] No suggestions showing in 3.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10223 --- Comment #1 from Owen Leonard --- I've tested this in 3.10.x and master and I can't reproduce it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:13:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:13:56 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:13:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:13:57 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17588|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 18044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18044&action=edit Bug 10080 - Change system pref IndependantBranches to IndependentBranches Test Plan: 1) Enable IndependantBranches 2) Apply this patch 3) Run updatedatabase.pl 4) Verify that the system preference still functions correctly Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:16:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:16:39 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard --- I think the added line should be: "aaSorting": [[8, "desc"]] ...so that the sorted column reflects the sort state in the column header. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:17:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:17:17 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10200 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:17:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:17:17 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10080 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:21:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:21:18 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 --- Comment #8 from Kyle M Hall --- Updated patch, removed modification for the previous database update. Thanks for catching that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:25:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:25:45 +0000 Subject: [Koha-bugs] [Bug 9300] filtering export.pl by accession date does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9300 --- Comment #1 from Nicole C. Engard --- Created attachment 18045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18045&action=edit dates in the marc aren't in the date range either This is still an issue. I ran the export for Jan 1 2013 to today and I got results like this one: mysql> select datecreated from biblio where biblionumber=753; +-------------+ | datecreated | +-------------+ | 2012-09-21 | +-------------+ Which is obviously not right. The MARC is attached in the image -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:41:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:41:56 +0000 Subject: [Koha-bugs] [Bug 10223] No suggestions showing in 3.10 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10223 --- Comment #2 from Nicole C. Engard --- I have reports from 2 libraries on 3.10.5 that this is happening and I tested on a third and recorded it here: http://screencast.com/t/jdIB2nsA3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:42:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:42:47 +0000 Subject: [Koha-bugs] [Bug 10079] HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:42:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:42:48 +0000 Subject: [Koha-bugs] [Bug 10079] HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17554|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 18046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18046&action=edit [SIGNED-OFF] Bug 10079 - HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled Test Plan: 1) Enable IndependantBranches 2) Set HomeOrHoldingBranch to holding branch 3) Delete an item whose holding branch is your logged in branch, and whose home branch is not 4) Apply this patch 5) Repeat step 3, it should fail 6) Try to delete another items whose home branch is your logged in branch, and whose holding branch is a different branch. This deletetion should succeed. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:45:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:45:22 +0000 Subject: [Koha-bugs] [Bug 10079] HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:47:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:47:22 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:47:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:47:54 +0000 Subject: [Koha-bugs] [Bug 10187] precision needed in serials-collection.tt (1/quarter) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10187 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:48:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:48:29 +0000 Subject: [Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:49:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:49:29 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:50:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:50:39 +0000 Subject: [Koha-bugs] [Bug 10189] French values in cataloging plugins for unimarc 128b and 128c fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10189 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:51:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:51:45 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:55:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:55:17 +0000 Subject: [Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 17:55:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 15:55:18 +0000 Subject: [Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17946|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 18047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18047&action=edit [SIGNED-OFF] Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt This patch close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt. To test : - in a UNIMARC Koha instance, edit a record - open the plugin for 115a subfield - check the "Form of release - visual projection, motion picture" option list is correct, especially the value "other film type" - ope the plugin for 116 field - check the "Technique (prints) 2" option list is correct, especially the value "lithography" Signed-off-by: Owen Leonard I did not test this in Koha, but it's a simple change of one character which I'm comfortable with signing off on. I don't know if this counts as a string change or not, since the string was previously mixed with a malformed tag. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 18:04:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 16:04:31 +0000 Subject: [Koha-bugs] [Bug 10159] koha-rebuild-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10159 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 18:04:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 16:04:34 +0000 Subject: [Koha-bugs] [Bug 10157] koha-email-enable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10157 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 18:04:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 16:04:38 +0000 Subject: [Koha-bugs] [Bug 10146] koha-stop-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10146 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 18:04:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 16:04:54 +0000 Subject: [Koha-bugs] [Bug 9927] tweak list-deps script to build a better ./debian/control file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mtj at kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 18:05:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 16:05:10 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |koha at univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 18:12:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 16:12:46 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #17 from Katrin Fischer --- Hi Owen, I'd really like to see the regression here fixed so that we are only showing baskets with outstanding orders by default, but a link to show more would certainly not hurt. Maybe we could just link into the aquisition search? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 18:19:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 16:19:17 +0000 Subject: [Koha-bugs] [Bug 9575] Serious Holds Problem with IndependantBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 18:19:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 16:19:18 +0000 Subject: [Koha-bugs] [Bug 9575] Serious Holds Problem with IndependantBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16861|0 |1 is obsolete| | --- Comment #10 from Owen Leonard --- Created attachment 18048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18048&action=edit [SIGNED-OFF] Bug 9575 - Serious Holds Problem with IndependantBranches If IndependantBranches is enabled, all holds for an item display the currently logged in library no matter what, and modifying the holds will set all pickup locations for all the holds to that logged in library! Test plan: 1) Disable IndependantBranches 2) Place 3 holds on a record with 3 different pickup locations 3) Enable IndependantBranches 4) Refresh the holds page for that record, all the holds show now show a pickup location of the logged in branch 5) Modify the order of the holds 6) Disable IndependantBranches 7) Refresh the holds, verify the holds all now have a pickup location of the logged in branch 8) Apply the patch 9) Repeat steps 1-3 10) Refresh the holds page for that record, all the holds should now show the correct pickup branch, but it cannot be changed as IndependantBranches is enabled. Signed-off-by: Kyle M Hall Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 18:24:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 16:24:22 +0000 Subject: [Koha-bugs] [Bug 10224] New: In transit not working for Silver Hills Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10224 Bug ID: 10224 Summary: In transit not working for Silver Hills Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: PC OS: Windows Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: sbirkbeck at wsd393.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com ILL items that have been scanned and sent in transit are failing. The items are being shown as on the shelf and the holds are still on the holds list. Sometimes it happens with all of the items, sometimes it happens with just a few. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 20:48:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 18:48:12 +0000 Subject: [Koha-bugs] [Bug 10054] When SingleBranchMode is enabled, allow superlibrarians to set logged in library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 20:48:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 18:48:15 +0000 Subject: [Koha-bugs] [Bug 10054] When SingleBranchMode is enabled, allow superlibrarians to set logged in library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17453|0 |1 is obsolete| | --- Comment #8 from Owen Leonard --- Created attachment 18049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18049&action=edit [SIGNED-OFF] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library Currently, when SingleBranchMode is enabled, nobody can change the logged in library in Koha. To change it requires disable SingleBranchMode, switching the library, and re-enabling it. It seems reasonable to allow superlibrarians to switch the logged in library even if SingleBranchMode is enabled. Test Plan: 1) Apply this patch 3) Enable SingleBranchMode 4) Log in as a superlibrarian 5) Attempt to change the logged in branch This change should succeed 6) Log in as a non-superlibrarian account 7) Attempt to change the logged n branch This should not be allowed, as per Koha's current behavior Signed-off-by: Owen Leonard I guess this doesn't do any harm even though the practical motivations behind it, as described in the bug, seem otherwise solvable. If SingleBranchMode is supposed to prevent librarians from switching their logged in library why can they choose their library when they first log in? Was SingleBranchMode supposed to only affect the OPAC originally? Or should the login form be modified? This seems to be a band-aid on a poorly-implemented feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:07:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:07:22 +0000 Subject: [Koha-bugs] [Bug 10225] New: If an item isn't editable, don't show the onclick Edit/Delete menu Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 Bug ID: 10225 Summary: If an item isn't editable, don't show the onclick Edit/Delete menu Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Cataloging Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org CC: m.de.rooy at rijksmuseum.nl When editing items, if you click anywhere in the table of items you'll be shown a small Edit/Delete menu. This menu should not appear on rows for items which are not editable because of the IndependantBranches setting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:14:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:14:07 +0000 Subject: [Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 --- Comment #1 from Owen Leonard --- Created attachment 18050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18050&action=edit Bug 10225 - If an item isn't editable, don't show the onclick Edit/Delete menu The user should not be shown edit/delete links when clicking on a row in additems which they cannot edit because of the IndependantBranches setting. This patch adds a class to the row to exclude such rows in the JavaScript onclick handler. To test: - Turn IndependantBranches on and edit items for a title which has holdings from various branches including your own. - Click a row for an item which is held by your library. You should see the "Edit/Delete" links appear. - Click a row for an item which is held by another library. No links should appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:14:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:14:06 +0000 Subject: [Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:18:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:18:00 +0000 Subject: [Koha-bugs] [Bug 9773] Replace YUI AJAX calls in cataloging plugins with jQuery In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #2 from Owen Leonard --- Switching this from enhancement to bug since YUI JS dependencies need to go away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:35:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:35:32 +0000 Subject: [Koha-bugs] [Bug 9358] Fixed field plugins for MARC21 should be updated for MARC21 update #15 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9358 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:35:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:35:43 +0000 Subject: [Koha-bugs] [Bug 9358] Fixed field plugins for MARC21 should be updated for MARC21 update #15 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9358 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6709 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:35:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:35:43 +0000 Subject: [Koha-bugs] [Bug 6709] marc21_field_006.xml and marc21_field_008.xml can't be translated. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6709 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9358 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:37:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:37:06 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #58 from Nicole C. Engard --- I was going to sign off on the follow up but I can't apply the original signed off patch anymore. Bug 8033 - add print receipt option to Koha self-check (edit) Apply? [yn] y Applying: Bug 8033 - add print receipt option to Koha self-check (edit) error: patch failed: koha-tmpl/opac-tmpl/prog/en/modules/sco/receipt.tt:1 error: koha-tmpl/opac-tmpl/prog/en/modules/sco/receipt.tt: patch does not apply Patch failed at 0001 Bug 8033 - add print receipt option to Koha self-check (edit) When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-8033---add-print-receipt-option-to-Koha-self-c-gJKXQ0.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:37:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:37:45 +0000 Subject: [Koha-bugs] [Bug 6709] marc21_field_006.xml and marc21_field_008.xml can't be translated. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6709 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #21 from Chris Cormack --- (In reply to comment #20) > (In reply to comment #19) > > Doesn't apply in 3.10.x (not sure it is needed anyway) > > In case you think it's needed first apply Bug 9358, then this patch applies > cleanly. Ah yeah I think its safe to have on 3.10.x and allows for translation so yep, ive updated the depends and will apply it now. Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:49:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:49:11 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17950|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard --- Created attachment 18051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18051&action=edit Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Well, not only typos. There is also a NEW update for 006/8 Music on April 2013. And 3 missing values in 006. Revised descriptions and labels, source LOC page. Strings spell checked. To test: 1) Apply the patch 2) Test that MARC21 006 and 008 value builders works properly. Small string changes. Signed-off-by: Nicole C. Engard All tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:49:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:49:25 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:52:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:52:10 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14100|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:52:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:52:28 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14101|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:52:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:52:40 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14102|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:56:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:56:03 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14100|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:56:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:56:09 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14101|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 21:56:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 19:56:14 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14102|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 22:00:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 20:00:48 +0000 Subject: [Koha-bugs] [Bug 7110] Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7110 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 22:00:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 20:00:52 +0000 Subject: [Koha-bugs] [Bug 7110] Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7110 --- Comment #11 from Owen Leonard --- Created attachment 18052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18052&action=edit Bug 7110 - Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled The original patch added a message to display if OpacRenewalAllowed is disabled but OPACFineNoRenewals is enabled. This change was reversed by a follow-up on Bug 8408. I think both versions are incorrect: If a patron has fines which exceed the limit set by OPACFineNoRenewals but OPAC renewals are disallowed by OpacRenewalAllowed, no message should be displayed. Information about outstanding fines in this case has no bearing on how the user sees his summary of checkouts. To test, try various combinations of OpacRenewalAllowed and OPACFineNoRenewals with a patron who has outstanding fines: - OpacRenewalAllowed ON and OPACFineNoRenewals ON (set to be triggered by the test patron's fines): Logging in to the OPAC the patron should see a warning on opac-user.pl about not being able to renew items because of fines. - OpacRenewalAllowed ON and OPACFineNoRenewals OFF (threshold high enough not to trigger a block): No warning appears. - OpacRenewalAllowed OFF and OPACFineNoRenewals ON: No warning appears. - OpacRenewalAllowed OFF and OPACFineNoRenewals OFF: No warning appears. If OpacRenewalAllowed is diabled and a patron's fines exceed the limit set by OPACFineNoRenewals they should see no message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 22:01:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 20:01:20 +0000 Subject: [Koha-bugs] [Bug 7110] Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7110 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 22:02:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 20:02:07 +0000 Subject: [Koha-bugs] [Bug 10084] YUI path wrong in CCSR theme with packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10084 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 22:18:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 20:18:52 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17373|0 |1 is obsolete| | --- Comment #59 from Kyle M Hall --- Created attachment 18053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18053&action=edit Bug 8033 [Follow-up] add print receipt option to Koha self-check This follow-up makes some corrections to JavaScript, most importantly by enabling translation of strings embedded in the script. Other corrections: Trailing whitespace, proper Works as expected. Signed-off-by: Mason James Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 22:19:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 20:19:04 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 22:19:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 20:19:06 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17374|0 |1 is obsolete| | --- Comment #60 from Kyle M Hall --- Created attachment 18054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18054&action=edit Bug 8033 - add print receipt option to Koha self-check (edit) 4 misc follow-up fixes 1/ fixed printslip.tmpl typo 2/ fixed display bug 3/ moved hardcoded text string from script to template. 4/ delete unused receipt.tt file To Test: - Sign in to self checkout. - Enter a barcode and click submit. - Click the finish button - You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. fyi: you should no longer see a "<title> Print Receipt for..." line in chrome/IE Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 23:27:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 21:27:48 +0000 Subject: [Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings In-Reply-To: <bug-6553-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6553-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6553-70-JQD5RWXGB4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5991|1 |0 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 23:29:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 21:29:08 +0000 Subject: [Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings In-Reply-To: <bug-6553-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6553-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6553-70-ioolxMER8J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #14 from Liz Rea <liz at catalyst.net.nz> --- This has come back - the attachment doesn't apply anymore, will make a new patch. LR -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 9 23:36:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 21:36:08 +0000 Subject: [Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings In-Reply-To: <bug-6553-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6553-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6553-70-PKPXjJfJzE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5991|0 |1 is obsolete| | --- Comment #15 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 18055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18055&action=edit Bug 6553 - Parentheses in Corporate author break tracings To test: If an author's name includes parentheses or other escape-characters, the tracing links produced in the OPAC fail in XSLT mode. This patch wraps the author names in double-quotes, providing the necessary escapement. Test plan: - Create a new framework, delete Thesaurus from 100 and other fields - Create a new record in this framework (or change an existing record to this framework) - Add 100$a - use parentheses - Check the search links in OPAC detail pages -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 00:46:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 09 May 2013 22:46:41 +0000 Subject: [Koha-bugs] [Bug 9927] tweak list-deps script to build a better ./debian/control file In-Reply-To: <bug-9927-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9927-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9927-70-4hO35BahbL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 --- Comment #15 from Robin Sheat <robin at catalyst.net.nz> --- I'm still not sold on the need for this, in an "if it ain't broke" kinda way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 02:18:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 00:18:45 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7882-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7882-70-SOJQ0kaq1J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #25 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- (In reply to comment #24) > Kyle, > I could move subfields but not fields > (ej a <-> b, but not 610 <-> 611) > That ^ was my mistake. Works as described, but still could not expand or collapse fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 06:14:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 04:14:52 +0000 Subject: [Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings In-Reply-To: <bug-6553-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6553-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6553-70-oXNC4llykE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 08:41:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 06:41:34 +0000 Subject: [Koha-bugs] [Bug 9826] Missing fields in MARC21 authority framework In-Reply-To: <bug-9826-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9826-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9826-70-ieMaFpuEJU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9826 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- (In reply to comment #3) > This patch only touch 'default' framework, perhaps I can do another bug that > updates example frameworks. For bib frameworks there are 2 files, for auth > there is only one. > > To delete present auth framework: > > mysql -ukohauser -pkohapass kohadb -e "delete from auth_subfield_structure; > delete from auth_tag_structure; delete from auth_types;" > > To add the new ones: > > mysql -ukohauser -pkohapass kohadb < $PATH/authorities_normal_marc21.sql > > What's new: > Look in diff view, > http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16174&action=diff > > All green is new + subtags for 368~384 > All lightBlue is modification Thanks for the additional info, Bernardo! Where did you get the list of tags to add? I know it would involve more work, but would you be able to add the appropriate tags to the other frameworks as well, since they're included in this same SQL file and you already know which tags need to be added overall? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 09:05:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 07:05:23 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10184-70-KXWQfTtxMR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 --- Comment #4 from Colin Campbell <colin.campbell at ptfs-europe.com> --- (In reply to comment #3) > I think the added line should be: > > "aaSorting": [[8, "desc"]] > > ...so that the sorted column reflects the sort state in the column header. Does this not add an unnecessary re-sort, the data is sorted unless the user selects to resort it no further processing is required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 09:16:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 07:16:38 +0000 Subject: [Koha-bugs] [Bug 10182] Save and continue editing should be improved In-Reply-To: <bug-10182-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10182-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10182-70-jr5TcR5hVN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10182 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17922|0 |1 is obsolete| | --- Comment #2 from David Cook <dcook at prosentient.com.au> --- Created attachment 18056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18056&action=edit [SIGNED OFF] Bug 10182: Stay on the same tab after saving a biblio When editing a biblio, the bug 7883 introduces the "save and continue editing" feature. After saving, the page is loaded with the first tab selected. This patch refresh the page with the same tab selected. Test plan: 1/ Edit a biblio. 2/ Clic on the 5th tab. 3/ Clic on the "Save and continue editing" button. 4/ You are redirected on the same page with the same tab selected Signed-off-by: David Cook <dcook at prosentient.com.au> Applied 7883, then applied 10182. Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 09:16:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 07:16:42 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10174-70-TULFO39VC2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 Zeno Tajoli <z.tajoli at cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #1 from Zeno Tajoli <z.tajoli at cineca.it> --- I suggest 'Compact many emails in one' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 09:18:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 07:18:58 +0000 Subject: [Koha-bugs] [Bug 10182] Save and continue editing should be improved In-Reply-To: <bug-10182-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10182-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10182-70-TdKehRUv9H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10182 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 09:29:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 07:29:47 +0000 Subject: [Koha-bugs] [Bug 10141] Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin In-Reply-To: <bug-10141-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10141-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10141-70-WUytYVNhWi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17891|0 |1 is obsolete| | --- Comment #6 from David Cook <dcook at prosentient.com.au> --- Created attachment 18057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18057&action=edit [SIGNED OFF] Bug 10141 - Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin Easy workaround This patch expands both options, Illustrations and Nature of.., so each position could be filled independently. To test: 1) edit or add a new recod 2) click on field 008 value builder, positions 18-21 and 24-27 only show an input text box 3) apply the patch 4) reload value_builder page, now each position (18-21,24-27) has it's own pulldown. A similar fix could be used in a similar problem in 006 value builder. Signed-off-by: David Cook <dcook at prosentient.com.au> I struggled with this test plan at first (until I cleared my memcache), but it works as described. Thanks, Bernardo! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 09:30:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 07:30:19 +0000 Subject: [Koha-bugs] [Bug 10141] Enable "18-21 Illustrations" and "24-27 Nature of contents" options for marc21_field_008.pl plugin In-Reply-To: <bug-10141-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10141-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10141-70-BHkUbmA18s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10141 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 09:41:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 07:41:47 +0000 Subject: [Koha-bugs] [Bug 9084] Dates in notices should be formatted according to dateformat system preference In-Reply-To: <bug-9084-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9084-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9084-70-DsuRQjJ3Tv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 09:54:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 07:54:59 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: <bug-9739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9739-70-V5IQUz7OAh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15800|0 |1 is obsolete| | --- Comment #6 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 18058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18058&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 09:55:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 07:55:16 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: <bug-9739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9739-70-64baD7zYe4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15801|0 |1 is obsolete| | --- Comment #7 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 18059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18059&action=edit Proposed patch (followup) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 09:56:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 07:56:09 +0000 Subject: [Koha-bugs] [Bug 9739] more options for serialsUpdate.pl In-Reply-To: <bug-9739-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9739-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9739-70-FWYr3w5g9b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9739 --- Comment #8 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- (In reply to comment #5) > Your followup looks strange : it contains the same strings as the main patch. > > Mathieu Indeed. I recreated patches form my branch and reattached them. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 11:06:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 09:06:25 +0000 Subject: [Koha-bugs] [Bug 9923] correction of a bug due to bz 7129 In-Reply-To: <bug-9923-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9923-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9923-70-dl1dEulac4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 18060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18060&action=edit [3.10.x] Bug 9923 - correction of a bug due to bz 7129 Patch rebased for 3.10.x. Also applies on 3.8.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 13:42:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 11:42:26 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10174-70-EVV4GRHXUv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- That's quite a mouthful - it's a thin column that I don't want to make extra wide just to fit the label. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:05:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:05:36 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9532-70-h3oejhaBEO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 --- Comment #7 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 18061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18061&action=edit Bug 9532: reserve rules with itemtype on biblio (followup) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:05:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:05:57 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9532-70-K0PccBYJtM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:07:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:07:43 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9532-70-umDTLagIHQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18061|Bug 9532: reserve rules |Bug 9532: GetItem must use description|with itemtype on biblio |item-level_itypes syspref |(followup) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:08:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:08:14 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9532-70-4xDOamB8WU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18061|Bug 9532: GetItem must use |Bug 9532: Followup - description|item-level_itypes syspref |GetItem must use | |item-level_itypes syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:12:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:12:49 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9532-70-K8HARhR7DY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #8 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- (In reply to comment #6) > I am not sure this patch works correctly. Even with biblio-level item types, > I am able to place a hold on an item which has the item-level item type set > to Books when the biblio-level item type is "Computer Files," which do not > allow holds. Indeed, I ran the same test and notices that GetItem does not use item-level_itypes syspref, biblio itemtype is used only if items.itype is not defined. See followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:17:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:17:45 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-9m9c2xDDWT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8814|1 |0 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:18:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:18:12 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-sAhdwaTGhg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17988|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:22:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:22:17 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10174-70-rtp5yN5HTD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #0) > At every training I get asked what 'Digest' means in reference to notices. It's unfortunate, because digest is a very unambiguous term *if* you're familiar with mailing lists. If you're not, there's no analogue to compare to. > Or even a reason why we wouldn't want all enhanced > messages to be digests? I think this might be a more fruitful discussion than what to call digests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:38:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:38:48 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10174-70-DMQe7WleLC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 --- Comment #4 from Nicole C. Engard <nengard at gmail.com> --- (In reply to comment #3) > (In reply to comment #0) > > Or even a reason why we wouldn't want all enhanced > > messages to be digests? > > I think this might be a more fruitful discussion than what to call digests. Agreed! I just figured it might be easier to get a label change in to Koha than reworking the feature ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:45:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:45:46 +0000 Subject: [Koha-bugs] [Bug 9424] Move JavaScript out of header include In-Reply-To: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9424-70-zaZRoEWmo1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15191|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18062&action=edit Bug 9424 [Revised] Move JavaScript out of header include This patch removes JavaScript "onlick" attributes from header.inc and moves the functionality to staff-global.js. This is in keeping with the idea of progressive enhancement. To test, be sure to clear your browser cache after applying the patch. - Test the help link. - Test the logout link with the intranetbookbag preference on and off. - Open a patron's account and click "search to hold." Log out, and log in again. Koha should not remember the patron you chose before logging out (as seen from a search results page). Revised for current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:45:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:45:44 +0000 Subject: [Koha-bugs] [Bug 9424] Move JavaScript out of header include In-Reply-To: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9424-70-37zYqhNtF2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:52:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:52:54 +0000 Subject: [Koha-bugs] [Bug 8274] count of suggestions on main page wrong In-Reply-To: <bug-8274-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8274-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8274-70-yPgtwsTtbK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8274 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:07 +0000 Subject: [Koha-bugs] [Bug 9512] "Did you mean" searches authority number as a stem, returns false positives In-Reply-To: <bug-9512-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9512-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9512-70-ABL6dsisEP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9512 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:07 +0000 Subject: [Koha-bugs] [Bug 10062] Attached item from a deleted record In-Reply-To: <bug-10062-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10062-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10062-70-BTqNHxC89L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10062 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:07 +0000 Subject: [Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password In-Reply-To: <bug-10177-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10177-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10177-70-egMmcyNUJb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:07 +0000 Subject: [Koha-bugs] [Bug 9181] Add patron messaging preference to Batch Patrons Modification tool In-Reply-To: <bug-9181-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9181-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9181-70-TK2ojA4SAq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9181 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:08 +0000 Subject: [Koha-bugs] [Bug 8825] Need an interface to see items received in acquisition module In-Reply-To: <bug-8825-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8825-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8825-70-2iA0ZtCUkW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8825 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:07 +0000 Subject: [Koha-bugs] [Bug 8752] Log circulation renewal In-Reply-To: <bug-8752-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8752-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8752-70-Oxx3JRXKrO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8752 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:08 +0000 Subject: [Koha-bugs] [Bug 9485] Short cut to create new authorities In-Reply-To: <bug-9485-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9485-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9485-70-nvBEs1hw7S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9485 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:08 +0000 Subject: [Koha-bugs] [Bug 10113] Currency and cost calculation problem in acquisition In-Reply-To: <bug-10113-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10113-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10113-70-mpMeoj7yAj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10113 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:08 +0000 Subject: [Koha-bugs] [Bug 10220] IDs on checkin columns In-Reply-To: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10220-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10220-70-xinpDYHFCV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10220 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:08 +0000 Subject: [Koha-bugs] [Bug 8754] Cardnumber/accession number range when creating print batches in tools In-Reply-To: <bug-8754-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8754-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8754-70-oi6As5qHQn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8754 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:08 +0000 Subject: [Koha-bugs] [Bug 9558] Customize CSS for mobile In-Reply-To: <bug-9558-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9558-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9558-70-G9TBXRFWbo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9558 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:09 +0000 Subject: [Koha-bugs] [Bug 10221] hold expiration doesn't show on patron's list of holds In-Reply-To: <bug-10221-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10221-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10221-70-Lr1WK55Zxe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:08 +0000 Subject: [Koha-bugs] [Bug 9513] Did you mean? Option to search only 4XX in authority records In-Reply-To: <bug-9513-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9513-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9513-70-D6N7zsjkx6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9513 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:09 +0000 Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for items "Waiting" In-Reply-To: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9774-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9774-70-lc5YGIwjfQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:09 +0000 Subject: [Koha-bugs] [Bug 10056] Styling Issue - Div does not grow. In-Reply-To: <bug-10056-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10056-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10056-70-FOZRcOwhFq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10056 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:09 +0000 Subject: [Koha-bugs] [Bug 10032] Uncertain prices hide 'close basket' without explanation In-Reply-To: <bug-10032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10032-70-TPNx5rEn7C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10032 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:09 +0000 Subject: [Koha-bugs] [Bug 10210] how to checkout an item without barcode In-Reply-To: <bug-10210-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10210-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10210-70-XrBI2aM2bw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10210 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:55:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:55:09 +0000 Subject: [Koha-bugs] [Bug 9612] SRU Responce is different when DOM indexing is enabled In-Reply-To: <bug-9612-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9612-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9612-70-ron20lpCrP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9612 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 14:58:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 12:58:49 +0000 Subject: [Koha-bugs] [Bug 10059] admin user can't see budgets on acq page In-Reply-To: <bug-10059-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10059-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10059-70-Nr725uJPde@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10059 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:01:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:01:04 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-nvDFdVxig0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #26 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> --- Created attachment 18063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18063&action=edit Bug 1993: Improving task scheduler Remove "url" as format as it is not implemented Add csv as output format Use MIME:Lite to send email Call runreport.pl with right parameters Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:01:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:01:52 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-k1WDwMYvVM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8814|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:03:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:03:54 +0000 Subject: [Koha-bugs] [Bug 8901] 952 showing on merge records In-Reply-To: <bug-8901-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8901-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8901-70-j7aFRLrABu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8901 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18064&action=edit Screenshot selection of a merge in 3.10.x I can't reproduce this bug in master or 3.10.x. See the screenshot: no 952. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:08:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:08:29 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-eiifeLQRem@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #27 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> --- Finally, patch only needed to be rebased. But now I don't know iln which status I should put it -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:12:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:12:04 +0000 Subject: [Koha-bugs] [Bug 10197] add id tags to patron info list In-Reply-To: <bug-10197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10197-70-YI7U4b55s7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:12:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:12:19 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-MDAzncVfRB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Sophie, signed off is ok if it was signed off before and only needed a rebase. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:13:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:13:06 +0000 Subject: [Koha-bugs] [Bug 7635] ignoring hold still marks it in transit In-Reply-To: <bug-7635-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7635-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7635-70-OaTwu6d6jR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7635 --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #3) > I cannot reproduce this on master or 3.10.x. Nicole, can you retest to > confirm? Me neither! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:20:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:20:22 +0000 Subject: [Koha-bugs] [Bug 10016] SelfCheckTimeout not logging patron out In-Reply-To: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10016-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10016-70-x3UejsbkvH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10016 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Confirmed in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:44:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:44:35 +0000 Subject: [Koha-bugs] [Bug 9679] can't place hold from cart in CCSR In-Reply-To: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9679-70-fMO930Glbz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9679 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:51:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:51:39 +0000 Subject: [Koha-bugs] [Bug 10197] add id tags to patron info list In-Reply-To: <bug-10197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10197-70-6h6mCQ8BkW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18065&action=edit Bug 10197: Add classes to patron info list This patch adds classes to the patron info found on the top left of the circulation and patron related pages to allow for easy styling of the information displayed. To test: * Apply patch * View a patron detail page and view the source on the list to the left to see the styles * View a checkout screen and view the source on the list to the left with patron info to see the styles * You could also try to style things by customizing your CSS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:51:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:51:52 +0000 Subject: [Koha-bugs] [Bug 10197] add id tags to patron info list In-Reply-To: <bug-10197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10197-70-umvL2pDArP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:51:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:51:57 +0000 Subject: [Koha-bugs] [Bug 10197] add id tags to patron info list In-Reply-To: <bug-10197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10197-70-kvsHzRV1bb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:54:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:54:33 +0000 Subject: [Koha-bugs] [Bug 9679] can't place hold from cart in CCSR In-Reply-To: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9679-70-MAfbmPLkrp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9679 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:54:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:54:35 +0000 Subject: [Koha-bugs] [Bug 9679] can't place hold from cart in CCSR In-Reply-To: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9679-70-nitrqVm2dE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9679 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18066&action=edit Bug 9679 - can't place hold from cart in CCSR When the CCSR theme is enabled, selecting items in the cart and clicking "place hold" triggers a JavaScript error and fails. This patch adds a function missing from the CCSR version of basket.js. To test, apply the patch and clear your browser cache. - Enable the CCSR theme and put items into the OPAC cart. - Open the cart, select one or more items, and click "place hold." The cart should automatically close and the main window should redirect to the holds screen showing your selections. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 15:55:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 13:55:24 +0000 Subject: [Koha-bugs] [Bug 10197] add id tags to patron info list In-Reply-To: <bug-10197-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10197-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10197-70-h09YbruBFJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10197 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18065|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18067&action=edit Bug 10197: Add classes to patron info list This patch adds classes to the patron info found on the top left of the circulation and patron related pages to allow for easy styling of the information displayed. To test: * Apply patch * View a patron detail page and view the source on the list to the left to see the styles * View a checkout screen and view the source on the list to the left with patron info to see the styles * You could also try to style things by customizing your CSS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 16:04:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 14:04:27 +0000 Subject: [Koha-bugs] [Bug 9203] limit pull down broken when adding biblio to subscription In-Reply-To: <bug-9203-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9203-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9203-70-f6rtIvd4vD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9203 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 16:09:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 14:09:15 +0000 Subject: [Koha-bugs] [Bug 9203] limit pull down broken when adding biblio to subscription In-Reply-To: <bug-9203-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9203-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9203-70-Eb2lPCUFmK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9203 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- The script seems to have been modified to check the AdvancedSearchTypes system preference and display options based on that (ccode,itemtype, or loc). However, it only works if you have a single choice. If you have "itemtypes|ccode" in your preference it breaks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 16:17:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 14:17:43 +0000 Subject: [Koha-bugs] [Bug 9769] Replace YUI buttons on acquisitions basket page with Bootstrap In-Reply-To: <bug-9769-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9769-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9769-70-8yp6rrqgne@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 --- Comment #8 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18068&action=edit [SIGNED-OFF] Bug 9679 - can't place hold from cart in CCSR When the CCSR theme is enabled, selecting items in the cart and clicking "place hold" triggers a JavaScript error and fails. This patch adds a function missing from the CCSR version of basket.js. To test, apply the patch and clear your browser cache. - Enable the CCSR theme and put items into the OPAC cart. - Open the cart, select one or more items, and click "place hold." The cart should automatically close and the main window should redirect to the holds screen showing your selections. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> All test passed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 16:18:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 14:18:35 +0000 Subject: [Koha-bugs] [Bug 9679] can't place hold from cart in CCSR In-Reply-To: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9679-70-4QAN3DSBDH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9679 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18066|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18069&action=edit [SIGNED-OFF] Bug 9679 - can't place hold from cart in CCSR When the CCSR theme is enabled, selecting items in the cart and clicking "place hold" triggers a JavaScript error and fails. This patch adds a function missing from the CCSR version of basket.js. To test, apply the patch and clear your browser cache. - Enable the CCSR theme and put items into the OPAC cart. - Open the cart, select one or more items, and click "place hold." The cart should automatically close and the main window should redirect to the holds screen showing your selections. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> All test passed http://bugs.koha-community.org/show_bug.cgi?id=9769 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 16:18:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 14:18:45 +0000 Subject: [Koha-bugs] [Bug 9679] can't place hold from cart in CCSR In-Reply-To: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9679-70-20H24AmMn0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9679 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 16:19:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 14:19:35 +0000 Subject: [Koha-bugs] [Bug 9769] Replace YUI buttons on acquisitions basket page with Bootstrap In-Reply-To: <bug-9769-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9769-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9769-70-vcPAsK9ILu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9769 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18068|0 |1 is obsolete| | --- Comment #9 from Nicole C. Engard <nengard at gmail.com> --- Comment on attachment 18068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18068 [SIGNED-OFF] Bug 9679 - can't place hold from cart in CCSR wrong bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 16:27:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 14:27:41 +0000 Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data In-Reply-To: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9836-70-27AGmsulQf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 16:38:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 14:38:19 +0000 Subject: [Koha-bugs] [Bug 10226] New: suspended holds still show not available Message-ID: <bug-10226-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10226 Bug ID: 10226 Summary: suspended holds still show not available Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com CC: gmcharlt at gmail.com See here: http://screencast.com/t/4ZfelnlJ If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 16:41:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 14:41:13 +0000 Subject: [Koha-bugs] [Bug 8901] 952 showing on merge records In-Reply-To: <bug-8901-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8901-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8901-70-0tBrDxFshx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8901 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 16:58:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 14:58:00 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9593-70-yOtJ5ftkUo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17949|0 |1 is obsolete| | --- Comment #23 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 18070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18070&action=edit Prices not imported correctly from a staged file Here is a new version of my patch that seeks to treat correctly every form of price sequence whatever the position of the symbol and even if the iso code is used. It 's still possible to pick another price than the default one ( default=first of the price zone string) but unlike the previous mechanism of MungeMarcPrice which worked only for prices preceded by the currency sign, it's now valid wherever the symbol is situated. As symbol you may enter a pure currency sign as well as a string in which it's included ('$US') or a plain latin character string ('Br'). Moreover, an 'isocode' column had been added in currency table (editable in the pro interface from Administration/Currencies and exchange rates) So you can also choose to pickup a currency from its iso code. Isocode is checked first if provided and symbol then. If no active currency is defined, the first price will be systematically picked up; Beware that currency will be activated in currency table only if necessary, this to avoid unusefull checkings. Whenever active currency is enabled and neather the symbol nor the isocode is found in the price string, the resulting price is set to 0 rather than picking the first one. This, to avoid merging prices in different currencies. I furnish a little test file ("sampl_multi_currencies") where the price zones look like this : A hauteur d'homme : 75.40 EUR, 93.5 USD, 20 250 EGP A la conqu?te du Graal : $44, 23 ?, 64 Br, ?30 Bernanos et les ?ges de la vie : 25,5 EUR, $US32, $LD35 Chateaubriand et la gravit? du comique : 38 Ksh, ?300, $62 Ecrire la sculpture : 32 EUR, 45$ CAN, 46$ USD I customized it with MarcTools : it's important to note that in MarcTools the dollar as currency sign has to be wrote down {dollar} not to be taken as a separator and truncate the price zone. Test Plan for multi currencies price zone : 1) Go to Pro interface Administration/Currencies and exchange rates and enter the data for the currency you would like to be privileged when different currencies are present. Mean that you make it active of course. 2) Get on your pc, an isofile with multi currencies price zone. 3) Go to Tools/Stage MARC records for import and stage it in koha. 4) Go to Acquisition module, and an open basket of your choice and click on 'From a staged file' 5) Choose your test file and add it to the basket 6) Click on an individual 'add order' link where you know the 'active currency' is not on first price and is following the digit part : the price might beeing set to 00.00 in the 'Vendor price' field of Accounting details block. 7) now Apply the patch As a modification had to be made in currency sql table, the database update should be made eather through the Pro interface or if not proposed automatically, through the command line : cd src/installer/data/mysql perl updatadatabase.pl 9) Go to Pro interface Administration/Currencies and exchange rates and add the isocode for your active currency you would like to be privileged when several currencies are present you can make different test with both symbol AND isocode defined or only symbol. 10) Go back to Acquisition module and your staged test file 11) Redo several tests on the same link changing currency/isocode sign in currency table between every test, you can a) go back with go back function of your browser b) if you have 'lost' your link because it ends up to be really imported, go to Tools/Staged MARC record management and clean your file test. Then redo stages 3,4 and 5 12) The price you asked for might now be present (I hope so) 13) Repeat the tests on another link 14) At the end, you can disabled your active currency in Currencies and exchange rates (setting to 0) and redo same tests. You will see that the first currency of price zone is picked up as expected 15) Sign off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:05:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:05:33 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-t3by79aw0J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17926|0 |1 is obsolete| | --- Comment #40 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 18071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18071&action=edit Bug 8236 Block renewing for overdue items Hello David, About the override_limit question, my patch respects both following necessities : 1) To renew an item by mistake (clicking on the renew buttons) must be impossible : That is done by a second check in renewscript.pl (the script is called by the button). So whenever this button is clicked by error the renewal fails if the member/item is blocked.I also add a function to hide renew buttons when there are no renewal checkbox available 2) To renew an item knowingly must remains possible through the override_limit : Situations may always happen where a certain flexibility is needed and where passing over the rule is the more appropriate thing to do. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:11:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:11:21 +0000 Subject: [Koha-bugs] [Bug 9203] limit pull down broken when adding biblio to subscription In-Reply-To: <bug-9203-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9203-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9203-70-F2OhcJ0ynr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9203 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18072&action=edit Bug 9203 [Incomplete] limit pull down broken when adding biblio to subscription When creating a subscription, if you use "Search for Biblio" link to search for an existing record the popup has a broken item type selection option. This broke when it became possible to add multiple values to the AdvancedSearchTypes system preference. This patch uses code from opac-search.pl as a template for enabling handling of multiple search limiters when buliding the search form. HOWEVER, I'm not sure how to amend the search process to handle multiple limiters. I would be grateful if someone could take it over from here or walk me through the process. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:24:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:24:03 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-gsb5Q5J5S4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18071|0 |1 is obsolete| | --- Comment #41 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 18073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18073&action=edit Bug 8236 Block renewing for overdue items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:36:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:36:35 +0000 Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data In-Reply-To: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9836-70-b6mJL4ZQfY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17929|0 |1 is obsolete| | --- Comment #7 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 18074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18074&action=edit Bug 9836 Filtering sort1 list according to patron category in patron data Hello Forgot to report the add of new column linked_with in kohastructure.sql file corrected. Test plan : 1) Apply patch As a modification had to be made in authorised_values sql table, the database update should be be proposed when launching the Pro interface if not, make it through command line : cd src/installer/data/mysql perl updatadatabase.pl 2) Go to Administration/Authorized values and select Bsort1 category 3) Edit a value you 'd like to bind with a patron category 4) Select the patron category in "Linked to" list and save 5) Do same thing for some other values 6) Go to an existing patron page, Details tab and set the patron category to the one you had linked some Bsort1 values with; 7) If you click below on Sort1 list, you 'll see that only these values are displayed. 8) From Patrons home module choose the category for a new patron in "New patron" list : again, you 'll see that only the linked values are to be seen in Sort1 list 9) Sign off the patch. Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:36:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:36:54 +0000 Subject: [Koha-bugs] [Bug 9702] Dont allow to reserve a document already in the hand of the patron In-Reply-To: <bug-9702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9702-70-JXRZREn5Co@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9702 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- > This is not an enhancement request - but a bug. Koha used to stop users from > placing the same item on hold over and over in previous releases. I thought this was the case too, but I can't find a previous version that does. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:37:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:37:42 +0000 Subject: [Koha-bugs] [Bug 9702] Don't allow a patron to place a hold on an item they have checked out In-Reply-To: <bug-9702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9702-70-fyYrMtba0e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9702 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master Summary|Dont allow to reserve a |Don't allow a patron to |document already in the |place a hold on an item |hand of the patron |they have checked out Severity|major |enhancement -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:37:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:37:54 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9593-70-NlSVT1Jrdz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #24 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 18075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18075&action=edit sample_multicurrencies -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:40:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:40:50 +0000 Subject: [Koha-bugs] [Bug 10227] New: GetMessagingPreferences does not return correct Digest preferences Message-ID: <bug-10227-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10227 Bug ID: 10227 Summary: GetMessagingPreferences does not return correct Digest preferences Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: sophie.meynieux at biblibre.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com SQL request in GetMessaginPreferences does not join on digest value, so, for a given patron, if you request his messaging preferences for a given message, it returns 2 rows, one with digest=On and the other with digest=Off rather than juste one corresponding to the Digest preference of the patron. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:44:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:44:05 +0000 Subject: [Koha-bugs] [Bug 9929] can't filter suggestions in Chrome In-Reply-To: <bug-9929-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9929-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9929-70-goZ52O0T80@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9929 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #1) > Unable to reproduce Me neither. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:46:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:46:04 +0000 Subject: [Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu In-Reply-To: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10225-70-Vddj3ZvY81@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18050|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18076&action=edit [SIGNED-OFF] Bug 10225 - If an item isn't editable, don't show the onclick Edit/Delete menu The user should not be shown edit/delete links when clicking on a row in additems which they cannot edit because of the IndependantBranches setting. This patch adds a class to the row to exclude such rows in the JavaScript onclick handler. To test: - Turn IndependantBranches on and edit items for a title which has holdings from various branches including your own. - Click a row for an item which is held by your library. You should see the "Edit/Delete" links appear. - Click a row for an item which is held by another library. No links should appear. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> All test pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:46:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:46:16 +0000 Subject: [Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu In-Reply-To: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10225-70-5pNn8ejfME@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:47:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:47:30 +0000 Subject: [Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date In-Reply-To: <bug-10067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10067-70-mBm7iAK9Lr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Confirmed in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:50:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:50:14 +0000 Subject: [Koha-bugs] [Bug 9678] fields in wrong tab in books framework In-Reply-To: <bug-9678-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9678-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9678-70-dbOkCWNwyy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9678 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:51:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:51:03 +0000 Subject: [Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR In-Reply-To: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8884-70-1AI9yp6d9x@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:56:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:56:55 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: <bug-8231-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8231-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8231-70-v9ynCmlYTe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17273|0 |1 is obsolete| | --- Comment #14 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 18077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18077&action=edit Bug 8231 Systematic warning at check in if borrower is restricted I submit again this patch now that bug 9031 is fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 17:59:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 15:59:53 +0000 Subject: [Koha-bugs] [Bug 9670] can't delete quote of the day that was just added In-Reply-To: <bug-9670-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9670-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9670-70-S3wZFStVeD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9670 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master Assignee|gmcharlt at gmail.com |cnighswonger at foundations.ed | |u --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Confirmed in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 18:01:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 16:01:46 +0000 Subject: [Koha-bugs] [Bug 9680] cart aligned right in CCSR In-Reply-To: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9680-70-DGgicxsxJV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 18:09:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 16:09:24 +0000 Subject: [Koha-bugs] [Bug 9680] cart aligned right in CCSR In-Reply-To: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9680-70-31MIPce4tl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 18:20:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 16:20:04 +0000 Subject: [Koha-bugs] [Bug 9680] cart aligned right in CCSR In-Reply-To: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9680-70-0ZHayH2HdI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 18:20:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 16:20:06 +0000 Subject: [Koha-bugs] [Bug 9680] cart aligned right in CCSR In-Reply-To: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9680-70-NKwj0OC0U8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18078&action=edit Bug 9680 - cart aligned right in CCSR The CCSR theme sets a min-width of 1000px for windows which are more than 700px wide. This caused the cart popup window to be given a min-width of 1000px, resulting in a broken layout with unnecessary horizontal scrolling. This patch adds a class to the cart template and to other pop-up window templates to ensure that a large min-width is not enforced and to give consistent padding to those pages. To test, set your theme to 'CCSR' and view the following pop-up pages: - The Cart. From the cart, trigger: - The "send" window - The "download" window - From a view of a List's contents trigger: - The "send" window" - The "download" window Each of these pages should look correct with no horizontal scrolling. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 18:24:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 16:24:43 +0000 Subject: [Koha-bugs] [Bug 10108] can't print more than one page of overdues In-Reply-To: <bug-10108-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10108-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10108-70-RSavMzgaE2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10108 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Confirmed in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 18:39:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 16:39:47 +0000 Subject: [Koha-bugs] [Bug 10108] can't print more than one page of overdues In-Reply-To: <bug-10108-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10108-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10108-70-9p8OCfgmxZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10108 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Browser compatibility Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- > Confirmed in master. Correction: Confirmed in master when using Firefox (on both Windows 7 and Ubuntu). The problem doesn't show when using Chrome or Opera. This sounds like Bug 6291 which unfortunately didn't exactly get a "real" fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 18:51:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 16:51:51 +0000 Subject: [Koha-bugs] [Bug 9929] can't filter suggestions in Chrome In-Reply-To: <bug-9929-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9929-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9929-70-DurGlhzmYe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9929 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 18:54:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 16:54:47 +0000 Subject: [Koha-bugs] [Bug 9680] cart aligned right in CCSR In-Reply-To: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9680-70-VXLHIK08Rl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18078|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18079&action=edit [SIGNED-OFF] Bug 9680 - cart aligned right in CCSR The CCSR theme sets a min-width of 1000px for windows which are more than 700px wide. This caused the cart popup window to be given a min-width of 1000px, resulting in a broken layout with unnecessary horizontal scrolling. This patch adds a class to the cart template and to other pop-up window templates to ensure that a large min-width is not enforced and to give consistent padding to those pages. To test, set your theme to 'CCSR' and view the following pop-up pages: - The Cart. From the cart, trigger: - The "send" window - The "download" window - From a view of a List's contents trigger: - The "send" window" - The "download" window Each of these pages should look correct with no horizontal scrolling. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> All tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 18:54:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 16:54:56 +0000 Subject: [Koha-bugs] [Bug 9680] cart aligned right in CCSR In-Reply-To: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9680-70-CRZKkGSUqg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 18:57:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 16:57:35 +0000 Subject: [Koha-bugs] [Bug 10228] New: cart and list download/email background sloppy in CCSR Message-ID: <bug-10228-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10228 Bug ID: 10228 Summary: cart and list download/email background sloppy in CCSR Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com Created attachment 18080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18080&action=edit cart in ccsr I don't know how else to explain this - but when in the cart or the list and you click send or download the pop up is ugly. The white background looks like an error because there are no rounded edges - also the font kind of looks like it's pushed up against the form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 19:09:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 17:09:45 +0000 Subject: [Koha-bugs] [Bug 10198] Add the ability to import and export authorized values In-Reply-To: <bug-10198-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10198-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10198-70-SiQGvnoRA6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10198 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 19:12:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 17:12:38 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: <bug-10200-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10200-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10200-70-rPfuD40zGJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 19:17:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 17:17:16 +0000 Subject: [Koha-bugs] [Bug 9891] Current suspend holds have disappeared In-Reply-To: <bug-9891-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9891-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9891-70-mg4TonMR7S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9891 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 20:55:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 18:55:46 +0000 Subject: [Koha-bugs] [Bug 10229] New: branch transfer limits showing one tab at bottom Message-ID: <bug-10229-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10229 Bug ID: 10229 Summary: branch transfer limits showing one tab at bottom Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All URL: /cgi-bin/koha/admin/branch_transfer_limits.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com Created attachment 18081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18081&action=edit transfer limits See attached. The final tab across the top always shows at the bottom of the screen before the save button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 21:38:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 19:38:49 +0000 Subject: [Koha-bugs] [Bug 10108] can't print more than one page of overdues In-Reply-To: <bug-10108-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10108-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10108-70-gj6ACGX3R2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10108 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 21:38:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 19:38:51 +0000 Subject: [Koha-bugs] [Bug 10108] can't print more than one page of overdues In-Reply-To: <bug-10108-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10108-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10108-70-7vAgLb3JO3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10108 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18082&action=edit Bug 10108 - can't print more than one page of overdues Printing a report like overdues in Firefox results in a printout which cuts off in the middle. I traced the cause to something in the YUI grid system, although I'm not sure what specific definition is the cause. This patch adds a "screen" parameter to the @import which loads the YUI grid CSS file. This will disable YUI grid layouts in print views. The main disadvantage to this, as far as I can tell, is that it will "linearize" some layouts. For instance: the patron detail page (moremember.pl) which on screen is divided into two columns. I think this disadvantage is outweighed by the ability to make complete prints. To test, apply the patch and clear your cache. Try printing various reports from Firefox. Printouts should look correct and be complete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 21:50:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 19:50:10 +0000 Subject: [Koha-bugs] [Bug 9378] Translations don't apply? In-Reply-To: <bug-9378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9378-70-eoFSxjUR77@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9378 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 21:54:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 19:54:06 +0000 Subject: [Koha-bugs] [Bug 10158] sorting serial issues In-Reply-To: <bug-10158-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10158-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10158-70-klJCUriZSC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10158 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- What page does this bug refer to? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 22:07:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 20:07:35 +0000 Subject: [Koha-bugs] [Bug 10196] items table partially hidden in marc view in ccsr In-Reply-To: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10196-70-bJRkP346XA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10196 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18083&action=edit Bug 10196 - items table partially hidden in marc view in ccsr In the CCSR theme's OPAC MARC view the table of items is truncated because the container div is styled with "overflow:hidden." I think the complete display of information is more important than not seeing a horizontal scrollbar, so this patch removes the style. To test, apply the patch and clear your browser cache. View a MARC detail page for a title which has holdings and confirm that the entire table can be seen. Test other pages to make sure no unwanted layout changes have resulted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 22:07:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 20:07:34 +0000 Subject: [Koha-bugs] [Bug 10196] items table partially hidden in marc view in ccsr In-Reply-To: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10196-70-rTknmn9PzU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10196 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 10 22:32:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 20:32:28 +0000 Subject: [Koha-bugs] [Bug 10108] can't print more than one page of overdues In-Reply-To: <bug-10108-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10108-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10108-70-sIf6JXZN6K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10108 --- Comment #5 from Nicole C. Engard <nengard at gmail.com> --- Should this work for reports run from the saved reports page? Because it doesn't appear to be. I have 200 lines set to show and then I print but only get 1 page. It is working for the Holds Queue though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 01:14:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 23:14:30 +0000 Subject: [Koha-bugs] [Bug 9923] correction of a bug due to bz 7129 In-Reply-To: <bug-9923-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9923-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9923-70-AjDjrhwHHX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> --- Applied cleanly to 3.10.x will be in 3.10.6. Still conflicts for 3.8.x -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 01:21:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 23:21:38 +0000 Subject: [Koha-bugs] [Bug 10176] Invalid URLs in 'Refine Search Results' when it uses UNICODE symbols In-Reply-To: <bug-10176-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10176-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10176-70-ekj4gHyTkR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10176 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.10.x and explained what use utf8; does Will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 01:30:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 10 May 2013 23:30:28 +0000 Subject: [Koha-bugs] [Bug 10183] Serials collection table is displayed with a single pixel before and after In-Reply-To: <bug-10183-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10183-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10183-70-4SJtp2ZGYE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10183 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Does not apply to 3.10.x . But I dont think it is needed, if I am wrong please send a patch for 3.10.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 03:39:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 01:39:15 +0000 Subject: [Koha-bugs] [Bug 10158] sorting serial issues In-Reply-To: <bug-10158-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10158-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10158-70-sLbYTeHSLl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10158 --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- The opac details page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 03:42:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 01:42:01 +0000 Subject: [Koha-bugs] [Bug 10196] items table partially hidden in marc view in ccsr In-Reply-To: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10196-70-xRE9XZTqLx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10196 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18083|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18084&action=edit [SIGNED-OFF] Bug 10196 - items table partially hidden in marc view in ccsr In the CCSR theme's OPAC MARC view the table of items is truncated because the container div is styled with "overflow:hidden." I think the complete display of information is more important than not seeing a horizontal scrollbar, so this patch removes the style. To test, apply the patch and clear your browser cache. View a MARC detail page for a title which has holdings and confirm that the entire table can be seen. Test other pages to make sure no unwanted layout changes have resulted. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> all tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 03:42:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 01:42:13 +0000 Subject: [Koha-bugs] [Bug 10196] items table partially hidden in marc view in ccsr In-Reply-To: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10196-70-VSxDSmoFz5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10196 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 13:41:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 11:41:11 +0000 Subject: [Koha-bugs] [Bug 9702] Don't allow a patron to place a hold on an item they have checked out In-Reply-To: <bug-9702-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9702-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9702-70-OUm6AaCwsS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9702 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think Owen is right and it always worked that way, but there is a new system preference in 3.12: AllowHoldsOnPatronsPossessions Allow/Don't allow a patron to place a hold on a record where the patron already has one or more items attached to that record checked out. *** This bug has been marked as a duplicate of bug 9206 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 13:41:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 11:41:11 +0000 Subject: [Koha-bugs] [Bug 9206] Only allow place holds in records that the patron don't have in his possession In-Reply-To: <bug-9206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9206-70-1JZS5M02mi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9206 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anthony.laquerre at ccsr.qc.ca --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 9702 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 13:47:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 11:47:57 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10174-70-fk7nAAsrMq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Some of our libraries are using the 'single' mail option and not the digests. I am not sure killing a feature is the answer. Would something like 'summary mail' work? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 13:51:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 11:51:50 +0000 Subject: [Koha-bugs] [Bug 9927] tweak list-deps script to build a better ./debian/control file In-Reply-To: <bug-9927-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9927-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9927-70-47bPs0DLwu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9927 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 14:14:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 12:14:22 +0000 Subject: [Koha-bugs] [Bug 10224] In transit not working for Silver Hills In-Reply-To: <bug-10224-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10224-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10224-70-nFYQwlJpre@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10224 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Sarah, maybe you intended to contact your support vendor? I am not sure if this is a bug or a configuration issue and as we don't have a way to know how your ILL items are set up in your installation we can't test what's going wrong for you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 14:20:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 12:20:19 +0000 Subject: [Koha-bugs] [Bug 9906] Holds Return Policy and Local Hold Item Types not working as expected In-Reply-To: <bug-9906-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9906-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9906-70-TaRjoqK1QW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9906 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Heather, I won't have time to test this, but maybe someone else can confirm? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 14:20:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 12:20:56 +0000 Subject: [Koha-bugs] [Bug 9965] Improve integration of report plugins with existing reports In-Reply-To: <bug-9965-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9965-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9965-70-mYGxyyo6M9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9965 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 14:24:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 12:24:37 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: <bug-10215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10215-70-zPioYBhVWV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |minor --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this has potential as a bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 14:28:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 12:28:24 +0000 Subject: [Koha-bugs] [Bug 10199] Move fields type, options and explanation from systempreferences table? In-Reply-To: <bug-10199-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10199-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10199-70-7sTCDePTD0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10199 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Marcel, I am not sure what we would win by dividing local use preferences and normal preferences. Both need a table for the value set to be saved, so 2 tables seem more error prone to me than having one with a few columns unused? I am sorry, but I don't understand the point about deleting the pref from your description. Could you give an example where this is a problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 14:29:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 12:29:51 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-FbCSwzeEJt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Owen, reading your comments I see you tested this - is this ready for sign off or is there a problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 14:37:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 12:37:13 +0000 Subject: [Koha-bugs] [Bug 10175] Software error in opac-detail.pl when CGISESSID cookie is not set In-Reply-To: <bug-10175-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10175-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10175-70-RaSfbNHots@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10175 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think we had 2 other bug reports that might be related to this: - bug 10217 - bug 9980 Could you check and resolve duplicate if one is a match? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 14:39:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 12:39:12 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: <bug-7498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7498-70-WwyVxJGDS3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|master |3.14 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Looks good on first glance and includes unit tests - contains a few strings so bumping to 3.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 14:45:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 12:45:01 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: <bug-7679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7679-70-nzsaNwIDTM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 15:11:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 13:11:54 +0000 Subject: [Koha-bugs] [Bug 9994] Changing 'rows per page' on saved sql reports doesn't work with runtime parameters In-Reply-To: <bug-9994-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9994-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9994-70-l1o8OinAq9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9994 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 9719 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 15:11:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 13:11:54 +0000 Subject: [Koha-bugs] [Bug 9719] Changing the rows per page on a custom report fails if it has user supplied parameters In-Reply-To: <bug-9719-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9719-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9719-70-rhExLEzdYn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 9994 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 16:35:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 14:35:50 +0000 Subject: [Koha-bugs] [Bug 10217] Make sure direct links to detail views work when there is no session In-Reply-To: <bug-10217-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10217-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10217-70-HGIRBojvCA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10217 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 16:35:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 14:35:52 +0000 Subject: [Koha-bugs] [Bug 10217] Make sure direct links to detail views work when there is no session In-Reply-To: <bug-10217-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10217-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10217-70-ZVwN7Cuvd0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10217 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18037|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18085&action=edit [PASSED QA] Bug 10217 - Make sure direct links to detail views work when there is no session To reproduce: - Make sure you do not have a session for the OPAC you will be testing with. Delete the CGISESSID session cookie if you have one. - Go directly to a detail view, e.g.: /cgi-bin/koha/opac-detail.pl?biblionumber=1 - Observe the error "Can't use an undefined value as a HASH reference at /home/magnus/scripts/kohadev/opac/opac-detail.pl line 445." To test: - Apply the patch - Reload the page with the error - You should now see the detail view of the record, as usual Thanks to Chris Cormack who suggested the fix for this! Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Tested according to test plan, confirmed patch fixes the problem. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 11 20:39:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 11 May 2013 18:39:41 +0000 Subject: [Koha-bugs] [Bug 10230] New: Match points do not work with authorities Message-ID: <bug-10230-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 Bug ID: 10230 Summary: Match points do not work with authorities Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: jcamins at cpbibliography.com Some of the changes in 3.12 cause problems with matching when importing authorities. Individual descriptions on each patch, and test plan on the last. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 05:07:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 03:07:37 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10166-70-Aj6w6p8wk4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> --- Does not apply to 3.10.x please send a new patch if it is needed for 3.10.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 05:09:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 03:09:35 +0000 Subject: [Koha-bugs] [Bug 8896] Delete serials no more missing from missinglist In-Reply-To: <bug-8896-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8896-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8896-70-517SlFsGBa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8896 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #25 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 05:11:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 03:11:18 +0000 Subject: [Koha-bugs] [Bug 9961] Truncation and QueryAutoTruncate not working properly with new QueryParser In-Reply-To: <bug-9961-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9961-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9961-70-kWRupW0Vbs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9961 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Not needed for 3.10.x bug fix for new feature on 3.12.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 05:12:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 03:12:33 +0000 Subject: [Koha-bugs] [Bug 10204] Patron image no longer appears in the OPAC In-Reply-To: <bug-10204-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10204-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10204-70-QIypg2vQ7V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10204 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Not needed for 3.10.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 05:15:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 03:15:03 +0000 Subject: [Koha-bugs] [Bug 10156] Fix usr/bin/perl path for get_report_social_data.pl In-Reply-To: <bug-10156-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10156-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10156-70-1MMuFBcb6u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10156 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 05:17:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 03:17:40 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: <bug-10185-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10185-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10185-70-gSjdaJqWhy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #19 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 10:45:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 08:45:09 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10178-70-1GeRHS2Eeg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 10:45:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 08:45:13 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10178-70-kNQyW1Gnno@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18051|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18086&action=edit [PASSED QA] Bug 10178 - Typos in plugins for 006 and 008 in MARC21 Well, not only typos. There is also a NEW update for 006/8 Music on April 2013. And 3 missing values in 006. Revised descriptions and labels, source LOC page. Strings spell checked. To test: 1) Apply the patch 2) Test that MARC21 006 and 008 value builders works properly. Small string changes. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> All tests pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> XML changes only, passes all tests. Contains string changes, so should go into 3.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 10:56:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 08:56:07 +0000 Subject: [Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt In-Reply-To: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10191-70-BcUgVILZar@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 10:56:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 08:56:09 +0000 Subject: [Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt In-Reply-To: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10191-70-YZj4VCSgVB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18047|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18087&action=edit [PASSED QA] Bug 10191: Close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt This patch close 2 option tags in unimarc_field_115a.tt and unimarc_field_116.tt. To test : - in a UNIMARC Koha instance, edit a record - open the plugin for 115a subfield - check the "Form of release - visual projection, motion picture" option list is correct, especially the value "other film type" - open the plugin for 116 field - check the "Technique (prints) 2" option list is correct, especially the value "lithography" Signed-off-by: Owen Leonard <oleonard at myacpl.org> I did not test this in Koha, but it's a simple change of one character which I'm comfortable with signing off on. I don't know if this counts as a string change or not, since the string was previously mixed with a malformed tag. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes tests and fixes an obvious problem in the HTML. I checked the po files - currently the strings appear as: "other film type/option> %s " So in theory it's possible to translate them correctly even if the standard templates now are not correct. Probably has to wait for 3.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 10:56:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 08:56:21 +0000 Subject: [Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt In-Reply-To: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10191-70-D8a3Q8c5bt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off CC| |katrin.fischer at bsz-bw.de Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 10:56:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 08:56:36 +0000 Subject: [Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt In-Reply-To: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10191-70-1Ns5I15x7D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 11:08:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 09:08:20 +0000 Subject: [Koha-bugs] [Bug 9680] cart aligned right in CCSR In-Reply-To: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9680-70-8PKCW3zrgq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 11:08:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 09:08:22 +0000 Subject: [Koha-bugs] [Bug 9680] cart aligned right in CCSR In-Reply-To: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9680-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9680-70-xbcwmoXNJT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18079|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18088&action=edit [PASSED QA] Bug 9680 - cart aligned right in CCSR The CCSR theme sets a min-width of 1000px for windows which are more than 700px wide. This caused the cart popup window to be given a min-width of 1000px, resulting in a broken layout with unnecessary horizontal scrolling. This patch adds a class to the cart template and to other pop-up window templates to ensure that a large min-width is not enforced and to give consistent padding to those pages. To test, set your theme to 'CCSR' and view the following pop-up pages: - The Cart. From the cart, trigger: - The "send" window - The "download" window - From a view of a List's contents trigger: - The "send" window" - The "download" window Each of these pages should look correct with no horizontal scrolling. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> All tests pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Template and CSS changes only, but no string changes. Save for inclusion in 3.12. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 11:12:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 09:12:25 +0000 Subject: [Koha-bugs] [Bug 10196] items table partially hidden in marc view in ccsr In-Reply-To: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10196-70-JCmKcmehBG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10196 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 11:12:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 09:12:26 +0000 Subject: [Koha-bugs] [Bug 10196] items table partially hidden in marc view in ccsr In-Reply-To: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10196-70-wK3G99DS2E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10196 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18084|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18089&action=edit [PASSED QA] Bug 10196 - items table partially hidden in marc view in ccsr In the CCSR theme's OPAC MARC view the table of items is truncated because the container div is styled with "overflow:hidden." I think the complete display of information is more important than not seeing a horizontal scrollbar, so this patch removes the style. To test, apply the patch and clear your browser cache. View a MARC detail page for a title which has holdings and confirm that the entire table can be seen. Test other pages to make sure no unwanted layout changes have resulted. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> all tests pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Simple CSS change, no string changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 11:17:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 09:17:36 +0000 Subject: [Koha-bugs] [Bug 10134] set XSLT usage ON as default, for new Koha installs In-Reply-To: <bug-10134-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10134-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10134-70-buZpOkTIM5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10134 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18040|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18090&action=edit [PASSED QA] Bug 10134 - set XSLT usage ON as default, for new Koha installs Currently, new installs are created with XSLT display set to "off", but XSLT seems to be the preferred way to display records, so having the default be "on" instead seems to make sense. This patch will of course only affect new installs. To test: - Apply the patch - Run through the webinstaller on an empty database - Log in to the staff client and search for "xslt" in system preferences - Verify that XSLTDetailsDisplay, XSLTResultsDisplay, OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay are all set to "default" Signed-off-by: Owen Leonard <oleonard at myacpl.org> Passes test plan correctly. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Changes syspref.sql for new installations to use XSLT views by default. No changes to existing installations, no string changes. Passes all tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 11:17:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 09:17:35 +0000 Subject: [Koha-bugs] [Bug 10134] set XSLT usage ON as default, for new Koha installs In-Reply-To: <bug-10134-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10134-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10134-70-gHpEpS1lsw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10134 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 11:23:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 09:23:58 +0000 Subject: [Koha-bugs] [Bug 9679] can't place hold from cart in CCSR In-Reply-To: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9679-70-IRRCE06Lxq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9679 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 11:23:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 09:23:59 +0000 Subject: [Koha-bugs] [Bug 9679] can't place hold from cart in CCSR In-Reply-To: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9679-70-4JFRVdFhbA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9679 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18069|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18091&action=edit [PASSED QA] Bug 9679 - can't place hold from cart in CCSR When the CCSR theme is enabled, selecting items in the cart and clicking "place hold" triggers a JavaScript error and fails. This patch adds a function missing from the CCSR version of basket.js. To test, apply the patch and clear your browser cache. - Enable the CCSR theme and put items into the OPAC cart. - Open the cart, select one or more items, and click "place hold." The cart should automatically close and the main window should redirect to the holds screen showing your selections. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> All test passed http://bugs.koha-community.org/show_bug.cgi?id=9769 Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Confirmed patch fixes the problem described. All tests and QA script pass, JavaScript only change. No strings involved, save for inclusion in 3.12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 11:43:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 09:43:02 +0000 Subject: [Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu In-Reply-To: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10225-70-AgjoXOmBXL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 11:43:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 09:43:04 +0000 Subject: [Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu In-Reply-To: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10225-70-nFKn9YBrEr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18076|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18092&action=edit [PASSED QA] Bug 10225 - If an item isn't editable, don't show the onclick Edit/Delete menu The user should not be shown edit/delete links when clicking on a row in additems which they cannot edit because of the IndependantBranches setting. This patch adds a class to the row to exclude such rows in the JavaScript onclick handler. To test: - Turn IndependantBranches on and edit items for a title which has holdings from various branches including your own. - Click a row for an item which is held by your library. You should see the "Edit/Delete" links appear. - Click a row for an item which is held by another library. No links should appear. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> All test pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> All tests and QA script pass. Changes to the templates include no string changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 11:46:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 09:46:25 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10080-70-VhKlk43gfc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|master |3.14 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I second Chris' vote to hold this patch for 3.14 to not risk missing something, marking bug accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 11:53:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 09:53:52 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10080-70-LI8VWpR2WU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Kyle, your patch contains the po files, but changes to those files should be handled via Pootle. Can you please resubmit your patch without them? I am also not sure if old release notes should be included, as they are 'history'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 12:08:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 10:08:53 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7441-70-mAalLKMBDg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 --- Comment #42 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Kyle, I had to rebase the first patch, because of a conflict in updatedatabase and found 1 problem: Third patch contains those lines: +[% USE Koha %] +[% USE KohaBranchName %] But fourth patch deletes the Koha TT plugin without removing them. I think as a result of that the QA script notes a problem with opac-results.tt: * koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt FAIL forbidden patterns OK tt_valid OK valid_template FAIL Koha: plugin not found Please fix and switch back to signed off if the only changes are the rebase and fixing the plugin problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 12:09:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 10:09:04 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7441-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7441-70-qtASK6lSLZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 12:30:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 10:30:55 +0000 Subject: [Koha-bugs] [Bug 10054] When SingleBranchMode is enabled, allow superlibrarians to set logged in library In-Reply-To: <bug-10054-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10054-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10054-70-kw23AZ1dY0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18049|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18093&action=edit [PASSED QA] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library Currently, when SingleBranchMode is enabled, nobody can change the logged in library in Koha. To change it requires disable SingleBranchMode, switching the library, and re-enabling it. It seems reasonable to allow superlibrarians to switch the logged in library even if SingleBranchMode is enabled. Test Plan: 1) Apply this patch 3) Enable SingleBranchMode 4) Log in as a superlibrarian 5) Attempt to change the logged in branch This change should succeed 6) Log in as a non-superlibrarian account 7) Attempt to change the logged n branch This should not be allowed, as per Koha's current behavior Signed-off-by: Owen Leonard <oleonard at myacpl.org> I guess this doesn't do any harm even though the practical motivations behind it, as described in the bug, seem otherwise solvable. If SingleBranchMode is supposed to prevent librarians from switching their logged in library why can they choose their library when they first log in? Was SingleBranchMode supposed to only affect the OPAC originally? Or should the login form be modified? This seems to be a band-aid on a poorly-implemented feature. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Patch works as decribed. As this only adds a check for a superlibrarian it seems safe and should not interfere with normal staff accounts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 12:30:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 10:30:53 +0000 Subject: [Koha-bugs] [Bug 10054] When SingleBranchMode is enabled, allow superlibrarians to set logged in library In-Reply-To: <bug-10054-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10054-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10054-70-VRqj5BCxLs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 12:32:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 10:32:17 +0000 Subject: [Koha-bugs] [Bug 10054] When SingleBranchMode is enabled, allow superlibrarians to set logged in library In-Reply-To: <bug-10054-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10054-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10054-70-X1uJwfVJfC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off Patch complexity|Small patch |Trivial patch --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I will open another bug for some inconsistency I found testing this: You can now switch the library once you are logged in, but while the library pull down also shows on the login page, the selection there is not saved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 12:35:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 10:35:24 +0000 Subject: [Koha-bugs] [Bug 10231] New: When logging in with database user library selection is not saved Message-ID: <bug-10231-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10231 Bug ID: 10231 Summary: When logging in with database user library selection is not saved Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de CC: gmcharlt at gmail.com To test: 1) Log into Koha with your database user, make sure you select a specific library from the pull down on the login page 2) Verify you are logged in correctly, but the top menu shows NO LIBRARY SET. We should either not show the pull down or make it work correctly. See also behaviour after applying patch 10054. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 12:36:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 10:36:20 +0000 Subject: [Koha-bugs] [Bug 10231] When logging in with database user library selection is not saved In-Reply-To: <bug-10231-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10231-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10231-70-JNgkX4vaRA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10231 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Note: This was tested with activated SingleBranchMode. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 12:40:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 10:40:28 +0000 Subject: [Koha-bugs] [Bug 10054] When SingleBranchMode is enabled, allow superlibrarians to set logged in library In-Reply-To: <bug-10054-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10054-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10054-70-gE8jVBD2xd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 12:53:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 10:53:39 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9533-70-WgQhtCaJeJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, I think maybe having this off by default would be safer? I wonder if the field is not empty, will the default overwrite what you have in there? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 12:53:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 10:53:50 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9533-70-SzWbng6BlC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 13:44:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 11:44:06 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9533-70-wdL2vrA8Aa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Testing this I was surprised to find the option on the upload page instead of on the page where I actually define the modifications. I tend to check all checkboxes and settings I made twice before I do a change like this, with the options being spread over 2 pages, I can't do that. I think the option should go on the second step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 13:47:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 11:47:48 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9533-70-X4wgTzG8iS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thinking more about this, a possible enhancement would be to make visible which fields will be set to which default value. There is no way to tell now which changes will be done or not done when you check/uncheck the checkbox. I know that this is more complicated so it should go on a new bug as an enhancement request once have figured this out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 14:01:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 12:01:54 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9533-70-32WaVf6Epz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Ok, I think I need to take a break, because after some more testing I understand better. Ignore last 2 comments, I will try again: 1) Having the feature off by default might be better in my opinion, because it reduces the risk of unintended changes. 2) I can see that the default values for text fields show up in the form, which is good as it makes visible which changes will happen. But there is a bug here: If you use a default itemtype, the pull down will not be preselected. This seems to happen for all values with pull downs. 3) I'd still like to see the checkbox on the second page instead of the first, but it might not be as big as a problem as I initially thought. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 14:05:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 12:05:35 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9533-70-ZFCqUidmV9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 14:05:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 12:05:37 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9533-70-idzfbW3I9j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17879|0 |1 is obsolete| | Attachment #17940|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18094&action=edit [PASSED QA] Bug 9533 - batch item modification should ignore defaults This patch makes the pre-population of the fields for the batch item editor with the default values from the default framework optional and off by default. Test Plan: 1) Apply patch 2) Add default values for cost and replacement cost to the default framework. 3) Browse to Tools / Batch item modification 4) Choose a file, or entire some barcodes in the text area 5) Ensure that the 'Populate fields with default values from default framework' is *not* checked 6) Click 'Continue' 7) Observe that the fields for cost and replacement cost are blank 8) Click the 'back' button on your browser 9) Check the checkbox to enable the default value 10) Click 'Continue' 11) Observe that the fields for cost and replacement cost now contain the default values you assigned them in the default MARC framework Signed-off-by: David Cook <dcook at prosentient.com.au> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Switch works correctly, all tests and QA script pass. Note: there is a bug with default values for all non text input fields. Default values won't be applied for those fields as the pull downs are not preselected correctly with the default values defined in the framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 14:06:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 12:06:49 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9533-70-cX89PvNQ5n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18095&action=edit [PASSED QA] Bug 9533: Use default values by default Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Simple template change checking the checkbox by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 14:07:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 12:07:52 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9533-70-K8DUWH8u4D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18095|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 18095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18095 [PASSED QA] Bug 9533: Use default values by default Obsoleting second patch, but also passing QA on it. The change is alright if we want the checkbox to be checked by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 15:46:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 13:46:33 +0000 Subject: [Koha-bugs] [Bug 10217] Make sure direct links to detail views work when there is no session In-Reply-To: <bug-10217-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10217-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10217-70-Ypqt9RMrOb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10217 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 15:54:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 13:54:36 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: <bug-10201-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10201-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10201-70-Xi7TK2fff4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 15:58:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 13:58:49 +0000 Subject: [Koha-bugs] [Bug 9679] can't place hold from cart in CCSR In-Reply-To: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9679-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9679-70-oLWrvuxgXs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9679 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 16:03:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 14:03:32 +0000 Subject: [Koha-bugs] [Bug 10196] items table partially hidden in marc view in ccsr In-Reply-To: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10196-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10196-70-K6O2EAZQkD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10196 --- Comment #4 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This is a 3.10.x-only change, as this problem does not exist on 3.12 or 3.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 16:05:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 14:05:58 +0000 Subject: [Koha-bugs] [Bug 10134] set XSLT usage ON as default, for new Koha installs In-Reply-To: <bug-10134-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10134-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10134-70-yH9S1Tq1tS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10134 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 16:09:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 14:09:55 +0000 Subject: [Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu In-Reply-To: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10225-70-9xGop3a1Dv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 16:11:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 14:11:16 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: <bug-10052-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10052-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10052-70-5zUCoWXisP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Marcel, I am trying to figure out how this works and entered a http://... into my intranetstylesheet preference. I can see that it works for the staff pages, but the help files (http://localhost:8080/cgi-bin/koha/help.pl) still refer to staff-global.css. Can you take a look please? All 3 patches were applied and the databaes update left my http:// URL alone. <title>Online Help -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 16:12:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 14:12:02 +0000 Subject: [Koha-bugs] [Bug 10054] When SingleBranchMode is enabled, allow superlibrarians to set logged in library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10054 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 16:15:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 14:15:04 +0000 Subject: [Koha-bugs] [Bug 9680] cart aligned right in CCSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9680 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 16:16:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 14:16:30 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 16:26:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 14:26:47 +0000 Subject: [Koha-bugs] [Bug 10232] New: Permission check for editing help files is broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 Bug ID: 10232 Summary: Permission check for editing help files is broken Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de CC: dpavlin at rot13.org To test: - Try editing a help file as superlibrarian, confirm you get to the editor. You might not be able to save your changes though, because of file permissions. - Try editing a help file with any of the listed permissions from the edithelp.pl file: 43 my ( $template, $loggedinuser, $cookie ) = get_template_and_user( 44 { 45 template_name => "help/edithelp.tt", 46 query => $input, 47 type => "intranet", 48 authnotrequired => 0, 49 flagsrequired => { 50 catalogue => 1, 51 circulate => 1, 52 parameters => 1, 53 borrowers => 1, 54 permissions => 1, 55 reserveforothers => 1, 56 borrow => 1, 57 reserveforself => 1, 58 editcatalogue => 1, 59 updatecharges => 1, 60 }, 61 debug => 1, 62 } 63 ); Verify it doesn't work. I think reserveforself doesn't exist in current Koha and the choice of permissions seems a bit arbitrary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 16:31:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 14:31:11 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #34 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 16:48:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 14:48:19 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #35 from Jared Camins-Esakov --- I suspect this is going to break unit tests on jenkins, in which case I will be reverting it. This line: + isa_ok( ref @listorders, 'ARRAY','GetOrdersByBiblionumber : result is an array' ); seems problematic. Perhaps you want to check that $#listorders > 1, Mathieu? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 17:48:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 15:48:15 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 17:48:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 15:48:18 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16539|0 |1 is obsolete| | Attachment #16540|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 18096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18096&action=edit Bug 8840 - [SIGNED-OFF] ubuntu-pkg-check.sh fix and extend functionality First, reworked it into a newer script with parameters: ubuntu-packages.sh -r This will generate output identical to the old script, except that it is fixed for non-english setups. ubuntu-packages.sh -h This adds a brief help, which all scripts should have. ubuntu-packages.sh -ic This helps handle a multi-arch problem by printing out a relevant command for installing missing dependencies. Signed-off-by: Jared Camins-Esakov Signed-off-by: Magnus Enger Works as advertised, see Bugzilla for details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 17:48:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 15:48:31 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 --- Comment #19 from Katrin Fischer --- Created attachment 18097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18097&action=edit [PASSED QA] Bug 8840 - [SIGNED-OFF] Patch to solve false "All dependencies installed!" Reordered logic to accumulate MISSING_PATCHES variable and tweak condition to be certain it was not failing. Signed-off-by: Magnus Enger Works as advertised, see Bugzilla for details. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 18:46:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 16:46:12 +0000 Subject: [Koha-bugs] [Bug 10079] HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18046|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 18098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18098&action=edit [PASSED QA] Bug 10079 - HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled Test Plan: 1) Enable IndependantBranches 2) Set HomeOrHoldingBranch to holding branch 3) Delete an item whose holding branch is your logged in branch, and whose home branch is not 4) Apply this patch 5) Repeat step 3, it should fail 6) Try to delete another items whose home branch is your logged in branch, and whose holding branch is a different branch. This deletetion should succeed. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer All tests and QA script pass. Change is logical, only homebranch should determine if the item can be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 18:46:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 16:46:11 +0000 Subject: [Koha-bugs] [Bug 10079] HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 18:56:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 16:56:17 +0000 Subject: [Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.12 |3.14 --- Comment #8 from Katrin Fischer --- This influences quite a lot of system preferences - maybe this is better included in 3.14/3.12.1 with a bit more testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 19:03:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 17:03:43 +0000 Subject: [Koha-bugs] [Bug 10116] Subscription history notes should be TEXT not VARCHAR(150) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10116 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Jared Camins-Esakov --- *** This bug has been marked as a duplicate of bug 10215 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 19:03:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 17:03:43 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins at cpbibliography.com --- Comment #4 from Jared Camins-Esakov --- *** Bug 10116 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 19:46:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 17:46:46 +0000 Subject: [Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 19:46:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 17:46:48 +0000 Subject: [Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17932|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 18099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18099&action=edit [PASSED QA] Bug 10129: Babeltheque does not depend on COinSinOPACResults This patch groups all loops on the new_results array into one. It is useless to loop on the same results array several times. Test plan: Quite hard to test all cases. This patch deals with 5 sysprefs: COinSinOPACResults, Babeltheque, TagsEnabled, TagsShowOnList and OpacStarRatings. Try to enable/disable all of them and verify there is no difference with and without this patch. The only different will be: The Babeltheque information should be displayed even if the COinSinOPACResults syspref is disabled. Signed-off-by: Owen Leonard This revised patch works fine for me, thanks. Signed-off-by: Katrin Fischer Verified following system preferences still work as expected: - COinSinOPACResults on/off - TagsEnabled, TagsShowOnList, TagsInputOnList on/off - OpacStarRatings Couldn't test Babeltheque functionality as this requires an account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 20:06:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 18:06:42 +0000 Subject: [Koha-bugs] [Bug 9575] Serious Holds Problem with IndependantBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Kyle, I am sorry, but this doesn't work for me. I created 3 different holds with 3 different pickup libraries away from my logged in library. I turned on independentbranches and like you described, suddenly all holds showed my current branch as pickup library. But after applying the patch and refreshing the page several times, this is still the case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 20:44:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 18:44:17 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 --- Comment #53 from Katrin Fischer --- Comment on attachment 18041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18041 [SIGNED-OFF] Bug 6739 - expired patrons not blocked from opac actions Review of attachment 18041: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6739&attachment=18041) ----------------------------------------------------------------- Hi Chris H. and Kyle, I have taken a look at those patches and found some problems, the most severe is in the database update (see splinter review comments below). Please fix and resubmit. And a little note for a possible enhancement: The new option doesn't show up on the patron categories summary table in administration. ::: installer/data/mysql/kohastructure.sql @@ +441,4 @@ > `reservefee` decimal(28,6) default NULL, -- cost to place holds > `hidelostitems` tinyint(1) NOT NULL default '0', -- are lost items shown to this category (1 for yes, 0 for no) > `category_type` varchar(1) NOT NULL default 'A', -- type of Koha patron (Adult, Child, Professional, Organizational, Statistical, Staff) > + `BlockExpiredPatronOpacActions` tinyint(1) NOT NULL default '-1', -- wheither or not a patron of this categori can renew books or place holds once their card has expired. 0 means they can, 1 means they cannot, -1 means use syspref BLockExpiredPAtronOpacACtions Tiny typo: categori ::: installer/data/mysql/updatedatabase.pl @@ +6845,5 @@ > + NULL, > + 'YesNo' > + ) > + "); > + $dbh->do("ALTER TABLE `categories` ADD COLUMN `BlockExpiredPatronOpacActions` TINYINT(1) DEFAULT 0 NOT NULL"); The default value for new patron categories is -1 (use system preference), but for existing installations we create the column with default 0. I checked that the follow ups are not fixing this. Failing QA. Also: It would be a bit safer to make sure the column is added after category_type like in kohastructure.sql. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 20:44:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 18:44:34 +0000 Subject: [Koha-bugs] [Bug 6739] expired patrons not blocked from opac actions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6739 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 21:14:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 19:14:45 +0000 Subject: [Koha-bugs] [Bug 9452] C4::Letters does not function under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 --- Comment #4 from Jared Camins-Esakov --- Created attachment 18100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18100&action=edit Bug 9452: C4::Letters not Plack-compatible Prior to this patch, at more-or-less random intervals pages working with notices will cease to function. To test: 1) Apply patch. 2) Try to edit some notices. 3) Trigger some notices. 4) If you were able to edit the notices and trigger the notices, sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 21:14:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 19:14:59 +0000 Subject: [Koha-bugs] [Bug 9452] C4::Letters does not function under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 21:15:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 19:15:41 +0000 Subject: [Koha-bugs] [Bug 9452] C4::Letters does not function under Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 --- Comment #5 from Jared Camins-Esakov --- I do not have any technique for consistently reproducing these errors. 75% of the time notices are not generated and/or I am unable to save changes to notices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 22:26:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 20:26:34 +0000 Subject: [Koha-bugs] [Bug 10230] Match points do not work with authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 --- Comment #1 from Jared Camins-Esakov --- Created attachment 18101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18101&action=edit Bug 10230: no need to use SimpleSearch for matching auths When introducing QueryParser, I introduced a check for QueryParser at too high a level, causing authority matching to try and use SimpleSearch for authorities prematurely, when SearchAuthorities should be handling it. This patch corrects the level of the check. This patch only moves three lines, but thanks to the change in if level, it adjusts the indentation quite a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 22:26:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 20:26:46 +0000 Subject: [Koha-bugs] [Bug 10230] Match points do not work with authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 --- Comment #2 from Jared Camins-Esakov --- Created attachment 18102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18102&action=edit Bug 10230: Don't limit valid matches to bibs The patch for bug 9523 added a JOIN to the biblio table when identifying the best match so that if a matched record had been deleted it would not hold up the import process. Unfortunately, this broke all authority matching, since of course authorities don't appear in the biblio table. This patch adds a join to auth_header as well, and decides which to check based on the record type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 22:27:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 20:27:00 +0000 Subject: [Koha-bugs] [Bug 10230] Match points do not work with authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 22:27:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 20:27:02 +0000 Subject: [Koha-bugs] [Bug 10230] Match points do not work with authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 --- Comment #3 from Jared Camins-Esakov --- Created attachment 18103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18103&action=edit Bug 10230: show correct matching record The correct matching record was not always shown on the manage staged MARC page. This patch corrects the issue and provides the template with the appropriate ID for the matched record regardless what type of record it is. To test: 1) Create a matching record for authorities. For MARC21, the following is a good choice: Matching rule code: AUTHPER Description: Personal name main entry Match threshold: 999 Record type: Authority record [Match point 1:] Search index: mainmainentry Score: 1000 Tag: 100 Subfields: a 2) Create a record that has the appropriate fields for being matched with that rule (if you don't already have one). 3) Save the authority record as MARC (Unicode/UTF-8). 4) Stage the file choosing your new matching rule. 5) Note that with these patches, you get a link to the existing authority and without them you could get any number of strange things. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 23:40:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 21:40:40 +0000 Subject: [Koha-bugs] [Bug 10094] koha-list should have an --disabled option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10094 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 23:51:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 21:51:21 +0000 Subject: [Koha-bugs] [Bug 10100] OPAC News dates need an CSS handle (class) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 12 23:51:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 21:51:22 +0000 Subject: [Koha-bugs] [Bug 10100] OPAC News dates need an CSS handle (class) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17731|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 18104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18104&action=edit [PASSED QA] Bug 10100: adds a class to OPAC news dates Adds a "newsfooter" class to allow CSS modification of the date appearing as a footer on each news. Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Adds a class, checked po files to make sure change is string safe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 00:00:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 22:00:15 +0000 Subject: [Koha-bugs] [Bug 10094] koha-list should have an --disabled option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10094 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Katrin Fischer --- Packaging manager has signed off - that's good enough for me :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 00:54:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 22:54:30 +0000 Subject: [Koha-bugs] [Bug 10159] koha-rebuild-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10159 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17846|0 |1 is obsolete| | --- Comment #2 from Robin Sheat --- Created attachment 18105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18105&action=edit Bug 10159 - koha-rebuild-zebra error handling This patch makes koha-rebuild-zebra: - Check for the existence of the instance - Handle arbitrary amount of instance parameters - Capture -a and -b (which made the script rebuild twice the chosen DB). It adds the extended version (--authorities and --biblios respectively) of the option switch. This makes the -a and -b switches work as "only do authorities" (or viceversa). They can be used concurrently, which is the default behaviour when no switch is provided. - Handle -v (and --verbose) as koha-rebuild-zebra options, to ease the use for non-techie users. - The rebuild_zebra.pl is wrapped inside an IF to return error values if we ever make rebuild_zebra.pl return error codes (this is pointed in the code). - Added -h/--help switches and an 'usage' output :-D Please provide patches for any wording issues, or contact me to fix it. To test: - Apply the patch and create your packages (or just use the script from your branch) - Run it in this scenarios / options - -h/--help to see the available option switches - Mix them with one or more instances, of which some could be fake - try -a/--authorities and -b/--biblios in all possible combinations - try -v/--verbose works Regards To+ Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 00:55:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 22:55:55 +0000 Subject: [Koha-bugs] [Bug 10157] koha-email-enable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10157 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17842|0 |1 is obsolete| | --- Comment #2 from Robin Sheat --- Created attachment 18106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18106&action=edit Bug 10157 - koha-email-enable error handling koha-email-enable now - Checks the instance exists. - Checks if email is already enabled. Regards To+ Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 00:56:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 22:56:16 +0000 Subject: [Koha-bugs] [Bug 10146] koha-stop-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10146 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17843|0 |1 is obsolete| | --- Comment #5 from Robin Sheat --- Created attachment 18107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18107&action=edit Bug 10146 - koha-stop-zebra error handling koha-stop-zebra now - Checks the instance exists. - Checks the instance is enabled. - Checks if the zebra daemon is already running. Regards To+ Edit: Corrected the die message Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 00:56:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 22:56:30 +0000 Subject: [Koha-bugs] [Bug 10159] koha-rebuild-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10159 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 00:56:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 22:56:34 +0000 Subject: [Koha-bugs] [Bug 10157] koha-email-enable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10157 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 00:56:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 22:56:38 +0000 Subject: [Koha-bugs] [Bug 10146] koha-stop-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10146 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 00:56:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 22:56:43 +0000 Subject: [Koha-bugs] [Bug 10159] koha-rebuild-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10159 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 00:56:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 22:56:49 +0000 Subject: [Koha-bugs] [Bug 10157] koha-email-enable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10157 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 00:56:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 12 May 2013 22:56:53 +0000 Subject: [Koha-bugs] [Bug 10146] koha-stop-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10146 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 02:29:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 00:29:50 +0000 Subject: [Koha-bugs] [Bug 10231] When logging in with database user library selection is not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10231 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #2 from Liz Rea --- I kind of disagree with this - I think that one cannot expect this to work when logging in as the DB user - maybe all we need to do is add a notice to the yellow box that the superuser has NO LIBRARY SET no matter what. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 02:36:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 00:36:48 +0000 Subject: [Koha-bugs] [Bug 10233] New: Toolbar background missing from staff client catalogue page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Bug ID: 10233 Summary: Toolbar background missing from staff client catalogue page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: dcook at prosentient.com.au Currently, the toolbar containing the buttons "New Record" and "Z39.50 search" is missing a background. Before we moved from YUI to Bootstrap, there was an extra div#toolbar wrapping the button group, but that appears to have vanished (and with it the background). We might be able to just change the current id from "newmenuc" to "toolbar", since the javascript that touched "newmenuc" seems to have been removed from the page as well (since it cleared the newmenuc div so that the plain html could be replaced with yui buttons). However, I'm loathe to do that without making sure that no existing functionality would break from doing that. It might be an idea to just wrap that div with a div#toolbar again to get that background back. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 02:46:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 00:46:40 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #36 from Jared Camins-Esakov --- I would prefer not to revert this if I could get a follow-up fixing the broken test, which is a problem only in the unit test and not in the code itself. If someone can provide a follow-up fixing the unit test by May 16, I will not revert these patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 02:55:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 00:55:35 +0000 Subject: [Koha-bugs] [Bug 10100] OPAC News dates need an CSS handle (class) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10100 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 02:59:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 00:59:55 +0000 Subject: [Koha-bugs] [Bug 10234] New: MySQL error when adding entry to z39.50servers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10234 Bug ID: 10234 Summary: MySQL error when adding entry to z39.50servers Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au Recently, someone reported getting an error when trying to add an entry into z39.50servers (http://irc.koha-community.org/koha/2013-05-09#i_1250075). Here is a snippet of their log: log: "z3950servers.pl: DBD::mysql::st execute failed: Field 'description' doesn't have a default value at /usr/share/koha/intranet/cg?i-bin/admin/z3950servers.pl line 133" I believe the problem is the result of using a strict SQL mode: Strict mode controls how MySQL handles input values that are invalid or missing. A value can be invalid for several reasons. For example, it might have the wrong data type for the column, or it might be out of range. A value is missing when a new row to be inserted does not contain a value for a non-NULL column that has no explicit DEFAULT clause in its definition. (For a NULL column, NULL is inserted if the value is missing.) (http://dev.mysql.com/doc/refman/5.5/en/server-sql-mode.html [You can check different versions, they all seem to have the same behaviour from what I can tell.]) * In this case, the field 'description' has no default value but is also NOT NULL field. If your SQL mode isn't strict, you'll get a warning but the insert will succeed (using a blank value rather than a null value). However, it if it strict, you'll get an error and a rolled back/failed insert. * If we observe other fields in kohastructure.sql that are NOT NULL and don't have a "real" default value, we typically use a default of ''. This will stop the warnings and the errors. Admittedly, the field "description" is documented as not being used, so perhaps the best thing to do is remove the field or perhaps make it NULL, but...using a default of '', will be the least potentially hazardous as it won't really change anything. It'll just enforce what we know as a default behaviour of using '' when the default value is missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 03:06:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 01:06:54 +0000 Subject: [Koha-bugs] [Bug 10079] HomeOrHoldingBranch should not control who can delete when IndependantBranches is enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10079 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 03:16:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 01:16:07 +0000 Subject: [Koha-bugs] [Bug 8840] ubuntu-pkg-check.sh fix and extend functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8840 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 04:44:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 02:44:51 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 --- Comment #7 from David Cook --- Created attachment 18108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18108&action=edit Bug 10096 [DB Follow-up] - Add a Z39.50 interface for authority searching This patch adds the "recordtype" column to the "z3950servers" table. The value in this column (biblio or authority) then controls whether the z3950 server shows up in a bibliographic search (through the Acq and Cataloguing modules) or in an authority search (through the Authorities module). I also edited the z3950 management console to show this value and allow users to edit it. The default value is "biblio", since the vast majority of z3950 targets will be bibliographic. However, there is an option to add/edit a z3950 target as a source of authority records. Test Plan: 1) Apply both patches 2) Run updatedatabase.pl (after setting your KOHA_CONF and PERL5 environmental variables) 3) Use the test plan from the 1st patch N.B. Make sure that your Z39.50 client target has a Record Type of Authority, otherwise it won't display when you're doing a Z3950 search for authorities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 07:54:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 05:54:08 +0000 Subject: [Koha-bugs] [Bug 10235] New: Koha's syspref search fails to find 'local' sysprefs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10235 Bug ID: 10235 Summary: Koha's syspref search fails to find 'local' sysprefs Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com CC: gmcharlt at gmail.com if you add a new syspref to Koha, then attempt to search for it - the 'syspref search' feature fails to find it :/ this ticket will attempt to fix this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 09:16:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 07:16:05 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17918|0 |1 is obsolete| | Attachment #17919|0 |1 is obsolete| | Attachment #17920|0 |1 is obsolete| | --- Comment #14 from M. de Rooy --- Created attachment 18109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18109&action=edit Bug 10052: Db revision for intranetstylesheet Report 10052 makes the intranetstylesheet prefs behave like the opac ones. This patch contains an optional db revision: If the pref intranetstylesheet is not blank, and does not start with http, https or /, then prefix it with a slash to make it an absolute path. Test plan: Before applying this patch: 1) Put intranet-tmpl/prog/en/css/staff-global.css into intranetstylesheet. This works in the current staff client, but will be interpreted as relative as soon as both patches for this report have been applied. Apply the patch. And run: /cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Check the webinstaller warning and the pref value. There should be a slash in front now. The css should still work. Continue after applying this patch with: 2) Clear the intranetstylesheet pref. Run updatestructure again. No message: OK 3) Put /intranet-tmpl/prog/en/css/staff-global.css in intranetstylesheet. Run updatestructure again. No message: OK 4) Prefix intranetstylesheet with http://[your-server-here]. Test again. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 09:16:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 07:16:09 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 --- Comment #15 from M. de Rooy --- Created attachment 18110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18110&action=edit Bug 10052: Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts Allow a relative path (within theme/css) in intranetstylesheet too. Allow a full path, local or remote with http(s), in intranetcolorstylesheet. This restores consistency between opac and staff. Test plan: First: the patch with the db revision should have been applied. And also the updatestructure step from the web installer should have been run. Clear intranetstylesheet. Check included stylesheet with page source in browser. Enter a full path with http or / in intranetstylesheet. Check again. Enter a relative path (such as staff-global.css). Check again. Clear intranetcolorstylesheet. Check if there is no reference with page source. Enter a full path with http or / in intranetcolorstylesheet. Check reference. Enter a relative path (such as blue.css). Check again. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 09:16:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 07:16:12 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 --- Comment #16 from M. de Rooy --- Created attachment 18111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18111&action=edit Bug 10052 Followup for edithelp.tt and help-top.inc A grep on the stylesheet names revealed that similar code was used in those template files. This patch moves the code from doc-head-close.inc to a new include file. Now, doc-head-close and the help templates refer to that one file. Test plan: If you tested the preceding two patches, now you only need to: 1) Check included css via page source in browser from staff main page. 2) Check it also from some other location. 3) Check again from Help: e.g. /cgi-bin/koha/help.pl 4) Check again from Edit Help: /cgi-bin/koha/edithelp.pl Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 09:16:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 07:16:15 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 --- Comment #17 from M. de Rooy --- Created attachment 18112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18112&action=edit Bug 10052: QA Followup As Katrin pointed out, the intranetstylesheet setting was not respected in the help pages. The script help.pl does not use get_template_and_user which sets these variables via Auth.pm but calls gettemplate. This makes it necessary to 'manually' set them. This patch does that. Evidently, this could be the case for some other templates vars too.. Test plan: Apply all patches for 10052. Change intranetstylesheet. Check a help page. Change intranetcolorstylesheet. Check a help page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 09:21:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 07:21:20 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #18 from M. de Rooy --- (In reply to comment #13) > I am trying to figure out how this works and entered a http://... into my > intranetstylesheet preference. I can see that it works for the staff pages, > but the help files (http://localhost:8080/cgi-bin/koha/help.pl) still refer > to staff-global.css. Can you take a look please? All 3 patches were applied > and the databaes update left my http:// URL alone. Good testing, Katrin! Gr?ndlich :) Thanks. You found something that must have been there for some time already.. The template var was not filled because it is not loaded via get_template_and_user but just gettemplate. Added a QA followup to fill them now. Resolved merge conflict on updatedb. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 09:21:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 07:21:34 +0000 Subject: [Koha-bugs] [Bug 10175] Software error in opac-detail.pl when CGISESSID cookie is not set In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10175 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Julian Maurice --- This is totally related to bug 10217. In fact, it's a duplicate. Good catch Katrin ;) *** This bug has been marked as a duplicate of bug 10217 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 09:21:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 07:21:34 +0000 Subject: [Koha-bugs] [Bug 10217] Make sure direct links to detail views work when there is no session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10217 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #5 from Julian Maurice --- *** Bug 10175 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 09:25:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 07:25:54 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #19 from mathieu saby --- In my opinion, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 09:39:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 07:39:47 +0000 Subject: [Koha-bugs] [Bug 10199] Move fields type, options and explanation from systempreferences table? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10199 --- Comment #2 from M. de Rooy --- (In reply to comment #1) > I am not sure what we would win by dividing local use preferences and normal > preferences. Both need a table for the value set to be saved, so 2 tables > seem more error prone to me than having one with a few columns unused? Hi Katrin, I agree. If(..) we should move the unused columns, we should leave what we do use in systempreferences. So no completely separate table for local use prefs. Maybe a joined table for options and explanation to remove redundancy? But then we still face this problem: You have local use pref A. Then it becomes a real pref so now its description comes from yaml. But we still have an old description in the joined table.. > I am sorry, but I don't understand the point about deleting the pref from > your description. Could you give an example where this is a problem? This is only a fictive problem. If you would delete a regular pref (remove it from the preferences file), but somehow not delete if from the table (the dbrev did not work out?). In this case you got a local use pref falling back to the old columns. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 09:40:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 07:40:18 +0000 Subject: [Koha-bugs] [Bug 10145] The acquisition details block is badly placed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5343 --- Comment #8 from Jonathan Druart --- (In reply to comment #7) > Doesn't apply to 3.10.x please rebase if it is needed Not needed for 3.10.x In fact, it depends on bug 5343, not 5335. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 09:40:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 07:40:18 +0000 Subject: [Koha-bugs] [Bug 5343] Subscription cost (Link serial and acqui modules) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5343 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10145 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 10:00:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 08:00:17 +0000 Subject: [Koha-bugs] [Bug 7883] save and continue editing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 10:01:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 08:01:05 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #20 from mathieu saby --- Sorry, Firefox is playing with me this morning... So, in my opinion, the goal of Lyon 3 patch is good - showing only useful information in basket lists - , but I am not sure to like the way it is working. The patch changes the default behavior GetBasketsInfosByBookseller function in Acquisition.pm. Would not it be better to maintain its default behavior, and to add an option if we want to filter the results ? (and in that case, the documentation of the function needs to be changed too). Maybe we could also imagine a way for this function to not get by default baskets with documents only linked with non active budgets ? But I think I would prefer keeping the function unchanged, and only hide received baskets in the templates. It will make possible the creation of a link "See also received basket" that would unhide received baskets. And I agree with Pierre : we must have a way to show all baskets if we want. In templates, we could have checkboxes or option buttons to see received/pending/closed/open baskets, according to the whish of the librarians. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 11:24:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 09:24:44 +0000 Subject: [Koha-bugs] [Bug 9456] Add callnumber column to the cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9456 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #58 from Jonathan Druart --- Kyle, Your first patch introduces some css. Since you don't use a table element, I think it is useless. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 11:28:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 09:28:38 +0000 Subject: [Koha-bugs] [Bug 10217] Make sure direct links to detail views work when there is no session In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10217 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Not needed for 3.10.x or below -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 11:29:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 09:29:50 +0000 Subject: [Koha-bugs] [Bug 10201] Old OPAC patron update system should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10201 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Not needed for 3.10.x and below -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 11:56:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 09:56:16 +0000 Subject: [Koha-bugs] [Bug 8277] item form not always showing when ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8277 --- Comment #12 from Jonathan Druart --- I checked out 3.10.3 commit db3cf8e62017e40533164edb0ab91cabf69f1f3b Refs: [v3.10.03], HEAD Author: Chris Cormack AuthorDate: Mon Feb 25 06:36:04 2013 +1300 Commit: Chris Cormack CommitDate: Mon Feb 25 06:36:04 2013 +1300 and I cannot reproduce the issue. Did you check the logs? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 12:03:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 10:03:58 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #37 from Jonathan Druart --- Created attachment 18113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18113&action=edit Bug 7593: Fix Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 12:06:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 10:06:13 +0000 Subject: [Koha-bugs] [Bug 9679] can't place hold from cart in CCSR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9679 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.10.x will be in 3.10.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 12:24:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 10:24:15 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #38 from mathieu saby --- Hello Thank you Jonathan for the fix. Are you sure of the "41" instead of "42" ? (I did not check) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 13:25:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 11:25:13 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #39 from mathieu saby --- In fact I wanted to check if the result is an array, and not something else (hash or scalar). Can you tell me why this line is wrong? isa_ok( ref @listorders, 'ARRAY','GetOrdersByBiblionumber : result is an array' ); I don't know the meaning of "$#listorders ". what is it supposed to check? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 13:52:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 11:52:55 +0000 Subject: [Koha-bugs] [Bug 9259] batch delete marc batches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9259 Karam Qubsi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karamqubsi at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 13:59:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 11:59:49 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #40 from Jonathan Druart --- (In reply to comment #38) > Hello > Thank you Jonathan for the fix. > Are you sure of the "41" instead of "42" ? (I did not check) % prove t/db_dependent/Acquisition.t t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 0 wallclock secs ( 0.02 usr 0.00 sys + 0.40 cusr 0.02 csys = 0.44 CPU) Result: PASS (In reply to comment #39) > In fact I wanted to check if the result is an array, and not something else > (hash or scalar). > Can you tell me why this line is wrong? > isa_ok( ref @listorders, 'ARRAY','GetOrdersByBiblionumber : result is an > array' ); The parameter should be a reference (http://perldoc.perl.org/functions/ref.html). Else the value is always an empty string. > I don't know the meaning of "$#listorders ". what is it supposed to check? $#array returns the max index of the array @array. So in fact the test I proposed is false. I will provide another patch (we just want to check if the returned value is defined). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 14:01:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 12:01:02 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18113|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart --- Created attachment 18114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18114&action=edit Bug 7593: Fix unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 14:29:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 12:29:39 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #42 from mathieu saby --- If you think this test is not very useful, you can supress the line. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 14:35:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 12:35:53 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #43 from Kyle M Hall --- Katrin, I split off the plugin to a separate bug and added it as a dependency on this bug. I'll still take are of the rebasing though. Kyle (In reply to comment #42) > Hi Kyle, > > I had to rebase the first patch, because of a conflict in updatedatabase and > found 1 problem: > > Third patch contains those lines: > +[% USE Koha %] > +[% USE KohaBranchName %] > But fourth patch deletes the Koha TT plugin without removing them. > > I think as a result of that the QA script notes a problem with > opac-results.tt: > > * koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt > FAIL > forbidden patterns OK > tt_valid OK > valid_template FAIL > Koha: plugin not found > > Please fix and switch back to signed off if the only changes are the rebase > and fixing the plugin problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 14:43:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 12:43:36 +0000 Subject: [Koha-bugs] [Bug 9575] Serious Holds Problem with IndependantBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575 --- Comment #12 from Owen Leonard --- (In reply to comment #11) > But after applying the patch and > refreshing the page several times, this is still the case. After you applied the patch did you start with a new set of three holds with different pickup locations? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 16:00:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 14:00:24 +0000 Subject: [Koha-bugs] [Bug 10233] Toolbar background missing from staff client catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 --- Comment #1 from Owen Leonard --- Created attachment 18115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18115&action=edit Bug 10233 - Toolbar background missing from staff client catalogue page The toolbar on the cataloging home page lacks the standard toolbar id, resulting in an inconsistent appearance. This patch adds the correct id. To test, apply the patch, clear your browser cache, and view the cataloging home page (cataloguing/addbooks.pl). The toolbar should look like other toolbars in Koha (for instance, members/members-home.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 16:00:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 14:00:22 +0000 Subject: [Koha-bugs] [Bug 10233] Toolbar background missing from staff client catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 16:01:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 14:01:55 +0000 Subject: [Koha-bugs] [Bug 10196] items table partially hidden in marc view in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10196 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master --- Comment #5 from Jared Camins-Esakov --- With Owen's help I was able to reproduce this problem on master. Resetting version, and pushing shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 16:02:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 14:02:59 +0000 Subject: [Koha-bugs] [Bug 10196] items table partially hidden in marc view in ccsr In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10196 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 16:24:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 14:24:44 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 --- Comment #24 from Jonathan Druart --- Kyle, shouldn't we unset the withdrawn date if an item is restored? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 16:42:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 14:42:32 +0000 Subject: [Koha-bugs] [Bug 10236] New: software error greek authorities Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10236 Bug ID: 10236 Summary: software error greek authorities Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.8 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolyn.somers at biblibre.com When displaying at OPAC an authority containing several languages forms, we get a software error : Template process failed: file error - language: not found at /home/fsomers/workspace/versions/community_38/C4/Templates.pm line 127. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 16:42:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 14:42:57 +0000 Subject: [Koha-bugs] [Bug 10229] branch transfer limits showing one tab at bottom In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10229 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Version|3.10 |master Resolution|--- |WONTFIX --- Comment #1 from Owen Leonard --- > The final tab across the top always shows at the bottom of > the screen before the save button. Not the final tab, the tab which refers to a collection code which contains a space. From the manual: "Authorized value is limited to 80 characters and cannot have spaces or special characters other than underscores and hyphens in it." I'm going to mark this bug "WONTFIX" but open a new one asking that we add some validation to the authorized value edit process to catch that kind of problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 16:45:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 14:45:07 +0000 Subject: [Koha-bugs] [Bug 9217] Extending character limit in Authorized Values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9217 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard --- *** This bug has been marked as a duplicate of bug 8757 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 16:45:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 14:45:07 +0000 Subject: [Koha-bugs] [Bug 8757] Longer size text for authorized values description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8757 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maria.okonska at brooklaw.edu --- Comment #5 from Owen Leonard --- *** Bug 9217 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 16:49:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 14:49:06 +0000 Subject: [Koha-bugs] [Bug 10237] New: Enforce authorized value character limitations Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10237 Bug ID: 10237 Summary: Enforce authorized value character limitations Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/admin/authorised_values.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org CC: gmcharlt at gmail.com According to the manual, "Authorized value is limited to 80 characters and cannot have spaces or special characters other than underscores and hyphens in it." We know that breaking this rule causes problems with searching and bugs like Bug 10229. We should enforce this rule on the client and server side to prevent the user from entering invalid data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 17:10:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 15:10:23 +0000 Subject: [Koha-bugs] [Bug 10236] software error greek authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10236 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 18116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18116&action=edit [3.8.x] proposed patch Proposed patch for 3.8, bug does not exist > 3.10 (see bug 8870) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 17:12:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 15:12:41 +0000 Subject: [Koha-bugs] [Bug 10236] software error greek authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10236 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8870 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 17:12:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 15:12:41 +0000 Subject: [Koha-bugs] [Bug 8870] UNIMARC authorities search doesn't display properly information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8870 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10236 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 18:36:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 16:36:06 +0000 Subject: [Koha-bugs] [Bug 10237] Enforce authorized value character limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10237 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 18:36:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 16:36:08 +0000 Subject: [Koha-bugs] [Bug 10237] Enforce authorized value character limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10237 --- Comment #1 from Owen Leonard --- Created attachment 18117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18117&action=edit Bug 10237 - Enforce authorized value character limitations An authorized value should not have spaces or special characters other than underscores and hyphens in it, but this limitation is not enforced. This patch adds client-side validation blocking entries which contain anything other than numbers, letters, underscores, or dashes. Changes include: - The addition of a custom alphanumeric validation scheme which can be used anywhere in Koha. - The addition of a new translatable warning message which appears when the alphanumeric validation scheme is violated. - The addition of rules to the authorized_values.tt template to enable the new alphanumeric validation scheme. To test, apply the patch and clear your browser cache. With an existing category of authorized values (like ccode): - Click to add new authorized value - Try to enter invalid data in the "authorized value" form field. You should see a warning. - Try to submit a form with the invalid data. You should be prevented from doing to. - Correct the invalid data to conform to the validation rules. Warnings should disappear. - Submit the form. It should submit correctly. With a new category: - Click to create a new category. - Try to enter invalid data in the "category" and "authorized value" form fields. You should see warnings. - Try to submit a form with the invalid data. You should be prevented from doing to. - Correct the invalid data to conform to the validation rules. Warnings should disappear. - Submit the form. It should submit correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 19:36:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 17:36:08 +0000 Subject: [Koha-bugs] [Bug 5992] Biblibre various improvements for 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5992 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Paul Poulain --- I think we can close this one, there's no need to keep it open. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 20:24:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 18:24:45 +0000 Subject: [Koha-bugs] [Bug 10221] hold expiration doesn't show on patron's list of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 20:28:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 18:28:36 +0000 Subject: [Koha-bugs] [Bug 10221] hold expiration doesn't show on patron's list of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 20:33:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 18:33:40 +0000 Subject: [Koha-bugs] [Bug 10221] hold expiration doesn't show on patron's list of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 20:33:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 18:33:41 +0000 Subject: [Koha-bugs] [Bug 10221] hold expiration doesn't show on patron's list of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221 --- Comment #1 from Owen Leonard --- Created attachment 18118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18118&action=edit Bug 10221 - hold expiration doesn't show on patron's list of holds When viewing the list of a patron's holds on the circulation page or the patron detail page the table of holds doesn't display the holds expiration date, if present. This patch adds display of the hold expiration date. To test, place a hold for a patron and set an expiration date for it. View the patron's existing holds on both circulation.pl and moremember.pl. The expiration date you chose should appear in the table of information about existing holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 20:33:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 18:33:48 +0000 Subject: [Koha-bugs] [Bug 10238] New: allow notes on transfer Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10238 Bug ID: 10238 Summary: allow notes on transfer Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice to have a notes field on the circulation transfer page to explain to the library you're transferring to why you're transferring materials. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 20:36:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 18:36:57 +0000 Subject: [Koha-bugs] [Bug 10192] Add {ISBN13} as new parameter to OPACSearchForTitleIn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10192 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |MARC Bibliographic data | |support Assignee|oleonard at myacpl.org |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 20:46:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 18:46:47 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master Summary|label 'online access' with |In OPAC XSLT search |id for css |results, add class to | |'online access' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 21:08:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 19:08:24 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 21:15:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 19:15:43 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #1 from Owen Leonard --- Created attachment 18119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18119&action=edit Bug 10218 - In OPAC XSLT search results, add class to 'online access' In some cases in OPAC search results and the detail page there is a class specific to each line of data being output (publisher, date, subjects, etc). In other cases there is no additional class. This patch makes modifications to a few different OPAC files in an attempt to make them consistent with each other. To test, apply the patch and view: - an OPAC detail page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay on Labels should have classes relevant to their data. To test the specific case requested by this bug, view details/results for a record which includes online resources (856u in MARC21). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 21:15:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 19:15:42 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 21:21:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 19:21:44 +0000 Subject: [Koha-bugs] [Bug 10193] Copies should be holdings as label for items on MARC view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 21:28:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 19:28:21 +0000 Subject: [Koha-bugs] [Bug 10221] hold expiration doesn't show on patron's list of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18118|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 18120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18120&action=edit [SIGNED-OFF] Bug 10221 - hold expiration doesn't show on patron's list of holds When viewing the list of a patron's holds on the circulation page or the patron detail page the table of holds doesn't display the holds expiration date, if present. This patch adds display of the hold expiration date. To test, place a hold for a patron and set an expiration date for it. View the patron's existing holds on both circulation.pl and moremember.pl. The expiration date you chose should appear in the table of information about existing holds. Signed-off-by: Nicole C. Engard works great -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 21:28:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 19:28:33 +0000 Subject: [Koha-bugs] [Bug 10221] hold expiration doesn't show on patron's list of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10221 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 21:28:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 19:28:53 +0000 Subject: [Koha-bugs] [Bug 10193] Copies should be holdings as label for items on MARC view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10193 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 13 21:28:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 19:28:55 +0000 Subject: [Koha-bugs] [Bug 10193] Copies should be holdings as label for items on MARC view In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10193 --- Comment #1 from Owen Leonard --- Created attachment 18121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18121&action=edit Bug 10193 - Copies should be holdings as label for items on MARC view In the OPAC MARC view, the table of holdings is labeled 'copies.' In order to be consistent with the normal view this should be labeled 'holdings.' This patch makes this correction. To test, apply the patch and view the MARC detail page for any record with items. The table of holdings data at the bottom of the page should be labeled 'Holdings.' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 01:18:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 23:18:26 +0000 Subject: [Koha-bugs] [Bug 10239] New: add dates to course reserves Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10239 Bug ID: 10239 Summary: add dates to course reserves Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 8215 It would be nice to be able to set a start and end date for a reserves list so that Koha can automatically remove things from reserve on a specific date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 01:18:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 23:18:26 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10239 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 01:26:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 23:26:34 +0000 Subject: [Koha-bugs] [Bug 10240] New: Offline circulation using HTML5 and IndexedDB Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Bug ID: 10240 Summary: Offline circulation using HTML5 and IndexedDB Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: jcamins at cpbibliography.com Reporter: jcamins at cpbibliography.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Modern web standards make it possible to make a stripped down version of Koha's circulation module function even when offline, and to seamlessly switch to offline functionality if the server or connection goes out. We should take advantage of this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 01:49:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 13 May 2013 23:49:32 +0000 Subject: [Koha-bugs] [Bug 10241] New: Easy analyticals creates two 773 fields. Search/link from host to children is broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Bug ID: 10241 Summary: Easy analyticals creates two 773 fields. Search/link from host to children is broken Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P4 Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: eb at efdss.org UseControlNumber preference is set to "Don't use" and the EasyAnalyticalRecords preference is set to 'Display.' I created a record, and then selected New child record and created an analytic. Then, following the instructions in the manual Chapter 5 http://es.koha-community.org/manual/3.10/en/cataloging.html#cataloganalytics I linked the analytic to the host item. This resulted in two 773 fields. The first (created when adding a new child record contains: w Host Record control number 005037189 d Place, publisher, and date of publication Milwaukee : Hal Leonard, [2002?] z International Standard Book Number 0634038788 t Title Selections from O brother, where art thou? : The second 773, created when I linked the child to the parent contains the above, plus 0 Host Biblionumber 19017 9 Host Itemnumber 20551 The search for analytics is driven by the host item number, which is not included in the 773 that is created with a new child record. So you must link the child to the parent. But why create an additional 773? It looks messy. Second part possibly not related at all to the above: When I go to the host item in the staff interface and click on Analytics it says Used in 4 analytics ('4 analytics' is a link: http://kohaadmin-test.efdss.org/cgi-bin/koha/catalogue/search.pl?idx=hi&q=20551 If I click on the link: No results found. No results match your search for 'hi,wrdl: 20551' in VWML Test Catalog. But if I put the host item number 20551 into the search field, it returns the children and the parent record. Something about the search from analytics is not functioning correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 02:19:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 00:19:40 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 --- Comment #26 from Bernardo Gonzalez Kriegel --- Also another side effect is that load time increases: with this patch ~36 sec without ~9 sec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 06:47:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 04:47:49 +0000 Subject: [Koha-bugs] [Bug 10233] Toolbar background missing from staff client catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18115|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 18122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18122&action=edit [SIGNED-OFF] Bug 10233 - Toolbar background missing from staff client catalogue page The toolbar on the cataloging home page lacks the standard toolbar id, resulting in an inconsistent appearance. This patch adds the correct id. To test, apply the patch, clear your browser cache, and view the cataloging home page (cataloguing/addbooks.pl). The toolbar should look like other toolbars in Koha (for instance, members/members-home.pl). Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 06:48:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 04:48:06 +0000 Subject: [Koha-bugs] [Bug 10233] Toolbar background missing from staff client catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |nengard at gmail.com Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 07:51:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 05:51:06 +0000 Subject: [Koha-bugs] [Bug 10237] Enforce authorized value character limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10237 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Should we also discourage the use dashes? Dashes in collection and location can cause problems with your search not being as exact as you expected it to be (being interpretated as multiple words by zebra). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:08:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:08:07 +0000 Subject: [Koha-bugs] [Bug 9575] Serious Holds Problem with IndependantBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575 --- Comment #13 from Katrin Fischer --- Hi Kyle and Owen, I skipped 5) - modifying the holds, because the pull downs were wrong and it seemed obvious that modifying would ruing the pickup location. But now I have problems reproducing the original problem with the wrong pull downs, I will try to investigate more later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:12:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:12:24 +0000 Subject: [Koha-bugs] [Bug 9575] Serious Holds Problem with IndependantBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575 --- Comment #14 from Katrin Fischer --- Ok, I think I have resolved it - the problem occurs not if your user is a superlibrarian. It does occur, when you don't have superlibrarian permissions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:17:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:17:15 +0000 Subject: [Koha-bugs] [Bug 9575] Serious Holds Problem with IndependantBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:17:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:17:17 +0000 Subject: [Koha-bugs] [Bug 9575] Serious Holds Problem with IndependantBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18048|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Created attachment 18123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18123&action=edit [PASSED QA] Bug 9575 - Serious Holds Problem with IndependantBranches If IndependantBranches is enabled, all holds for an item display the currently logged in library no matter what, and modifying the holds will set all pickup locations for all the holds to that logged in library! Test plan: 1) Disable IndependantBranches 2) Place 3 holds on a record with 3 different pickup locations 3) Enable IndependantBranches 4) Refresh the holds page for that record, all the holds show now show a pickup location of the logged in branch 5) Modify the order of the holds 6) Disable IndependantBranches 7) Refresh the holds, verify the holds all now have a pickup location of the logged in branch 8) Apply the patch 9) Repeat steps 1-3 10) Refresh the holds page for that record, all the holds should now show the correct pickup branch, but it cannot be changed as IndependantBranches is enabled. Signed-off-by: Kyle M Hall Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer In my tests the above test plan only worked out if my user had no superlibrarian permission. But then behaviour for independentbranches off/on was all correct. All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:29:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:29:30 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:29:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:29:33 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18109|0 |1 is obsolete| | Attachment #18110|0 |1 is obsolete| | Attachment #18111|0 |1 is obsolete| | Attachment #18112|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer --- Created attachment 18124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18124&action=edit [PASSED QA] Bug 10052: Db revision for intranetstylesheet Report 10052 makes the intranetstylesheet prefs behave like the opac ones. This patch contains an optional db revision: If the pref intranetstylesheet is not blank, and does not start with http, https or /, then prefix it with a slash to make it an absolute path. Test plan: Before applying this patch: 1) Put intranet-tmpl/prog/en/css/staff-global.css into intranetstylesheet. This works in the current staff client, but will be interpreted as relative as soon as both patches for this report have been applied. Apply the patch. And run: /cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Check the webinstaller warning and the pref value. There should be a slash in front now. The css should still work. Continue after applying this patch with: 2) Clear the intranetstylesheet pref. Run updatestructure again. No message: OK 3) Put /intranet-tmpl/prog/en/css/staff-global.css in intranetstylesheet. Run updatestructure again. No message: OK 4) Prefix intranetstylesheet with http://[your-server-here]. Test again. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Comments on last patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:29:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:29:44 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 --- Comment #20 from Katrin Fischer --- Created attachment 18125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18125&action=edit [PASSED QA] Bug 10052: Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts Allow a relative path (within theme/css) in intranetstylesheet too. Allow a full path, local or remote with http(s), in intranetcolorstylesheet. This restores consistency between opac and staff. Test plan: First: the patch with the db revision should have been applied. And also the updatestructure step from the web installer should have been run. Clear intranetstylesheet. Check included stylesheet with page source in browser. Enter a full path with http or / in intranetstylesheet. Check again. Enter a relative path (such as staff-global.css). Check again. Clear intranetcolorstylesheet. Check if there is no reference with page source. Enter a full path with http or / in intranetcolorstylesheet. Check reference. Enter a relative path (such as blue.css). Check again. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:29:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:29:50 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 --- Comment #21 from Katrin Fischer --- Created attachment 18126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18126&action=edit [PASSED QA] Bug 10052 Followup for edithelp.tt and help-top.inc A grep on the stylesheet names revealed that similar code was used in those template files. This patch moves the code from doc-head-close.inc to a new include file. Now, doc-head-close and the help templates refer to that one file. Test plan: If you tested the preceding two patches, now you only need to: 1) Check included css via page source in browser from staff main page. 2) Check it also from some other location. 3) Check again from Help: e.g. /cgi-bin/koha/help.pl 4) Check again from Edit Help: /cgi-bin/koha/edithelp.pl Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Template only, no string changes. Tested according to test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:29:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:29:57 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 --- Comment #22 from Katrin Fischer --- Created attachment 18127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18127&action=edit [PASSED QA] Bug 10052: QA Followup As Katrin pointed out, the intranetstylesheet setting was not respected in the help pages. The script help.pl does not use get_template_and_user which sets these variables via Auth.pm but calls gettemplate. This makes it necessary to 'manually' set them. This patch does that. Evidently, this could be the case for some other templates vars too.. Test plan: Apply all patches for 10052. Change intranetstylesheet. Check a help page. Change intranetcolorstylesheet. Check a help page. Signed-off-by: Katrin Fischer Looks all good to me now. Passes tests and still no string changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:32:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:32:18 +0000 Subject: [Koha-bugs] [Bug 10233] Toolbar background missing from staff client catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Small patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:32:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:32:20 +0000 Subject: [Koha-bugs] [Bug 10233] Toolbar background missing from staff client catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18122|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 18128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18128&action=edit [PASSED QA] Bug 10233 - Toolbar background missing from staff client catalogue page The toolbar on the cataloging home page lacks the standard toolbar id, resulting in an inconsistent appearance. This patch adds the correct id. To test, apply the patch, clear your browser cache, and view the cataloging home page (cataloguing/addbooks.pl). The toolbar should look like other toolbars in Koha (for instance, members/members-home.pl). Signed-off-by: Nicole C. Engard Signed-off-by: Katrin Fischer Template change only, no string changed involved. Works as described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:36:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:36:26 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 --- Comment #15 from Katrin Fischer --- Kyle, could you please fix the merge conflict? SIP is hard to test and I am still not familiar with it. Therefore I would like to call for a second sign off on this and given it passes the tests and QA script then it can pass QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:36:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:36:42 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:42:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:42:14 +0000 Subject: [Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer --- Hi Kyle, could you perhaps provide a little follow up for the tabulation characters? * C4/SIP/Sip/MsgType.pm FAIL pod OK forbidden patterns FAIL The patch introduces a forbidden pattern: tabulation character (869) The patch introduces a forbidden pattern: tabulation character (793) The patch introduces a forbidden pattern: tabulation character (781) valid OK critic OK Apart from this all tests and the QA script pass. SIP is hard to test and I am still not familiar with it. Therefore I would like to call for a second sign off on this and then it can pass QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 08:45:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 06:45:43 +0000 Subject: [Koha-bugs] [Bug 10231] When logging in with database user library selection is not saved In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10231 --- Comment #3 from Katrin Fischer --- I am not sure about this either, it just feels to me like unexpected behaviour. If I choose to select a library manually from the pull down, I would expect it to work, not depending on my login. Of course it never can work when you leave it to 'my library'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 10:28:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 08:28:40 +0000 Subject: [Koha-bugs] [Bug 7228] can't order more than 1 when importing all from staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #19 from Christophe Croullebois --- Created attachment 18129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18129&action=edit patch rebased for 3.10.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 10:33:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 08:33:13 +0000 Subject: [Koha-bugs] [Bug 7228] can't order more than 1 when importing all from staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #20 from Christophe Croullebois --- Created attachment 18130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18130&action=edit patch rebased for 3.8.x Hi Chris, I have made two patches for 3.8 and 3.10. I have added a line in the comment to distinguish each one thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 10:34:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 08:34:21 +0000 Subject: [Koha-bugs] [Bug 7228] can't order more than 1 when importing all from staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 --- Comment #21 from Chris Cormack --- Thanks, will test and push them now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 10:44:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 08:44:16 +0000 Subject: [Koha-bugs] [Bug 7228] can't order more than 1 when importing all from staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #22 from Chris Cormack --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 11:18:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 09:18:53 +0000 Subject: [Koha-bugs] [Bug 9923] correction of a bug due to bz 7129 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 --- Comment #5 from Christophe Croullebois --- Created attachment 18131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18131&action=edit patch rebased for 3.8.x Hi Chris, I have added a line in the comment. rebased for 3.8.x thx -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 11:46:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 09:46:46 +0000 Subject: [Koha-bugs] [Bug 10237] Enforce authorized value character limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10237 --- Comment #3 from Owen Leonard --- (In reply to comment #2) > Should we also discourage the use dashes? It's easy to modify the regex if that's the right thing to do. I was simply following what the manual recommended. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 11:58:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 09:58:05 +0000 Subject: [Koha-bugs] [Bug 9923] correction of a bug due to bz 7129 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9923 --- Comment #6 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.13 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 12:40:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 10:40:31 +0000 Subject: [Koha-bugs] [Bug 10214] malformed syspref.po file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10214 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #2 from Paul Poulain --- Le 07/05/2013 18:42, Bernardo Gonzalez Kriegel a ?crit :> > I use to download syspref.po, add the header and then upload to pootle. > We may check how is created/updated. > The .po files are generated by misc/translator/translate script. Digging a little, I've found that the culprit is probably in LangInstaller.pm, sub save_po { my $self = shift; # Write .po entries into a file put in Koha standard po directory Locale::PO->save_file_fromhash( $self->po_filename, $self->{po} ); say "Saved in file: ", $self->po_filename if $self->{verbose}; Other .po are generated by tmpl_process3.pl AFAIK (but i'm not a translation process specialist, I may be wrong) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 12:47:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 10:47:09 +0000 Subject: [Koha-bugs] [Bug 10214] malformed syspref.po file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10214 --- Comment #3 from Fr?d?ric Demians --- Can anyone post the missing header here as a comment? I will take a look at how to add it directly from the translation script. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 13:30:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 11:30:19 +0000 Subject: [Koha-bugs] [Bug 10214] malformed syspref.po file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10214 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |frederic at tamil.fr |ity.org | --- Comment #4 from Fr?d?ric Demians --- Created attachment 18132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18132&action=edit Proposed patch With this patch, header is created when creating a new syspref .po file for a new language (translate create), and is added if it doesn't already exist when updating an existing language (translate update). To test: (1) Create a new language syspref file: ./translate create -p xx-XX Check that there is an header (2) Update an existing syspref file without header: ./translate update fr-FR Check that fr-FR-pref.po has a header (3) Update an existing syspref file with header: Modify fr-FR-pref.po. Add an email, or whatever. ./translate update fr-FR Check that fr-FR-pref.po has a header with the manual modification -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 13:33:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 11:33:47 +0000 Subject: [Koha-bugs] [Bug 10214] malformed syspref.po file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10214 --- Comment #5 from Fr?d?ric Demians --- This patch applies on master and 3.12 branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 14:18:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 12:18:04 +0000 Subject: [Koha-bugs] [Bug 10233] Toolbar background missing from staff client catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10233 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 14:21:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 12:21:20 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 --- Comment #23 from Jared Camins-Esakov --- String changes on the patch "Bug 10052: Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts." Holding for 3.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 14:24:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 12:24:23 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 --- Comment #24 from Katrin Fischer --- Oh sorry, missed that :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 14:27:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 12:27:02 +0000 Subject: [Koha-bugs] [Bug 10214] malformed syspref.po file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10214 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18132|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel --- Created attachment 18133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18133&action=edit [SIGNED-OFF] Bug 10214 Add header to syspref po files With this patch, header is created when creating a new syspref .po file for a new language (translate create), and is added if it doesn't already exist when updating an existing language (translate update). To test: (1) Create a new language syspref file: ./translate create -p xx-XX Check that there is an header (2) Update an existing syspref file without header: ./translate update fr-FR Check that fr-FR-pref.po has a header (3) Update an existing syspref file with header: Modify fr-FR-pref.po. Add an email, or whatever. ./translate update fr-FR Check that fr-FR-pref.po has a header with the manual modification Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. No errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 14:28:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 12:28:03 +0000 Subject: [Koha-bugs] [Bug 10214] malformed syspref.po file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10214 Bernardo Gonzalez Kriegel changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 14:29:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 12:29:58 +0000 Subject: [Koha-bugs] [Bug 9575] Serious Holds Problem with IndependantBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9575 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 14:33:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 12:33:04 +0000 Subject: [Koha-bugs] [Bug 10108] can't print more than one page of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10108 --- Comment #6 from Owen Leonard --- (In reply to comment #5) > Should this work for reports run from the saved reports page? It works in my tests. Can you try again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 14:59:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 12:59:39 +0000 Subject: [Koha-bugs] [Bug 10108] can't print more than one page of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10108 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18082|0 |1 is obsolete| | --- Comment #7 from Nicole C. Engard --- Created attachment 18134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18134&action=edit [SIGNED-OFF] Bug 10108 - can't print more than one page of overdues Printing a report like overdues in Firefox results in a printout which cuts off in the middle. I traced the cause to something in the YUI grid system, although I'm not sure what specific definition is the cause. This patch adds a "screen" parameter to the @import which loads the YUI grid CSS file. This will disable YUI grid layouts in print views. The main disadvantage to this, as far as I can tell, is that it will "linearize" some layouts. For instance: the patron detail page (moremember.pl) which on screen is divided into two columns. I think this disadvantage is outweighed by the ability to make complete prints. To test, apply the patch and clear your cache. Try printing various reports from Firefox. Printouts should look correct and be complete. Signed-off-by: Nicole C. Engard all tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 14:59:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 12:59:51 +0000 Subject: [Koha-bugs] [Bug 10108] can't print more than one page of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10108 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 15:50:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 13:50:29 +0000 Subject: [Koha-bugs] [Bug 9866] OPAC advanced search error with Solr enabled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9866 --- Comment #3 from Hend --- I found that i need the following files so that i could use Advanced Searchbecause. I can't find them under /usr/share/koha/opac/htdocs/opac-tmpl/prog/en/modules/search/ & /usr/share/koha/opac/htdocs/opac-tmpl/prog/en/includes/ directories [1]advsearch.tt [2]intranet-bottom.inc [3]header.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 15:52:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 13:52:46 +0000 Subject: [Koha-bugs] [Bug 8803] modifying order quantity in neworderempty.pl has restrictions implemented in javascript that can be bypassed with the enter key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8803 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois at bibl | |ibre.com Depends on| |7228 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 15:52:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 13:52:46 +0000 Subject: [Koha-bugs] [Bug 7228] can't order more than 1 when importing all from staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7228 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8803 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 16:56:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 14:56:58 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 16:57:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 14:57:10 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 16:57:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 14:57:19 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 16:57:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 14:57:25 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 16:57:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 14:57:49 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17913|[PASSED QA] Bug 7593: Move |[ALREADY PUSHED][PASSED QA] description|orders on the destination |Bug 7593: Move orders on |record when merging 2 |the destination record when |records |merging 2 records -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 16:57:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 14:57:56 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17914|[PASSED QA] Bug 7593 : QA |[ALREADY PUSHED][PASSED QA] description|followup : restores deleted |Bug 7593 : QA followup : |line in C4::Acquisition |restores deleted line in | |C4::Acquisition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 18:43:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 16:43:34 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 --- Comment #44 from Nicole C. Engard --- This is still a big issue - are we in a state of discussion on this? do we need a new patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 19:32:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 17:32:33 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 --- Comment #45 from Chris Cormack --- (In reply to comment #44) > This is still a big issue - are we in a state of discussion on this? do we > need a new patch? Nope its in failed qa, it needs a follow fixing the things that make it fail qa. Most importantly 6a, and updating all the frameworks. Then a proposal of how to deal with the fact for lots of libraries that column was used for paidfor for a long and will contain that data. And a patch to deal with that cleanly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 19:46:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 17:46:40 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #43 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 21:12:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 19:12:18 +0000 Subject: [Koha-bugs] [Bug 6329] patron categories should show which fields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|enhancement |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 21:12:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 19:12:53 +0000 Subject: [Koha-bugs] [Bug 6329] patron categories should show which fields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 --- Comment #2 from Owen Leonard --- Created attachment 18135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18135&action=edit Bug 6329 - patron categories should show which fields are required When entering a new patron category, required fields are not indicated on the entry form. This patch adds the "required" class to the relevant labels. To test, add or edit a patron category. Confirm that the required fields (category code, category type, description, and enrollment period) are indicated as being required with a red label. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 21:12:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 19:12:51 +0000 Subject: [Koha-bugs] [Bug 6329] patron categories should show which fields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 21:15:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 19:15:23 +0000 Subject: [Koha-bugs] [Bug 10242] New: Small typo in marc21_field_008.xml: reorts vs. reports Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10242 Bug ID: 10242 Summary: Small typo in marc21_field_008.xml: reorts vs. reports Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 21:15:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 19:15:24 +0000 Subject: [Koha-bugs] [Bug 6359] number one printing on quick label page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6359 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- This appears to be fixed in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 21:16:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 19:16:08 +0000 Subject: [Koha-bugs] [Bug 10242] Small typo in marc21_field_008.xml: reorts vs. reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10242 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 18136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18136&action=edit Bug 10242 - Small typo in marc21_field_008.xml: reorts vs. reports Just that. Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 21:16:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 19:16:31 +0000 Subject: [Koha-bugs] [Bug 10242] Small typo in marc21_field_008.xml: reorts vs. reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10242 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 21:24:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 19:24:32 +0000 Subject: [Koha-bugs] [Bug 10242] Small typo in marc21_field_008.xml: reorts vs. reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10242 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Tom?s Cohen Arazi --- *** This bug has been marked as a duplicate of bug 10178 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 21:24:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 19:24:32 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- *** Bug 10242 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 21:53:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 19:53:58 +0000 Subject: [Koha-bugs] [Bug 10243] New: Holds queue is making transfer requests that contradict the branch holds policy Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243 Bug ID: 10243 Summary: Holds queue is making transfer requests that contradict the branch holds policy Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com CC: gmcharlt at gmail.com For some reason MapItemsToHoldRequests will, as a last ditch effort, grab what seems to be an arbitrary available item to fill a hold request, even if it will violate the circulation rules for holds. In other words, even if an item matches a "Holds policy by item type" that says "From home library", the a request to transfer that item to another library will be added to the holds queue! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 22:02:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 20:02:39 +0000 Subject: [Koha-bugs] [Bug 10243] Holds queue is making transfer requests that contradict the branch holds policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 22:02:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 20:02:40 +0000 Subject: [Koha-bugs] [Bug 10243] Holds queue is making transfer requests that contradict the branch holds policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243 --- Comment #1 from Kyle M Hall --- Created attachment 18137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18137&action=edit Bug 10243 - Holds queue is making transfer requests that contradict the branch holds policy For some reason MapItemsToHoldRequests will, as a last ditch effort, grab what seems to be an arbitrary available item to fill a hold request, even if it will violate the circulation rules for holds. In other words, even if an item matches a "Holds policy by item type" that says "From home library", a request to transfer that item to another library will be added to the holds queue! Test Plan: 1) Create a record with a an item at BranchA of item type BOOK 2) Set the holds policy such that itemtype BOOK for BranchA is set to "From home library" 3) Place a bib-level hold request for a patron with a pickup at BranchB 4) Run build_holds_queue.pl 5) You should now see a request for that item to be transfered to BranchB, even though the rules should not allow this. 6) Apply this patch 7) Run build_holds_queue.pl again 8) View the holds queue again, that request should no longer exist -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 22:05:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 20:05:36 +0000 Subject: [Koha-bugs] [Bug 10243] Holds queue is making transfer requests that contradict the branch holds policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243 --- Comment #2 from Kyle M Hall --- This patch is tested and working, but I wonder if we should simply delete lines 470-471 instead of using the code I wrote. I cannot understand the justification for what 470-471 do, and there are no comments about why it's there. I'll post an alterative that just deletes those lines, either one will resolve this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 22:09:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 20:09:38 +0000 Subject: [Koha-bugs] [Bug 10243] Holds queue is making transfer requests that contradict the branch holds policy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243 --- Comment #3 from Kyle M Hall --- Created attachment 18138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18138&action=edit Bug 10243 - Holds queue is making transfer requests that contradict the branch holds policy - Alternate solution For some reason MapItemsToHoldRequests will, as a last ditch effort, grab what seems to be an arbitrary available item to fill a hold request, even if it will violate the circulation rules for holds. In other words, even if an item matches a "Holds policy by item type" that says "From home library", a request to transfer that item to another library will be added to the holds queue! Test Plan: 1) Create a record with a an item at BranchA of item type BOOK 2) Set the holds policy such that itemtype BOOK for BranchA is set to "From home library" 3) Place a bib-level hold request for a patron with a pickup at BranchB 4) Run build_holds_queue.pl 5) You should now see a request for that item to be transfered to BranchB, even though the rules should not allow this. 6) Apply this patch 7) Run build_holds_queue.pl again 8) View the holds queue again, that request should no longer exist -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 22:43:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 20:43:50 +0000 Subject: [Koha-bugs] [Bug 10244] New: all money fields should have the tool tip like in fines Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10244 Bug ID: 10244 Summary: all money fields should have the tool tip like in fines Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com It would be nice if all money fields like the one when entering a budget (/cgi-bin/koha/admin/aqbudgetperiods.pl?op=add_form) had a tool tip to show not to use the currency character. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 22:50:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 20:50:47 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #21 from Kyle M Hall --- That looks good to me! > Kyle, is there anything else I need to touch to test this? > > No koha-qa errors :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 14 23:04:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 14 May 2013 21:04:54 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #43 from Fr?d?rick Capovilla --- Comment on attachment 17448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17448 Bug 7710 - multiple holds per title Review of attachment 17448: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=7710&attachment=17448) ----------------------------------------------------------------- Some lines in this patch are needed in bug 9394 so it can pass QA as a standalone patch. ::: koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt @@ +564,4 @@ > [% FOREACH reserveloo IN biblioloo.reserveloop %] > [% UNLESS ( loop.odd ) %][% ELSE %][% END %] > > + Needed in Bug 9394. @@ +584,4 @@ > > [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] > > + Needed in Bug 9394. @@ +588,4 @@ > Go up > > > + Needed in Bug 9394. @@ +592,4 @@ > Go top > > > + Needed in Bug 9394. @@ +596,4 @@ > Go bottom > > > + Needed in Bug 9394. @@ +676,4 @@ > > [% IF ( CAN_user_reserveforothers_modify_holds_priority ) %] > > + Needed in Bug 9394. @@ +687,4 @@ > [% END %] > > > + Needed in Bug 9394. @@ +695,4 @@ > [% IF SuspendHoldsIntranet %] > > [% UNLESS ( reserveloo.wait ) %] > + Needed in Bug 9394. @@ +699,3 @@ > > [% IF AutoResumeSuspendedHolds %] > + Needed in Bug 9394. @@ +699,4 @@ > > [% IF AutoResumeSuspendedHolds %] > + > + Needed in Bug 9394. @@ +699,5 @@ > > [% IF AutoResumeSuspendedHolds %] > + > + > + Clear Date Needed in Bug 9394. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 05:28:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 03:28:27 +0000 Subject: [Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 05:45:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 03:45:02 +0000 Subject: [Koha-bugs] [Bug 6329] patron categories should show which fields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18135|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard --- Created attachment 18139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18139&action=edit [SIGNED-OFF] Bug 6329 - patron categories should show which fields are required When entering a new patron category, required fields are not indicated on the entry form. This patch adds the "required" class to the relevant labels. To test, add or edit a patron category. Confirm that the required fields (category code, category type, description, and enrollment period) are indicated as being required with a red label. Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 05:45:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 03:45:16 +0000 Subject: [Koha-bugs] [Bug 6329] patron categories should show which fields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 06:33:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 04:33:40 +0000 Subject: [Koha-bugs] [Bug 10214] malformed syspref.po file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 07:22:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 05:22:30 +0000 Subject: [Koha-bugs] [Bug 10108] can't print more than one page of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10108 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 07:22:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 05:22:32 +0000 Subject: [Koha-bugs] [Bug 10108] can't print more than one page of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10108 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18134|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 18140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18140&action=edit [PASSED QA] Bug 10108 - can't print more than one page of overdues Printing a report like overdues in Firefox results in a printout which cuts off in the middle. I traced the cause to something in the YUI grid system, although I'm not sure what specific definition is the cause. This patch adds a "screen" parameter to the @import which loads the YUI grid CSS file. This will disable YUI grid layouts in print views. The main disadvantage to this, as far as I can tell, is that it will "linearize" some layouts. For instance: the patron detail page (moremember.pl) which on screen is divided into two columns. I think this disadvantage is outweighed by the ability to make complete prints. To test, apply the patch and clear your cache. Try printing various reports from Firefox. Printouts should look correct and be complete. Signed-off-by: Nicole C. Engard all tests pass Signed-off-by: Katrin Fischer CSS only change, no strings involved. Tested with a saved SQL report 'select * from borrowers'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 07:30:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 05:30:46 +0000 Subject: [Koha-bugs] [Bug 6329] patron categories should show which fields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 07:30:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 05:30:48 +0000 Subject: [Koha-bugs] [Bug 6329] patron categories should show which fields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18139|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 18141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18141&action=edit [PASSED QA] Bug 6329 - patron categories should show which fields are required When entering a new patron category, required fields are not indicated on the entry form. This patch adds the "required" class to the relevant labels. To test, add or edit a patron category. Confirm that the required fields (category code, category type, description, and enrollment period) are indicated as being required with a red label. Signed-off-by: Nicole C. Engard Signed-off-by: Katrin Fischer Works nicely. Template changes only, but no string changes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 07:41:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 05:41:40 +0000 Subject: [Koha-bugs] [Bug 10214] malformed syspref.po file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 07:41:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 05:41:42 +0000 Subject: [Koha-bugs] [Bug 10214] malformed syspref.po file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10214 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18133|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 18142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18142&action=edit [PASSED QA] Bug 10214 Add header to syspref po files With this patch, header is created when creating a new syspref .po file for a new language (translate create), and is added if it doesn't already exist when updating an existing language (translate update). To test: (1) Create a new language syspref file: ./translate create -p xx-XX Check that there is an header (2) Update an existing syspref file without header: ./translate update fr-FR Check that fr-FR-pref.po has a header (3) Update an existing syspref file with header: Modify fr-FR-pref.po. Add an email, or whatever. ./translate update fr-FR Check that fr-FR-pref.po has a header with the manual modification Signed-off-by: Bernardo Gonzalez Kriegel Comment: Work as described. No errors. Signed-off-by: Katrin Fischer All tests and QA script pass. Also tested that updated pref files can still be installed correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 08:30:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 06:30:00 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 08:30:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 06:30:04 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17886|0 |1 is obsolete| | Attachment #17887|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 18143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18143&action=edit [PASSED QA] Bug 10120 : Tidy up the code so we can see what is going on Signed-off-by: David Cook Signed-off-by: Katrin Fischer Amended test plan used for testing: Note: Use a new item for each test as we determine fines by item number. If you have the same item twice on the same day on the same account with the same due date, fine calculation is going to fail. 1/ Create an overdue item, that should get fines 2/ Return the item from the patron account checkout tab 3/ Check the borrowers record to see if the fine has been added/updated Repeat, but for 2/ return the item from the check in page Apply patch 1/ Make sure preference is set to do Repeat steps 1-3 from above 2/ Switch the preference to don't Repeat steps 1-2 3/ Check the fine hasn't been added/updated Again, check for returns from patron account and check in page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 08:30:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 06:30:18 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #10 from Katrin Fischer --- Created attachment 18144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18144&action=edit [PASSED QA] Bug 10120 : Adding a syspref to control if overdue charges are updated /on return On by default, To Test 1/ Create an overdue item, that should get fines 2/ Return the item 3/ Check the borrowers record to see if the fine has been added/updated Apply patch 1/ Make sure preference is set to do Repeat steps 1-3 above 2/ Switch the preference to don't Repeat stes 1-2 3/ Check the fine hasn't been added/updated Signed-off-by: David Cook Signed-off-by: Katrin Fischer All tests and QA script pass, works as described. I would categorize this a bug fix for libraries that don't want the new changed behaviour that was introduced by recalculating fines on return. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 08:30:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 06:30:26 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18143|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 18145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18145&action=edit [PASSED QA] Bug 10120 : Tidy up the code so we can see what is going on Signed-off-by: David Cook Signed-off-by: Katrin Fischer Amended test plan used for testing: Note: Use a new item for each test as we determine fines by item number. If you have the same item twice on the same day on the same account with the same due date, fine calculation is going to fail. 1/ Create an overdue item, that should get fines 2/ Return the item from the patron account checkout tab 3/ Check the borrowers record to see if the fine has been added/updated Repeat, but for 2/ return the item from the check in page Apply patch 1/ Make sure preference is set to do Repeat steps 1-3 from above 2/ Switch the preference to don't Repeat steps 1-2 3/ Check the fine hasn't been added/updated Again, check for returns from patron account and check in page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 08:40:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 06:40:07 +0000 Subject: [Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 --- Comment #6 from Katrin Fischer --- The problems I experienced were related to the fact that you should use 'new' items/due dates to make sure this works consistently. I am continuing the tests, but reading the code of the sub I couldn't help wondering - do we really want to count in Sundry fines? http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Overdues.pm;h=bc1c7a77dbfe451180f6d4262e0351152336b197;hb=1b877167f5231f7eef6c7f82cba9322bdba0dbac#l502 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 09:25:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 07:25:42 +0000 Subject: [Koha-bugs] [Bug 10245] New: OPAC items table CSS classes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Bug ID: 10245 Summary: OPAC items table CSS classes Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: chrish at catalyst.net.nz The table with the id 'holdingst' in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt lacks some classes which would help in styling and JS manipulation. Robin started in http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9736 Some classes were added in http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 I have added all the classes missing from 8597 that were in Robin's original work for 9736, I made one change which was to change 'vol_no' to 'vol_info' to be consistent with 8597. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 09:35:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 07:35:05 +0000 Subject: [Koha-bugs] [Bug 10245] OPAC items table CSS classes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |chrish at catalyst.net.nz --- Comment #1 from Chris Hall --- Created attachment 18146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18146&action=edit adding OPAC detail items table classes As master is significantly different to 3.10 in this area I will create a separate bug with the 3.10 equivalent of this patch. I also added in the id for barcode of 'item_barcode' as this was in 3.10 and seems to not be in 3.12, I will have to check why it was removed to see if this will cause an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 09:36:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 07:36:58 +0000 Subject: [Koha-bugs] [Bug 10246] New: OPAC items table CSS classes Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10246 Bug ID: 10246 Summary: OPAC items table CSS classes Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: chrish at catalyst.net.nz The table with the id 'holdingst' in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt lacks some classes which would help in styling and JS manipulation. This bug is equivalent to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 The 3.12 and 3.10 codebases are formatted differently in this area so I have created this bug for the 3.10 version of the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 09:39:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 07:39:12 +0000 Subject: [Koha-bugs] [Bug 10246] OPAC items table CSS classes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10246 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard at myacpl.org |chrish at catalyst.net.nz --- Comment #1 from Chris Hall --- Created attachment 18147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18147&action=edit adding OPAC detail items table classes 3.10 This patch is the 3.10 version of the patch attached to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 09:39:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 07:39:22 +0000 Subject: [Koha-bugs] [Bug 10245] OPAC items table CSS classes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 --- Comment #2 from Chris Hall --- 3.10 patch attached at http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10246 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 09:39:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 07:39:25 +0000 Subject: [Koha-bugs] [Bug 10246] OPAC items table CSS classes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10246 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 09:39:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 07:39:29 +0000 Subject: [Koha-bugs] [Bug 10245] OPAC items table CSS classes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10245 Chris Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 10:38:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 08:38:47 +0000 Subject: [Koha-bugs] [Bug 10247] New: Too many reserves due to syspref does not show warning Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Bug ID: 10247 Summary: Too many reserves due to syspref does not show warning Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On intranet, when placing a reserve : If borrower as reached the reserves quota, a warning should appear : Cannot place hold * Too Many Holds: TEST has too many holds. This works when quota defined in circulation rules is reached but not when quota specified in syspref maxreserves is reached, in case this quota is lower than the one defined is circulation rules. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 10:49:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 08:49:01 +0000 Subject: [Koha-bugs] [Bug 10237] Enforce authorized value character limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10237 --- Comment #4 from Katrin Fischer --- It took me a bit to find it, but Joy wrote something on the topic a while ago: http://bywatersolutions.com/2012/07/05/naming-conventions-in-koha/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 11:02:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 09:02:05 +0000 Subject: [Koha-bugs] [Bug 10237] Enforce authorized value character limitations In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10237 --- Comment #5 from Katrin Fischer --- Hm, thinking more about this - there are values where this won't work so nicely - one of them is MANUAL_INV. The code is the value that will be shown for your custom fee type and therefore enforcing upper case, no spaces and no umlauts would not be good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 11:19:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 09:19:39 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #21 from Katrin Fischer --- Hm I have done some research. The change discussed here was made when the result list for vendors was redone and GetBasketsInfosByBookseller was introduced (http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=d09e428a7dc9854c6f4e45f3caade3c8e141b79d): The old list of baskets was created using following condition: -where booksellerid = ? -AND ( aqorders.quantity > aqorders.quantityreceived OR quantityreceived IS NULL) -AND datecancellationprinted IS NULL The new sub uses: + WHERE booksellerid = ? The change proposed in the patch just restores the original condition: + WHERE booksellerid = ? AND ( aqorders.quantity > aqorders.quantityreceived OR quantityreceived IS NULL) + AND datecancellationprinted IS NULL I know that the patch was pushed a while ago, but since we are still using 3.6.x in some libraries, this means a major change for them. Is there a chance we can agree on a solution here? I am in favor of restoring the original behaviour for now and using the search to find other older baskets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 11:32:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 09:32:49 +0000 Subject: [Koha-bugs] [Bug 10248] New: No results found message when searching in Staff client Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10248 Bug ID: 10248 Summary: No results found message when searching in Staff client Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: hend.eleraky at bibalex.org CC: gmcharlt at gmail.com No results found message appears when searching in Staff client although i could search for the same item in OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 11:33:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 09:33:46 +0000 Subject: [Koha-bugs] [Bug 10248] No results found message when searching in Staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10248 Hend changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high --- Comment #1 from Hend --- Koha Version 3.10.03.000 Search Engine : Solr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 11:47:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 09:47:23 +0000 Subject: [Koha-bugs] [Bug 10248] No results found message when searching using Solr in Staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10248 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P5 - low Component|Staff Client |Searching Assignee|koha-bugs at lists.koha-commun |gmcharlt at gmail.com |ity.org | Summary|No results found message |No results found message |when searching in Staff |when searching using Solr |client |in Staff client OS|Linux |All -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 11:59:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 09:59:42 +0000 Subject: [Koha-bugs] [Bug 10249] New: Untranslatable strings in Javascript on OPAC detail page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Bug ID: 10249 Summary: Untranslatable strings in Javascript on OPAC detail page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Untranslatable strings are: 178 Your rating 343,354 Go to detail 328 Click to forward the list to 306 Click to rewind the list to Also some CSS is hardcoded, as a background color on line 347 if (highlIndex && i == index) li.css("backgroundColor", "#DDDDDD"); I think one possible solution would be to use variables in those places and then have something like var sth = _("Go to detail") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 12:00:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 10:00:25 +0000 Subject: [Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 18148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18148&action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 12:00:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 10:00:33 +0000 Subject: [Koha-bugs] [Bug 10247] Too many reserves due to syspref does not show warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10247 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 12:06:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 10:06:57 +0000 Subject: [Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 --- Comment #1 from Katrin Fischer --- Also 'by' in a few lines. Everything that builds HTML-Tags with Javascript is a bit suspicious. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 13:16:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 11:16:47 +0000 Subject: [Koha-bugs] [Bug 10108] can't print more than one page of overdues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10108 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 13:22:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 11:22:57 +0000 Subject: [Koha-bugs] [Bug 10214] malformed syspref.po file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10214 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 13:26:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 11:26:04 +0000 Subject: [Koha-bugs] [Bug 6329] patron categories should show which fields are required In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6329 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 14:50:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 12:50:03 +0000 Subject: [Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 14:50:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 12:50:05 +0000 Subject: [Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 --- Comment #1 from Owen Leonard --- Created attachment 18149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18149&action=edit Bug 6399 - tooltip for tags that says 'separate by comma' Some sites split tags on spaces, some on commas. Since Koha splits on a comma, we should make that clear to the patron. This patch adds additional text to the "New tag(s)" label. To test, enable TagsEnabled, TagsInputOnDetail, and TagsInputOnList. Click "Add tag" on both OPAC search results and an OPAC detail page. Confirm that the revised label appears correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 14:50:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 12:50:20 +0000 Subject: [Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 14:55:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 12:55:21 +0000 Subject: [Koha-bugs] [Bug 6564] access to account isn't easy to find on the masthead In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6564 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Owen Leonard --- I think the practice of putting user account links in the upper left of the screen is widespread enough (Facebook, Twitter, Gmail, Amazon) that this kind of change should be made via local customizations. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:09:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:09:25 +0000 Subject: [Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18149|0 |1 is obsolete| | --- Comment #2 from Nicole C. Engard --- Created attachment 18150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18150&action=edit [SIGNED-OFF] Bug 6399 - tooltip for tags that says 'separate by comma' Some sites split tags on spaces, some on commas. Since Koha splits on a comma, we should make that clear to the patron. This patch adds additional text to the "New tag(s)" label. To test, enable TagsEnabled, TagsInputOnDetail, and TagsInputOnList. Click "Add tag" on both OPAC search results and an OPAC detail page. Confirm that the revised label appears correctly. Signed-off-by: Nicole C. Engard all tests pass -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:09:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:09:39 +0000 Subject: [Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:31:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:31:39 +0000 Subject: [Koha-bugs] [Bug 10159] koha-rebuild-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10159 --- Comment #3 from Jared Camins-Esakov --- There is one (maybe) problem with this patch, but as it already exists as far as I can tell, I am going to push the patch as-is for 3.12.0: koha-rebuild-zebra does not check if an instance is disabled before reindexing. Arguably it should. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:34:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:34:55 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17901|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall --- Created attachment 18151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18151&action=edit Bug 7441 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. Signed-off-by: Bernardo Gonzalez Kriegel Rebased on current master (2013-01-31). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:35:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:35:32 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17902|0 |1 is obsolete| | --- Comment #45 from Kyle M Hall --- Created attachment 18152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18152&action=edit Bug 7441: Followup search results showing wrong branch [UNIMARC] Unimarc modifications Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:35:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:35:43 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17903|0 |1 is obsolete| | --- Comment #46 from Kyle M Hall --- Created attachment 18153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18153&action=edit Bug 7441 - search results showing wrong branch? - Followup - Use syspref for XSLT and non-XSLT Signed-off-by: Bernardo Gonzalez Kriegel Comment: Applied all patches. Tested with and without XLST display. Works as described. No errors. Not tested with UNIMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:36:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:36:08 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:36:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:36:09 +0000 Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17968|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall --- Created attachment 18154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18154&action=edit Bug 7441 - search results showing wrong branch? - Followup - Delete Koha TT Plugin Deletes the Koha TT Plugin from this patch series, to move it to it's own bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:38:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:38:23 +0000 Subject: [Koha-bugs] [Bug 10159] koha-rebuild-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10159 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:38:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:38:33 +0000 Subject: [Koha-bugs] [Bug 10157] koha-email-enable error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10157 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:38:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:38:38 +0000 Subject: [Koha-bugs] [Bug 10146] koha-stop-zebra error handling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10146 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:38:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:38:42 +0000 Subject: [Koha-bugs] [Bug 10094] koha-list should have an --disabled option In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10094 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:43:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:43:02 +0000 Subject: [Koha-bugs] [Bug 7390] Place hold page should offer compact view if it is in a pop-up In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7390 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard --- Fixed by Bug 9115. Instead of performing the hold operation in the pop-up window we open the holds page in the "main" window. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:45:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:45:50 +0000 Subject: [Koha-bugs] [Bug 7071] download list link not opening new window in FF7 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7071 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Owen Leonard --- This doesn't seem to be a problem anymore in master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 15:51:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 13:51:28 +0000 Subject: [Koha-bugs] [Bug 7416] calendar header black in Chrome In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7416 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Owen Leonard --- Starting in 3.10 we have a new calendar widget which isn't affected by this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:02:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:02:36 +0000 Subject: [Koha-bugs] [Bug 7637] patron renewal notice stand out more In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7637 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX QA Contact|koha.sekjal at gmail.com | --- Comment #2 from Owen Leonard --- I'm marking this "wontfix" since it seems to be working for most people. If I misunderstand what this is about please reopen and provide more details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:05:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:05:59 +0000 Subject: [Koha-bugs] [Bug 7506] opac note not showing in staff client anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7506 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #5 from Owen Leonard --- I'm closing this because the original bug doesn't seem to be valid. The other issues about permanent vs. temporary notes can be addressed in a new bug if someone feels strongly about it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:07:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:07:50 +0000 Subject: [Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |Small patch QA Contact| |m.de.rooy at rijksmuseum.nl --- Comment #7 from M. de Rooy --- Looking at this one now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:11:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:11:32 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:11:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:11:33 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18044|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 18155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18155&action=edit Bug 10080 - Change system pref IndependantBranches to IndependentBranches Test Plan: 1) Enable IndependantBranches 2) Apply this patch 3) Run updatedatabase.pl 4) Verify that the system preference still functions correctly Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:11:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:11:36 +0000 Subject: [Koha-bugs] [Bug 7713] display local license files in about.pl, rather than via external urls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7713 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:12:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:12:13 +0000 Subject: [Koha-bugs] [Bug 7713] display local license files in about.pl, rather than via external urls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7713 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|INVALID |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:12:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:12:18 +0000 Subject: [Koha-bugs] [Bug 7713] display local license files in about.pl, rather than via external urls In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7713 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:12:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:12:48 +0000 Subject: [Koha-bugs] [Bug 7776] Inconsistency between check in and check out display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7776 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:12:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:12:53 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 --- Comment #12 from Kyle M Hall --- (In reply to comment #10) > Hi Kyle, > > your patch contains the po files, but changes to those files should be > handled via Pootle. Can you please resubmit your patch without them? > > I am also not sure if old release notes should be included, as they are > 'history'. Good call, fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:14:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:14:49 +0000 Subject: [Koha-bugs] [Bug 7906] Optimize the order of styles and scripts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7906 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master QA Contact|koha.sekjal at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:21:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:21:15 +0000 Subject: [Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:21:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:21:16 +0000 Subject: [Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17568|0 |1 is obsolete| | --- Comment #8 from M. de Rooy --- Created attachment 18156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18156&action=edit Bug 10030 - MaxFines checks against amount, not amount outstanding If a patron has over time accumulated fines greater than the amount defined in MaxFine, the patron will never get more fines even if they have previously paid off those fines. This bug was introduced by the patch for Bug 7420. Test Plan: 1) Create a patron 2) Create a fine of 10.00 for that patron 3) Pay off the fine 4) Set MaxFines to 5.00 5) Check out an item to the patron, backdate the due date so the item should generate fines. 6) Run fines.pl, observe that no fine was created 7) Apply the patch 8) Rerun fines.pl 9) Observe that the fine was created correctly Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:21:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:21:57 +0000 Subject: [Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:21:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:21:58 +0000 Subject: [Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 --- Comment #9 from M. de Rooy --- Created attachment 18157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18157&action=edit Bug 10030: QA Followup for trivial false warning detected while testing Moving the warn line below the line that returns if amount<=0. If amount<=0, a false warn is now raised because of the return after it. We should only warn here if we do not return. Signed-off-by: Marcel de Rooy Tested with fines.pl on overdue. Before this patch: Reducing fine for item 199709 borrower 23 from 44 to -1 - MaxFine reached. This did not happen however because of the return. After this change: no false warning. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:23:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:23:18 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #5 from Fr?d?ric Demians --- The sorting algorithm doesn't take into account the 'dateformat' system preference. We just have a string sort. It works when dateformat = yyyy/mm/dd. It doesn't for dd/mm/yyyy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:25:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:25:31 +0000 Subject: [Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from M. de Rooy --- QA Comment: Tested. Works. Added a trivial followup too for false warning raised (detected while testing this). Simple code change looks good. The question Katrin raised: > I am continuing the tests, but reading the code of the sub I couldn't help wondering - do we really want to count in Sundry fines? This question is certainly valid, but imo falls outside the scope of this report. This patch just fixes the wrongly used column in adding the total amount. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:28:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:28:48 +0000 Subject: [Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 --- Comment #11 from Katrin Fischer --- Marcel, totally agreed - thx for QA'ing! :) I will try to write up a new bug for the other problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:31:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:31:19 +0000 Subject: [Koha-bugs] [Bug 7261] System Preference to select the first day of week (Sunday or Monday) to use in the calendar (OPAC and Intranet) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7261 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #16 from Owen Leonard --- Looks like this is working in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:36:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:36:52 +0000 Subject: [Koha-bugs] [Bug 9518] There's no sending button for opac's cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9518 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Owen Leonard --- Lacking any additional details I think this should be closed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:38:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:38:40 +0000 Subject: [Koha-bugs] [Bug 7127] Templates must be valid XHTML In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #23 from Owen Leonard --- (In reply to comment #22) > Should we leave this open or better have individual new bugs for new > problems? I think in general individual bugs work better, and since we're using an HTML5 doctype now this bug should be closed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:38:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:38:41 +0000 Subject: [Koha-bugs] [Bug 7452] OPAC unable to delete list item in IE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7452 Bug 7452 depends on bug 7127, which changed state. Bug 7127 Summary: Templates must be valid XHTML http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7127 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:52:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:52:41 +0000 Subject: [Koha-bugs] [Bug 7534] OPACAllowUserToChooseBranch and hold rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7534 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Component|OPAC |Hold requests Version|3.6 |master Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org QA Contact|koha.sekjal at gmail.com | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 16:57:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 14:57:58 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 --- Comment #26 from Rafal --- Created attachment 18158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18158&action=edit Proposed fix This path should fix display Statuses in OPAC. Patch is for master, but bug appear in all versions from 3.8+. Thi is my first patch so let me know if something's wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 17:03:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 15:03:52 +0000 Subject: [Koha-bugs] [Bug 10250] New: typo in help/reports/guided_reports.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Bug ID: 10250 Summary: typo in help/reports/guided_reports.tt Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: mathieu.saby at univ-rennes2.fr typo in help/reports/guided_reports.tt : CreditXXX should be credit M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 17:07:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 15:07:27 +0000 Subject: [Koha-bugs] [Bug 10251] New: typos in help/members/member-flags.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 Bug ID: 10251 Summary: typos in help/members/member-flags.tt Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: mathieu.saby at univ-rennes2.fr typos in help/members/member-flags.tt
  • Access to the Overdue Notice Status/TriggersTool
    • should be
  • Access to the Overdue Notice Status/Triggers Tool
    • and
  • Acces to the Tags Tool
    • should be
  • Access to the Tags Tool
    • M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 17:09:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 15:09:14 +0000 Subject: [Koha-bugs] [Bug 10250] typo in help/reports/guided_reports.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #1 from mathieu saby --- also : missing space after "=" in this line
  • W =Waiting: the reserve is linked to an item, is at the pickup branch, and is waiting on the hold shelf
    • -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 17:14:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 15:14:29 +0000 Subject: [Koha-bugs] [Bug 10250] typo in help/reports/guided_reports.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #2 from mathieu saby --- in the same file, probably an other typo, but I am not sure : 6 = Delete should be 6 = Deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 17:14:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 15:14:38 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|typo in |typos in |help/reports/guided_reports |help/reports/guided_reports |.tt |.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 17:23:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 15:23:43 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #3 from mathieu saby --- Another typo: "What are the possible codes for the area field in the reports_dictionary table?" should be "What are the possible codes for the report_area field in the reports_dictionary table?" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 17:48:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 15:48:49 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #61 from Owen Leonard --- (In reply to comment #60) > 2/ fixed display bug What is 'i18n-content="title"' supposed to do? This template should not have a beginning <title> tag. <title> is supplied by doc-head-open.inc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 18:26:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 16:26:28 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-ETrf0cWeHI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- 1 other typos : What are the possible codes for the status field in the serial table"? should be What are the possible codes for the status field in the serial table? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 18:44:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 16:44:20 +0000 Subject: [Koha-bugs] [Bug 10043] When receiving an item to have the facility to scan the barcode and change the status of the item from ON ORDER to JUST RECEIVED automatically In-Reply-To: <bug-10043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10043-70-0iRrcsR5pq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10043 --- Comment #1 from Amit Gupta <amit.gupta at osslabs.biz> --- Created attachment 18159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18159&action=edit Clear notforloan on receipt Clear not for loan on receipt When receiving an item to have the facility to scan the barcode and change the status of the item from ON ORDER to JUST RECEIVED automatically To Test: 1) Create a ACQ framwork in MARC bibliographic framework 2) Search 952 tag and set default value notforloan is to -1 3) Create a basket for ex: basket1 4) Create order under basket 5) Close the basket 6) Receive the shipment 7) By default notforloan value is Ordered 8) Once you receive the order item tag value is available or value is 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 18:44:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 16:44:43 +0000 Subject: [Koha-bugs] [Bug 10043] When receiving an item to have the facility to scan the barcode and change the status of the item from ON ORDER to JUST RECEIVED automatically In-Reply-To: <bug-10043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10043-70-JdPUAV5aP5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10043 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 18:49:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 16:49:03 +0000 Subject: [Koha-bugs] [Bug 10043] Clear notforloan on receipt In-Reply-To: <bug-10043-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10043-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10043-70-DRKDZAt8Sv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10043 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When receiving an item to |Clear notforloan on receipt |have the facility to scan | |the barcode and change the | |status of the item from ON | |ORDER to JUST RECEIVED | |automatically | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 18:57:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 16:57:45 +0000 Subject: [Koha-bugs] [Bug 10243] Holds queue is making transfer requests that contradict the branch holds policy In-Reply-To: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10243-70-S0uzpPYSzD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18138|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 19:12:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 17:12:38 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-hWWQEItZGI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 --- Comment #27 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- (In reply to comment #26) > Created attachment 18158 [details] [review] I think this is a new bug. And it should use KohaAuthorisedValues template plugin on restricted data. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 19:19:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 17:19:16 +0000 Subject: [Koha-bugs] [Bug 10243] Holds queue is making transfer requests that contradict the branch holds policy In-Reply-To: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10243-70-smEoV6EhKF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18137|0 |1 is obsolete| | --- Comment #4 from Melia Meggs <melia at bywatersolutions.com> --- Created attachment 18160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18160&action=edit [Signed off] Bug 10243 - Holds queue is making transfer requests that contradict the branch holds policy For some reason MapItemsToHoldRequests will, as a last ditch effort, grab what seems to be an arbitrary available item to fill a hold request, even if it will violate the circulation rules for holds. In other words, even if an item matches a "Holds policy by item type" that says "From home library", a request to transfer that item to another library will be added to the holds queue! Test Plan: 1) Create a record with a an item at BranchA of item type BOOK 2) Set the holds policy such that itemtype BOOK for BranchA is set to "From home library" 3) Place a bib-level hold request for a patron with a pickup at BranchB 4) Run build_holds_queue.pl 5) You should now see a request for that item to be transfered to BranchB, even though the rules should not allow this. 6) Apply this patch 7) Run build_holds_queue.pl again 8) View the holds queue again, that request should no longer exist Signed-off-by: Heather Braum <hbraum at nekls.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 19:37:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 17:37:24 +0000 Subject: [Koha-bugs] [Bug 10243] Holds queue is making transfer requests that contradict the branch holds policy In-Reply-To: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10243-70-KPpe8tZfdC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 19:45:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 17:45:55 +0000 Subject: [Koha-bugs] [Bug 10243] Holds queue is making transfer requests that contradict the branch holds policy In-Reply-To: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10243-70-VmQ7FzwHEr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243 Heather Braum <hbraum at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum at nekls.org --- Comment #5 from Heather Braum <hbraum at nekls.org> --- I, Heather Braum, from NEKLS sign off on this patch. I have tested it on our production server and it works. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 19:48:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 17:48:56 +0000 Subject: [Koha-bugs] [Bug 10223] No suggestions showing in 3.10 In-Reply-To: <bug-10223-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10223-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10223-70-c83ozLk9hB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10223 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jweaver at bywatersolutions.co | |m Assignee|koha-bugs at lists.koha-commun |jweaver at bywatersolutions.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 22:08:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 20:08:00 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10080-70-DzPBc5wpBZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Sorry Kyle, I finally took a step forward in direction of understanding how to grep and found another occurence: /reserve/request.pl. Please provide a follow up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 22:12:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 20:12:10 +0000 Subject: [Koha-bugs] [Bug 10159] koha-rebuild-zebra error handling In-Reply-To: <bug-10159-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10159-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10159-70-X9CnZx7eqP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10159 --- Comment #5 from Robin Sheat <robin at catalyst.net.nz> --- (In reply to comment #3) > There is one (maybe) problem with this patch, but as it already exists as > far as I can tell, I am going to push the patch as-is for 3.12.0: > koha-rebuild-zebra does not check if an instance is disabled before > reindexing. Arguably it should. Specifically it shouldn't. If I'm recovering an instance where the indices have broken, I'll put it into maintenance mode by disabling it while I reindex rather than have people have issues with a half-working system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 22:32:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 20:32:31 +0000 Subject: [Koha-bugs] [Bug 10159] koha-rebuild-zebra error handling In-Reply-To: <bug-10159-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10159-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10159-70-7uMDNAG6yA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10159 --- Comment #6 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #5) > (In reply to comment #3) > > There is one (maybe) problem with this patch, but as it already exists as > > far as I can tell, I am going to push the patch as-is for 3.12.0: > > koha-rebuild-zebra does not check if an instance is disabled before > > reindexing. Arguably it should. > > Specifically it shouldn't. If I'm recovering an instance where the indices > have broken, I'll put it into maintenance mode by disabling it while I > reindex rather than have people have issues with a half-working system. Fair enough. However, it might be worth noting that in the help, as all the other Zebra scripts do not do anything when the instance is disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 22:36:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 20:36:36 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-bCRQuAeRd4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Component|Templates |Documentation Assignee|oleonard at myacpl.org |nengard at gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 22:36:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 20:36:47 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-fvlKOq0yyz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 22:37:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 20:37:24 +0000 Subject: [Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt In-Reply-To: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10251-70-38gaS9QWUs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Component|Templates |Documentation Version|master |3.12 Assignee|oleonard at myacpl.org |nengard at gmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 23:00:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 21:00:18 +0000 Subject: [Koha-bugs] [Bug 10072] "my suggestions" always says "There are no pending purchase suggestions." In-Reply-To: <bug-10072-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10072-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10072-70-kkhDkf3hdH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10072 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #7 from Jesse Weaver <jweaver at bywatersolutions.com> --- *** Bug 10223 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 23:00:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 21:00:18 +0000 Subject: [Koha-bugs] [Bug 10223] No suggestions showing in 3.10 In-Reply-To: <bug-10223-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10223-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10223-70-ENScjMU6Eg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10223 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jesse Weaver <jweaver at bywatersolutions.com> --- This seems to be the same bug as #10072, and a fix will be released in 3.10.6. *** This bug has been marked as a duplicate of bug 10072 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 23:20:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 21:20:26 +0000 Subject: [Koha-bugs] [Bug 10134] set XSLT usage ON as default, for new Koha installs In-Reply-To: <bug-10134-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10134-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10134-70-kjnrWaDzp8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10134 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- This changes the default behaviour, so not putting this in 3.10.x or 3.8.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 23:20:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 21:20:30 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-IQMK3wGh3B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #28 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Rafal, thank you for your patch! We are always very happy about new developers. Let me try to help you to get this into Koha :) This bug has the status "pushed to stable" which means it's basically done and resolved. If it has a 'Pushed...' status it's always better to file a new bug. The new bug should have a good description and ideally a test plan that shows people how to reproduce the problem you are trying to fix. The version should be set to master, if it's not a problem that's specific to an older version. Make sure you assign (Assiged to:) the bug to yourself and that you switch the bug status to 'Needs Signoff', which means it's waiting for someone to test. You can find some information about a bug's life cycle and the different status here: http://wiki.koha-community.org/wiki/Bug-enhancement-patch_Workflow If you have questions, or need some pointers, or just want to get to know us, I would recommend jumping into the IRC channel. There is almost always someone around willing to help. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 23:31:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 21:31:57 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-8xbm5NT2QR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED --- Comment #29 from Liz Rea <liz at catalyst.net.nz> --- It does say patch pushed, but I have observed this still not working correctly - so I'm going to test this patch anyway, and will upload one with the requirements as an example if it fixes the issue. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 15 23:49:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 21:49:41 +0000 Subject: [Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu In-Reply-To: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10225-70-07VqJGrVGm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.6 and 3.8.13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 00:29:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 22:29:30 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-14K2oE7a2l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11132|0 |1 is obsolete| | Attachment #11135|0 |1 is obsolete| | Attachment #12010|0 |1 is obsolete| | Attachment #18158|0 |1 is obsolete| | --- Comment #30 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 18161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18161&action=edit Bug 4173 - Statuses not appearing in the OPAC Simply revert order of 2 lines in Items.pm. Previous line write to variable used in next line as function argument. To Test: Give an item a special restricted value, define one if you have to in the authorised values. Observe that, without this patch, statuses are not shown in the OPAC in parentheses. My example was an item that had a restricted value of "Library Staff Only" It should have been shown under status on the detail page of the OPAC, but was not. Apply the patch, observe that restricted values are now shown for your item, for example: Available (Library Staff Only) in the status column. Signed-off-by: Liz Rea <liz at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 00:30:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 22:30:07 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-kr6QhYCF7F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 00:30:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 22:30:14 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-WaWZv54CuU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 00:56:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 22:56:35 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-4sbnKrHr2C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 --- Comment #31 from Liz Rea <liz at catalyst.net.nz> --- This last patch is going to be for 3.8 only, as 3.10+ have the plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 00:57:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 22:57:47 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-yyItlvFT4M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18161|0 |1 is obsolete| | --- Comment #32 from Liz Rea <liz at catalyst.net.nz> --- Created attachment 18162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18162&action=edit [3.8.x] Bug 4173 - Statuses not appearing in the OPAC Simply revert order of 2 lines in Items.pm. Previous line write to variable used in next line as function argument. To Test: Give an item a special restricted value, define one if you have to in the authorised values. Observe that, without this patch, statuses are not shown in the OPAC in parentheses. My example was an item that had a restricted value of "Library Staff Only" It should have been shown under status on the detail page of the OPAC, but was not. Apply the patch, observe that restricted values are now shown for your item, for example: Available (Library Staff Only) in the status column. Signed-off-by: Liz Rea <liz at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 01:23:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 23:23:05 +0000 Subject: [Koha-bugs] [Bug 7353] Inconsistencies with Longoverdue.pl In-Reply-To: <bug-7353-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7353-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7353-70-xzPvjX9Qbn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7353 Thatcher Rea <thatcher.rea at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Thatcher Rea <thatcher.rea at bywatersolutions.com> --- I don't believe so, no. The addition of the --mark-returned flag corrects this behavior I believe. This can probably be closed. :T -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 01:27:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 15 May 2013 23:27:57 +0000 Subject: [Koha-bugs] [Bug 10252] New: File Print of Checkout History Truncates Results Message-ID: <bug-10252-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10252 Bug ID: 10252 Summary: File Print of Checkout History Truncates Results Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: bugs.koha-community.org Assignee: koha-bugs at lists.koha-community.org Reporter: thatcher.rea at bywatersolutions.com We're observing that printing of the checkout history is truncating some of the results. To replicate: Find a patron with more than 8 checkouts. Do a File-> Print of the page, and spool to PDF. The printout will drop results after 8 items. This seems to be affected in both 3.10.5 as well as master. Printing to hard copy is also affected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 03:52:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 01:52:39 +0000 Subject: [Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding In-Reply-To: <bug-10030-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10030-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10030-70-effm0anQHM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 05:46:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 03:46:50 +0000 Subject: [Koha-bugs] [Bug 10253] New: tax rate only takes 1 decimal point Message-ID: <bug-10253-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10253 Bug ID: 10253 Summary: tax rate only takes 1 decimal point Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com Created attachment 18163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18163&action=edit tax rate preference See attached. The tax rate where I am is 6.85, but I can't get that to show in the tax pull down. It turns it in to 6.8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 05:47:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 03:47:06 +0000 Subject: [Koha-bugs] [Bug 10253] tax rate only takes 1 decimal point In-Reply-To: <bug-10253-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10253-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10253-70-r0gUK1hptN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10253 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18164&action=edit tax rate pull down -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 06:11:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 04:11:26 +0000 Subject: [Koha-bugs] [Bug 10254] New: Added sort1 and sort2 in overdue report Message-ID: <bug-10254-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10254 Bug ID: 10254 Summary: Added sort1 and sort2 in overdue report Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: amit.gupta at osslabs.biz Added sort1 and sort2 in overdue report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 06:11:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 04:11:44 +0000 Subject: [Koha-bugs] [Bug 10254] Added sort1 and sort2 in overdue report In-Reply-To: <bug-10254-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10254-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10254-70-oJniLzSHIu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10254 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |amit.gupta at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 06:12:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 04:12:45 +0000 Subject: [Koha-bugs] [Bug 10255] New: Add price in overdue report Message-ID: <bug-10255-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10255 Bug ID: 10255 Summary: Add price in overdue report Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: amit.gupta at osslabs.biz Add price in overdue report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 06:14:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 04:14:06 +0000 Subject: [Koha-bugs] [Bug 10255] Add price in overdue report In-Reply-To: <bug-10255-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10255-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10255-70-0R0PTuCiB2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10255 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Assignee|gmcharlt at gmail.com |amit.gupta at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 08:02:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 06:02:29 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-Ruo11Qj1NP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 --- Comment #33 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Liz, I think it's still better to open a new bug when a new problem arises and link it to the old one. If Rafal doesn't beat me to it, I will do it later when doing QA. My reasoning is that this has been pushed to a long released version of Koha and it takes a lot of time to process bugs like this when you are testing because there are so many comments and other things to look for. Also we have many different people working on this, a new bug is really cleaner. If the same patch works on master I would say we should use it for now. It looks like an easy fix to a longer existing problem and we shouldn't force people to rewrite lots of code in that case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 09:46:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 07:46:17 +0000 Subject: [Koha-bugs] [Bug 10096] Add a Z39.50 interface for authority searching In-Reply-To: <bug-10096-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10096-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10096-70-Bsl8MJJ3vl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10096 mr_megahed at hotmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mr_megahed at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 09:53:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 07:53:40 +0000 Subject: [Koha-bugs] [Bug 10256] New: Remove some unused subs from Overdues module, or do not export them Message-ID: <bug-10256-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 Bug ID: 10256 Summary: Remove some unused subs from Overdues module, or do not export them Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Circulation Assignee: m.de.rooy at rijksmuseum.nl Reporter: m.de.rooy at rijksmuseum.nl CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Did a grep on the following exported subs: CreateItemAccountLine UpdateAccountLines CheckAccountLineLevelInfo CheckAccountLineItemInfo CheckExistantNotifyid GetNextIdNotify GetNotifyId ReplacementCost ReplacementCost2 GetOverdueDelays GetOverduerules As it appears, they are not even used anywhere (anymore). My proposal is now to remove them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 10:07:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 08:07:39 +0000 Subject: [Koha-bugs] [Bug 10256] Remove some unused subs from Overdues module, or do not export them In-Reply-To: <bug-10256-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10256-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10256-70-u0CXzGucG7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 10:07:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 08:07:40 +0000 Subject: [Koha-bugs] [Bug 10256] Remove some unused subs from Overdues module, or do not export them In-Reply-To: <bug-10256-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10256-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10256-70-3FhEcwKYz8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 --- Comment #1 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18165&action=edit Bug 10256: Remove some unused subs from Overdues module Removes the following exported but unused subs from Overdues.pm: CreateItemAccountLine UpdateAccountLines CheckAccountLineLevelInfo CheckAccountLineItemInfo CheckExistantNotifyid GetNextIdNotify GetNotifyId ReplacementCost ReplacementCost2 GetOverdueDelays GetOverduerules Test plan: It is hard to test the removal of something that was not used :) Try this: Do a recursive grep on these routine names in the Koha codebase. Compile some scripts that use the Overdues module. And just to be sure we do not break something: Go to Circulation: Do a checkout, checkin, place and confirm a hold. Go to Patrons: Goto Check out. Goto Fines. Run the command line scripts: fines.pl and overdue_notices.pl. Go to opac-user.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 10:35:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 08:35:02 +0000 Subject: [Koha-bugs] [Bug 10257] New: Make OpacSeparateHoldings work for non-logged in users Message-ID: <bug-10257-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10257 Bug ID: 10257 Summary: Make OpacSeparateHoldings work for non-logged in users Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: magnus at enger.priv.no Depends on: 7674 OpacSeparateHoldings is a great enhancement, but only works for logged in users, which means it is less useful on e.g. public access computers in the library, used for quickly looking up what books are on the shelf in the library. It would be nice to have a way to choose a library without being logged in. This could probably work very similar to how the language chooser works (with a cookie). It would also be nice to be able to specify the chosen library in a URL, so you could link to a shared OPAC with a special link and have the chosen library be "your" library. (See bug 9735 for a parallel development for languages.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 10:35:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 08:35:02 +0000 Subject: [Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-p0aCPmBbJS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10257 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 11:58:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 09:58:33 +0000 Subject: [Koha-bugs] [Bug 10258] New: Remove erroneous call to haspermission in basket.pl Message-ID: <bug-10258-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 Bug ID: 10258 Summary: Remove erroneous call to haspermission in basket.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Acquisitions Assignee: m.de.rooy at rijksmuseum.nl Reporter: m.de.rooy at rijksmuseum.nl Current code in basket.pl contains an invalid call of haspermission: if ($basket->{closedate} && haspermission({ acquisition => 'group_manage'} )) { The first parameter should be userid, the second should be flagsrequired. Looking at the code, it is useless to just insert the first parameter here via $member->{userid}, since this would result in an empty basket group list. To resolve this, more should be done in the template. Currently, the erroneous call results in getting back some hash probably filled with zeroes. But the hash makes the if test above prove true for a closed basket. So in reality, any user will see here all basket groups. Removing this erroneous call for haspermission will therefore not make a difference. The proposed patch adds a FIXME. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 12:10:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 10:10:59 +0000 Subject: [Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl In-Reply-To: <bug-10258-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10258-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10258-70-cyuvSCP8LY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 12:11:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 10:11:01 +0000 Subject: [Koha-bugs] [Bug 10258] Remove erroneous call to haspermission in basket.pl In-Reply-To: <bug-10258-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10258-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10258-70-oLnNoxSJ2A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10258 --- Comment #1 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18166&action=edit Bug 10258: Remove erroneous call to haspermission in basket.pl First parameter (userid) was not passed making the test useless. Removed the test for now. Current behavior does not change. Just adding the first parameter here does not make sense. Using the permission here needs more than that. Test plan: Open a closed basket in Acquisition. Check if you see all available basketgroups in the combo at the right side. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 13:05:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 11:05:18 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10184-70-RZRYYH0BI3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 --- Comment #6 from Colin Campbell <colin.campbell at ptfs-europe.com> --- (In reply to comment #5) > The sorting algorithm doesn't take into account the 'dateformat' system > preference. We just have a string sort. It works when dateformat = > yyyy/mm/dd. It doesn't for dd/mm/yyyy. The sort is done by mysql on a mysql date column the koha system preference is not relevant. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 13:14:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 11:14:31 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-N10A241IDF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #44 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- We are still getting failures from jenkins on master. I am going to need to revert this today if we (well, someone who isn't me) can't figure out and fix the problem quickly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 13:17:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 11:17:50 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-23LHegzZOT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #45 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Did you test the patch of Jonathan (18114)? I suppose I cannot sign it off, as I am the main contributor to this bug? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 13:20:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 11:20:59 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-knUsflnAG5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #46 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #45) > Did you test the patch of Jonathan (18114)? > I suppose I cannot sign it off, as I am the main contributor to this bug? Yes. I pushed it, but we're still getting errors. Could it be a data issue? Is there particular data that is needed for those steps? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 13:47:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 11:47:24 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-WuqczQHxt9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #47 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I do not know how Jenkins is working. Does it precise which test is wrong? The reason why I added unit test is that P. Poulain said me "new function, new unit test" during Hackfest (the new function was on an other bug at that time) ;-) So, you can suppress some of these tests if you think they are not necessary... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 13:58:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 11:58:57 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-Ie2n2hieB5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #48 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #47) > I do not know how Jenkins is working. Does it precise which test is wrong? Jenkins just has all the sample data on a Debian Squeeze server and runs the entire build/test process every time there is a change to the source code. http://wiki.koha-community.org/wiki/Continuous_Integration If you look at http://jenkins.koha-community.org/job/Koha_master/lastCompletedBuild/testReport/ it gives you a summary, and you can get a bit more information in the log at http://jenkins.koha-community.org/job/Koha_master/lastCompletedBuild/console > The reason why I added unit test is that P. Poulain said me "new function, > new unit test" during Hackfest (the new function was on an other bug at that > time) ;-) > > So, you can suppress some of these tests if you think they are not > necessary... The test is definitely necessary, and looks good. I would not have pushed it without unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 14:26:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 12:26:32 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-jLGpqlveYO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #49 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- OK, so if I understand Jenkins logs, the 2 tests are failing. Maybe my function is wrong, or maybe the 2 lines in unit test "my $testorder = @$orders[0]; my $testbiblio = $testorder->{'biblionumber'};" I am looking at it right now. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 14:27:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 12:27:14 +0000 Subject: [Koha-bugs] [Bug 10021] Remove dead(?) code related to notifys In-Reply-To: <bug-10021-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10021-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10021-70-epA10RxEGP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10021 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10256 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 14:27:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 12:27:14 +0000 Subject: [Koha-bugs] [Bug 10256] Remove some unused subs from Overdues module, or do not export them In-Reply-To: <bug-10256-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10256-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10256-70-kjWsE2qcXK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10021 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Marcel, I think this is related to a bug I filed - only I was concentrating on the database relicts that are connected to those subs: bug 10021 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 14:31:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 12:31:09 +0000 Subject: [Koha-bugs] [Bug 10257] Make OpacSeparateHoldings work for non-logged in users In-Reply-To: <bug-10257-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10257-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10257-70-52ozVw8wVA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10257 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Maybe this could work similar as bug 7740? >If set to OpacURLBranch, the library is chosen based on the Apache environment variable BRANCHCODE. >For example, this could be added to the OPAC section of koha-httpd.conf: SetEnv BRANCHCODE "CPL" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 14:35:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 12:35:49 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-OukVPklWDr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #50 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I updated my Koha instance, and launch $prove -v Acquisition.t Acquisition.t .. ok 5 - GetOrdersByBiblionumber : no argument, return undef ok 6 - GetOrdersByBiblionumber : result is defined ok 7 - GetOrdersByBiblionumber : result contains at least one element I don't understand : How is it possible that Jenkins fails and not my instance? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 14:43:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 12:43:37 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-zdTtGHq8xl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #51 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #50) > I don't understand : How is it possible that Jenkins fails and not my > instance? Theses tests are db dependent. As Jared said, you should insert the sample data before launching them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 14:45:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 12:45:52 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-ykTG9wMHlq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #52 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I checked everything is correct by adding warns in my Acquisition.t warn 'record number : '.$testbiblio; my @listorders = GetOrdersByBiblionumber($testbiblio); ok( @listorders ,'GetOrdersByBiblionumber : result is defined' ); ok( scalar (@listorders) >0,'GetOrdersByBiblionumber : result contains at least one element' ); warn 'nborders in listorders : '.scalar (@listorders); warn 'record number in listorders[0] : '. at listorders[0]->{biblionumber}; => everything is correct record number : 2090 at Acquisition.t line 45. ok 6 - GetOrdersByBiblionumber : result is defined ok 7 - GetOrdersByBiblionumber : result contains at least one element nborders in listorders : 1 at Acquisition.t line 49. record number in listorders[0] : 2090 at Acquisition.t line 50. So, as you say, the pbm must come from the test database. Is there a way to look at its data ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 14:46:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 12:46:36 +0000 Subject: [Koha-bugs] [Bug 10256] Remove some unused subs from Overdues module, or do not export them In-Reply-To: <bug-10256-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10256-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10256-70-63PD7BcmW8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 --- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #2) > I think this is related to a bug I filed - only I was concentrating on the > database relicts that are connected to those subs: bug 10021 Good catch, Katrin. Well, this patch could remove the first code. Your report is somewhat broader in scope. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 14:46:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 12:46:55 +0000 Subject: [Koha-bugs] [Bug 10256] Remove some unused subs from Overdues module In-Reply-To: <bug-10256-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10256-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10256-70-Y65Zf42Shb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10256 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remove some unused subs |Remove some unused subs |from Overdues module, or do |from Overdues module |not export them | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 14:52:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 12:52:14 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-NZaFlRWfuw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #53 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Jonathan I did not see you answer. I never did that, and I am not sure it could be done in a few lines (need to find a biblio or create it, find a fund, a vendor etc). So if it is necessary, I could not do that today, and Jared need to revert the bug. Maybe the easier solution would be to take a look at Jenkins sample database, but I don't know where it is. I suppose there must already be some orders in it, because other tests of Acquisiton.t do not fail. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 14:52:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 12:52:36 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10166-70-AJZ9Wk7Jfs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18167&action=edit Bug 10166 [3.10.x] Can't place holds on multiple titles if one or more are un-holdable opac-reserve.pl tries to check whether all selected titles in a multiple-hold batch are unavailable to be placed on hold. However, the logic is flawed in such a way that if the last item in the batch cannot be placed on hold the script assumes none can be placed on hold. This patch modifies the way the script tracks the "no titles available for holds" variable in order to correct the error. To test, place multiple holds by selecting titles from a list of search results. Test three conditions: - All titles are available to be placed on hold You should see no onscreen warnings, and all titles should be selectable on the place hold screen. A "Place hold" button should appear at the bottom. - Some titles can be placed on hold, some cannot The titles which can be placed on hold should be selectable. Titles which cannot be placed on hold should show a warning message. A "Place hold" button should appear at the bottom. - No titles can be placed on hold "Sorry, none of these items can be placed on hold." should appear at the top of the page. All titles should appear with warning messages. There should be no "Place hold" button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 14:52:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 12:52:51 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10166-70-iPBfZLXpDI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17947|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 15:05:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 13:05:35 +0000 Subject: [Koha-bugs] [Bug 10257] Make OpacSeparateHoldings work for non-logged in users In-Reply-To: <bug-10257-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10257-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10257-70-5R6I2B53Xx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10257 --- Comment #2 from Magnus Enger <magnus at enger.priv.no> --- (In reply to comment #1) > Maybe this could work similar as bug 7740? > > >If set to OpacURLBranch, the library is chosen based on the Apache > environment variable BRANCHCODE. > >For example, this could be added to the OPAC section of koha-httpd.conf: > SetEnv BRANCHCODE "CPL" Yeah, that is cool! But as far as I can understand, if you have say 50 libraries in one instance, you have to create 50 new apache configs, one for each library. I still think it would be nice to have a way to set the library based on a URL that does not require tweaking the Apache configs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 15:05:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 13:05:52 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-SOGghzHUoN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 15:05:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 13:05:54 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-zEMOKYYZVF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #22 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18168&action=edit [SIGNED-OFF] Bug 9824 - Hide basket with no expected items in basqket list by bookseller Before patch you will see in acqui/booksellers.pl all the baskets ever created. After the patch you will see in acqui/booksellers.pl only the basket with expected items. Test plan : * Create a basket with some orders lines You should see this basket in acqui/booksellers.pl * receive or cancel all the line in this basket This basket shouldn't appear any more in acqui/booksellers.pl Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 15:06:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 13:06:04 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-lzw4jfIrkK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16639|0 |1 is patch| | Attachment #16639|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 15:29:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 13:29:00 +0000 Subject: [Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface In-Reply-To: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10083-70-Z8BiKryhWQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17767|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18169&action=edit Bug 10083 [3.10.x] In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 15:37:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 13:37:44 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10120-70-F2LLVxkc53@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 --- Comment #12 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- String changes, so this will be held for 3.14/3.12.1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 15:55:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 13:55:49 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-aMHMmt6eyO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #54 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #48) > Jenkins just has all the sample data on a Debian Squeeze server and runs the > entire build/test process every time there is a change to the source code. > http://wiki.koha-community.org/wiki/Continuous_Integration Hello Jared, In fact I don't understand at all why tests fail. Maybe I missed something. What are sample data? Is it sql files in installer/data/mysql/en/optional? I don't find any insert into the acquisition tables and t/db_dependent/Acquisition.t does not add orders. How is created this order? I suspect that the biblionumber key (l.44) is empty but I cannot check it :-/ (I include Chris in the loop) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 16:11:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 14:11:42 +0000 Subject: [Koha-bugs] [Bug 10259] New: koha-*-zebra scripts are expected to run without warnings if no instance name passed Message-ID: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Bug ID: 10259 Summary: koha-*-zebra scripts are expected to run without warnings if no instance name passed Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com CC: robin at catalyst.net.nz This files where modified to check the parameters for instance names. This sounds fine, but the init scripts expect the start script not to complain on missing instance parameters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 16:18:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 14:18:41 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-mlf40GsrJz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 18170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18170&action=edit Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed Commented out the code that checks for intance name parameters on the zebra service handling scripts. It restores the original behaviour, while leaving error checking code. Regards To+ Sponsored-by: Universidad Nacionald de C?rdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 16:20:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 14:20:55 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-VlC1YmAiEO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 16:57:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 14:57:20 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-Pzm0V3hw54@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18170|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 18171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18171&action=edit Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed Commented out the code that checks for intance name parameters on the zebra service handling scripts. It restores the original behaviour, while leaving error checking code. Regards To+ Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 18:14:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 16:14:11 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10174-70-Vo5giabMez@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 --- Comment #6 from Nicole C. Engard <nengard at gmail.com> --- I just got a suggestion - why not have it so that when you mouse over 'digest' it explains what it is? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 18:53:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 16:53:46 +0000 Subject: [Koha-bugs] [Bug 9906] Holds Return Policy and Local Hold Item Types not working as expected In-Reply-To: <bug-9906-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9906-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9906-70-Fi0FpGixBK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9906 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |melia at bywatersolutions.com Resolution|--- |DUPLICATE --- Comment #6 from Melia Meggs <melia at bywatersolutions.com> --- I think was resolved with the patch for Bug 10243, so I am closing this out. *** This bug has been marked as a duplicate of bug 10243 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 18:53:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 16:53:46 +0000 Subject: [Koha-bugs] [Bug 10243] Holds queue is making transfer requests that contradict the branch holds policy In-Reply-To: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10243-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10243-70-SCpdpQwNUO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10243 --- Comment #6 from Melia Meggs <melia at bywatersolutions.com> --- *** Bug 9906 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 18:57:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 16:57:46 +0000 Subject: [Koha-bugs] [Bug 4012] Can't place hold on specific copy if selecting more than 1 title In-Reply-To: <bug-4012-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4012-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4012-70-1s6eA34lX4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4012 --- Comment #4 from Nicole C. Engard <nengard at gmail.com> --- This is still a desired function. Since you can do it in the OPAC it only makes sense that the staff should be able to do it via the staff client. This came up in training today so I'm bumping this. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 19:10:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 17:10:08 +0000 Subject: [Koha-bugs] [Bug 10260] New: way to enter a note when writing off Message-ID: <bug-10260-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10260 Bug ID: 10260 Summary: way to enter a note when writing off Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com It would be nice to have a way to have a note attached to the write off. A way to enter why you wrote off the fine. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 19:29:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 17:29:13 +0000 Subject: [Koha-bugs] [Bug 10261] New: On pay fines tab patron tabs are missing Message-ID: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Bug ID: 10261 Summary: On pay fines tab patron tabs are missing Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All URL: cgi-bin/koha/members/pay.pl?borrowernumber=96 OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com If you're on the pay fines tab you don't see the following tabs on the left as you should: Files Routing List Statistics -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 19:56:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 17:56:26 +0000 Subject: [Koha-bugs] [Bug 10262] New: fine calculation at checkin not respecting CircControl Message-ID: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Bug ID: 10262 Summary: fine calculation at checkin not respecting CircControl Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: melia at bywatersolutions.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The fine calculation at checkin is not respecting CircControl the way fines.pl does. (More details and test plan coming with a patch soon.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 19:57:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 17:57:38 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-fVOKelYsWe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 20:15:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 18:15:30 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-AAT344LCNY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18172&action=edit Bug 10262 - fine calculation at checkin not respecting CircControl The fines.pl script uses the system preference CircControl to decide what branches circ rules to use for fine generation. Recently, code was added to the returns system to recalculate the fine at checkin time ( to support hourly loans ). The problem is that this code does not respect CircControl. Test Plan: 1) Set circ control to "the library you are logged in at" 2) Set different fines rules for two different librarys 3) Check an item out at library A, backdate the due date so it's overdue and will have fines. 4) Check the item in at library B 5) Observe that the fines should be generated based on library A's rules, but the fines will be based on library B's rules instead! 5) Apply the patch 6) Repeat steps 3 and 4. 7) Observe now that the fines should reflect the fines rules for Library A Note: it seems counter-intuitive for the fines system to behave this way based on the preference being set to "the library you are logged in at" but it does make sense. The rules used are from "the library you are logged in at" when the item is first checked out. If the fines system really did use the rules for the library the item was returned to, it would be easy to exploit the library system. Some Koha using system have branches that charge fines, and others that don't, so a patron could just return any overdue item's to a non-charging branch to avoid ever paying fines! Furthermore, it would mean that the fines.pl script would be using one set of rules to charge fines, and the returns system could possibly be using another. Since fines.pl has been around far longer, it makes sense to assume the fines.pl behavior is canonical. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 20:15:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 18:15:28 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-YM44OPe7n9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 20:16:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 18:16:57 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-d61iHVVcOQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18172|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18173&action=edit Bug 10262 - fine calculation at checkin not respecting CircControl The fines.pl script uses the system preference CircControl to decide what branches circ rules to use for fine generation. Recently, code was added to the returns system to recalculate the fine at checkin time ( to support hourly loans ). The problem is that this code does not respect CircControl. Test Plan: 1) Set circ control to "the library you are logged in at" 2) Set different fines rules for two different librarys 3) Check an item out at library A, backdate the due date so it's overdue and will have fines. 4) Check the item in at library B 5) Observe that the fines should be generated based on library A's rules, but the fines will be based on library B's rules instead! 5) Apply the patch 6) Repeat steps 3 and 4. 7) Observe now that the fines should reflect the fines rules for Library A Note: it seems counter-intuitive for the fines system to behave this way based on the preference being set to "the library you are logged in at" but it does make sense. The rules used are from "the library you are logged in at" when the item is first checked out. If the fines system really did use the rules for the library the item was returned to, it would be easy to exploit the library system. Some Koha using systems have branches that charge fines, and others that don't, so a patron could just return any overdue items to a non-charging branch to avoid ever paying fines! Furthermore, it would mean that the fines.pl script would be using one set of rules to charge fines, and the returns system could possibly be using another. Since fines.pl has been around far longer, it makes sense to assume the fines.pl behavior is canonical. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 20:17:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 18:17:15 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-oxYofK8fTA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 20:20:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 18:20:30 +0000 Subject: [Koha-bugs] [Bug 10263] New: Add ability to limit which branch can edit a bibliographic record Message-ID: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Bug ID: 10263 Summary: Add ability to limit which branch can edit a bibliographic record Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com CC: m.de.rooy at rijksmuseum.nl Right now, it's possible to limit who can edit items by using IndependantBranches. However, Koha has no method of limiting who can edit bibliographic records, as they have no defined owner. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 20:25:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 18:25:42 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10263-70-Cw1FHGQM4G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 20:25:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 18:25:43 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10263-70-cde91bbFZa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18174&action=edit Bug 10200 - Bug 10263 - Add ability to limit which branch can edit a bibliographic record ( IndependentBranchesMarcEditing ) Right now, it's possible to limit who can edit items by using IndependantBranches. However, Koha has no method of limiting who can edit bibliographic records, as they have no defined owner. This patch adds a new system preference IndependentBranchesMarcEditing. If this new syspref is enabled, a librarian can only edit or delete a bib record if his or her logged in branch code matches the branchcode in biblio.branchcode. This feature does not affect the ability to edit or delete items, as that functionality is determined by IndependantBranches. This patch adds the 'branches_optional' field to the authorised values pulldown for MARC fields and subfields in the MARC frameworks editor. 'branches_optional' behaves exactly like 'branches' except it includes an "empty" choice so the branch does not have to be set. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Map a nonrepeatable field/subfield to biblio.branchcode ( e.g. 951$o ) Pro-tip: Use the authorised value 'branches_optional' to get a pulldown of libraries instead of entering the branchcode manually. 4) Edit a record, and add a branchcode. 5) Log in as a non-superlibrarian with cataloging priveleges 6) Change the logged in branch to a branch other than the one you entered in the record. 7) You should note the 'edit' pulldown for the record is missing the "Edit record" and "Delete record" options. 8) Switch the logged in branch to match the branchcode of the record. 9) You should now see the edit and delete options for that record. 10) Attempt to edit a record with no branchcode defined, you should be able to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 20:25:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 18:25:51 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10263-70-RDzqXHuEo1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 20:29:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 18:29:55 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10263-70-3dDX71PLyR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10206 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 20:29:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 18:29:55 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-U8ZuNMmlTU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10263 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 20:30:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 18:30:53 +0000 Subject: [Koha-bugs] [Bug 10200] Add more Independent Branches options In-Reply-To: <bug-10200-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10200-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10200-70-93zS1RUoLD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10200 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 21:03:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 19:03:51 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-Kz2SF9RKjl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Mickey Coalwell <mcoalwell at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcoalwell at nekls.org --- Comment #3 from Mickey Coalwell <mcoalwell at nekls.org> --- The problem was first identified by a situation in which fines were applied to an overdue item which was checked out an "no-fines" library was checked in at a fining library. I would want to see this situation tested as well. Did the overdue returned item check in fine-free at a fining library? Thanks, Mickey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 21:49:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 19:49:18 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-OUEzRdmLyi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #55 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #54) > (In reply to comment #48) > > Jenkins just has all the sample data on a Debian Squeeze server and runs the > > entire build/test process every time there is a change to the source code. > > http://wiki.koha-community.org/wiki/Continuous_Integration > > Hello Jared, > In fact I don't understand at all why tests fail. > Maybe I missed something. > What are sample data? Is it sql files in installer/data/mysql/en/optional? > I don't find any insert into the acquisition tables and > t/db_dependent/Acquisition.t does not add orders. How is created this order? > > I suspect that the biblionumber key (l.44) is empty but I cannot check it :-/ > > (I include Chris in the loop) The tests fail, because they are dependent on orders existing for an existing supplier, but the test does not set up any of this up, so they work coincidentally on systems that have it set up, skip on others that have no orders, fail on others that have some orders but not the ones the test is expecting. I will make jenkins have data to make these tests pass, in future it would be good to make the tests test creating and deleting orders too, so that they can pass on any database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 22:07:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 20:07:45 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-cxsEmuIIXs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 --- Comment #4 from Mickey Coalwell <mcoalwell at nekls.org> --- I tested an overdue item checked out at a non-fining library and checked it in at a fining library. No fines accrued. Works for me. Mickey -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 22:12:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 20:12:30 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-9pTQC4W1i9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18173|0 |1 is obsolete| | --- Comment #5 from Melia Meggs <melia at bywatersolutions.com> --- Created attachment 18175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18175&action=edit [Signed off] Bug 10262 - fine calculation at checkin not respecting CircControl The fines.pl script uses the system preference CircControl to decide what branches circ rules to use for fine generation. Recently, code was added to the returns system to recalculate the fine at checkin time ( to support hourly loans ). The problem is that this code does not respect CircControl. Test Plan: 1) Set circ control to "the library you are logged in at" 2) Set different fines rules for two different librarys 3) Check an item out at library A, backdate the due date so it's overdue and will have fines. 4) Check the item in at library B 5) Observe that the fines should be generated based on library A's rules, but the fines will be based on library B's rules instead! 5) Apply the patch 6) Repeat steps 3 and 4. 7) Observe now that the fines should reflect the fines rules for Library A Note: it seems counter-intuitive for the fines system to behave this way based on the preference being set to "the library you are logged in at" but it does make sense. The rules used are from "the library you are logged in at" when the item is first checked out. If the fines system really did use the rules for the library the item was returned to, it would be easy to exploit the library system. Some Koha using systems have branches that charge fines, and others that don't, so a patron could just return any overdue items to a non-charging branch to avoid ever paying fines! Furthermore, it would mean that the fines.pl script would be using one set of rules to charge fines, and the returns system could possibly be using another. Since fines.pl has been around far longer, it makes sense to assume the fines.pl behavior is canonical. Signed-off-by: Mickey Coalwell <mcoalwell at nekls.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 16 22:13:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 20:13:19 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-nApxWH7PXR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Melia Meggs <melia at bywatersolutions.com> --- Mickey has done before and after tests on his production server, and this patch is working, so I am helping with the Git part of the sign off. Thanks, Mickey! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 00:30:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 22:30:16 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10263-70-cmif1Rpoid@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 01:45:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 16 May 2013 23:45:45 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-RDVoSyhXs1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18171|0 |1 is obsolete| | --- Comment #3 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 18176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18176&action=edit Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed Commented out the code that checks for intance name parameters on the zebra service handling scripts. It restores the original behaviour, while leaving error checking code. Regards To+ Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Robin Sheat <robin at catalyst.net.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 03:05:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 01:05:47 +0000 Subject: [Koha-bugs] [Bug 10264] New: amazon cover not showing on results, but is on details Message-ID: <bug-10264-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10264 Bug ID: 10264 Summary: amazon cover not showing on results, but is on details Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com Created attachment 18177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18177&action=edit results - no image See attached. The amazon cover is showing on the bib detail page but not the results for some titles. Are they using a different way to look for images? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 03:06:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 01:06:07 +0000 Subject: [Koha-bugs] [Bug 10264] amazon cover not showing on results, but is on details In-Reply-To: <bug-10264-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10264-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10264-70-WgEOJT9FvG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10264 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18178&action=edit details page - image -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 04:14:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 02:14:36 +0000 Subject: [Koha-bugs] [Bug 10265] New: 830 needs spaces in opac display Message-ID: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Bug ID: 10265 Summary: 830 needs spaces in opac display Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com Created attachment 18179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18179&action=edit series display The subfields of the 830 are showing up without spaces in the series tag on the opac. See attached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 04:14:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 02:14:53 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in opac display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-PIKeMtxVn4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18180&action=edit marc for 830 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 07:49:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 05:49:44 +0000 Subject: [Koha-bugs] [Bug 10266] New: Restricted status doesn't show in OPAC Message-ID: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Bug ID: 10266 Summary: Restricted status doesn't show in OPAC Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: rkk0 at poczta.onet.pl Reporter: katrin.fischer at bsz-bw.de To Test: Give an item a special restricted value, define one if you have to in the authorised values. Observe that, without this patch, statuses are not shown in the OPAC in parentheses. My example was an item that had a restricted value of "Library Staff Only" It should have been shown under status on the detail page of the OPAC, but was not -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 07:50:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 05:50:02 +0000 Subject: [Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC In-Reply-To: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10266-70-xFyqcfNZdS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |4173 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 07:50:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 05:50:02 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-1NgwARUYw4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10266 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 07:51:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 05:51:32 +0000 Subject: [Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC In-Reply-To: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10266-70-kQvbcWsgBi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18181&action=edit Proposed patch Moved patch and bug description to a new bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 07:51:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 05:51:46 +0000 Subject: [Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC In-Reply-To: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10266-70-bwijMU6JqM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 07:51:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 05:51:41 +0000 Subject: [Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC In-Reply-To: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10266-70-L95Pb2GDGq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 07:59:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 05:59:29 +0000 Subject: [Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC In-Reply-To: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10266-70-1jFi2ntS1z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18181|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18182&action=edit [PASSED QA] Bug 4173 - Statuses not appearing in the OPAC Simply revert order of 2 lines in Items.pm. Previous line write to variable used in next line as function argument. To Test: Give an item a special restricted value, define one if you have to in the authorised values. Observe that, without this patch, statuses are not shown in the OPAC in parentheses. My example was an item that had a restricted value of "Library Staff Only" It should have been shown under status on the detail page of the OPAC, but was not. Apply the patch, observe that restricted values are now shown for your item, for example: Available (Library Staff Only) in the status column. Signed-off-by: Liz Rea <liz at catalyst.net.nz> http://bugs.koha-community.org/show_bug.cgi?id=10266 Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes all tests and test plan. Simple change fixing a display problem, no string changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 07:59:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 05:59:27 +0000 Subject: [Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC In-Reply-To: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10266-70-zqajjSRt22@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 08:01:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 06:01:14 +0000 Subject: [Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC In-Reply-To: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10266-70-bYsEdAtG8y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off Patch complexity|Small patch |--- --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- As we are very close to release I suggest to file a separate bug for using the new TT plugin for displaying all item status and use this patch to fix the existing bug in the upcoming release and the older releases. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 08:02:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 06:02:16 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-xlzhJKCcUu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18162|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 08:03:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 06:03:13 +0000 Subject: [Koha-bugs] [Bug 4173] Statuses not appearing in the OPAC In-Reply-To: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4173-70-nbt5L6Cxaj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4173 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |FIXED --- Comment #34 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I have opened bug 10266 for the new patch and passed QA on the patch there. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 08:03:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 06:03:49 +0000 Subject: [Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC In-Reply-To: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10266-70-YYEvZvKuVp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 08:32:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 06:32:54 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-w7w7ToH5M4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Sophie, I am at a loss here... I don't know how to fix the problem with permissions on running at. I have added the users to a newly created at.allow file, but it's just not working. :( -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 08:44:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 06:44:43 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-wfVt7ZWqEr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18183&action=edit screenshot Actually, the logs show no new permission errors now, but I still get the same message in the interface about the job not being added (see screenshot) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 09:29:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 07:29:28 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-r2Zmdk0EeQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #56 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #55) Chris, Thank you for your quick reply! > The tests fail, because they are dependent on orders existing for an > existing supplier, but the test does not set up any of this up, so they work > coincidentally on systems that have it set up, skip on others that have no > orders, fail on others that have some orders but not the ones the test is > expecting. So what was the case for the DB used by jenkins? Was an order exist ? I think yes: Yesterday, the jenkins report for t/db_dependent/Acquisition.t was [...] ok 2 - NewBasket( 1 , 1 ) returns 18575 ok 3 - GetBasket(18575) returns HASH(0x3b1a960) ok 4 - The reference isa ARRAY ok 5 - GetOrdersByBiblionumber : no argument, return undef not ok 6 - GetOrdersByBiblionumber : result is defined not ok 7 - GetOrdersByBiblionumber : result contains at least one element ok 8 - all orders match ok 9 - AddClaim : Check claimed_date ok 10 - This order has a basketno field ok 11 - This order has a biblioitemnumber field ok 12 - This order has a biblionumber field ok 13 - This order has a invoiceid field [...] If no orders existed we should have: ok 1 - use C4::Acquisition; ok 2 - NewBasket( 1 , 1 ) returns 92 ok 3 - GetBasket(92) returns HASH(0x402ecc8) ok 4 - The reference isa ARRAY ok 5 - GetOrdersByBiblionumber : no argument, return undef ok 6 # skip No Orders, cannot test GetOrdersByBiblionumber ok 7 # skip No Orders, cannot test GetOrdersByBiblionumber ok 8 # skip No Orders, cannot test GetOrdersByBiblionumber ok 9 - AddClaim : Check claimed_date ok 10 # skip No relevant orders in database, cannot test baskets ok 11 # skip No relevant orders in database, cannot test baskets ok 12 # skip No relevant orders in database, cannot test baskets So yesterday an order existed before tests was launched, but I don't find why. It was not inserted by sample data (which I know) or unit test itself. I would like to unravel this mystery :) > I will make jenkins have data to make these tests pass, in future it would > be good to make the tests test creating and deleting orders too, so that > they can pass on any database. Yes, it is what I do and I think Mathieu should propose another patch to go in that way. Otherwise, it will be even more complicated to understand how tests are launched and how launching them with a local DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 09:58:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 07:58:12 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-zm3Tn3HwLW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #31 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #29) > I am at a loss here... I don't know how to fix the problem with permissions > on running at. I have added the users to a newly created at.allow file, but > it's just not working. :( If you have Linux distro with SELinux enforced, that could be a reason too. In that case you need to tell SELinux too that this is okay.. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 09:59:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 07:59:44 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-v9Uo8LTnTW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #57 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- > > I will make jenkins have data to make these tests pass, in future it would > > be good to make the tests test creating and deleting orders too, so that > > they can pass on any database. > > Yes, it is what I do and I think Mathieu should propose another patch to go > in that way. Otherwise, it will be even more complicated to understand how > tests are launched and how launching them with a local DB. It may be beyond my competencies :( I think the best would be some real good developper create a strong and comprehensive set of tests for Acquisition.t. A lot of functions are not tested at that time. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 10:04:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 08:04:49 +0000 Subject: [Koha-bugs] [Bug 10267] New: No error message when entering an invalid cardnumber Message-ID: <bug-10267-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Bug ID: 10267 Summary: No error message when entering an invalid cardnumber Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The cardnumber field is limited to 16 in Koha. When you enter a longer cardnumber the number is cut off. When you try to change it adding the missing part, there is no error message shown and your change is just not saved. Koha should give a useful error message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 10:07:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 08:07:25 +0000 Subject: [Koha-bugs] [Bug 10268] New: add missing perl packages for Koha on wheezy (perl5.14) Message-ID: <bug-10268-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10268 Bug ID: 10268 Summary: add missing perl packages for Koha on wheezy (perl5.14) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: mtj at kohaaloha.com CC: robin at catalyst.net.nz i just upgraded my squeeze box to wheezy, and got some errors about some missing perl modules a quick cpanm fixed the errors... # cpanm LWP/UserAgent.pm Try/Tiny.pm URI/Escape.pm this bug will attempt to fix this problem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 10:30:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 08:30:08 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-iaZLUH2K8D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am using Ubuntu and didn't activate anything. Maybe it's realted to the form that has changed between the screenshots and the current version in master? The error from the logs is gone, so I think I must have solved the permission problem, but I still can't schedule anything, which makes me think that there is something wrong with my input or something else inside Koha? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 10:34:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 08:34:23 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-E5DuQjhkhQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 --- Comment #33 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Katrin: Just another observation. I set my SELinux temporarily to Permissive. I can add a job, but there is another security issue. At job run time, I receive the mail: This account is currently not available. Why? Because my apache user is not allowed to login. So the job cannot be run, although it is allowed via at.allow etc. This brings me to a more important question: Should we encourage Koha users to allow login for apache user to make use of the Task Scheduler? Note that is a general Apache hardening measure to not allow interactive login for the apache user. IMO we (as Koha developers) should not stimulate Koha users to lower security barriers to enable Koha functionality. Another approach to the Task Scheduler could be to have a specific cronjob, look for Koha reports to run at specified times without allowing apache to add generic jobs with all security risks attached.. Moving this report to In Discussion. Will send a mail to the dev list. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 10:34:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 08:34:48 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-uM97pEGKDg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 10:53:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 08:53:51 +0000 Subject: [Koha-bugs] [Bug 10269] New: add a way to define a specific replyto email address for some notice Message-ID: <bug-10269-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 Bug ID: 10269 Summary: add a way to define a specific replyto email address for some notice Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: mathieu.saby at univ-rennes2.fr I am defining a notice template for ILL. I want to use a specific email address (like "ill at mylibrary.fr", instead of the adress of the banch or the adress of the Koha administrator. I believe it is not possible. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:01:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:01:09 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-bqTnsb4OBS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #58 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #55) > The tests fail, because they are dependent on orders existing for an > existing supplier, but the test does not set up any of this up, so they work > coincidentally on systems that have it set up, skip on others that have no > orders, fail on others that have some orders but not the ones the test is > expecting. > > I will make jenkins have data to make these tests pass, in future it would > be good to make the tests test creating and deleting orders too, so that > they can pass on any database. Hi Chris, and thx for the DB fix. Is it written somewhere how the jenkins database is filled ? I thought it was filled with default datas, and default datas only, but we're not sure, because other acq tests should have failed. what are we missing ? (about having datas to make there tests pass, that could be Kenza main work. 2 weeks to wait before she's onboard ;-) -and maybe 2-3 more weeks before she can really produce high value code - ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:02:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:02:38 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-w4BmLrf3gt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #23 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- QA: Looking at this one now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:02:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:02:58 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-gOKFkXaXcj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:32:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:32:50 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-ynfJ7EUjKH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #24 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- QA Comment: Works fine. My only question was: How to find back this basket if it is no longer on that list. But with Order search or its Advanced Search, you can still find it. Small patch. No complaints from qa-tools. Looks good. BTW: I do not think that quantityreceived could be NULL (constrained), but this test does not hurt either. Final thought: Perhaps another improvement could be: always show baskets that are still open and apply your condition only on the closed ones.. If you agree on that, could you add a followup? Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:33:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:33:12 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-Ux4Y9uSt5K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:33:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:33:14 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-BYKWC4Bl18@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18168|0 |1 is obsolete| | --- Comment #25 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18184&action=edit Bug 9824 - Hide basket with no expected items in basqket list by bookseller Before patch you will see in acqui/booksellers.pl all the baskets ever created. After the patch you will see in acqui/booksellers.pl only the basket with expected items. Test plan : * Create a basket with some orders lines You should see this basket in acqui/booksellers.pl * receive or cancel all the line in this basket This basket shouldn't appear any more in acqui/booksellers.pl Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:33:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:33:29 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-TxqYkHo4Dz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:34:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:34:13 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-syvl8mqU21@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:36:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:36:22 +0000 Subject: [Koha-bugs] [Bug 10270] New: GetOrdersByBiblionumber needs better unit tests Message-ID: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 Bug ID: 10270 Summary: GetOrdersByBiblionumber needs better unit tests Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:36:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:36:29 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-1YtUMx6w0e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7593 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:36:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:36:29 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-vOts58vDzf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10270 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:36:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:36:41 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-QtdE5cKeD4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:38:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:38:32 +0000 Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto email address for some notice In-Reply-To: <bug-10269-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10269-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10269-70-og8g5lLlaF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 Liz Rea <liz at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea <liz at catalyst.net.nz> --- I agree this is desirable. Reply to should probably be a configuration option in notices and tools, per branch and per notice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:40:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:40:39 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-CGzpJF5ryT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:40:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:40:41 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-JZ51fbG3sT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18185&action=edit Bug 10270: GetOrdersByBiblionumber needs better unit tests prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:41:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:41:28 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-MvoLHDuurK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.12 Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:47:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:47:58 +0000 Subject: [Koha-bugs] [Bug 9417] Allow number of results per page to be selectable for guided reports In-Reply-To: <bug-9417-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9417-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9417-70-r52nj1N027@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9417 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9719 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:47:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:47:58 +0000 Subject: [Koha-bugs] [Bug 9719] Changing the rows per page on a custom report fails if it has user supplied parameters In-Reply-To: <bug-9719-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9719-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9719-70-hZ3aviNSea@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9417 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:48:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:48:08 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-hRTlOQohx0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18185|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18186&action=edit Bug 10270: GetOrdersByBiblionumber needs better unit tests prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:51:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:51:42 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-n97rplj8rN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #3 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Thank you Jonathan, that looks GREAT! I am going to test it right now. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:53:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:53:07 +0000 Subject: [Koha-bugs] [Bug 9719] Changing the rows per page on a custom report fails if it has user supplied parameters In-Reply-To: <bug-9719-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9719-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9719-70-WLcjauki18@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9719 --- Comment #7 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- (In reply to comment #5) > Does not apply to 3.10.x please rebase if needed This bug corrects an enhancement added by bug 9417 which has only been pushed on master. So no need to create a 3.10.x rebase. @Kyle : nice job, you're like a bug hunter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:53:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:53:11 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-jfFgBiTaBg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17650|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18187&action=edit Bug 5336: Add unit tests for 3 acq routines Unit tests In C4::Acquisition for: - CloseBasket - ReopenBasket - GetBiblioCountByBasketno -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 11:58:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 09:58:51 +0000 Subject: [Koha-bugs] [Bug 10174] Digest is confusing In-Reply-To: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10174-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10174-70-dUcREQrbpZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10174 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #7 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- In french, we have no exact translation for digest. For us it is the same world as "summary" or "abstract". So we translate it by "r?sum?" (summary), but it sounds a bit strange. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 12:10:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 10:10:49 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-bVPwyFLJak@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I made 2 tests : $prove -v t/db_dependent/Acquisition/GetOrdersByBiblionumber.t t/db_dependent/Acquisition/GetOrdersByBiblionumber.t .. ok 1 - GetOrdersByBiblionumber : no argument, return undef ok 2 - 1 order on biblionumber 1 ok 3 - 2 orders on biblionumber 2 1..3 ok All tests successful. Files=1, Tests=3, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.36 cusr 0.03 csys = 0.41 CPU) Result: PASS and $prove -v t/db_dependent/Acquisition.t t/db_dependent/Acquisition.t .. 1..37 [...] All tests successful. Files=1, Tests=37, 1 wallclock secs ( 0.01 usr 0.01 sys + 0.36 cusr 0.04 csys = 0.42 CPU) Result: PASS I sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 12:13:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 10:13:41 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-bM14PcXqJ6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18186|0 |1 is obsolete| | --- Comment #5 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Created attachment 18188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18188&action=edit [SIGNED OFF][PATCH] Bug 10270: GetOrdersByBiblionumber needs better unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 12:14:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 10:14:15 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-0JZfmoZWX9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #59 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I signed off BZ 10270 Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 13:55:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 11:55:31 +0000 Subject: [Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC In-Reply-To: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10266-70-7FW5ABFxGx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. I agree with Katrin- I'd rather see this go into 3.12, as the patch is merely correcting the order of two lines already in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:02:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:02:58 +0000 Subject: [Koha-bugs] [Bug 10271] New: An index containing ns or nb does not work Message-ID: <bug-10271-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271 Bug ID: 10271 Summary: An index containing ns or nb does not work Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com When an index does not contain a structure part, the structure "wrdl" is automatically added and a structure is mandatory to build search query (to convert ':' into '='). But the code that tests that the structure is not already defined looks in entire index string : $index =~ /(st-|phr|ext|wrdl|nb|ns)/ It should look for a comma followed by a structure and in the case of "nb" and "ns" look for an exact match. The consequence is that an index containing ns or nb or phr or etc does not work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:03:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:03:11 +0000 Subject: [Koha-bugs] [Bug 10272] New: CheckReserves returns not respecting ReservesControlBranch Message-ID: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Bug ID: 10272 Summary: CheckReserves returns not respecting ReservesControlBranch Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com CC: gmcharlt at gmail.com CheckReserves is using the CircControl system preference to determine what patrons an item can fill a hold for. It should be using ReservesControlBranch instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:03:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:03:53 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-TUGaWeYeM3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #26 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. I have serious reservations about this patch, but am pushing it anyway as it simply reverts Koha to its previous behavior, problematic as that was. With this patch, I am no longer able to get an overview of baskets for a particular vendor. I can see a list of orders using the Orders search, but there's no overview of baskets available. I am pushing this only because I trust that someone will fix this issue properly for the 3.12.1 release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:10:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:10:22 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10272-70-JWkOIzUPeb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:10:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:10:23 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10272-70-FNw2NsxquU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18189&action=edit Bug 10272 - CheckReserves returns not respecting ReservesControlBranch CheckReserves is using the CircControl system preference to determine what patrons an item can fill a hold for. It should be using ReservesControlBranch instead. Test Plan: 1) Create an item at Library A, place holds for it for patrons at Library B, Library C, and Library A in that order, for pickup at the patrons home library. 2) Make sure the holds policy for Library A is set to Hold Policy = "From home library" and Return Policy = "Item returns home". Make sure the holds policies for the other libraries are set to Hold Policy = "From any library". 3) Check the item in at Library C, the hold for the patron at Library B should pop up, even though it's in violation of the circulation rules. Don't click the confirm button! 4) Apply this patch, and reload the page, now the hold listed should be for the last hold, the hold for the patron at Library A, which is correct. This patch adds the subroutine C4::Reserves::GetReservesControlBranch as an equivilent to C4::Circulation::_GetCircControlBranch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:10:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:10:32 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10272-70-02Se1b8rql@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:12:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:12:55 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10272-70-mqDYmYw72X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18189|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18190&action=edit Bug 10272 - CheckReserves returns not respecting ReservesControlBranch Perltidy'ed the new sub. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:14:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:14:23 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-d3zfZST13r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #27 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I have been thinking about this for a while now and I can see that it's problematic because the old behaviour has been broken quite a while ago and now it could be a problematic change for other libraries using Koha's acq. I was wondering if I could use jQuery to 'revert' to the original behaviour... probably a bit tricky, but it could work until we see this fixed properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:16:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:16:01 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-BdjaPuX6Yb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #28 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- For 3.12.1, what about a filter on the left of the page, giving ability to choose to display received/pending/closed/open baskets, according to the whish of the librarians ? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:21:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:21:13 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-ERXN1QtPWV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- That sounds nice - as long as we get something. I think having the shorter list (limited to 'unfinished' baskets) might be a good default, but have an option to show all/pending/open/closed baskets would certainly be nice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:25:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:25:03 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-wXEInhKxGO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #30 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #27) > I have been thinking about this for a while now and I can see that it's > problematic because the old behaviour has been broken quite a while ago and > now it could be a problematic change for other libraries using Koha's acq. > > I was wondering if I could use jQuery to 'revert' to the original > behaviour... probably a bit tricky, but it could work until we see this > fixed properly. That would be quite easy to do: $('.baskets tbody tr').each(function () { if ($('td:eq(2)', this).text() == $('td:eq(4)', this).text() && $('td:eq(2)', this).text() != '0') { $(this).hide(); } }); It sounds like a better patch is in the works for 3.12.1, so I am inclined to revert this patch for now, as it will change the behavior for anyone already using 3.8 or 3.10, and no one who upgraded from 3.6 noticed the change until this March. I will delay a decision until later today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:26:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:26:21 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-wFt0yn6yh5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #31 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #26) > This patch has been pushed to master and 3.12.x. > > I have serious reservations about this patch, but am pushing it anyway as it > simply reverts Koha to its previous behavior, problematic as that was. With > this patch, I am no longer able to get an overview of baskets for a > particular vendor. I can see a list of orders using the Orders search, but > there's no overview of baskets available. I am pushing this only because I > trust that someone will fix this issue properly for the 3.12.1 release. Am I missing something ? Koha > Acquisitions > Order search > Advanced search > enter basket # in basket field, and you'll get all the content of basket # ! Doesn't that fit your need ? Which use case could achieve a list of baskets for a particular vendor ? I don't see one (but I'm OK to be convinced being wrong ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:31:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:31:24 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-QtcPT1GJFE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #32 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #31) > (In reply to comment #26) > Am I missing something ? > Koha > Acquisitions > Order search > Advanced search > enter basket # in > basket field, and you'll get all the content of basket # ! > Doesn't that fit your need ? Not smoothly. > Which use case could achieve a list of baskets for a particular vendor ? I > don't see one (but I'm OK to be convinced being wrong ;-) ) I have a library that uses Acquisitions to record gifts, and each gift is a separate basket, and with a list of baskets they can review how often/when they received gifts, without needing to slog through lists of items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:31:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:31:43 +0000 Subject: [Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC In-Reply-To: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10266-70-IFFnZ6UMXs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 --- Comment #5 from Rafal <rkk0 at poczta.onet.pl> --- (In reply to comment #1) > Created attachment 18181 [details] [review] > Proposed patch > > Moved patch and bug description to a new bug. Thanks Katrin for correcting this bugfix :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:36:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:36:10 +0000 Subject: [Koha-bugs] [Bug 10266] Restricted status doesn't show in OPAC In-Reply-To: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10266-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10266-70-wSiJa8eGZx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10266 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Rafal, thx to you for fixing an annoying bug and welcome :) http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=3898e70fe55b9e56a474220223adcf205a12add1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:37:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:37:17 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-84SVDa0lcJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #33 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- "no one who upgraded from 3.6 noticed the change until this March" I can say that my colleagues noticed and come to complain very often !! I know that Lyon2 university had to change all the vendor every year to get around this problem. I take account of the desire of people who manage the acquisitions in my university, but if operations differ in other organizations, i can understand that we try to giving ability to choose to display received/pending/closed/open baskets. What is the need of people that really deals with acquisitions ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:41:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:41:59 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-APoYCLycXj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #34 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- I'm sorry but using acquistions module for gift is a sort of diversion, no ? If this change is introduced not for the proper use, i'm not sure it's a good idea.. Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:43:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:43:36 +0000 Subject: [Koha-bugs] [Bug 10271] An index containing ns or nb does not work In-Reply-To: <bug-10271-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10271-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10271-70-afQp8ewFIx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 18191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18191&action=edit Proposed patch See commit message. I know there is a work on QueryParser but this patch is very small. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:43:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:43:43 +0000 Subject: [Koha-bugs] [Bug 10271] An index containing ns or nb does not work In-Reply-To: <bug-10271-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10271-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10271-70-5zplktm45l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10271 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:46:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:46:22 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-pumQgiCWEL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #35 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- In Rennes 2, we agree the default behavior MUST be changed, and we are fine with this patch being pushed in master. The only remark is that MAYBE it could be useful for a lib, or the chief librarian responsible for acquisitions to see all baskets. But not everyday ;-) And we could add new possibilities for filtering and sorting baskets (for ex. sorting by date, showing only open baskets etc). Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:51:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:51:07 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9593-70-DosPjXwvGs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #25 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- My 1st test, just to check the new behavior of currency module => seems ok My test plan: 1. $perl installer/data/mysql/updatedatabase.pl Upgrade to 3.11.00.XXX done (Added isocode to the currency table) 2. going to admin/currency.pl page : there is a new column for iso code => ok 3. editing my two currencies (euro and dollar) to add iso codes (EUR and USD) => ok 4. adding a new currency (sterling pound) with symbol ? and iso code GBP => ok 5. suppressing a currency => ok 6. changing the active currency => ok I am now testing the import of marc record Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:54:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:54:50 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: <bug-10241-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10241-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10241-70-eIw0PeNgW9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I've just been going through the options and if my understanding is correct it would appear there's been a regression somewhere. I'm sure it used to be that when you enabled EasyAnalytics, then the 'Analyze items' menu option replaced 'New child record' as an option under the 'New' menu in a record display. With both options present it's very easy to get confused between the two different mutually exclusive procedures for creating analytics. However.. I do think we should be able to enhance the functionality such that the options are no longer mutually exclusive. I'll open another bug for this as an enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:56:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:56:39 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-rucr7K9r9H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18188|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18192&action=edit Bug 10270: GetOrdersByBiblionumber needs better unit tests prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:57:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:57:13 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-eTI4fvcwgy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> --- typo in the last patch: -use C4::Biblio qw( AddBiblio ); +use C4::Biblio; [...] -( undef, $ordernumber2 ) = C4::Acquisition::NewOrder( +( undef, $ordernumber3 ) = C4::Acquisition::NewOrder( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:58:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:58:40 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-MhJY8LzDAo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 --- Comment #8 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- However, it worked. Need to be tested again? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 14:59:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 12:59:23 +0000 Subject: [Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml In-Reply-To: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9531-70-k61zCs2n3A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15204|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18193&action=edit Bug 9531 - Make SIP2 message terminator configurable via SIPconfig.xml Add a delimeter option to SIPConfig.xml, choices for 'delimeter' are 'CR' or 'CRLF'. The default continues to be 'CRLF' if 'delimeter' is undefined. Test Plan: 1) Apply patch 2) Start SIP server 3) Run C4/SIP/t/04patron_status.t 4) Stop SIP server 5) Add terminator="CR" for account login 'term1' 6) Run 04patron_status.t again, you should see no change Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr> Make sense. With this patch, starting 2 SIP2 servers, it is possible to serve heterogeneous Self check devices. Shouldn't we need some doc somewhere about this parameter? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:01:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:01:11 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-8a7E0wJUp4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 --- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> --- Needs SO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:03:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:03:50 +0000 Subject: [Koha-bugs] [Bug 10273] New: Unit tests should not be dependent on the Jenkins database Message-ID: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Bug ID: 10273 Summary: Unit tests should not be dependent on the Jenkins database Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com This report is an omnibus. The idea is to have a test suite to launch on any instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:04:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:04:12 +0000 Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database In-Reply-To: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10273-70-L3YpcZVrlv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:08:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:08:05 +0000 Subject: [Koha-bugs] [Bug 10274] New: UT: Acquisition.t needs to create its own data Message-ID: <bug-10274-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Bug ID: 10274 Summary: UT: Acquisition.t needs to create its own data Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com t/db_dependent/Acquisition.t depends on the Jenkins database. We should create the data we want and delete them at the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:08:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:08:18 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: <bug-10274-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10274-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10274-70-I3ZFpUlWsR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10273 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:08:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:08:18 +0000 Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database In-Reply-To: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10273-70-iS5hhGyKox@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10274 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:09:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:09:27 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: <bug-10274-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10274-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10274-70-KLGiQdN146@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10270 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:09:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:09:27 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-rmq3O3X0Xe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10274 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:11:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:11:23 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7560-70-Phz15NzXVe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16044|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18194&action=edit Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books Add checks in C4::ILS::Patron and C4::ILS::Transaction::Renew to make sure the patron is below the noissuescharge system pref for issues and OPACFineNoRenewals for renewals. Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:11:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:11:34 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7560-70-C2W7nefJhh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16045|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18195&action=edit Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:11:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:11:44 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7560-70-0cmrwpOFxN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16048|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18196&action=edit Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:13:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:13:15 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: <bug-10274-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10274-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10274-70-SbuU6XhUOe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18197&action=edit MT10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:13:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:13:29 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: <bug-10274-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10274-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10274-70-KOmJpWuBMi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:13:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:13:37 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7560-70-1cJpLkbo44@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:13:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:13:38 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7560-70-s9rUdjia5d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18196|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18198&action=edit Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:14:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:14:50 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7560-70-TsBufYtB87@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18198|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18199&action=edit Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:15:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:15:14 +0000 Subject: [Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books In-Reply-To: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7560-70-37lA2jZLhE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18199|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18200&action=edit Bug 7560 - SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books - QA Followup 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:20:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:20:15 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9593-70-JlpSAzEKZB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #26 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Following of my test : add currencies matching codes and symbols in your records CANADA 1.00000 $ CAN DOLLAR 1.00000 $ USD EGYPT 1.00000 ?E EGP EUR 1.00000 ? EUR KENYAN SHI 1.00000 KSh KES LIVRE 1.00000 ? GBP YEN 1.00000 ? JPY (CAN should be CAD I suppose, but this is cosmetic) active currency : EUR Checking 010$d fields of your records in with yaz-marcdump. Staging records Filling a basket with staged records, selecting currency : EUR. Checking content of the basket : A hauteur d'homme / Rousseau et l'?criture de soi by Lionel Bourg <subfield code="d">75.40 EUR, 93.5 USD, 20 250 EGP</subfield> RRP tax exc : 75.40 A la conqu?te du Graal by Alicia Bekhouche <subfield code="d">$44, 23 ?, 64 Br,?30</subfield> RRP tax exc : 23.00 Bernanos et les {copy}ages de la vie / actes du colloque d'Aix-en-Provence, 23, 24, 25 octobre 2008 by sous la direction de Andr? Not <subfield code="d">25,5 EUR, $US32, $LD35</subfield> RRP tax exc : 25.50 Chateaubriand et la gravit? du comique by Fabio Vasarri <subfield code="d">38 Ksh, ?300, $62</subfield> RRP tax exc : 0 (uncertain) Ecrire la sculpture, XIXe-XXe si?cles / actes du colloque organis? ? l'Ecole normale sup?rieure et ? la Maison de la recherche du 16 au 18 juin 2011 by sous la direction d'Ivanne Rialland <subfield code="d">32 EUR, 45$ CAN, 46$ USD</subfield> RRP tax exc : 32.00 => problem with "Chateaubriand et la gravit? du comique". But I suppose we would never find such thing as "38 Ksh, ?300, $62" in 010$d (more likely "Ksh38, ?300, $62", or "38 Ksh, 300?, 62$"). I will make other tests later Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:26:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:26:54 +0000 Subject: [Koha-bugs] [Bug 10275] New: UT: OrderFromSubscription.t needs to create its own data Message-ID: <bug-10275-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 Bug ID: 10275 Summary: UT: OrderFromSubscription.t needs to create its own data Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com t/db_dependent/Acquisition/OrderFromSubscription.t depends on the Jenkins database. We should create the data we want and delete them at the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:27:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:27:23 +0000 Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database In-Reply-To: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10273-70-MISsyva9kB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10275 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:27:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:27:23 +0000 Subject: [Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data In-Reply-To: <bug-10275-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10275-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10275-70-gAB4zhfjau@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10273 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:29:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:29:16 +0000 Subject: [Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data In-Reply-To: <bug-10275-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10275-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10275-70-UiL2EfI5uP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18201&action=edit MT10275: UT: OrderFromSubscription.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition/OrderFromSubscription.t And after, it should produce: t/db_dependent/Acquisition/OrderFromSubscription.t .. ok All tests successful. Files=1, Tests=12, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.02 csys = 0.50 CPU) Result: PASS And some warnings... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:29:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:29:14 +0000 Subject: [Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data In-Reply-To: <bug-10275-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10275-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10275-70-iBj38KNn74@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:32:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:32:21 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-xseJynR4We@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18192|0 |1 is obsolete| | --- Comment #10 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Created attachment 18202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18202&action=edit [SIGNED OFF][PATCH] Bug 10270: GetOrdersByBiblionumber needs better unit tests Tested again. The 2 test files Acquisition/GetOrdersByBiblionumber.t and Acquisition.t are successful. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:32:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:32:28 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-l7Z9mInolq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:51:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:51:44 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9288-70-mmwW7nFDpp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:51:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:51:45 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9288-70-z0HXkwrfSY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14640|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18203&action=edit Bug 9288 - Add a script to test SIP from the command line This is a very basic start to a sip server testing script. I imagine we will want to make it interactive in end, essentially replicating what a SIP based self-checkout machine does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 15:55:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 13:55:16 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9593-70-NSSy98kehF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #27 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Hey Mathieu, My god, you are everywhere ! fallen in a magic potion barrel when a baby ? As for Chateaubriand case, it's a normal result with euro as active currency because there's no euro currency in the string price '38 Ksh, ?300, $62' As I 'd mentionned : Whenever active currency is enabled and neather the symbol nor the isocode of this currency is found in the price string, the resulting price is set to 0 (rather than picking the first one by default). I did this knowingly to make clear that no price has been picked. If first price would be picked, in your test context,38 would be the resulting price and we could think it's in euro. Olivier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:18:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:18:57 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-OOVv97PTNZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #11 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Jonathan, a question about: +++ b/t/db_dependent/Acquisition/GetOrdersByBiblionumber.t @@ -0,0 +1,84 @@ +#!/usr/bin/env perl Why use env perl instead of perl? Note that we only use env perl in 6 Koha files (2 in the test directory t). I understand that it is more portable. But then we should do it more often.. All our scripts contain the fixed perl path. Just for consistency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:34:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:34:20 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-qfzvjRNsEl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- QA: Looking at this one now.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:37:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:37:42 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-SOGAZMX1n4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Kyle, This works fine. Two questions remain: 1) To have this work, you currently do not need to do a use C4::Koha. Without that line, it works too. Why did you add it? 2) If it can be removed, please repair the typo: replated-> related :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:43:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:43:27 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9593-70-v9eBK6n6rU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #28 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I did not read all your description, I must confess ;-) Not sure to agree with this behavior if it is a new one. I think it should be : - in Koha, 3 currencies = euros ?, dollar $, pound ? ; and active currency = euro - in 010 : 40 ?, 50 $ => 40 ? - in 010 : 50 $ => convert 50 $ in ? using the exchange rate defined in Koha - in 010 : 50 $, 60 ? => convert 50 $ in ? using the exchange rate defined in Koha (? should be ignored, as ? is not defined in Koha list of currencies) - in 010 : 60 ? => 0 (undefined) (? should be ignored, as ? is not defined in Koha list of currencies) - in 010 : 50 $, 30 ? => 2 solutions : - either 0 (undefined) - or maybe convert the first price of the list in euros, using exchange rate What's your opinion? Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:47:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:47:37 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-9nRxz52iww@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #18 from Owen Leonard <oleonard at myacpl.org> --- I'm sorry to say that this doesn't apply anymore. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:56:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:56:10 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-P9ilTXQOPz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Maxime Pelletier <pelletiermaxime at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pelletiermaxime at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:56:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:56:49 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7710-70-w2JY9T5zML@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Maxime Pelletier <pelletiermaxime at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pelletiermaxime at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:57:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:57:24 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-J5bAUN9CrY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 --- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #11) > Jonathan, a question about: > > +++ b/t/db_dependent/Acquisition/GetOrdersByBiblionumber.t > @@ -0,0 +1,84 @@ > +#!/usr/bin/env perl > > Why use env perl instead of perl? Note that we only use env perl in 6 Koha > files (2 in the test directory t). > I understand that it is more portable. But then we should do it more often.. > All our scripts contain the fixed perl path. > Just for consistency. There is no specific reason, I thought it is a good practice. A patch coming... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:58:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:58:09 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-ZIxjljSIqS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 --- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18204&action=edit Bug 10270: Fix shebang Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:59:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:59:14 +0000 Subject: [Koha-bugs] [Bug 10276] New: Extend IndependentBranches to support groups of libraries Message-ID: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Bug ID: 10276 Summary: Extend IndependentBranches to support groups of libraries Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:59:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:59:31 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-cW3VaDvbeZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 --- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Well, just to harass you a little bit more :) Why do you add use Template::Plugin btw? The use base seems to be enough? And could we find a better and still generic name for Koha.pm? I do not directly have the solution.. But just thinking about KohaInterface, Functions, GeneralPurpose, .., .. But we could start with Koha. Just trying to avoid it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:59:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:59:32 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-lsBANd77bz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10090, 10206 Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:59:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:59:32 +0000 Subject: [Koha-bugs] [Bug 10090] the ordered and spent page display the itemtype code In-Reply-To: <bug-10090-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10090-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10090-70-qR6hKKSAgZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10276 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 16:59:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 14:59:32 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-8h56GHeYxj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10276 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:00:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:00:20 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-WT77EjvcBE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:00:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:00:21 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-6jJhPny6p8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18205&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:01:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:01:30 +0000 Subject: [Koha-bugs] [Bug 10277] New: Add C4::Context->IsSuperLibrarian() Message-ID: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Bug ID: 10277 Summary: Add C4::Context->IsSuperLibrarian() Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com The method of checking the logged in user for superlibrarian privileges is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least. The codebase is littered with these lines, with no explanation given. It would be much better if we had one subroutine that returned a boolean value to tell us if the logged in user is a superlibrarian or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:02:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:02:02 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-YvY0IVZ663@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18206&action=edit Bug 10277 - Add C4::Context->IsSuperLibrarian() The method of checking the logged in user for superlibrarian privileges is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least. The codebase is littered with these lines, with no explanation given. It would be much better if we had one subroutine that returned a boolean value to tell us if the logged in user is a superlibrarian or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:05:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:05:44 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-FYFeTmkDjk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:07:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:07:53 +0000 Subject: [Koha-bugs] [Bug 10278] New: Add ability to hide items and records from search results for Independent Branches Message-ID: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Bug ID: 10278 Summary: Add ability to hide items and records from search results for Independent Branches Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com IndependentBranches will hide other library's patrons, and limit editing of items, but it does not hide the items the way it hides library patrons. This new preference would do just that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:08:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:08:18 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10278-70-gAmVSheeMP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10277, 10276 Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:08:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:08:18 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-RCuA2NsLw4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10278 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:08:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:08:18 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-bpKV6Y8X1n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10278 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:08:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:08:30 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-fcjrXjtuFA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:09:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:09:32 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10278-70-3lRhjU3kzo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18207&action=edit Bug 10278 - Add ability to hide items and records from search results for Independent Branches For the staff intranet, enabling IndependentBranchesRecordsAndItems will automatically add a branch limit filter to the search results thus hiding all records without one or more items owned by the logged in library. In add addition, all items whose homebranch is not that libraries will be filtered and hidden from the search results and record details. This system preference will not affect the OPAC, unless the environment variable BRANCHCODE is defined in the koha-httpd.conf file. If it is defined, the same filters are applied to the OPAC, but based on the branchcode value of the environment variable BRANCHCODE, rather than the logged in branch. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Perform a search that will give results for both records which have items owned by the logged in library, and records which have no items owned by the logged in library. 4) Enable the new system preference IndependentBranchesRecordesAndItems 5) Perform the same search again, any records without items owned by the currently logged in library should not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:09:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:09:44 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10278-70-bR4WkTmygb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:18:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:18:21 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10272-70-IU5CE90WXm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18190|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18208&action=edit Bug 10272 - CheckReserves returns not respecting ReservesControlBranch CheckReserves is using the CircControl system preference to determine what patrons an item can fill a hold for. It should be using ReservesControlBranch instead. Test Plan: 1) Create an item at Library A, place holds for it for patrons at Library B, Library C, and Library A in that order, for pickup at the patrons home library. 2) Make sure the holds policy for Library A is set to Hold Policy = "From home library" and Return Policy = "Item returns home". Make sure the holds policies for the other libraries are set to Hold Policy = "From any library". 3) Check the item in at Library C, the hold for the patron at Library B should pop up, even though it's in violation of the circulation rules. Don't click the confirm button! 4) Apply this patch, and reload the page, now the hold listed should be for the last hold, the hold for the patron at Library A, which is correct. This patch adds the subroutine C4::Reserves::GetReservesControlBranch as an equivilent to C4::Circulation::_GetCircControlBranch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:23:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:23:16 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-gjRrPvf3Sn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |MARC Bibliographic data | |support Version|3.10 |master Assignee|oleonard at myacpl.org |gmcharlt at gmail.com Summary|830 needs spaces in opac |830 needs spaces in XSLT |display |display --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- I can reproduce this in master in both the OPAC and staff client but where this is happening in the xsl file I do not know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:38:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:38:26 +0000 Subject: [Koha-bugs] [Bug 10264] amazon cover not showing on results, but is on details In-Reply-To: <bug-10264-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10264-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10264-70-sNX3RmXlag@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10264 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- This appears to be a problem with this particular ISBN on Amazon's side. They seem to have no smaller version of the cover. On the results page Koha tries to load the slightly smaller version and fails to find one: http://images.amazon.com/images/P/030726999X.01.TZZZZZZZ.jpg On the detail page Koha tries to load a larger one and finds it: http://images.amazon.com/images/P/030726999X.01.MZZZZZZZ.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 17:41:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 15:41:49 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-1tGbUmqBIs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #36 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Default should probably include the open baskets too, that could be excluded in the current change (as noted in the QA comment) if they have no order lines or if it is reopened but everything is received. A simple link to remove this default filter (and thus show all) might be a way to prevent the need of reverting this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:03:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:03:17 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-GST3r5YN9S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|3.10 |master Summary|On pay fines tab patron |Link to patron files |tabs are missing |missing from circ-menu.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:10:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:10:50 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-wWGQwmRsIB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18209&action=edit Bug 10261 - Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The "Files" tab should appear in the left-hand sidebar menu. Other patron pages should show the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:10:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:10:49 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-xVId2Y79kr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:12:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:12:17 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9252-70-bPUS3NlnuU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:12:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:12:30 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9252-70-CEGzY9jbUq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13977|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:12:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:12:37 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9252-70-dvjMW7ygRh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 18210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18210&action=edit Bug 9243: Bad delete order in sub index-records If we have in the zebraqueue table for the same record, one line "update" and another "delete", the index_records sub in rebuild_zebra.pl treats the delete line first. The result is that the record still exists in zebra. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:13:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:13:17 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9252-70-qWjKQZyamO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #9 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by George Williams <georgew at latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:13:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:13:30 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9252-70-ttMRhfwzBe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18210|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:13:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:13:35 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9252-70-fq8sNaWsY9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 18211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18211&action=edit Bug 9243: Bad delete order in sub index-records If we have in the zebraqueue table for the same record, one line "update" and another "delete", the index_records sub in rebuild_zebra.pl treats the delete line first. The result is that the record still exists in zebra. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> http://bugs.koha-community.org/show_bug.cgi?id=9252 Signed-off-by: George Williams <georgew at latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:14:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:14:00 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9252-70-9Jw2SYjAlk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18211|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:14:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:14:29 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9252-70-XmG2g4QGMX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13977|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:15:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:15:32 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9252-70-sX3aelPKCT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #11 from Christopher Brannon <cbrannon at cdalibrary.org> --- My name is Christopher Brannon with the Coeur d'Alene Public Library, and we have tested the patch and can verify that the patch works as intended. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:16:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:16:08 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9252-70-1nbhd56VbI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 --- Comment #12 from Christopher Brannon <cbrannon at cdalibrary.org> --- My name is Christopher Brannon with the Coeur d'Alene Public Library, and we have tested the patch and can verify that the patch works as intended. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:19:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:19:59 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9252-70-zSVnlTkIYv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13977|0 |1 is obsolete| | --- Comment #13 from Melia Meggs <melia at bywatersolutions.com> --- Created attachment 18212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18212&action=edit [Signed off] Bug 9252 - Add option to send patron's home branch in AF field This patch gives you the option of sending a patrons home branch code in an AF field for patron status requests. It is controlled at the account login level, so it can be enable on a per-sip-login basis. Test Plan: 1) Apply patch 2) Edit SIPconfig.xml, add the parameter 'send_patron_home_library_in_af="1"' to the login you will be using to test. 3) Start your SIP2 server. 4) Connect to it via telnet ( something like: '9300CNterm1|COterm1|CPCPL|' ) 5) Send a patron status request ( like: '2300120121110 82925AOCPL|AA23529000035676|ACterm1|ADletmein' ) 6) Examine reponse you should see something like this: "24 00120121210 085332AEHenry Acevedo|AA23529000035676|BLY|CQN|AFGreetings from Koha. |AFMPL|AO|" Note the second AF field with the value MPL. Signed-off-by: George Williams <georgew at latahlibrary.org> Signed-off-by: Christopher Brannon <cbrannon at cdalibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:20:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:20:22 +0000 Subject: [Koha-bugs] [Bug 10279] New: Link to routing lists missing from circ-menu.tt in 3.10.x Message-ID: <bug-10279-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10279 Bug ID: 10279 Summary: Link to routing lists missing from circ-menu.tt in 3.10.x Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org The link to routing lists doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:20:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:20:56 +0000 Subject: [Koha-bugs] [Bug 9252] Add option to send patron's home branch in AF field In-Reply-To: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9252-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9252-70-akYRdLDn0b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9252 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia at bywatersolutions.com --- Comment #14 from Melia Meggs <melia at bywatersolutions.com> --- This patch was tested by George and Christopher. They have verified it works, so I am signing it off on their behalf. (We had some weirdness trying to use the sandbox.) Thanks, Melia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:35:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:35:39 +0000 Subject: [Koha-bugs] [Bug 10279] Link to routing lists missing from circ-menu.tt in 3.10.x In-Reply-To: <bug-10279-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10279-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10279-70-1GiRHWqbdh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10279 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This bug can be fixed by applying Bug 9917 to 3.10.x. It applies cleanly. *** This bug has been marked as a duplicate of bug 9917 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:35:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:35:39 +0000 Subject: [Koha-bugs] [Bug 9917] Routing list tab on patron account should depend on syspref/permission In-Reply-To: <bug-9917-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9917-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9917-70-KF51SUwIRW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9917 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 10279 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 18:44:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 16:44:51 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-AweiEb6h1i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- See Bug 9917 for the solution to the problem with the routing lists link. I can't reproduce the problem with the statistics link in master or 3.10.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 19:00:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 17:00:04 +0000 Subject: [Koha-bugs] [Bug 9558] Customize CSS for mobile In-Reply-To: <bug-9558-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9558-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9558-70-IJ5WgnRmjY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9558 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Isn't this what the OPACMobileUserCSS system preference is for? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 19:05:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 17:05:09 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-DIGBCrnBHs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16669|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18213&action=edit Bug 2720 - Overdues which debar automatically should undebar automatically when returned This patch adds a more extensible and flexible debarments system to Koha. The fields borrowers.debarred and borrowers.debarredcomment are retained for compatibility and speed. This system supports having debarments for multiple reasons. There are currently three types of debarments: OVERDUES - Generated by overdue_notices.pl if the notice should debar a patron SUSPENSION - A punative debarment generated on checkin via an issuing rule MANUAL - A debarment created manually by a librarian OVERDUE debarments are cleared automatically when all overdue items have been returned, if the new system preference AutoRemoveOverduesRestrictions is enabled. It is disabled by default to retain current default functionality. Whenever a borrowers debarments are modified, the system updates the borrowers debarment fields with the highest expiration from all the borrowers debarments, and concatenates the comments from the debarments together. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the borrower_debarments table has been created and populated with the pre-existing debarments 4) Run t/db_dependent/Borrower_Debarments.t 5) Manually debar a patron, with an expiration date 6) Verify the patron cannot be issued to 7) Add another manual debarment with a different expiration date 8) Verify the 'restricted' message lists the date farthest into the future 9) Add another manual debarment with no expiration date 10) Verify the borrower is now debarred indefinitely 11) Delete the indefinite debarment 12) Verify the debarment message lists an expiration date dagain 13) Enable the new system preference AutoRemoveOverduesRestrictions 14) Set an overdue notice to debar after 1 day of being overdue 15) Check out an item to a patron and backdate the due date to yesterday 16) Run overdue_notices.pl 17) Verify the OVERDUES debarment was created 18) Return the item 19) Verify the OVERDUES debarment was removed 20) Disable AutoRemoveOverduesRestrictions 21) Repeat steps 15 though 18, verify the OVERDUES debarment was *not* removed 22) Add issuing rules so that an overdue item causes a temporary debarment 23) Check out an item to a patron and backdate the due date by a year 24) Return the item 25) Verify the SUSPENSION debarment was added to the patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 19:05:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 17:05:08 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-ACYcgtc2FU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 19:06:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 17:06:10 +0000 Subject: [Koha-bugs] [Bug 7691] normal results showing multiple copies individually In-Reply-To: <bug-7691-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7691-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7691-70-gmg8AKyF7m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7691 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- I don't see this problem in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 19:11:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 17:11:42 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-b0xAU36dWf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #37 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18214&action=edit Bug 9824: Followup for removing filter Adds allbaskets parameter to GetBasketsInfosByBookseller. (Only used in booksellers.pl now) Normally, all 'active' baskets are shown. With allbaskets=1 all baskets :) In the template I had to rename a loop var supplier to supplier1 to resolve name conflict between template vars. In the template I added the string: Cancel filter. Note that this string is already translated: msgid "Cancel filter" msgstr "" Hope this helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 19:13:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 17:13:10 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-tVkKxCZwuX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #38 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- This *trick* would not really involve a string change (for emphasis). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 19:17:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 17:17:02 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-i217KLyAt8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion --- Comment #39 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- I would be satisfied with that change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 19:17:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 17:17:12 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-9haCKZnQvO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 19:24:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 17:24:42 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-LuPlnan0kz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #40 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Still found a little issue with my change: sometimes supplier contains the search string, but sometimes the bookseller id numeric already. Will have a quick look :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 19:28:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 17:28:49 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-1hyiwIF8gK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18214|0 |1 is obsolete| | --- Comment #41 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18215&action=edit Bug 9824: Followup for removing filter Adds allbaskets parameter to GetBasketsInfosByBookseller. (Only used in booksellers.pl now) Normally, all 'active' baskets are shown. With allbaskets=1 all baskets :) In the template I had to rename a loop var supplier to supplier1 to resolve name conflict between template vars. In the template I added the string: Cancel filter. Note that this string is already translated: msgid "Cancel filter" msgstr "" Hope this helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 19:29:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 17:29:23 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basqket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-6BtTYDurTs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #42 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #40) > Still found a little issue with my change: sometimes supplier contains the > search string, but sometimes the bookseller id numeric already. Resolved: added both ways in the url. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 19:41:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 17:41:39 +0000 Subject: [Koha-bugs] [Bug 9558] Customize CSS for mobile In-Reply-To: <bug-9558-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9558-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9558-70-8nUw57FrFl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9558 --- Comment #2 from Zachary Spalding <spalding at senylrc.org> --- The problem with OPACMobileUserCSS from my understanding is a global change. In my case I have 15 organizations that are sharing one Koha instance but each want there own look. We the opac.css override I am able to do that for the average computer use and but now need a way to do this for mobile as well. I did come up with my own modifications to solve this problem but do not know enough on how to submit it for inclusion into the Koha code. Changed Auth.pm Around line 412 to add support for multiple css for mobile devices opac_css_override_mobile => $ENV{'OPAC_CSS_OVERRIDE_MOBILE'}, Changed doc-head-close.inc Around line28 [% IF ( opac_css_override_mobile ) %] <link rel="stylesheet" type="text/css" media="screen and (max-width:700px)" href="[% themelang %]/css/[% opac_css_override_mobile %]" /> [% END %] These are my productions examples http://vassar.koha.senylrc.org http://hhs.koha.senylrc.org http://nki.koha.senylrc.org/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 19:42:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 17:42:51 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-1cZmrRN4Xg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hide basket with no |Hide basket with no |expected items in basqket |expected items in basket |list by bookseller |list by bookseller --- Comment #43 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- My last action for today on Bugzilla will be: eliminate this typo basqket in the title of this great report :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 20:27:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 18:27:19 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-1wfXsmzdTR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18216&action=edit Bug 9394 - Use reserve_id where possible - Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 20:29:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 18:29:06 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7710-70-QYifAsgqBU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17448|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18217&action=edit Bug 7710 - multiple holds per title Adds the ability to allow multiple holds on the same record for the same borrower. Adds new system preference MaxHoldsPerRecord, which controls how many holds one person can have on items for the same record. Test Plan: 1) Apply patch for Bug 9394 2) Apply this patch 3) Run updatedatabase.pl 4) Attempt to place 2 holds for the same patron on the same record, you should not be able to ( default is 1 per record ) 5) Set MaxHoldsPerRecord to 3 6) Attempt to place multiple holds for one patron on one record, you should be able to place 3 holds for one patron on a given record. A 4th hold should result in a message stating the patron has placed the max number of holds allowed on this record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 20:30:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 18:30:15 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7710-70-eJmaCtCtsV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #45 from Kyle M Hall <kyle.m.hall at gmail.com> --- I've taken the needed lines, moved them to a followup on 9394, and removed them from this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 20:31:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 18:31:00 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-Y4d9touVTc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #23 from Kyle M Hall <kyle.m.hall at gmail.com> --- Followup adds the lines from 7710 that needed to be in this patch set instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 20:35:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 18:35:33 +0000 Subject: [Koha-bugs] [Bug 9558] Customize CSS for mobile In-Reply-To: <bug-9558-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9558-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9558-70-Nav9iY26fK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9558 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 20:35:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 18:35:35 +0000 Subject: [Koha-bugs] [Bug 9558] Customize CSS for mobile In-Reply-To: <bug-9558-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9558-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9558-70-g2Z3HOlkAt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9558 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18218&action=edit Bug 9558 - Customize CSS for mobile It is possible to use an environment variable to specify a custom stylesheet for different libraries in a multi-library system: $ENV{'OPAC_CSS_OVERRIDE'}. This patch adds an additional option to override the CCSR theme's mobile stylesheet. To test: - Create a custom stylesheet and add it alongside CCSR's other CSS files. - Add a simple CSS rule which will be obvious in testing. For example: form#searchform { background-color: red; } - Modify the configuration file for your OPAC to add a line specifying a new custom stylesheet: SetEnv OPAC_CSS_OVERRIDE_MOBILE <name of CSS file> - Restart Apache. - Switch the OPAC theme to 'CCSR' - Clear your browser cache - View any page in the OPAC. If you browser is wider than 700 pixels the OPAC should appear normal. Below 700 pixels wide you should see your custom CSS applied (a red background on the search bar if you used the above example. The changes in this patch are courtesy Zachary Spalding as described in Bug 9558. Patch and test plan created by Owen Leonard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 20:41:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 18:41:56 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-xFtpRogwTc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Good news - you really tricked the translation scripts! Now it would be perfect if we could make a link 'Apply filter' show up after clicking the link for the first time... looking into it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 21:18:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 19:18:39 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-4l7an2VBML@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18184|0 |1 is obsolete| | Attachment #18215|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18219&action=edit [SIGNED OFF] Bug 9824: Followup for removing filter Adds allbaskets parameter to GetBasketsInfosByBookseller. (Only used in booksellers.pl now) Normally, all 'active' baskets are shown. With allbaskets=1 all baskets :) In the template I had to rename a loop var supplier to supplier1 to resolve name conflict between template vars. In the template I added the string: Cancel filter. Note that this string is already translated: msgid "Cancel filter" msgstr "" Hope this helps. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Undoing the filter works and I checked that the string gets translated with the po files in current master. So this is almost perfect, only we can't apply the filters again and the link remains 'cancel' when we already did. Sending a follow-up trying to fix this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 21:18:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 19:18:54 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-KcEC6VtWj1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #46 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18220&action=edit Bug 9824: Make it possible to apply/cancel switch Using another existing string 'Apply filter' we are now able to cancel the filter... and apply it... and cancel it again... and so on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 21:27:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 19:27:15 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-h9v9yVxLqQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 17 21:27:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 17 May 2013 19:27:17 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-qNbJFojduh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18220|0 |1 is obsolete| | --- Comment #47 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18221&action=edit [SIGNED-OFF] Bug 9824: Make it possible to apply/cancel switch Using another existing string 'Apply filter' we are now able to cancel the filter... and apply it... and cancel it again... and so on. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 09:34:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 07:34:09 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-8hvzR0fk9u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 09:34:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 07:34:31 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-aLnxXwSrnc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Signed off by packaging manager and packages related... passing QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:05:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:05:46 +0000 Subject: [Koha-bugs] [Bug 6802] with IndependantBranches on can still edit items In-Reply-To: <bug-6802-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6802-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6802-70-IFZBVHpFPd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6802 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |magnus at enger.priv.no Resolution|--- |DUPLICATE --- Comment #5 from Magnus Enger <magnus at enger.priv.no> --- Looks like this has been fixed on bug 10225. *** This bug has been marked as a duplicate of bug 10225 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:05:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:05:46 +0000 Subject: [Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu In-Reply-To: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10225-70-RKPOgu8G04@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 --- Comment #6 from Magnus Enger <magnus at enger.priv.no> --- *** Bug 6802 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:08:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:08:50 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-5vFbFnYXz4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:08:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:08:53 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-anFK0Hv4TP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18202|0 |1 is obsolete| | Attachment #18204|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18222&action=edit [PASSED QA] Bug 10270: GetOrdersByBiblionumber needs better unit tests prove t/db_dependent/Acquisition/GetOrdersByBiblionumber.t Signed-off-by:Mathieu Saby <mathieu.saby at univ-rennes2.fr> I made 2 tests : $prove -v t/db_dependent/Acquisition/GetOrdersByBiblionumber.t and $prove -v t/db_dependent/Acquisition.t The 2 tests are successful. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> All tests and QA script pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:09:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:09:03 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-Coh2ZZmWkM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18223&action=edit [PASSED QA] Bug 10270: Fix shebang Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:12:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:12:40 +0000 Subject: [Koha-bugs] [Bug 10280] New: Extend SeparateHoldings functionality to the "Add items" screen Message-ID: <bug-10280-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10280 Bug ID: 10280 Summary: Extend SeparateHoldings functionality to the "Add items" screen Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at enger.priv.no CC: gmcharlt at gmail.com If you have IndependantBrnaches turned on, the table of items at the top of the "Add items" screen still displays all the items from all the libraries (with the Edit/Delete links missing for the items that belong to other libraries then the library of the logged in user). This can be a long and not very useful list if there are a lot of libraries and copies. It would be nicer if this display was governed by the SeparateHoldings syspref, and items from other libraries were e.g. put in a second tab (so they are available to look at, but not "in your face" immediately). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:18:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:18:10 +0000 Subject: [Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma' In-Reply-To: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6399-70-JcBRR4P0A4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This works on the results and details screen for tagging a single record. We also have options for tagging in the cart, the lists and in the result list menu - maybe we should add a hint there too? I like the initial idea of a tooltip, but I agree that on the detail pages having it directly in the label is more obvious. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:19:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:19:04 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-0WsNOW4N7N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18176|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18224&action=edit [PASSED QA] Bug 6399 - tooltip for tags that says 'separate by comma' Some sites split tags on spaces, some on commas. Since Koha splits on a comma, we should make that clear to the patron. This patch adds additional text to the "New tag(s)" label. To test, enable TagsEnabled, TagsInputOnDetail, and TagsInputOnList. Click "Add tag" on both OPAC search results and an OPAC detail page. Confirm that the revised label appears correctly. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> all tests pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> All tests pass. There are some more places where we can add tags to multiple records at once, I noted them on the bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:19:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:19:02 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-2nUrfXxruI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:19:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:19:28 +0000 Subject: [Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma' In-Reply-To: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6399-70-WBGJYGHsKf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:20:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:20:06 +0000 Subject: [Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma' In-Reply-To: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6399-70-Vl0kMQvTr7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:20:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:20:08 +0000 Subject: [Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma' In-Reply-To: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6399-70-2aSoLm7sqT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18150|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18225&action=edit [PASSED QA] Bug 6399 - tooltip for tags that says 'separate by comma' Some sites split tags on spaces, some on commas. Since Koha splits on a comma, we should make that clear to the patron. This patch adds additional text to the "New tag(s)" label. To test, enable TagsEnabled, TagsInputOnDetail, and TagsInputOnList. Click "Add tag" on both OPAC search results and an OPAC detail page. Confirm that the revised label appears correctly. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> all tests pass Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> All tests pass. There are some more places where we can add tags to multiple records at once, I noted them on the bug. http://bugs.koha-community.org/show_bug.cgi?id=10259 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:20:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:20:38 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-rAkNsYA5il@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18176|1 |0 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 18176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18176 Bug 10259 - koha-*-zebra scripts are expected to run without warnings if no instance name passed Sorry, had the wrong bug number. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:20:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:20:51 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-jNlOcoLj3z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18224|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 10:37:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 08:37:41 +0000 Subject: [Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page In-Reply-To: <bug-10249-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10249-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10249-70-MiiqZ0ebxJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 12:09:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 10:09:03 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-EqnO1kE1in@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 12:14:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 10:14:20 +0000 Subject: [Koha-bugs] [Bug 10270] GetOrdersByBiblionumber needs better unit tests In-Reply-To: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10270-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10270-70-dz8KOuRmvN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10270 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 13:32:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 11:32:13 +0000 Subject: [Koha-bugs] [Bug 10281] New: Search domains do not seem to work Message-ID: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Bug ID: 10281 Summary: Search domains do not seem to work Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: magnus at enger.priv.no I added two libraries and added them to a search domain (with code "NARVIK"). One of them owns "The hobbit" and the other owns "Lord of the rings". - When I search for "hobbit" in the first library I get one hit as expected. - When I search for "rings" in the second library I also get one hit as expected. - When I search for "tolkien" in the group I get no results. - When I search for "hobbit" or "rings" in the group I get no results. - When I search for "tolkien" in "all libraries" I get two hits, as expected. Are search domains (a.k.a "search groups of libraries") broken or is there some missing config step? The documentation does not seem to mention anything of that sort. The URLs for the search limited to the search domain looks like this: OPAC, simple search (with OpacAddMastheadLibraryPulldown activated): /cgi-bin/koha/opac-search.pl?q=tolkien&branch_group_limit=multibranchlimit-NARVIK OPAC, advanced search: /opac-search.pl?idx=kw&q=tolkien&idx=kw&idx=kw&do=S?k&multibranchlimit=NARVIK&sort_by=relevance Intranet search: /cgi-bin/koha/catalogue/search.pl?idx=kw&q=tolkien&idx=kw&idx=kw&multibranchlimit=NARVIK&sort_by=relevance I have tried a full "sudo koha-rebuild-zebra -f -v <instancename>", but that did not change anything. Tested on 3.12 rc2 package install, no memcached or anything else fancy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 14:05:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 12:05:49 +0000 Subject: [Koha-bugs] [Bug 10281] Search domains do not seem to work In-Reply-To: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10281-70-0Ojufccd8Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 --- Comment #1 from Magnus Enger <magnus at enger.priv.no> --- Here are the errors I get when I limit to a group and get no results: OPAC, simple search: [Sat May 18 14:04:01 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:01 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkien&branch_group_limit=multibranchlimit-NARVIK [Sat May 18 14:04:01 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:01 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 39., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkien&branch_group_limit=multibranchlimit-NARVIK [Sat May 18 14:04:01 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:01 2013] opac-search.pl: WARNING: query problem with kw,wrdl,rtrn=tolkien and () ZOOM error 10014 "CCL parsing error" (addinfo: "Search word expected") from diag-set 'ZOOM' at /usr/share/koha/lib/C4/Search.pm line 378., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkien&branch_group_limit=multibranchlimit-NARVIK OPAC, advanced search: [Sat May 18 14:04:13 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:13 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkien&branch_group_limit=multibranchlimit-NARVIK [Sat May 18 14:04:13 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:13 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 39., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl?q=tolkien&branch_group_limit=multibranchlimit-NARVIK [Sat May 18 14:04:22 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:22 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 34., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl [Sat May 18 14:04:22 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:22 2013] opac-search.pl: Use of uninitialized value $_ in pattern match (m//) at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 39., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl [Sat May 18 14:04:23 2013] [error] [client 109.189.7.19] [Sat May 18 14:04:23 2013] opac-search.pl: WARNING: query problem with kw,wrdl,rtrn=tolkien and () ZOOM error 10014 "CCL parsing error" (addinfo: "Search word expected") from diag-set 'ZOOM' at /usr/share/koha/lib/C4/Search.pm line 378., referer: http://nvgs.test312.bibkat.no/cgi-bin/koha/opac-search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 15:10:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 13:10:18 +0000 Subject: [Koha-bugs] [Bug 10135] Adding the ability to define customised basketgroups pdf layouts In-Reply-To: <bug-10135-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10135-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10135-70-4kBd6UUIiX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17756|0 |1 is obsolete| | --- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Created attachment 18226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18226&action=edit [PATCH] Bug 10135 : Add the ability to define customised basketgroups pdf layouts correction of a typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 15:11:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 13:11:42 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9593-70-CdhCPDXq4p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 15:22:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 13:22:33 +0000 Subject: [Koha-bugs] [Bug 10281] Search domains do not seem to work In-Reply-To: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10281-70-K2mdFsX0HI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 --- Comment #2 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18227&action=edit Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 15:22:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 13:22:31 +0000 Subject: [Koha-bugs] [Bug 10281] Search domains do not seem to work In-Reply-To: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10281-70-Y5ZOds6Dww@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 15:35:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 13:35:14 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-fp2fmlzRK9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #17 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Created attachment 18228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18228&action=edit [PATCH 2] Bug 9806 : QA Followup - use template plugin for branch names With this followup, instead of passing the real names of the branches to template file, only the branchcodes are passed. The branchcodes are translated into branchnames in template file, using the KohaBranchName template plugin. To test : do the same test as for main patch : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 15:35:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 13:35:26 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-gG6dG4KZQ1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 21:03:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 19:03:35 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-mnPzlIrIPZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Nicole C. Engard <nengard at gmail.com> --- The link is there now but the link doesn't include the borrowernumber so it doesn't open right: /cgi-bin/koha/members/files.pl?borrowernumber= -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 22:38:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 20:38:17 +0000 Subject: [Koha-bugs] [Bug 10281] Search domains do not seem to work In-Reply-To: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10281-70-k6DsacjoNk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18227|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18229&action=edit Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 22:45:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 20:45:21 +0000 Subject: [Koha-bugs] [Bug 9452] C4::Letters does not function under Plack In-Reply-To: <bug-9452-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9452-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9452-70-3xZwXbpkrT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 22:45:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 20:45:23 +0000 Subject: [Koha-bugs] [Bug 9452] C4::Letters does not function under Plack In-Reply-To: <bug-9452-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9452-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9452-70-79yboUPHvn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18100|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18230&action=edit [PASSED QA] Bug 9452: C4::Letters not Plack-compatible Prior to this patch, at more-or-less random intervals pages working with notices will cease to function. To test: 1) Apply patch. 2) Try to edit some notices. 3) Trigger some notices. 4) If you were able to edit the notices and trigger the notices, sign off. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> All tests and QA script pass. I did a regression script without Plack: - edit, add, delete and copy notice - trigger checkout/checkin notice - print issueslip No problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 22:46:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 20:46:49 +0000 Subject: [Koha-bugs] [Bug 9452] C4::Letters does not function under Plack In-Reply-To: <bug-9452-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9452-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9452-70-gSSchrj0aF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 23:24:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 21:24:29 +0000 Subject: [Koha-bugs] [Bug 10230] Match points do not work with authorities In-Reply-To: <bug-10230-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10230-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10230-70-1jDpgJAEeB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18101|0 |1 is obsolete| | Attachment #18102|0 |1 is obsolete| | Attachment #18103|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18231&action=edit [PASSED QA] Bug 10230: no need to use SimpleSearch for matching auths When introducing QueryParser, I introduced a check for QueryParser at too high a level, causing authority matching to try and use SimpleSearch for authorities prematurely, when SearchAuthorities should be handling it. This patch corrects the level of the check. This patch only moves three lines, but thanks to the change in if level, it adjusts the indentation quite a bit. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Comments on third patch of this series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 23:24:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 21:24:27 +0000 Subject: [Koha-bugs] [Bug 10230] Match points do not work with authorities In-Reply-To: <bug-10230-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10230-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10230-70-KY2RUiLgxU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 23:24:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 21:24:47 +0000 Subject: [Koha-bugs] [Bug 10230] Match points do not work with authorities In-Reply-To: <bug-10230-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10230-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10230-70-pbcaMdIrYB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18232&action=edit [PASSED QA] Bug 10230: Don't limit valid matches to bibs The patch for bug 9523 added a JOIN to the biblio table when identifying the best match so that if a matched record had been deleted it would not hold up the import process. Unfortunately, this broke all authority matching, since of course authorities don't appear in the biblio table. This patch adds a join to auth_header as well, and decides which to check based on the record type. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Comment on third patch of this series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 23:24:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 21:24:45 +0000 Subject: [Koha-bugs] [Bug 10230] Match points do not work with authorities In-Reply-To: <bug-10230-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10230-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10230-70-9eT3cpRKEp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 18 23:24:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 21:24:56 +0000 Subject: [Koha-bugs] [Bug 10230] Match points do not work with authorities In-Reply-To: <bug-10230-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10230-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10230-70-wzGgurt3Db@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18233&action=edit [PASSED QA] Bug 10230: show correct matching record The correct matching record was not always shown on the manage staged MARC page. This patch corrects the issue and provides the template with the appropriate ID for the matched record regardless what type of record it is. To test: 1) Create a matching record for authorities. For MARC21, the following is a good choice: Matching rule code: AUTHPER Description: Personal name main entry Match threshold: 999 Record type: Authority record [Match point 1:] Search index: mainmainentry Score: 1000 Tag: 100 Subfields: a 2) Create a record that has the appropriate fields for being matched with that rule (if you don't already have one). 3) Save the authority record as MARC (Unicode/UTF-8). 4) Stage the file choosing your new matching rule. 5) Note that with these patches, you get a link to the existing authority and without them you could get any number of strange things. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> Passes all tests and QA script. Additional tests done: - staged bibliographic records and matched with different rules and actions. Undid the import. - staged autohrity recods and matched with the example rule. Undid the import. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 00:08:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 22:08:59 +0000 Subject: [Koha-bugs] [Bug 10281] Search domains do not seem to work In-Reply-To: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10281-70-rnFFhjqGnv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18229|0 |1 is obsolete| | --- Comment #4 from Magnus Enger <magnus at enger.priv.no> --- Created attachment 18234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18234&action=edit Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off Signed-off-by: Magnus Enger <magnus at enger.priv.no> I have failed to recreate the problem on three different dev installs, both on Ubuntu and Debian, but the current patch does not break anything as far as I can tell, so I'm signing off. I tested with two libraries in the same search domain, with each library owning a different book by the same author. Searching for the author in - all libraries, - individual libraries and - the search domain that contains both libraries all return the expected results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 00:09:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 18 May 2013 22:09:32 +0000 Subject: [Koha-bugs] [Bug 10281] Search domains do not seem to work In-Reply-To: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10281-70-YVy3w6G7jN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 10:03:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 08:03:09 +0000 Subject: [Koha-bugs] [Bug 10282] New: Implement (OPAC)Display856uAsImage for NORMARC XSLT Message-ID: <bug-10282-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10282 Bug ID: 10282 Summary: Implement (OPAC)Display856uAsImage for NORMARC XSLT Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: MARC Bibliographic data support Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no No way to display 856u as images at the moment - can't have that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 10:10:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 08:10:39 +0000 Subject: [Koha-bugs] [Bug 10280] Extend SeparateHoldings functionality to the "Add items" screen In-Reply-To: <bug-10280-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10280-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10280-70-ePBzOIZ78H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10280 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10278 --- Comment #1 from Magnus Enger <magnus at enger.priv.no> --- Sounds like Bug 10278 is related to this, but that the IndependentBranchesRecordsAndItems syspref will cause a more complete separation between libraries. I can imagine situations where libraries want to easily see just their own items but still have an easy way to see items at other libraries, and so I don't think this enh is a duplicate of Bug 10278. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 10:10:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 08:10:39 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10278-70-Q5v7NfijaP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10280 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 11:31:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 09:31:45 +0000 Subject: [Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page In-Reply-To: <bug-10249-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10249-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10249-70-WXe2g2m0qX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 11:31:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 09:31:48 +0000 Subject: [Koha-bugs] [Bug 10249] Untranslatable strings in Javascript on OPAC detail page In-Reply-To: <bug-10249-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10249-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10249-70-nYn3qCWrBk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10249 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18235&action=edit Bug 10249: Fix untranslatable strings in OPAC detail page Star ratings feature: - Your CGI session cookie is not current. Please refresh the page and try again. - average rating: - your rating: Browse results feature: - Click to rewind the list to - See biblio - with biblionumber - by (between title and author) - Click to forward the list to - Go to detail To test: - Update the po file using 'perl translate update <langcode>' - Translate all new strings, maybe mark them with XX to make it easier to find them - Install the updated translation file using 'perl translate install <langcode>' - Test the ratings and browse results features in the OPAC detail page - Verify everything is still working/displaying like it should - Check that you don't find any unstranslated strings/terms Some hints where the changes are: - Change an existing rating - the average and your rating will change - Browse result list and check mouse over tooltips for all links -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 11:45:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 09:45:21 +0000 Subject: [Koha-bugs] [Bug 7674] Separate tabs for my holdings and others holdings In-Reply-To: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7674-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7674-70-EPkwYBfIeh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7674 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10283 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 11:45:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 09:45:21 +0000 Subject: [Koha-bugs] [Bug 10283] New: Hide "many items" on second tab when using OpacSeparateHoldings Message-ID: <bug-10283-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Bug ID: 10283 Summary: Hide "many items" on second tab when using OpacSeparateHoldings Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: magnus at enger.priv.no Depends on: 7674 As noted by Katrin on Bug 7674: "- if there are over 50 items in the holdings or Other holdings tab, the warning and link 'This record has many physical items. Click here to view them all.' is only shown for the first tab." If there are more than a given number of items, they do not display directly in the detail view in the OPAC, but the text and link "This record has many physical items. Click here to view them all." is displayed instead. Activating OpacSeparateHoldings separates holdings into two tabs. If there are manye items the text and link is shown on the first tab (showing the items that belong to the library of the logged in suer), but the second tab (showing items at all other libraries) show the full list, not the text and link. This makes the initial display of the detail page veeery slow, when there are a lot if items (I have tested with ~3000 items). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 12:01:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 10:01:25 +0000 Subject: [Koha-bugs] [Bug 10281] Search domains do not seem to work In-Reply-To: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10281-70-HpvNmQHYRX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18234|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18236&action=edit [PASSED QA] Bug 10281: searching for a search domain fails For reasons I cannot fathom, the split() in handling multi-branch limits was not coming up with a valid search group code. Replacing the split() with a substr() and creating the CGI parameter as a string rather than as an arrayref fixes the problem. This problem may not affect all installations, since I tested this exact feature just under two months ago and it worked fine, and none of the relevant code has been changed since then that I can see. To test: 1) Create search group, and add at least one library to it, in /cgi-bin/koha/admin/branches.pl 2) Apply patch 3) Try doing a search limited to your search group, making sure that the search will match items that belong to a library in the search group 4) Sign off Signed-off-by: Magnus Enger <magnus at enger.priv.no> I have failed to recreate the problem on three different dev installs, both on Ubuntu and Debian, but the current patch does not break anything as far as I can tell, so I'm signing off. I tested with two libraries in the same search domain, with each library owning a different book by the same author. Searching for the author in - all libraries, - individual libraries and - the search domain that contains both libraries all return the expected results. Signed-off-by: Katrin Fischer <Katrin.Fischer.83 at web.de> All tests and QA script pass. I couldn't reproduce the problem, but didn't find any regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 12:01:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 10:01:23 +0000 Subject: [Koha-bugs] [Bug 10281] Search domains do not seem to work In-Reply-To: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10281-70-V7Otzn1Kxi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 12:02:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 10:02:25 +0000 Subject: [Koha-bugs] [Bug 10281] Search domains do not seem to work In-Reply-To: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10281-70-ls02af53SP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|gmcharlt at gmail.com |jcamins at cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 12:05:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 10:05:44 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-VyXkx0XfHN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|gmcharlt at gmail.com |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 12:14:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 10:14:58 +0000 Subject: [Koha-bugs] [Bug 10284] New: Missing spaces between label and content in XSLT view for 785/780 Message-ID: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 Bug ID: 10284 Summary: Missing spaces between label and content in XSLT view for 785/780 Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de Created attachment 18237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18237&action=edit XSLT view in OPAC There should be a space between the label and the content for the 780 and 785 fields in the XSLT view in OPAC and staff. See screenshots. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 12:15:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 10:15:37 +0000 Subject: [Koha-bugs] [Bug 10284] Missing spaces between label and content in XSLT view for 785/780 In-Reply-To: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10284-70-WxvVReimIK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18238&action=edit Screenshot of MARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 12:17:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 10:17:46 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-EAGhrfWVqa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 12:17:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 10:17:47 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-EWeTPJQd0b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18239&action=edit Bug 10265: Add missing spaces between label and content in XSLT view (780/785) To test: - Check OPAC and intranet XSLT view for a record that contains 780 and 785 fields. - Verify there is no space between the label and the content of the field. - Apply patch. - Verify the display both in intranet and OPAC is a little nicer now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 12:18:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 10:18:55 +0000 Subject: [Koha-bugs] [Bug 10284] Missing spaces between label and content in XSLT view for 785/780 In-Reply-To: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10284-70-17hneb0fwo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18238|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 12:20:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 10:20:03 +0000 Subject: [Koha-bugs] [Bug 10284] Missing spaces between label and content in XSLT view for 785/780 In-Reply-To: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10284-70-ibMqlNRJPa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18240&action=edit MARC fields/subfields I think only the the indicators and $a/$t are needed for reproducing the wrong display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 12:46:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 10:46:31 +0000 Subject: [Koha-bugs] [Bug 10285] New: Error 500 in staff client displays old start page Message-ID: <bug-10285-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Bug ID: 10285 Summary: Error 500 in staff client displays old start page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at enger.priv.no CC: gmcharlt at gmail.com Created attachment 18241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18241&action=edit 500 error including old start page If you trigger a 500 internal server error in the the saff client, the old start page is displayed along with the error message. See attached screenshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 14:20:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 12:20:26 +0000 Subject: [Koha-bugs] [Bug 6546] Batch modification tool should accept a biblionumber In-Reply-To: <bug-6546-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6546-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6546-70-XXdNpmfxbD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6546 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |magnus at enger.priv.no Resolution|--- |FIXED --- Comment #4 from Magnus Enger <magnus at enger.priv.no> --- I think this has been solved now. If you are on the detail view in the staff client, you can do "Edit" > "Edit items in batch" and edit all the items attached to the bib record. Please reopen if I missed something. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 14:34:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 12:34:48 +0000 Subject: [Koha-bugs] [Bug 10286] New: Syspref auto-populator broken in French Message-ID: <bug-10286-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10286 Bug ID: 10286 Summary: Syspref auto-populator broken in French Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: jcamins at cpbibliography.com CC: gmcharlt at gmail.com When viewing the staff client in French, the syspref auto-populated for the XSLT configuration is broken: if you click one of the links in OPACXSLTResultsDisplay, the value of OPACXSLTDetailsDisplay is changed. This is not an issue in nb-NO or de-DE. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 14:39:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 12:39:13 +0000 Subject: [Koha-bugs] [Bug 9452] C4::Letters does not function under Plack In-Reply-To: <bug-9452-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9452-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9452-70-A1H57FLnHF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9452 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 14:39:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 12:39:58 +0000 Subject: [Koha-bugs] [Bug 10281] Search domains do not seem to work In-Reply-To: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10281-70-2ZzQltYZ3y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10281 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 14:41:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 12:41:38 +0000 Subject: [Koha-bugs] [Bug 10230] Match points do not work with authorities In-Reply-To: <bug-10230-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10230-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10230-70-moxEudDz53@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10230 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 14:44:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 12:44:23 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-KNbUVQQUmN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #48 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Exercising my powers as RM and passing QA since the patches work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 14:44:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 12:44:34 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-NliKlDRbnS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #49 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 15:19:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 13:19:01 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-7Vz6iEchbm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #60 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Jared, can you confirm this is definitly pushed? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 15:32:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 13:32:40 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-mbPZ3Phd6r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #61 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Yes, this and all the follow-ups are in 3.12.x and master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 15:52:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 13:52:29 +0000 Subject: [Koha-bugs] [Bug 7593] merging bib records loses connection to order line In-Reply-To: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7593-70-HYhAF5PPEB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593 --- Comment #62 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Great. My colleagues will be really happy! Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 15:59:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 13:59:51 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-02e6Nt83a0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Nicole C. Engard <nengard at gmail.com> --- This patch doesn't solve the problem of the 830. Applied and both the staff and the OPAC have the spaces still missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 17:38:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 15:38:11 +0000 Subject: [Koha-bugs] [Bug 10287] New: Budget administration table displayed with single pixel artifact before and after Message-ID: <bug-10287-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10287 Bug ID: 10287 Summary: Budget administration table displayed with single pixel artifact before and after Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: In Discussion Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jcamins at cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 17:44:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 15:44:05 +0000 Subject: [Koha-bugs] [Bug 10287] Budget administration table displayed with single pixel artifact before and after In-Reply-To: <bug-10287-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10287-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10287-70-IJZKJ0xXuC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10287 --- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18242&action=edit Bug 10287: Remove 1px artifacts from budget admin page Changes follow the method used in bug 10183 and bug 9791. As RM, I am pushing this directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 17:44:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 15:44:04 +0000 Subject: [Koha-bugs] [Bug 10287] Budget administration table displayed with single pixel artifact before and after In-Reply-To: <bug-10287-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10287-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10287-70-9vH600jUdm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10287 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 17:45:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 15:45:05 +0000 Subject: [Koha-bugs] [Bug 10287] Budget administration table displayed with single pixel artifact before and after In-Reply-To: <bug-10287-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10287-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10287-70-C8Y9Wgt2yD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10287 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #2 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 18:08:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 16:08:11 +0000 Subject: [Koha-bugs] [Bug 10288] New: Tiny typo on "Pending offline circulation actions" Message-ID: <bug-10288-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10288 Bug ID: 10288 Summary: Tiny typo on "Pending offline circulation actions" Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Circulation Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On <intranet>/cgi-bin/koha/circ/circulation-home.pl this: There is no pending offline operations. should probably be this: There are no pending offline operations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 18:58:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 16:58:05 +0000 Subject: [Koha-bugs] [Bug 10288] Tiny typo on "Pending offline circulation actions" In-Reply-To: <bug-10288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10288-70-uCIBoyfO2E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10288 --- Comment #1 from Magnus Enger <magnus at enger.priv.no> --- Created attachment 18243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18243&action=edit Bug 10288 - Fix a tiny typo on "Pending offline circulation actions" To test: - Apply the patch - Go to <intranet>/cgi-bin/koha/circ/circulation-home.pl - Verify that is says "There are no pending offline operations." - Sign off Or just have a look at the patch... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 18:58:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 16:58:44 +0000 Subject: [Koha-bugs] [Bug 10288] Tiny typo on "Pending offline circulation actions" In-Reply-To: <bug-10288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10288-70-jBYqQPkCOf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10288 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 22:05:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 20:05:33 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-309RPjHcjM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Nicole, I attached the patch to the wrong bug - still working on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 22:06:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 20:06:35 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-KuOwT0gzeo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 22:06:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 20:06:48 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-u42oVOjiwF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18239|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 18239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18239 Bug 10265: Add missing spaces between label and content in XSLT view (780/785) >From 0a9055d0c36ef12d19da91b970f725dba2f6a6b5 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83 at web.de> >Date: Sun, 19 May 2013 12:16:16 +0200 >Subject: [PATCH] Bug 10265: Add missing spaces between label and content in > XSLT view (780/785) > >To test: >- Check OPAC and intranet XSLT view for a record that contains > 780 and 785 fields. >- Verify there is no space between the label and the content of the > field. >- Apply patch. >- Verify the display both in intranet and OPAC is a little nicer now. >--- > .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 3 ++- > .../prog/en/xslt/MARC21slim2OPACDetail.xsl | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >index aeaa797..98d5742 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >@@ -741,6 +741,7 @@ > <span class="label">Separated from:</span> > </xsl:when> > </xsl:choose> >+ <xsl:text> </xsl:text> > <xsl:variable name="f780"> > <xsl:call-template name="subfieldSelect"> > <xsl:with-param name="codes">at</xsl:with-param> >@@ -800,8 +801,8 @@ > <xsl:when test="@ind2=8"> > <span class="label">Changed back to:</span> > </xsl:when> >- > </xsl:choose> >+ <xsl:text> </xsl:text> > <xsl:variable name="f785"> > <xsl:call-template name="subfieldSelect"> > <xsl:with-param name="codes">at</xsl:with-param> >diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >index 5130e8b..e1e6546 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >@@ -847,6 +847,7 @@ > <span class="label">Separated from:</span> > </xsl:when> > </xsl:choose> >+ <xsl:text> </xsl:text> > <xsl:variable name="f780"> > <xsl:call-template name="subfieldSelect"> > <xsl:with-param name="codes">a_t</xsl:with-param> >@@ -907,8 +908,8 @@ > <xsl:when test="@ind2=8"> > <span class="label">Changed back to:</span> > </xsl:when> >- > </xsl:choose> >+ <xsl:text> </xsl:text> > <xsl:variable name="f785"> > <xsl:call-template name="subfieldSelect"> > <xsl:with-param name="codes">a_t</xsl:with-param> >-- >1.7.9.5 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 22:08:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 20:08:31 +0000 Subject: [Koha-bugs] [Bug 10284] Missing spaces between label and content in XSLT view for 785/780 In-Reply-To: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10284-70-Y7e0ih1TEP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18244&action=edit Bug 10265: Add missing spaces between label and content in XSLT view (780/785) To test: - Check OPAC and intranet XSLT view for a record that contains 780 and 785 fields. - Verify there is no space between the label and the content of the field. - Apply patch. - Verify the display both in intranet and OPAC is a little nicer now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 22:08:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 20:08:29 +0000 Subject: [Koha-bugs] [Bug 10284] Missing spaces between label and content in XSLT view for 785/780 In-Reply-To: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10284-70-TnbucfYBUL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 22:08:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 20:08:59 +0000 Subject: [Koha-bugs] [Bug 10284] Missing spaces between label and content in XSLT view for 785/780 In-Reply-To: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10284-70-NEgUh9X1l8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18244|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 18245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18245&action=edit Bug 10284: Add missing spaces between label and content in XSLT view (780/785) To test: - Check OPAC and intranet XSLT view for a record that contains 780 and 785 fields. - Verify there is no space between the label and the content of the field. - Apply patch. - Verify the display both in intranet and OPAC is a little nicer now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 19 23:52:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 19 May 2013 21:52:40 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: <bug-10267-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10267-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10267-70-oR7Eaa3T3P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Magnus Enger <magnus at enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no --- Comment #1 from Magnus Enger <magnus at enger.priv.no> --- 16 sounds quite restrictive - could it be made longer too? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 10:04:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 08:04:55 +0000 Subject: [Koha-bugs] [Bug 10283] Hide "many items" on second tab when using OpacSeparateHoldings In-Reply-To: <bug-10283-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10283-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10283-70-fqQAkQGoMR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 10:04:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 08:04:57 +0000 Subject: [Koha-bugs] [Bug 10283] Hide "many items" on second tab when using OpacSeparateHoldings In-Reply-To: <bug-10283-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10283-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10283-70-I3QXZwE3m0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18246&action=edit Bug 10283: Hide "many items" on second tab when using OpacSeparateHoldings If there are over 50 items in the holdings or Other holdings tab, the warning and link 'This record has many physical items. Click here to view them all.' is only shown for the first tab. Test plan: - Switch on the OpacSeparateHoldings pref. - Go on a biblio detail page at the OPAC with more than 50 items - Check that the 'view all' link appears on the second tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 10:14:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 08:14:13 +0000 Subject: [Koha-bugs] [Bug 10283] Hide "many items" on second tab when using OpacSeparateHoldings In-Reply-To: <bug-10283-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10283-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10283-70-H0y7HDO7S7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10283 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 12:33:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 10:33:35 +0000 Subject: [Koha-bugs] [Bug 9833] New virtual shelves/lists permissions In-Reply-To: <bug-9833-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9833-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9833-70-tpBeKmRO1V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Summary|New shelves permissions |New virtual shelves/lists | |permissions QA Contact| |m.de.rooy at rijksmuseum.nl --- Comment #6 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- I like this patch since we really need some permissions for shelves!! But I think that we must not add manage shelves under editcatalogue. Managing shelves should have its own permission (if we allow it in the first place). If this patch adds an entry for shelves/lists, I would also have the idea of adding/allowing Change ownership for instance. Note also the privacy issue here as noted in related reports (should a staff user be able to view these lists at all?). So, you could remove manage_shelves from this patch or add a root entry like lists and start a discussion on how we should view the underlying manage. What we do need e.g. is a permission to manage shelves that do no longer have an owner (after deleting user). Merge from shelves is another story: this indeed fits better under edit_catalogue. A technical detail: To know member->userid you use GetMemberDetails: Isn't that quite overkill? Also please watch operator priority in $user && $shelf->{owner}==$user) || C4::Auth::haspermission... Place parentheses? A test plan should be added too. Thanks for your attention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 12:35:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 10:35:15 +0000 Subject: [Koha-bugs] [Bug 5763] Add users private list management functionality for administrators In-Reply-To: <bug-5763-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5763-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5763-70-KGJc29mZwR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5763 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Version|3.4 |master See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9833 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 12:35:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 10:35:15 +0000 Subject: [Koha-bugs] [Bug 9833] New virtual shelves/lists permissions In-Reply-To: <bug-9833-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9833-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9833-70-L3TV5QiwqR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5763 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 13:13:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 11:13:05 +0000 Subject: [Koha-bugs] [Bug 9833] New virtual shelves/lists permissions In-Reply-To: <bug-9833-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9833-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9833-70-5KofjUs4Jz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9833 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16360|0 |1 is obsolete| | --- Comment #7 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18247&action=edit Bug 9833: Refine shelves permissions. - This patch adds two new permissions for shelves: - manage_shelves: allows to manage shelves - merge_from_shelves: allows to merge records from shelves Signed-off-by: Pierre Angot <tredok.pierre at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 14:22:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 12:22:42 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-EKd24RyqMb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 14:38:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 12:38:22 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-6XgDvPWJ6h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 14:38:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 12:38:24 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-lqizJoznPP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18209|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18248&action=edit Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The "Files" tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 15:17:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 13:17:33 +0000 Subject: [Koha-bugs] [Bug 7718] Remove itemnumber column from serials table In-Reply-To: <bug-7718-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7718-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7718-70-uizBZZ5i3k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 15:59:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 13:59:35 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-d9JZ3RmFQa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18248|0 |1 is obsolete| | --- Comment #5 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18249&action=edit [SIGNED-OFF]Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The "Files" tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> all tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 15:59:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 13:59:46 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-HDT40UnpgX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:27:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:27:57 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: <bug-10163-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10163-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10163-70-M3qwlQssve@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #2 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Just confirmed with a customer that this seems to have been caused by the changes introduced under bug 5521 caused the problem - reverting that change got this working again ( but reintroduced the 5521 bug) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:34:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:34:42 +0000 Subject: [Koha-bugs] [Bug 10289] New: UT: Reserves.t needs to create its own data Message-ID: <bug-10289-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Bug ID: 10289 Summary: UT: Reserves.t needs to create its own data Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com t/db_dependent/Reserves.t depends on the Jenkins database. We should create the data we want and delete them at the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:35:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:35:35 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: <bug-10274-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10274-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10274-70-1cROe5fqxH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10273 Depends on|10273 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:35:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:35:35 +0000 Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database In-Reply-To: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10273-70-V5zYkc9lgv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10274, 10275 | Depends on| |10274, 10275 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:35:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:35:35 +0000 Subject: [Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data In-Reply-To: <bug-10275-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10275-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10275-70-fZadkOBGea@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10273 Depends on|10273 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:36:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:36:27 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: <bug-10289-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10289-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10289-70-oOnfp9RO0c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |10273 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:36:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:36:27 +0000 Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database In-Reply-To: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10273-70-GQZo0sIfeq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10289 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:38:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:38:58 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: <bug-10289-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10289-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10289-70-NiejLQrIZ4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18250&action=edit Bug 10289: UT: Reserves.t needs to create its own data Try before the patch: prove t/db_dependent/Reserves.t And after, it should produce: t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:38:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:38:56 +0000 Subject: [Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data In-Reply-To: <bug-10289-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10289-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10289-70-P7Q8RK2Ucr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:41:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:41:00 +0000 Subject: [Koha-bugs] [Bug 10274] UT: Acquisition.t needs to create its own data In-Reply-To: <bug-10274-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10274-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10274-70-Q8Mp1znkUY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10274 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18197|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18251&action=edit Bug 10274: UT: Acquisition.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition.t And after, it should produce: t/db_dependent/Acquisition.t .. ok All tests successful. Files=1, Tests=41, 2 wallclock secs ( 0.03 usr 0.00 sys + 0.42 cusr 0.02 csys = 0.47 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:41:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:41:55 +0000 Subject: [Koha-bugs] [Bug 10275] UT: OrderFromSubscription.t needs to create its own data In-Reply-To: <bug-10275-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10275-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10275-70-CWScMF6eaJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10275 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18201|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18252&action=edit Bug 10275: UT: OrderFromSubscription.t needs to create its own data Try before the patch: prove t/db_dependent/Acquisition/OrderFromSubscription.t And after, it should produce: t/db_dependent/Acquisition/OrderFromSubscription.t .. ok All tests successful. Files=1, Tests=12, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.46 cusr 0.02 csys = 0.50 CPU) Result: PASS And some warnings... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:44:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:44:03 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-dNuO4CK11Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #5 from Nicole C. Engard <nengard at gmail.com> --- (In reply to comment #0) > typo in help/reports/guided_reports.tt : > > CreditXXX should be credit</li> > > M. Saby Actually it's right - it's going to say Credit and then the XX is the value after it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:45:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:45:03 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-R5UDfAEh4X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #6 from Nicole C. Engard <nengard at gmail.com> --- (In reply to comment #2) > in the same file, probably an other typo, but I am not sure : > > 6 = Delete > > should be > > 6 = Deleted Nope, that's the value that's stored in the DB. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:47:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:47:26 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-XpPt7z1pz8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:55:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:55:04 +0000 Subject: [Koha-bugs] [Bug 10290] New: UT: VirtualShelves.t needs to create its own data Message-ID: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 Bug ID: 10290 Summary: UT: VirtualShelves.t needs to create its own data Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com t/db_dependent/VirtualShelves.t depends on the Jenkins database. We should create the data we want and delete them at the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:55:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:55:27 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10290-70-8tI4CmugLn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |10273 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:55:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:55:27 +0000 Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database In-Reply-To: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10273-70-fwQUNaA8Ym@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10290 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:56:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:56:02 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: <bug-10186-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10186-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10186-70-UsNKYQNcbt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:58:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:58:04 +0000 Subject: [Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt In-Reply-To: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10191-70-ezhWUefZpc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:58:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:58:16 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10290-70-pmPsxPeMXk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18253&action=edit MT10290: UT: VirtualShelves.t needs to create its own data Try before the patch: prove t/db_dependent/VirtualShelves.t And after, it should produce: t/db_dependent/VirtualShelves.t .. ok All tests successful. Files=1, Tests=82, 6 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.03 csys = 0.52 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 16:58:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 14:58:14 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10290-70-pioPTsJ6GV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:00:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:00:35 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-yCIXoy5V9R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #7 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18254&action=edit Bug 10250: Fix typos in guided reports help file This is a string patch that fixes typos in the guided reports help file. To test: * Go to the guided reports page * Click help * Confirm text is right -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:01:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:01:24 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-7lANxQOFjn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:04:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:04:13 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10178-70-ViYSzLWnUu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Bernardo! The typo fixes aside, because of the April 2013 updates to the 006 for music, this patch should be backported to stable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:05:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:05:54 +0000 Subject: [Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt In-Reply-To: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10251-70-yXPHHnQrbE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18255&action=edit Bug 10251: Fix typos in Patron Permissions Help This is a string patch that fixes the typos in the patron permission help file. To test: * go to a patron record * click 'set permissions' under more * click 'help' * confirm that text is right -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:06:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:06:03 +0000 Subject: [Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt In-Reply-To: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10251-70-zOWkrHL4ab@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:08:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:08:05 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-N2J1IL6DjV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Changing status to reflect need for clarification. Why C4::Koha? Are there specific functions in that module you recommend to use? If so, maybe add this in the pod lines? Typo replated. Use Template::Plugin not needed? Use base seems enough. Leaving the name as-is.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:15:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:15:34 +0000 Subject: [Koha-bugs] [Bug 10163] batch-mod items tool fails on files over 1000 lines long In-Reply-To: <bug-10163-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10163-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10163-70-JEQLPjvhmy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10163 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #3 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 18256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18256&action=edit proposed patch This patch corrects the logic while preserving the test from bug 5521 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:17:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:17:05 +0000 Subject: [Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma' In-Reply-To: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6399-70-EqBvDSZNXS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Owen! I agree with Katrin's comment that we should consider adjusting the text at the other three places where a tag can be added. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:42:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:42:00 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: <bug-10170-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10170-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10170-70-eHsdpuTvqJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:42:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:42:02 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: <bug-10170-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10170-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10170-70-eQtjM3Ko9q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 --- Comment #6 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18257&action=edit bug 10170: expose more managed staged MARC strings to translation This commit makes it possible to translated the 'staged' and 'error' record statuses as well as the 'auto_match' overlay status. Also takes out a bit of HTML cruft in one string that is not needed for translation. Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:47:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:47:16 +0000 Subject: [Koha-bugs] [Bug 10170] non translatable strings in manage-marc-import (actions and table values) In-Reply-To: <bug-10170-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10170-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10170-70-nMyafgUypv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10170 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton <gmcharlt at gmail.com> --- Adrien's patch is fine as far as it goes, but I've attached a follow-up that addresses Marcel's observation about the 'auto_match' overlay status and 'staged' and 'error' record status -- for simple stuff like this, I prefer to push a patch or a patch series that completely addresses the problem. I've intentionally not supplied anything for the 'manual_match' and 'items_reverted' statuses, as there's at present no code that will set them. Hopefully this can be fixed in time for 3.14. For the record, the intention was that 'manual_match' would signify that a user had performed a search and manually identified a matching bib record, while 'items_reverted' would signify an operation that would remove items added during a previous commit without reverting the bib record as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:51:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:51:14 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-DOPqSOdg9Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12654|0 |1 is obsolete| | Attachment #13050|0 |1 is obsolete| | Attachment #13089|0 |1 is obsolete| | --- Comment #29 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 18258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18258&action=edit Bug 8773 - Start per-instance koha-index-daemon in .deb setup Short: Launch a koha-index-daemon (from Koha::Contrib::tamil) process for each enabled instance. Enabling/disabling the use of the indexer is handled using a new(ly introduced) /etc/default/koha-common config file that can be used for other stuff too, and is the Debian way of handling init scripts control variables[1]. Long: Using an indexing daemon avoids launching a new interpreter each time the cron triggers the indexing, and also allows sub-minute incremental reindexing, a requirement from our librarians.[2] Using the indexer daemon should remain "experimental" so is disabled by default. To enable the use of the indexer the user has to tweak the /etc/default/koha-common config file (introduced by this patch). Specifically the USE_INDEXER_DAEMON variable, which is clearly explained in the file. Update frecquency defaults to 30 sec, and can be changed by tweaking the /etc/default/koha-common config file too. This patch relies on Koha::Contrib::Tamil's koha-index-daemon script [3], but could be easily adjusted to use another if we got a new one (SolR?). As Robin proposed it check for availability of the relevant files before trying to spawn the daemon. If there's something I could change to make this patches better just let me know. Note: there was a problem Robin found regarding the spawned processes forgetting the PERL5LIB and/or KOHA_CONF env variables, this is fixed in this version with the inclusion of the 'export' keyword for the relevant variables. Regards To+ [1] Section 9.3.2 of http://www.debian.org/doc/debian-policy/ch-opersys.html [2] This is the .deb version of http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [3] The default cronjob that is set using the debian/koha-common.cron.d file is being disbaled by this patch to avoid collision. Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:52:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:52:40 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-bI3sqjnbKq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Command-line Utilities |Packaging Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored Assignee|tomascohen at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:53:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:53:23 +0000 Subject: [Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup In-Reply-To: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8773-70-fYuXUZxGK8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773 --- Comment #30 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Forgot to mention that lavamind helped me with his ideas and testing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 17:54:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 15:54:16 +0000 Subject: [Koha-bugs] [Bug 10291] New: Misleading Variable names in batchMod.pl Message-ID: <bug-10291-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10291 Bug ID: 10291 Summary: Misleading Variable names in batchMod.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: colin.campbell at ptfs-europe.com batchMod,pl has two variables with names of the form x_hashref but both are actually references to an array of hashrefs. It passes the contents of one to the templares under the name itemnumbers_hashref but the use of it belies that name. For the sake of future maintainers lets clean up these names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 18:03:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 16:03:57 +0000 Subject: [Koha-bugs] [Bug 10291] Misleading Variable names in batchMod.pl In-Reply-To: <bug-10291-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10291-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10291-70-Iz97dVWf7M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10291 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 18259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18259&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 18:07:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 16:07:05 +0000 Subject: [Koha-bugs] [Bug 9508] the dateformat variable is not standardized in template files In-Reply-To: <bug-9508-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9508-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9508-70-r8CIbmNZus@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9508 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Paul and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 18:12:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 16:12:11 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9032-70-hD3zrwLIIl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #1 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #0) > The owner can 'unshare' the list and remove all shares for that list. I am having second thoughts about this part of the functionality. I would rather opt now for copy and delete without unsharing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 18:15:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 16:15:11 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9032-70-TNNTdtllMw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18260&action=edit Bug 9032: Share a list: OPAC foundation Adds a Share button for OPAC private lists Adds template and script for further development Test plan: Toggle the pref OpacAllowSharingPrivateList. If enabled, you should see the Share button in OPAC/Private lists. Click on the Share button. You should get Share a list. Logout and try to go back to opac/opac-shareshelf.pl It should now present you the login form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 18:16:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 16:16:55 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9032-70-mY7NuUU17C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10206 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 18:16:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 16:16:55 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-VqtVnSZESN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9032 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 18:18:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 16:18:10 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9032-70-eccEYRPYvA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Please wait for some more patches :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 18:22:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 16:22:15 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: <bug-2774-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2774-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2774-70-HlXZxRe1n9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch Severity|critical |normal --- Comment #11 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #10) > (In reply to comment #9) > > This looks good to me, but I am bumping it to 3.14 because I am concerned > > about the number of files it changes. > > hmm, i might bump the severity to 'critical', so this bug gets noticed > more... > > i hope no-one objects to this? I do. From http://wiki.koha-community.org/wiki/Bug_Reporting_Guidelines#Severity, the critical severity is defined as "Koha or component crashes and/or there is a potential loss of data". While this definition is a guideline, not an absolute rule, this bug simply does not qualify as a critical bug by that definition. If you want to call attention to a bug, please do so by (for example) discussing it on the IRC channel or koha-devel. Setting the severity of a bug higher than necessary would be a bad habit for us to get into, as it reduces the utility of that BZ field. Consequently, I am setting the severity back to normal. This should not be construed as a statement that I am not going to review the patch; I will, in due course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 18:44:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 16:44:10 +0000 Subject: [Koha-bugs] [Bug 10292] New: XSLT files always taken from 'prog' theme for English Message-ID: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Bug ID: 10292 Summary: XSLT files always taken from 'prog' theme for English Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: gmcharlt at gmail.com The commit for bug 8947 has the side-effect of (when the language is English) causing the theme syspref to be ignored when looking for an XSLT stylesheet for bib details or search result display. To reproduce the bug: [1] Make sure OPAC XSLT details is turned on and that English is the OPAC language. [2] Create a new OPAC theme, including copying the XSLT files. [3] Set opactheme to the new theme. [4] Make a change to koha-tmpl/opac-tmpl/NEWTHEME/en/xslt/MARC21slim2OPACDetail.xsl [5] View a bib record in the OPAC. The change made in the previous step is not reflected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 19:07:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 17:07:21 +0000 Subject: [Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR In-Reply-To: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8884-70-v1g6hzwNqY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 19:07:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 17:07:23 +0000 Subject: [Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR In-Reply-To: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8884-70-w4sT8SuvFA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 --- Comment #5 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18261&action=edit Bug 8884: opacheader is not in the header on CCSR In CCSR the opacheader preference isn't really in the header it's to the right of the search box (see attached). I'm okay with a customizable region over there, but we should have a new preference for that and header should be above the search box as it implies. To test: 1) Put something in the OpacHeader syspref. Preferably something large and header-like for maximum effect. 2) Select CCSR theme. 3) View OPAC. Notice placement of "header" content. 4) Apply patch. 5) View OPAC. Notice placement of "header" content. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 19:07:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 17:07:52 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-k3jNA1qSwU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #8 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Not sure CreditXXX is right : - HTML closing Tag </li> missing - I don't know how to translate CreditXXX in french Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 19:43:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 17:43:08 +0000 Subject: [Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR In-Reply-To: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8884-70-lqwJBvzpWq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 --- Comment #6 from Ed Veal <ed.veal at bywatersolutions.com> --- Jared, I am going to test this but would like to make a suggestion. There are a few sites I am already working with and will be using the opacheader to place a library logo to the right of the search bar as it is functioning now. So if this passes QA and gets patched it will affect these sites. Might we be able to add a new system preference to work like the opacheader is working now on CCSR to accomodate this desired look? Just a thought. Ed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 19:53:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 17:53:21 +0000 Subject: [Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English In-Reply-To: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10292-70-unFZmLgtKi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 19:53:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 17:53:23 +0000 Subject: [Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English In-Reply-To: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10292-70-gI13pLVDZ4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 --- Comment #1 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18262&action=edit bug 10292: improve fallback logic for picking XSLT This patch fixes a bug whereby XSLT files from the prog theme would be used (for English OPACs and staff interfaces) even if the user had created and enabled a custom theme that provided override XSLT files. This patch provides a clearer implementation of the fallback logic and adds test cases. To reproduce the bug: [1] Set OPACXSLTDetailsDisplay to 'default' and English as the OPAC language. [2] Create a new OPAC theme, including copying the XSLT files. [3] Set opactheme to the new theme. [4] Make a change to koha-tmpl/opac-tmpl/NEWTHEME/en/xslt/MARC21slim2OPACDetail.xsl [5] View a bib record in the OPAC. The change made in the previous step is not reflected. To test after applying the patch: [6] Reload the bib record in the OPAC. The change made in step 4 should now be reflected. [7] (To be thorough) Go through the test plan for bug 8947 and verify that there is no regression. Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 19:54:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 17:54:48 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: <bug-2774-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2774-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2774-70-ghhaXisVHs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10292 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 19:54:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 17:54:48 +0000 Subject: [Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English In-Reply-To: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10292-70-bLuKC9iRwP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2774 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 19:56:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 17:56:22 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: <bug-2774-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2774-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2774-70-oeVTZY0m5P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 --- Comment #12 from Galen Charlton <gmcharlt at gmail.com> --- I've added bug 10292 as a dependency -- not so much because it is directly related to the patch that was submitted, but because it touches on the specific issue that was originally reported by Doug Dearden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:01:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:01:07 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: <bug-10186-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10186-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10186-70-Li5umek6Ii@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:17:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:17:05 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: <bug-2774-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2774-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2774-70-6V1O6kQslR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 --- Comment #13 from Galen Charlton <gmcharlt at gmail.com> --- I've pushed Owen's patch to master. Thanks, Owen! I'm also setting this back to In Discussion, as there are some places that still make hard-coded references to prog. Here is a list of potential candidates for replacing references: ./C4/Record.pm ./C4/Templates.pm ./C4/Koha.pm ./C4/Items.pm ./C4/XSLT.pm ./misc/translator/translate ./misc/translator/LangInstaller.pm ./installer/InstallAuth.pm ./admin/systempreferences.pl ./koha-tmpl/intranet-tmpl/prog/en/includes/error-messages.inc ./koha-tmpl/intranet-tmpl/prog/en/includes/installer-doc-head-close.inc ./koha-tmpl/intranet-tmpl/prog/en/css/blue.css ./koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css ./koha-tmpl/intranet-tmpl/prog/en/css/mainpage.css ./koha-tmpl/intranet-tmpl/prog/en/js/ajax.js ./koha-tmpl/intranet-tmpl/prog/en/modules/help/labels/spinelabel-home.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/help/mainpage.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/installer/step2.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/installer/step3.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt ./koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt ./koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl ./koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetResults.xsl ./koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl ./koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARC_compact.xsl ./koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetResults.xsl ./koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl ./koha-tmpl/opac-tmpl/prog/en/xslt/NORMARCslim2OPACDetail.xsl ./koha-tmpl/opac-tmpl/gmc/en/xslt/NORMARCslim2OPACDetail.xsl ./koha-tmpl/opac-tmpl/gmc/en/xslt/MARC21slim2OPACDetail.xsl ./opac/unapi ./opac/opac-showmarc.pl ./opac/oai.pl ./catalogue/cardview.pl ./cataloguing/value_builder/marc21_field_008.pl ./cataloguing/value_builder/marc21_field_006.pl ./cataloguing/addbiblio.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:18:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:18:04 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: <bug-2774-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2774-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2774-70-UaSd9wTLQ2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17611|0 |1 is obsolete| | --- Comment #14 from Galen Charlton <gmcharlt at gmail.com> --- Comment on attachment 17611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17611 Bug 2774 - Path to theme is hard-coded in many places Marking patch attachment obsolete now that it's been pushed to master, because bug should remain open for additional followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:18:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:18:40 +0000 Subject: [Koha-bugs] [Bug 2774] Path to theme is hard-coded in many places In-Reply-To: <bug-2774-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2774-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2774-70-lhucExnoQM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2774 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:42:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:42:34 +0000 Subject: [Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface In-Reply-To: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10083-70-b9Ai2e8QF8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED Version|master |3.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:42:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:42:44 +0000 Subject: [Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface In-Reply-To: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10083-70-TeYVUFNnpB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:43:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:43:16 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10166-70-0sHfBvhBLi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED Version|master |3.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:43:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:43:26 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10166-70-UGajK7q5bz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:48:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:48:51 +0000 Subject: [Koha-bugs] [Bug 10293] New: Bug 9930 needs to be reverted for 3.10.x Message-ID: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Bug ID: 10293 Summary: Bug 9930 needs to be reverted for 3.10.x Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com The patch for bug 9930 needs to be reverted for 3.10.x, as the patron self registration feature is not part of 3.10.x. With the patch applied, the OPAC patron details link redirects to a non-existent page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:49:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:49:01 +0000 Subject: [Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x In-Reply-To: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10293-70-PLUQH0Rz1v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9930 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:49:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:49:01 +0000 Subject: [Koha-bugs] [Bug 9930] can't update patron info in ccsr In-Reply-To: <bug-9930-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9930-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9930-70-sNe1HJhYkG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9930 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10293 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:49:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:49:09 +0000 Subject: [Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR In-Reply-To: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8884-70-JcOvxBfMkr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #6) > There are a few > sites I am already working with and will be using the opacheader to place a > library logo to the right of the search bar as it is functioning now. Is that because that's where they really want it, or because that's where they can put it? I would certainly prefer to fix the placement of opacheader and have any library customizations be corrected later. There will be plenty of notice before any such change arrives on customers' installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:49:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:49:14 +0000 Subject: [Koha-bugs] [Bug 7067] allow patron self registration via the opac In-Reply-To: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7067-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7067-70-CjbvAVPjMh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7067 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10293 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:49:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:49:14 +0000 Subject: [Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x In-Reply-To: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10293-70-vENsaT23OS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7067 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:57:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:57:38 +0000 Subject: [Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR In-Reply-To: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8884-70-4qeSM4EHZw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 --- Comment #8 from Ed Veal <ed.veal at bywatersolutions.com> --- Owen, Yes, I agree and that is what I was trying to say. I would like to opacheader work as it should and then add a new preference or just figure out a way to move the logos there. I was just bouncing around the idea. Ed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:59:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:59:56 +0000 Subject: [Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x In-Reply-To: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10293-70-o6PFgV0wqf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18263&action=edit Bug 10293 - Bug 9930 needs to be reverted for 3.10.x The patch for bug 9930 needs to be reverted for 3.10.x, as the patron self registration feature is not part of 3.10.x. With the patch applied, the OPAC patron details link may redirect to a non-existent page ( opac-memberentry.pl ). This reverts commit e5186d6d784c1fdd8d12c6e93e163d0b9e10cc0e. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 20:59:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 18:59:55 +0000 Subject: [Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x In-Reply-To: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10293-70-EjJKgqWVhb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 21:03:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 19:03:50 +0000 Subject: [Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x In-Reply-To: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10293-70-VZpbQ9N3Rm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18263|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18264&action=edit Bug 10293 - Bug 9930 needs to be reverted for 3.10.x The patch for bug 9930 needs to be reverted for 3.10.x, as the patron self registration feature is not part of 3.10.x. With the patch applied, the OPAC patron details link may redirect to a non-existent page ( opac-memberentry.pl ). Test Plan: 1) Set OPAC to use CCSR theme. 2) Log into the OPAC. 3) Click the link for your username. 4) Click the "my personal details" tab. 5) Note the error page you get 6) Apply this patch 7) Refresh the page 8) You should now see the user details update page This reverts commit e5186d6d784c1fdd8d12c6e93e163d0b9e10cc0e. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 21:04:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 19:04:28 +0000 Subject: [Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x In-Reply-To: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10293-70-s6iDiaPXmx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 21:07:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 19:07:03 +0000 Subject: [Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt In-Reply-To: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10251-70-FiIYA8yIrY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 21:07:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 19:07:11 +0000 Subject: [Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt In-Reply-To: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10251-70-vNdqYIkwHU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 21:07:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 19:07:48 +0000 Subject: [Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt In-Reply-To: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10251-70-Yrm2eiFqbT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #2 from Galen Charlton <gmcharlt at gmail.com> --- Trivial and visibly correct string patch; pushing directly to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 21:08:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 19:08:01 +0000 Subject: [Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt In-Reply-To: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10251-70-r1mQvNkZ6u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 21:23:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 19:23:57 +0000 Subject: [Koha-bugs] [Bug 10288] Tiny typo on "Pending offline circulation actions" In-Reply-To: <bug-10288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10288-70-NaKa98Of6i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10288 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 21:24:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 19:24:12 +0000 Subject: [Koha-bugs] [Bug 10288] Tiny typo on "Pending offline circulation actions" In-Reply-To: <bug-10288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10288-70-6r8fbDfTrq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10288 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 21:24:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 19:24:34 +0000 Subject: [Koha-bugs] [Bug 10288] Tiny typo on "Pending offline circulation actions" In-Reply-To: <bug-10288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10288-70-JIQSXTzxq7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10288 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #2 from Galen Charlton <gmcharlt at gmail.com> --- Trivial string patch; pushed directly to master. Thanks, Magnus! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 21:48:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 19:48:30 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-7j2134MB1b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |gmcharlt at gmail.com --- Comment #2 from Galen Charlton <gmcharlt at gmail.com> --- I agree with the notion that the method for checking whether a session has superlibrarian privileges should be more clear. The patch is problematic, however: - I'm pretty sure terminating (via confess) is not the right thing to do if the userenv isn't set up yet; in particular, this has the potential to break command-line scripts for no good reason. - Doing it via confess() without loading the Carp module is wrong regardless. - A patch that introduces a new C4::Context method but never uses it is untestable. It should, at the very least, attempt to replace some of the opaque userenv flags tests, and ideally should aim to replace them all. In other words, if we're going to refactor this, let's refactor this all the way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 22:12:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 20:12:45 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8688-70-9TDuWXqu7W@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 --- Comment #12 from Galen Charlton <gmcharlt at gmail.com> --- I think a feature to add support for recalls needs more fleshing out before being committed to master, since most other implementations I know of have additional components. The most important one is doing something to keep track of to whom the recalled item should be given. Other ILSs do this by treating a recall as a special kind of hold request. Note that if the feature were to allow patrons to place recall requests directly, that is something that is typically not offered to all patron categories -- for example, in an academic library, often it's only professors and maybe grad students who are allowed to recall books. Secondarily, I feel that there should be a related permission on whether a staff member is allowed to place recalls in the first place. Next, consideration should be given to whether recalls are allowed to shorten the loan period for the originally borrower. In addition, I know that some libraries impose higher fines if a recalled items is not returned promptly enough. Tying recalls into the holds system (or perhaps creating a separate class of recall request) should be considered a sine qua non, in my opinion. I have doubts that a feature that simply sends recall notices at (staff) will is going to be sufficient. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 22:12:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 20:12:52 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8688-70-E0cYDgjWsu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 22:55:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 20:55:19 +0000 Subject: [Koha-bugs] [Bug 10294] New: when the word "user" is included in default in framework, surname of login creating record inserted Message-ID: <bug-10294-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10294 Bug ID: 10294 Summary: when the word "user" is included in default in framework, surname of login creating record inserted Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: drnoe at bywatersolutions.com CC: m.de.rooy at rijksmuseum.nl When the word "user" is included in a default value in a MARC subfield structure of a tag in a framework, the surname of he user login creating record is inserted in the place of the word "user." Create the deafualt value in the framework -In MARC frameworks. -Select a MARC structure of any framework to edit. -Select the subfields to edit. -Select the Edit Subfields button. -Select Display more constraints of any subfield tab. -Include "user" in the default value. (make sure hidden is st to 0). -Save Changes. Create a new record -In Cataloging, select New Record with the edited framework -Go to the tag with the default value. -The surname of the user with which you create the new record will be in the tag in the place of user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 23:01:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 21:01:00 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-nvkojz2IiS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #9 from Nicole C. Engard <nengard at gmail.com> --- The closing <li> is after the </ul> as it should be. And the way the data is stored is Credit and then a code - all one word with no spaces. How would be a better way to denote this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 23:11:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 21:11:52 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-mKKrjAlfIE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #10 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Oh, I looked to quickly. I did not understand the structure of the code. Of course you are right! We'll find a way to translate CreditXXX (I translated in french as "Credit </li>" - SHAME ON ME!) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 23:17:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 21:17:02 +0000 Subject: [Koha-bugs] [Bug 1993] Task Scheduler Needs Re-write In-Reply-To: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-1993-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-1993-70-esTMb3hNis@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1993 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #34 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #33) > This brings me to a more important question: Should we encourage Koha users > to allow login for apache user to make use of the Task Scheduler? Note that > is a general Apache hardening measure to not allow interactive login for the > apache user. IMO we (as Koha developers) should not stimulate Koha users to > lower security barriers to enable Koha functionality. I agree: we should not be asking users to grant special privileges to the user that Apache runs as, > Another approach to the Task Scheduler could be to have a specific cronjob, > look for Koha reports to run at specified times without allowing apache to > add generic jobs with all security risks attached.. I think writing a cronjob (and abandoning Schedule::At) is the way to go. In particular, I suggest the following implementation: - create a database table to store a queue of reports to run (or maybe generalize it a bit and call it a job queue table) - the current report scheduling functionality would just add rows to the queue with a run start time set by the user - the cronjob would periodically check the queue and run any pending reports whose run start time has passed This would be pretty light-weight, but would allow us to get fancier in the future. For example, adding functionality to schedule reports to run periodically could be done by writing code to add entries into the job queue. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 23:17:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 21:17:29 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-U5lDfV8GfX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #11 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- By the way, CreditXXX is the only value begining with an Uppercase in the list. It is not a typo ? http://manual.koha-community.org/3.10/en/reportsfaq.html#statscodefaq Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 20 23:49:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 21:49:58 +0000 Subject: [Koha-bugs] [Bug 8917] Track clicks to links external to Koha In-Reply-To: <bug-8917-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8917-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8917-70-BAMgwmll0b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8917 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #73 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Is somebody planning to write a followup bug for UNIMARC XSLT? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 00:26:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 22:26:20 +0000 Subject: [Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR In-Reply-To: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8884-70-X83IsKtQJx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Maybe we could just copy from opacheader into the new preference on database update and preserve the current customizations that way? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 00:35:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 22:35:20 +0000 Subject: [Koha-bugs] [Bug 10294] when the word "user" is included in default in framework, surname of login creating record inserted In-Reply-To: <bug-10294-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10294-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10294-70-vZpq07PGAF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10294 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm I am not sure user = surname makes sense to me - what if you have more than one staff member with the same surname? and why not use surname as the keyword? I think for 'user' i would expect the username (opac login) to be inserted in the record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 00:36:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 22:36:08 +0000 Subject: [Koha-bugs] [Bug 8412] add color icon set In-Reply-To: <bug-8412-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8412-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8412-70-T6eIj7cOH0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8412 Suzanne Fayle <sfayle at roseman.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sfayle at roseman.edu --- Comment #18 from Suzanne Fayle <sfayle at roseman.edu> --- This feature would be of use to us for sure. But I'd like to see more colors available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 00:37:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 20 May 2013 22:37:24 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-c2HkWtMGGX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Mathieu, are you sure those should be translated? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 10:16:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 08:16:45 +0000 Subject: [Koha-bugs] [Bug 10295] New: add the ability to sort and filter batch of records in Staged Records Management Tool Message-ID: <bug-10295-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10295 Bug ID: 10295 Summary: add the ability to sort and filter batch of records in Staged Records Management Tool Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr In manage-marc-import.pl, we should have the ability to sort and filter batch of records by date, and status (staged, imported, cleared...) M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 12:36:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 10:36:02 +0000 Subject: [Koha-bugs] [Bug 10250] typos in help/reports/guided_reports.tt In-Reply-To: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10250-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10250-70-cdgiPy3KG9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10250 --- Comment #13 from Nicole C. Engard <nengard at gmail.com> --- (In reply to comment #12) > Mathieu, are you sure those should be translated? I was just coming here to say that. I didn't think about it yesterday, but these are database values, they won't be different if you're using a different language pack - they should not be translated I would think. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 12:53:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 10:53:40 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9593-70-jnmOOo26oK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #29 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 18265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18265&action=edit Bug 9593 Prices not imported correctly (plus conversion) My opinion is that seems a good idea but that would be really interesting to have the opinion of libraries likely to use the active currency mechanism. In Lyon3, we don't need it, so I have no view from experience about that. Anyhow, you'll find here an other version of patch (that do not necessarily cancel the previous one). It includes your idea to pick the first other currency found in the list (when active is not present in the price string) and convert it to active currency. Olivier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 13:08:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 11:08:20 +0000 Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent In-Reply-To: <bug-7045-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7045-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7045-70-TVhcaUZzqT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10294 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 13:08:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 11:08:20 +0000 Subject: [Koha-bugs] [Bug 10294] when the word "user" is included in default in framework, surname of login creating record inserted In-Reply-To: <bug-10294-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10294-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10294-70-i7TfGvRdtN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10294 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7045 --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- I think that this is related to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 13:14:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 11:14:09 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: <bug-10267-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10267-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10267-70-9OWNk5Jcdv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 13:14:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 11:14:32 +0000 Subject: [Koha-bugs] [Bug 10269] add a way to define a specific replyto email address for some notice In-Reply-To: <bug-10269-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10269-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10269-70-ecEYAGQR9L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10269 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 13:15:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 11:15:37 +0000 Subject: [Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken In-Reply-To: <bug-10241-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10241-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10241-70-6lmjb4KqEZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 13:16:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 11:16:45 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-8WIpttkSyo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 13:17:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 11:17:05 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10278-70-FdWDNtN4zu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 13:17:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 11:17:56 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-9iGzHOfJ3j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 13:18:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 11:18:15 +0000 Subject: [Koha-bugs] [Bug 10280] Extend SeparateHoldings functionality to the "Add items" screen In-Reply-To: <bug-10280-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10280-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10280-70-VJuwKtrFgR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10280 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 13:24:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 11:24:24 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9593-70-G04tdCG3E1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #30 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I will take a look tomorrow. we don't use it either in Rennes2, and I think no french library is using it. Maybe you can ask the question on koha list. Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 14:53:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 12:53:59 +0000 Subject: [Koha-bugs] [Bug 10296] New: db schemas are useless Message-ID: <bug-10296-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10296 Bug ID: 10296 Summary: db schemas are useless Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com 3 files seem to be useless in t/data/db_schemas -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 14:57:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 12:57:22 +0000 Subject: [Koha-bugs] [Bug 10296] db schemas are useless In-Reply-To: <bug-10296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10296-70-epBFFouoOG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10296 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 14:57:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 12:57:25 +0000 Subject: [Koha-bugs] [Bug 10296] db schemas are useless In-Reply-To: <bug-10296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10296-70-iqakgmpmBO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10296 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18266&action=edit Bug 10296: UT: db schemas are useless I did not find any utility in these 3 old files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 14:57:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 12:57:49 +0000 Subject: [Koha-bugs] [Bug 10296] db schemas are useless In-Reply-To: <bug-10296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10296-70-rmUoQQC1oe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10296 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 15:02:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 13:02:07 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: <bug-10267-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10267-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10267-70-sArmqLLrQ1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Here are some steps we could take, individually or in combination: 1. Add a "maxlenth" attribute to the input field. 2. Add some JavaScript validation to warn the user when the limit is reached. 3. Increase the length which can be stored. If we increase the possible length of a card number what should it be? 50? 100? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 15:28:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 13:28:52 +0000 Subject: [Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml In-Reply-To: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9531-70-cc0DXCXLD3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18193|0 |1 is obsolete| | --- Comment #10 from Adrien SAURAT <adrien.saurat at biblibre.com> --- Created attachment 18267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18267&action=edit Bug 9531 - Make SIP2 message terminator configurable via SIPconfig.xml Signed off. With my own SIP testing scripts, I get good results (ie. no change) with CRLF. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 15:29:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 13:29:04 +0000 Subject: [Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml In-Reply-To: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9531-70-fIpvLtz6PI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 15:35:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 13:35:23 +0000 Subject: [Koha-bugs] [Bug 7920] Establish style guide for Koha help pages In-Reply-To: <bug-7920-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7920-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7920-70-FMt33dhJcB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7920 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- The problem here is that it's all copied from the manual and as I'm the only one writing the manual I often just write as quickly as I can to get the content in there. Any style changes to the help files should be made in the manual as well since it's just a copy/paste effort. As for linking prefs - I'm A-OK with that. I do that in the manual, but was removing those links from the help files because I figured that we didn't want to link out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:03:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:03:20 +0000 Subject: [Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt In-Reply-To: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10191-70-XqekgAMD8T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Pushed to 3.12.x. Will be in 3.12.1. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:03:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:03:41 +0000 Subject: [Koha-bugs] [Bug 10297] New: categorycode and branchcode should be required for patrons Message-ID: <bug-10297-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Bug ID: 10297 Summary: categorycode and branchcode should be required for patrons Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com CC: drnoe at bywatersolutions.com, gmcharlt at gmail.com, kyle.m.hall at gmail.com The BorrowerMandatoryField pref should have categorycode and branchcode should be in the default values for this preference since they are required by Koha but not labeled as such on the patron add form. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:11:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:11:28 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10178-70-NFJ7DgSp9M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Pushed to 3.12.x. This will be in 3.12.1. Thanks! Note: this probably doesn't need to be applied to 3.10.x and older branches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:17:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:17:42 +0000 Subject: [Koha-bugs] [Bug 10297] categorycode and branchcode should be required for patrons In-Reply-To: <bug-10297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10297-70-ITnVkU5obv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #0) > The BorrowerMandatoryField pref should have categorycode and branchcode I would think instead they should be mandatory regardless of what is in BorrowerMandatoryField. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:28:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:28:21 +0000 Subject: [Koha-bugs] [Bug 10297] categorycode and branchcode should be required for patrons In-Reply-To: <bug-10297-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10297-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10297-70-EgHEiwzaOS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- That works for me too :) Anything that makes it clear that they're required. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:29:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:29:07 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-rsi1rHJXr3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10159 --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- This patch was shipped into 3.12.0. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:29:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:29:07 +0000 Subject: [Koha-bugs] [Bug 10159] koha-rebuild-zebra error handling In-Reply-To: <bug-10159-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10159-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10159-70-ln7DSFrqDN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10159 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10259 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:30:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:30:20 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-jynDfqKomM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10144, 10146 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:30:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:30:20 +0000 Subject: [Koha-bugs] [Bug 10146] koha-stop-zebra error handling In-Reply-To: <bug-10146-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10146-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10146-70-kyR4iqO3lh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10146 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10259 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:30:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:30:20 +0000 Subject: [Koha-bugs] [Bug 10144] koha-start-zebra error handling In-Reply-To: <bug-10144-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10144-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10144-70-gHqVBuNJKK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10144 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10259 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:32:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:32:07 +0000 Subject: [Koha-bugs] [Bug 10259] koha-*-zebra scripts are expected to run without warnings if no instance name passed In-Reply-To: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10259-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10259-70-xaJBy3VZOJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10259 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- For 3.8/3.10 maintainers: This patch applies on top of patches for the bugs marked as "depends on". If they happen to be backported too, this one should be applied. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:50:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:50:18 +0000 Subject: [Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma' In-Reply-To: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6399-70-VTPHbK245A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Pushed to 3.12.x. This will be on 3.12.1. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:52:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:52:09 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9288-70-HUqwTOtiqM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18203|0 |1 is obsolete| | --- Comment #11 from Adrien SAURAT <adrien.saurat at biblibre.com> --- Created attachment 18268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18268&action=edit Bug 9288 - Add a script to test SIP from the command line Tested OK for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 16:52:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 14:52:29 +0000 Subject: [Koha-bugs] [Bug 9288] Add a script to test SIP from the command line In-Reply-To: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9288-70-0xqLvZT8Ed@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9288 Adrien SAURAT <adrien.saurat at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 17:11:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 15:11:22 +0000 Subject: [Koha-bugs] [Bug 10298] New: t::lib::Mocks tries to deal with syspref but doesn not manage to Message-ID: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Bug ID: 10298 Summary: t::lib::Mocks tries to deal with syspref but doesn not manage to Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 17:11:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 15:11:35 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10298-70-MYeqA91SQe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 17:31:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 15:31:39 +0000 Subject: [Koha-bugs] [Bug 5943] Merging Authorities In-Reply-To: <bug-5943-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5943-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5943-70-dMUMohXG57@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5943 --- Comment #5 from Nicole C. Engard <nengard at gmail.com> --- This is still desired - can we get a new patch? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 17:46:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 15:46:00 +0000 Subject: [Koha-bugs] [Bug 10299] New: authorities plugin putting values in reverse order Message-ID: <bug-10299-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299 Bug ID: 10299 Summary: authorities plugin putting values in reverse order Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nengard at gmail.com CC: m.de.rooy at rijksmuseum.nl Created attachment 18269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18269&action=edit authority plugin with reverse order This is hard to explain, so please see the attached image. If you click the plugin next to an authority field that is already populated it takes the values from the field and puts them in the search in the reverse order. So in the image, the field has PA, Phila, Fiction but then when you click on the plugin it reorders them as Fiction, Phila, PA. The order should match. Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 18:14:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 16:14:48 +0000 Subject: [Koha-bugs] [Bug 10300] New: Revert Bug 8781 - Access to Transfer page while "independent branches" is on Message-ID: <bug-10300-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Bug ID: 10300 Summary: Revert Bug 8781 - Access to Transfer page while "independent branches" is on Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com This bug needs reverted, this explanation was given to me by a librarian: For our group it is useful in order to allow the library to "fix" items that they receive from other libraries for holds requests that have either not been transferred properly by the lending library, so the item was never processed through check in to be placed "in transit," -- there are frequent enough occasions when a library is filling hold requests from their queue and the transfer is not completely placed into effect -- the status will be changed to "in transit" but the "Current Location" is not updated to the borrowing library. In these instances, the item arrives at the borrowing location, they scan it at check in and get the message "Item must be checked in at home library." In both of these cases, without the "Transfer" ability, I have to make the transfer for them. This is not a workable situation. It is far too manual a system if I have to personally transfer items to libraries myself to correct both of these situations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 18:15:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 16:15:58 +0000 Subject: [Koha-bugs] [Bug 10301] New: notes not showing on receive page Message-ID: <bug-10301-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10301 Bug ID: 10301 Summary: notes not showing on receive page Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com Created attachment 18270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18270&action=edit note shows This is true in master, 3.12 and 3.10.x. See attached. When you have a note on a title in acq if you click receive that note does not show - it should show here because most notes are left for those receiving. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 18:16:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 16:16:15 +0000 Subject: [Koha-bugs] [Bug 10301] notes not showing on receive page In-Reply-To: <bug-10301-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10301-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10301-70-kT9gnrZGzM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10301 --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- Created attachment 18271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18271&action=edit note not carried over -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 18:16:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 16:16:51 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-Gljs6fCPKo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Just a question: +function IEEventHandler_KeyDown() { + if (event.keyCode == 13 && event.srcElement.type != 'textarea' && event.srcElement.type != 'submit') + return false; + return true; +} But am I missing a parameter here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 18:21:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 16:21:59 +0000 Subject: [Koha-bugs] [Bug 10300] Revert Bug 8781 - Access to Transfer page while "independent branches" is on In-Reply-To: <bug-10300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10300-70-WxqeHED81Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18272&action=edit Bug 10300 - Revert Bug 8781 - Access to Transfer page while "independent branches" is on This bug needs reverted, this explanation was given to me by a librarian: For our group it is useful in order to allow the library to "fix" items that they receive from other libraries for holds requests that have either not been transferred properly by the lending library, so the item was never processed through check in to be placed "in transit," -- there are frequent enough occasions when a library is filling hold requests from their queue and the transfer is not completely placed into effect -- the status will be changed to "in transit" but the "Current Location" is not updated to the borrowing library. In these instances, the item arrives at the borrowing location, they scan it at check in and get the message "Item must be checked in at home library." In both of these cases, without the "Transfer" ability, I have to make the transfer for them. This is not a workable situation. It is far too manual a system if I have to personally transfer items to libraries myself to correct both of these situations. Test Plan: 1) As a non-superlibrarian, navigate to circulation-home.pl 2) Note the transfer option is non-existant 3) Apply this patch 4) Refresh circulation-home.pl 5) Note the transfer option is displayed This reverts commit c101f779e587217ae5ac46ee18aa0292c30aa808. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 18:21:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 16:21:58 +0000 Subject: [Koha-bugs] [Bug 10300] Revert Bug 8781 - Access to Transfer page while "independent branches" is on In-Reply-To: <bug-10300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10300-70-QtREXlcIs4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 18:22:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 16:22:14 +0000 Subject: [Koha-bugs] [Bug 10300] Revert Bug 8781 - Access to Transfer page while "independent branches" is on In-Reply-To: <bug-10300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10300-70-Z7qtaDrlVc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 18:25:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 16:25:59 +0000 Subject: [Koha-bugs] [Bug 10302] New: order from staged showing inactive funds Message-ID: <bug-10302-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10302 Bug ID: 10302 Summary: order from staged showing inactive funds Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All URL: /cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id =59&basketno=7&booksellerid=1 OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com When ordering from a staged file you see all funds ever used in the system - including ones that have since been marked inactive. This does not happen with any other type of order - just the order from staged file: /cgi-bin/koha/acqui/addorderiso2709.pl?import_batch_id=59&basketno=7&booksellerid=1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 18:35:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 16:35:36 +0000 Subject: [Koha-bugs] [Bug 7130] quantity to receive showing wrong amount In-Reply-To: <bug-7130-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7130-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7130-70-Ca3H6318mF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7130 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Nicole C. Engard <nengard at gmail.com> --- I think this is resolved in recent releases of Koha -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 19:13:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 17:13:25 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10080-70-OfIik5I4U0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 19:13:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 17:13:27 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10080-70-Qnw5xJ0v9F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18273&action=edit Bug 10080 - Change system pref IndependantBranches to IndependentBranches - Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 19:52:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 17:52:04 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-4U7S8NwhMK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #120 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18274&action=edit bug 8215: (followup) run new files through perltidy Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 19:52:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 17:52:44 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-4fh2E5w4kV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 19:52:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 17:52:48 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-n0LfyCrNut@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #121 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18275&action=edit bug 8215: (followup) make sure C4::CourseReserves doesn't export anything New modules should not export any symbols by default without a very good reason. Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 19:52:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 17:52:59 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-x7yAsoyKZ5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #122 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18276&action=edit bug 8215: (followup) don't allow deleting course reserves from OPAC Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 19:53:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 17:53:09 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-14dFxLaJbu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #123 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18277&action=edit bug 8215: (followup) avoid SQL syntax error in logs ModItem currently will attempt to update an item even if no field updates are specified. This patch avoids (harmless) error messages in the Apache logs if an item is not actually being changed when it is placed or taken off reserve. Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 19:53:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 17:53:15 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-evDuvOYeYs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #124 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18278&action=edit bug 8215: (followup) rename GetItemReservesInfo Renamed that routine to GetItemCourseReservesInfo in order to avoid any potential confusion with reserves qua hold requests. Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 19:53:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 17:53:21 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-oM6CgEfjhi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #125 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18279&action=edit bug 8215: (followup) remove extraneous underscore in template Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 19:57:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 17:57:42 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-C5w5F3zbzB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #126 from Galen Charlton <gmcharlt at gmail.com> --- I have attached six follow-up patches to deal with the following issues: - perltidy - ensuring that the new C4::CourseReserves module does not export any symbols by default - dealing with a copy-pasto that would have allowed unprivileges users to delete course reserves via the OPAC - cleaning up after a couple spurious warning messages that could appear in the Apachelogs - a template typo fix - renaming a method that could be confused with one that might be used for reserves qua hold requests All of this is also available in the new/bug_8215_merge_candidate branch as well. Upon QA review of my follow-up patches, I am prepared to merge this to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 20:07:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 18:07:56 +0000 Subject: [Koha-bugs] [Bug 10303] Cannot create item with no barcode with autoBarcode disabled In-Reply-To: <bug-10303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10303-70-dYdQ836Cfs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10303 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 20:07:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 18:07:52 +0000 Subject: [Koha-bugs] [Bug 10303] New: Cannot create item with no barcode with autoBarcode disabled Message-ID: <bug-10303-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10303 Bug ID: 10303 Summary: Cannot create item with no barcode with autoBarcode disabled Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com CC: m.de.rooy at rijksmuseum.nl Even if autobarcode is set to off, items will get a barcode. This barcode may be a duplicate in which case the item fails to be created with no error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 20:09:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 18:09:14 +0000 Subject: [Koha-bugs] [Bug 7883] save and continue editing In-Reply-To: <bug-7883-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7883-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7883-70-O4agjEdGNg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7883 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Elliott! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 20:29:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 18:29:25 +0000 Subject: [Koha-bugs] [Bug 9812] Several files shouldn't be exposed or browseable through a URL In-Reply-To: <bug-9812-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9812-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9812-70-NV70Uet2O2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9812 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion Severity|blocker |normal --- Comment #16 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #13) > Just a *dumb* question: But why should these "open source files" -- by no > means :) -- be exposed through the browser? > Much of this stuff will be from the standard install, available online > elsewhere. > Some small customizations are probably not of a "to be hidden nature". > The larger custom work that for some reason should not be public (pity btw! > we encourage to submit patches) can be hidden by a pro :) > > Not in any way wanting to discourage your sending of patches! Well, the motivation isn't to hide code or customizations per se, it's to reduce the risk that the webserver could be made to send out sensitive configuration information, e.g., DB passwords or the like. In this specific case, there isn't anything (to my knowledge) in modules, xslt, and includes that would be useful to an attacker, although I could certainly see a customizer getting lazy and (say) hardcoding credentials into a template. The upshot is that I see this patch as a useful direction to be thinking towards, and I'm not opposed to pushing it (once Tom?s' concerns are addressed), but I think even better would be to move Since the revert is done, I'm setting this one to in discussion. I'm also setting the the criticality back to 'normal'. If there is a *specific* security issue that warrants blocker status, please let me know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 20:29:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 18:29:37 +0000 Subject: [Koha-bugs] [Bug 9812] Several files shouldn't be exposed or browseable through a URL In-Reply-To: <bug-9812-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9812-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9812-70-aDY1gIBVOg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9812 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 20:29:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 18:29:42 +0000 Subject: [Koha-bugs] [Bug 9812] Several files shouldn't be exposed or browseable through a URL In-Reply-To: <bug-9812-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9812-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9812-70-qae1Vnqt17@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9812 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 21:26:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 19:26:38 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-AL2IAm8jbf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #16 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #9) > One remark. IMO this pref and MaxFine should really be at the Circulation > tab under Fines policy. All other Patron prefs have no direct connection to > Circulation as well as Fines. To agree with and intensify what Marcel said ... IMO this *really* needs to be an attribute of issuingrules, not a system preference. Different libraries sharing a Koha database might have different preferences on setting the max fine, and I can imagine cases where a library might want this to vary by item type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 21:28:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 19:28:07 +0000 Subject: [Koha-bugs] [Bug 10303] Cannot create item with no barcode with autoBarcode disabled In-Reply-To: <bug-10303-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10303-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10303-70-ouLozM7aZc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10303 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 21:48:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 19:48:17 +0000 Subject: [Koha-bugs] [Bug 10304] New: Filter notforloan items when searching for only available items Message-ID: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Bug ID: 10304 Summary: Filter notforloan items when searching for only available items Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com It does not make sense for the "available items only" search limit to include results for items that are not for loan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 21:51:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 19:51:38 +0000 Subject: [Koha-bugs] [Bug 10304] Filter notforloan items when searching for only available items In-Reply-To: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10304-70-SgavBXCmBU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18280&action=edit Bug 10304 - Filter notforloan items when searching for only available items It does not make sense for the "available items only" search limit to include results for items that are not for loan. Test Plan: 1) Catalog 3 records with 1 or more items each, make the first two records' items available for loan, and the third record's items not for loan. 2) Do a search limiting only to available items 3) Note all 3 records are in the search results 4) Apply this patch 5) Refresh the search results 6) Note the third record ( with only not for loan items ) is no longer in the search results list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 21:51:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 19:51:37 +0000 Subject: [Koha-bugs] [Bug 10304] Filter notforloan items when searching for only available items In-Reply-To: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10304-70-zrsSRxCJlx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 21:56:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 19:56:37 +0000 Subject: [Koha-bugs] [Bug 10304] Filter notforloan items when searching for only available items In-Reply-To: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10304-70-i9brWuu1nv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 21:58:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 19:58:38 +0000 Subject: [Koha-bugs] [Bug 10305] New: Duplicate code in Search.pm Message-ID: <bug-10305-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 Bug ID: 10305 Summary: Duplicate code in Search.pm Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com For some reason, _increment_barcode is called twice in succession in cataloguing/additem.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:00:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:00:23 +0000 Subject: [Koha-bugs] [Bug 10304] Filter notforloan items when searching for only available items In-Reply-To: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10304-70-EgdUCzWvYH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:00:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:00:35 +0000 Subject: [Koha-bugs] [Bug 10305] Duplicate code in Search.pm In-Reply-To: <bug-10305-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10305-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10305-70-fm4HO07ZGb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:00:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:00:36 +0000 Subject: [Koha-bugs] [Bug 10305] Duplicate code in Search.pm In-Reply-To: <bug-10305-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10305-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10305-70-JeyVTPVLsW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18281&action=edit Bug 10305 - Duplicate code in Search.pm For some reason, _increment_barcode is called twice in succession in cataloguing/additem.pl Test Plan: 1) Enable autobarcode = incremental 2) Catalog an item, not the barcode 3) Apply this patch 4) Catalog another item, the barcode should be the next in line as previously. No change should be noted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:00:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:00:44 +0000 Subject: [Koha-bugs] [Bug 10305] Duplicate code in Search.pm In-Reply-To: <bug-10305-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10305-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10305-70-QS36aW6L0z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:00:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:00:51 +0000 Subject: [Koha-bugs] [Bug 10305] Duplicate code in Search.pm In-Reply-To: <bug-10305-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10305-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10305-70-IcROVHfV7X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:06:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:06:10 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-i6BrUtkWFO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #127 from Kyle M Hall <kyle.m.hall at gmail.com> --- Not that I feel strongly about it, but I thought our official perltidy stance was to use the default perltidy configuration ( http://wiki.koha-community.org/wiki/Perltidy ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:07:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:07:31 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-zCBxBaDsi5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #128 from Kyle M Hall <kyle.m.hall at gmail.com> --- Also, thanks for the followups Galen! Much appreciated! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:25:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:25:40 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-MDRsQPcM7H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17894|0 |1 is obsolete| | Attachment #17895|0 |1 is obsolete| | Attachment #17896|0 |1 is obsolete| | Attachment #17897|0 |1 is obsolete| | Attachment #17898|0 |1 is obsolete| | Attachment #17899|0 |1 is obsolete| | Attachment #18274|0 |1 is obsolete| | Attachment #18275|0 |1 is obsolete| | Attachment #18276|0 |1 is obsolete| | Attachment #18277|0 |1 is obsolete| | Attachment #18278|0 |1 is obsolete| | Attachment #18279|0 |1 is obsolete| | --- Comment #129 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18282&action=edit Bug 8215 - Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Test Plan: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Corinne Bulac <corinne.hayet at bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> http://bugs.koha-community.org/show_bug.cgi?id=8125 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:25:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:25:52 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-2JWTZYG1aR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #130 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18283&action=edit Bug 8215 follow-up encoding for branches & itemtypes Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Corinne Bulac <corinne.hayet at bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:26:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:26:03 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-ZPq6g0GkLm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #131 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18284&action=edit Bug 8215: Followup FIX QA issues Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:26:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:26:15 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-ngenFKZ0HR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #132 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18285&action=edit Bug 8215 - Add Course Reserves - QA Followup Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:26:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:26:26 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-5Bru9wg18l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #133 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18286&action=edit Bug 8215: Followup Fix confirmation links for delete course and item Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:26:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:26:34 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-vZfL2h2DhO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #134 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18287&action=edit Bug 8215: FIX ergonomic issue : 'Unchanged()' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:26:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:26:43 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-maQseVUV4T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #135 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18288&action=edit bug 8215: (followup) run new files through perltidy Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:26:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:26:52 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-6DZ9jlVdZL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #136 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18289&action=edit bug 8215: (followup) make sure C4::CourseReserves doesn't export anything New modules should not export any symbols by default without a very good reason. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:27:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:27:01 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-DepcwHCZul@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #137 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18290&action=edit bug 8215: (followup) don't allow deleting course reserves from OPAC Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:27:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:27:10 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-XSk1Tkq7qU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #138 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18291&action=edit bug 8215: (followup) avoid SQL syntax error in logs ModItem currently will attempt to update an item even if no field updates are specified. This patch avoids (harmless) error messages in the Apache logs if an item is not actually being changed when it is placed or taken off reserve. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:27:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:27:19 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-sSk0NhUuNv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #139 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18292&action=edit bug 8215: (followup) rename GetItemReservesInfo Renamed that routine to GetItemCourseReservesInfo in order to avoid any potential confusion with reserves qua hold requests. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:27:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:27:28 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-LVJr7RrxvB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #140 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18293&action=edit bug 8215: (followup) remove extraneous underscore in template Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 21 22:31:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 20:31:04 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-vG8BTpjncz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #141 from Kyle M Hall <kyle.m.hall at gmail.com> --- Passes koha-qa.pl, tested and works with all followups, inspection of followups reveals nothing untoward. Passing QA on Galen's followups. I am the author of the original patch, so if it is deemed inappropriate for me to pass qa on this bug, please slap me with a large trout and reset the status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 00:51:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 22:51:55 +0000 Subject: [Koha-bugs] [Bug 8519] Make koha-index-daemon run on startup In-Reply-To: <bug-8519-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8519-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8519-70-uLXc8HPzoo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- This patch shipped with 3.12.0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 01:02:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 23:02:52 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-tgGjTaDMXb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #142 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #141) > Passes koha-qa.pl, tested and works with all followups, inspection of > followups reveals nothing untoward. Passing QA on Galen's followups. > > I am the author of the original patch, so if it is deemed inappropriate for > me to pass qa on this bug, please slap me with a large trout and reset the > status. No trout necessary, IMO -- the patch series as a whole has seen sufficient attention by other QA team members, and as original author of the patch, you're in a good position to evaluate the followups. Pushed (along with a one-liner follow-up that I missed attaching to this bug) to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 01:55:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 21 May 2013 23:55:31 +0000 Subject: [Koha-bugs] [Bug 6413] Notes in Fines doing wonky things In-Reply-To: <bug-6413-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6413-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6413-70-dfLYv1NSDY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6413 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #69 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Chris, Paul, and Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 02:09:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 00:09:33 +0000 Subject: [Koha-bugs] [Bug 10284] Missing spaces between label and content in XSLT view for 785/780 In-Reply-To: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10284-70-9XygBGPzdD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 02:09:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 00:09:34 +0000 Subject: [Koha-bugs] [Bug 10284] Missing spaces between label and content in XSLT view for 785/780 In-Reply-To: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10284-70-vPlZvCJD07@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18245|0 |1 is obsolete| | --- Comment #5 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18294&action=edit Bug 10284: Add missing spaces between label and content in XSLT view (780/785) To test: - Check OPAC and intranet XSLT view for a record that contains 780 and 785 fields. - Verify there is no space between the label and the content of the field. - Apply patch. - Verify the display both in intranet and OPAC is a little nicer now. Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 02:18:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 00:18:21 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10218-70-9h9USgi0tj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 02:18:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 00:18:22 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10218-70-hthhUNICWY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18119|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18295&action=edit Bug 10218 - In OPAC XSLT search results, add class to 'online access' In some cases in OPAC search results and the detail page there is a class specific to each line of data being output (publisher, date, subjects, etc). In other cases there is no additional class. This patch makes modifications to a few different OPAC files in an attempt to make them consistent with each other. To test, apply the patch and view: - an OPAC detail page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay on Labels should have classes relevant to their data. To test the specific case requested by this bug, view details/results for a record which includes online resources (856u in MARC21). Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 02:23:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 00:23:12 +0000 Subject: [Koha-bugs] [Bug 10305] Duplicate code in Search.pm In-Reply-To: <bug-10305-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10305-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10305-70-70HyLSL58V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10305 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |gmcharlt at gmail.com --- Comment #2 from Galen Charlton <gmcharlt at gmail.com> --- The patch itself looks OK, the patch title is clearly wrong. Please update the patch title (and the bug title) to reflect the actual problem, which is that _increment_barcode is called twice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 03:27:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 01:27:03 +0000 Subject: [Koha-bugs] [Bug 10306] New: acquisitions shows publisher from 260 only Message-ID: <bug-10306-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Bug ID: 10306 Summary: acquisitions shows publisher from 260 only Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com The acquisitions module show publisher info from the 260, but now libraries are using RDA and need the 264 to show if there is no 260. This is easy enough on XSLT styled pages, but acquisitions is not one of those. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 03:49:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 01:49:32 +0000 Subject: [Koha-bugs] [Bug 10307] New: z39.50 server search tab shows z390.50 Message-ID: <bug-10307-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10307 Bug ID: 10307 Summary: z39.50 server search tab shows z390.50 Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jurgens.b at xtra.co.nz Created attachment 18296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18296&action=edit Screen capture showing the mislabled tab. On the z39.50 administration page the tab underneath the search bar shows "Search z390.50 servers" - there is an extra 0 after the 9 - I believe it should just read "Search z39.50 servers". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 04:35:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 02:35:54 +0000 Subject: [Koha-bugs] [Bug 10308] New: Authorities linker should handle the "local subject added entry" fields. Message-ID: <bug-10308-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308 Bug ID: 10308 Summary: Authorities linker should handle the "local subject added entry" fields. Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: robin at catalyst.net.nz CC: m.de.rooy at rijksmuseum.nl In MARC21, 690-699 are for locally defined subjects. These should be linked up to their appropriate authorities by the linker too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 04:36:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 02:36:03 +0000 Subject: [Koha-bugs] [Bug 10308] Authorities linker should handle the "local subject added entry" fields. In-Reply-To: <bug-10308-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10308-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10308-70-mMgw7QRvTw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 05:30:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 03:30:28 +0000 Subject: [Koha-bugs] [Bug 10308] Authorities linker should handle the "local subject added entry" fields. In-Reply-To: <bug-10308-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10308-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10308-70-NNwZpQZWPJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308 --- Comment #1 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 18297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18297&action=edit Bug 10308 - local subjects can use authorities too This adds entries for 690-699 to the authorities linker, so they get linked up like everything else. To Test: * make sure your framework doesn't have 690 set up to link to authorities (or it'll get linked as part of cataloguing.) * add a subject with some term to the 690$a field. * add an authority for TOPIC_TERM with the matching term. * make sure zebra is up to date. * run link_bibs_to_authorities.pl over your system. * check that the authority is now linked to your record. * repeat with the other 69x fields if you like. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 05:30:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 03:30:41 +0000 Subject: [Koha-bugs] [Bug 10308] Authorities linker should handle the "local subject added entry" fields. In-Reply-To: <bug-10308-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10308-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10308-70-Pkv6dhi9R3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 08:03:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 06:03:35 +0000 Subject: [Koha-bugs] [Bug 10301] notes not showing on receive page In-Reply-To: <bug-10301-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10301-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10301-70-1cRc0yPF3z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10301 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.10 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 08:13:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 06:13:55 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-36DMJGwSeY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, I think Marcel meant the the Patrons tab in the system preference editor is not the right place, but that it should be in Circulation. With 3.12 we have MaxFine in the circulation matrix - not sure how the best way would be to indicate that it should be using the replacement price there. It's an input field, so maybe a checkbox that implies 'replacement price' and deactivates the maxfine input field? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 08:16:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 06:16:59 +0000 Subject: [Koha-bugs] [Bug 10304] Filter notforloan items when searching for only available items In-Reply-To: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10304-70-9PqKz2Rth7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Kyle, sorry, but I disagree here. As I understand it available does not necessarily imply that you can check the item out, but that it's currently available (on the shelf) in the library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 08:35:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 06:35:21 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-WYL12XBKTM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Some notes for reproducing this: - you need to make p and n visible in the MARC editor, to make it possible to catalog the attached example. - You also have to make sure you have a matching 490 field with the first indicator = 1, else the information is pulled from the 490 field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 08:37:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 06:37:47 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-nMRE1nJtNq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The problem is somewhere in the part template that deals with the n and p subfields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 08:46:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 06:46:42 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-noWD95td7U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Do we only want spaces? Or is there some other punctuation needed between those fields? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 09:44:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 07:44:40 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-nOUdVcfAZd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #3) > Just a question: > > +function IEEventHandler_KeyDown() { > + if (event.keyCode == 13 && event.srcElement.type != 'textarea' && > event.srcElement.type != 'submit') > + return false; > + return true; > +} > > But am I missing a parameter here? Humm, I just factorize the code, so it is not a regression. I don't have IE for testing it. In fact event is a global object, it is not necessary to pass it in parameters. This code should work I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 09:56:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 07:56:10 +0000 Subject: [Koha-bugs] [Bug 10267] No error message when entering an invalid cardnumber In-Reply-To: <bug-10267-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10267-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10267-70-m2kzn98aqJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10267 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think I'd like to see a combination of JavaScript warning and maxlength. 16 seems like a reasonable size for a cardnumber, but not sure if there are use cases where a longer number would be needed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 10:04:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 08:04:21 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7688-70-Fy8vTKWiLt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17855|0 |1 is obsolete| | --- Comment #94 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 18298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18298&action=edit [PASSED-QA] Bug 7688: Change subscription numbering pattern and frequencies Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 10:04:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 08:04:40 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7688-70-Uk93XOCgZC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17856|0 |1 is obsolete| | --- Comment #95 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 18299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18299&action=edit [SIGNED-OFF] Bug 7688: Set firstacquidate in updatedatabase if it's not set firstacquidate is now a mandatory field, so it must be set. The updatedatabase process set firstacquidate value to one of: - the planned date of the first serial for this subscription, or if not found, - the subscription start date. + auto-select the numbering pattern when modifying a subscription. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 10:05:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 08:05:10 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7688-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7688-70-FknKlNwVIh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17857|0 |1 is obsolete| | --- Comment #96 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 18300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18300&action=edit [SIGNED-OFF] Bug 7688: Rewrite t/db_dependant/Serials.t A lot of tests were just a call to a funtion without any arguments, whereas the function expect at least one argument. These tests were kept, but all return values are now undef when a mandatory argument is missing, so return values are consistent. The part where subscription periodicity is changed could not work because of ',' appended to each key in ModSubscription call. So it's rewritten, taking into account the new API for subscription frequencies. This script should leave your database intact because it revert any modification made. Also fix some warnings in C4::Serials and in C4::Items. And fix a typo in koha-tmpl/.../subscription-numberpatterns.tt Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Comment: Work as described. No errors Tested, again, without trouble. With a suscription, tests successful. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 11:07:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 09:07:50 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10298-70-UDzHE3yk0Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18302&action=edit Bug 10298: Adapt existing code set_solr and set_zebra is not really useful. It is preferable to use mock_preference directly. To test: 1/ Launch Solr 2/ prove -r t/searchengine/ It should produce: % prove -r t/searchengine/ t/searchengine/000_conn/conn.t ........... ok t/searchengine/001_search/search_base.t .. ok t/searchengine/002_index/index_base.t .... IndexRecord called with biblio 2 Indexing biblio 2 t/searchengine/002_index/index_base.t .... ok t/searchengine/003_query/buildquery.t .... ok t/searchengine/004_config/load_config.t .. ok All tests successful. Files=5, Tests=21, 4 wallclock secs ( 0.03 usr 0.01 sys + 2.74 cusr 0.20 csys = 2.98 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 11:07:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 09:07:46 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10298-70-cPoZSfdEFD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18301&action=edit Bug 10298: Mock C4::Context->preference t::lib::Mocks::Context tried to deal with preferences but did not manage to. This patch removes this module and add 2 routines in t::lib::Mocks in order to mock C4::context->preference and C4::Context->config. To test: ===START t/test.pl=== use Modern::Perl; use t::lib::Mocks; use C4::Context; say "initial value for version: " . C4::Context->preference('Version'); say "initial value for language: " . C4::Context->preference('language'); t::lib::Mocks::mock_preference('Version', "new version for testing"); say "version is mocked with: " . C4::Context->preference('Version'); say "language is not yet mocked: " . C4::Context->preference('language'); t::lib::Mocks::mock_preference('language', 'new langage for testing'); t::lib::Mocks::mock_preference('Version', 'another version for testing'); say "version is mocked with another value: " . C4::Context->preference('Version'); say "language is finally mocked: " . C4::Context->preference('language'); ===END=== Try to execute this file and check that the output is consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 11:11:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 09:11:23 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10298-70-KBXZOAo1N2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 11:11:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 09:11:31 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10298-70-nysyVZAcX2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 11:13:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 09:13:27 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-KHfdXldNzD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #88 from Jonathan Druart <jonathan.druart at biblibre.com> --- Kyle, did you have a look at my unit tests? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 11:25:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 09:25:51 +0000 Subject: [Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x In-Reply-To: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10293-70-SE6fAjbCyZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 11:25:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 09:25:53 +0000 Subject: [Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x In-Reply-To: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10293-70-SjGqM5YKar@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18264|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18303&action=edit Bug 10293 - Bug 9930 needs to be reverted for 3.10.x The patch for bug 9930 needs to be reverted for 3.10.x, as the patron self registration feature is not part of 3.10.x. With the patch applied, the OPAC patron details link may redirect to a non-existent page ( opac-memberentry.pl ). Test Plan: 1) Set OPAC to use CCSR theme. 2) Log into the OPAC. 3) Click the link for your username. 4) Click the "my personal details" tab. 5) Note the error page you get 6) Apply this patch 7) Refresh the page 8) You should now see the user details update page This reverts commit e5186d6d784c1fdd8d12c6e93e163d0b9e10cc0e. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 11:28:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 09:28:08 +0000 Subject: [Koha-bugs] [Bug 10272] CheckReserves returns not respecting ReservesControlBranch In-Reply-To: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10272-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10272-70-H1BabrzY7l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10272 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Kyle, The new routine GetReservesControlBranch needs a unit test. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 12:17:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 10:17:36 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-DH3Gsf1iaS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 --- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #4) > I don't have IE for testing it. :) I would not recommend IE too for the staff client. But if you change code related to IE, it still would be an idea to test it somehow? > In fact event is a global object, it is not necessary to pass it in > parameters. Yes, you are right (of course). As a purist, you could perhaps say that it should be even better to refer to window.event. With Google, I came across this example for a cross-browser solution: element.onclick = doSomething; function doSomething(e) { if (!e) var e = window.event; // e gives access to the event in all browsers } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 12:29:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 10:29:11 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-B8hmVW4hOr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #5) > With Google, I came across this example for a cross-browser solution: > > element.onclick = doSomething; > function doSomething(e) { > if (!e) var e = window.event; > // e gives access to the event in all browsers > } Yep I think the code can be improved, but the goal of this patch is only to factorize the code. When this patch will be pushed, it will be easy to improve it: there will be only 1 place to change :) Don't you agree with me? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 12:40:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 10:40:57 +0000 Subject: [Koha-bugs] [Bug 7718] Remove itemnumber column from serials table In-Reply-To: <bug-7718-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7718-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7718-70-BldK7gNN3E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: This patch removes a useless (since the table serialitems exist) column. I agree with Bernardo, I did not find any occurrence of this column. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 12:41:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 10:41:08 +0000 Subject: [Koha-bugs] [Bug 7718] Remove itemnumber column from serials table In-Reply-To: <bug-7718-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7718-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7718-70-Ws8zGkrgkl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 12:41:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 10:41:25 +0000 Subject: [Koha-bugs] [Bug 7718] Remove itemnumber column from serials table In-Reply-To: <bug-7718-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7718-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7718-70-FZxvRUqVDF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15073|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18304&action=edit Bug 7718 - Remove itemnumber column from serials table Remove the column 'itemnumber' from the table 'serial'. This is a 1 to many relationship, and this reference does not make sense. The 'serialitems' table handles the relationship between the 'items' table and the 'serial' table. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify serial.itemnumber has been removed from the database Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Column removed. No errors. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 12:44:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 10:44:02 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-p7N6K0ZjQJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 --- Comment #7 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #6) > Yep I think the code can be improved, but the goal of this patch is only to > factorize the code. > Don't you agree with me? Yes, I agree. Will try to qa this today. BTW As a non-native English speaker, I think you mean to refactor the code. I thought factorizing was 12=3*2*2 :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 12:53:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 10:53:27 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-HKSIKwxGRa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 --- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #7) > BTW As a non-native English speaker, I think you mean to refactor the code. > I thought factorizing was 12=3*2*2 :-) Ooops :-/ Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 12:53:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 10:53:38 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-00pipbIobh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15015|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18305&action=edit Bug 9507: prevent submit: refactor some code in a js file This patch refactores code in a js file. Test plan: On acqui/neworderempty.pl, acqui/orderreceive.pl and serials/serials-edit.tt try to scan a barcode (or press enter) on the form and check that it is not sent. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 13:02:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 11:02:38 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-5cCgk4XOko@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: I never understand why 2 includes files are present. What is the way to keep just one of them? The patch fixes the described issue. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 13:02:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 11:02:50 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-L6ino19GIi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18249|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18306&action=edit Bug 10261 [Revised] Link to patron files missing from circ-menu.tt The link to patron files doesn't appear on some pages. That's because the link was added to circ-menu.inc but not circ-menu.tt. Each is used by different patron-related pages. This patch adds the missing link. To test, enable the EnableBorrowerFiles system preference and view members/pay.pl or members.paycollect.pl. The "Files" tab should appear in the left-hand sidebar menu. Other patron pages should show the same. Edit: Corrected scope of template variables which shouldn't have been copied directly from circ-menu.inc without changing scope. Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> all tests pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:00:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:00:11 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-w1VLQ1QUy4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #89 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to comment #88) > Kyle, did you have a look at my unit tests? These are fantastic! Everything passes except the last test for SimpleMARC.t Also, test 14 has no description. Thanks for pointing me to your git branch. ok 1 - use MARC::Field; ok 2 - use MARC::Record; ok 3 - use Koha::SimpleMARC; ok 4 - 650$a exists ok 5 - 650$b does not exist ok 6 - 650$a exists, field_exists returns the first one ok 7 - first 650$a ok 8 - second 650$a ok 9 - first 650$a bis ok 10 - second 650$a bis ok 11 - There is no 3 650$a ok 12 - After copy 245$a still exists ok 13 - 246$a is a new field ok 14 ok 15 - Copy multivalued field ok 16 - Copy first field 650$a ok 17 - Copy second field 650$a ok 18 - Copy field using regex ok 19 - Copy fields using regex on existing fields ok 20 - Copy first field using regex on existing fields without erase existing values ok 21 - Copy fields using regex on existing fields without erase existing values ok 22 - update existing subfield 952$p ok 23 - create subfield 952$p ok 24 - create subfield 952$k on existing 952 field ok 25 - update all subfields 952$p with the same value ok 26 - update all subfields 952$p with the different values ok 27 - copy 952$d into others 952 field ok 28 - The first 952$c has moved not ok 29 - Now the second 952$c exists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:00:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:00:19 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10080-70-ZqxdPXTaJR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|m.de.rooy at rijksmuseum.nl |jonathan.druart at biblibre.co | |m --- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: Looks good to me now. The only occurrences are git grep -l IndependantBranches | grep -v translator installer/data/mysql/updatedatabase.pl misc/release_notes/release_notes_30004.txt misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_12_0.txt We have to keep this patch in mind for future patch! I will provide a patch for the qa tools. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:00:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:00:24 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-6IEfRcFZI5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:00:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:00:54 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10080-70-8iWBUKUTCj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 --- Comment #17 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18308&action=edit Bug 10080 - Change system pref IndependantBranches to IndependentBranches - Followup Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:00:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:00:50 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10080-70-AQc37jRiv8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18155|0 |1 is obsolete| | Attachment #18273|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18307&action=edit Bug 10080 - Change system pref IndependantBranches to IndependentBranches Test Plan: 1) Enable IndependantBranches 2) Apply this patch 3) Run updatedatabase.pl 4) Verify that the system preference still functions correctly Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:02:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:02:41 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-21r90gj53D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 --- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18309&action=edit Bug 9507: prevent submit: refactor some code in a js file This patch refactors code in a js file. Test plan: On acqui/neworderempty.pl, acqui/orderreceive.pl and serials/serials-edit.tt try to scan a barcode (or press enter) on the form and check that it is not sent. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Have to note that the code for IE9 does not work. Before and after this patch. If we refactor code, it would have been nice to resolve this too. But I do not oppose pushing this patch. The test uses 'an ancient Netscape property' window.Event (uppercase!) to make the distinction between browers and event models. Some more documentation here would be welcome too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:03:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:03:15 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-BBWdJTN6l5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:03:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:03:17 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-JJcpiy0DR9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18305|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:03:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:03:35 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-Oc4XT101gg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:04:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:04:37 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-9wKVxjrb4O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18309|0 |1 is obsolete| | --- Comment #11 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18310&action=edit Bug 9507: prevent submit: refactor some code in a js file This patch refactors some code in a js file. Test plan: On acqui/neworderempty.pl, acqui/orderreceive.pl and serials/serials-edit.tt try to scan a barcode (or press enter) on the form and check that it is not sent. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Have to note that the code for IE9 does not work. Before and after this patch. If we refactor code, it would have been nice to resolve this too. But I do not oppose pushing this patch. The test uses 'an ancient Netscape property' window.Event (uppercase!) to make the distinction between browers and event models. Some more documentation here would be welcome too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:07:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:07:04 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-hy9N48LQxi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- QA Comment: See signoff. Tested under FF. Works well. Tested under IE9. Does not work before or after. No complaints from qa-tools. Passing QA but with some reluctancy as noted. With appreciation for the intention to improve code BTW! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:07:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:07:59 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-r90UGzVNB1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:21:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:21:15 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-oAgoiIRiRO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #90 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #89) > These are fantastic! Everything passes except the last test for SimpleMARC.t > not ok 29 - Now the second 952$c exists Yep, it was I said in comment 85 ("One test does not pass and I think it should."). So is there a bug in move_field? Or my test is bad (but I don't think so). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 14:33:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 12:33:26 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-kcEYWurlwY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #18 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #17) > Hm, I think Marcel meant the the Patrons tab in the system preference editor > is not the right place, but that it should be in Circulation. That is actually what I meant to write, taking one step at a time. But Galen is two steps further and I agree with him too :) It is confusing to configure circulation on two platforms: prefs and rules, not even talking about making it itemtype dependent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:01:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:01:07 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-LvswBvRX0Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #50 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18311&action=edit Bug 9824: Followup for POD lines of GetBasketsInfosByBookseller Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:08:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:08:34 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-mz8coJkVWo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #51 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18312&action=edit Bug 9824: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:33:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:33:50 +0000 Subject: [Koha-bugs] [Bug 10309] New: New OPAC theme based on Bootstrap Message-ID: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 Bug ID: 10309 Summary: New OPAC theme based on Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org I'm working on a new theme for the OPAC which replaces the old YUI grid system with Bootstrap. This new theme's design is based on the look of CCSR, but adds Bootstrap-style widgets and additional layout breakpoints for better responsiveness. My initial design is focused on the structural overhaul of the templates (with complete re-indentation and tab-to-spaces conversion) to add the Bootstrap grid and other features. I would like to later refine the design so that it looks less like the default Bootstrap design and more like something we can call our own. I started the redesign by throwing out everything in opac.css and starting from scratch. I still have the old version saved as opac-old.css for reference during development. The file should be removed for release. CSS is now generated from a couple of LESS files: opac.less and responsive.less which are combined when compiled. It's compiled to a non-minified version at the moment, but that should be changed for the release as well. The [lang] directory now contains only /includes, /modules, and /xslt. Everything else has been moved up to the [theme] level. The initial conversion of the templates is done, and I'm working now on tweaking the responsive layout, finding where breakpoints need to be adjusted. There's still a lot of work to be done in deciding how to prioritize content in the mobile view. I'll push an in-progress branch to Gitorious shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:37:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:37:13 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-pHHU1t1Btc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18312|0 |1 is obsolete| | --- Comment #52 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18313&action=edit Bug 9824: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:37:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:37:50 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-7KoFSwJJQq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18219|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:38:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:38:06 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-8AgbWCZT5v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18221|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:39:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:39:53 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-LUJgih6cLG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #53 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Katrin: Do you still have a suggestion on the second followup for textual changes? Perhaps from translation point of view. I submitted an amendment to make translation somewhat easier. Status back to Signed off for two trivial QA followups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:40:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:40:04 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-MTBGlVtqCL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:40:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:40:12 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-yP85vPCS8o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:40:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:40:30 +0000 Subject: [Koha-bugs] [Bug 10301] notes not showing on receive page In-Reply-To: <bug-10301-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10301-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10301-70-EXL7xeUHzS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10301 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.10 --- Comment #2 from Nicole C. Engard <nengard at gmail.com> --- Why change this to master? The problem is 3.10, 3.12 and master? Shouldn't it be 3.10? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:41:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:41:45 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-Ljr2VZxKDs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #10 from Nicole C. Engard <nengard at gmail.com> --- Spaces should be sufficient, the cataloger should have entered the other punctuation: http://www.loc.gov/marc/bibliographic/bd830.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:48:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:48:39 +0000 Subject: [Koha-bugs] [Bug 10310] New: Prevent submit form pressing enter should be improved Message-ID: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 Bug ID: 10310 Summary: Prevent submit form pressing enter should be improved Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com CC: gmcharlt at gmail.com Actually it does not work for IE (see Marcel's comment on bug 9507). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:48:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:48:55 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-GbFsXtztZ6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:51:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:51:31 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-lUHUZgZE4k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18314&action=edit Bug 10310: Prevent submitting form with enter does not work with IE I am not able to test this patch with IE... I tested it with Chromium and FF and it works great. This patch can be tested on the neworderempty.pl page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:51:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:51:54 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-7bxcYsiJrX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Depends on| |9507 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:51:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:51:54 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-696Ul5eHCF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10310 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:52:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:52:29 +0000 Subject: [Koha-bugs] [Bug 10311] New: Holds queue ignores item-level holds where only one items exists Message-ID: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10311 Bug ID: 10311 Summary: Holds queue ignores item-level holds where only one items exists Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com CC: gmcharlt at gmail.com If a record has only one item, and that item has one item-level hold on it, that hold will not show in the holds queue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:52:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:52:35 +0000 Subject: [Koha-bugs] [Bug 10311] Holds queue ignores item-level holds where only one items exists In-Reply-To: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10311-70-YxvcNiDrhC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10311 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:55:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:55:04 +0000 Subject: [Koha-bugs] [Bug 10311] Holds queue ignores item-level holds where only one items exists In-Reply-To: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10311-70-9MoF4ih0St@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10311 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18315&action=edit Bug 10311 - Holds queue ignores item-level holds where only one items exists If a record has only one item, and that item has one item-level hold on it, that hold will not show in the holds queue. Test Plan: 1) Create 1 record with 1 item at BranchA 2) Create an item-level hold for that item, for pickup at BranchA by a patron of BranchA 3) Run build_holds_queue.pl 4) View the holds queue for BranchA 5) Note the hold is not in there 6) Apply this patch 7) Re-run build_holds_queue.pl 8) View the holds queue again 9) Not that the hold is now there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:55:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:55:03 +0000 Subject: [Koha-bugs] [Bug 10311] Holds queue ignores item-level holds where only one items exists In-Reply-To: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10311-70-d28GhBYez0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10311 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:55:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:55:19 +0000 Subject: [Koha-bugs] [Bug 10311] Holds queue ignores item-level holds where only one items exists In-Reply-To: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10311-70-nRxSUa6bok@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10311 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:55:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:55:34 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-ecqSJWxXKK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The function chops off the other punctuation as far as I can see... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:57:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:57:21 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-wbZ85XbCLz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I will do some testing, it's a pretty old part of the XSLT code, maybe we can just do it completely different now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 15:57:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 13:57:59 +0000 Subject: [Koha-bugs] [Bug 10301] notes not showing on receive page In-Reply-To: <bug-10301-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10301-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10301-70-5QnbVfXmMT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10301 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Bugs are fixed downwards not upwards - so the patch needs to be for master, then it will get cherry picked for 3.10 and following :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:00:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:00:13 +0000 Subject: [Koha-bugs] [Bug 10309] New OPAC theme based on Bootstrap In-Reply-To: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10309-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10309-70-i7ZG8a8Dt3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10309 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Work in progress is now on Gitorious: http://gitorious.org/koha-dev/koha-dev ...in a branch called "bootstrap-opac" I can't stress enough that this is very unfinished. However I'm happy to hear questions, comments, suggestions, complaints, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:01:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:01:05 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-vYbbuxt7Wq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:01:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:01:07 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-yiFHgHHxUJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18314|0 |1 is obsolete| | --- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18316&action=edit Bug 10310: Prevent submitting form with enter does not work with IE I am not able to test this patch with IE... I tested it with Chromium and FF and it works great. This patch can be tested on the neworderempty.pl page Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Tested with FF and IE. Works for both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:01:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:01:58 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-AjgVY0NHZf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:07:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:07:00 +0000 Subject: [Koha-bugs] [Bug 10135] Adding the ability to define customised basketgroups pdf layouts In-Reply-To: <bug-10135-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10135-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10135-70-Kxk6HI6dAV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- Mathieu, your patch adds a new routine. Could you provide a unit test for it please? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:12:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:12:24 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-D323cu7Xbm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- QA Comment: Very quick! fix from Jonathan as followup for 9507. Tested neworderempty on FF and IE. Grepped prevent_submit and checked templates for doc3 tag. Notes textarea still worked with Enter. Good improvement and reduction of code. Seems to be browser independent. Two document ready functions are not a problem for jQuery too. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:16:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:16:00 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-jC5HtosCag@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- This seems to work in IE9, but I think it has an unintended consequence: You can't tab to the submit button and hit <enter> to submit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:17:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:17:46 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-caoaDkQPQt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #4) > This seems to work in IE9, but I think it has an unintended consequence: You > can't tab to the submit button and hit <enter> to submit. So true. This just went too fast :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:35:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:35:11 +0000 Subject: [Koha-bugs] [Bug 10135] Adding the ability to define customised basketgroups pdf layouts In-Reply-To: <bug-10135-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10135-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10135-70-PUX37BT9G9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135 --- Comment #6 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- OK. But this is a QA issue, and the patch has not been tested yet. I think Pierre Angot want to so so. Could I set it again in "need sign off" ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:35:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:35:38 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-Vo4MzTGPvr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #19 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #17) > Hm, I think Marcel meant the the Patrons tab in the system preference editor > is not the right place, but that it should be in Circulation. Indeed, I had in fact misread what Marcel meant, although I see that he also agrees with where I ended up after my misreading. :) > With 3.12 we have MaxFine in the circulation matrix - not sure how the best > way would be to indicate that it should be using the replacement price > there. It's an input field, so maybe a checkbox that implies 'replacement > price' and deactivates the maxfine input field? That makes sense to me -- a checkbox for "cap overdue fine at replacement price" that then disables the maxfine input field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:36:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:36:27 +0000 Subject: [Koha-bugs] [Bug 10135] Adding the ability to define customised basketgroups pdf layouts In-Reply-To: <bug-10135-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10135-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10135-70-tpVQmZZkeT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135 --- Comment #7 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Maybe there is also other QA issue, for example, what is the best location in Koha directory hierarchy to store customized layout templates? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:39:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:39:59 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-ajcHnbRN5z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:40:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:40:01 +0000 Subject: [Koha-bugs] [Bug 10288] Tiny typo on "Pending offline circulation actions" In-Reply-To: <bug-10288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10288-70-MHAKmLqgPQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10288 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:40:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:40:02 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-Pi0KrvQsT2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18316|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18317&action=edit Bug 10310: Prevent submitting form with enter does not work with IE I am not able to test this patch with IE... I tested it with Chromium and FF and it works great. This patch can be tested on the neworderempty.pl page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:40:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:40:11 +0000 Subject: [Koha-bugs] [Bug 10251] typos in help/members/member-flags.tt In-Reply-To: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10251-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10251-70-BHFrZarGwP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10251 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:42:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:42:09 +0000 Subject: [Koha-bugs] [Bug 9659] Undefined authorised value category yields empty dropdown menu on SQL reports In-Reply-To: <bug-9659-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9659-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9659-70-ZDylrMu7gS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9659 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:42:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:42:29 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-GtpQAPSks9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 --- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #4) > This seems to work in IE9, but I think it has an unintended consequence: You > can't tab to the submit button and hit <enter> to submit. Yep good catch Owen! The last patch returns false only if enter is pressed on input with a type != "submit". I don't find a case where a problem can occur. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:43:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:43:51 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-RIMPZtSnVO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #6) > QA comment: > > I never understand why 2 includes files are present. What is the way to keep > just one of them? I would agree that moving towards DRY (don't repeat yourself) would nice. Regardless, I've pushed this to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:49:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:49:56 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-C1VftTCQst@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #20 from Owen Leonard <oleonard at myacpl.org> --- Is this a new patch? It doesn't seem to address any of the issues I raised. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:50:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:50:28 +0000 Subject: [Koha-bugs] [Bug 10135] Adding the ability to define customised basketgroups pdf layouts In-Reply-To: <bug-10135-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10135-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10135-70-xDuKp3mgSi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135 --- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> --- A new type of this kind for syspref is not a best choice I think. Why do you want to list the directory? The value can be filled manually. I agree with your changes in /acqui/basketgroup.pl I think we just want: - if ($pdfformat eq 'pdfformat::layout3pages' || $pdfformat eq 'pdfformat::layout2pages'){ eval { eval "require $pdfformat"; import $pdfformat; }; if ($@){ + print $input->header; + print $input->start_html; # FIXME Should do a nicer page + print "<h1>Invalid PDF Format set</h1>"; + print "Please go to the systempreferences and set a valid pdfformat"; + exit; } - } - else { - print $input->header; - print $input->start_html; # FIXME Should do a nicer page - print "<h1>Invalid PDF Format set</h1>"; - print "Please go to the systempreferences and set a valid pdfformat"; - exit; - } I completely disagree with others changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:54:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:54:38 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-CjsA3mYWoO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Patch complexity|--- |Small patch --- Comment #13 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Jonathan! I too encourage a quick follow-up to improve the Javascript, now that it lives only in one place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:57:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:57:19 +0000 Subject: [Koha-bugs] [Bug 10261] Link to patron files missing from circ-menu.tt In-Reply-To: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10261-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10261-70-Ej61FZYIbD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10261 --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #6) > I never understand why 2 includes files are present. What is the way to keep > just one of them? >From the original commit of that file: "Adds a version of the include circ-menu.inc as circ-menu.tt this has the same functionality as the old include but does not require all the borrowers attributes to be passed as global scoped variables." http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff;h=507c7f422485aaf7ae601b0a84bacdbaedac061c Perhaps there is a better way to handle the scope issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 16:59:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 14:59:05 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-gwG6L7clQQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #21 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to comment #20) > Is this a new patch? It doesn't seem to address any of the issues I raised. That issue? If you are referring to your question about the cronjob, that has been obviated and is no longer an issue, this patch doesn't have a cronjob. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 17:01:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 15:01:43 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2720-70-fBdY0kEdzz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #22 from Owen Leonard <oleonard at myacpl.org> --- See comment #15. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 17:22:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 15:22:19 +0000 Subject: [Koha-bugs] [Bug 10080] Change system pref IndependantBranches to IndependentBranches In-Reply-To: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10080-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10080-70-6cXj7EpVGR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10080 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com Patch complexity|--- |Medium patch --- Comment #18 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 17:29:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 15:29:14 +0000 Subject: [Koha-bugs] [Bug 10135] Adding the ability to define customised basketgroups pdf layouts In-Reply-To: <bug-10135-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10135-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10135-70-FRCTZchnLL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135 --- Comment #9 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Someone added a control to prevent librarians to choose a non existing layout : at present we only can choose only layout2pages and layout3pages. So I thought we cannot just let librarians put any value in the syspref, as this could create a new way to "break" Koha. That's why I thought we could use a dropdow menu like the one beeing used for opac templates, to be sure a librarian cannot use a non existing layout. But maybe that's useless. That's why I asked the help of koha-devel list in december, but I had no real advice, so I decided to realize my idea ;-) http://web.archiveorange.com/archive/v/O5wWPk28B1FY7zsUFIz8 I believe I asked Chris too, but I cannot find his answer. Maybe I dreamt... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 17:54:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 15:54:25 +0000 Subject: [Koha-bugs] [Bug 7718] Remove itemnumber column from serials table In-Reply-To: <bug-7718-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7718-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7718-70-8bAXCjuUqg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7718 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Kyle! As a historical note, the serialitems table was added back in 2008. There was an upgrade concern that apparently prevented serial.itemnumber from being removed at the time that serialitems was added, but the code behind that that used to put a comma-separated list of itemnumbers into serial.itemnumber has long since been removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 17:59:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 15:59:45 +0000 Subject: [Koha-bugs] [Bug 10312] New: turning on IndependentBranches doesn't limit libraries than user can create subscriptions for Message-ID: <bug-10312-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10312 Bug ID: 10312 Summary: turning on IndependentBranches doesn't limit libraries than user can create subscriptions for Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: gmcharlt at gmail.com CC: colin.campbell at ptfs-europe.com Due to a template error, if IndependentBraches is on, the user is still presented with a list of all libraries to choose from when creating a new subscription. Instead, only the user's library should be available. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 18:03:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 16:03:33 +0000 Subject: [Koha-bugs] [Bug 10312] turning on IndependentBranches doesn't limit libraries than user can create subscriptions for In-Reply-To: <bug-10312-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10312-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10312-70-pYUV59OcFz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10312 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Galen Charlton <gmcharlt at gmail.com> --- Whoops, marking invalid. Super librarians get to ignore IndependentBranches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 20:27:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 18:27:05 +0000 Subject: [Koha-bugs] [Bug 10313] New: selecting an invoice from the historic orders page does not take you to that invoice Message-ID: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10313 Bug ID: 10313 Summary: selecting an invoice from the historic orders page does not take you to that invoice Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: colin.campbell at ptfs-europe.com To reproduce search for historic orders from the acquisitions home screen. Click on a displayed invoice number you will be taken to a receipt screen but not to the items on that invoice. The correct linking key needs to be passed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 20:27:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 18:27:16 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-HnGrIRpcTf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 George Williams <georgew at latahlibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |georgew at latahlibrary.org --- Comment #7 from George Williams <georgew at latahlibrary.org> --- I tested this on the VALNet production server and the patch works as expected. George Williams georgew at latahlibrary.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 20:36:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 18:36:31 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-KA4pO0GXUa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Maxime Pelletier <pelletiermaxime at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17447|0 |1 is obsolete| | Attachment #18216|0 |1 is obsolete| | --- Comment #24 from Maxime Pelletier <pelletiermaxime at gmail.com> --- Created attachment 18318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18318&action=edit Rebased and signed off patch I rebased the patch on master (to fix a small conflict) and merged the 2 patches in one. All tests I performed passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 20:45:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 18:45:15 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-a28B5zqFwM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Maxime Pelletier <pelletiermaxime at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 20:46:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 18:46:43 +0000 Subject: [Koha-bugs] [Bug 10313] selecting an invoice from the historic orders page does not take you to that invoice In-Reply-To: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10313-70-FdfWBdDMp9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10313 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 18319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18319&action=edit Proposed patch To test: Without this patch selecting an invoice number on the histsearch screen returns apparently random orderlines. With patch applied it should retrieve the correct invoice and its associated orderlines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 21:35:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 19:35:19 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7710-70-OnFopICaJe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Maxime Pelletier <pelletiermaxime at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18217|0 |1 is obsolete| | --- Comment #46 from Maxime Pelletier <pelletiermaxime at gmail.com> --- Created attachment 18320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18320&action=edit Signed off patch with small bug fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 21:35:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 19:35:30 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7710-70-sBw90I3SG7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Maxime Pelletier <pelletiermaxime at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 21:40:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 19:40:04 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7710-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7710-70-m7W7H2vn4Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #47 from Maxime Pelletier <pelletiermaxime at gmail.com> --- Created attachment 18321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18321&action=edit Selenium tests As a bonus here are selenium tests that create 3 holds for an user. The tests create a biblio, a testuser and them use them to tests the holds. Those tests aren't really solid, so you may have to change them a bit if you want to use them. Also, make sure MaxHoldsPerRecord is set to >= 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 22 22:21:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 22 May 2013 20:21:29 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-uwXUBTb2LV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18175|0 |1 is obsolete| | --- Comment #8 from Melia Meggs <melia at bywatersolutions.com> --- Created attachment 18322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18322&action=edit [Signed off] Bug 10262 - fine calculation at checkin not respecting CircControl The fines.pl script uses the system preference CircControl to decide what branches circ rules to use for fine generation. Recently, code was added to the returns system to recalculate the fine at checkin time ( to support hourly loans ). The problem is that this code does not respect CircControl. Test Plan: 1) Set circ control to "the library you are logged in at" 2) Set different fines rules for two different librarys 3) Check an item out at library A, backdate the due date so it's overdue and will have fines. 4) Check the item in at library B 5) Observe that the fines should be generated based on library A's rules, but the fines will be based on library B's rules instead! 5) Apply the patch 6) Repeat steps 3 and 4. 7) Observe now that the fines should reflect the fines rules for Library A Note: it seems counter-intuitive for the fines system to behave this way based on the preference being set to "the library you are logged in at" but it does make sense. The rules used are from "the library you are logged in at" when the item is first checked out. If the fines system really did use the rules for the library the item was returned to, it would be easy to exploit the library system. Some Koha using systems have branches that charge fines, and others that don't, so a patron could just return any overdue items to a non-charging branch to avoid ever paying fines! Furthermore, it would mean that the fines.pl script would be using one set of rules to charge fines, and the returns system could possibly be using another. Since fines.pl has been around far longer, it makes sense to assume the fines.pl behavior is canonical. Signed-off-by: Mickey Coalwell <mcoalwell at nekls.org> Signed-off-by: George Williams <georgew at latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 08:51:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 06:51:34 +0000 Subject: [Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml In-Reply-To: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9531-70-fnr3BmBOWr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 08:53:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 06:53:08 +0000 Subject: [Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml In-Reply-To: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9531-70-N80PoEPN1j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18267|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18323&action=edit Bug 9531 - Make SIP2 message terminator configurable via SIPconfig.xml Add a delimeter option to SIPConfig.xml, choices for 'delimeter' are 'CR' or 'CRLF'. The default continues to be 'CRLF' if 'delimeter' is undefined. Test Plan: 1) Apply patch 2) Start SIP server 3) Run C4/SIP/t/04patron_status.t 4) Stop SIP server 5) Add terminator="CR" for account login 'term1' 6) Run 04patron_status.t again, you should see no change Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr> Signed-off-by: Adrien Saurat <adrien.saurat at biblibre.com> Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 08:54:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 06:54:02 +0000 Subject: [Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml In-Reply-To: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9531-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9531-70-pl7yphx7rc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 08:59:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 06:59:49 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-KTjYEqFjyE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18317|0 |1 is obsolete| | --- Comment #8 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18324&action=edit Bug 10310: Prevent submitting form with enter does not work with IE I am not able to test this patch with IE... I tested it with Chromium and FF and it works great. This patch can be tested on the neworderempty.pl page Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:00:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:00:06 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-9mk52JSatS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:00:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:00:56 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-3Ga5HRdjSs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 --- Comment #9 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Tested it again. Entering the submit button works now. Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:05:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:05:23 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-1CwCMUiVzG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Pierre Angot <tredok.pierre at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre at gmail.com --- Comment #18 from Pierre Angot <tredok.pierre at gmail.com> --- Test on sandbox : Sandbox setup by tredok.pierre at gmail.com with database 2 and bug 9806 on Thu May 23 08:44:09 2013 Something went wrong ! Applying: Bug 9806 : Add new columns to basket groups lists Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basketgroup.tt Applying: Bug 9806 : QA Followup - use template plugin for branch names Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 9806 : QA Followup - use template plugin for branch names When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9806 - Show more information on basketgroups lists [SIGNED-OFF] Bug 9806 : Add new columns to basket groups lists Apply? [yn] [PATCH 2] Bug 9806 : QA Followup - use template plugin for branch names Apply? [yn] Patch left in /tmp/PATCH-2-Bug-9806--QA-Followup---use-template-plugi-GS6lZO.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:12:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:12:01 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-mdh7QNABez@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- My former QA comment still holds. Good improvement. Just curious about this line: $(e.target).attr('type') != "submit" Is there a difference with using e.target.type? Does jQuery not guarantee already that object e contains a 'which' and 'target'? Note that you assume that in the lines before this line when you directly refer to e.which and e.target. This tiny inconsistency does not prevent me from passing QA on this patch (second try). Just wait for Owen :) This patch makes it work too on IE9 which did not work. I could not test on earlier versions of IE. Not encouraging IE for staff at all btw.. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:15:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:15:33 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-9mVCteKHSj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:15:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:15:58 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-YcNTFuaBLb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:35:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:35:46 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-rsdyQ1BO8z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #18 from Pierre Angot <tredok.pierre at gmail.com> --- I've tested on sandbox : - search authorities "Po?sie", edit it and modify 250$a (Po?sie jolie) - search catalog "Le buveur d'?toiles" - check 606 - search authorities "Romain", edit it and modify 250$a (Romain test) - search catalog "Au temps des romains" - check 606 Everything is ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:36:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:36:19 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-LHRXElopHp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #19 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:36:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:36:38 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-oom8OBad3e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16790|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:36:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:36:44 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-auDbF5NOWZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #20 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 18325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18325&action=edit Bug 8304 : composed authorities Rameau management This patch is designed to manage the composed authorities the Way Rameau is coping with them in France. It supposes that the previous data is sent to merge function so that process deletes previous heading entries. Say you have in a biblio record : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politiciens $9 1216 $3 789 $z 1801-1860 And you change authority 1210 -250 $a Politiciens into -250 $a Politique You should get : - 606 $9 1214 $3 123 $a Europe $9 1215 $3 456 $y France $9 1210 $3 199 $x Politique $9 1216 $3 789 $z 1801-1860 In an other record : - 606 $9 1210 $3 199 $a Politiciens You should get : - 606 $9 1210 $3 199 $a Politique This patch changes the merge function. Signed-off-by: Pierre Angot <tredok.pierre at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:38:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:38:01 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-xAF7cQpTer@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #54 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- As requested, back to Needs signoff. Could a native speaker look at the proposed textual change? Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:40:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:40:06 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-wJM8ZRDV0a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 --- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #10) > Just curious about this line: > $(e.target).attr('type') != "submit" > Is there a difference with using e.target.type? > Does jQuery not guarantee already that object e contains a 'which' and > 'target'? Yes, you are right, it is inconsistent. I will provide a followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:40:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:40:50 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-SuaVOZj1o5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 --- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18326&action=edit Bug 10310: Followup Prevent submitting form with enter does not work with IE Check e.target.type instead of using jQuery. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:41:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:41:48 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-otfvVoC9m9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff --- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> --- Switch back to Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:43:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:43:59 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-mFv3DDEvco@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16019|0 |1 is obsolete| | Attachment #16020|0 |1 is obsolete| | --- Comment #16 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18327&action=edit Bug 8952 - Add http:// to url in social media links on opac-detail This patch adds a variable to the template, "protocol" based on whether "using_https" is set. The appropriate protocol is inserted before social media links. To test, confirm that OPACBaseURL is set and lacks "http(s)://" Social media links should include correct URLs. A follow-up patch could copy use of this [% protocol %] variable in other parts of this template which duplicate large chunks of HTML based on [% using_https %]. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:44:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:44:04 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-bNOOTgclly@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 --- Comment #17 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18328&action=edit Bug 8952: Followup: Change all occurrences of using_https Signed-off-by: Corey Fuimaono <agent.075 at gmail.com> Verified. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:44:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:44:27 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-A7PfOwZVdT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 --- Comment #18 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Resolved trivial merge conflict. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 09:54:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 07:54:58 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-KPHUTC6oY1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 cedric.vita at dracenie.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #25 from cedric.vita at dracenie.com --- Sandbox setup by unknown with database 2 and bug 9394 on Thu May 23 09:50:10 2013 Something went wrong ! Applying: Bug 9394 - Use reserve_id where possible Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Reserves.pm Auto-merging circ/circulation.pl Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt Auto-merging reserve/request.pl CONFLICT (content): Merge conflict in reserve/request.pl Auto-merging serials/routing-preview.pl Failed to merge in the changes. Patch failed at 0001 Bug 9394 - Use reserve_id where possible When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9394 - Use reserve_id where possible Rebased and signed off patch Apply? [yn] Patch left in /tmp/Rebased-and-signed-off-patch-FnVHt7.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:01:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:01:04 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-liUTBSovTT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #19 from Jonathan Druart <jonathan.druart at biblibre.com> --- The patches apply correctly on a local instance. Switch back to Needs SO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:03:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:03:21 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-ZZIBQWyJ97@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 cedric.vita at dracenie.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |cedric.vita at dracenie.com --- Comment #55 from cedric.vita at dracenie.com --- Sandbox setup by unknown with database 2 and bug 9824 on Thu May 23 09:59:56 2013 Something went wrong ! Applying: Bug 9824: Followup for POD lines of GetBasketsInfosByBookseller Applying: Bug 9824: Followup adding some text around Apply/cancel filter. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt Failed to merge in the changes. Patch failed at 0001 Bug 9824: Followup adding some text around Apply/cancel filter. When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9824 - Hide basket with no expected items in basket list by bookseller Bug 9824: Followup for POD lines of GetBasketsInfosByBookseller Apply? [yn] Bug 9824: Followup adding some text around Apply/cancel filter. Apply? [yn] Patch left in /tmp/Bug-9824-Followup-adding-some-text-around-Applycan-myQQFX.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:06:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:06:22 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-WOUmRIoiYq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- This still looks good to me, although I could not test Syndetics changes. Unfortunately Jared did not respond to comment15. I am resetting the status of this patch to Signed off. For the reason of the problem mentioned in comment14 I am asking an additional QAer to sign off please. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:10:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:10:42 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-xEVN30Tpa6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #20 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Thank you Jonathan. I could not check this morning, I am struggling with my VM... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:13:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:13:06 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-QioUgp4ERq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:13:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:13:29 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-VLEDwQNzYi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:13:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:13:40 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-XQBeNq1pey@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #56 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #55) > Sandbox setup by unknown with database 2 and bug 9824 on Thu May 23 09:59:56 > 2013 > > Patch failed at 0001 Bug 9824: Followup adding some text around Apply/cancel > filter. Thanks for testing! Strange. These two patches do apply fine for me on current master. Are you sure that the sandbox setup is on current master? Back to Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:17:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:17:08 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-wdfroAQ9Aa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:17:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:17:10 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-F0YKXdCtTS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18324|0 |1 is obsolete| | Attachment #18326|0 |1 is obsolete| | --- Comment #14 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18329&action=edit Bug 10310: Prevent submitting form with enter does not work with IE I am not able to test this patch with IE... I tested it with Chromium and FF and it works great. This patch can be tested on the neworderempty.pl page Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:17:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:17:14 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-LHHbTggE4L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 --- Comment #15 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18330&action=edit Bug 10310: Followup Prevent submitting form with enter does not work with IE Check e.target.type instead of using jQuery. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:18:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:18:04 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-TM0QxPZhWv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Nothing to say :) Back to Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:26:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:26:22 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10120-70-yfWWelB7B5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Version|3.14 |master --- Comment #13 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Back to master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:27:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:27:32 +0000 Subject: [Koha-bugs] [Bug 10070] History of anonymous searches is not kept In-Reply-To: <bug-10070-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10070-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10070-70-0o9eYLbJc3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10070 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master --- Comment #19 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Version back to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:27:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:27:57 +0000 Subject: [Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults In-Reply-To: <bug-10129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10129-70-CKitIqwTfl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Version|3.14 |master --- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Version back to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:28:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:28:19 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-mRX7BTX3hr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #21 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:28:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:28:24 +0000 Subject: [Koha-bugs] [Bug 9533] batch item modification should ignore defaults In-Reply-To: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9533-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9533-70-hTVgnGzKui@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9533 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master --- Comment #21 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Version back to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:28:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:28:34 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-GD24z3PtCX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #22 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 18331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18331&action=edit Bug 9806 : QA Followup - use template plugin for branch names With this followup, instead of passing the real names of the branches to template file, only the branchcodes are passed. The branchcodes are translated into branchnames in template file, using the KohaBranchName template plugin. To test : do the same test as for main patch : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before Signed-off-by: Pierre Angot <tredok.pierre at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:28:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:28:48 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: <bug-10052-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10052-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10052-70-QhApkaJTHH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master --- Comment #25 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Version back to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:29:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:29:16 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: <bug-7167-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7167-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7167-70-D3T8evUxKS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master --- Comment #243 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Version back to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:29:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:29:26 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-nZJPMFD56P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #23 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- So, it is working? Your sandbox was not rightly set-up ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:42:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:42:27 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-zo51XfR6QJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18228|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:51:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:51:16 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-uXJIelkeDC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #57 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by Cedric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:51:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:51:34 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-yJlCXUyQTn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #58 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 18332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18332&action=edit Bug 9824: Followup for POD lines of GetBasketsInfosByBookseller Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Cedric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:56:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:56:36 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-iMP7HtE4wQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #24 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: Ergonomic improvement for the basket group table. Simple patch, just add some columns on the table. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:57:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:57:06 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-2CBmq7SACq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16509|0 |1 is obsolete| | Attachment #18331|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18333&action=edit Bug 9806 : Add new columns to basket groups lists Revised to fix whitespace problems. Cosmetic changes put in an other patch. In the list of all the open/closed basketgroups for a vendor, you just have the name of each basketgroup, and 3 action buttons. It is not sufficient for libraries using basketgroup. Warning : this patch must be tested with BZ 9771 applied. If BZ 9771 is not pushed to master when you test, apply it before. This patch adds the following columns : - number (id of basketgroup) - billingplace (name of the library) - deliveryplace (name of the library, or "free delivery place") - number of baskets in each basketgroup To test : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before Signed-off-by: Owen Leonard <oleonard at myacpl.org> This is a nice improvement! Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:57:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:57:11 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-Xikamnej0j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #26 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18334&action=edit Bug 9806 : QA Followup - use template plugin for branch names With this followup, instead of passing the real names of the branches to template file, only the branchcodes are passed. The branchcodes are translated into branchnames in template file, using the KohaBranchName template plugin. To test : do the same test as for main patch : 1) make some basketgroups with 0, 1, 2 baskets 2) make some basketgroups with different billing and deliveryplace 3) check the list of open and closed basketgroups 4) check action buttons are working like before Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:57:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:57:14 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-mgakQDVMT9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #27 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18335&action=edit Bug 9806: Remove single pixel on the basketgroup table Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:58:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:58:00 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-ZE9bPGzDG3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #28 from Jonathan Druart <jonathan.druart at biblibre.com> --- The last patch fixes a small issue with the Datatable sDom. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 10:59:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 08:59:31 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-kZVmQVnXzC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #59 from cedric.vita at dracenie.com --- Error sandbox for sinagture. I will revalidate the good "Pelardon" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:00:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:00:06 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-TzhORmHTfZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #29 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Jonathan, that's not my patch... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:01:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:01:19 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-9Dkfx1rt1f@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #60 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by Cedric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:01:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:01:41 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-5drQQNbfrC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #61 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 18336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18336&action=edit Bug 9824: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Cedric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:15:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:15:19 +0000 Subject: [Koha-bugs] [Bug 6506] deleting patron history missing errors In-Reply-To: <bug-6506-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6506-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6506-70-2JyP2sUlXO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6506 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |chris at bigballofwax.co.nz Resolution|--- |FIXED --- Comment #23 from Chris Cormack <chris at bigballofwax.co.nz> --- Released with 3.12.0 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:15:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:15:21 +0000 Subject: [Koha-bugs] [Bug 9944] cleanborrowers.pl does not check for anonymisation errors In-Reply-To: <bug-9944-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9944-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9944-70-3VRf4mtFG1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9944 Bug 9944 depends on bug 6506, which changed state. Bug 6506 Summary: deleting patron history missing errors http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6506 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:15:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:15:21 +0000 Subject: [Koha-bugs] [Bug 10165] Trying to clear reading history when AnonymousPatron unset and DEBUG is on causes fatal error In-Reply-To: <bug-10165-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10165-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10165-70-0ygpq3Tyzi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10165 Bug 10165 depends on bug 6506, which changed state. Bug 6506 Summary: deleting patron history missing errors http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6506 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:19:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:19:44 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-35SyE17IFh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #30 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #29) > Jonathan, that's not my patch... Hum... 2 first patchs is yours. Last one is mine. It is a QA followup. Do you disagree with it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:23:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:23:34 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-m6nXVtKN5v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #31 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- If it is a QA patch, that's ok! In fact I did not look... I just look the title, and it reminds me an other bug, so I thought it as an attachement error. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:24:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:24:51 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-jiOEILJFtM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 --- Comment #32 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- (it reminds me BZ 10287) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:27:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:27:42 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-7aFalb84jO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17815|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:27:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:27:57 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-vaXcrykm9A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17816|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:28:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:28:06 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-bw71PGigl6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:28:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:28:22 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-XkzDTw80lk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:28:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:28:25 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-1VRcw7FcpC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #92 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18337&action=edit Bug 7143: Release team 3.14 on about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:28:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:28:45 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-ADYQD1OHJV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18311|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:28:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:28:50 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-TLw8yBCCD3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18313|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:36:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:36:33 +0000 Subject: [Koha-bugs] [Bug 10185] updatedatabase.pl remove all reserves In-Reply-To: <bug-10185-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10185-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10185-70-YjGRD9BJJR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10185 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7065 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:36:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:36:33 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: <bug-7065-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7065-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7065-70-4rK5RgqVJv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10185 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:41:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:41:13 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7295-70-EiUNJPzNnP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:47:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:47:38 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7295-70-cxUZ9CwIq9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17706|0 |1 is obsolete| | --- Comment #37 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 18338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18338&action=edit [SIGNED-OFF] Bug 7295: More granular permissions for baskets Add branch info to baskets Add a list of borrowers that are allowed to manage a basket (one list for each basket). Add a new subpermission: acquisition => order_manage_all If user is superlibrarian, or if he has permission acquisition = 1 (GranularPermissions = OFF), or subpermission acquisition => order_manage_all (GranularPermissions = ON). He's authorised to manage all baskets. Depending on syspref AcqViewBaskets: 'all': user can manage all baskets 'branch': user can manage baskets of his branch (the basket branch is taken into account, not the branch of the basket's creator). If basket branch is not defined, all user can manage this basket. 'user': user can manage baskets he created, and baskets he's in their user list There are unit tests in t/Acquisition/CanUserManageBasket.t, which require Test::MockModule You can edit basket's branch and users list in basket modification page (acqui/basket.pl) Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:48:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:48:10 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7295-70-e47sSIM92e@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17708|0 |1 is obsolete| | --- Comment #39 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 18340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18340&action=edit [SIGNED-OFF] Bug 7295 [follow-up] More granular permissions for baskets - updatedatabase.pl now fills the new aqbasket.branch with branchcode of basket owner (aqbasket.authorisedby). So the behavior is unchanged if you have set your syspref AcqViewBaskets to 'branch' - If AcqViewBaskets='branch', prevent librarian to add users that are not from the same branch than the basket. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:47:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:47:59 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7295-70-uQFg1ZdNqR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17707|0 |1 is obsolete| | --- Comment #38 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 18339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18339&action=edit [SIGNED-OFF] Bug 7295: Follow-up: Several fixes - List of libraries in basket.pl is now sorted by branch name, not code - When IndependantBranches is ON, user has only the possibility to set basket branch to its own branch, or to no branch at all. - When basket do not belong to any branch, selected branch by default is connection branch (was 'no branch') - added id attributes to both added li elements - change description of 'order_manage_all' permission to make it clearer. - remove Test::MockModule dependency Signed-off-by: Sonia Bouis <sonia.bouis at univ-lyon3.fr> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:48:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:48:33 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7295-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7295-70-AERQqxVcD2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:51:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:51:16 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: <bug-7498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7498-70-Hf9hAjbk5p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by C?dric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:51:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:51:33 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: <bug-7498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7498-70-O8bE3kaZwa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 --- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 18341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18341&action=edit Add new features and tests to the budget duplication : * Allow to enter a new name for the duplicate * Add option to transfer the not received orders in the budget copy * Transfer the duplication code in Budgets.pm to allow easier testing. In doing this I removed the code block " # deal with any children" because I just don't understand it and it had a typo in the table name ('aqcudgets'), so I figured it was useless code * Update Budgets.t with the right field names, test the data more and tests the duplication code. Sadly I didn't write tests for the order transfers because it just depends on too much stuff :/ http://bugs.koha-community.org/show_bug.cgi?id=7498 Signed-off-by: C -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:51:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:51:28 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: <bug-7498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7498-70-7QIlut7gYA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17871|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:52:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:52:27 +0000 Subject: [Koha-bugs] [Bug 9560] Add a filter by basketgroup in reception page In-Reply-To: <bug-9560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9560-70-HQKdtoU889@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9560 Pierre Angot <tredok.pierre at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre at gmail.com --- Comment #10 from Pierre Angot <tredok.pierre at gmail.com> --- It will be a good idea to remplace "Basketgroup number" with basketgroup name ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:55:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:55:33 +0000 Subject: [Koha-bugs] [Bug 9560] Add a filter by basketgroup in reception page In-Reply-To: <bug-9560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9560-70-MQuQuw20Xs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9560 --- Comment #11 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- In Rennes 2, we search basketgroup by number, so it is usefull for us. But I could keep basketgroup number and add an other filter for basketgroup name. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:57:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:57:34 +0000 Subject: [Koha-bugs] [Bug 9560] Add a filter by basketgroup in reception page In-Reply-To: <bug-9560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9560-70-SvaK4jcOgP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9560 --- Comment #12 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Rather that signing this patch, you should better sign this one http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 I will "reactivate" 9560 after 10124 is pushed. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 11:57:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 09:57:43 +0000 Subject: [Koha-bugs] [Bug 9560] Add a filter by basketgroup in reception page In-Reply-To: <bug-9560-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9560-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9560-70-6yFMOoBtV0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9560 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 12:14:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 10:14:20 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10124-70-Oep1K68ZqM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #11 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Your patch is better and larger, so I put mine "in discussion". I will see if it deserves to be reopened after 10124 is pushed. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 12:33:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 10:33:55 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9722-70-Q8f8r6ZjHM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: Good integration into a really ugly code/page. 2 small remarks: - Maybe the new pref should be under the OPAC/Appearance instead of Features. All OPACShow* pref are under appearande. - The toggle stuff can be made with a simple $("#notesrow_"+biblioNum).toggle(); not blocker Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 12:35:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 10:35:27 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9722-70-mhjcJ7Hevs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17717|0 |1 is obsolete| | Attachment #17718|0 |1 is obsolete| | Attachment #17726|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18342&action=edit Bug 9722: Allow users to add notes when placing a hold in opac The option of adding a note is controlled by new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: 1 Verify if new pref is disabled by default. Place a hold. You can't add a note. 2 Enable the pref. Place a hold and add a note. Check in staff if you can see the note in Catalogue Detail/Holds tab. 3 Toggle SingleBranchmode, AllowHoldDateInFuture/OPACAllowHoldDateInFuture, OPACShowHoldQueueDetails, or OPACItemHolds. Check the display of columns when placing a hold from opac. 4 Place a few holds with notes from opac search results in one run (enable DisplayMultiPlaceHold). Check results in staff again. Remark: A few lines already refer to mandatory note reasons. This is handled in a subsequent report. No reason to worry. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 12:35:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 10:35:35 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9722-70-Q0hp2azMgC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #17 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18343&action=edit Bug 9722: Allow users to add notes when placing a hold in opac (dbrev) Database revision for report 9722, adding new pref OpacShowHoldNotes. This development is part of a larger one (see umbrella report 9721). Test plan: Run [your server]/cgi-bin/koha/installer/install.pl?step=3&op=updatestructure Optionally, run a new install to test sysprefs.sql. Or: Edit sysprefs.sql, leave at least the last few lines including the new one. And run from command line: mysql -p [yourdatabase] < [your-clone]/installer/data/mysql/sysprefs.sql Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 12:35:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 10:35:38 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9722-70-LPARQIj5Zi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #18 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18344&action=edit Bug 9722: Toggle display of hold notes with Edit notes button Small adjustments, requested by Kyle: 1) Rename Show notes button. It is called now: Edit notes. 2) Do not hide all other notes fields. The Edit button now only toggles the corresponding hold notes field. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 12:50:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 10:50:13 +0000 Subject: [Koha-bugs] [Bug 9965] Improve integration of report plugins with existing reports In-Reply-To: <bug-9965-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9965-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9965-70-9PCxU1Sfbg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9965 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: 1/ There are 3 tabulation characters: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt FAIL forbidden patterns The patch introduces a forbidden pattern: tabulation character (73) The patch introduces a forbidden pattern: withespace character (74) The patch introduces a forbidden pattern: tabulation character (15) 2/ The conditional test in reports-home.tt should be [% IF UseKohaPlugins && CAN_user_plugins_report && plugins %] Otherwise a single h2 title is displayed. 3/ Why do you change "Report plugins" with "Other reports" while a "Others" already exists? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 13:15:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 11:15:43 +0000 Subject: [Koha-bugs] [Bug 10314] New: CanItemBeReserved does not respect the holds policies Message-ID: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Bug ID: 10314 Summary: CanItemBeReserved does not respect the holds policies Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com CC: gmcharlt at gmail.com CanItemBeReserved will return 1 as long as the circulation rules have a non-zero number of holds allowed and the patron hasn't reached his or her "Holds allowed" count. However, the subroutine completely ignores the holds policies which would contravene reserving the item even if the patron has not reached the maximum holds allowed count. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 13:20:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 11:20:40 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10314-70-71bfMMYifL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 13:20:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 11:20:41 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10314-70-cDwvplGb7F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18345&action=edit Bug 10314 - CanItemBeReserved does not respect the holds policies CanItemBeReserved will return 1 as long as the circulation rules have a non-zero number of holds allowed and the patron hasn't reached his or her "Holds allowed" count. However, the subroutine completely ignores the holds policies which would contravene reserving the item even if the patron has not reached the maximum holds allowed count. Test Plan: 1) Place an item on hold for a patron 2) Clear any existing hold policies 3) Set the appropriate circ rule so that the patron should be allowed 4) Attempt to place am item-level hold for this item/patron, it should succeed 5) Create a hold policy rule that would stop this patron from placing a hold on this item 6) Attempt to place an item-level hold on this item/patron, it should fail, but instead it will succeed 7) Apply this patch 8) Repeat step 6, this time you should be unable to place a specific hold on this item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 13:21:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 11:21:32 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10314-70-M0pBOB2txQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18346&action=edit Bug 10314 - CanItemBeReserved does not respect the holds policies - Followup - Tidy up CanItemBeReserved -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 13:50:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 11:50:24 +0000 Subject: [Koha-bugs] [Bug 10315] New: Use easier readable font for generated passwords Message-ID: <bug-10315-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10315 Bug ID: 10315 Summary: Use easier readable font for generated passwords Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de We had a library reporting that they had problems telling apart small l and capital I in the font used when passwords are generated. Of course you can always generate another password, if you are not sure, but it would be nice if we could change the CSS to use a font where the letters are easier to distinguish. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 13:51:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 11:51:14 +0000 Subject: [Koha-bugs] [Bug 10036] adding header search to additem page In-Reply-To: <bug-10036-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10036-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10036-70-Ybu9TZVPDK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10036 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17938|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18347&action=edit Bug 10036 - adding header search to additem page The add item screen lacks a header search form. This patch adds the cataloging header search include to additem.tt. To test, apply the patch and add items to or edit items of an existing record. The header search form should appear with options for cataloging search and circulation. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 13:51:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 11:51:02 +0000 Subject: [Koha-bugs] [Bug 10036] adding header search to additem page In-Reply-To: <bug-10036-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10036-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10036-70-o69uzavxB8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10036 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: Simple patch, it adds the header on the add item page. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 14:02:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 12:02:50 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: <bug-8231-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8231-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8231-70-F3oK44d67T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 14:03:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 12:03:07 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: <bug-8231-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8231-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8231-70-M00GNLsVQn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> --- This patch needs a SO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 14:18:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 12:18:41 +0000 Subject: [Koha-bugs] [Bug 9866] OPAC advanced search error with Solr enabled In-Reply-To: <bug-9866-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9866-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9866-70-8gdz6XwZPd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9866 --- Comment #4 from Hend <hend.eleraky at bibalex.org> --- I tried to make a way round to fix this problem .Here are the steps that i had done . 1- copy opac-search.tt to "search" directory and name it advsearch.tt. 2- Add advanced search part to search.pl [copy from opac-search.pl ] Added the following part after " my $itemtypes = GetItemTypes; " line #----------------Advanced Search---------------------- # the index parameter is different for item-level itemtypes my $itype_or_itemtype = (C4::Context->preference("item-level_itypes"))?'itype':'itemtype'; my @advancedsearchesloop; my $cnt; my $advanced_search_types = C4::Context->preference("AdvancedSearchTypes") || "itemtypes"; my @advanced_search_types = split(/\|/, $advanced_search_types); foreach my $advanced_srch_type (@advanced_search_types) { if ($advanced_srch_type eq 'itemtypes') { # itemtype is a special case, since it's not defined in authorized values my @itypesloop; foreach my $thisitemtype ( sort {$itemtypes->{$a}->{'description'} cmp $itemtypes->{$b}->{'description'} } keys %$itemtypes ) { my %row =( number=>$cnt++, ccl => "$itype_or_itemtype,phr", code => $thisitemtype, description => $itemtypes->{$thisitemtype}->{'description'}, imageurl=> getitemtypeimagelocation( 'opac', $itemtypes->{$thisitemtype}->{'imageurl'} ), ); push @itypesloop, \%row; } my %search_code = ( advanced_search_type => $advanced_srch_type, code_loop => \@itypesloop ); push @advancedsearchesloop, \%search_code; } else { # covers all the other cases: non-itemtype authorized values my $advsearchtypes = GetAuthorisedValues($advanced_srch_type, '', 'opac'); my @authvalueloop; for my $thisitemtype (@$advsearchtypes) { my %row =( number=>$cnt++, ccl => $advanced_srch_type, code => $thisitemtype->{authorised_value}, description => $thisitemtype->{'lib_opac'} || $thisitemtype->{'lib'}, imageurl => getitemtypeimagelocation( 'opac', $thisitemtype->{'imageurl'} ), ); push @authvalueloop, \%row; } my %search_code = ( advanced_search_type => $advanced_srch_type, code_loop => \@authvalueloop ); push @advancedsearchesloop, \%search_code; } } $template->param(advancedsearchesloop => \@advancedsearchesloop); # The following should only be loaded if we're bringing up the advanced search template if ( $template_type && $template_type eq 'advsearch' ) { # load the servers (used for searching -- to do federated searching, etc.) my $primary_servers_loop;# = displayPrimaryServers(); $template->param(outer_servers_loop => $primary_servers_loop,); my $secondary_servers_loop; $template->param(outer_sup_servers_loop => $secondary_servers_loop,); # set the default sorting if ( C4::Context->preference('OPACdefaultSortField') && C4::Context->preference('OPACdefaultSortOrder') ) { my $default_sort_by = C4::Context->preference('OPACdefaultSortField') . '_' . C4::Context->preference('OPACdefaultSortOrder'); $template->param( sort_by => $default_sort_by ); } # determine what to display next to the search boxes (ie, boolean option # shouldn't appear on the first one, scan indexes should, adding a new # box should only appear on the last, etc. my @search_boxes_array; my $search_boxes_count = 3; # begin whith 3 boxes for (my $i=1;$i<=$search_boxes_count;$i++) { # if it's the first one, don't display boolean option, but show scan indexes if ($i==1) { push @search_boxes_array, { scan_index => 1, }; } # if it's the last one, show the 'add field' box elsif ($i==$search_boxes_count) { push @search_boxes_array, { boolean => 1, add_field => 1, }; } else { push @search_boxes_array, { boolean => 1, }; } } $template->param(uc( C4::Context->preference("marcflavour")) => 1, # we already did this for UNIMARC advsearch => 1, search_boxes_loop => \@search_boxes_array); # use the global setting by default if ( C4::Context->preference("expandedSearchOption") == 1 ) { $template->param( expanded_options => C4::Context->preference("expandedSearchOption") ); } # but let the user override it if (defined $cgi->param('expanded_options')) { if ( ($cgi->param('expanded_options') == 0) || ($cgi->param('expanded_options') == 1 ) ) { $template->param( expanded_options => $cgi->param('expanded_options')); } } } #----------------------------------------------------- Now i could use advanced search. Please could you review it and check if there's any part that i am missing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 14:19:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 12:19:46 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-Dr5idRNBiW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- >From IRC: [14:16] jcamins marcelr: I confirm that when I apply that patch the social media links all point to https even though I'm using http. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 14:22:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 12:22:02 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-ckRn3knvl0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 14:22:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 12:22:04 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-Gy114DEwzg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18336|0 |1 is obsolete| | --- Comment #62 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18348&action=edit Bug 9824: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. With thanks to Owen for some rewording. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 14:23:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 12:23:16 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-w35YTbIwbz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #63 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Thank you for your quick signoff, cedric vita. I reworded the text of the links on the second patch, with thanks to Owen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 14:28:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 12:28:11 +0000 Subject: [Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct In-Reply-To: <bug-9410-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9410-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9410-70-Olli5brOIF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- The aqorders.discount field is a float(6,4) in DB. If we limit the value to 2 in the interface, we should limit the number of decimals in the DB structure too. However, maybe the 4 decimals are used by some library (hum... it should be surprising). Switch to in discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 14:31:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 12:31:51 +0000 Subject: [Koha-bugs] [Bug 9410] Formatting of the discount field when doing a new order from new empty record is not correct In-Reply-To: <bug-9410-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9410-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9410-70-dk24dfDpN2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9410 --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- I just seen you already submitted a patch for the supplier form (bug 9062). You limited the discount value to 1 decimal, we have to be consistent. 2 is certainly the best choice, but in this case a patch for the supplier form is required (and maybe for DB changes). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 14:54:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 12:54:25 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-4EFrt4aCd6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #26 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- For me applies on a today's fresh master. I re-set to signed-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 15:16:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 13:16:58 +0000 Subject: [Koha-bugs] [Bug 10316] New: Some patron search options missing in advanced search on patron record Message-ID: <bug-10316-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10316 Bug ID: 10316 Summary: Some patron search options missing in advanced search on patron record Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When you open the advanced patron search option while looking at a patron account, 2 search options are missing from the list compared with the patron search in the patron module: patron category and library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:01:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:01:21 +0000 Subject: [Koha-bugs] [Bug 10313] selecting an invoice from the historic orders page does not take you to that invoice In-Reply-To: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10313-70-NziDNwRXQu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10313 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18319|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 18349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18349&action=edit [SIGNED-OFF] Bug 10313 Fix link to invoice from orders Need to have invoiceid and pass it to retrieve selected invoicenumber. Wrong data passed causing incorrect records to be displayed Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:02:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:02:28 +0000 Subject: [Koha-bugs] [Bug 10313] selecting an invoice from the historic orders page does not take you to that invoice In-Reply-To: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10313-70-THekV8jkcN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10313 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com --- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> --- Simple patch, easy to test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:09:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:09:21 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-C2ZsxHGjya@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #91 from Kyle M Hall <kyle.m.hall at gmail.com> --- I do not believe that is a valid test. I would just remove it. (In reply to comment #90) > (In reply to comment #89) > > These are fantastic! Everything passes except the last test for SimpleMARC.t > > > not ok 29 - Now the second 952$c exists > > Yep, it was I said in comment 85 ("One test does not pass and I think it > should."). > > So is there a bug in move_field? Or my test is bad (but I don't think so). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:09:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:09:38 +0000 Subject: [Koha-bugs] [Bug 10304] Filter notforloan items when searching for only available items In-Reply-To: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10304-70-MugInMWckv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:09:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:09:39 +0000 Subject: [Koha-bugs] [Bug 10304] Filter notforloan items when searching for only available items In-Reply-To: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10304-70-s74IehlTJH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18280|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18350&action=edit Bug 10304 - Add avanced search filter for "not for loan" items This patch adds a new search limit for not for loan items. This limit filters all items that have a notforloan value not equal to 0. This limit can be used in conjunction with the "available" limit so that a person may search for items that are available and can be checked out right away. Test Plan: 1) Apply this patch 2) Catalog 3 records with 1 item each. a) Mark item A as notforloan b) Mark item B as lost c) Do nothing to item C 3) Do a search limiting only to available items a) You should see item's A and C in your reults 4) Do a search limiting only to items that can be checked out a) You should see item's B and C 5) Do a seach using both limits a) You should see item C and not items A or B -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:09:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:09:55 +0000 Subject: [Koha-bugs] [Bug 10313] selecting an invoice from the historic orders page does not take you to that invoice In-Reply-To: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10313-70-6ZEiATJcSm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10313 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m Severity|enhancement |normal --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: Clearly a bug. Another bug exist on the parcel page, I will open a new report. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:10:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:10:00 +0000 Subject: [Koha-bugs] [Bug 10304] Add avanced search filter for "not for loan" items In-Reply-To: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10304-70-X0oP5jcFhO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Filter notforloan items |Add avanced search filter |when searching for only |for "not for loan" items |available items | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:10:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:10:10 +0000 Subject: [Koha-bugs] [Bug 10313] selecting an invoice from the historic orders page does not take you to that invoice In-Reply-To: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10313-70-R9NCcoirFk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10313 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18349|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18351&action=edit Bug 10313 Fix link to invoice from orders Need to have invoiceid and pass it to retrieve selected invoicenumber. Wrong data passed causing incorrect records to be displayed Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:12:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:12:02 +0000 Subject: [Koha-bugs] [Bug 10317] New: Parcel should display a message when called with an nonexistent invoiceid Message-ID: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 Bug ID: 10317 Summary: Parcel should display a message when called with an nonexistent invoiceid Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:12:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:12:11 +0000 Subject: [Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid In-Reply-To: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10317-70-Al3MwRK006@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:12:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:12:16 +0000 Subject: [Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid In-Reply-To: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10317-70-sP4orljKbY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:12:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:12:25 +0000 Subject: [Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid In-Reply-To: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10317-70-VfaBEeXQcf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10313 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:12:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:12:25 +0000 Subject: [Koha-bugs] [Bug 10313] selecting an invoice from the historic orders page does not take you to that invoice In-Reply-To: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10313-70-S8afJtX26n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10313 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10317 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:16:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:16:10 +0000 Subject: [Koha-bugs] [Bug 10036] adding header search to additem page In-Reply-To: <bug-10036-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10036-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10036-70-o3KK4lltw4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10036 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:19:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:19:59 +0000 Subject: [Koha-bugs] [Bug 10304] Add avanced search filter for "not for loan" items In-Reply-To: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10304-70-GnyS29jaY1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 --- Comment #4 from Kyle M Hall <kyle.m.hall at gmail.com> --- Ok, I've updated my patch to make it a new optional filter that may be used in conjunction with the existing availability filter. (In reply to comment #2) > Kyle, sorry, but I disagree here. As I understand it available does not > necessarily imply that you can check the item out, but that it's currently > available (on the shelf) in the library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:31:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:31:45 +0000 Subject: [Koha-bugs] [Bug 10318] New: show email on patron search results Message-ID: <bug-10318-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10318 Bug ID: 10318 Summary: show email on patron search results Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com On the patron search results page it would be great to see the email address. It could go in the name column with other contact info. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:35:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:35:22 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-0r4q8B1IRt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:41:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:41:17 +0000 Subject: [Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved In-Reply-To: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10310-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10310-70-a28qvK2Io1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:44:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:44:02 +0000 Subject: [Koha-bugs] [Bug 10304] Add avanced search filter for "not for loan" items In-Reply-To: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10304-70-VRChGvNqlj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10304 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 18350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18350 Bug 10304 - Add avanced search filter for "not for loan" items "Only items that can be checked out" seems a bit dangerous for me as a lot of our libraries allow some patron categories to checkout several itemtypes while others are not allowe. So almost no items are marked 'reference'. It's not possible to create a filter that will take into account circulation rules and for some libraries this will work - also it has an id so it can be hidden. But I am still a little worried we will see bug reports about that not working like people expect it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:48:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:48:19 +0000 Subject: [Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid In-Reply-To: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10317-70-gx6FQdcEUk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:48:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:48:21 +0000 Subject: [Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid In-Reply-To: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10317-70-Mc71FKBW61@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18352&action=edit Bug 10317: The parcel page display whatever if the invoiceid is unknown This patch fixes some stuffs on the parcel page. 1/ Removes dead code 2/ Display an error message if invoiceid is unset or not to refer to an invoice 3/ Fix a bug in the note ("change note" and "add note" links) Test plan: 1/ Try to call the invoice page with an existing invoiceid and check that order results are consistent. 2/ Try without invoiceid or a bad invoiceid and check that an error message is displayed. 3/ Add and change notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:52:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:52:32 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10184-70-sYK2a2H3rI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 --- Comment #7 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Status has been marked as failed QA but I cant see under what basis? Patch is stalled as a result and bug is out in the wild can someone clarify -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 16:56:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 14:56:45 +0000 Subject: [Koha-bugs] [Bug 10313] selecting an invoice from the historic orders page does not take you to that invoice In-Reply-To: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10313-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10313-70-2HMErNoTdv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10313 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 17:04:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 15:04:57 +0000 Subject: [Koha-bugs] [Bug 9806] Show more information on basketgroups lists In-Reply-To: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9806-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9806-70-rZCDl4N9mr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9806 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #33 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 17:12:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 15:12:25 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-pdC0ULfAMA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 --- Comment #21 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #20) > From IRC: > [14:16] jcamins marcelr: I confirm that when I apply that patch the social > media links all point to https even though I'm using http. Same here using Plack. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 17:32:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 15:32:39 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-1u5QzusMva@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 17:32:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 15:32:42 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-UZBHcEnVlg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 --- Comment #22 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18353&action=edit Bug 8952: using_https does not deal with Plack When using Plack, the https method returns 'OFF'. We have to test this value before sending the value to templates. Test plan: - Check the social networks link under Plack - Check the social networks link without Plack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 17:35:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 15:35:44 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9722-70-12QGnAv06m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master along with a follow up to allow the hold note to be displayed in the patron summary in the OPAC (as it doesn't make sense to allow patrons to set a note without being able to view it later, particularly if it's meant to later contain notes about requesting a specific part). Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 18:02:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 16:02:33 +0000 Subject: [Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop In-Reply-To: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9505-70-EBrPYCnVOi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14963|0 |1 is obsolete| | --- Comment #5 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 18354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18354&action=edit Amended Patch Updated patch to apply on current master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 18:04:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 16:04:00 +0000 Subject: [Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop In-Reply-To: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9505-70-qI40HRkuit@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Reset status, Patch should now apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 18:05:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 16:05:51 +0000 Subject: [Koha-bugs] [Bug 10052] Make intranetstylesheet and intranetcolorstylesheet behave exactly like their opac counterparts In-Reply-To: <bug-10052-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10052-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10052-70-zNVdQOyYXr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10052 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #26 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 18:11:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 16:11:19 +0000 Subject: [Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop In-Reply-To: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9505-70-tBlJCcL6Ef@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Galen Charlton <gmcharlt at gmail.com> --- Tested and confirmed that my signoff is still good. Setting status accordingly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 18:16:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 16:16:34 +0000 Subject: [Koha-bugs] [Bug 10316] Some patron search options missing in advanced search on patron record In-Reply-To: <bug-10316-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10316-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10316-70-wy3YKCJmLr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10316 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** This bug has been marked as a duplicate of bug 7380 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 18:16:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 16:16:34 +0000 Subject: [Koha-bugs] [Bug 7380] Can't filter patron search on detail page In-Reply-To: <bug-7380-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7380-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7380-70-q8w0wnC5vm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 10316 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 18:29:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 16:29:37 +0000 Subject: [Koha-bugs] [Bug 10129] Babeltheque does not depend on COinSinOPACResults In-Reply-To: <bug-10129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10129-70-Mo1b4G29mR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10129 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 18:34:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 16:34:20 +0000 Subject: [Koha-bugs] [Bug 10319] New: C4::SocialData is badly named Message-ID: <bug-10319-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10319 Bug ID: 10319 Summary: C4::SocialData is badly named Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com The name of the module implies that it supports general-purpose social (network?) data handling. It does not; the code is applicable only to a particular added content vendor, Babeltheque, and the module should be renamed accordingly, for example, to C4::External::Babeltheque (or better, if it meets the criteria, Koha::External::Babeltheque). Similarly, the following directories and cronjobs should be renamed: ./misc/cronjobs/social_data ./misc/cronjobs/social_data/update_social_data.pl ./misc/cronjobs/social_data/get_report_social_data.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 18:49:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 16:49:15 +0000 Subject: [Koha-bugs] [Bug 10315] Use easier readable font for generated passwords In-Reply-To: <bug-10315-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10315-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10315-70-2gSBigUvkr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10315 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 18:49:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 16:49:16 +0000 Subject: [Koha-bugs] [Bug 10315] Use easier readable font for generated passwords In-Reply-To: <bug-10315-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10315-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10315-70-WDJ1xGBor1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10315 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18355&action=edit Bug 10315 - Use easier readable font for generated passwords The text inputs on the change password form are not very big, and the default sans-serif font isn't always good for showing unambiguous characters. This patch sets a larger, monospace font for those fields. To test, apply the patch, clear your browser cache, and open the patron change password form (members/member-password.pl). The inputs should be more readable, especially the password fields when you click to fill with a randomly generated password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 18:52:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 16:52:53 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-8BFb4HuZBB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 --- Comment #23 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #22) > When using Plack, the https method returns 'OFF'. > We have to test this value before sending the value to templates. Good catch. This adjustment imo does deserve some comment in the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 19:32:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 17:32:43 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-iseNnVfe2m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17969|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18356&action=edit Bug 10206 - Add Koha TT Plugin - Koha.Preference This plugin is meant to be a place to put general purpose TT functions directly related to Koha. If a plugin is not a filter, and does not have more than one subroutine, that subroutine most likely belongs in this TT plugin. This first and only function the plugin currently has is Preference, which allows a template to get the value of a system preference without, it needing to be passed in from a perl script. This plugin was already tested and signed off as part of bug 7441. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 19:32:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 17:32:41 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-OH2aU6Tb8i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 19:33:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 17:33:46 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-0BPoNBRHLp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 --- Comment #7 from Kyle M Hall <kyle.m.hall at gmail.com> --- My bad ; ) I've removed all the unnecessary code from this new patch. Kyle (In reply to comment #5) > Changing status to reflect need for clarification. > Why C4::Koha? Are there specific functions in that module you recommend to > use? If so, maybe add this in the pod lines? > Typo replated. > Use Template::Plugin not needed? Use base seems enough. > Leaving the name as-is.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 19:43:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 17:43:17 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-7QCW1v1sGr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 --- Comment #8 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18357&action=edit Bug 10206 - Add Koha TT Plugin - Koha.Preference This plugin is meant to be a place to put general purpose TT functions directly related to Koha. If a plugin is not a filter, and does not have more than one subroutine, that subroutine most likely belongs in this TT plugin. This first and only function the plugin currently has is Preference, which allows a template to get the value of a system preference without, it needing to be passed in from a perl script. This plugin was already tested and signed off as part of bug 7441. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 19:43:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 17:43:15 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-Jm1nsp1eMM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 19:48:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 17:48:33 +0000 Subject: [Koha-bugs] [Bug 9614] Fines not assessed after renewing an item In-Reply-To: <bug-9614-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9614-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9614-70-NW6X12qgjA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9614 Jesse Maseto <jesse at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P2 |P1 - high CC| |jesse at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 19:51:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 17:51:04 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-0DCXnBwBcq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 --- Comment #9 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- False warning of qa-tools: critic FAIL Code before strictures are enabled at line 42, column 1. See page 429 of PBP. This is not true, since the code contains a use Modern::Perl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 19:54:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 17:54:09 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-I5gqY4MoxK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- With reference to former comments, adjustments make this patch pass QA. Nice feature, tested with future work for report 9032. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 19:58:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 17:58:56 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9722-70-uM85RUGkZ9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #20 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #19) > Pushed to master along with a follow up to allow the hold note to be > displayed in the patron summary in the OPAC (as it doesn't make sense to > allow patrons to set a note without being able to view it later, > particularly if it's meant to later contain notes about requesting a > specific part). Thanks for that, Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 20:43:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 18:43:32 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-6DVXAdvA5i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #20 from Kyle M Hall <kyle.m.hall at gmail.com> --- One nice feature of this patch as it stands is that you can specify both MaxFine and MaxFineIsReplacementPrice at once. If the replacement price is over the MaxFine, it will be reduced. To move it to the circulation matrix would require a full re-write. The overduefinescap functions within CalcFine, rather than UpdateFine. Perhaps we have fines logic in too many places. Maybe MaxFines logic needs to be moved to CalcFine as well. (In reply to comment #19) > (In reply to comment #17) > > Hm, I think Marcel meant the the Patrons tab in the system preference editor > > is not the right place, but that it should be in Circulation. > > Indeed, I had in fact misread what Marcel meant, although I see that he also > agrees with where I ended up after my misreading. :) > > > With 3.12 we have MaxFine in the circulation matrix - not sure how the best > > way would be to indicate that it should be using the replacement price > > there. It's an input field, so maybe a checkbox that implies 'replacement > > price' and deactivates the maxfine input field? > > That makes sense to me -- a checkbox for "cap overdue fine at replacement > price" that then disables the maxfine input field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 21:54:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 19:54:08 +0000 Subject: [Koha-bugs] [Bug 9424] Move JavaScript out of header include In-Reply-To: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9424-70-5S40lxvVih@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18062|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18358&action=edit Bug 9424 [Revised] Move JavaScript out of header include This patch removes JavaScript "onlick" attributes from header.inc and moves the functionality to staff-global.js. This is in keeping with the idea of progressive enhancement. To test, be sure to clear your browser cache after applying the patch. - Test the help link. - Test the logout link with the intranetbookbag preference on and off. - Open a patron's account and click "search to hold." Log out, and log in again. Koha should not remember the patron you chose before logging out (as seen from a search results page). Revised for current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 23 22:15:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 20:15:45 +0000 Subject: [Koha-bugs] [Bug 10311] Holds queue ignores item-level holds where only one items exists In-Reply-To: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10311-70-zPg7z62Cg8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10311 George Williams <georgew at latahlibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |georgew at latahlibrary.org --- Comment #2 from George Williams <georgew at latahlibrary.org> --- I've tested this patch on the VALNet production server and it works as expected. George Williams -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 00:41:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 22:41:20 +0000 Subject: [Koha-bugs] [Bug 10320] New: Show results from library's OverDrive collection in OPAC search Message-ID: <bug-10320-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Bug ID: 10320 Summary: Show results from library's OverDrive collection in OPAC search Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P4 Component: OPAC Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com Show any relevant results from OverDrive on the OPAC search. This is done by showing a link with "Found xx results in the library's OverDrive collection" at the top of opac-search.pl, and linking to a page that shows the full results. This requires an OverDrive developer account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 00:44:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 22:44:53 +0000 Subject: [Koha-bugs] [Bug 10311] Holds queue ignores item-level holds where only one items exists In-Reply-To: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10311-70-Lj9fNgXYOf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10311 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18315|0 |1 is obsolete| | --- Comment #3 from Melia Meggs <melia at bywatersolutions.com> --- Created attachment 18359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18359&action=edit [Signed off] Bug 10311 - Holds queue ignores item-level holds where only one items exists If a record has only one item, and that item has one item-level hold on it, that hold will not show in the holds queue. Test Plan: 1) Create 1 record with 1 item at BranchA 2) Create an item-level hold for that item, for pickup at BranchA by a patron of BranchA 3) Run build_holds_queue.pl 4) View the holds queue for BranchA 5) Note the hold is not in there 6) Apply this patch 7) Re-run build_holds_queue.pl 8) View the holds queue again 9) Not that the hold is now there Signed-off-by: George Williams <georgew at latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 00:45:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 22:45:20 +0000 Subject: [Koha-bugs] [Bug 10311] Holds queue ignores item-level holds where only one items exists In-Reply-To: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10311-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10311-70-LyEpzTu2jg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10311 Melia Meggs <melia at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia at bywatersolutions.com --- Comment #4 from Melia Meggs <melia at bywatersolutions.com> --- I'm adding the sign off on behalf of George. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 01:18:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 23 May 2013 23:18:48 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: <bug-10320-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10320-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10320-70-MOIa4u5fTk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #1 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 18360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18360&action=edit Bug 10320 - Integrate OverDrive search into OPAC (1/2) This show results from the OverDrive ebook/audiobook service in the OPAC. To test: 1) Fill in the OverDrive system preferences (you will need an Overdrive client key, client secret and library ID). 2) Perform a search on the OPAC, verify that, if available, a link to results from OverDrive will appear at the top. 3) Click on the link, verify that the list of results appears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 02:08:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 00:08:26 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: <bug-10320-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10320-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10320-70-YIDKBOUhHM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 --- Comment #2 from Jesse Weaver <jweaver at bywatersolutions.com> --- Created attachment 18361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18361&action=edit Bug 10320 - Integrate OverDrive search into OPAC (2/2) This followup adds the sysprefs and copies the relevant JS to CCSR. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 02:47:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 00:47:16 +0000 Subject: [Koha-bugs] [Bug 9161] Translate only specific files In-Reply-To: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9161-70-4bj9nYfFSI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9161 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 02:47:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 00:47:38 +0000 Subject: [Koha-bugs] [Bug 9161] Translate only specific files In-Reply-To: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9161-70-9wDlTaTgXL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9161 --- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18362&action=edit Bug 9161: Translate only specific files The previous version of tmpl_process3.pl says in the pod: -i, --input=SOURCE Get or update strings from SOURCE file. SOURCE is a directory if -r is also specified. But is was not possible to specify one or more files. This patch allows us to give one or more specific file with the -f parameter. for eg.: perl tmpl_process3.pl install -i /home/koha/koha-tmpl/opac-tmpl/prog/en/modules/ -o /home/koha/koha-tmpl/opac-tmpl/prog/fr-FR/modules/ -s /home/koha/misc/translator/po/fr-FR-i-opac-t-prog-v-3006000.po -r -f opac-account.tt -f opac-main.tt You can specify: -f advsearch.tt => translate all files with a filename containing 'advsearch.tt' or -f search => will translate acqui/histsearch.tt, acqui/z3950_search.tt, etc. Bug 9161: Followup: Add a -f param for the translate script Now you can directly call the translate script (misc/translator/translate) with the -f parameter eg.: ./translate install|create|update -f search.tt -f main.tt Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr> I've squashed the 3 patches, and reported doc into 'translate' script. It works as advertised. Side note: It would be great to extend this functionnality in order to be able to apply the translation to XSL files stored outside Koha directories hierarchy. Useful to translate site-specific XSLs defined with XSLTResultsDisplay, and other sysprefs. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 02:47:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 00:47:49 +0000 Subject: [Koha-bugs] [Bug 9161] Translate only specific files In-Reply-To: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9161-70-EwnF7m42Zv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9161 --- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18363&action=edit Bug 9161: Followup: the -f param does not work correctly Without this patch, the -f param (for the translate script) add the modified line in the po file BUT comment all lines from others files. This patch concat the generated file with the previous one and merge them. This way produce a pretty po file with all our strings :) + Modification in LangInstaller.pm to fix a bug when the -f param was not given. Test plan: 1/ Update your po file : cd misc/translator perl translate update fr-FR git commit -a -m"TMP PO" 2/ Modification on 2 files: ie. catalogue/advsearch.tt:32 <h1>Advanced search Foo</h1> catalogue/issuehistory.tt:38 <th>Patron Bar</th> 3/ Update your po file with only the first file: perl translate update fr-FR -f advsearch.tt 4/ Edit your po file and check that only the foo string is present (or git diff). 5/ Update your po file with only the second file: perl translate update fr-FR -f issuehistory 6/ Edit your po file and check that 2 strings are present (or git diff). 7/ Change the translation for these 2 strings and delete the fuzzy lines. 8/ Install the first file for your language: perl translate install fr-FR -f advsearch.tt 9/ Edit your translated file and verify the string is translated. Check that the issuehistory.tt file is not changed. 10/ Same for issuehistory: perl translate install fr-FR -f issuehistory 11/ stash your modification in your tt files (or reset --hard): git stash 12/ Check in your po file that the 2 strings are commented (git diff). 13/ To finish, install all template files and check that they are replaced correctly: perl translate install fr-FR Signed-off-by: Fr?d?ric Demians <f.demians at tamil.fr> I have squashed the both follow-up patches. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 02:48:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 00:48:07 +0000 Subject: [Koha-bugs] [Bug 9161] Translate only specific files In-Reply-To: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9161-70-RL93R82bk5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9161 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 02:48:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 00:48:19 +0000 Subject: [Koha-bugs] [Bug 9161] Translate only specific files In-Reply-To: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9161-70-ANttxXfxoz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9161 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15207|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 02:49:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 00:49:32 +0000 Subject: [Koha-bugs] [Bug 9161] Translate only specific files In-Reply-To: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9161-70-SmG17FNSI0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9161 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> --- Passes all tests, and works as advertised without breaking existing functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 04:53:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 02:53:06 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8034-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8034-70-RceynL0suh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 09:43:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 07:43:16 +0000 Subject: [Koha-bugs] [Bug 10321] New: Followup on hold notes Message-ID: <bug-10321-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 Bug ID: 10321 Summary: Followup on hold notes Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl CC: gmcharlt at gmail.com This is a followup report on bug 9722. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 09:43:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 07:43:57 +0000 Subject: [Koha-bugs] [Bug 10321] Followup on hold notes In-Reply-To: <bug-10321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10321-70-gTITSlxKaR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9722 Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 09:43:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 07:43:57 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9722-70-QWo2cTsp9A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10321 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 10:07:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 08:07:12 +0000 Subject: [Koha-bugs] [Bug 10321] Followup on hold notes In-Reply-To: <bug-10321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10321-70-uc0pCIJhfW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 10:07:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 08:07:13 +0000 Subject: [Koha-bugs] [Bug 10321] Followup on hold notes In-Reply-To: <bug-10321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10321-70-03g3wbz3yS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 --- Comment #1 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18364&action=edit Bug 10321: Followup for hold notes Based on work for report 9722. This patch resolves a small display problem with the number of columns of the table on opac-reserve. Test plan: Enable OPACShowHoldQueueDetails and OpacShowHoldNotes. Without this patch, the hold notes end at the one-but-last column. Test this by placing a hold in opac and click on Edit notes. Apply this patch: repeat what you did, the display should be correct. Toggle the value of OPACShowHoldQueueDetails. And check again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 10:17:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 08:17:54 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9722-70-BOLObECmWi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #21 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #15) > - Maybe the new pref should be under the OPAC/Appearance instead of > Features. All OPACShow* pref are under appearande. Thanks for QAing, Jonathan. I thought about moving it. But I think that this pref that allows or not allows adding notes should be under Features. But I agree that you have a point about the name of the pref. Probably, the name is somewhat misleading. Do you have a suggestion? Would OpacHoldNotes be an improvement? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 10:37:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 08:37:59 +0000 Subject: [Koha-bugs] [Bug 10321] Followup on hold notes In-Reply-To: <bug-10321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10321-70-aHmo47zLxX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 --- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18365&action=edit Bug 10321: QA Followup on report 9722 As Jonathan suggested, use jQuery toggle function. Test plan: Enable OPACShowHoldNotes. Place one hold. Repeat clicking on Edit notes to show and hide notes. Place a multi hold (two biblios at the same time). Check again with both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 10:38:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 08:38:47 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9722-70-LdcZqOiUWt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #22 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #15) > - The toggle stuff can be made with a simple > $("#notesrow_"+biblioNum).toggle(); Submitted small followup on bug 10321 for that. Thx. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 10:49:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 08:49:22 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-EPQteLNBQj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17991|0 |1 is obsolete| | Attachment #17992|0 |1 is obsolete| | --- Comment #21 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18366&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 10:50:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 08:50:05 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-YLcCbn18vw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18366|0 |1 is obsolete| | --- Comment #22 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18367&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Enable MaxFineIsReplacementPrice 4) Pick an item, set it's replacementprice to some amount ( e.g. $6.50 ) 5) Check it out to a patron, back date the due date by an amount such that the fine should exceed the replacement price ( a year ago should be good ). 6) Run fines.pl 7) Verify the fine for the item is not exceeded the replacement price. Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> Make sure that you also have maximum fine amount to be higher than the replacement price you set, otherwise it will stop at that amount. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 10:50:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 08:50:11 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-17B72eFyri@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #23 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18368&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price - QA Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 10:50:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 08:50:55 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-RpPensU3fr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.14 |master --- Comment #24 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Resolved small merge conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 10:53:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 08:53:56 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-eEA8WJGt22@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18353|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18369&action=edit Bug 8952: using_https does not deal with Plack When using Plack, the https method returns 'OFF'. We have to test this value before sending the value to templates. Test plan: 1/ Fill your OPACBaseUrl 2/ Configure apache for using http 3/ Check the social networks links (should be http://OPACBaseUrl) 4/ Launch Plack 5/ Check the social networks link (should be http://OPACBaseUrl) 6/ Stop Plack 7/ Configure apache for using https sudo openssl req -x509 -nodes -days 365 -newkey rsa:1024 -out /etc/apache2/server.crt -keyout /etc/apache2/server.key and add in you virtualhost (with :443) SSLEngine on SSLCertificateFile /etc/apache2/server.crt SSLCertificateKeyFile /etc/apache2/server.key a2enmod ssl service apache2 restart 8/ Check the social networks links (should be https://OPACBaseUrl) FIXME: Under Plack, with ssl actived, the CGI->https() method always returns 'OFF'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 11:06:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 09:06:05 +0000 Subject: [Koha-bugs] [Bug 9722] Allow users to add notes when placing a hold in opac In-Reply-To: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9722-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9722-70-6EJeJ1jeDT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9722 --- Comment #23 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #21) > (In reply to comment #15) > > - Maybe the new pref should be under the OPAC/Appearance instead of > > Features. All OPACShow* pref are under appearande. > > Thanks for QAing, Jonathan. I thought about moving it. But I think that this > pref that allows or not allows adding notes should be under Features. But I > agree that you have a point about the name of the pref. Probably, the name > is somewhat misleading. > Do you have a suggestion? Would OpacHoldNotes be an improvement? OpacHoldNotes is probably more expressive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 11:37:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 09:37:06 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-EHkMORzpBB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18368|0 |1 is obsolete| | --- Comment #25 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18370&action=edit Bug 9129 - Add the ability to set the maximum fine for an item to its replacement price - QA Followup Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Attaching a followup too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 11:37:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 09:37:12 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-DIoFwCUGen@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #26 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18371&action=edit Bug 9129: Followup for moving two maxfine prefs to Circulation Moving two fines prefs from Patrons to Circulation/Fines Policy. Rewording no=Allow to exceed to no=Do not use for more clarity :) Test plan: Check if you can still find them.. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 11:39:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 09:39:07 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-QwPJFI24Ed@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #27 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Had some problems understanding No=Allow to exceed ... I think that No=Do not use replacement price as max is easier? Attached a QA followup that also moves the two prefs to Circulation tab, as noted before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 11:49:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 09:49:10 +0000 Subject: [Koha-bugs] [Bug 9864] systematic searching error : can't call method "raw" In-Reply-To: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9864-70-I5iMqb4FLo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9864 Guillaume Hatt <guillaume.hatt at enc.sorbonne.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |guillaume.hatt at enc.sorbonne | |.fr --- Comment #6 from Guillaume Hatt <guillaume.hatt at enc.sorbonne.fr> --- Hello, I have the same problem after an "apt-get install koha-common" on Debian Squeeze, using 3.12 version packages : Can't call method "raw" on an undefined value at /usr/share/koha/lib/C4/Search.pm line 490." My installation is french UNIMARC, and I did a full reindexation. Thanks. G. Hatt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 11:50:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 09:50:07 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-GfcYqnQItw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA --- Comment #28 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #20) > One nice feature of this patch as it stands is that you can specify both > MaxFine and MaxFineIsReplacementPrice at once. If the replacement price is > over the MaxFine, it will be reduced. > > To move it to the circulation matrix would require a full re-write. The > overduefinescap functions within CalcFine, rather than UpdateFine. > > Perhaps we have fines logic in too many places. Maybe MaxFines logic needs > to be moved to CalcFine as well. I agree with Galen that moving them both out of the prefs would be great. But adjusting a lot of troublesome circulation code would be great too. All together, I do no think that we should block this patch for that reason. BTW Kyle should be the ideal candidate to get the code in CalcFine and UpdateFine on a higher level as followup :) Moving the status back to Passed QA for final RM comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 11:59:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 09:59:33 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-uKJpSbeCu5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 11:59:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 09:59:40 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-OjmZrWPgmq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17038|0 |1 is obsolete| | --- Comment #92 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18372&action=edit Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 12:00:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 10:00:41 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-EqK7PHKLQG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #93 from Jonathan Druart <jonathan.druart at biblibre.com> --- I amended my ut patch in order to add some tests for the move_field routine. Now all tests pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 12:26:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 10:26:58 +0000 Subject: [Koha-bugs] [Bug 10322] New: IndependentBranches - can edit items from other branches Message-ID: <bug-10322-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10322 Bug ID: 10322 Summary: IndependentBranches - can edit items from other branches Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: vfernandes at keep.pt CC: m.de.rooy at rijksmuseum.nl IdenpendentBranches - prevent A user with editcatalogue permissions can edit and remove items from other branches. In items table (appears on the top of items cataloguing/editing page) the menu that appears with javascript when clicking on the items has a link to edit the item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 12:33:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 10:33:16 +0000 Subject: [Koha-bugs] [Bug 10322] IndependentBranches - can edit items from other branches In-Reply-To: <bug-10322-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10322-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10322-70-k7Af5DgdEO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10322 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Vitor, I think this has been fixed quite recently - bug 10225. *** This bug has been marked as a duplicate of bug 10225 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 12:33:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 10:33:16 +0000 Subject: [Koha-bugs] [Bug 10225] If an item isn't editable, don't show the onclick Edit/Delete menu In-Reply-To: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10225-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10225-70-WwKdIupDfn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10225 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vfernandes at keep.pt --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 10322 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 12:56:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 10:56:21 +0000 Subject: [Koha-bugs] [Bug 10323] New: Allow system preferences to be overridable from koha-httpd.conf Message-ID: <bug-10323-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10323 Bug ID: 10323 Summary: Allow system preferences to be overridable from koha-httpd.conf Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com It would be nice to be able to override systeprefs from the http conf file. Case in point, a library wants to have two separate opacs, one the is only viewable from within the library that allows patrons to place holds, and a second public one that does not. In this case, overriding the system preference RequestOnOpac would accomplish this simply, and with no ill affects. This feature would of course be highly dangerous and system prefs should only be overridden if they have cosmetic effects on the system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 12:57:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 10:57:00 +0000 Subject: [Koha-bugs] [Bug 10323] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: <bug-10323-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10323-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10323-70-Ce8PbCJC8T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10323 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 12:59:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 10:59:03 +0000 Subject: [Koha-bugs] [Bug 10323] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: <bug-10323-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10323-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10323-70-BlZahUogHE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10323 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 12:59:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 10:59:39 +0000 Subject: [Koha-bugs] [Bug 10324] New: Editorial series do not display correctly in normal view (UNIMARC / no XSLT) Message-ID: <bug-10324-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10324 Bug ID: 10324 Summary: Editorial series do not display correctly in normal view (UNIMARC / no XSLT) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: januszop at gmail.com For UNIMARC bibliographic records, in normal view (no XSLT) the information about editorial series (field 225) do not display correctly. Instead of 225 the content subject headings fields is displayed. To reproduce: take a UNIMARC record with 225 and some 6[01]. correctly filled up and see what is displayed under "Series:". A patch will follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:06:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:06:21 +0000 Subject: [Koha-bugs] [Bug 10324] Editorial series do not display correctly in normal view (UNIMARC / no XSLT) In-Reply-To: <bug-10324-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10324-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10324-70-HBc3adbOU4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10324 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |januszop at gmail.com --- Comment #1 from Janusz Kaczmarek <januszop at gmail.com> --- Created attachment 18373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18373&action=edit Proposed patch The patch corrects the issue -- the content of the field 225 shall be displayed under Series now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:09:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:09:28 +0000 Subject: [Koha-bugs] [Bug 10325] New: Allow system preferences to be overridable from koha-httpd.conf Message-ID: <bug-10325-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 Bug ID: 10325 Summary: Allow system preferences to be overridable from koha-httpd.conf Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com For Koha installations with multiple OPAC URLs, It would be nice to be able to override systeprefs from the http conf file. Case in point, a library wants to have two separate opacs, one the is only viewable from within the library that allows patrons to place holds, and a second public one that does not. In this case, overriding the system preference RequestOnOpac would accomplish this simply, and with no ill affects. This feature would of course be should only be used to override cosmetic effects on the system, and should not be used for system preferences such as CircControl, but would be great for preferences such as OpacStarRatings, opacuserjs, OpacHighlightedWords and many others! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:09:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:09:57 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: <bug-10325-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10325-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10325-70-YTCwCi8tRz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18374&action=edit Bug 10325 - Allow system preferences to be overridable from koha-httpd.conf For Koha installations with multiple OPAC URLs, It would be nice to be able to override systeprefs from the http conf file. Case in point, a library wants to have two separate opacs, one the is only viewable from within the library that allows patrons to place holds, and a second public one that does not. In this case, overriding the system preference RequestOnOpac would accomplish this simply, and with no ill affects. This feature would of course be should only be used to override cosmetic effects on the system, and should not be used for system preferences such as CircControl, but would be great for preferences such as OpacStarRatings, opacuserjs, OpacHighlightedWords and many others! Test Plan: 1) Apply this patch 2) Disable the system pref OpacHighlightedWords 3) Do a seach in the OPAC, not the term is not highlighted 4) Edit your koha-http.conf file, add the line SetEnv OVERRIDE_SYSPREF_OpacHighlightedWords "1" to your koha-http.conf file's OPAC section. 5) Restart your web server, or just reload it's config 6) Do a seach, now your search term should be highlighted! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:09:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:09:56 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: <bug-10325-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10325-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10325-70-NErmalX0oI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:20:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:20:34 +0000 Subject: [Koha-bugs] [Bug 10326] New: bulkmarcimport.pl turns off CataloguingLog sys pref Message-ID: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Bug ID: 10326 Summary: bulkmarcimport.pl turns off CataloguingLog sys pref Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: januszop at gmail.com The bulkmarcimport.pl script does not correctly restore the CataloguingLog system preference. To reproduce: 1) have CataloguingLog set to Log; 2) import some batch of bibliographic records with bulkmarcimport.pl 3) check the state of CataloguingLog system preference -- it will be set to "Don't log". A patch will follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:23:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:23:43 +0000 Subject: [Koha-bugs] [Bug 10327] New: Rename poorly named system preferences Message-ID: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Bug ID: 10327 Summary: Rename poorly named system preferences Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com Over time Koha's system preference names have become de facto standardized using upper camel case. It would be nice to go through our system preferences and rename those prefs that do not follow this standard. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:23:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:23:56 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10327-70-Qvw0NItEIE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:23:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:23:55 +0000 Subject: [Koha-bugs] [Bug 10326] bulkmarcimport.pl turns off CataloguingLog sys pref In-Reply-To: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10326-70-iZgxyysHOB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |januszop at gmail.com --- Comment #1 from Janusz Kaczmarek <januszop at gmail.com> --- Created attachment 18375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18375&action=edit Proposed patch The patch corrects the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:26:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:26:10 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: <bug-9254-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9254-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9254-70-hglHZnsVOa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Sophie MEYNIEUX <sophie.meynieux at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #13 from Sophie MEYNIEUX <sophie.meynieux at biblibre.com> --- As described in Koha Manual, 1.12.12. EnhancedMessagingPreferences Default: Allow Asks: ___ patrons to choose which notices they receive and when they receive them. Values: Allow Don't allow Important This only applies to certain kinds of notices, overdue notices will be sent based on the library's rules, not the patron's choice. So this syspref is defined to allow patrons to choose the notifications they want to receive. What Victor describes as a problem is not one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:33:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:33:11 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: <bug-10325-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10325-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10325-70-Xeb89JrclO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:34:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:34:14 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10298-70-4MkJhXMPqb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18376&action=edit Bug 10298: Followup: Adapt existing code This unit tests file does not need the t::lib::Mocks::Context module. To test: prove t/db_dependent/Circulation_issuingrules.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:34:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:34:29 +0000 Subject: [Koha-bugs] [Bug 10328] New: Rename opaccolorstylesheet to OpacColorStyleSheet Message-ID: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Bug ID: 10328 Summary: Rename opaccolorstylesheet to OpacColorStyleSheet Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:34:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:34:34 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10328-70-Qp5ESKCuTN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:34:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:34:46 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10328-70-JDms2ScZIl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Blocks| |10327 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:34:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:34:46 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10327-70-8iyOlu46fQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10328 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:36:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:36:30 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10328-70-AFe9bqLEl5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18377&action=edit Bug 10328 - Rename opaccolorstylesheet to OpacColorStyleSheet Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify the system pref OpacColorStyleSheet still works i.e. no change should be noted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:36:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:36:29 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10328-70-VCqQhy65O5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:42:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:42:06 +0000 Subject: [Koha-bugs] [Bug 10329] New: Rename system preference marcflavour to MarcFormat Message-ID: <bug-10329-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329 Bug ID: 10329 Summary: Rename system preference marcflavour to MarcFormat Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:42:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:42:44 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10327-70-jcsbZUJma9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10329 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:42:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:42:44 +0000 Subject: [Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat In-Reply-To: <bug-10329-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10329-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10329-70-XvSt1SdqHa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Depends on| |10327 Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:45:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:45:22 +0000 Subject: [Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat In-Reply-To: <bug-10329-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10329-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10329-70-SNDyBuZYa7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18378&action=edit Bug 10329 - Rename system preference marcflavour to MarcFormat Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) View and edit some records 4) You should not see any change in functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:45:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:45:20 +0000 Subject: [Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat In-Reply-To: <bug-10329-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10329-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10329-70-wNurv1telg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:47:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:47:09 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10327-70-aQ0gOmyaoT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10328 Depends on|10328 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:47:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:47:09 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10328-70-rIopA7TNVz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10327 | Depends on| |10327 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:47:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:47:44 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10328-70-U0BKiowBWr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10327 Depends on|10327 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:47:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:47:44 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10327-70-SDwsYZAYFj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10328, 10329 | Depends on| |10328, 10329 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:47:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:47:44 +0000 Subject: [Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat In-Reply-To: <bug-10329-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10329-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10329-70-REFA9t1hQu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10327 Depends on|10327 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:51:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:51:05 +0000 Subject: [Koha-bugs] [Bug 10330] New: Rename system preference authoritysep to AuthoritySeperator Message-ID: <bug-10330-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Bug ID: 10330 Summary: Rename system preference authoritysep to AuthoritySeperator Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:51:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:51:32 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10327-70-nwuHLB3Qr9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10330 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:51:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:51:32 +0000 Subject: [Koha-bugs] [Bug 10330] Rename system preference authoritysep to AuthoritySeperator In-Reply-To: <bug-10330-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10330-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10330-70-gcyuy4cfLf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Blocks| |10327 Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:56:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:56:03 +0000 Subject: [Koha-bugs] [Bug 10330] Rename system preference authoritysep to AuthoritySeperator In-Reply-To: <bug-10330-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10330-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10330-70-kEjGHAI9P6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 13:56:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 11:56:04 +0000 Subject: [Koha-bugs] [Bug 10330] Rename system preference authoritysep to AuthoritySeperator In-Reply-To: <bug-10330-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10330-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10330-70-pBV4puU87X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10330 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18379&action=edit Bug 10330 - Rename system preference authoritysep to AuthoritySeperator Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) View some records with authorities 4) Note your previously set authority separator should still be in use -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:03:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:03:43 +0000 Subject: [Koha-bugs] [Bug 10329] Rename system preference marcflavour to MarcFormat In-Reply-To: <bug-10329-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10329-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10329-70-NhDC1MNUIF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10329 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18378|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18380&action=edit Bug 10329 - Rename system preference marcflavour to MarcFormat Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) View and edit some records 4) You should not see any change in functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:07:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:07:47 +0000 Subject: [Koha-bugs] [Bug 10331] New: Little errors in unimarc_field_4XX.pl (punctuation) Message-ID: <bug-10331-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Bug ID: 10331 Summary: Little errors in unimarc_field_4XX.pl (punctuation) Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: januszop at gmail.com CC: m.de.rooy at rijksmuseum.nl The punctuation in subfield $a in linking fields 4XX is wrong when filling it up with the unimarc_field_4XX.pl To reproduce: A. 1) have $a active in one of the linking fields (like 461, 463, etc.). 2) have a biblio record with the field 700 $a, $b, $f filled up 3) go to cataloguing -> field 4XX of your choice, use the plugin to fetch data from biblio rec. mentioned in b) 4) see the punctuation in $a -- it will be wrong (no closing bracket) B. 1) have $a active in one of the linking fields (like 461, 463, etc.). 2) have a biblio record with the field 700 $a, $b, $c, $f filled up 3) go to cataloguing -> field 4XX of your choice, use the plugin to fetch data from biblio rec. mentioned in b) 4) see the punctuation in $a -- it will be wrong (dash instead of semicolon between original $c and $f, no closing bracket) C. 1) have $a active in one of the linking fields (like 461, 463, etc.). 2) have a biblio record with the field 702 $a, $b, $c filled up 3) go to cataloguing -> field 4XX of your choice, use the plugin to fetch data from biblio rec. mentioned in b) 4) see the punctuation in $a -- it will be wrong (unnecessary semicolon after original $c, n.b. lacking space). A patch will follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:12:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:12:02 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: <bug-10331-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10331-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10331-70-vviEahIGwZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |januszop at gmail.com --- Comment #1 from Janusz Kaczmarek <januszop at gmail.com> --- Created attachment 18381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18381&action=edit Proposed patch The patch corrects the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:23:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:23:03 +0000 Subject: [Koha-bugs] [Bug 10332] New: UT: CourseReserves.t needs to create its own data Message-ID: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Bug ID: 10332 Summary: UT: CourseReserves.t needs to create its own data Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com t/db_dependent/Acquisition/CourseReserves.t depends on the Jenkins database. We should create the data we want and delete them at the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:23:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:23:16 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10332-70-Ig0UrJcbgN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:24:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:24:00 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10332-70-8RoBXNkezW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10273 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:24:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:24:00 +0000 Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database In-Reply-To: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10273-70-k1rY0HGPZc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10332 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:25:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:25:42 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10332-70-kH8i8sUTbU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18382&action=edit Bug 10332: CourseReserves.t needs to create its own data prove t/db_dependent/CourseReserves.t t/db_dependent/CourseReserves.t .. ok All tests successful. Files=1, Tests=20, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.43 cusr 0.03 csys = 0.48 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:25:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:25:40 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10332-70-s3vCRQcDOK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:29:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:29:44 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10184-70-iYsnZVaXsO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- I set to "Failed QA" because of the issue with the table header sort indicator. I see your point about the forced re-sort. In my tests there was a minor difference in processing time, but I didn't test with an account with a large history (only ~120). The indicator is a minor point, so I'll give the re-sort question the benefit of the doubt and say it's not worth the extra processing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:31:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:31:06 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10184-70-OniQNBQ3v2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:31:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:31:08 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10184-70-Npq6NJTQpx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17933|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18383&action=edit [SIGNED-OFF] Bug 10184 - Circulation History reverses sort order Issue data is passed to the readingrec template ordered most recent due date first. Datatables unless specified otherwise do a presort on the data they will display the default results in an order the reverse of what was intended. Disabling the presort preserves the initial sort order until the user selects a different sort http://bugs.koha-community.org/show_bug.cgi?id=10184 Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:46:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:46:16 +0000 Subject: [Koha-bugs] [Bug 10328] Rename opaccolorstylesheet to OpacColorStyleSheet In-Reply-To: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10328-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10328-70-GCC5cSEWdh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10328 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- If we're renaming this one, maybe we should rename it to something which better describes its use? It's not really a stylesheet for color, even though that was the original intention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:51:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:51:48 +0000 Subject: [Koha-bugs] [Bug 10333] New: UT: Labels/t_Batch.t needs to create its own data Message-ID: <bug-10333-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Bug ID: 10333 Summary: UT: Labels/t_Batch.t needs to create its own data Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com t/db_dependent/Labels/t_Batch.t depends on the Jenkins database. We should create the data we want and delete them at the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:52:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:52:19 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10332-70-T2QiEKccRo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10273 Depends on|10273 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:52:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:52:19 +0000 Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database In-Reply-To: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10273-70-M68PSlTvjy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10332 | Depends on| |10332 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:52:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:52:27 +0000 Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database In-Reply-To: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10273-70-gG2kXb0OKZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10333 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:52:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:52:27 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: <bug-10333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10333-70-Q99Puu1xCx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |10273 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:53:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:53:54 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: <bug-10333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10333-70-eMR03wNxDb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 14:53:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 12:53:56 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: <bug-10333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10333-70-YALQQwWYIn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18384&action=edit Bug 10333: Labels/t_Batch.t needs to create its own data prove t/db_dependent/Labels/t_Batch.t [14:53:09] t/db_dependent/Labels/t_Batch.t .. 1/32 # Testing Batch->new() method. t/db_dependent/Labels/t_Batch.t .. 13/32 # Testing Batch->retrieve() method. t/db_dependent/Labels/t_Batch.t .. ok All tests successful. Files=1, Tests=32, 3 wallclock secs ( 0.02 usr 0.00 sys + 0.48 cusr 0.03 csys = 0.53 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 15:08:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 13:08:38 +0000 Subject: [Koha-bugs] [Bug 10334] New: UT: t/db_dependent/needs_user_input/* are unusable Message-ID: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Bug ID: 10334 Summary: UT: t/db_dependent/needs_user_input/* are unusable Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com t/db_dependent/needs_user_input/Auth.t and t/db_dependent/needs_user_input/Auth_with_ldap.t seem not really useful. If I refer to the git history, it seems that they are antiquated tests. The first one is not compilable: perl -wc t/db_dependent/needs_user_input/Auth.t Can't locate override_context_prefs.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 15:09:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 13:09:09 +0000 Subject: [Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable In-Reply-To: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10334-70-59hnOLjdvP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |10273 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 15:09:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 13:09:09 +0000 Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database In-Reply-To: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10273-70-xAw3erWnyQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10334 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 15:10:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 13:10:30 +0000 Subject: [Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable In-Reply-To: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10334-70-0p2HsfkyfQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18385&action=edit MT10334: t/db_dependent/needs_user_input/* are unusable t/db_dependent/needs_user_input/Auth.t and t/db_dependent/needs_user_input/Auth_with_ldap.t seem not really useful. If I refer to the git history, it seems that they are antiquated tests. The first one is not compilable: perl -wc t/db_dependent/needs_user_input/Auth.t Can't locate override_context_prefs.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 15:10:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 13:10:28 +0000 Subject: [Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable In-Reply-To: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10334-70-P8EcVJRVwP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 15:10:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 13:10:43 +0000 Subject: [Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable In-Reply-To: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10334-70-LyT3Rgnu9J@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 15:17:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 13:17:27 +0000 Subject: [Koha-bugs] [Bug 10335] New: UNIMARC authorities search doesn't display properly information on parallel form Message-ID: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 Bug ID: 10335 Summary: UNIMARC authorities search doesn't display properly information on parallel form Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: januszop at gmail.com UNIMARC authorities can contain translated headings. The language is coded in $8 subfield: "Subfield $8 contains 6 character positions (designated as $8/0, 8/1, etc.) The first group of three characters specifies the language of catalogue into which the heading in the field is designed to fit; the second group of three characters specifies the language of the base heading. The language codes are listed in the ISO 639-2 standard and in Appendix A of the UNIMARC Manual - Bibliographic Format." (cf. UNIMARC manual : authorities format. -- 2nd rev. and enl. ed. -- M?nchen : Saur, 2001, p. 66) I.e. it is the second triple designates the language of in which the actual parallel form is entered. Currently the information is displayed wrongly. To reproduce: 1) Create an authority record with main heading (100) in Latin script (e.g. Oppenheimer, Aharon -- subfields $a and $b) and parallel form (700) in Hebrew (?????????, ???? -- subfields $a and $b). Mark it correctly in $8 with freheb (or engheb if you like); 2) reindex and search; 3) you will see: Oppenheimer Aharon freheb: ????????? Whereas you would rather like to see (mind language and lack of $b above): Oppenheimer, Aharon Hebrew: ?????????, ???? A patch will follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 15:22:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 13:22:22 +0000 Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form In-Reply-To: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10335-70-MR3ObkgSfo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |januszop at gmail.com --- Comment #1 from Janusz Kaczmarek <januszop at gmail.com> --- Created attachment 18386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18386&action=edit Proposed patch The patch corrects the issue and should not harm those who (improperly) put only one triple in $8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 15:22:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 13:22:33 +0000 Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form In-Reply-To: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10335-70-sdJ2jaHnAl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 15:42:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 13:42:41 +0000 Subject: [Koha-bugs] [Bug 9864] systematic searching error : can't call method "raw" In-Reply-To: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9864-70-OxCuCjZcpz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9864 --- Comment #7 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- I made the update (it's already some weeks ago) as you suggested in comment 3 perl Makefile.PL --prev-install-log /home/[USER]/koha-dev/misc/koha-install-log but seems there's a problem with dev install update : What happens is that files present in our /home/[USER]/koha-dev/etc/zebradb repertory are saved and postfixed with current version number (something like retrieval-info-auth-grs1.xml_3.08.88 ) but new retrieval and mar files are not copied from /home/[USER]/src/etc/zebradb in it. Moreover, record.abs and koha-conf.xml aren't updated. So I made the minimum necessary modifications by hands (only for unimarc flavour et grs1 indexation) : first I deleted all saved files then copied the 2 unimarc retrieval files (unimarc-retrieval-info-auth-grs1.xml and unimarc-retrieval-info-bib-grs1.xml) from /home/[USER]/src/etc/zebradb in /home/[USER]/koha-dev/zebradb copied unimarc.mar file in /home/[USER]/koha-dev/zebradb/etc replaced 'marc usmarc.mar' line by 'marc unimarc.mar' in record.abs replaced all occurrences of syntax="usmarc" by syntax="unimarc" in koha-conf.xml reindexed and it's ok Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 15:49:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 13:49:35 +0000 Subject: [Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc In-Reply-To: <bug-5572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5572-70-6WlIrEAdMv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 --- Comment #22 from Janusz Kaczmarek <januszop at gmail.com> --- (In reply to comment #20) > I do not think this is correct. Subfield 'e' is not authority-controlled, > but Koha treats all non-numeric subfields in authority-controlled fields as > if they are. Or am I misunderstanding what this bug does, and there is a > workaround for this? OK, the action of the modified merge procedure is based on "Select to display or not" (i.e. auth_subfield_structure.hidden) and of course one has to be cautious about it. If a subfield of the heading is hidden in authority editor == it not supposed to be controlled == will never be overwriten. This would be the case of auth. 100 applied on biblio. 700 with $e present. $e will stay untouched provided it is not active in the authorities framework. Why I now think it is really important: a very common case for my libraries (participating in a cooperative cataloguing program) are personal headings with duplicated family name + surname. So, if the librarian who creates the entry does no know the dates, he/she adds a qualifier like $c. But then another librarian who found the dates (maybe after some months or even years) exchanges $c for $d in the authority data. Now, without this enhancement you will have $c and $d in bibliographic records, which is what you don't want. Another reason is the case when wrongly entered data was propagated to several dozens of biblio recs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 15:57:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 13:57:12 +0000 Subject: [Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc In-Reply-To: <bug-5572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5572-70-j59oQUFov9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7264|0 |1 is obsolete| | --- Comment #23 from Janusz Kaczmarek <januszop at gmail.com> --- Created attachment 18387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18387&action=edit Proposed patch - refreshed Applies smoothly to master (as on 24th May 2013) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:12:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:12:39 +0000 Subject: [Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc In-Reply-To: <bug-5572-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5572-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5572-70-ufWBIffj5G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5943 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:12:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:12:39 +0000 Subject: [Koha-bugs] [Bug 5943] Merging Authorities In-Reply-To: <bug-5943-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5943-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5943-70-fOktK6cMsp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5943 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5572 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:23:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:23:36 +0000 Subject: [Koha-bugs] [Bug 10336] New: UT: HoldsQueue.t needs to create its own data Message-ID: <bug-10336-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Bug ID: 10336 Summary: UT: HoldsQueue.t needs to create its own data Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com t/db_dependent/HoldsQueue.t depends on the Jenkins database. We should create the data we want and delete them at the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:23:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:23:57 +0000 Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database In-Reply-To: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10273-70-ChLE6CnOPw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10336 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:23:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:23:57 +0000 Subject: [Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data In-Reply-To: <bug-10336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10336-70-rMXRMhHGwA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |10273 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:31:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:31:26 +0000 Subject: [Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data In-Reply-To: <bug-10336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10336-70-9lq75BPhjO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18388&action=edit WIP: HoldsQueue.t needs to create its own data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:33:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:33:26 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-nWuizRSgZA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #29 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #28) > > Perhaps we have fines logic in too many places. Maybe MaxFines logic needs > > to be moved to CalcFine as well. > > I agree with Galen that moving them both out of the prefs would be great. > But adjusting a lot of troublesome circulation code would be great too. The thing is, not taking the time to set a new circ policy switch at the right level of specificity just adds to the refactoring work that has to be done later. Setting back to in discussion to ask the question of Kyle directly: are you willing to prepare a version of this patch that adds this limit as a issuingrules policy, not a system preference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:33:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:33:43 +0000 Subject: [Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data In-Reply-To: <bug-10336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10336-70-lpDfwN5E7C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Hi Kyle, I tried to pass HoldsQueue unit tests but I am not able to do :-/ The idea is to create all data the tests need before launching them in order not to be dependent on the Jenkins database. Could you take a look at it please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:41:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:41:49 +0000 Subject: [Koha-bugs] [Bug 10337] New: UT: The unit tests cannot be launched by everyone Message-ID: <bug-10337-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 Bug ID: 10337 Summary: UT: The unit tests cannot be launched by everyone Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com Currently, only jenkins is able to launch tests successfully. It would great to have a file in the db_dependent directory to initialize the database structure with sample data. Like that all developers will be able to launch unit tests and check if a development breaks something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:42:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:42:12 +0000 Subject: [Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone In-Reply-To: <bug-10337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10337-70-W78OXlTY5G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10273 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:42:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:42:12 +0000 Subject: [Koha-bugs] [Bug 10273] Unit tests should not be dependent on the Jenkins database In-Reply-To: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10273-70-yuh2BBF8Rn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10273 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10337 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:43:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:43:36 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10298-70-4dYSzbFz2r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10337 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:43:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:43:36 +0000 Subject: [Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone In-Reply-To: <bug-10337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10337-70-tt2S8QV6RW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10298 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:50:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:50:25 +0000 Subject: [Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone In-Reply-To: <bug-10337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10337-70-WzalGrMOVy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18389&action=edit Bug 10337: Unit tests is based on an existing database This patchs adds a new unit tests file which will launched before all others db_dependent tests. It will drop and recreate the database with sample data. Prerequisite: The database 'koha_ut' have to be created with CREATE DATABASE $dbname CHARACTER SET utf8 COLLATE utf8_bin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:51:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:51:54 +0000 Subject: [Koha-bugs] [Bug 10336] UT: HoldsQueue.t needs to create its own data In-Reply-To: <bug-10336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10336-70-XOaJOFQVWC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10336 --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- I create a new database containing sample data with script submitted on bug 10337. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:52:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:52:41 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-pG2jMDNDDl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Please note that I adjusted the commit message to include the example usage found in the POD. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:53:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:53:18 +0000 Subject: [Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone In-Reply-To: <bug-10337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10337-70-uOjp4tDZLo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:53:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:53:08 +0000 Subject: [Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone In-Reply-To: <bug-10337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10337-70-L7lqYdbjnG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- This patch is proposed for discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:54:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:54:35 +0000 Subject: [Koha-bugs] [Bug 10337] UT: The unit tests cannot be launched by everyone In-Reply-To: <bug-10337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10337-70-EkgtbMNobN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18389|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18390&action=edit Bug 10337: Unit tests is based on an existing database This patchs adds a new unit tests file which will launched before all others db_dependent tests. It will drop and recreate the database with sample data. Prerequisite: The database 'koha_ut' have to be created with CREATE DATABASE $dbname CHARACTER SET utf8 COLLATE utf8_bin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 16:55:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 14:55:38 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10120-70-5Yei6FpVms@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #14 from Galen Charlton <gmcharlt at gmail.com> --- For future reference, the IRC discussion in question starts at http://irc.koha-community.org/koha/2013-04-25#i_1239245 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 17:10:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 15:10:02 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10120-70-cqB5vS05Wj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #15 from Galen Charlton <gmcharlt at gmail.com> --- And a general comment: perhaps we should consider having loan records either store a copy of the circ policy that applies to the loan (e.g., issuelength, lengthunit, fine, finedays, etc.) or a reference to it (e.g,. by first giving issuingrules an opaque PK, then adding that as a FK to issues). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 17:11:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 15:11:03 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10120-70-AXjmW3RRaw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 --- Comment #16 from Galen Charlton <gmcharlt at gmail.com> --- And of course, Chris already suggested that. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 17:52:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 15:52:06 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10120-70-o8z2rUs2mH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Galen Charlton <gmcharlt at gmail.com> --- I have pushed the main patch to master, though with a bit of reluctance as I suspect the need for this syspref will go away if/when the underpinnings of fine accounting are improved. I have *not* pushed the follow-up whitespace patch; it might just be me, but I found that it made that section of code *less* readable, not more. Among other reasons, I really prefer that comments be indented at the same level as the block they apply to. I suggest that we just plan on running C4/Circulation.pm through perltidy at some point in the near future. Thanks, Chris! RMaint 3.12 please take note: I believed that this is considered a blocker by at least one library to upgrading. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 18:16:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 16:16:29 +0000 Subject: [Koha-bugs] [Bug 9161] Translate only specific files In-Reply-To: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9161-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9161-70-YGLiXgigUM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9161 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 18:31:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 16:31:22 +0000 Subject: [Koha-bugs] [Bug 9424] Move JavaScript out of header include In-Reply-To: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9424-70-IYOvQt4NDk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 18:31:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 16:31:24 +0000 Subject: [Koha-bugs] [Bug 9424] Move JavaScript out of header include In-Reply-To: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9424-70-Agv7H1wgjy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18358|0 |1 is obsolete| | --- Comment #8 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18391&action=edit Bug 9424: Move JavaScript out of header include This patch removes JavaScript "onlick" attributes from header.inc and moves the functionality to staff-global.js. This is in keeping with the idea of progressive enhancement. To test, be sure to clear your browser cache after applying the patch. - Test the help link. - Test the logout link with the intranetbookbag preference on and off. - Open a patron's account and click "search to hold." Log out, and log in again. Koha should not remember the patron you chose before logging out (as seen from a search results page). Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 18:47:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 16:47:59 +0000 Subject: [Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR In-Reply-To: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8884-70-vG9ydXH5wZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #9) > Maybe we could just copy from opacheader into the new preference on database > update and preserve the current customizations that way? Wouldn't copying over the contents of 'opacheader' to a new preference cause a bit of a surprise (in the form of duplicate text or the like) for libraries that aren't using CCSR? Also, that begs the question of whether a new system preference is needed -- shifting logos around could be done via OpacUserCSS, and at the moment I'm not convinced that we need to maintain backwards compatibility for what appears to simply have been an oversight. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 19:12:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 17:12:06 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10327-70-KMVXOB8W2T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #1 from Galen Charlton <gmcharlt at gmail.com> --- We should probably decide on some ground rules for this. I'm not opposed to the idea in general terms, as choosing better names for some system preferences can improve Koha's polish. However, I think it safe to assume that there are no system preferences so poorly named that it's worth risking functionality breakage. Here are my preferences regarding system preference names: - They should make positive assertions. Consequently, "noItemTypeImages" and "noissuescharge" should be considered for renaming. - They should be fully spelled out except for very well-known acronyms (e.g., "MARC" is OK in a syspref name) - They should describe their current purpose. And some caveats: - If a system preference name is also used for other purposes, particularly database column names, the bar is going to be higher for accepting the patch. I'm thinking of 'marcflavour' in particular. I value consistency in the code base pretty highly; I would rather have a non-optimal name be used throughout than mixing old and new names for the same concept. - Patches that just rename system preferences are much more likely to be accepted at the beginning of a release than at the end. - It is OK for Koha to have a few idiosyncrasies. Unless there's evidence that a given name is *actually* confusing to users, these patches are never going to be high priority. One thing for folks to keep in mind is that system preference lookup (as with everything else in MySQL) is case-INsensitive. Consequently, if you're grepping for a system preference name, remember to use -i By the way, thanks, Kyle, for creating the omnibus bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 19:14:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 17:14:29 +0000 Subject: [Koha-bugs] [Bug 5380] an end to copy-and-paste-itis In-Reply-To: <bug-5380-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5380-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5380-70-fPmuCsPDzT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5380 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #6) > I am tempted to close this as it has not seen any attention in quite a > while. It might be worth doing individual bugs for removing code as this can > always have dangerous side effects. I agree -- obviously I'm keen to extirpate copy-pasta on sight, but I don't think this omnibus bug needs to remain open. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 19:16:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 17:16:58 +0000 Subject: [Koha-bugs] [Bug 9370] use Library::CallNumber::LC when splitting LC call numbers for spine labels In-Reply-To: <bug-9370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9370-70-UmnE0d6b9s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 --- Comment #8 from Galen Charlton <gmcharlt at gmail.com> --- Just noting that as of today, the patch series still applies cleanly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 19:21:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 17:21:11 +0000 Subject: [Koha-bugs] [Bug 10039] the systempreferences.variable column should be a unique key In-Reply-To: <bug-10039-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10039-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10039-70-9j3ShqkYIo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10039 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #4 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #3) > (In reply to comment #2) > > Same conclusion here, the variable names are already unique. > These primary keys nowadays are no longer what they used to be :) I don't trust them! In the cold light of today, I have no idea why I opened this. I can only assume that I had run into a database that had dropped the PK for some reason. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 19:22:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 17:22:41 +0000 Subject: [Koha-bugs] [Bug 5324] "bring out the dead!" in C4 In-Reply-To: <bug-5324-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5324-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5324-70-JkzRe8uxm0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5324 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WISHLIST --- Comment #2 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #1) > I think this was thought to be an umbrella bug, but it has not got any > attention. Maybe we should close and start over? Or can we find some bugs to > link to this? :) Why bring an umbrella to the desert? :) I agree; I'm closing this. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 19:26:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 17:26:26 +0000 Subject: [Koha-bugs] [Bug 9864] systematic searching error : can't call method "raw" In-Reply-To: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9864-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9864-70-hSsQtgGAyu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9864 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #8 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I never notice this problem, that's strange. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 19:39:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 17:39:02 +0000 Subject: [Koha-bugs] [Bug 4306] Label manage batch listing should show item-level itemtype In-Reply-To: <bug-4306-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-4306-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4306-70-ziGyX6OJvH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4306 --- Comment #6 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #3) > Now the list shows the item type if it has been set at the biblio level and > the collection code if it has not. I don't think this is the intended > outcome. Do you still see this happening? I'm not. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 20:26:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 18:26:58 +0000 Subject: [Koha-bugs] [Bug 10338] New: Search history can cause "Out of memory" errors Message-ID: <bug-10338-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10338 Bug ID: 10338 Summary: Search history can cause "Out of memory" errors Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: OPAC Assignee: oleonard at myacpl.org Reporter: jweaver at bywatersolutions.com After a certain number of searches, thawing the search history cookie (line ~296 of C4/Auth.pm) can cause an "Out of memory" error, causing all OPAC scripts to stop working. This seems to occur after a certain number of searches, but does not seem to be related to corruption or truncation due to the max cookie size. The current workaround is to disable OPAC search history (the EnableOpacSearchHistory syspref). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 22:23:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 20:23:36 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: <bug-10320-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10320-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10320-70-nwCemN8nTe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Jesse Weaver <jweaver at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 22:23:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 20:23:59 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10327-70-uV1SgGKNdx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 --- Comment #2 from Galen Charlton <gmcharlt at gmail.com> --- I would also urge folks to write test cases exercising each syspref that get srenamed, as that would make the benefit not just cosmetic. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 22:29:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 20:29:05 +0000 Subject: [Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x In-Reply-To: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10293-70-ymDYFsKRY6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 22:29:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 20:29:07 +0000 Subject: [Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x In-Reply-To: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10293-70-A6QMsql8Ac@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18303|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18392&action=edit Bug 10293 - Bug 9930 needs to be reverted for 3.10.x The patch for bug 9930 needs to be reverted for 3.10.x, as the patron self registration feature is not part of 3.10.x. With the patch applied, the OPAC patron details link may redirect to a non-existent page ( opac-memberentry.pl ). Test Plan: 1) Set OPAC to use CCSR theme. 2) Log into the OPAC. 3) Click the link for your username. 4) Click the "my personal details" tab. 5) Note the error page you get 6) Apply this patch 7) Refresh the page 8) You should now see the user details update page This reverts commit e5186d6d784c1fdd8d12c6e93e163d0b9e10cc0e. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 22:32:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 20:32:54 +0000 Subject: [Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x In-Reply-To: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10293-70-MGI250VHvg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com, | |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- One for you Bernardo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 22:35:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 20:35:49 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-iKkvlK9IIc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Version|3.10 |master --- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> --- This bug is present on 3.12.x and master also -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 22:42:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 20:42:42 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-kP9YdOP6Yk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10120 --- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> --- In order to QA this patch on master, I needed to fix a conflict with bug 10120. This makes this patch now dependent on it. If 10120 is not pushed to 3.12.x and 3.10.x then the original patch would work (I'd of course prefer 10120 to be pushed as it is blocking some of my libraries from upgrading) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 22:42:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 20:42:42 +0000 Subject: [Koha-bugs] [Bug 10120] Fine recalculation on return needs to be a system preference In-Reply-To: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10120-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10120-70-jwEdxvnKjg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10120 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10262 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 22:45:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 20:45:22 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-I5KbxllIim@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 22:45:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 20:45:25 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-wdS8AYKXMT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18322|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18393&action=edit Bug 10262 - fine calculation at checkin not respecting CircControl The fines.pl script uses the system preference CircControl to decide what branches circ rules to use for fine generation. Recently, code was added to the returns system to recalculate the fine at checkin time ( to support hourly loans ). The problem is that this code does not respect CircControl. Test Plan: 1) Set circ control to "the library you are logged in at" 2) Set different fines rules for two different librarys 3) Check an item out at library A, backdate the due date so it's overdue and will have fines. 4) Check the item in at library B 5) Observe that the fines should be generated based on library A's rules, but the fines will be based on library B's rules instead! 5) Apply the patch 6) Repeat steps 3 and 4. 7) Observe now that the fines should reflect the fines rules for Library A Note: it seems counter-intuitive for the fines system to behave this way based on the preference being set to "the library you are logged in at" but it does make sense. The rules used are from "the library you are logged in at" when the item is first checked out. If the fines system really did use the rules for the library the item was returned to, it would be easy to exploit the library system. Some Koha using systems have branches that charge fines, and others that don't, so a patron could just return any overdue items to a non-charging branch to avoid ever paying fines! Furthermore, it would mean that the fines.pl script would be using one set of rules to charge fines, and the returns system could possibly be using another. Since fines.pl has been around far longer, it makes sense to assume the fines.pl behavior is canonical. Signed-off-by: Mickey Coalwell <mcoalwell at nekls.org> Signed-off-by: George Williams <georgew at latahlibrary.org> Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 22:56:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 20:56:29 +0000 Subject: [Koha-bugs] [Bug 10029] CAS authentication fails in OPAC reserve In-Reply-To: <bug-10029-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10029-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10029-70-IkvFV34U5R@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10029 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 22:56:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 20:56:31 +0000 Subject: [Koha-bugs] [Bug 10029] CAS authentication fails in OPAC reserve In-Reply-To: <bug-10029-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10029-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10029-70-3jJidUcuot@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10029 --- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18394&action=edit Bug 10029 - CAS authentication fails in OPAC reserve If OPAC reserve page is accessed without being logged-in, login form is displayed as well as a CAS authentication link (if enabled). A click on this link will lead to CAS server but one comming back to Koha, page shows an error : "ERROR: No biblionumber received". This is because CAS link only contains the query path "/cgi-bin/koha/opac-reserve.pl", not the query parameters. This patch adds query parameters to URI sent to CAS. Test plan : - Enable CAS - Go to opac without been logged-in - Try to place hold on a record => You get to /cgi-bin/koha/opac-reserve.pl?biblionumber=XXX showing authentication page => Check that CAS link contains query param "biblionumber" - Click on CAS link and log in => Check you return well logged-in to reserve page with biblionumber param Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 23:03:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 21:03:31 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10166-70-lW7sa5A7V3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 23:10:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 21:10:03 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10166-70-x5DpcsU6Ei@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18167|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18395&action=edit Bug 10166 [3.10.x] Can't place holds on multiple titles if one or more are un-holdable opac-reserve.pl tries to check whether all selected titles in a multiple-hold batch are unavailable to be placed on hold. However, the logic is flawed in such a way that if the last item in the batch cannot be placed on hold the script assumes none can be placed on hold. This patch modifies the way the script tracks the "no titles available for holds" variable in order to correct the error. To test, place multiple holds by selecting titles from a list of search results. Test three conditions: - All titles are available to be placed on hold You should see no onscreen warnings, and all titles should be selectable on the place hold screen. A "Place hold" button should appear at the bottom. - Some titles can be placed on hold, some cannot The titles which can be placed on hold should be selectable. Titles which cannot be placed on hold should show a warning message. A "Place hold" button should appear at the bottom. - No titles can be placed on hold "Sorry, none of these items can be placed on hold." should appear at the top of the page. All titles should appear with warning messages. There should be no "Place hold" button. Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 23:10:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 21:10:00 +0000 Subject: [Koha-bugs] [Bug 10166] Can't place holds on multiple titles if one or more are un-holdable In-Reply-To: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10166-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10166-70-DDfRwmj04Y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10166 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 23:20:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 21:20:03 +0000 Subject: [Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR In-Reply-To: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8884-70-eXipQhQGjw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 23:20:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 21:20:05 +0000 Subject: [Koha-bugs] [Bug 8884] opacheader is not in the header on CCSR In-Reply-To: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8884-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8884-70-E2SmyvmthL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8884 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18261|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18396&action=edit Bug 8884: opacheader is not in the header on CCSR In CCSR the opacheader preference isn't really in the header it's to the right of the search box (see attached). I'm okay with a customizable region over there, but we should have a new preference for that and header should be above the search box as it implies. To test: 1) Put something in the OpacHeader syspref. Preferably something large and header-like for maximum effect. 2) Select CCSR theme. 3) View OPAC. Notice placement of "header" content. 4) Apply patch. 5) View OPAC. Notice placement of "header" content. 6) Sign off. Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 23:23:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 21:23:36 +0000 Subject: [Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable In-Reply-To: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10334-70-75MnbwVmGm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> --- Yes I concur these tests are not working. Having them there makes people think things are being tested when they aren't, happy to sign off on their removal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 23:28:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 21:28:12 +0000 Subject: [Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable In-Reply-To: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10334-70-zMaApi5d8d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18385|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18397&action=edit MT10334: t/db_dependent/needs_user_input/* are unusable t/db_dependent/needs_user_input/Auth.t and t/db_dependent/needs_user_input/Auth_with_ldap.t seem not really useful. If I refer to the git history, it seems that they are antiquated tests. The first one is not compilable: perl -wc t/db_dependent/needs_user_input/Auth.t Can't locate override_context_prefs.pm Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 23:28:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 21:28:10 +0000 Subject: [Koha-bugs] [Bug 10334] UT: t/db_dependent/needs_user_input/* are unusable In-Reply-To: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10334-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10334-70-Ehkomd7rPa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10334 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 24 23:48:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 21:48:36 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10332-70-J0ixqppsRB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> --- Hi Jonathan I get this DBD::mysql::db do failed: Cannot truncate a table referenced in a foreign key constraint (`koha_persona`.`course_instructors`, CONSTRAINT `course_instructors_ibfk_2` FOREIGN KEY (`course_id`) REFERENCES `koha_persona`.`courses` (`course_id`)) at t/db_dependent/CourseReserves.t line 22. DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_persona`.`items`, CONSTRAINT `items_ibfk_2` FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at C4/Items.pm line 2105. When trying on my machine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 01:14:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 23:14:36 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10290-70-Hd7U6r3gkM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 01:14:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 23:14:38 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10290-70-dbsgIehYvS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18253|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18398&action=edit Bug 10290: UT: VirtualShelves.t needs to create its own data Try before the patch: prove t/db_dependent/VirtualShelves.t And after, it should produce: t/db_dependent/VirtualShelves.t .. ok All tests successful. Files=1, Tests=82, 6 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.03 csys = 0.52 CPU) Result: PASS Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 01:16:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 23:16:26 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10332-70-vD1W5H7PIK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #2) > Hi Jonathan > > I get this > > DBD::mysql::db do failed: Cannot truncate a table referenced in a foreign > key constraint (`koha_persona`.`course_instructors`, CONSTRAINT > `course_instructors_ibfk_2` FOREIGN KEY (`course_id`) REFERENCES > `koha_persona`.`courses` (`course_id`)) at t/db_dependent/CourseReserves.t > line 22. > DBD::mysql::st execute failed: Cannot add or update a child row: a foreign > key constraint fails (`koha_persona`.`items`, CONSTRAINT `items_ibfk_2` > FOREIGN KEY (`homebranch`) REFERENCES `branches` (`branchcode`) ON UPDATE > CASCADE) at C4/Items.pm line 2105. > > > When trying on my machine The second error to do with branches was a data one, fixed that, but I am still getting the can't truncate error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 01:21:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 23:21:26 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: <bug-10333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10333-70-T5ZlVG2Nd0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 01:21:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 24 May 2013 23:21:28 +0000 Subject: [Koha-bugs] [Bug 10333] UT: Labels/t_Batch.t needs to create its own data In-Reply-To: <bug-10333-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10333-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10333-70-tpGrRgzAbN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10333 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18384|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18399&action=edit Bug 10333: Labels/t_Batch.t needs to create its own data prove t/db_dependent/Labels/t_Batch.t [14:53:09] t/db_dependent/Labels/t_Batch.t .. 1/32 # Testing Batch->new() method. t/db_dependent/Labels/t_Batch.t .. 13/32 # Testing Batch->retrieve() method. t/db_dependent/Labels/t_Batch.t .. ok All tests successful. Files=1, Tests=32, 3 wallclock secs ( 0.02 usr 0.00 sys + 0.48 cusr 0.03 csys = 0.53 CPU) Result: PASS Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 02:00:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 00:00:38 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7368-70-AUIQZt7kwm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #82 from Connor <connor.fraser13 at yahoo.com> --- Created attachment 18400 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18400&action=edit 3 typos in history.txt fixed 3 more typos fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 02:02:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 00:02:36 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7368-70-rtWCGRJQQg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 02:04:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 00:04:21 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7368-70-vgTmyYngeM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18400|0 |1 is obsolete| | --- Comment #83 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18401&action=edit Bug 7368: Correct three typos in history.txt Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 02:04:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 00:04:36 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7368-70-4eKiM0RFlM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 02:04:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 00:04:45 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7368-70-ZUsCRLRg7A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 02:04:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 00:04:55 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7368-70-cjnNdkTWV9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 05:56:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 03:56:02 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10218-70-Bfgl54K1Jn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 05:56:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 03:56:04 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10218-70-r2SNQiwtEb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18295|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18402&action=edit Bug 10218 - In OPAC XSLT search results, add class to 'online access' In some cases in OPAC search results and the detail page there is a class specific to each line of data being output (publisher, date, subjects, etc). In other cases there is no additional class. This patch makes modifications to a few different OPAC files in an attempt to make them consistent with each other. To test, apply the patch and view: - an OPAC detail page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay on Labels should have classes relevant to their data. To test the specific case requested by this bug, view details/results for a record which includes online resources (856u in MARC21). Signed-off-by: Galen Charlton <gmc at esilibrary.com> html changes only, passes all tests Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 05:58:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 03:58:45 +0000 Subject: [Koha-bugs] [Bug 10284] Missing spaces between label and content in XSLT view for 785/780 In-Reply-To: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10284-70-a7GAExgj9T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 05:58:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 03:58:47 +0000 Subject: [Koha-bugs] [Bug 10284] Missing spaces between label and content in XSLT view for 785/780 In-Reply-To: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10284-70-miqhtkrLS9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18294|0 |1 is obsolete| | --- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18403&action=edit Bug 10284: Add missing spaces between label and content in XSLT view (780/785) To test: - Check OPAC and intranet XSLT view for a record that contains 780 and 785 fields. - Verify there is no space between the label and the content of the field. - Apply patch. - Verify the display both in intranet and OPAC is a little nicer now. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 15:14:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 13:14:42 +0000 Subject: [Koha-bugs] [Bug 10339] New: make the content of some help files templates marflavor dependent Message-ID: <bug-10339-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10339 Bug ID: 10339 Summary: make the content of some help files templates marflavor dependent Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: mathieu.saby at univ-rennes2.fr Some help files contain strings that only apply to MARC21 (in advanced search for example). We should change the display of those strings or remove them strings if marcflavor is not MARC21. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 15:21:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 13:21:10 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10327-70-3qFsK2WyE8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #3 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I don't know if you agree, but here are some sysprefs that I always found poorly named : - dontmerge (Don't merge what? when?) - insecure (What is insecure? when?) - authoritysep (=> AuthoritySeparator ?) - delimiter (=> CSVDelimiter ?) - reviewson (=>OPACAllowComments ?) - suggestion (=>OPACAllowSuggestions ?) - AnonSuggestions (=>OPACAllowAnonymousSuggestions ?) - language (=> StaffLanguage ?) - useDaysMode (don't know how to rename it, b Maybe because I don't speak english fluently, I don't understand the group of sysprefs "Local use". What is the meaning of this phrase? I don't understant the group of sysprefs "Creators" either. What does it mean for you? We could also improve the description (or the name?) of some MARC21 specific features, as MARCOrgCode : it only applies to MARC21, and not to UNIMARC, but it is said nowhere. And we should remove the following sysprefs : -NoZebraIndexes - hidelostitems (an other pref can make the same job. I forget its name...) M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 15:35:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 13:35:11 +0000 Subject: [Koha-bugs] [Bug 9547] Give the ability to sort baskets by closing date and status In-Reply-To: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9547-70-aGNxFuXIDy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9547 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 15:35:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 13:35:27 +0000 Subject: [Koha-bugs] [Bug 9547] Give the ability to sort baskets by closing date and status In-Reply-To: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9547-70-cUfMe1UBtI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9547 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mathieu.saby at univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 15:44:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 13:44:16 +0000 Subject: [Koha-bugs] [Bug 10340] New: deleted orders should not be taken into account for Item count calculation in booksellers.pl Message-ID: <bug-10340-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10340 Bug ID: 10340 Summary: deleted orders should not be taken into account for Item count calculation in booksellers.pl Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mathieu.saby at univ-rennes2.fr in booksellers.pl, the "Item count" column contains all items, even if the order was deleted. I think it is a wrong behavior. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 15:44:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 13:44:27 +0000 Subject: [Koha-bugs] [Bug 10340] deleted orders should not be taken into account for Item count calculation in booksellers.pl In-Reply-To: <bug-10340-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10340-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10340-70-IhFxS5VOMW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10340 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 15:50:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 13:50:57 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-Ri9W5qGbCd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #64 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- The status was not changed. Could be marked as "Signed off" I suppose? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 16:32:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 14:32:56 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-7hFOKVosql@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #65 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think probably the reworded patch waits for sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 16:58:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 14:58:12 +0000 Subject: [Koha-bugs] [Bug 10341] New: Erro installing new language with Koha Message-ID: <bug-10341-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10341 Bug ID: 10341 Summary: Erro installing new language with Koha Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: Linux Status: NEW Severity: critical Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: costalc at gmail.com CC: frederic at tamil.fr Erro while trying to install es-ES language. Steps followed by me: 1) cd /usr/share/koha/misc/translator 2) perl translate install es-ES Message echoed: /usr/share/koha/opac/htdocs/opac-tmpl/prog/es-ES: The directory does not exist /usr/share/koha/intranet/htdocs/intranet-tmpl/prog/es-ES: The directory does not exist /usr/share/koha/opac/htdocs/opac-tmpl/ccsr/es-ES: The directory does not exist Koha directories hierarchy for es-ES must be created first Regards, Claudio -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 17:25:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 15:25:27 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-VliQsKtLKU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #66 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- ok, i'll test it. but there is only 2 followups. Where is the main patch? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 17:27:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 15:27:52 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-DstPPBRFk9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #40 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Sorry, patch does not apply : CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt CONFLICT (content): Merge conflict in C4/Acquisition.pm M. Saby -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 18:02:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 16:02:05 +0000 Subject: [Koha-bugs] [Bug 9547] Give the ability to sort baskets by closing date and status In-Reply-To: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9547-70-Yy1ueQOFIt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9547 --- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Created attachment 18404 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18404&action=edit Subject: [PATCH] Bug 9547 : Make baskets sortable by closing date in booksellers.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 18:02:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 16:02:25 +0000 Subject: [Koha-bugs] [Bug 9547] Give the ability to sort baskets by closing date and status In-Reply-To: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9547-70-4KxG6dSfIq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9547 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- In baskets list table displayed for each bookseller in booksellers.tt, this patch - adds a new column "Action" - reword "Date" column into "Open on" - give a name to the the "Closed on" column and make it sortable - remove the useless "closed on" in each cell of "Closed on" column To test : 1. Create some baskets for a vendor, some open, other closed, with different closing dates 2. See if you can sort these baskets by date in bokksellers.pl page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat May 25 18:51:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 16:51:09 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9593-70-iKiJLGx7FN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #31 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Hello. I tested your 2d patch. It needs to be rebased (conflict in updatedatabse, and need to remplace 3.11.XXX by 3.13.XXX) The result is the same, except for Chateaubriand et la gravit? du comique by Fabio Vasarri => 300.00 This is not good, but as I put before, this kind of data is not supposed to be found... <subfield code="d">38 Ksh, ?300, $62</subfield> I will edit your sample batch of record, so it would be easier to test. Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 01:36:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 23:36:15 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9593-70-F34hGh5bcM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #32 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Olivier, With your 2d patch, I made 4 tests, with a batch of 19 records (I join them) tva: 0 discount : 5% test A : Euro as active currency, all currency rates = 1 ; selecting "Euro" currency in addorderiso2709.pl (in Accounting details) test B : Euro as active currency ; rates : 1 ? = 10 $ = 4 ? ; selecting "Euro" currency in addorderiso2709.pl (in Accounting details) test C : GB Pound as active currency ; rates : 1 ? = 10 $ = 5 ? ; selecting "Pound" currency in addorderiso2709.pl (in Accounting details) test D : GB Pound as active currency ; rates : 1 ? = 10 $ = 5 ? ; selecting "Euro" currency in addorderiso2709.pl (in Accounting details) A, B, C are OK D seems not OK, but I am not sure to understand how the currency you can choose when importing the record is supposed to interact with the currency stored of the record. What Koha is supposed to do if there is a price with ? symbol in the record, but if we select "euro" while importing? Maybe the currency choosen when importing is made to be used if the prices have no currency symbol in the record?? I did not test this point without your patch. Perhaps it is broken... If it is the case, I would agree to sign it off, as as the problem it fixes has been noticed in january. And we can fix it in an other patch. Could you give me your analysis? If you are as lost as myself, you can ask the koha-devel list ;-) Titre01 75.40 EUR, 93.5 USD, 20 250 GBP test A and test B : OK - should be : 75.40 - result : 75.40 test C : OK - should be : RRP = 20250.00 ; Total tax inc = 19237.50 - result : RRP : 20250.00 ; Total tax inc. (POUND) : 19237.50 test D : KO - should be : don't know - result : RRP : 4050.00 ; Total tax inc. (POUND) : 19237.50 => it means Koha knows ? is the active currency, takes the 20250 pounds price, BUT after that, the system considers it is 20250 euros, so it divides it by 5 (according to currency rate), to establish a RRP price of 4050? AND rather strangely, the Total tax inc. price is calculated according to the raw value in the record (20250) and not to the wrongly calculated price of 4050?. Titre02 75.40 EUR, 93.5 USD, 20,250 GBP test A and test B : OK - should be : 75.40 - result : 75.40 test C : OK - should be : RRP = 20250.00 ; Total tax inc = 19237.50 - result : RRP : 20250.00 ; Total tax inc. (POUND) : 19237.50 test D : KO - should be : don't know - result : RRP : 4050.00 ; Total tax inc. (POUND) : 19237.50 Titre03 75.40 EUR, 93.5 USD, 20,250.10 GBP test A and test B : OK - should be : 75.40 - result : 75.40 test C : OK - should be : RRP = 20250.10 ; Total tax inc = 19237.60 - result : RRP : 20250.10 ; Total tax inc. (POUND) : 19237.60 test D : KO - should be : don't know - result : RRP : 4050.02 ; Total tax inc. (POUND) : 19237.60 Titre04 ?75.40, $93.5, ?20,250.10 test A and test B : OK - should be : 75.40 - result : 75.40 test C : OK - should be : RRP = 20250.10 ; Total tax inc = 19237.60 - result : RRP : 20250.10 ; Total tax inc. (POUND) : 19237.60 test D : KO - should be : don't know - result : RRP : 4050.02 ; Total tax inc. (POUND) : 19237.60 Titre10 32,10 EUR, 45,12 USD test A and test B : OK - should be : 32.10 - result : 32.10 test C : OK - should be : RRP = 6.42 (= 32.10/5) ; Total tax inc = 6.10 - result : = 6.42 (= 32.10/5) ; Total tax inc = 6.10 test D : KO - should be : don't know - result : RRP : 1.28 ; Total tax inc. (POUND) : 6.10 => not good : Koha took the first price (32.10), and considered it is euro. I don't know how, but for RRP price, it divided it by 5, and then again by 5 (32.10/5/5 = 1.28). For Total tax inc, it only took 32.10 /5 (minus the discount), that is correct. Titre11 32,10 ?, 45,12 $ test A and test B : OK - should be : 32.10 - result : 32.10 test C : OK - should be : RRP = 6.42 (= 32.10/5) ; Total tax inc = 6.10 - result : = 6.42 (= 32.10/5) ; Total tax inc = 6.10 test D : KO - should be : don't know - result : RRP : 1.28 ; Total tax inc. (POUND) : 6.10 Titre12 32.10, USD 45.12 test A and test B : OK - should be : 32.10 - result : 32.10 test C : OK - should be : RRP = 6.42 (= 32.10/5) ; Total tax inc = 6.10 - result : = 6.42 (= 32.10/5) ; Total tax inc = 6.10 test D : KO - should be : don't know - result : RRP : 1.28 ; Total tax inc. (POUND) : 6.10 Titre13 ?32.10, $45.12 test A and test B : OK - should be : 32.10 - result : 32.10 test C : OK - should be : RRP = 6.42 (= 32.10/5) ; Total tax inc = 6.10 - result : = 6.42 (= 32.10/5) ; Total tax inc = 6.10 test D : KO - should be : don't know - result : RRP : 1.28 ; Total tax inc. (POUND) : 6.10 Titre20 300 ?, 62.20 $ test A : OK - should be : 62.20 - result : 62.20 test B : OK - should be : 6.22 - result : 6.22 test C : OK - should be : RRP = 6.22 (= 62.20/10) ; Total tax inc = 5.91 - result : RRP = 6.22 ; Total tax inc = 5.91 test D : KO - should be : don't know - result : RRP : 1.24 ; Total tax inc. (POUND) : 5.91 => same as before : RRP = raw price / 25 ; total tax inc. = raw price / 5 minus discount Titre22 ?300, $62.20 test A : - should be : 62.20 - result : 62.20 test B : - should be : 6.22 (as 10 $ = 1 ?) - result : 6.22 test C : OK - should be : RRP = 6.22 (= 62.20/10) ; Total tax inc = 5.91 - result : RRP = 6.22 ; Total tax inc = 5.91 test D : KO - should be : don't know - result : RRP : 1.24 ; Total tax inc. (POUND) : 5.91 Titre23 300 YEN, 62.20 USD test A : - should be : 62.20 - result : 62.20 => OK test B : OK - should be : 6.22 - result : 6.22 test C : OK - should be : RRP = 6.22 (= 62.20/10) ; Total tax inc = 5.91 - result : RRP = 6.22 ; Total tax inc = 5.91 test D : KO - should be : don't know - result : RRP : 1.24 ; Total tax inc. (POUND) : 5.91 Titre24 YEN 300, USD 62.20 test A : - should be : 62.20 - result : 62.20 test B : OK - should be : 6.22 - result : 6.22 test D : OK - should be : RRP = 6.22 (= 62.20/10) ; Total tax inc = 5.91 - result : RRP = 6.22 ; Total tax inc = 5.91 test D : KO - should be : don't know - result : RRP : 1.24 ; Total tax inc. (POUND) : 5.91 Titre30 75 EUR test A and B : OK - should be : 75.00 - result : 75.00 test C : OK - should be : RRP = 15? (=75?/5) ; Total tax inc. : 14.25? - result : RRP : 15 ; Total tax inc. (POUND) : 14.25 test D : - should be : don't know - result : RRP : 3 ; Total tax inc. (POUND) : 14.25 => same as before : RRP = raw price / 25 ; total tax inc. = raw price / 5 minus discount Titre31 ?75 test A and B : OK - should be : 75.00 - result : 75.00 test C : OK - should be : RRP = 15? (=75?/5) ; Total tax inc. : 14.25? - result : RRP : 15 ; Total tax inc. (POUND) : 14.25 test D : - should be : don't know - result : RRP : 3 ; Total tax inc. (POUND) : 14.25 Titre32 EUR 75 test A and B : OK - should be : 75.00 - result : 75.00 test C : OK - should be : RRP = 15? (=75?/5) ; Total tax inc. : 14.25? - result : RRP : 15 ; Total tax inc. (POUND) : 14.25 test D : KO - should be : don't know - result : RRP : 3 ; Total tax inc. (POUND) : 14.25 Titre33 75 ? test A and B : OK - should be : 75.00 - result : 75.00 => OK test C : OK - should be : RRP = 15? (=75?/5) ; Total tax inc. : 14.25? - result : RRP : 15 ; Total tax inc. (POUND) : 14.25 test D : KO - should be : don't know - result : RRP : 3 ; Total tax inc. (POUND) : 14.25 Titre34 ?300 all tests : OK - should be : 0 - result : 0 => OK Titre35 300 YEN all tests : OK - should be : 0 - result : 0 => OK Titre36 300 ? all tests : OK - should be : 0 - result : 0 => OK Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 01:37:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 25 May 2013 23:37:16 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9593-70-YHw7XjRwYw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #33 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Created attachment 18405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18405&action=edit 19records-testSaby-20130425 the records I used for testing -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 08:22:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 06:22:17 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-tdJfiaVNKB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #67 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #66) > ok, i'll test it. > but there is only 2 followups. Where is the main patch? > > Mathieu It was pushed to master and 3.12 way back on comment 49, at that point a new bug should have been created for any followups, because as you demonstrate, it is just confusing otherwise. Remember people, once something is marked pushed to master, please to go back to needs signoff, (unless it is the patch rebased for a stable branch or something). Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 12:11:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 10:11:18 +0000 Subject: [Koha-bugs] [Bug 9547] Give the ability to sort baskets by closing date and status In-Reply-To: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9547-70-mDcamqsgNS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9547 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 12:23:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 10:23:10 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9593-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9593-70-FW2OTTtVLO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #34 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I made again test D, but WITHOUT your patch. GB Pound as active currency ; rates : 1 ? = 10 $ = 5 ? ; selecting "Euro" currency in addorderiso2709.pl (in Accounting details) I call it test E Titre01, Titre02, Titre03, Titre30, Titre31, Titre32, Titre33 are broken, but that's logical. Titre04 has the same values as test D ?75.40, $93.5, ?20,250.10 test D & E - result : RRP : 4050.02 ; Total tax inc. (POUND) : 19237.60 Titre10, Titre11, Titre12, Titre13 as values different from test D 32,10 EUR, 45,12 USD Test D - result : RRP : 1.28 ; Total tax inc. (POUND) : 6.10 Test E - result : RRP : 6.42 ; Total tax inc. (POUND) : 30.50 Titre20, Titre21, Titre22, Titre24 as values different from test D Test D - result : RRP : 1.24 ; Total tax inc. (POUND) : 5.91 Test E - result : RRP : 12.44 ; Total tax inc. (POUND) : 59.09 So your patch seems to change Koha behavior on that point. Could you check it why? Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 13:02:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 11:02:40 +0000 Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form In-Reply-To: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10335-70-JQlb3Pfkj7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Hello Janusz Good idea, but I would like to make some comments before testing : The $8 contains the code for a language, not for a kind of script. Scripts codes are stored in $7, on 2 characters (interesting info = position 4-5) ba latin ca cyrillic fa arabe ga grec ha h?breu etc. The $8 subfield (not mandatory) can be used in 7XX, but also in 2XX or 4XX. So, you can have a field coded in case of romanized record, you can have 2 repeated fields, with the same $8, but different $7. That's the way we work in France. I hope it is not wrong... Ex from unimarc manual : 200 #1 $7ba0yba0a $8engrus $aGlinka,$bMihail Ivanovi? 200 #1 $7ba0yca0y $8engrus $a??????,$b?????? ???????? The $7 is mandatory in case of double script records, but the $8 is not mandatory. The possible codes in $7 are limited (a dozen), but ALL 639-2 iso codes can be used in $8. So I wonder if managing them in the templates is a good solution. So, could you tell me if your patch deals only with 7XX fields ? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 13:13:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 11:13:15 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10218-70-dVz0qtUt4o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I did not look, but I suppose a followup can be made for UNIMARC (in an other patch?) M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 13:22:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 11:22:42 +0000 Subject: [Koha-bugs] [Bug 7490] Add CSS classes/ids to OPAC and staff NORMARC XSLT views In-Reply-To: <bug-7490-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7490-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7490-70-82eSBoEolJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7490 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- This must be made for UNIMARC too! M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 13:26:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 11:26:43 +0000 Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form In-Reply-To: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10335-70-qY0AWatSCU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 --- Comment #3 from Janusz Kaczmarek <januszop at gmail.com> --- Mathieu, I perfectly agree with what you wrote. Of course while cataloguing one should fill up $7 as well to have correct data produced--but it seems that Koha does not make any use of $7 for now. BTW, according to the cited "UNIMARC manual : authorities format" (p. 66): "$8 -- Occurrence Mandatory in each 7-- heading when parallel headings or parallel data. Optional in 2--, 4--, 5--. Not repeatable." My patch is not an enhancement (and does not deal with $7 script-story, nor with 4XX and 5XX, nor with shifting languages expansion away from the templates, which would be a good idea). Its aim was only to fix what seemed to be wrong in the existing code. So it deals only with what and how Koha extracts from 7XX ($8, $a, $b) for the display in auth. search results. Hope this explains my motivations and the scope of the patch. Janusz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 13:46:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 11:46:44 +0000 Subject: [Koha-bugs] [Bug 10342] New: Better display of UNIMARC thesis note in xslt is needed Message-ID: <bug-10342-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10342 Bug ID: 10342 Summary: Better display of UNIMARC thesis note in xslt is needed Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr XSLT file in UNIMARC display the 328$a (thesis note). But in Sudoc network, we fill the 328 field using other subfields (http://documentation.abes.fr/sudoc/formats/unmb/zones/328.htm) So the display of 328 field must be improved. Additionnaly, the thesis national number in 029 could be managed, but maybe it is a french only field... M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 14:05:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 12:05:43 +0000 Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form In-Reply-To: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10335-70-qq1r5e4f1S@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 --- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- You are right for the $8, I did not know it was mandatory for 7XX. In french universities network, we consider it as non mandatory. http://documentation.abes.fr/sudoc/formats/unma/DonneesCodees/CodesDollar8.htm#TOP "La sous-zone $8 est facultative." But maybe our cataloguing tool fill it automaticly if we don't do it. For $7 codes, in my library I created an authorised values category with scripts codes, and link them to $7 fields in bibliographic framework. So when you catalog a record, you can pick the cataloguing script in a dropdown list. But we don't display it in OPAC or Staff interface. Not sure it is very important. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 16:19:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 14:19:07 +0000 Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form In-Reply-To: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10335-70-onh8cMjMZ1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 --- Comment #5 from Janusz Kaczmarek <januszop at gmail.com> --- I see. Than, apparently, the SUDOC instruction authors made a simplification. The French version of the official recommendation reads: "$8 - Occurrence Obligatoire pour chaque zone 7XX dans le cas de vedettes parall?les ou de donn?es parall?les. Facultatif dans les zones 2XX, 4XX, 5XX. Non r?p?table." (http://www.bnf.fr/documents/UnimarcA.pdf, p. 74) So as far as I am able to understand French, it is the same ;) As to filling up with authorized values--good choice! I have $7 and $8 configured this way. As I wrote, it ($7, $8) may seem not to be very important because Koha makes (almost) no use of it, but if one would like to reuse the data some day (if Koha dies some day, what is not our wish, but just in case), data should conform to the standard :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 16:26:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 14:26:06 +0000 Subject: [Koha-bugs] [Bug 10335] UNIMARC authorities search doesn't display properly information on parallel form In-Reply-To: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10335-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10335-70-da3kTRSbzb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10335 --- Comment #6 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- (En r?ponse au commentaire 5) > I see. Than, apparently, the SUDOC instruction authors made a > simplification. The French version of the official recommendation reads: > > "$8 - Occurrence > Obligatoire pour chaque zone 7XX dans le cas de vedettes parall?les ou de > donn?es parall?les. Facultatif dans les zones 2XX, 4XX, 5XX. > Non r?p?table." (http://www.bnf.fr/documents/UnimarcA.pdf, p. 74) > > So as far as I am able to understand French, it is the same ;) You understand well. > > As to filling up with authorized values--good choice! I have $7 and $8 > configured this way. > > As I wrote, it ($7, $8) may seem not to be very important because Koha makes > (almost) no use of it, but if one would like to reuse the data some day (if > Koha dies some day, what is not our wish, but just in case), data should > conform to the standard :) If the question is "how to fill properly $7 and $8", that's not difficult : the answer could be : map these subfields with some authorized values in default framework, or maybe create some plugins if necessary. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun May 26 23:54:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 21:54:44 +0000 Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to pay fines screen if borrower has outstanding fines In-Reply-To: <bug-8058-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8058-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8058-70-8R3iyNrNnK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058 Chris Hall <chrish at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 00:06:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 22:06:51 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10240-70-eTFqg5Rgge@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18406&action=edit Work-in-progress patch for: Bug 10240: Offline circulation using HTML5 and IndexedDB This patch adds an HTML5-based offline mode to Koha's existing circulation module, allowing librarians to check out items using a basically familiar interface. The feature will be implemented using the Application Cache and IndexedDB features of the HTML5 specification, both of which are fully supported on Firefox 10+ and Chrome 23+, with limited support going back to Firefox 4 and Chrome 11. The basic workflow enabled by this patch is as follows: Part 1: While connected to the Internet 1. Enable offline functionality by turning on the "AllowOfflineCirculation" system preference. 2. Sync the offline circulation database on the computer that will be used for offline circulation by following the "Offline circulation interface" link on the Circulation home page, choosing "Synchronize (must be online)", and clicking the "Download records" button. This process may take a while. 3. Bookmark /cgi-bin/koha/circ/offline.pl (the page you are currently on) for easy access when offline. Part 2: While disconnected from the Internet 4. Navigate to /cgi-bin/koha/circ/offline.pl using the bookmark you created while online. 5. Start checking books in by scanning the barcode of an item that has been returned into the box in the "Check in" tab. 6. Scan the barcodes of any additional items that have been returned. 7. Start checking out books to a patron by scanning the patron's barcode in the box in the "Check out" tab. 8. Set a due date (the "Remember for session" box will be checked by default, since circulation rules are not computed during offline transactions and therefore a due date must be specified by the librarian). 9. Scan an item barcode (if you did not set a due date, it will prompt you) to check the item out to the patron. 10. If a patron has a fine you can see the total amount (current to when the offline module was synced), and record a payment. Unlike when in online mode, there will be no breakdown of what item(s) fines are for, and you will only be able to record the payment amount and not associate it with a particular item. Part 3: While connected to the Internet 11. Click the "Synchronize" link and choose "Upload transactions" to upload the transactions recorded during the offline circulation session. 12. Navigate to /cgi-bin/koha/offline_circ/list.pl (there will be a link from the Offline circulation page) and review the transactions, as described in the documentation for the Firefox Offline circulation plugin: http://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 00:06:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 22:06:50 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10240-70-Lk2uRqVvS7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 00:07:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 26 May 2013 22:07:17 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10240-70-75yJ20nEz9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 05:46:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 03:46:47 +0000 Subject: [Koha-bugs] [Bug 10293] Bug 9930 needs to be reverted for 3.10.x In-Reply-To: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10293-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10293-70-i5ETULsw8o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10293 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Pushed to 3.10.x will be in 3.10.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 08:32:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 06:32:09 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-zyghIyse35@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18332|Bug-9824-Followup-for-POD-l |[SIGNED_OFF] filename|ines-of-GetBasketsInfos.pat |Bug-9824-Followup-for-POD-l |ch |ines-of-GetBasketsInfos.pat | |ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 08:32:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 06:32:42 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-UxEy6hGVTv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18332|[SIGNED_OFF] |Bug-9824-Followup-for-POD-l filename|Bug-9824-Followup-for-POD-l |ines-of-GetBasketsInfos.pat |ines-of-GetBasketsInfos.pat |ch |ch | Attachment #18332|Bug 9824: Followup for POD |[SIGNED_OFF] Bug 9824: description|lines of |Followup for POD lines of |GetBasketsInfosByBookseller |GetBasketsInfosByBookseller -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 08:33:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 06:33:07 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-xpffIQcZTH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18348|Bug 9824: Followup adding |[NEEDS_SIGNOFF] Bug 9824: description|some text around |Followup adding some text |Apply/cancel filter. |around Apply/cancel filter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 08:34:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 06:34:13 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-oizW0nY7sH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #68 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #66) > but there is only 2 followups. Where is the main patch? The second followup only needs a signoff, preferably from a native English speaker. (Note that I already followed the suggestion of Owen here.) Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 08:35:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 06:35:15 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-iIB6eOvebK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #69 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #67) > Remember people, once something is marked pushed to master, please to go > back to needs signoff, (unless it is the patch rebased for a stable branch > or something). Not completely clear what you mean here, Chris. But these followups imo do not need a separate report.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 08:42:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 06:42:48 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-n6bbvutV3K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #70 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hm, I was tempted to suggest a separate bug too when I took a look at this. It seems like a good practice to me to use a new bug once the original feature has been pushed. And in this case the original feature has even been released :) - I am also thinking about the automatically created release notes here. Maybe something like "Reword basket filter in vendor search result list" would be more clear? For testers and QA it's also harder to deal with a loooong discussion like this :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 09:26:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 07:26:48 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7368-70-vwIPJkdH2q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 09:26:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 07:26:51 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7368-70-XFAcz9iM5z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18401|0 |1 is obsolete| | --- Comment #84 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18407&action=edit Bug 7368: Correct three typos in history.txt Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 09:30:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 07:30:43 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-6cHWA1LaSB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #71 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- (En r?ponse au commentaire 70) > Hm, I was tempted to suggest a separate bug too when I took a look at this. > It seems like a good practice to me to use a new bug once the original > feature has been pushed. And in this case the original feature has even been > released :) - I am also thinking about the automatically created release > notes here. Maybe something like "Reword basket filter in vendor search > result list" would be more clear? > > For testers and QA it's also harder to deal with a loooong discussion like > this :) I don't know if it is already an enforced "rule", but 1 or 2 times I tried to add followup to bugs pushed to master, and I was said to create new bugs (for ex., a followup for UNIMARC of a MARC21 enh). After having thougth at this, I believe it was a good advice ;-) M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 09:43:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 07:43:43 +0000 Subject: [Koha-bugs] [Bug 9424] Move JavaScript out of header include In-Reply-To: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9424-70-Gc8mK1K5MN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: The 3 links do the same job as before, no regression found. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 09:43:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 07:43:56 +0000 Subject: [Koha-bugs] [Bug 9424] Move JavaScript out of header include In-Reply-To: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9424-70-tngNSoCi1B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18391|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18408&action=edit Bug 9424: Move JavaScript out of header include This patch removes JavaScript "onlick" attributes from header.inc and moves the functionality to staff-global.js. This is in keeping with the idea of progressive enhancement. To test, be sure to clear your browser cache after applying the patch. - Test the help link. - Test the logout link with the intranetbookbag preference on and off. - Open a patron's account and click "search to hold." Log out, and log in again. Koha should not remember the patron you chose before logging out (as seen from a search results page). Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 09:57:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 07:57:40 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-NbksKm1FlQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #72 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Sorry, will try to remember your suggestion next time :) Katrin: As you suggested, I asked Owen on irc and adjusted the text. Would you mind passing these two patches on this report now or still require a new one? Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:00:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:00:14 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-YTeLwRk9Of@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18356|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:05:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:05:26 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7720-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7720-70-ZM07hDdvbC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #51 from Chris Cormack <chris at bigballofwax.co.nz> --- # both modified: installer/data/mysql/sysprefs.sql # both modified: installer/data/mysql/updatedatabase.pl # both modified: koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Patch doesn't apply cleanly, I could fix the first 2 files, but unsure on the 3rd one, Kyle can you rebase and set back to signed off please -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:09:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:09:54 +0000 Subject: [Koha-bugs] [Bug 9286] Add script to add a bib to the zebra queue from the command line In-Reply-To: <bug-9286-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9286-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9286-70-zwyHA7ndRY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9286 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #13 from Chris Cormack <chris at bigballofwax.co.nz> --- misc/mod_zebraqueue.pl -a 1 select * from zebraqueue where done=0; +----+--------------------+---------------+-----------------+------+---------------------+ | id | biblio_auth_number | operation | server | done | time | +----+--------------------+---------------+-----------------+------+---------------------+ | 1 | 1 | specialUpdate | authorityserver | 0 | 2013-05-27 20:07:39 | +----+--------------------+---------------+-----------------+------+---------------------+ misc/mod_zebraqueue.pl -b 1 | 2 | 1 | specialUpdate | biblioserver | 0 | 2013-05-27 20:08:47 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:12:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:12:38 +0000 Subject: [Koha-bugs] [Bug 9286] Add script to add a bib to the zebra queue from the command line In-Reply-To: <bug-9286-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9286-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9286-70-GjFZK15EPk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9286 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:12:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:12:41 +0000 Subject: [Koha-bugs] [Bug 9286] Add script to add a bib to the zebra queue from the command line In-Reply-To: <bug-9286-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9286-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9286-70-cTlHJYmXsr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9286 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15504|0 |1 is obsolete| | --- Comment #14 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18409&action=edit Bug 9286 - Add script to add a bib to the zebra queue from the command line Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Comment: No test plan, but works. Tested adding auth, biblios or both, then rebuilding -z No errors. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Test Plan 1/ run misc/mod_zebraqueue.pl -a 1 2/ In your koha db SELECT * FROM zebraqueue WHERE done = 0; Check that a row for authority record id 1 has been inserted 3/ run misc/mod_zebraqueue.pl -b 1 4/ In your koha db SELECT * FROM zebraqueue WHERE done = 0; Check that a row for biblio record id 1 has been inserted 5/ run misc/mod_zebraqueue.pl Make sure the help is sensible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:19:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:19:48 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10184-70-rfElMwaXyV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:20:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:20:14 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10184-70-gJshuFN1KQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18383|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18410 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18410&action=edit Bug 10184 - Circulation History reverses sort order Issue data is passed to the readingrec template ordered most recent due date first. Datatables unless specified otherwise do a presort on the data they will display the default results in an order the reverse of what was intended. Disabling the presort preserves the initial sort order until the user selects a different sort Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:20:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:20:11 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10184-70-NQ01NxeJ4E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:20:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:20:53 +0000 Subject: [Koha-bugs] [Bug 10343] New: Rename OpacShowHoldNotes to OpacHoldNotes Message-ID: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 Bug ID: 10343 Summary: Rename OpacShowHoldNotes to OpacHoldNotes Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Hold requests Assignee: m.de.rooy at rijksmuseum.nl Reporter: m.de.rooy at rijksmuseum.nl CC: gmcharlt at gmail.com As a QA followup on report 9722. Jonathan suggested to move the pref. I suggested to rename. Then Jonathan suggested: OpacHoldNotes is probably more expressive. In the meantime I also discovered that this pref name came in two flavours: starting with OPAC and with Opac. Unfortunately, there are a lot of prefs starting with OPAC, Opac or opac. Since we are not consistent, I pick Opac for readability :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:27:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:27:23 +0000 Subject: [Koha-bugs] [Bug 10321] Followup on hold notes In-Reply-To: <bug-10321-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10321-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10321-70-27ngKnDM0t@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10321 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10343 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:27:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:27:23 +0000 Subject: [Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes In-Reply-To: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10343-70-m1PLyQjSFa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10321 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:28:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:28:20 +0000 Subject: [Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes In-Reply-To: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10343-70-dFepPIgDP0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 --- Comment #1 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Building this on top of bug 10321. Please apply/test that one first :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:39:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:39:58 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-9rbeqEaDs3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17648|0 |1 is obsolete| | Attachment #17649|0 |1 is obsolete| | Attachment #17883|0 |1 is obsolete| | Attachment #18187|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18411 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18411&action=edit Bug 5336:Order search (search and UI enhancements) You can now search orders by - order status - fund New field aqorders.orderstatus, it can contains following values: 0 => New 1 => Ordered 2 => Partial 3 => Complete 4 => Deleted To test: Search and check if results are consistent in histsearch.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:40:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:40:03 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-mLAeIAJdYk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #42 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18412 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18412&action=edit Bug 5336: Late orders search: don't display deleted order. Test plan: Check that deleted orders are not listed in the late orders search results. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:40:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:40:07 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-QUDO7mJfOi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #43 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18413 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18413&action=edit Bug 5336: Merge parent ordernumber and ordernumber columns -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:40:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:40:11 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-vmEejUBiol@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #44 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18414&action=edit Bug 5336: Add unit tests for 3 acq routines Unit tests In C4::Acquisition for: - CloseBasket - ReopenBasket - GetBiblioCountByBasketno -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:40:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:40:12 +0000 Subject: [Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes In-Reply-To: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10343-70-uWn4fRZ0U6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:40:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:40:14 +0000 Subject: [Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes In-Reply-To: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10343-70-Z7WxBiRyoR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 --- Comment #2 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18415 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18415&action=edit Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes As QA followup on report 9722. Built on top of another followup report 10321. Test plan: Run the db revision included in this patch. Enable OpacHoldNotes. Check that you can add a hold note on opac-reserve. Do you see it on opac-user and in staff on catalog detail of that biblio? Do a grep on ShowHoldNotes on the Koha code: grep -i ignores case. You should find three occurrences only in updatedatabase.pl (the old dbrev and this dbrev renaming them). These are fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 10:40:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 08:40:29 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-hKwvhyulhf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 11:07:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 09:07:09 +0000 Subject: [Koha-bugs] [Bug 10332] UT: CourseReserves.t needs to create its own data In-Reply-To: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10332-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10332-70-69MtP53jNm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10332 --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #2) > Hi Jonathan > > I get this > > DBD::mysql::db do failed: Cannot truncate a table referenced in a foreign > key constraint (`koha_persona`.`course_instructors`, CONSTRAINT > `course_instructors_ibfk_2` FOREIGN KEY (`course_id`) REFERENCES > `koha_persona`.`courses` (`course_id`)) at t/db_dependent/CourseReserves.t > line 22. I cannot reproduce :-/ The error is weird, the script truncate the course_instructors table before the courses table. So normally no course_instructors.course_id should refers to a courses.course_id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 11:11:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 09:11:33 +0000 Subject: [Koha-bugs] [Bug 10344] New: add RDA support to Koha Message-ID: <bug-10344-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Bug ID: 10344 Summary: add RDA support to Koha Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com CC: m.de.rooy at rijksmuseum.nl this bug attempts to track RDA support in Koha. below are some useful links on this issue... http://wiki.koha-community.org/wiki/RDA http://blog.bigballofwax.co.nz/2012/12/12/rda-support-in-koha/ http://bywatersolutions.com/2013/02/08/rda/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 12:14:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 10:14:37 +0000 Subject: [Koha-bugs] [Bug 9375] Logging in with LDAP creates duplicate users In-Reply-To: <bug-9375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9375-70-ZQeMofdmUQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9375 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 12:15:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 10:15:42 +0000 Subject: [Koha-bugs] [Bug 9375] Logging in with LDAP creates duplicate users In-Reply-To: <bug-9375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9375-70-dREizqZ5S3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9375 --- Comment #2 from Dobrica Pavlinusic <dpavlin at rot13.org> --- I changed priority of this bug because it's critical for installation with LDAP login (like us). I will try to fix it in next few days and submit report because it hurts us pretty badly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 14:27:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 12:27:33 +0000 Subject: [Koha-bugs] [Bug 10345] New: Copy number should be incremented when adding multiple items at once Message-ID: <bug-10345-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345 Bug ID: 10345 Summary: Copy number should be incremented when adding multiple items at once Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de CC: m.de.rooy at rijksmuseum.nl When adding multiple items in cataloguing, the copy number is not incremented for the generated additional items. To test: - Add new items to any of your records - Make sure you enter a copy number - Choose "Add multiple copies" - Enter number of items to be generaded - Click Add - Verify copynumber is empty for all generated items except the first -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 14:28:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 12:28:48 +0000 Subject: [Koha-bugs] [Bug 10346] New: "Add multiple copies" should be labelled "Add multiple items" Message-ID: <bug-10346-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10346 Bug ID: 10346 Summary: "Add multiple copies" should be labelled "Add multiple items" Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de For consistency in the English and translated templates the button "Add multiple copies" in cataloguing should read "Add multiple items". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 14:32:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 12:32:54 +0000 Subject: [Koha-bugs] [Bug 10347] New: Deactivate "Add item" button when "Add multiple copies" was activated Message-ID: <bug-10347-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10347 Bug ID: 10347 Summary: Deactivate "Add item" button when "Add multiple copies" was activated Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de It happens often that when trying to add multiple items after entering the number the form is accidentally submitted with "Add item". This way you have to start all over to add your multiple copies as it's not possible to duplicate existing items. I think it would be nice, if the "add item" button could be deactivated on entering a number of copies into the field for multiple items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 14:44:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 12:44:38 +0000 Subject: [Koha-bugs] [Bug 10348] New: When using SeparateHoldings OPAC shows number of items, but staff doesn't Message-ID: <bug-10348-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348 Bug ID: 10348 Summary: When using SeparateHoldings OPAC shows number of items, but staff doesn't Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 14:45:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 12:45:56 +0000 Subject: [Koha-bugs] [Bug 10348] When using SeparateHoldings OPAC shows number of items, but staff doesn't In-Reply-To: <bug-10348-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10348-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10348-70-Zl9Hr4Z1xv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- When using the *SeparateHoldings system preferences the number of items for each tab is shown in the OPAC, but not in the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 14:47:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 12:47:56 +0000 Subject: [Koha-bugs] [Bug 10349] New: Don't show empty Descriptions/Title notes tabs in OPAC and staff Message-ID: <bug-10349-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349 Bug ID: 10349 Summary: Don't show empty Descriptions/Title notes tabs in OPAC and staff Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de In staff and OPAC detail pages we shouldn't show the tabs "Description" or "Title note" when they are empty. Also - should they be named differently? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 14:50:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 12:50:42 +0000 Subject: [Koha-bugs] [Bug 10350] New: Capitalization: Home Library column in staff detail items table Message-ID: <bug-10350-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10350 Bug ID: 10350 Summary: Capitalization: Home Library column in staff detail items table Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de The column 'Home Library' should be labelled 'Home library' in the items table of the staff interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 14:54:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 12:54:34 +0000 Subject: [Koha-bugs] [Bug 10351] New: Typo: Missing parenthesis in download options in staff detail pages Message-ID: <bug-10351-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10351 Bug ID: 10351 Summary: Typo: Missing parenthesis in download options in staff detail pages Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de We miss the closing parenthesis for one of the download options (Save to) on the staff detail pages: 'MARC (Unicode/UTF-8' should be 'MARC (Unicode/UTF-8)' <li><a href="/cgi-bin/koha/catalogue/export.pl?format=utf8&op=export&bib=1">MARC (Unicode/UTF-8</a></li> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 14:58:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 12:58:15 +0000 Subject: [Koha-bugs] [Bug 8740] Serials Claims should be exportable all at once In-Reply-To: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8740-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8740-70-SQ1dHWr0Fr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8740 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: Sorry MJ but the warning still occur when the string is not initialized: Use of uninitialized value $supplierid in string eq at /home/koha/src/serials/claims.pl line 71 Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 15:10:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 13:10:20 +0000 Subject: [Koha-bugs] [Bug 10352] New: Cataloguing log search mixing itemnumber/bibnumber Message-ID: <bug-10352-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Bug ID: 10352 Summary: Cataloguing log search mixing itemnumber/bibnumber Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de When testing the 'Modification log' tab on a given record with multiple items in my system I noticed that the search showed confusing results. Some things that seem not quite right: The preselected search uses the biblionumber as object and 'all' for the log. This will bring up all changes for the record, but also all changes for any item which itemnumber matches the bibnumber. If you limit the saerch to only show you the catalog log, you got the same problem. There is no option to find all logs for all items of a given record. Also there is no way to find out if someone deleted items from a record as you don't know the missing itemnumbers. And as object can be itemnumber or biblionumber the results can always be mixed up containing items and records with no relationship with each other. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 15:25:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 13:25:31 +0000 Subject: [Koha-bugs] [Bug 10353] New: "Fines in days" (aka suspensions) should be first-class citizen in Koha Message-ID: <bug-10353-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10353 Bug ID: 10353 Summary: "Fines in days" (aka suspensions) should be first-class citizen in Koha Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: tomascohen at gmail.com Suspensions should be considered a different thing from fines (money wise). Both can be concurrent actually. They should be recorded in its own table on the DB, and have its own class under the Koha namespace. Requirements: - We should be able to know what items under what circumstances triggered a suspension. - We should be able to set a max suspensions limit in a period of time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 15:25:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 13:25:47 +0000 Subject: [Koha-bugs] [Bug 10353] "Fines in days" (aka suspensions) should be first-class citizen in Koha In-Reply-To: <bug-10353-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10353-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10353-70-Byx86Rsu4I@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10353 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 15:43:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 13:43:00 +0000 Subject: [Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop In-Reply-To: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9505-70-9YLH3O071o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505 --- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> --- Comment on attachment 18354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18354 Amended Patch Review of attachment 18354: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9505&attachment=18354) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt @@ +92,4 @@ > [% IF ( invoicenumber ) %] > <li>Invoice no.: [% invoicenumber %]</li> > [% END %] > + [% IF booksellerid %] I think this test can be removed. I don't find anywhere supplier was passed. Or perhaps should we check the supplierid variable. It is passed when we come from the acqui/supplier.pl page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 15:55:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 13:55:48 +0000 Subject: [Koha-bugs] [Bug 10354] New: Don's show optgroup Libraries when no search groups are defined Message-ID: <bug-10354-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Bug ID: 10354 Summary: Don's show optgroup Libraries when no search groups are defined Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de When using OpacAddMastheadLibraryPulldown the library pull down next to the simple search now allways shows an opt group 'libraries' before the entries for the libraries. For an installation with only a few libraries and no search groups this doesn't make sense. Also it would be good if the opt group heading could be formatted to make it more obvious that it's not an option that and can not be selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 15:58:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 13:58:35 +0000 Subject: [Koha-bugs] [Bug 9618] Add support for intranetuserjs to labels/spinelabel-print.pl In-Reply-To: <bug-9618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9618-70-tI4DJo7UfQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 --- Comment #7 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18416 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18416&action=edit Bug 9618: Followup Add support for intranetuserjs to labels/spinelabel-print.pl the jQuery lib is useful only if js code is filled into the intranetuserjs pref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 15:59:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 13:59:26 +0000 Subject: [Koha-bugs] [Bug 9618] Add support for intranetuserjs to labels/spinelabel-print.pl In-Reply-To: <bug-9618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9618-70-cUzlg5IYnb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> --- I think the jQuery lib should only be include if user had defined js code. Owen, could you confirm that please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 16:43:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 14:43:11 +0000 Subject: [Koha-bugs] [Bug 10344] add RDA support to Koha In-Reply-To: <bug-10344-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10344-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10344-70-ZKWTU0pBaj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 17:07:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 15:07:21 +0000 Subject: [Koha-bugs] [Bug 10353] "Fines in days" (aka suspensions) should be first-class citizen in Koha In-Reply-To: <bug-10353-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10353-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10353-70-dGQy3NPnab@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10353 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #1 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Yes, good idea. And if somebody is suspended because he was late (as we do in France), there should be a comment along with the suspenstion, so we know he was blocked because of the late document and not an other cause (like a unpaid fine, a theft attempt etc). M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 17:09:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 15:09:30 +0000 Subject: [Koha-bugs] [Bug 10353] "Fines in days" (aka suspensions) should be first-class citizen in Koha In-Reply-To: <bug-10353-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10353-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10353-70-qDBnhqaoph@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10353 --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I'm glad to see there's interest in this. That's one of the things I'd like to implement Mathieu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 17:13:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 15:13:27 +0000 Subject: [Koha-bugs] [Bug 10353] "Fines in days" (aka suspensions) should be first-class citizen in Koha In-Reply-To: <bug-10353-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10353-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10353-70-3TlWJdhME0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10353 --- Comment #3 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I will sign it off with pleasure ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 17:33:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 15:33:25 +0000 Subject: [Koha-bugs] [Bug 9890] Fix the new plugin system for package installs In-Reply-To: <bug-9890-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9890-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9890-70-omblWrfvMV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16791|0 |1 is obsolete| | --- Comment #17 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 18417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18417&action=edit Bug 9890 - Fix koha-create and koha-create-dirs As noted in the bug, there were three things to do: 1) koha-create: fill in __PLUGINS_DIR__ 2) leave the enable_plugins as off (at least for now) 3) koha-create-dirs: create the directory, set permissions (writeable by the koha user) - Fixed generate_config_file from koha-create so it correctly fills __PLUGINS_DIR__ in every installed file. - koha-create-dirs now creates the relevant dir. - enable_plugins is set to 0 currently, no action required here. Regarding the apache configurations, I'm not sure what you mean. Regards To+ Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 17:34:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 15:34:22 +0000 Subject: [Koha-bugs] [Bug 9890] Fix the new plugin system for package installs In-Reply-To: <bug-9890-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9890-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9890-70-PbiMG0lBYI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff CC| |tomascohen at gmail.com --- Comment #18 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I'm not sure if anything else is needed for packages, and no one is around today to ask :-( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 18:33:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 16:33:31 +0000 Subject: [Koha-bugs] [Bug 10354] Dont's show optgroup Libraries when no search groups are defined In-Reply-To: <bug-10354-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10354-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10354-70-edzlBSIDdu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don's show optgroup |Dont's show optgroup |Libraries when no search |Libraries when no search |groups are defined |groups are defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 18:33:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 16:33:59 +0000 Subject: [Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined In-Reply-To: <bug-10354-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10354-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10354-70-9qZ2RP5Aoz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Dont's show optgroup |Don't show optgroup |Libraries when no search |Libraries when no search |groups are defined |groups are defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 18:48:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 16:48:10 +0000 Subject: [Koha-bugs] [Bug 10341] Erro installing new language with Koha In-Reply-To: <bug-10341-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10341-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10341-70-Abj0b6AQjv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10341 bondiurbano <costalc at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from bondiurbano <costalc at gmail.com> --- Need login as koha user -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon May 27 18:49:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 16:49:56 +0000 Subject: [Koha-bugs] [Bug 10355] New: Second click on modification log misses object parameter Message-ID: <bug-10355-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10355 Bug ID: 10355 Summary: Second click on modification log misses object parameter Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de To reproduce the problem: 1) Go to any detail page in staff 2) Click on the modification log tab 3) Verify, that the object is prefilled with the records biblionumber and you can also see it as parameter in the url 4) Click a second time on modification log to reset your search 4) Verify that the url is missing the biblionumber now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 01:07:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 23:07:18 +0000 Subject: [Koha-bugs] [Bug 10356] New: adding date published to catalogue detail page Message-ID: <bug-10356-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10356 Bug ID: 10356 Summary: adding date published to catalogue detail page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: chrish at catalyst.net.nz CC: gmcharlt at gmail.com adding 'date published' to catalogue detail page, I have also renamed 'date' to 'date arrived' to avoid confusion. similar to bug5512 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 01:10:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 23:10:31 +0000 Subject: [Koha-bugs] [Bug 10356] adding date published to catalogue detail page In-Reply-To: <bug-10356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10356-70-lKFLLCc103@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10356 Chris Hall <chrish at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |chrish at catalyst.net.nz |ity.org | --- Comment #1 from Chris Hall <chrish at catalyst.net.nz> --- Created attachment 18418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18418&action=edit adding date published to catalogue detail page To test: visit the catalogue detail page for a serial item and check: there is a column 'date published' that corresponds to the published date the 'data' column is no longer present there is a 'date arrived' column that corresponds to the arrival date -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 01:10:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 27 May 2013 23:10:45 +0000 Subject: [Koha-bugs] [Bug 10356] adding date published to catalogue detail page In-Reply-To: <bug-10356-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10356-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10356-70-r2UXAeYKWO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10356 Chris Hall <chrish at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 03:13:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 01:13:15 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: <bug-10186-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10186-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10186-70-EWfA7MMrdD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- This patch has been pushed to 3.10.x, will be in 3.10.7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 03:22:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 01:22:55 +0000 Subject: [Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt In-Reply-To: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10191-70-Rqggo6zWJW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Pushed to 3.10.x. Will be in 3.10.7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 03:46:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 01:46:16 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10178-70-eISxi3SBj4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- This patch corrects or updates strings that are already in 3.10.6, I will apply it. Pushed to 3.10.x, will be in 3.10.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 05:25:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 03:25:26 +0000 Subject: [Koha-bugs] [Bug 10357] New: Send email when serial received subscription link is hard to find Message-ID: <bug-10357-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10357 Bug ID: 10357 Summary: Send email when serial received subscription link is hard to find Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: liz at catalyst.net.nz CC: colin.campbell at ptfs-europe.com The link to subscribe to be notified of a new issue of a serial is squirrelled away 3 clicks from the main view - it should be easier to find. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 09:28:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 07:28:21 +0000 Subject: [Koha-bugs] [Bug 10062] Attached item from a deleted record In-Reply-To: <bug-10062-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10062-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10062-70-4mRnliOXxO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10062 shalomchong at segi.edu.my changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #4 from shalomchong at segi.edu.my --- The record disappeared after the re-indexing. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 13:02:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 11:02:22 +0000 Subject: [Koha-bugs] [Bug 10358] New: Unable to return items via self check Message-ID: <bug-10358-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10358 Bug ID: 10358 Summary: Unable to return items via self check Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: bob at calyx.net.au Using Koha's Self checkout module at /cgi-bin/koha/sco/sco-main.pl in Koha 3.10.4. System preference 'AllowSelfCheckReturns' is set to allow. When a patron's barcode is submitted, items on loan are refreshed. There is a button for renewing the item but no button for return. Unable to find any facility to return the item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 13:44:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 11:44:04 +0000 Subject: [Koha-bugs] [Bug 10359] New: CCSR theme should apply jqTransform after OpacUserJS Message-ID: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Bug ID: 10359 Summary: CCSR theme should apply jqTransform after OpacUserJS Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: jcamins at cpbibliography.com Reporter: jcamins at cpbibliography.com Since libraries may want to customize the options in the masthead search dropdown, which is done via dropdown, it would be better if the select box were transformed *after* user javascript was run. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 13:48:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 11:48:49 +0000 Subject: [Koha-bugs] [Bug 10359] CCSR theme should apply jqTransform after OpacUserJS In-Reply-To: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10359-70-lUqNp2Abnv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 13:48:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 11:48:51 +0000 Subject: [Koha-bugs] [Bug 10359] CCSR theme should apply jqTransform after OpacUserJS In-Reply-To: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10359-70-lBhZlVzuXg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 --- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18419&action=edit Bug 10359: transform masthead dropdown after user JS for CCSR Since libraries may want to customize the options in the masthead search dropdown, which is done via dropdown, it would be better if the select box were transformed *after* user javascript was run. To test: 1) Switch to the CCSR OPAC theme. 2) Add some Javascript to your OpacUserJS that will modify the masthead search dropdown, such as: $("select[name='idx']").append("<option value='Host-item,wrdl'>Journal title</option>"); 3) Note that when you view the OPAC, the results in the dropdown are unchanged. 4) Apply patch. 5) Note that your new option now shows up. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 13:53:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 11:53:18 +0000 Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data In-Reply-To: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9836-70-AtJVtXPk2T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 --- Comment #8 from jmbroust <jean-manuel.broust at univ-lyon2.fr> --- I tried to test on sandbox1 and had this message (it might not be tested on sandbox ?) Something went wrong ! Applying: Bug 9836 Filtering sort1 list according to patron category in patron data Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Failed to merge in the changes. Patch failed at 0001 Bug 9836 Filtering sort1 list according to patron category in patron data When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9836 - Filtering sort1 list according to patron category in patron data Bug 9836 Filtering sort1 list according to patron category in patron data Apply? [yn] Patch left in /tmp/Bug-9836-Filtering-sort1-list-according-to-patron--ED9Blz.patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:00:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:00:40 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10278-70-aucMDCdFsM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18207|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18420&action=edit Bug 10278 - Add ability to hide items and records from search results for Independent Branches For the staff intranet, enabling IndependentBranchesRecordsAndItems will automatically add a branch limit filter to the search results thus hiding all records without one or more items owned by the logged in library. In add addition, all items whose homebranch is not that libraries will be filtered and hidden from the search results and record details. This system preference will not affect the OPAC, unless the environment variable BRANCHCODE is defined in the koha-httpd.conf file. If it is defined, the same filters are applied to the OPAC, but based on the branchcode value of the environment variable BRANCHCODE, rather than the logged in branch. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Perform a search that will give results for both records which have items owned by the logged in library, and records which have no items owned by the logged in library. 4) Enable the new system preference IndependentBranchesRecordesAndItems 5) Perform the same search again, any records without items owned by the currently logged in library should not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:08:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:08:42 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-P6JPMvkdyI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18206|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18421&action=edit Bug 10277 - Add C4::Context->IsSuperLibrarian() The method of checking the logged in user for superlibrarian privileges is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least. The codebase is littered with these lines, with no explanation given. It would be much better if we had one subroutine that returned a boolean value to tell us if the logged in user is a superlibrarian or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:10:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:10:53 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-bIH6OJzxGO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18421|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18422&action=edit Bug 10277 - Add C4::Context->IsSuperLibrarian() The method of checking the logged in user for superlibrarian privileges is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least. The codebase is littered with these lines, with no explanation given. It would be much better if we had one subroutine that returned a boolean value to tell us if the logged in user is a superlibrarian or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:11:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:11:42 +0000 Subject: [Koha-bugs] [Bug 10360] New: Can't change patron password Message-ID: <bug-10360-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10360 Bug ID: 10360 Summary: Can't change patron password Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: hend.eleraky at bibalex.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Created attachment 18423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18423&action=edit Error shown on changing password When i try to change patron's password i get an error saying that "Passwords don't match" . The passwords are identical but i don't know why it always show this error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:12:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:12:20 +0000 Subject: [Koha-bugs] [Bug 10360] Can't change patron password In-Reply-To: <bug-10360-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10360-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10360-70-rUP0dtL6VX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10360 Hend <hend.eleraky at bibalex.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:33:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:33:32 +0000 Subject: [Koha-bugs] [Bug 10360] Can't change patron password In-Reply-To: <bug-10360-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10360-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10360-70-pPY3C9QwQO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10360 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P5 - low --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- I can't reproduce this problem in master or 3.10.x. What browser are you using, and what version? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:33:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:33:31 +0000 Subject: [Koha-bugs] [Bug 10361] New: Add Option to cleanup_database.pl to purge search_history entries Message-ID: <bug-10361-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Bug ID: 10361 Summary: Add Option to cleanup_database.pl to purge search_history entries Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: mirko at abunchofthings.net Reporter: mirko at abunchofthings.net Add an option to cleanup_database.pl to purge the search_history entries older than X days. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:34:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:34:42 +0000 Subject: [Koha-bugs] [Bug 10360] Can't change patron password In-Reply-To: <bug-10360-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10360-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10360-70-UVM46ZggxX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10360 --- Comment #2 from Hend <hend.eleraky at bibalex.org> --- Browser :Firefox Koha version : 3.10.03.000 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:37:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:37:40 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: <bug-10361-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10361-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10361-70-qBuGADPCH7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 --- Comment #1 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 18424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18424&action=edit Bug 10361 - Add Option to cleanup_database.pl to purge search_history entries Add an option to cleanup_database.pl to purge the search_history entries older than X days. Test plan: - Apply patch - Check that your test DB has some entries a little older than 30 days and a few ones even older than that in search_history: SELECT * FROM search_history WHERE time < DATE_SUB( NOW(), INTERVAL 30 DAY ); If not, modify some existing entries. - Run cleanup_database with a fixed number of days (replace XX with something higher than 30) /misc/cronjobs/cleanup_database.pl --searchhistory XX - check that entries older than XX days got deleted from search_history - run without the day parameter /misc/cronjobs/cleanup_database.pl --searchhistory - check that entries older than 30 days got deleted from search_history - Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:38:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:38:34 +0000 Subject: [Koha-bugs] [Bug 10361] Add Option to cleanup_database.pl to purge search_history entries In-Reply-To: <bug-10361-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10361-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10361-70-JIdIkFviRP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10361 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:38:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:38:38 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-thWBzhMO9m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18425 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18425&action=edit Bug 10277 - Add C4::Context->IsSuperLibrarian() - Followup - Use IsSuperLibrarian() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:39:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:39:06 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-EFF5WgXALt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:41:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:41:51 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-4ruNw7rOw8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 --- Comment #6 from Kyle M Hall <kyle.m.hall at gmail.com> --- > - I'm pretty sure terminating (via confess) is not the right thing to do if > the userenv isn't set up yet; in particular, this has the potential to break > command-line scripts for no good reason. Good point, switched the confess to a carp! > - Doing it via confess() without loading the Carp module is wrong regardless. I've added a "use Carp" to C4::Context. I think this is the best way to do it, but the BEGIN block does some stuff with CGI::Carp. I don't believe it will cause problems, but I just wanted to point this out. > - A patch that introduces a new C4::Context method but never uses it is > untestable. It should, at the very least, attempt to replace some of the > opaque userenv flags tests, and ideally should aim to replace them all. In > other words, if we're going to refactor this, let's refactor this all the > way. I totally agree! I had originally split this off from another patch that uses it, but I'm in total agreement. I've attached a followup that switches all known code for superlibrarian checks to use IsSuperLibrarian. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:42:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:42:40 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-JRR4KZKDs6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 --- Comment #7 from Kyle M Hall <kyle.m.hall at gmail.com> --- Test Plan: 1) Apply these patches 2) Verify superlibrarian behavior remains unchanged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:45:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:45:06 +0000 Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data In-Reply-To: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9836-70-QDFaukyjy1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18074|0 |1 is obsolete| | --- Comment #9 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 18426 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18426&action=edit Bug 9836 Filtering sort1 list according to patron category in patron data Hello Jean-Manuel, I rebased the patch. It should apply now if nothing is added to updatedatabase.pl in the meanwhile. Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:46:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:46:30 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-E3CGwKrOMt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18422|0 |1 is obsolete| | Attachment #18425|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18427 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18427&action=edit Squashed both patches together. There is really no need to have them separated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:47:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:47:11 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-QRwSqKWst2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18427|Squashed both patches |Bug 10277 - Add description|together. There is really |C4::Context->IsSuperLibrari |no need to have them |an() |separated. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:55:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:55:29 +0000 Subject: [Koha-bugs] [Bug 10193] Copies should be holdings as label for items on MARC view In-Reply-To: <bug-10193-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10193-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10193-70-IjJDO93UCG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10193 --- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 18428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18428&action=edit Bug 10193 - Copies should be holdings as label for items on MARC view In the OPAC MARC view, the table of holdings is labeled 'copies.' In order to be consistent with the normal view this should be labeled 'holdings.' This patch makes this correction. To test, apply the patch and view the MARC detail page for any record with items. The table of holdings data at the bottom of the page should be labeled 'Holdings.' Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:56:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:56:02 +0000 Subject: [Koha-bugs] [Bug 10193] Copies should be holdings as label for items on MARC view In-Reply-To: <bug-10193-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10193-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10193-70-oiBYmuOqFJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10193 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18121|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 14:56:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 12:56:18 +0000 Subject: [Koha-bugs] [Bug 10193] Copies should be holdings as label for items on MARC view In-Reply-To: <bug-10193-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10193-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10193-70-DuZI0qDZfN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10193 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 15:15:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 13:15:28 +0000 Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data In-Reply-To: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9836-70-9elr2RRhWx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 --- Comment #10 from jmbroust <jean-manuel.broust at univ-lyon2.fr> --- Sorry Olivier, I don't have private sandbox and there's a merge conflict. Database might be updated with the command u mentionned in your plan test ? There are 5 other users of this patch, maybe somenone with private ("fromagere") sandbox could test it ? Applying: Bug 9836 Filtering sort1 list according to patron category in patron data Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging admin/authorised_values.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging members/memberentry.pl Failed to merge in the changes. Patch failed at 0001 Bug 9836 Filtering sort1 list according to patron category in patron data When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9836 - Filtering sort1 list according to patron category in patron data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 15:42:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 13:42:30 +0000 Subject: [Koha-bugs] [Bug 10362] New: on return with reserve or transfer the alerts are not shown Message-ID: <bug-10362-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10362 Bug ID: 10362 Summary: on return with reserve or transfer the alerts are not shown Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a return is performed on an item with a reserve or a transfer, the possible alert messages are not shown. These alerts are cases from errmsgloop like "NotIssued", "debarred" ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 15:44:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 13:44:07 +0000 Subject: [Koha-bugs] [Bug 10363] New: There is no package for authorised values. Message-ID: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Bug ID: 10363 Summary: There is no package for authorised values. Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com CC: gmcharlt at gmail.com We should have a package to manage authorised values. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 15:44:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 13:44:15 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10363-70-2woSHHagzP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 15:46:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 13:46:19 +0000 Subject: [Koha-bugs] [Bug 10095] There should be a way to suppress a category of authorised values In-Reply-To: <bug-10095-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10095-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10095-70-1C79x1IL0C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10095 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- I think it is not a bug. There are several mandatory categories (Asort1 Asort2 Bsort1 Bsort2 SUGGEST DAMAGED LOST REPORT_GROUP REPORT_SUBGROUP DEPARTMENT TERM : They are hardcoded into admin/authorised_values.pl). Which categories are you talking about? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 15:54:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 13:54:49 +0000 Subject: [Koha-bugs] [Bug 10362] on return with reserve or transfer the alerts are not shown In-Reply-To: <bug-10362-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10362-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10362-70-FybDWXGpxt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10362 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 18429 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18429&action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 15:54:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 13:54:56 +0000 Subject: [Koha-bugs] [Bug 10362] on return with reserve or transfer the alerts are not shown In-Reply-To: <bug-10362-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10362-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10362-70-w87xloUZkj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10362 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 15:55:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 13:55:51 +0000 Subject: [Koha-bugs] [Bug 10095] There should be a way to suppress a category of authorised values In-Reply-To: <bug-10095-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10095-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10095-70-QOio0J5xdW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10095 --- Comment #2 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Yes, there are hard coded categories. But you can also define your own categories. For example, we defined a category for the type of alphabet used in record, for the type of diploma used in patron attributes, for the "level" of the documents (target audience), etc. Ex : If next year the diploma codes are no more stored in our patron records, the category we created (mapped with codes from our LDAP) will become useless... M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 15:58:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 13:58:14 +0000 Subject: [Koha-bugs] [Bug 10095] There should be a way to suppress a category of authorised values In-Reply-To: <bug-10095-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10095-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10095-70-XGpOprefTm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10095 --- Comment #3 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- The mandatory categories you cite could be highted in Koha interface. We don't have DEPARTMENT and TERM in Rennes 2. What is used for? M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 15:58:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 13:58:35 +0000 Subject: [Koha-bugs] [Bug 10095] There should be a way to suppress a category of authorised values In-Reply-To: <bug-10095-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10095-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10095-70-6FzSqGMeLE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10095 --- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I mean highlighted... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:11:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:11:24 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10363-70-QUCypiOPsB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18430&action=edit Bug 10363: Add 2 packages for authorised values Currently, the authorised values are anarchically managed :) We have to have a better way to manage them. I propose 2 packages in order to execute the sql queries into a package instead of directly into the pl script. This development adds: - A new unique key (category and authorised values) for the authorised_values table. - 2 new packages Koha::AuthorisedValue and Koha::AuthorisedValues - 1 new unit test file in order to test these 2 packages. It is a code source evolution, but there is no change for the final user. Test plan: 1/ Apply the patches 2/ Check that existing authorised values is displayed on your admin page (admin/authorised_values.pl). 3/ Update an existing one 4/ Create a new category 5/ Create a new AV for this category 6/ Create another one with the same value, an error should be occur. 7/ Delete one AV. 8/ Click everywhere on the authorised values admin page and try to find a bug. 9/ Launch t/db_dependent/AuthorisedValues.t and check that all tests pass (1 sql error appears, it is normal). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:11:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:11:27 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10363-70-41uRRtJ8J2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18431 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18431&action=edit Bug 10363: DB Changes: Adds a unique key for the authorised values table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:11:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:11:30 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10363-70-D93Y3VEmYX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18432&action=edit Bug 10363: Adds unit tests for Koha::AuthorisedValue[s] packages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:11:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:11:50 +0000 Subject: [Koha-bugs] [Bug 10363] There is no package for authorised values. In-Reply-To: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10363-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10363-70-dc6djuMkgu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:19:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:19:05 +0000 Subject: [Koha-bugs] [Bug 10095] There should be a way to suppress a category of authorised values In-Reply-To: <bug-10095-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10095-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10095-70-iDapJEHAuy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10095 --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- To remove a category, you should remove all authorised values created for this category. DEPARTMENT and TERM are introduced by bug 8215 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:34:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:34:00 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-5GzoG3EzYo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9498|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18433&action=edit Bug 8064: Merge several biblios This patch improves the existing merging tool by adding possibility to merge more than 2 biblios. There is no functional changes: - Add some biblios to a list - In the list check some biblios and click on 'Merge selected records' - Choose the biblio which will be kept, all others will be deleted - On the next page you have all biblios you chose in tabs (left side of the screen) and the preview of result (right side) - Pick some fields or subfields from records that will be deleted or delete some fields from reference record. - Click on 'Merge', if there is no errors you are redirected to the biblio view. Added checks for non-repeatable subfields Added checks for mandatory fields and subfields before submitting the form. Added a final report which display deleted records (see syspref MergeReportFields) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:34:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:34:39 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-nxTJrxeA34@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:36:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:36:36 +0000 Subject: [Koha-bugs] [Bug 10095] There should be a way to suppress a category of authorised values In-Reply-To: <bug-10095-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10095-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10095-70-yDItPfgJSW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10095 --- Comment #6 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Ok, when I tested some months ago to suppress all values of a category, I believe the void category itself remained in Koha. Maybe I did it the wrong way... M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:42:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:42:15 +0000 Subject: [Koha-bugs] [Bug 10193] Copies should be holdings as label for items on MARC view In-Reply-To: <bug-10193-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10193-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10193-70-AK5F71vqIK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10193 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |String patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- String patch. Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:42:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:42:27 +0000 Subject: [Koha-bugs] [Bug 10193] Copies should be holdings as label for items on MARC view In-Reply-To: <bug-10193-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10193-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10193-70-z6PEPm7Fgq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10193 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18428|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18434&action=edit Bug 10193 - Copies should be holdings as label for items on MARC view In the OPAC MARC view, the table of holdings is labeled 'copies.' In order to be consistent with the normal view this should be labeled 'holdings.' This patch makes this correction. To test, apply the patch and view the MARC detail page for any record with items. The table of holdings data at the bottom of the page should be labeled 'Holdings.' Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:44:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:44:37 +0000 Subject: [Koha-bugs] [Bug 10364] New: add a way to partially receive an order without creating a new order Message-ID: <bug-10364-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10364 Bug ID: 10364 Summary: add a way to partially receive an order without creating a new order Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mathieu.saby at univ-rennes2.fr At present, if we order 3 copies of a document, and only 2 are received, Koha creates a new order with the 3rd copy. As a consequency, if we print again the basketgroup, there is a new line. I would prefer Koha not to create a new order, so that the content of baskets and basket groups will not be altered by reception. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:45:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:45:18 +0000 Subject: [Koha-bugs] [Bug 10284] Missing spaces between label and content in XSLT view for 785/780 In-Reply-To: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10284-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10284-70-h9LcIDAe17@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10284 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:47:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:47:07 +0000 Subject: [Koha-bugs] [Bug 9424] Move JavaScript out of header include In-Reply-To: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9424-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9424-70-I3Q6YXMOKu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9424 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:49:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:49:00 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-HIWbqsXyJV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #4 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Does this take into account the (already signed-off) refactoring I did on bug 9755? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:55:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:55:25 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7368-70-BxsjAXJPR4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #85 from Galen Charlton <gmcharlt at gmail.com> --- Latest pushed to master. Thanks, Connor! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:57:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:57:09 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7368-70-8eve8IFDSP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18407|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:57:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:57:16 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7368-70-6AcoF2wf1H@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:59:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:59:07 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7825-70-EKGHnbl8Gb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15606|0 |1 is obsolete| | Attachment #15607|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18435 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18435&action=edit bug_7825: Sign off Changed OPACItemHolds syspref to be no|tes|force choice Amended opac-reserve.tt accordingly Signed-off-by: Delaye Stephane <stephane.delaye at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:59:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:59:08 +0000 Subject: [Koha-bugs] [Bug 10193] Copies should be holdings as label for items on MARC view In-Reply-To: <bug-10193-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10193-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10193-70-MtOTzor2Jy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10193 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:59:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:59:12 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7825-70-Tb6E0hIUt9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #54 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18436 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18436&action=edit Bug 7825: Followup prevent submission without choosing an item + Fix some ergonomic issues in opac-reserve Signed-off-by: Delaye Stephane <stephane.delaye at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 16:59:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 14:59:40 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7825-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7825-70-r0nii5TI0P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #55 from Jonathan Druart <jonathan.druart at biblibre.com> --- Rebased patches... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:02:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:02:33 +0000 Subject: [Koha-bugs] [Bug 9286] Add script to add a bib to the zebra queue from the command line In-Reply-To: <bug-9286-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9286-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9286-70-SnggEYhpfz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9286 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:06:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:06:58 +0000 Subject: [Koha-bugs] [Bug 10184] Circulation History reverses sort order In-Reply-To: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10184-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10184-70-bFX23sRKsC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10184 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:08:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:08:50 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-hOVlAJIAQ0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r Change sponsored?|--- |Sponsored --- Comment #5 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Sponsored by Rennes 2 M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:09:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:09:29 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10218-70-OzPRAQCIHf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED CC| |gmcharlt at gmail.com Assignee|oleonard at myacpl.org |mathieu.saby at univ-rennes2.f | |r --- Comment #5 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Owen! Setting status to assigned to Mathieu for a UNIMARC followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:10:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:10:08 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10218-70-UJirplI37y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18402|0 |1 is obsolete| | --- Comment #6 from Galen Charlton <gmcharlt at gmail.com> --- Comment on attachment 18402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18402 Bug 10218 - In OPAC XSLT search results, add class to 'online access' Marking patch obsolete now that it has been pushed to master but with a UNIMARC follow-up to be expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:11:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:11:37 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-mlQZBboA1m@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |--- --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- Absolutely not... I think Julian did not know this report exist... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:13:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:13:25 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10218-70-aTbmkI7Vkw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #7 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Galen, I never really understood that : must or must not a followup for a patch already pushed in master be attached to a new bug ? >From a discussion under an other bug, I believe it is a good practice? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:15:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:15:07 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-QEaklsStW5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #7 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Jared, I tested your patch in march, so I hopped it would be in 3.12. But it was not QAed, and I forgot it... Do you think it will cause major conflict with this bug? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:32:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:32:25 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-sbm7fZopwg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master because this patch resolves the discrepancy, but I must confess to a number of reservations: - the same section of code sets and uses both $control_branchcode and $circControlBranch - the patch effectively adds copy-pasta rather than moving more of the fine-calculation code into a routine that could be shared by fines.pl and AddReturn() - the fact that the patch couldn't use _GetCircControlBranch and is overloading the PickupLibrary value for CircControl, while consistent with fines.pl, is IMO stretching the CircControl syspref a bit too far. - the patch include whitespace changes that obscured its purpose - this patch is crying out for DB-dependent test cases -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:33:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:33:10 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-pBsf4GrRSH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #22 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: This patch adds a new entry in the search fields dropdown list: date of birth. The functionality deals with all date formats and works as expected. Marked as Passed QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:33:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:33:34 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-33xLqxqRyb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15556|0 |1 is obsolete| | Attachment #15557|0 |1 is obsolete| | Attachment #15558|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18437&action=edit Bug 8845 - Add ability search patrons by date of birth Adds the ability to search by dates of birth in iso format. Signed-off-by: Marc Veron <veron at veron.ch> Searched with following formats: YYYYMMDD , YYYY-MM-DD , YYYY.MM.DD All searches are OK Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:33:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:33:41 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-YJOnKSJq1X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #24 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18438&action=edit Bug 8845: Followup Allow to give a date using the syspref format Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:33:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:33:51 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-eoecsYjR9F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #25 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18439&action=edit Bug 8845 - Add ability search patrons by date of birth - Add tooltip Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Works with all date formats -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:34:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:34:03 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-Do9H511ZAE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.12 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:37:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:37:04 +0000 Subject: [Koha-bugs] [Bug 9349] Saved reports: sort broken on creation date In-Reply-To: <bug-9349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9349-70-8MpStRzcDd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9349 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Bug 9466 introduces Datatable on this page. This patch becomes useless. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 17:40:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 15:40:53 +0000 Subject: [Koha-bugs] [Bug 10327] Rename poorly named system preferences In-Reply-To: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10327-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10327-70-gFi9bgwi2n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 --- Comment #4 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #3) > Maybe because I don't speak english fluently, I don't understand the group > of sysprefs "Local use". What is the meaning of this phrase? In this context, "Local use" means "locally-defined", i.e., system preferences that aren't in stock Koha and are strictly for the use of that particularly installation. One of example of such system preferences would be for Koha-as-a-CMS. > I don't understant the group of sysprefs "Creators" either. What does it > mean for you? I don't think "Creators" is a good name -- that section refers to sysprefs related to item labels and patron card priting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 18:52:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 16:52:04 +0000 Subject: [Koha-bugs] [Bug 6173] Cronjob to send account expiry notices In-Reply-To: <bug-6173-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6173-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6173-70-4KJw4XujVM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6173 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|henridamien at koha-fr.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 19:46:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 17:46:34 +0000 Subject: [Koha-bugs] [Bug 10359] CCSR theme should apply jqTransform after OpacUserJS In-Reply-To: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10359-70-1r7Yfz4QeY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18419|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 18440 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18440&action=edit Bug 10359: transform masthead dropdown after user JS for CCSR Since libraries may want to customize the options in the masthead search dropdown, which is done via dropdown, it would be better if the select box were transformed *after* user javascript was run. To test: 1) Switch to the CCSR OPAC theme. 2) Add some Javascript to your OpacUserJS that will modify the masthead search dropdown, such as: $("select[name='idx']").append("<option value='Host-item,wrdl'>Journal title</option>"); 3) Note that when you view the OPAC, the results in the dropdown are unchanged. 4) Apply patch. 5) Note that your new option now shows up. 6) Sign off. Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 19:46:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 17:46:54 +0000 Subject: [Koha-bugs] [Bug 10359] CCSR theme should apply jqTransform after OpacUserJS In-Reply-To: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10359-70-CCEIYFA5Jb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 20:14:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 18:14:43 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-syGvrvzfit@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #30 from Kyle M Hall <kyle.m.hall at gmail.com> --- Galen, if you feel strongly this is the way to go, I will do it that way. I'm fully invested in making Koha the best ILS it can be! Also, as far as the fines logic goes, for this I will do whatever is necessary to make it function, but I'm still preparing a full-rewrite of the accounts system, so I'll probably just shore this up with the minimum amount of code, as the rewrite will replace it eventually. It really does seem more logical to have CalcFine deal with all fine limiting activities, rather than UpdateFine. However, there may be consequences I'm not seeing. Kyle (In reply to comment #29) > (In reply to comment #28) > > > Perhaps we have fines logic in too many places. Maybe MaxFines logic needs > > > to be moved to CalcFine as well. > > > > I agree with Galen that moving them both out of the prefs would be great. > > But adjusting a lot of troublesome circulation code would be great too. > > The thing is, not taking the time to set a new circ policy switch at the > right level of specificity just adds to the refactoring work that has to be > done later. > > Setting back to in discussion to ask the question of Kyle directly: are you > willing to prepare a version of this patch that adds this limit as a > issuingrules policy, not a system preference? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 20:21:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 18:21:20 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-zfK2AgI0yy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18372|0 |1 is obsolete| | --- Comment #94 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18441 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18441&action=edit [SIGNED-OFF] Bug 8015: Add unit tests for SimpleMARC and MarcModificationTemplates routines Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 20:21:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 18:21:45 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-xnqZ9fyAJV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 20:45:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 18:45:14 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-skDJvREVn0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #95 from Kyle M Hall <kyle.m.hall at gmail.com> --- Jonathan, I looks like your git branch for this doesn't include the newest version of the last patch. I checked out your branch, updated the last patch, and tried to rebase it against master. However, I got a large merge conflict at "Fix template capitalization and other template issues". Would you care to try rebasing this patch series to master? Kyle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 21:12:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 19:12:39 +0000 Subject: [Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English In-Reply-To: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10292-70-cyEEupLTgv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18262|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 18442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18442&action=edit bug 10292: improve fallback logic for picking XSLT This patch fixes a bug whereby XSLT files from the prog theme would be used (for English OPACs and staff interfaces) even if the user had created and enabled a custom theme that provided override XSLT files. This patch provides a clearer implementation of the fallback logic and adds test cases. To reproduce the bug: [1] Set OPACXSLTDetailsDisplay to 'default' and English as the OPAC language. [2] Create a new OPAC theme, including copying the XSLT files. [3] Set opactheme to the new theme. [4] Make a change to koha-tmpl/opac-tmpl/NEWTHEME/en/xslt/MARC21slim2OPACDetail.xsl [5] View a bib record in the OPAC. The change made in the previous step is not reflected. To test after applying the patch: [6] Reload the bib record in the OPAC. The change made in step 4 should now be reflected. [7] (To be thorough) Go through the test plan for bug 8947 and verify that there is no regression. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 21:13:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 19:13:00 +0000 Subject: [Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English In-Reply-To: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10292-70-0BKstI5h3s@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 21:25:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 19:25:43 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-FvcKabXiVJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 --- Comment #13 from Kyle M Hall <kyle.m.hall at gmail.com> --- (In reply to comment #12) > Pushed to master because this patch resolves the discrepancy, but I must > confess to a number of reservations: > > - the same section of code sets and uses both $control_branchcode and > $circControlBranch Yes, that is rather ugly. _GetCircControlBranch does a lot of under the hood logic, far more than the new statement, but I think the results would be this same. So we can unify that. > - the patch effectively adds copy-pasta rather than moving more of the > fine-calculation code into a routine that could be shared by fines.pl and > AddReturn() Agreed, that should be remedied. > - the fact that the patch couldn't use _GetCircControlBranch and is > overloading the PickupLibrary value for CircControl, while consistent with > fines.pl, is IMO stretching the CircControl syspref a bit too far. Should we make fines.pl use _GetCircControlBranch as well? > - the patch include whitespace changes that obscured its purpose My bad, I have a perltidy addiction. I just can't help myself ; ) > - this patch is crying out for DB-dependent test cases Agreed! I'm willing to followup on this to clean up this code. It seems logical to unify all this logic under the banner of _GetCircControlBranch, would you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 21:32:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 19:32:27 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-g7dcCYDmUB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz QA Contact| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- QAing this today -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 21:33:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 19:33:17 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-IytNr75V93@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #6 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I try it today, there is a little conflict. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 21:34:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 19:34:39 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-ZFDrWV9J1z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #8 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I am working on a rebase of Biblibre on top of 9755. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 22:54:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 20:54:58 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5202-70-ThlGb7Nh94@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Large patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 22:55:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 20:55:00 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5202-70-kT0X3qr2vA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 --- Comment #3 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18443 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18443&action=edit Bug 5202: merge authorities from the authority file and reservoir This patch gives Koha the ability to merge authority records using the same interface used by bibliographic records, though slightly different methods for selecting which records to merge. The two ways to select records are as follows: 1) Records can be selected from authority search results by clicking the "Merge" link for two records. 2) Authority records can be merged from the reservoir by clicking the merge-related links in the Manage staged MARC batch screen. To test: 1) Apply patch. 2) Do a search for an authority record that will turn up multiple identical records (or at least two records that you don't mind merging). 3) Click the "Merge" link for the first record. 4) Click the "Merge" link for the second record. 5) Choose which fields from which record you want to appear in the resulting record. 6) Confirm that those are the fields that exist in the resulting record. 7) Stage an authority record (for example, an authority record you saved from your catalog. 8) Search for a record to merge with it using the "Search for a record to merge in a new window" link. 9) Merge these records, confirming that the resulting record (after going through the entire merging process) matches your expectations. 10) Set up a matching rule for authorities, and export an authority from your catalog that will match based on that rule. For MARC21, the following is a good choice for a rule: Matching rule code: AUTHPER Description: Personal name main entry Match threshold: 999 Record type: Authority record [Match point 1:] Search index: mainmainentry Score: 1000 Tag: 100 Subfields: a 11) Stage the record you just exported, choosing the matching rule you just created. 12) Merge the record using the "Merge" link, confirming that the resulting record (after going through the entire merging process) matches your expectations. 13) Sign off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 23:38:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 21:38:23 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-Htn8T6w0pn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 --- Comment #14 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #13) > Yes, that is rather ugly. _GetCircControlBranch does a lot of under the hood > logic, far more than the new statement, but I think the results would be > this same. So we can unify that. [snip] > > - the fact that the patch couldn't use _GetCircControlBranch and is > > overloading the PickupLibrary value for CircControl, while consistent with > > fines.pl, is IMO stretching the CircControl syspref a bit too far. > > Should we make fines.pl use _GetCircControlBranch as well? First we'll have to figure out what we want _GetCircControlBranch to do. However, it might be as simple as passing it an optional issues hash so that it handle the special PickupLibrary case for loans. > > - the patch include whitespace changes that obscured its purpose > > My bad, I have a perltidy addiction. I just can't help myself ; ) That addiction is best indulged in separate patches that follow the substantive ones. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 23:41:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 21:41:40 +0000 Subject: [Koha-bugs] [Bug 9773] Replace YUI AJAX calls in cataloging plugins with jQuery In-Reply-To: <bug-9773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9773-70-60UCcA6Mee@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15989|0 |1 is obsolete| | --- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 18444 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18444&action=edit Bug 9773 - Replace YUI AJAX calls in cataloging plugins with jQuery Several cataloging plugins make some simple AJAX GET calls via the YUI AJAX feature. This code can be easily converted to jQuery. To test, link each plugin to the relelvant field by editing your MARC stucture. Confirm that functionality is unchanged. For callnumber.pl and callnumber-KU.pl, test by linking to 952o. callnumber.pl is triggered on blur of (when you focus on and click away from) the 952o entry field. callnumber-KU.pl is triggered by clicking the "..." link. stocknumberam123.pl should be linked to 952i. If your data doesn't already have information stored for inventory number, modify at least one record to add one. The plugin is triggered on blur of the 952i field. It should increment the highest value inventory number stored in your system. unimarc_field_010.pl is UNIMARC-specific, so I'm guessing about its functionality. I tested it by linking the plugin to MARC21 field 020a. The plugin is triggered on blur of the affected field (020a in my test). You can confirm that the plugin returns valid data by using a tool like Firebug to view the XHR response. Or if you're not using UNIMARC you can hack the plugin to update a different field instead (line 57, /^tag_210_subfield_c/ ). I tried "245_subfield_c" instead of "210c_subfield_c." Nonsensical, but useful for testing. Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> Tried the 3 MARC21 plugins. Did not try the Unimarc one, but it's exactly the same code change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 23:42:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 21:42:04 +0000 Subject: [Koha-bugs] [Bug 9773] Replace YUI AJAX calls in cataloging plugins with jQuery In-Reply-To: <bug-9773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9773-70-XUW3ny51fo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 23:56:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 21:56:42 +0000 Subject: [Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings In-Reply-To: <bug-6553-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6553-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6553-70-R6QcWMdqu7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18055|0 |1 is obsolete| | --- Comment #16 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 18445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18445&action=edit Bug 6553 - Parentheses in Corporate author break tracings To test: If an author's name includes parentheses or other escape-characters, the tracing links produced in the OPAC fail in XSLT mode. This patch wraps the author names in double-quotes, providing the necessary escapement. Test plan: - Create a new framework, delete Thesaurus from 100 and other fields - Create a new record in this framework (or change an existing record to this framework) - Add 100$a - use parentheses - Check the search links in OPAC detail pages Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue May 28 23:57:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 21:57:07 +0000 Subject: [Koha-bugs] [Bug 6553] Parentheses in corporate author break tracings In-Reply-To: <bug-6553-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6553-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6553-70-hFUibplXdb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6553 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 00:15:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 22:15:12 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-BUQMmyXbst@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> --- Passes the QA scripts OK Koha/Authority.pm OK Koha/Record.pm OK cataloguing/merge.pl OK t/Koha_Record.t OK koha-tmpl/intranet-tmpl/prog/en/includes/merge-record.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/merge.tt perl t/Koha_Record.t ok 1 - use Koha::Record; ok 2 - Created valid Koha::Record object ok 3 - Generated hash correctly ok 4 - No duplicate keys Unit tests pass prove t passes all tests Testing functionality now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 00:34:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 22:34:10 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-B4efGPzRJ5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> --- Merge worked fine in the interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 00:34:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 22:34:41 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-S9KV7OaXBX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 00:34:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 28 May 2013 22:34:43 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-su4px32FQn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15922|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18446 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18446&action=edit Bug 9755: Refactor record merge functionality This patch refactors the merge record interface and code a little bit in preparation for making it possible to merge authority records. To test: 1) Apply patch. 2) Try merging two records: a) Create a list. b) Add two records you would like to (or be willing to) merge to said list. c) View said list. d) Check the checkboxes next to the two records you added. e) Click "Merge selected records." f) Choose a merge reference. g) Choose fields from each record that you want to keep. h) Click "Merge." 3) Confirm that your merged record has the fields and subfields you wanted. 4) Run the unit tests for the two files that were changed: prove t/Koha_Record.t t/db_dependent/Koha_Authority.t 5) Sign off. Signed-off-by: Mathieu Saby <mathieu.saby at univ-rennes2.fr> Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 02:20:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 00:20:10 +0000 Subject: [Koha-bugs] [Bug 10365] New: Using published date on routing slips Message-ID: <bug-10365-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10365 Bug ID: 10365 Summary: Using published date on routing slips Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: chrish at catalyst.net.nz CC: gmcharlt at gmail.com Using published date on routing slips (rather than planned date). A possible future enhancement is place this behind a syspref and/or have planned date there as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 02:21:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 00:21:15 +0000 Subject: [Koha-bugs] [Bug 10365] Using published date on routing slips In-Reply-To: <bug-10365-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10365-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10365-70-yNZ1KoU5cm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10365 Chris Hall <chrish at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |chrish at catalyst.net.nz |ity.org | --- Comment #1 from Chris Hall <chrish at catalyst.net.nz> --- Created attachment 18447 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18447&action=edit change routing slips to use date published -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 02:40:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 00:40:48 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10240-70-bOnbEMXfAN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 02:40:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 00:40:50 +0000 Subject: [Koha-bugs] [Bug 10240] Offline circulation using HTML5 and IndexedDB In-Reply-To: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10240-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10240-70-XDb7kJBaKP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10240 --- Comment #2 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18448&action=edit Bug 10240: Offline circulation using HTML5 and IndexedDB This patch adds an HTML5-based offline mode to Koha's existing circulation module, allowing librarians to check out items using a basically familiar interface. The feature will be implemented using the Application Cache and IndexedDB features of the HTML5 specification, both of which are fully supported on Firefox 10+ and Chrome 23+, with limited support going back to Firefox 4 and Chrome 11. The basic workflow enabled by this patch is as follows: Part 1: While connected to the Internet 1. Enable offline functionality by turning on the "AllowOfflineCirculation" system preference. 2. Sync the offline circulation database on the computer that will be used for offline circulation by following the "Offline circulation interface" link on the Circulation home page, choosing "Synchronize (must be online)", and clicking the "Download records" button. This process may take a while. 3. Bookmark /cgi-bin/koha/circ/offline.pl (the page you are currently on) for easy access when offline. Part 2: While disconnected from the Internet 4. Navigate to /cgi-bin/koha/circ/offline.pl using the bookmark you created while online. 5. Start checking books in by scanning the barcode of an item that has been returned into the box in the "Check in" tab. 6. Scan the barcodes of any additional items that have been returned. 7. Start checking out books to a patron by scanning the patron's barcode in the box in the "Check out" tab. 8. Set a due date (the "Remember for session" box will be checked by default, since circulation rules are not computed during offline transactions and therefore a due date must be specified by the librarian). 9. Scan an item barcode (if you did not set a due date, it will prompt you) to check the item out to the patron. 10. If a patron has a fine you can see the total amount (current to when the offline module was synced), and record a payment. Unlike when in online mode, there will be no breakdown of what item(s) fines are for, and you will only be able to record the payment amount and not associate it with a particular item. Part 3: While connected to the Internet 11. Click the "Synchronize" link and choose "Upload transactions" to upload the transactions recorded during the offline circulation session. 12. Navigate to /cgi-bin/koha/offline_circ/list.pl (there will be a link from the Offline circulation page) and review the transactions, as described in the documentation for the Firefox Offline circulation plugin: http://wiki.koha-community.org/wiki/Offline_circulation_firefox_plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 03:10:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 01:10:02 +0000 Subject: [Koha-bugs] [Bug 10366] New: Alert librarian if an invoice number is duplicated Message-ID: <bug-10366-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Bug ID: 10366 Summary: Alert librarian if an invoice number is duplicated Classification: Unclassified Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jcamins at cpbibliography.com Reporter: jcamins at cpbibliography.com Some vendors ship materials from the same invoice in multiple packages. In those cases, it would be good to notify the librarian when they enter a duplicate invoice number, so that they can continue receiving on the previously-created invoice, rather than creating an invoice with a duplicate number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 03:29:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 01:29:36 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9902-70-Td6NR425m8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #16 from Nicole C. Engard <nengard at gmail.com> --- Was this pushed to 3.10.x? I don't think so and that's where this bug was found. Reopening. Close if I'm wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 03:29:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 01:29:44 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9902-70-ejTL0RQZRi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 03:29:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 01:29:51 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9902-70-UUFj7Mi9G2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 03:31:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 01:31:47 +0000 Subject: [Koha-bugs] [Bug 9611] Changing the password hashing algorithm from MD5 to more secure Bcrypt In-Reply-To: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9611-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9611-70-qdUrXrkZUd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9611 Chris Hall <chrish at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 04:05:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 02:05:34 +0000 Subject: [Koha-bugs] [Bug 10367] New: Allow packages to work on debian wheezy Message-ID: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Bug ID: 10367 Summary: Allow packages to work on debian wheezy Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz CC: robin at catalyst.net.nz Some (hopefully minor) changes are required to the packages to make them work on Debian Wheezy. Ideally these changes would also permit it to work on Squeeze at the same time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 04:05:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 02:05:43 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-ap61if6eWQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 05:51:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 03:51:39 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-7T6J5fKlJW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 --- Comment #1 from Robin Sheat <robin at catalyst.net.nz> --- These are the packages that, on a first pass, don't exist in wheezy. These we already have packages for: libdata-paginator-perl libmodule-bundled-files-perl libtemplate-plugin-htmltotext-perl This no longer exists: tinymce2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 06:09:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 04:09:52 +0000 Subject: [Koha-bugs] [Bug 3628] Add opacSerialDefaultTab preference to display shortened serial collection instead of holdings by default In-Reply-To: <bug-3628-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-3628-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3628-70-vA5dMqfy2B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3628 vimal kumar <vimal0212 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com --- Comment #10 from vimal kumar <vimal0212 at gmail.com> --- Administration ? System preferences> opacSerialDefaultTab > Subscription Tab does not save.I felt this problem in 3.12.00. The result is serial display in OPAC missing issue details in first view. Any progress in solve this problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 06:10:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 04:10:07 +0000 Subject: [Koha-bugs] [Bug 6461] BiblioDefaultView has no impact on how record are displayed when going from results list In-Reply-To: <bug-6461-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6461-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6461-70-ORPAoY57JR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6461 vimal kumar <vimal0212 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 07:33:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 05:33:11 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-0gd0pMLqKb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 --- Comment #2 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 18449 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18449&action=edit Bug 10367 - update the rules and control file for wheezy This updates the control file to use tinymce rather than tinymce2, as tinymce2 is deprecated and no longer in Debian. Also a general dependencies update. Note that this is suitable for master only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 07:34:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 05:34:13 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-9cD9DxsZtB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Robin Sheat <robin at catalyst.net.nz> --- A quick bit of testing illustrated that tinymce, which is version 3, works just as well as tinymce2. Koha as a whole should probably switch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 07:34:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 05:34:20 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-JzUPu4rq8k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 07:34:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 05:34:29 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-fe5P7hvXd4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 09:13:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 07:13:45 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-FETmucAPNw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #10 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Jared, could you tell my why you exclude 999 field in this line of createMarcHash ? I don't know how the 999 is used by Koha... + if ((!defined($tagslib) || $tagslib->{$fieldtag}->{'tab'} >= 0) && $fieldtag ne '995' && $fieldtag ne '999') { M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 09:15:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 07:15:10 +0000 Subject: [Koha-bugs] [Bug 10368] New: Added price in overdue report Message-ID: <bug-10368-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10368 Bug ID: 10368 Summary: Added price in overdue report Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: amit.gupta at osslabs.biz Added price in overdue report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 09:15:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 07:15:50 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-HD8S92q6WD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #11 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- As 995 is excluded (for UNIMARC), I suppose 952 should have do (for Marc21) ? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 09:18:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 07:18:53 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8015-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8015-70-ACzmV1oEWn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 --- Comment #96 from Jonathan Druart <jonathan.druart at biblibre.com> --- I updated the git branch just now. All patches (submitted on this report) are rebased against master (just 2 conflicts with the first patch on updatedatabase.pl and kohastructure.sql). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 09:52:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 07:52:39 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-aOtFvWvv93@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #10) > Jared, could you tell my why you exclude 999 field in this line of > createMarcHash ? > I don't know how the 999 is used by Koha... > > + if ((!defined($tagslib) || $tagslib->{$fieldtag}->{'tab'} >= 0) && > $fieldtag ne '995' && $fieldtag ne '999') { > > > M. Saby 999 is where the biblioitemnumber and biblionumber are stored (at least in MARC21) 999$c and 999$d -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:00:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:00:33 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-1XyuywkIXD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #13 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #11) > As 995 is excluded (for UNIMARC), I suppose 952 should have do (for Marc21) ? > > M. Saby 995 was excluded originally (if you look at merge.pl). So we are still excluding it. However for quite a while the item data has not been stored in the MARCXML, and the way we fetch the MARC biblio is by calling my $record = GetMarcBiblio($biblionumber); So the item data is not added, if it was called with my $record = GetMarcBiblio($biblionumber, 1); Then items would be added so 952. So in our case, we have the MARC object, with no item data ie no 952 (in theory no 995 as well, but im not sure about that so left that exclusion in there). So no need to exclude the 952. I hope this helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:07:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:07:27 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-jT7QwU7mQX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #14 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- OK, I thought it was in 090a, like in UNIMARC. So, if it useful NOT to merge 999 for Marc21, maybe it will be usefull NOT t to merge 090 too, for UNIMARC? But 999 could also be used for other purpose I suppose, in Marc21 and in UNIMARC. For example, in UNIMARC, Academic libraries can use this subfield freely, for their own use. "Cette zone peut ?tre utilis?e librement pour des donn?es ne correspondant ? aucune zone du format d'?change standard, suivant les besoins de chaque biblioth?que." http://documentation.abes.fr/sudoc/formats/loc/zones/999.htm#UtilisationActuelle M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:09:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:09:57 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-z8AbhAQEET@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #15 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #14) > OK, I thought it was in 090a, like in UNIMARC. > So, if it useful NOT to merge 999 for Marc21, maybe it will be usefull NOT t > to merge 090 too, for UNIMARC? > > But 999 could also be used for other purpose I suppose, in Marc21 and in > UNIMARC. > For example, in UNIMARC, Academic libraries can use this subfield freely, > for their own use. > "Cette zone peut ?tre utilis?e librement pour des donn?es ne correspondant ? > aucune zone du format d'?change standard, suivant les besoins de chaque > biblioth?que." > http://documentation.abes.fr/sudoc/formats/loc/zones/999. > htm#UtilisationActuelle > > M. Saby It could but that would be dangerous of them, because 999 is used for Koha specific data, and merging them makes no sense, you cant have a record that has 2 biblionumbers that would break things badly. Maybe you could send a follow up patch that doesn't exclude 999 if the flavour is UNIMARC. This is still a major improvement though, and makes it much less likely for the merge to create an invalid record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:12:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:12:15 +0000 Subject: [Koha-bugs] [Bug 10369] New: Added Sort1 in circulation page Message-ID: <bug-10369-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10369 Bug ID: 10369 Summary: Added Sort1 in circulation page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: amit.gupta at osslabs.biz CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Added Sort1 in circulation page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:12:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:12:33 +0000 Subject: [Koha-bugs] [Bug 10368] Added price in overdue report In-Reply-To: <bug-10368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10368-70-z5xakSxB6F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10368 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |amit.gupta at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:12:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:12:54 +0000 Subject: [Koha-bugs] [Bug 10369] Added Sort1 in circulation page In-Reply-To: <bug-10369-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10369-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10369-70-aOIP42tMXr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10369 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |amit.gupta at osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:32:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:32:55 +0000 Subject: [Koha-bugs] [Bug 10370] New: Adding Callno barcode on circulation print page Message-ID: <bug-10370-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10370 Bug ID: 10370 Summary: Adding Callno barcode on circulation print page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: amit.gupta at osslabs.biz CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Adding Callno barcode on circulation print page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:33:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:33:08 +0000 Subject: [Koha-bugs] [Bug 10370] Adding Callno barcode on circulation print page In-Reply-To: <bug-10370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10370-70-8nfpWiym4D@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10370 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |amit.gupta at osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:33:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:33:28 +0000 Subject: [Koha-bugs] [Bug 10370] Adding Callno barcode on circulation print page In-Reply-To: <bug-10370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10370-70-R62vUAi1ps@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10370 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:33:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:33:45 +0000 Subject: [Koha-bugs] [Bug 10369] Added Sort1 in circulation page In-Reply-To: <bug-10369-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10369-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10369-70-bdZOeT33Cx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10369 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:34:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:34:14 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-P4SgMHyGBX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #16 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- OK, so the solution could probably be - exclude merge of 999 for MARC21 / NORMARC - exclude merge of 090 for UNIMARC Am I right? For the 995, as you said, it is no more in main marc record, so I suppose we could drop the exclusion of 995. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:34:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:34:17 +0000 Subject: [Koha-bugs] [Bug 10368] Added price in overdue report In-Reply-To: <bug-10368-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10368-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10368-70-GMVwklGBt4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10368 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:40:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:40:11 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-bTMxdffeXs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #21 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: 1/ There is no unit tests for new subroutines introduced in C4::Charset and C4::AuthoritiesMarc packages. 2/ There is no call to C4::Charset::SanitizeEntity, where it is used? 3/ The C4::AuthoritiesMarc::_process_subfcode_4_merge checks if a string exists: q{S'emploie uniquement en subdivision chronologique} but there is no comment to explain what is it. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:41:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:41:49 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-rr2If6D1Gk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #17 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #16) > OK, so the solution could probably be > - exclude merge of 999 for MARC21 / NORMARC > - exclude merge of 090 for UNIMARC > > Am I right? > > For the 995, as you said, it is no more in main marc record, so I suppose we > could drop the exclusion of 995. > > M. Saby Yep I'd wait for this improvement to be pushed, then open a new bug to do that follow up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:42:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:42:05 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-ZAPQKIqPWU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #22 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18450 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18450&action=edit Bug 8304: UT for new subroutines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:42:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:42:34 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-KXHIfCDbqm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 --- Comment #23 from Jonathan Druart <jonathan.druart at biblibre.com> --- 3 unit tests in t/Charset do not pass, I think there is a bug in C4::Charset::SanitizeEntity. I cannot provide unit tests for the C4::AuthoritiesMarc::_process_subfcode_4_merge routine, I don't understand what it does. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:57:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:57:43 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-yjTp6ABWDh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10298 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 10:57:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 08:57:43 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10298-70-mYJMhd1kBv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8304 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:04:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:04:32 +0000 Subject: [Koha-bugs] [Bug 10359] CCSR theme should apply jqTransform after OpacUserJS In-Reply-To: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10359-70-USv8SjroUP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: Just move a js line some lines before. No regression possible. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:04:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:04:45 +0000 Subject: [Koha-bugs] [Bug 10359] CCSR theme should apply jqTransform after OpacUserJS In-Reply-To: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10359-70-GPSymk7Pnc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18440|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18451 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18451&action=edit Bug 10359: transform masthead dropdown after user JS for CCSR Since libraries may want to customize the options in the masthead search dropdown, which is done via dropdown, it would be better if the select box were transformed *after* user javascript was run. To test: 1) Switch to the CCSR OPAC theme. 2) Add some Javascript to your OpacUserJS that will modify the masthead search dropdown, such as: $("select[name='idx']").append("<option value='Host-item,wrdl'>Journal title</option>"); 3) Note that when you view the OPAC, the results in the dropdown are unchanged. 4) Apply patch. 5) Note that your new option now shows up. 6) Sign off. Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:21:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:21:58 +0000 Subject: [Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English In-Reply-To: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10292-70-rWE1BwjBBu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch Assignee|oleonard at myacpl.org |gmcharlt at gmail.com QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: This patch fixes a bug and improves the code. No regression found. Thanks for unit tests! Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:22:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:22:28 +0000 Subject: [Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English In-Reply-To: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10292-70-xIttIic4Be@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18442|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18452 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18452&action=edit bug 10292: improve fallback logic for picking XSLT This patch fixes a bug whereby XSLT files from the prog theme would be used (for English OPACs and staff interfaces) even if the user had created and enabled a custom theme that provided override XSLT files. This patch provides a clearer implementation of the fallback logic and adds test cases. To reproduce the bug: [1] Set OPACXSLTDetailsDisplay to 'default' and English as the OPAC language. [2] Create a new OPAC theme, including copying the XSLT files. [3] Set opactheme to the new theme. [4] Make a change to koha-tmpl/opac-tmpl/NEWTHEME/en/xslt/MARC21slim2OPACDetail.xsl [5] View a bib record in the OPAC. The change made in the previous step is not reflected. To test after applying the patch: [6] Reload the bib record in the OPAC. The change made in step 4 should now be reflected. [7] (To be thorough) Go through the test plan for bug 8947 and verify that there is no regression. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:24:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:24:56 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9902-70-BUsjJzx0PX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This couldn't be pushed, because it caused another bug on 10088. I would like to see this solved with a patch for 3.10 specifically and the patch being signed off also making sure the problem from 10088 doesn't occur. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:36:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:36:44 +0000 Subject: [Koha-bugs] [Bug 9773] Replace YUI AJAX calls in cataloging plugins with jQuery In-Reply-To: <bug-9773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9773-70-obi0Q4f3Fm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: This patch replaces the YUI AJAX stuff with jQuery. It is a more readable and adds a new step to get rid of YUI. There is no more occurrence of 'YAHOO' in the cataloguing/value_builder directory. I tested the unimarc plugin and it works like as before. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:37:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:37:46 +0000 Subject: [Koha-bugs] [Bug 9773] Replace YUI AJAX calls in cataloging plugins with jQuery In-Reply-To: <bug-9773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9773-70-JNmk8v8iL7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18444|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18453&action=edit Bug 9773 - Replace YUI AJAX calls in cataloging plugins with jQuery Several cataloging plugins make some simple AJAX GET calls via the YUI AJAX feature. This code can be easily converted to jQuery. To test, link each plugin to the relelvant field by editing your MARC stucture. Confirm that functionality is unchanged. For callnumber.pl and callnumber-KU.pl, test by linking to 952o. callnumber.pl is triggered on blur of (when you focus on and click away from) the 952o entry field. callnumber-KU.pl is triggered by clicking the "..." link. stocknumberam123.pl should be linked to 952i. If your data doesn't already have information stored for inventory number, modify at least one record to add one. The plugin is triggered on blur of the 952i field. It should increment the highest value inventory number stored in your system. unimarc_field_010.pl is UNIMARC-specific, so I'm guessing about its functionality. I tested it by linking the plugin to MARC21 field 020a. The plugin is triggered on blur of the affected field (020a in my test). You can confirm that the plugin returns valid data by using a tool like Firebug to view the XHR response. Or if you're not using UNIMARC you can hack the plugin to update a different field instead (line 57, /^tag_210_subfield_c/ ). I tried "245_subfield_c" instead of "210c_subfield_c." Nonsensical, but useful for testing. Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> Tried the 3 MARC21 plugins. Did not try the Unimarc one, but it's exactly the same code change. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:41:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:41:40 +0000 Subject: [Koha-bugs] [Bug 10191] 2 option tags are not closed in unimarc_field_115a.tt and unimarc_field_116.tt In-Reply-To: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10191-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10191-70-ByBr7vaOwo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10191 Chris Hall <chrish at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #7 from Chris Hall <chrish at catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:41:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:41:47 +0000 Subject: [Koha-bugs] [Bug 10186] Typo in subscription-add.tt (years vs year) In-Reply-To: <bug-10186-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10186-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10186-70-LNLCsQPdy6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10186 Chris Hall <chrish at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #9 from Chris Hall <chrish at catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.14. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:45:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:45:09 +0000 Subject: [Koha-bugs] [Bug 10371] New: Show item status in cart list Message-ID: <bug-10371-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10371 Bug ID: 10371 Summary: Show item status in cart list Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: amit.gupta at osslabs.biz Show item status in cart list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:45:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:45:24 +0000 Subject: [Koha-bugs] [Bug 10371] Show item status in cart list In-Reply-To: <bug-10371-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10371-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10371-70-DhTGfeHAU3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10371 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Assignee|oleonard at myacpl.org |amit.gupta at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:48:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:48:18 +0000 Subject: [Koha-bugs] [Bug 10371] Show item status in cart list In-Reply-To: <bug-10371-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10371-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10371-70-vPP39MatuZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10371 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:48:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:48:27 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9902-70-ZEvWCHqn0d@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 --- Comment #18 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18454&action=edit Bug 9902 - item subfields not populating Test Plan: 1) Create a new serial with a default location, call number, and library ( the library will need to be any but the one you are logged in as ) 2) Click the "Recieve" button for this serial 3) Click "Click to add item" 4) Note those values are not populated 5) Apply the patch 6) Reload the page 7) Click "Click to add item" 8) Note those values are now populated Signed-off-by: Nicole C. Engard <nengard at bywatersolutions.com> All tests pass! Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> This seems to restore the former behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:49:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:49:45 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9902-70-Gv84Yn5ZjG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17114|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:50:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:50:07 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9902-70-UahVT5MvwX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17257|[PASSED QA] Bug 9902 - item |[PUSHED 3.12&master][PASSED description|subfields not populating |QA] Bug 9902 - item | |subfields not populating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:50:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:50:21 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9902-70-o46rjMe7qt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18454|Bug 9902 - item subfields |[3.10.X] Bug 9902 - item description|not populating |subfields not populating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:52:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:52:15 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9902-70-iCPbqlPNE3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Jonathan, did you see my comment 17? Bit worried about the problems with bug 10088. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:52:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:52:28 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9902-70-qkLAMehuR3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |jonathan.druart at biblibre.co | |m See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10088 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:52:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:52:28 +0000 Subject: [Koha-bugs] [Bug 10088] software error when filling a basket with staged record In-Reply-To: <bug-10088-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10088-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10088-70-lKYWVBY1Gg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10088 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9902 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:53:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:53:04 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10178-70-mVQ2w6RoPZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Chris Hall <chrish at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz --- Comment #12 from Chris Hall <chrish at catalyst.net.nz> --- A quick look through this patch shows that it seems to be applicable for 3.8.x, however the patch in its current form does not apply cleanly. It is possible for you to rebase and submit a version for 3.8.x? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 11:55:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 09:55:27 +0000 Subject: [Koha-bugs] [Bug 9902] item subfields not populating In-Reply-To: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9902-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9902-70-wZ6oT02bNk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9902 --- Comment #20 from Jonathan Druart <jonathan.druart at biblibre.com> --- Nicole, I submit a patch for the 3.10 branch. Could you test it please? Patch for 10088 has to be applied too! @Katrin, No I did not see your comment before submitting the patch, sorry :-/ But if 2 patches are pushed together, I expect not to have problem. Don't you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 12:15:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 10:15:25 +0000 Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management In-Reply-To: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8304-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8304-70-aZjJSFt5n6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #24 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I don't know what _process_subfcode_4_merge does, but it is only dealing with some fields (600, 606, 607, 700, 701, 710, 711, 712). Maybe it should deal other subject fields (like 604, 605, 608, 616) ? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 12:15:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 10:15:36 +0000 Subject: [Koha-bugs] [Bug 10372] New: SIP2- Ability to use both userid and cardnumber Message-ID: <bug-10372-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10372 Bug ID: 10372 Summary: SIP2- Ability to use both userid and cardnumber Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: amit.gupta at osslabs.biz CC: colin.campbell at ptfs-europe.com SIP2- Ability to use both userid and cardnumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 12:15:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 10:15:49 +0000 Subject: [Koha-bugs] [Bug 10372] SIP2- Ability to use both userid and cardnumber In-Reply-To: <bug-10372-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10372-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10372-70-R7S0Cu602v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10372 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m Assignee|koha-bugs at lists.koha-commun |amit.gupta at osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 12:16:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 10:16:21 +0000 Subject: [Koha-bugs] [Bug 10373] New: Added sort1 and sort2 in overdue report Message-ID: <bug-10373-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10373 Bug ID: 10373 Summary: Added sort1 and sort2 in overdue report Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: amit.gupta at osslabs.biz Added sort1 and sort2 in overdue report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 12:16:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 10:16:32 +0000 Subject: [Koha-bugs] [Bug 10373] Added sort1 and sort2 in overdue report In-Reply-To: <bug-10373-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10373-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10373-70-qLO7IUyC7B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10373 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 12:16:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 10:16:39 +0000 Subject: [Koha-bugs] [Bug 10373] Added sort1 and sort2 in overdue report In-Reply-To: <bug-10373-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10373-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10373-70-yOFHs3zQ92@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10373 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |amit.gupta at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 12:19:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 10:19:46 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-G2UcqlllLx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16373|0 |1 is obsolete| | Attachment #16374|0 |1 is obsolete| | Attachment #16409|0 |1 is obsolete| | Attachment #16457|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18455&action=edit Bug 7162: Factorize code for order cancellation Some code was duplicated, all is now in cancelorder.pl Added possibility to provide a reason for cancellation (or other things, this is saved in aqorders.notes) Signed-off-by: Corinne Bulac <corinne.hayet at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 12:19:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 10:19:53 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-4570QN16lr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 --- Comment #34 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18456&action=edit Bug 7162 [Follow-up] Fix referrer URL when coming from parcel.pl Signed-off-by: Corinne Bulac <corinne.hayet at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 12:20:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 10:20:51 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7162-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7162-70-pWyuxq8r4h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #35 from Jonathan Druart <jonathan.druart at biblibre.com> --- Rebased patches (the second one is become useless). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 12:24:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 10:24:20 +0000 Subject: [Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface In-Reply-To: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10083-70-tNuKyXJapa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 --- Comment #10 from Gaetan Boisson <gaetan.boisson at biblibre.com> --- Created attachment 18457 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18457&action=edit [SIGNED OFF] Bug 10083 [3.10.x] In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl. Signed-off-by: Gaetan Boisson <gaetan.boisson at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 12:27:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 10:27:23 +0000 Subject: [Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface In-Reply-To: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10083-70-Jl90fLHWd1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Gaetan Boisson <gaetan.boisson at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |gaetan.boisson at biblibre.com --- Comment #11 from Gaetan Boisson <gaetan.boisson at biblibre.com> --- On a 3.10 instance, before applying the patch, the string "In transit from" is found only once in the French po file (for request.pl). After applying the patch and running updating the French po file, the string is found twice, once for request.pl and once for detail.pl. Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 12:28:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 10:28:53 +0000 Subject: [Koha-bugs] [Bug 9763] Add callnumber column to "print summary" for moremember.pl In-Reply-To: <bug-9763-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9763-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9763-70-2SX2rC6IlL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9763 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: This patch adds a new column to the 'print summary' page. Simple patch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 12:29:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 10:29:09 +0000 Subject: [Koha-bugs] [Bug 9763] Add callnumber column to "print summary" for moremember.pl In-Reply-To: <bug-9763-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9763-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9763-70-aYWBDFjb0l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9763 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15956|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18458&action=edit Bug 9763 - Add callnumber column to "print summary" for moremember.pl Test plan: 1) Apply patch 2) Check out some items to a borrower 3) Choose "Print summary" from the "Print" pulldown 4) Observe the new callnumber column after "Author" and before "Item type" 5) Note that the totals in the footer are still aligned correctly Signed-off-by: Eli Anthony <library.assist at taylorcountygov.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 13:17:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 11:17:04 +0000 Subject: [Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface In-Reply-To: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10083-70-gyIjx6Db59@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: I confirm the proposed patch works for 3.10 branch. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 13:17:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 11:17:24 +0000 Subject: [Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface In-Reply-To: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10083-70-950Z1XQ3hl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18169|0 |1 is obsolete| | Attachment #18457|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18459&action=edit Bug 10083 [3.10.x] In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl. Signed-off-by: Gaetan Boisson <gaetan.boisson at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 13:25:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 11:25:01 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-BiyZzr8bDX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: # cat /etc/debian_version 7.0 # aptitude search tinymce p python-django-tinymce - replacement text widget for Django web framework p tinymce - platform independent web based Javascript/HTML WYSIWYG editor # aptitude search libfile-slurp-perl i A libfile-slurp-perl - single call read & write file routines # aptitude search libtest-www-mechanize-perl i A libtest-www-mechanize-perl # git grep tinymce2 returns no result. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 13:25:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 11:25:17 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-zYyZ6qZVNl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18449|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18460 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18460&action=edit Bug 10367 - update the rules and control file for wheezy This updates the control file to use tinymce rather than tinymce2, as tinymce2 is deprecated and no longer in Debian. Also a general dependencies update. Note that this is suitable for master only. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 13:27:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 11:27:42 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-8LKEd3OIIz@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 --- Comment #15 from Kyle M Hall <kyle.m.hall at gmail.com> --- > First we'll have to figure out what we want _GetCircControlBranch to do. > However, it might be as simple as passing it an optional issues hash so that > it handle the special PickupLibrary case for loans. So, _GetCircControlBranch returns the following: * If CircControl is set to "PickupLibrary", it returns the currently logged in library branchcode. * If CircControl is set to 'PatronLibrary', it returns the patron's home library branchcode * If CircControl is set to 'ItemHomeLibrary', it uses the system preference HomeOrHoldingBranch to return either the item's homebranch or its holdingbranch. So _GetCircControlBranch is actually a bit more configurable than the other code ( it behaves exactly the same except it can use either the hold or the holding branch ). In addition, if CircControl is set to ItemHomeLibrary and HomeOrHoldingBranch is set to "Holding branch" we will get very unexpected behavior for some items, as we will have some code using the item's holding branch, and some of the code using the item's home branch for circulation rule purposes. So, for _GetCircControlBranch, if we add $issue to the parameters list, and returned the branchcode of the issuing library in cases where a) CircControl is set to 'ItemHomeLibrary' and b) $issue is not undefined, I think everything will be good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 13:39:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 11:39:11 +0000 Subject: [Koha-bugs] [Bug 6709] marc21_field_006.xml and marc21_field_008.xml can't be translated. In-Reply-To: <bug-6709-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6709-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6709-70-P0D7V8Dnxu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6709 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10178 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 13:39:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 11:39:11 +0000 Subject: [Koha-bugs] [Bug 10178] Typos in plugins for 006 and 008 in MARC21 In-Reply-To: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10178-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10178-70-HRhGaqnyQ6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10178 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6709 --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Chris, to apply this you need first Bug 6709 (and one more at least, read the final comments). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 13:44:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 11:44:32 +0000 Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data In-Reply-To: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9836-70-elMFi7SYNu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18426|0 |1 is obsolete| | --- Comment #11 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 18461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18461&action=edit Bug 9836 Filtering sort1 list according to patron category in patron data Hello Jean-Manuel really sorry, my fault : I squeezed 2 lines of updatedatabase.pl when rebasing Olivier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:14:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:14:05 +0000 Subject: [Koha-bugs] [Bug 10374] New: Clean up and unify CircControl related code Message-ID: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Bug ID: 10374 Summary: Clean up and unify CircControl related code Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: kyle.m.hall at gmail.com As discussed in bug 10262, code related to the CircControl should be unified under C4::Circulation::GetCircControlBranch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:14:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:14:10 +0000 Subject: [Koha-bugs] [Bug 10374] Clean up and unify CircControl related code In-Reply-To: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10374-70-aca2ZOBvyQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:14:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:14:33 +0000 Subject: [Koha-bugs] [Bug 10374] Clean up and unify CircControl related code In-Reply-To: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10374-70-SPZoSS6t8i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10262 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:14:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:14:33 +0000 Subject: [Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl In-Reply-To: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10262-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10262-70-dymNVYgg4v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10374 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:16:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:16:47 +0000 Subject: [Koha-bugs] [Bug 10374] Clean up and unify CircControl related code In-Reply-To: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10374-70-H3mSMwxN9g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:16:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:16:48 +0000 Subject: [Koha-bugs] [Bug 10374] Clean up and unify CircControl related code In-Reply-To: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10374-70-g5idsoPc3A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18462 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18462&action=edit Bug 10374 - Clean up and unify CircControl related code As discussed in bug 10262, code related to the CircControl should be unified under C4::Circulation::GetCircControlBranch. Test Plan: 1) Apply this patch 2) Find some overdue items 2) Test the different settings for CircControl setting the system preference, returning an item, and verifying the correct rule was used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:16:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:16:57 +0000 Subject: [Koha-bugs] [Bug 10374] Clean up and unify CircControl related code In-Reply-To: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10374-70-1XoIO9Nh8O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:17:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:17:24 +0000 Subject: [Koha-bugs] [Bug 10375] New: add a tool to Koha, to check for zebra problems Message-ID: <bug-10375-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10375 Bug ID: 10375 Summary: add a tool to Koha, to check for zebra problems Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: mtj at kohaaloha.com this bug will track a tool that checks for zebra problems patch coming... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:21:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:21:38 +0000 Subject: [Koha-bugs] [Bug 9991] De-duplicate "no cover image available" (currently in lieu of prioritizing cover image sources) In-Reply-To: <bug-9991-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9991-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9991-70-B74A1zLLw2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9991 Serhij Dubyk <dubyk at library.lviv.ua> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk at library.lviv.ua -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:25:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:25:50 +0000 Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data In-Reply-To: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9836-70-hrLcruqCoI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 --- Comment #12 from jmbroust <jean-manuel.broust at univ-lyon2.fr> --- Applying: Bug 9836 Filtering sort1 list according to patron category in patron data Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging admin/authorised_values.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Auto-merging members/memberentry.pl Failed to merge in the changes. Patch failed at 0001 Bug 9836 Filtering sort1 list according to patron category in patron data When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 9836 - Filtering sort1 list according to patron category in patron data -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:26:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:26:11 +0000 Subject: [Koha-bugs] [Bug 10376] New: Printing cart does not work under IE9 Message-ID: <bug-10376-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 Bug ID: 10376 Summary: Printing cart does not work under IE9 Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Browser compatibility Assignee: oleonard at myacpl.org Reporter: m.de.rooy at rijksmuseum.nl This problem may be older than IE9; I do not know. Cannot check that for now. Since many patrons have IE9, it would be nice if they could print the contents of the cart on opac. Somehow this does not work now. See discussions like http://stackoverflow.com/questions/2555697/window-print-not-working-in-ie?rq=1 The proposed patch adds some code for IE. Works with setting a small timeout, calling window.print instead of print, and changing location on receiving focus back. Note that this last trick is also browser dependent. I do not favor browser dependent code, but at least we reach the goal of enabling the print function again for IE users.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:32:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:32:53 +0000 Subject: [Koha-bugs] [Bug 10374] Clean up and unify CircControl related code In-Reply-To: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10374-70-QwmqCIY9XV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18462|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18463 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18463&action=edit Bug 10374 - Clean up and unify CircControl related code As discussed in bug 10262, code related to the CircControl should be unified under C4::Circulation::GetCircControlBranch. Test Plan: 1) Apply this patch 2) Run perl t/db_dependent/Circulation.t 3) All tests should pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:34:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:34:05 +0000 Subject: [Koha-bugs] [Bug 10376] Printing cart does not work under IE9 In-Reply-To: <bug-10376-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10376-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10376-70-XS9NgrVsPe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:34:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:34:06 +0000 Subject: [Koha-bugs] [Bug 10376] Printing cart does not work under IE9 In-Reply-To: <bug-10376-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10376-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10376-70-Sr4wU0sg2y@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 --- Comment #1 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18464&action=edit Bug 10376: Printing cart does not work under IE9 Test plan: 1) Test with Firefox (or any other browser except IE): Add biblio to cart Go to Cart and click Print Does the Cart window come back to its original state after confirm/cancel Print? 2) Test with Internet Explorer (I used IE9; testing another version is fine) Do the same as above. Is behavior now more or less the same? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 14:34:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 12:34:27 +0000 Subject: [Koha-bugs] [Bug 10376] Printing cart does not work under IE9 In-Reply-To: <bug-10376-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10376-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10376-70-w6VzCyhjpF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|oleonard at myacpl.org |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 15:03:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 13:03:04 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-lsSsYHYSSm@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #27 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: It's a great patch Kyle, well done! I found some problems while testing your patch, I will provide a followup. I tested some use cases but not all. It would be good if this patch is QAed by someone else from the QA team (in order to have another pair of eyes on this patch). Having this patch into master asap would permit to have a lot of testers. I think it is better than blocking this patch any longer. Marked as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 15:03:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 13:03:53 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-u2dZ5d82FQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18318|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18465&action=edit Bug 9394 - Use reserve_id where possible This patch switches from using a combination of biblionumber/borrowernumber to using reserve_id where possible. Test Plan: 1) Apply patch 2) Run t/db_dependent/Holds.t Signed-off-by: Maxime Pelletier <maxime.pelletier at libeo.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 15:04:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 13:04:00 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-Tu9kJTQfyk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #29 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18466&action=edit Bug 9394: QA Followup * C4::Reserves::_FixPriority - The previous code checked the cancellationdate. If think you never pass in it with bad parameters, but in order to be sure I added the check on this value. - The reservedates array was never used. * circ/circulation.tt There was a bug: it was not possible to remove an hold from the circulation page. Passing reserve_id fixes the issue. * C4::Reserves::GetReserveId This subroutine did not have a unit test. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 15:06:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 13:06:09 +0000 Subject: [Koha-bugs] [Bug 5696] Hold deletion should use reservenumber In-Reply-To: <bug-5696-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5696-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5696-70-G7tT7cdB2a@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5696 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- *** This bug has been marked as a duplicate of bug 9394 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 15:06:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 13:06:09 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-0tbAtrVkZA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #30 from Jonathan Druart <jonathan.druart at biblibre.com> --- *** Bug 5696 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 15:13:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 13:13:19 +0000 Subject: [Koha-bugs] [Bug 10374] Clean up and unify CircControl related code In-Reply-To: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10374-70-fjPcjUBndB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18467 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18467&action=edit Bug 10374 - Clean up and unify CircControl related code - Followup - Clean up AddReturn This patch tidys up C4::Circulation::AddReturn. It rearranges some comments to make them more sensible, and addresses the FIXME for an unitelligable comment. This patch makes no functional changes to the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 15:14:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 13:14:40 +0000 Subject: [Koha-bugs] [Bug 10374] Clean up and unify CircControl related code In-Reply-To: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10374-70-PdkNNPsG4w@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18467|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18468 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18468&action=edit Bug 10374 - Clean up and unify CircControl related code - Followup - Clean up AddReturn This patch tidys up C4::Circulation::AddReturn. It rearranges some comments to make them more sensible, and addresses the FIXME for an unitelligable comment. This patch makes no functional changes to the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 15:16:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 13:16:00 +0000 Subject: [Koha-bugs] [Bug 10374] Clean up and unify CircControl related code In-Reply-To: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10374-70-LPYUIP8Is7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18468|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18469 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18469&action=edit Bug 10374 - Clean up and unify CircControl related code - Followup - Clean up AddReturn This patch tidys up C4::Circulation::AddReturn. It rearranges some comments to make them more sensible, and addresses the FIXME for an unitelligable comment. This patch makes no functional changes to the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 15:18:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 13:18:55 +0000 Subject: [Koha-bugs] [Bug 10374] Clean up and unify CircControl related code In-Reply-To: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10374-70-ZvT3xg8UZT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18469|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18470&action=edit Bug 10374 - Clean up and unify CircControl related code - Followup - Clean up AddReturn This patch tidys up C4::Circulation::AddReturn. It rearranges some comments to make them more sensible, and addresses the FIXME for an unitelligable comment. This patch makes no functional changes to the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 15:23:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 13:23:58 +0000 Subject: [Koha-bugs] [Bug 10374] Clean up and unify CircControl related code In-Reply-To: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10374-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10374-70-oaoo6GmVXH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10374 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18470|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18471&action=edit Bug 10374 - Clean up and unify CircControl related code - Followup - Clean up AddReturn This patch tidys up C4::Circulation::AddReturn. It rearranges some comments to make them more sensible, and addresses the FIXME for an unitelligable comment. This patch makes no functional changes to the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 15:26:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 13:26:37 +0000 Subject: [Koha-bugs] [Bug 10377] New: fix_unimarc_100 could be improved with 210$d values Message-ID: <bug-10377-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10377 Bug ID: 10377 Summary: fix_unimarc_100 could be improved with 210$d values Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: paul.poulain at biblibre.com The misc/migration_tools/rebuild_zebra.pl script includes a fix_unimarc_100 sub. This sub rewrites 100 field in case it has an invalid length. However, the copyright dates, that are stored in 210$d are also in 100, positions 9-12 Koha could try to retrieve the 210$d values in case the 100 must be rebuilt because it's wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 15:39:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 13:39:02 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5349-70-hUlywRrw4P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #61 from Jonathan Druart <jonathan.druart at biblibre.com> --- Julian, Could you add a unit test for the new subroutine (C4::Acquisition::TransferOrder) please ? Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 15:56:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 13:56:03 +0000 Subject: [Koha-bugs] [Bug 7498] Cloning a budget, enable change of description In-Reply-To: <bug-7498-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7498-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7498-70-sWpyXciiR5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7498 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|koha.sekjal at gmail.com | --- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: All look good. I have just a little remark: after click on 'duplicate', the description field is prefilled with the original description's budget. But if the user does not change it, nothing append (no error and no creation). It would be good if a message appears (JS on submitting or after reloading the page ). Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 16:01:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 14:01:45 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: <bug-10366-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10366-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10366-70-SR5EDK1eDu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 16:01:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 14:01:46 +0000 Subject: [Koha-bugs] [Bug 10366] Alert librarian if an invoice number is duplicated In-Reply-To: <bug-10366-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10366-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10366-70-HN5qONExvD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10366 --- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18472&action=edit Bug 10366: Alert librarian if an invoice number is duplicated Some vendors ship materials from the same invoice in multiple packages. In those cases, it would be good to notify the librarian when they enter a duplicate invoice number, so that they can continue receiving on the previously-created invoice, rather than creating an invoice with a duplicate number. To test: 1) Apply patch and run database update. 2) Make sure that you have created at least one invoice on acqui/parcels.pl and take note of the invoice number. 3) Try to create an invoice with the same invoice number. 4) Note that without changing your configuration this works exactly the same as before. 5) Turn on the AcqWarnOnDuplicateInvoice system preference. 6) Try to create a new invoice with the same number as the one you noted earlier. 7) Make sure you get a warning about a duplicate invoice. 8) Choose to receive on the existing invoice. 9) Confirm that you are receiving on said existing invoice. 10) Start the receiving process over, and this time choose "Create new invoice anyway." 11) Confirm that you are now receiving on a new invoice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 16:08:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 14:08:54 +0000 Subject: [Koha-bugs] [Bug 10377] fix_unimarc_100 could be improved with 210$d values In-Reply-To: <bug-10377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10377-70-Ua04j2zkRJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10377 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |januszop at gmail.com --- Comment #1 from Janusz Kaczmarek <januszop at gmail.com> --- Or I would suggest to consider keeping (transferring to the new 100$a) bytes 100$a/08 and 100$a/09-12, if 100$a/08 contains a meaningful code for the date and 100$a/09-12 looks like a date (i.e. 4 digits, forming a number greater or equal than, say, 1455 and lesser or equal the current year). What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 16:34:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 14:34:12 +0000 Subject: [Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes In-Reply-To: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10343-70-YLFluohExq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18415|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18473&action=edit Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes As QA followup on report 9722. Built on top of another followup report 10321. Test plan: Run the db revision included in the other patch. Enable OpacHoldNotes. Check that you can add a hold note on opac-reserve. Do you see it on opac-user and in staff on catalog detail of that biblio? Do a grep on ShowHoldNotes on the Koha code: grep -i ignores case. You should find three occurrences only in updatedatabase.pl (the old dbrev and this dbrev renaming them). These are fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 16:34:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 14:34:28 +0000 Subject: [Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes In-Reply-To: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10343-70-NimCGG5sW7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18473|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18474&action=edit Bug 10343: dbrev for rename OpacShowHoldNotes to OpacHoldNotes Renames the pref for install and upgrade. Test plan: See the other patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 16:34:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 14:34:32 +0000 Subject: [Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes In-Reply-To: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10343-70-T5fGUpoq3Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 --- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18475&action=edit Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes As QA followup on report 9722. Built on top of another followup report 10321. Test plan: Run the db revision included in the other patch. Enable OpacHoldNotes. Check that you can add a hold note on opac-reserve. Do you see it on opac-user and in staff on catalog detail of that biblio? Do a grep on ShowHoldNotes on the Koha code: grep -i ignores case. You should find three occurrences only in updatedatabase.pl (the old dbrev and this dbrev renaming them). These are fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 16:36:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 14:36:31 +0000 Subject: [Koha-bugs] [Bug 10343] Rename OpacShowHoldNotes to OpacHoldNotes In-Reply-To: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10343-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10343-70-ThxEA7Q0gs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10343 --- Comment #6 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Separated the dbrev from the other changes. A merge conflict on the dbrev patch should not be hard to resolve :) Please test them on top of bug 10321. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 16:36:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 14:36:41 +0000 Subject: [Koha-bugs] [Bug 10377] fix_unimarc_100 could be improved with 210$d values In-Reply-To: <bug-10377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10377-70-GEQ5eMJEWj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10377 --- Comment #2 from Paul Poulain <paul.poulain at biblibre.com> --- I agree with the idea of keeping the value if it's meaningful. What does meaningful mean though ? I would say "keep 9-12" if they contain only 4 numbers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 16:40:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 14:40:27 +0000 Subject: [Koha-bugs] [Bug 10292] XSLT files always taken from 'prog' theme for English In-Reply-To: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10292-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10292-70-oGLLvyx21N@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10292 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 16:46:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 14:46:58 +0000 Subject: [Koha-bugs] [Bug 10359] CCSR theme should apply jqTransform after OpacUserJS In-Reply-To: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10359-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10359-70-TWJrblSpPI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10359 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Jared! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 16:51:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 14:51:23 +0000 Subject: [Koha-bugs] [Bug 9763] Add callnumber column to "print summary" for moremember.pl In-Reply-To: <bug-9763-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9763-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9763-70-mUUEFGDRms@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9763 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 17:05:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 15:05:18 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-FhadRdvADo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt at gmail.com --- Comment #18 from Galen Charlton <gmcharlt at gmail.com> --- Couple comments: - Please rename the 'Koha::Record' class; as it is, the name is too generic. After all, Koha has lots of record types, many of which are not MARC. I suggest either 'Koha::MARC::Record' (following MARC::Record) or perhaps 'Koha::Metadata::MARC' (allowing for Koha::Metadata::MODS, etc.) or 'Koha::Util::MARC'. - I think references to the 999 and 955 tags would be better handled by looking up the tag that the MARC framework uses to store biblio.biblionumber rather than using magic numbers. Setting back to in discussion, as I do not intend to push this until (at least) the class has a better name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 17:10:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 15:10:03 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-VAimXZYVeY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Robin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 17:12:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 15:12:31 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-6UBah3eO8B@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #19 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #18) > - I think references to the 999 and 955 tags would be better handled by > looking up the tag that the MARC framework uses to store biblio.biblionumber > rather than using magic numbers. I fully agree with this ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 17:18:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 15:18:00 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-z0XnoRGIr0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 --- Comment #7 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #3) > A quick bit of testing illustrated that tinymce, which is version 3, works > just as well as tinymce2. Koha as a whole should probably switch. Upon checking, Koha already has. Bug 9172, in addition to moving TinyMCE out of its language-specific directory, bumped up the version bundled with Koha to 3.5.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 17:43:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 15:43:58 +0000 Subject: [Koha-bugs] [Bug 9773] Replace YUI AJAX calls in cataloging plugins with jQuery In-Reply-To: <bug-9773-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9773-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9773-70-DovY36ko3O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9773 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 18:00:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 16:00:39 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-YucV7YDgzH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #26 from Galen Charlton <gmcharlt at gmail.com> --- The patches do not apply. The base patch needs to be rebased to take 065fe316e into account, while the tooltip patch needs to be adjusted now that 7e10f6fb was pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 18:25:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 16:25:40 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10218-70-csReMBh7kA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #8 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #7) > Galen, I never really understood that : must or must not a followup for a > patch already pushed in master be attached to a new bug ? > From a discussion under an other bug, I believe it is a good practice? Well, the original bug description didn't specify that it was a MARC21-only bug. The perfect patch for this bug would have handled all of the MARC flavors that are currently supported, but as that didn't happen, I chose to leave the bug open. More broadly: unless a bug is truly specific to a particular MARC format, IMO we should aim for *complete* patches. However, this is a preference, not a requirement. If you prefer to open a new bug, you are free to do so. If you do that, please link it to this one via a dependency or a comment citing the new bug number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 18:26:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 16:26:51 +0000 Subject: [Koha-bugs] [Bug 2559] Language limit on Spanish returns Russian records or is it English ... In-Reply-To: <bug-2559-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-2559-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2559-70-btAb3zzOqb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2559 --- Comment #3 from Nicole C. Engard <nengard at gmail.com> --- Yes, it's still valid in Marc21 libraries. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 18:27:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 16:27:32 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-OMbBnJ3kE6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #31 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #30) > Galen, if you feel strongly this is the way to go, I will do it that way. > I'm fully invested in making Koha the best ILS it can be! Thanks, I will await your revised patch with pleasure. > Also, as far as the fines logic goes, for this I will do whatever is > necessary to make it function, but I'm still preparing a full-rewrite of the > accounts system, so I'll probably just shore this up with the minimum amount > of code, as the rewrite will replace it eventually. That's OK. Speaking of the fines write, have you put together a plan for it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 18:27:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 16:27:41 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-DwFnOmjm3V@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 18:42:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 16:42:43 +0000 Subject: [Koha-bugs] [Bug 10378] New: Enable checked out items to be transferred without returning them Message-ID: <bug-10378-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10378 Bug ID: 10378 Summary: Enable checked out items to be transferred without returning them Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kyle.m.hall at gmail.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When items are transferred, they are automatically returned to the transferred-from library. Some libraries would like to be able to use the transfer system without automatically returning the item and having it removed from the patron record. Scenario: LibraryA of multi-library system is checking in items from the overnight dropbox. The librarian pulls out a damaged item, but it is an item owned and checked out from LibraryB. Instead of removing the item from the patrons checked out items, the library would like to transfer the item, still checked out, back to LibraryB so that LibraryB may decide how to deal with the damaged item. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 18:47:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 16:47:28 +0000 Subject: [Koha-bugs] [Bug 10378] Enable checked out items to be transferred without returning them In-Reply-To: <bug-10378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10378-70-1utT5D2qtJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10378 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18476 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18476&action=edit Bug 10378 - Enable checked out items to be transferred without returning them When items are transferred, they are automatically returned to the transferred-from library. Some libraries would like to be able to use the transfer system without automatically returning the item and having it removed from the patron record. Scenario: LibraryA of multi-library system is checking in items from the overnight dropbox. The librarian pulls out a damaged item, but it is an item owned and checked out from LibraryB. Instead of removing the item from the patrons checked out items, the library would like to transfer the item, still checked out, back to LibraryB so that LibraryB may decide how to deal with the damaged item. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure that ReturnItemWhenTransferred is enabled 4) Check an item out to a borrower 5) Transfer the item to another library 6) Verify the item was returned and removed from the patron's issues 7) Disable ReturnItemWhenTransferred 8) Check an item out to a borrower 9) Transfer the item to another library 10) Verify the item is still listed in the patron's current issues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 18:47:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 16:47:27 +0000 Subject: [Koha-bugs] [Bug 10378] Enable checked out items to be transferred without returning them In-Reply-To: <bug-10378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10378-70-4nhTm5Ethv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10378 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 18:58:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 16:58:13 +0000 Subject: [Koha-bugs] [Bug 10378] Enable checked out items to be transferred without returning them In-Reply-To: <bug-10378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10378-70-3Bk1oohbRJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10378 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18476|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18477 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18477&action=edit Bug 10378 - Enable checked out items to be transferred without returning them When items are transferred, they are automatically returned to the transferred-from library. Some libraries would like to be able to use the transfer system without automatically returning the item and having it removed from the patron record. Scenario: LibraryA of multi-library system is checking in items from the overnight dropbox. The librarian pulls out a damaged item, but it is an item owned and checked out from LibraryB. Instead of removing the item from the patrons checked out items, the library would like to transfer the item, still checked out, back to LibraryB so that LibraryB may decide how to deal with the damaged item. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure that ReturnItemWhenTransferred is enabled 4) Check an item out to a borrower 5) Transfer the item to another library 6) Verify the item was returned and removed from the patron's issues 7) Disable ReturnItemWhenTransferred 8) Check an item out to a borrower 9) Transfer the item to another library 10) Verify the item is still listed in the patron's current issues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 19:00:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 17:00:24 +0000 Subject: [Koha-bugs] [Bug 10378] Enable checked out items to be transferred without returning them In-Reply-To: <bug-10378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10378-70-koF0Yl3CZo@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10378 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18478 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18478&action=edit Bug 10378 - Enable checked out items to be transferred without returning them [ v3.10.05 ] When items are transferred, they are automatically returned to the transferred-from library. Some libraries would like to be able to use the transfer system without automatically returning the item and having it removed from the patron record. Scenario: LibraryA of multi-library system is checking in items from the overnight dropbox. The librarian pulls out a damaged item, but it is an item owned and checked out from LibraryB. Instead of removing the item from the patrons checked out items, the library would like to transfer the item, still checked out, back to LibraryB so that LibraryB may decide how to deal with the damaged item. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Ensure that ReturnItemWhenTransferred is enabled 4) Check an item out to a borrower 5) Transfer the item to another library 6) Verify the item was returned and removed from the patron's issues 7) Disable ReturnItemWhenTransferred 8) Check an item out to a borrower 9) Transfer the item to another library 10) Verify the item is still listed in the patron's current issues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 19:00:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 17:00:38 +0000 Subject: [Koha-bugs] [Bug 10378] Enable checked out items to be transferred without returning them In-Reply-To: <bug-10378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10378-70-tV0sQQRdCK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10378 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18478|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 19:45:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 17:45:12 +0000 Subject: [Koha-bugs] [Bug 8854] invoice filters don't all work In-Reply-To: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8854-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8854-70-zL6CzTc7DM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8854 Joseph Alway <jbalway at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbalway at gmail.com --- Comment #7 from Joseph Alway <jbalway at gmail.com> --- We are using MARC21 and the only Search Filters working for the invoices are the invoice number, Vendor, and Billing date. The following searches are broken: Shipment date, ISBN / EAN / ISSN, Title, Author, Publisher, Publisher Year, and Library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 20:31:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 18:31:03 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-DyV8PBiXLn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18205|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18479&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 21:24:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 19:24:19 +0000 Subject: [Koha-bugs] [Bug 10377] fix_unimarc_100 could be improved with 210$d values In-Reply-To: <bug-10377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10377-70-4wZ4dM4SIq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10377 --- Comment #3 from Janusz Kaczmarek <januszop at gmail.com> --- How about something in this style: my $string = marc->subfield('100','a'); my $s100a08 = substr($string, 8, 1); my $s100a09_12 = substr($string, 9, 4); my $year_now = POSIX::strftime("%Y", localtime()); if ($s100a08 =~ /[abcdefghijku]/ && $s100a09_12 =~ /\d{4}/ && $s100a09_12 >= 1455 && $s100a09_12 <= $year_now + 1) { # +1 just in case the is a next year date on the document # keep the date as $s100a08 . $s100a09_12 } else { # don't care about pub date from 100 -- it does not make sense, try to reconstruct it from 210$d } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 21:31:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 19:31:03 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10263-70-GyOmvfKF2b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18174|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18480&action=edit Bug 10200 - Bug 10263 - Add ability to limit which branch can edit a bibliographic record ( IndependentBranchesMarcEditing ) Right now, it's possible to limit who can edit items by using IndependantBranches. However, Koha has no method of limiting who can edit bibliographic records, as they have no defined owner. This patch adds a new system preference IndependentBranchesMarcEditing. If this new syspref is enabled, a librarian can only edit or delete a bib record if his or her logged in branch code matches the branchcode in biblio.branchcode. This feature does not affect the ability to edit or delete items, as that functionality is determined by IndependantBranches. This patch adds the 'branches_optional' field to the authorised values pulldown for MARC fields and subfields in the MARC frameworks editor. 'branches_optional' behaves exactly like 'branches' except it includes an "empty" choice so the branch does not have to be set. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Map a nonrepeatable field/subfield to biblio.branchcode ( e.g. 951$o ) Pro-tip: Use the authorised value 'branches_optional' to get a pulldown of libraries instead of entering the branchcode manually. 4) Edit a record, and add a branchcode. 5) Log in as a non-superlibrarian with cataloging priveleges 6) Change the logged in branch to a branch other than the one you entered in the record. 7) You should note the 'edit' pulldown for the record is missing the "Edit record" and "Delete record" options. 8) Switch the logged in branch to match the branchcode of the record. 9) You should now see the edit and delete options for that record. 10) Attempt to edit a record with no branchcode defined, you should be able to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 21:31:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 19:31:49 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-pwpdE62hEq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10263 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 21:31:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 19:31:49 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10263-70-NnanusFsg3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10206 |10276 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 21:31:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 19:31:49 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-Ij4PGBcL36@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10263 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 21:32:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 19:32:56 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-8hzki33t4h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10090 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 21:32:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 19:32:56 +0000 Subject: [Koha-bugs] [Bug 10090] the ordered and spent page display the itemtype code In-Reply-To: <bug-10090-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10090-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10090-70-uQCKViiTek@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10090 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10276 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 21:36:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 19:36:55 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-1DT9fakOnR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #20 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #19) > (In reply to comment #18) > > - I think references to the 999 and 955 tags would be better handled by > > looking up the tag that the MARC framework uses to store biblio.biblionumber > > rather than using magic numbers. > I fully agree with this ! I agree too, but this is not new in this patch, so I don't think that is a valid reason for stopping it. The Class name might be though. We've already discussed a followup for different MARC flavours that could be extended to use the mappings instead. But I do think that this is a huge code improvement over what we had, and that a follow up to change to using mappings would be better outside of this refactoring patch anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 21:40:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 19:40:36 +0000 Subject: [Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface In-Reply-To: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10083-70-oCrpqS2GzD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #14 from Chris Cormack <chris at bigballofwax.co.nz> --- Another one for you Bernardo :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 22:04:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 20:04:55 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: <bug-10331-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10331-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10331-70-mPWqEBCdeK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Janusz Kaczmarek <januszop at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18381|0 |1 is obsolete| | --- Comment #2 from Janusz Kaczmarek <januszop at gmail.com> --- Created attachment 18481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18481&action=edit Proposed patch - improved Yet another error: D. 1) have $a active in one of the linking fields (like 461, 463, etc.). 2) have a biblio record with the field 712 $a, $b filled up 3) go to cataloguing -> field 4XX of your choice, use the plugin to fetch data from biblio rec. mentioned in b) 4) see the punctuation in $a -- it will be wrong (unnecessary opening bracket at the end). New version of the patch covers this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 22:25:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 20:25:36 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10218-70-Jfjw5VEvtb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #9 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- In the past, some other bugs about XSLT or installation were MARC21 specific, without anouncing it. As you said, it is pretty annoying... I will add a followup on this bug, and change the status to Need Signoff. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 22:41:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 20:41:31 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-rb7dSbbT2Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 --- Comment #8 from Robin Sheat <robin at catalyst.net.nz> --- (In reply to comment #7) > Upon checking, Koha already has. Bug 9172, in addition to moving TinyMCE > out of its language-specific directory, bumped up the version bundled with > Koha to 3.5.8. Oh excellent. I think I was basing my comment there on old information then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 23:05:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 21:05:50 +0000 Subject: [Koha-bugs] [Bug 10315] Use easier readable font for generated passwords In-Reply-To: <bug-10315-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10315-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10315-70-kSRxcJFVyF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10315 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18355|0 |1 is obsolete| | --- Comment #2 from Mirko Tietgen <mirko at abunchofthings.net> --- Created attachment 18482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18482&action=edit Bug 10315 - Use easier readable font for generated passwords The text inputs on the change password form are not very big, and the default sans-serif font isn't always good for showing unambiguous characters. This patch sets a larger, monospace font for those fields. To test, apply the patch, clear your browser cache, and open the patron change password form (members/member-password.pl). The inputs should be more readable, especially the password fields when you click to fill with a randomly generated password. Signed-off-by: Mirko Tietgen <mirko at abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 23:07:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 21:07:32 +0000 Subject: [Koha-bugs] [Bug 10315] Use easier readable font for generated passwords In-Reply-To: <bug-10315-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10315-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10315-70-qXxM0XaIQi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10315 Mirko Tietgen <mirko at abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko at abunchofthings.net --- Comment #3 from Mirko Tietgen <mirko at abunchofthings.net> --- On a sidenote: Independently of using the patch or not, I could only generate one password. If I wanted to do it again, I had to reload the page. Is that the intended behaviour? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 23:31:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 21:31:30 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-g04u1CczVQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #31 from Maxime Pelletier <pelletiermaxime at gmail.com> --- (In reply to comment #29) > Created attachment 18466 [details] [review] > Bug 9394: QA Followup > > * C4::Reserves::GetReserveId > This subroutine did not have a unit test. This new test fails for me. You pass an itemnumber to GetReserveId after an AddReserve with no itemnumber, so GetReserveId returns the wrong of the 2 existing reserves at that point. We could either remove the "itemnumber => $itemnumber," line or add modify the AddReserve above it. What do you think ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed May 29 23:49:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 21:49:37 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8375-70-FepKahAFvC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger at foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger at foundations.ed | |u --- Comment #31 from Chris Nighswonger <cnighswonger at foundations.edu> --- (In reply to comment #29) > Im happy to sign off on this as soon as bug 9856 and bug 9854 have patches > to sign off on as well. It looks like we are still lacking patches to move ttf pathing to a syspref. RE bugs 9854 and 9856... Embedding fonts is the only way to fix the problems according to a software engineer at Adobe who I corresponded with a couple of years back concerning this very issue. So this sounds like a good thing for now. Once patches for the above mentioned bugs are submitted, I'd be glad to sign off on this as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 00:27:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 22:27:42 +0000 Subject: [Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail In-Reply-To: <bug-9299-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9299-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9299-70-rAztXSEZeQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 --- Comment #1 from Robin Sheat <robin at catalyst.net.nz> --- I've seen this happen when extended attributes are defined, but it's definitely a problem. It might be when none are assigned to the user, or something like that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 01:18:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 23:18:46 +0000 Subject: [Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail In-Reply-To: <bug-9299-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9299-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9299-70-g73kQ23L1M@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |srdjan at catalyst.net.nz Assignee|gmcharlt at gmail.com |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 01:25:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 23:25:15 +0000 Subject: [Koha-bugs] [Bug 10315] Use easier readable font for generated passwords In-Reply-To: <bug-10315-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10315-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10315-70-L60kQK3XsF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10315 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- (In reply to comment #3) > I could only > generate one password. This is the way it has always worked, so I guess you could call it the intended behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 01:36:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 29 May 2013 23:36:11 +0000 Subject: [Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface In-Reply-To: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10083-70-19qg2vhNFu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Thanks Owen! Pushed to 3.10.x, will be on 3.10.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 05:16:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 03:16:18 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-0fswTEQCXM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 --- Comment #9 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 18483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18483&action=edit Bug 10367 - [3.12] update the rules and control file for wheezy This updates the control file to use tinymce rather than tinymce2, as tinymce2 is deprecated and no longer in Debian. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 05:17:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 03:17:34 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-TWmS0hWb8U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |--- --- Comment #10 from Robin Sheat <robin at catalyst.net.nz> --- This patch is actually identical to the one for master with a different commit message, turns out master and 3.12 are close enough that it works. Not too surprising really. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 05:21:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 03:21:56 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-hVPGaJvd00@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 --- Comment #11 from Robin Sheat <robin at catalyst.net.nz> --- PS: Jonathan, thanks for letting me know that 'git grep' is a thing that exists. I can see it being useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 05:33:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 03:33:32 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-F3I5qWZ5Sp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 --- Comment #12 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 18484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18484&action=edit Bug 10367 - [3.10] update the rules and control file for wheezy This updates the control file to use tinymce rather than tinymce2, as tinymce2 is deprecated and no longer in Debian. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 05:35:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 03:35:19 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-cGOJnJQNsk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18460|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 05:36:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 03:36:04 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-iWEQsPPEbS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 --- Comment #13 from Robin Sheat <robin at catalyst.net.nz> --- The 3.10 patch is a reasonably different patch, due to recent changes that aren't in that one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 05:59:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 03:59:23 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10314-70-JIf7Avh8nu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18345|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18485 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18485&action=edit Bug 10314 - CanItemBeReserved does not respect the holds policies CanItemBeReserved will return 1 as long as the circulation rules have a non-zero number of holds allowed and the patron hasn't reached his or her "Holds allowed" count. However, the subroutine completely ignores the holds policies which would contravene reserving the item even if the patron has not reached the maximum holds allowed count. Test Plan: 1) Place an item on hold for a patron 2) Clear any existing hold policies 3) Set the appropriate circ rule so that the patron should be allowed 4) Attempt to place am item-level hold for this item/patron, it should succeed 5) Create a hold policy rule that would stop this patron from placing a hold on this item 6) Attempt to place an item-level hold on this item/patron, it should fail, but instead it will succeed 7) Apply this patch 8) Repeat step 6, this time you should be unable to place a specific hold on this item Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 05:59:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 03:59:59 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10314-70-dhHwdZxqaL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 06:00:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 04:00:02 +0000 Subject: [Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies In-Reply-To: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10314-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10314-70-q150xJAvra@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18346|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18486 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18486&action=edit Bug 10314 - CanItemBeReserved does not respect the holds policies - Followup - Tidy up CanItemBeReserved Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 06:01:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 04:01:09 +0000 Subject: [Koha-bugs] [Bug 10379] New: koha-rebuild-zebra gets noisy if no instances are defined Message-ID: <bug-10379-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10379 Bug ID: 10379 Summary: koha-rebuild-zebra gets noisy if no instances are defined Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: robin at catalyst.net.nz CC: robin at catalyst.net.nz If koha-rebuild-zebra is given no arguments, it displays the usage. That's quite reasonable, however it means that if you have koha-common installed but no instances defined, you get emailed every 5 minutes about it. I'm going to add a -q flag that is used by the cron job that suppresses the usage message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 06:06:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 04:06:12 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9532-70-excLoWDB2G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 06:06:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 04:06:14 +0000 Subject: [Koha-bugs] [Bug 9532] reserve rules with itemtype on biblio In-Reply-To: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9532-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9532-70-ifbmpSUDpI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9532 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18061|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18487&action=edit Bug 9532: GetItem must use item-level_itypes syspref Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 06:15:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 04:15:24 +0000 Subject: [Koha-bugs] [Bug 7110] Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled. In-Reply-To: <bug-7110-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7110-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7110-70-DTWqbvPOX5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7110 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 06:15:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 04:15:27 +0000 Subject: [Koha-bugs] [Bug 7110] Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled. In-Reply-To: <bug-7110-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7110-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7110-70-Mzvd6XgU3l@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7110 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18052|0 |1 is obsolete| | --- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18488 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18488&action=edit Bug 7110 - Renewal messages still displays in OPAC if OpacRenewalAllowed is disabled The original patch added a message to display if OpacRenewalAllowed is disabled but OPACFineNoRenewals is enabled. This change was reversed by a follow-up on Bug 8408. I think both versions are incorrect: If a patron has fines which exceed the limit set by OPACFineNoRenewals but OPAC renewals are disallowed by OpacRenewalAllowed, no message should be displayed. Information about outstanding fines in this case has no bearing on how the user sees his summary of checkouts. To test, try various combinations of OpacRenewalAllowed and OPACFineNoRenewals with a patron who has outstanding fines: - OpacRenewalAllowed ON and OPACFineNoRenewals ON (set to be triggered by the test patron's fines): Logging in to the OPAC the patron should see a warning on opac-user.pl about not being able to renew items because of fines. - OpacRenewalAllowed ON and OPACFineNoRenewals OFF (threshold high enough not to trigger a block): No warning appears. - OpacRenewalAllowed OFF and OPACFineNoRenewals ON: No warning appears. - OpacRenewalAllowed OFF and OPACFineNoRenewals OFF: No warning appears. If OpacRenewalAllowed is diabled and a patron's fines exceed the limit set by OPACFineNoRenewals they should see no message. Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 06:16:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 04:16:09 +0000 Subject: [Koha-bugs] [Bug 10379] koha-rebuild-zebra gets noisy if no instances are defined In-Reply-To: <bug-10379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10379-70-f6dZc9yydt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10379 --- Comment #1 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 18489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18489&action=edit Bug 10379 - silence zebra rebuild cron when no instances are enabled This adds a -q option to koha-rebuild-zebra that prevents it outputting help if no instances are provided on the command line. This means that if you've just installed the package, you won't get messages from cron telling you how to use the script. Test plan: * install koha-common 3.12 or master onto a system with no enabled instances. * note that you or the sysadmin will start getting emails every 5 minutes. * replace /etc/cron.d/koha-common and /usr/sbin/koha-rebuild-zebra with the versions from this patch. * note that the emails stop flowing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 06:16:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 04:16:49 +0000 Subject: [Koha-bugs] [Bug 10379] koha-rebuild-zebra gets noisy if no instances are defined In-Reply-To: <bug-10379-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10379-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10379-70-RNCaebCwQI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10379 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 08:52:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 06:52:42 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: <bug-9735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9735-70-3J3IKcA26E@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 08:53:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 06:53:07 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: <bug-9735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9735-70-DgVKwX7aOS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 --- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> --- Created attachment 18490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18490&action=edit Bug 9735 - Let the language be selected through URL parameters Passing language=<valid_language_code> as a parameter in any Koha's URL can be used to set the desired language. This patch touches - C4::Templates - C4::Auth Adds a new method getlanguagecookie that does exactly that, for use in get_template_and_user. Also modifies getlanguage so it checks (a) if there's a 'language' parameter in the CGI object and (b) checks if its valid and enabled for the desired interface. To test: * Without the patch - access any koha page - add ?language=code to the end of the URL (change code for a valid language code it needs to be installed using perl translate install code, and enabled either for the staff or opac interface, depending where are you testing) - Nothing happens with the language parameter * With the patch - access any koha page - add ?language=code (the same as before) and hit enter - the language should be changed to the one you chose - if you browse through some links, you will see koha 'remembers' the language you passed as a parameter (i.e. the language cookie has been updated). Regards To+ Sponsored-by: Universidad Nacional de C?rdoba Signed-off-by: Brendan <brendan at bywatersolutions.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> Comment: Works very well. No errors. Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 08:53:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 06:53:26 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: <bug-9735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9735-70-KJUKEBXlXl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16091|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 08:53:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 06:53:35 +0000 Subject: [Koha-bugs] [Bug 9735] Choose language using URL parameters in any page In-Reply-To: <bug-9735-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9735-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9735-70-jVQHccG3GN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9735 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:09:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:09:31 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10124-70-22NOoW8sto@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Pierre Angot <tredok.pierre at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |tredok.pierre at gmail.com --- Comment #12 from Pierre Angot <tredok.pierre at gmail.com> --- Sandbox setup by tredok.pierre at gmail.com with database 2 and bug 10124 on Thu May 30 08:42:02 2013 Something went wrong ! Applying: Bug 10124: Merge GetPendingOrders and SearchOrders routines Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Acquisition.pm Auto-merging acqui/orderreceive.pl Auto-merging t/db_dependent/Acquisition.t Applying: Bug 10124: Add basket group name in filters Applying: Bug 10124: Add filters on the pending orders table Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10124: Add filters on the pending orders table When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Bug 10124 - Pending orders: ergonomic improvement Bug 10124: Merge GetPendingOrders and SearchOrders routines Apply? [yn] Bug 10124: Add basket group name in filters Apply? [yn] Bug 10124: Add filters on the pending orders table Apply? [yn] Patch left in /tmp/Bug-10124-Add-filters-on-the-pending-orders-table-GhyXZs.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:17:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:17:33 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-gA0vs6hTNE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:18:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:18:21 +0000 Subject: [Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid In-Reply-To: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10317-70-wpbbfZwC3F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #2 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by Cedric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:18:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:18:32 +0000 Subject: [Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid In-Reply-To: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10317-70-0Jq3MVnPUX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18352|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:18:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:18:37 +0000 Subject: [Koha-bugs] [Bug 10317] Parcel should display a message when called with an nonexistent invoiceid In-Reply-To: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10317-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10317-70-6g8PZQyMMi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10317 --- Comment #3 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 18491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18491&action=edit Bug 10317: The parcel page display whatever if the invoiceid is unknown This patch fixes some stuffs on the parcel page. 1/ Removes dead code 2/ Display an error message if invoiceid is unset or not to refer to an invoice 3/ Fix a bug in the note ("change note" and "add note" links) Test plan: 1/ Try to call the invoice page with an existing invoiceid and check that order results are consistent. 2/ Try without invoiceid or a bad invoiceid and check that an error message is displayed. 3/ Add and change notes. Signed-off-by: Cedric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:18:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:18:37 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-2JJ9SeAhTq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 --- Comment #32 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #31) > (In reply to comment #29) > > Created attachment 18466 [details] [review] [review] > > Bug 9394: QA Followup > > > > * C4::Reserves::GetReserveId > > This subroutine did not have a unit test. > > This new test fails for me. You pass an itemnumber to GetReserveId after an > AddReserve with no itemnumber, so GetReserveId returns the wrong of the 2 > existing reserves at that point. We could either remove the "itemnumber => > $itemnumber," line or add modify the AddReserve above it. What do you think ? Ho yes, of course! 50% chance, the test passes on my instance... I will resubmit the patch and switch back the status to Needs Signoff! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:19:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:19:26 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-7jIBkvm5OR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:19:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:19:29 +0000 Subject: [Koha-bugs] [Bug 9394] Use reserve_id where possible In-Reply-To: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9394-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9394-70-boLpshp5JB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9394 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18466|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18492 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18492&action=edit Bug 9394: QA Followup * C4::Reserves::_FixPriority - The previous code checked the cancellationdate. If think you never pass in it with bad parameters, but in order to be sure I added the check on this value. - The reservedates array was never used. * circ/circulation.tt There was a bug: it was not possible to remove an hold from the circulation page. Passing reserve_id fixes the issue. * C4::Reserves::GetReserveId This subroutine did not have a unit test. Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:21:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:21:27 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8064-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8064-70-rOApH3nkFp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #9 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- I mark it in discussion, as 9755 will be soon QAed and pushed... M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:39:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:39:11 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10124-70-Byv6VyH82n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17691|0 |1 is obsolete| | Attachment #17692|0 |1 is obsolete| | Attachment #17701|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18493&action=edit Bug 10124: Merge GetPendingOrders and SearchOrders routines Preliminary work: In the C4::Acquisition module, 2 routines do the same work. This patch merges these 2 routines. Test plan: test the acqui/orderreceive.pl, acqui/uncertainprice.pl and serials/acqui-search-result.pl scripts. acqui/parcel.pl will be tested with the others patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:39:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:39:15 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10124-70-GmKAVYGuJY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #14 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18494&action=edit Bug 10124: Add basket group name in filters This patch adds a new filter "basket group name" for pending orders searches. Test plan: Try different filters and check that results are consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:39:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:39:19 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10124-70-3CxftNtxx3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #15 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18495&action=edit Bug 10124: Add filters on the pending orders table Since the parcel.pl script get *all* pending orders, there is no reason not to display all of them. Like that, DataTable manages pagination and sorting correctly (on all data). This patch adds filters on the table header (using columnFilter). Test plan: Try filters on the left of the screen and filters on the table header. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:39:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:39:59 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10124-70-48rnWCjmjK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 09:59:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 07:59:07 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10013-70-1ndjTzG9Q7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 Pierre Angot <tredok.pierre at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tredok.pierre at gmail.com --- Comment #14 from Pierre Angot <tredok.pierre at gmail.com> --- Hello, I'm questionning about the use of this patch. Why made a link to budget ? I've maybe misunderstood the goal of this patch. Can you give me more explaination ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 10:03:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 08:03:30 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10013-70-wn67G16maN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #15 from Amit Gupta <amit.gupta at osslabs.biz> --- Hi, The purpose of this patch will show under which budget you ordered/purchased the item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 10:04:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 08:04:13 +0000 Subject: [Koha-bugs] [Bug 7654] Add location an callnumber at opac subscription view In-Reply-To: <bug-7654-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7654-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7654-70-L9JMRwRqOw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7654 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #14 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Hello, I don't understand why this bug is "in discussion" after being signed-off et passed QA. I don't see in the comments an explanation about this status. Thanks, Sonia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 10:11:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 08:11:19 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-DJzrRRzUA8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #45 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by Cedric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 10:11:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 08:11:42 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-Sn42pWajin@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #46 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 18496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18496&action=edit Bug 5336: Add unit tests for 3 acq routines Unit tests In C4::Acquisition for: - CloseBasket - ReopenBasket - GetBiblioCountByBasketno Signed-off-by: Cedric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 10:26:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 08:26:03 +0000 Subject: [Koha-bugs] [Bug 10013] Ability to link directly from an item in the Staff client to budget information. In-Reply-To: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10013-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10013-70-y3zOrR6RU8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10013 --- Comment #16 from Pierre Angot <tredok.pierre at gmail.com> --- Ok. I think the proposals that Mathieu did are more complete. Have you seen them ? It will be a good idea to work to include what Rennes2 did. If evebody think this patch (10013) is essential, I can sign it (it works ^^). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 10:42:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 08:42:16 +0000 Subject: [Koha-bugs] [Bug 9547] Give the ability to sort baskets by closing date and status In-Reply-To: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9547-70-sCh8VNz2NU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9547 cedric.vita at dracenie.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cedric.vita at dracenie.com --- Comment #3 from cedric.vita at dracenie.com --- Everything seems to appear in the columns, but it is not possible to sort the column "Closed is" on sandbox as closing dates are identical. The column "Opened on" the sort is OK. The base is reset every night on Sandbox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 10:46:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 08:46:08 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-V1xktNmxrd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18411|0 |1 is obsolete| | Attachment #18412|0 |1 is obsolete| | Attachment #18413|0 |1 is obsolete| | Attachment #18414|0 |1 is obsolete| | Attachment #18496|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18497 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18497&action=edit Bug 5336:Order search (search and UI enhancements) You can now search orders by - order status - fund New field aqorders.orderstatus, it can contains following values: 0 => New 1 => Ordered 2 => Partial 3 => Complete 4 => Deleted To test: Search and check if results are consistent in histsearch.pl Signed-off-by: Cedric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 10:46:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 08:46:14 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-kOPGrbDa21@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #48 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18498&action=edit Bug 5336: Late orders search: don't display deleted order. Test plan: Check that deleted orders are not listed in the late orders search results. Signed-off-by: Cedric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 10:46:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 08:46:18 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-b0buFGbTQb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #49 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18499 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18499&action=edit Bug 5336: Merge parent ordernumber and ordernumber columns Signed-off-by: Cedric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 10:46:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 08:46:22 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-Oio9zaryIi@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #50 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18500&action=edit Bug 5336: Add unit tests for 3 acq routines Unit tests In C4::Acquisition for: - CloseBasket - ReopenBasket - GetBiblioCountByBasketno Signed-off-by: Cedric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 10:46:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 08:46:35 +0000 Subject: [Koha-bugs] [Bug 9547] Give the ability to sort baskets by closing date and status In-Reply-To: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9547-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9547-70-wDezdAtuCT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9547 --- Comment #4 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- OK, so it cannot be tested fully and signed off on a sandbox... M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 10:47:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 08:47:06 +0000 Subject: [Koha-bugs] [Bug 5336] Acq history search In-Reply-To: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5336-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5336-70-UulyTrSAsD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336 --- Comment #51 from Jonathan Druart <jonathan.druart at biblibre.com> --- Last 4 patches are signoff patch for C?dric Vita. Thanks C?dric! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:00:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:00:14 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10124-70-zuuwTl9d3X@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18493|0 |1 is obsolete| | Attachment #18494|0 |1 is obsolete| | Attachment #18495|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18501&action=edit Bug 10124: Merge GetPendingOrders and SearchOrders routines Preliminary work: In the C4::Acquisition module, 2 routines do the same work. This patch merges these 2 routines. Test plan: test the acqui/orderreceive.pl, acqui/uncertainprice.pl and serials/acqui-search-result.pl scripts. acqui/parcel.pl will be tested with the others patches. Signed-off-by: Pierre Angot <tredok.pierre at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:00:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:00:19 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10124-70-AVNC4JvnkW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #17 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18502 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18502&action=edit Bug 10124: Add basket group name in filters This patch adds a new filter "basket group name" for pending orders searches. Test plan: Try different filters and check that results are consistent. Signed-off-by: Pierre Angot <tredok.pierre at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:00:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:00:24 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10124-70-7S8gGgr0T5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 --- Comment #18 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18503 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18503&action=edit Bug 10124: Add filters on the pending orders table Since the parcel.pl script get *all* pending orders, there is no reason not to display all of them. Like that, DataTable manages pagination and sorting correctly (on all data). This patch adds filters on the table header (using columnFilter). Test plan: Try filters on the left of the screen and filters on the table header. Signed-off-by: Pierre Angot <tredok.pierre at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:06:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:06:02 +0000 Subject: [Koha-bugs] [Bug 10028] ModReceiveOrder works unexpectedly In-Reply-To: <bug-10028-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10028-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10028-70-casu4aEI0F@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10028 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:08:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:08:26 +0000 Subject: [Koha-bugs] [Bug 10124] Pending orders: ergonomic improvement In-Reply-To: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10124-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10124-70-gx0OLUIy2b@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10124 Pierre Angot <tredok.pierre at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #19 from Pierre Angot <tredok.pierre at gmail.com> --- Test on sandbox. Signed off. I've created 2 baskets, and add them to a basketgroup. Then, I've made a receive to test filters. - Authors, ... : ok - Basket : ok - Basket group name : ok - Order line : ok I've also tested column filter. Everything is fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:10:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:10:33 +0000 Subject: [Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop In-Reply-To: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9505-70-wFgrLMBSC3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505 --- Comment #9 from Colin Campbell <colin.campbell at ptfs-europe.com> --- (In reply to comment #8) > Comment on attachment 18354 [details] [review] > Amended Patch > > Review of attachment 18354 [details] [review]: > ----------------------------------------------------------------- > > ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt > @@ +92,4 @@ > > [% IF ( invoicenumber ) %] > > <li>Invoice no.: [% invoicenumber %]</li> > > [% END %] > > + [% IF booksellerid %] > > I think this test can be removed. I don't find anywhere supplier was passed. > Or perhaps should we check the supplierid variable. It is passed when we > come from the acqui/supplier.pl page. It gets passed from invoices.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:27:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:27:33 +0000 Subject: [Koha-bugs] [Bug 10298] t::lib::Mocks tries to deal with syspref but doesn not manage to In-Reply-To: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10298-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10298-70-CfbGVkzRGX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10298 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18301|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18504 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18504&action=edit Bug 10298: Mock C4::Context->preference t::lib::Mocks::Context tried to deal with preferences but did not manage to. This patch removes this module and add 2 routines in t::lib::Mocks in order to mock C4::context->preference and C4::Context->config. To test: ===START t/test.pl=== use Modern::Perl; use t::lib::Mocks; use C4::Context; say "initial value for version: " . C4::Context->preference('Version'); say "initial value for language: " . C4::Context->preference('language'); t::lib::Mocks::mock_preference('Version', "new version for testing"); say "version is mocked with: " . C4::Context->preference('Version'); say "language is not yet mocked: " . C4::Context->preference('language'); t::lib::Mocks::mock_preference('language', 'new langage for testing'); t::lib::Mocks::mock_preference('Version', 'another version for testing'); say "version is mocked with another value: " . C4::Context->preference('Version'); say "language is finally mocked: " . C4::Context->preference('language'); ===END=== Try to execute this file and check that the output is consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:34:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:34:12 +0000 Subject: [Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop In-Reply-To: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9505-70-rbU6hLBU4C@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505 --- Comment #10 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #9) > > I think this test can be removed. I don't find anywhere supplier was passed. > > Or perhaps should we check the supplierid variable. It is passed when we > > come from the acqui/supplier.pl page. > > It gets passed from invoices.pl Humm... yes :) It looks like I forgot to read the code with the context. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:44:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:44:58 +0000 Subject: [Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop In-Reply-To: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9505-70-ovX5VAOLbf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: All look good. No regression found. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:45:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:45:13 +0000 Subject: [Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop In-Reply-To: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9505-70-eqohJzV5t0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18354|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18505 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18505&action=edit bug 9505 refactor loops in invoices.pl - Remove an unnecessary loop where output just recreated input. - Remove unnecessary temp variables that obscure code purpose. - Call the variable containing invoices, invoices rather than anonymous and ambiguous results reflect namechange in template. - Lists are passed to template as array refs; declare them as scalars as that is how we use them. - No need to introduce the whole namespace of some C4 modules for 1 routine. Test plan: Note that this patch should not change any visible behavior. [1] Open the invoice search page. [2] Verify that the list of suppliers in the drop-down on the search form is complete. [3] Verify that the list of libraries in the drop-down on the saerch form is complete. [4] Perform a search. Verify that the list of invoices is correct. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:45:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:45:23 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-Vb2ygVOMHb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Paul Poulain <paul.poulain at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #73 from Paul Poulain <paul.poulain at biblibre.com> --- Patch tested with a sandbox, by Pierre Angot <tredok.pierre at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:45:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:45:42 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-hP8JB3bLV4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #74 from Paul Poulain <paul.poulain at biblibre.com> --- Created attachment 18506 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18506&action=edit Bug 9824: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. With thanks to Owen for some rewording. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Pierre Angot <tredok.pierre at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:46:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:46:07 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-igvj9LhXzP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18348|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:50:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:50:33 +0000 Subject: [Koha-bugs] [Bug 10296] UT: db schemas are useless In-Reply-To: <bug-10296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10296-70-IBIgmhSgw0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10296 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|db schemas are useless |UT: db schemas are useless -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 11:53:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 09:53:51 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8236-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8236-70-gnLR4xLSyh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18073|0 |1 is obsolete| | --- Comment #42 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 18507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18507&action=edit Bug-8236-Block-renewing-for-overdue-items.patch patch rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 12:13:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 10:13:37 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-M8KF5Kz5Pd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #21 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- (In reply to comment #18) > Couple comments: > > - Please rename the 'Koha::Record' class; as it is, the name is too generic. > After all, Koha has lots of record types, many of which are not MARC. I > suggest either 'Koha::MARC::Record' (following MARC::Record) or perhaps > 'Koha::Metadata::MARC' (allowing for Koha::Metadata::MODS, etc.) or > 'Koha::Util::MARC'. I've decided I'm attached to Koha::Record, because my reasoning behind using it was that it would be nice to be able to merge non-MARC records, so I've gone a bit further in a follow-up and made the class schema-sensitive, moving the MARC-specific code to Koha::Util::MARC. > - I think references to the 999 and 955 tags would be better handled by > looking up the tag that the MARC framework uses to store biblio.biblionumber > rather than using magic numbers. Fixed. > Setting back to in discussion, as I do not intend to push this until (at > least) the class has a better name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 12:16:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 10:16:23 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-L09Y5yuTT6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18437|0 |1 is obsolete| | Attachment #18438|0 |1 is obsolete| | Attachment #18439|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18508&action=edit Bug 8845 - Add ability search patrons by date of birth Adds the ability to search by dates of birth in iso format. Signed-off-by: Marc Veron <veron at veron.ch> Searched with following formats: YYYYMMDD , YYYY-MM-DD , YYYY.MM.DD All searches are OK Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 12:16:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 10:16:30 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-IxLj2XxVK7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #28 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18509&action=edit Bug 8845: Followup Allow to give a date using the syspref format Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 12:16:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 10:16:34 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-fOViyswVLC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #29 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18510&action=edit Bug 8845 - Add ability search patrons by date of birth - Add tooltip Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> Works with all date formats Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 12:16:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 10:16:39 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-xsx8N69hO8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 --- Comment #30 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18511&action=edit Bug 8845: FIX dateonly is the 4th parameter, not 3rd! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 12:17:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 10:17:32 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-xMBO6yM48K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #31 from Jonathan Druart <jonathan.druart at biblibre.com> --- Rebased patches. I added a patch in order to fix a variable order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 12:19:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 10:19:44 +0000 Subject: [Koha-bugs] [Bug 9014] Add time due to slips In-Reply-To: <bug-9014-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9014-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9014-70-U1vo1b8SHT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9014 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #37 from Jonathan Druart <jonathan.druart at biblibre.com> --- This patch reorder the parameter for output_pref but does not deal with existing occurrence. I think there are 2 calls to fix: C4/Letters.pm: $values->{'expirationdate'} = output_pref( $dt, undef, 1 ); C4/Letters.pm: $values->{'waitingdate'} = output_pref( dt_from_string( $values->{'waitingdate'} ), undef, 1 ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 12:26:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 10:26:43 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-aiUbF8KiOF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #22 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Just to know, what kind of records in Koha are not MARC records? I don't understand. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 12:27:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 10:27:55 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-5JMDKFTXgK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 12:27:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 10:27:57 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-Fm0kXii3qt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #23 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18512&action=edit Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_Record.t t/Koha_Util_MARC.t t/db_dependent/Authority.t and optionally try to merge a record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 12:31:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 10:31:29 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-iMvq92sS9A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18512|0 |1 is obsolete| | --- Comment #24 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18513&action=edit Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_Record.t t/Koha_Util_MARC.t t/db_dependent/Authority.t and optionally try to merge a record. Re-uploading since my last upload missed some of the changes (code tidying in the new file only). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 12:48:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 10:48:03 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5202-70-7FvUrMzq4G@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Colin Campbell <colin.campbell at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #4 from Colin Campbell <colin.campbell at ptfs-europe.com> --- This is dependent on the patch associated with bug 9755 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 12:53:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 10:53:53 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5202-70-8Fc7ajgr4O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18443|0 |1 is obsolete| | --- Comment #5 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18514&action=edit Bug 5202: merge authorities from the authority file and reservoir This patch gives Koha the ability to merge authority records using the same interface used by bibliographic records, though slightly different methods for selecting which records to merge. The two ways to select records are as follows: 1) Records can be selected from authority search results by clicking the "Merge" link for two records. 2) Authority records can be merged from the reservoir by clicking the merge-related links in the Manage staged MARC batch screen. To test: 1) Apply patch. 2) Do a search for an authority record that will turn up multiple identical records (or at least two records that you don't mind merging). 3) Click the "Merge" link for the first record. 4) Click the "Merge" link for the second record. 5) Choose which fields from which record you want to appear in the resulting record. 6) Confirm that those are the fields that exist in the resulting record. 7) Stage an authority record (for example, an authority record you saved from your catalog. 8) Search for a record to merge with it using the "Search for a record to merge in a new window" link. 9) Merge these records, confirming that the resulting record (after going through the entire merging process) matches your expectations. 10) Set up a matching rule for authorities, and export an authority from your catalog that will match based on that rule. For MARC21, the following is a good choice for a rule: Matching rule code: AUTHPER Description: Personal name main entry Match threshold: 999 Record type: Authority record [Match point 1:] Search index: mainmainentry Score: 1000 Tag: 100 Subfields: a 11) Stage the record you just exported, choosing the matching rule you just created. 12) Merge the record using the "Merge" link, confirming that the resulting record (after going through the entire merging process) matches your expectations. 13) Sign off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 13:01:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 11:01:59 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes, on the same order number In-Reply-To: <bug-10209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10209-70-Od2pNPpUDK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 --- Comment #1 from Amit Gupta <amit.gupta at osslabs.biz> --- Created attachment 18515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18515&action=edit The ability to order multiple copies of the same item, from different fund classes, on the same order number To Test: 1) Create basket. 2) Click on new order empty record. 3) Give title, quantity and select fund. 4) Order multiple copies of the same item click on Add fund and quantity button it will add one more fund and quantity by default quantity will be 1. 5) For delete fund and quantity simply click on Delete fund and quantity. Atleast one quantity and fund will be there if you try to delete it will show one error message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 13:02:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 11:02:10 +0000 Subject: [Koha-bugs] [Bug 10209] The ability to order multiple copies of the same item, from different fund classes, on the same order number In-Reply-To: <bug-10209-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10209-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10209-70-JbKm64X0OP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10209 Amit Gupta <amit.gupta at osslabs.biz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 13:02:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 11:02:41 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5202-70-iwK7wdRGjG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18514|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18516&action=edit Bug 5202: merge authorities from the authority file and reservoir This patch gives Koha the ability to merge authority records using the same interface used by bibliographic records, though slightly different methods for selecting which records to merge. The two ways to select records are as follows: 1) Records can be selected from authority search results by clicking the "Merge" link for two records. 2) Authority records can be merged from the reservoir by clicking the merge-related links in the Manage staged MARC batch screen. To test: 1) Apply patch. 2) Do a search for an authority record that will turn up multiple identical records (or at least two records that you don't mind merging). 3) Click the "Merge" link for the first record. 4) Click the "Merge" link for the second record. 5) Choose which fields from which record you want to appear in the resulting record. 6) Confirm that those are the fields that exist in the resulting record. 7) Stage an authority record (for example, an authority record you saved from your catalog. 8) Search for a record to merge with it using the "Search for a record to merge in a new window" link. 9) Merge these records, confirming that the resulting record (after going through the entire merging process) matches your expectations. 10) Set up a matching rule for authorities, and export an authority from your catalog that will match based on that rule. For MARC21, the following is a good choice for a rule: Matching rule code: AUTHPER Description: Personal name main entry Match threshold: 999 Record type: Authority record [Match point 1:] Search index: mainmainentry Score: 1000 Tag: 100 Subfields: a 11) Stage the record you just exported, choosing the matching rule you just created. 12) Merge the record using the "Merge" link, confirming that the resulting record (after going through the entire merging process) matches your expectations. 13) Sign off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 14:12:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 12:12:32 +0000 Subject: [Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price In-Reply-To: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9129-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9129-70-vOaaLWjUEp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129 --- Comment #32 from Kyle M Hall <kyle.m.hall at gmail.com> --- > That's OK. Speaking of the fines write, have you put together a plan for it? Yes, I submitted an RFC, and have already started development. The new database schema has deviated a bit from the RFC for technical reasons ( I had thought to split fees accruing and fees accrued into two separate tables, but it became unworkable in reality ). The biggest change will be the separation of fees and payments into two tables. Each 'payment' will have subpayments for each fee paid. So, if a patron pays $10 in fines, we'll know that person paid $10 total, $3.00 on Fine A, $5.00 on Fine B, and $2.00 on Fine C! In addition, the biggest under the hood change will be to unify all payment subroutines into a single sub, so we don't have behavioral issues that crop up currently. Also, all tables will have primary keys, so we won't have to update fees based on the description anymore ( which has lead to bugs in the past ). In addition, the account offsets table will function again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 14:37:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 12:37:46 +0000 Subject: [Koha-bugs] [Bug 10380] New: output_pref should use a hashref for parameters Message-ID: <bug-10380-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Bug ID: 10380 Summary: output_pref should use a hashref for parameters Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Koha::DateUtils::output_pref takes 4 parameters and the last one is a boolean, so some calls are: output_pref($dt, undef, undef, 1) Which is not readable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 14:37:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 12:37:54 +0000 Subject: [Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters In-Reply-To: <bug-10380-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10380-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10380-70-vQbDywmdqv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 14:42:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 12:42:22 +0000 Subject: [Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters In-Reply-To: <bug-10380-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10380-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10380-70-cPHuf5uHUE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18517&action=edit Bug 10380: Change prototype for output_pref routine Koha::DateUtils::output_pref takes 4 parameters and the last one is a boolean, so some calls are: output_pref($dt, undef, undef, 1) This patch changes it prototype to output_pref({ dt => $dt, dateformat => $dateformat, timeformat => $timeformat, dateonly => $boolean }); an alternative is to call the output_pref routine with a datetime object, without using an hashref: output_pref($dt); Test plan: Go on some page where dates are displayed (circulation, laterorder, member page, etc.). Launch the unit tests file t/DateUtils.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 14:42:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 12:42:35 +0000 Subject: [Koha-bugs] [Bug 10380] output_pref should use a hashref for parameters In-Reply-To: <bug-10380-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10380-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10380-70-fL1KYBP7kS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10380 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 14:45:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 12:45:12 +0000 Subject: [Koha-bugs] [Bug 9014] Add time due to slips In-Reply-To: <bug-9014-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9014-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9014-70-ZlMmVP5WHO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9014 --- Comment #38 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #37) > This patch reorder the parameter for output_pref but does not deal with > existing occurrence. I think there are 2 calls to fix: > > C4/Letters.pm: $values->{'expirationdate'} = output_pref( $dt, undef, > 1 ); > C4/Letters.pm: $values->{'waitingdate'} = output_pref( > dt_from_string( $values->{'waitingdate'} ), undef, 1 ); Not a big issue. Dates reserves.expirationdate and reserves.waitingdate will be displayed like (depending from the dateformat pref): DD/MM/YYYY 00:00 instead of DD/MM/YYYY I provided a patch (bug 10380) in order to fix the prototype problem of this routine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:03:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:03:47 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10263-70-WjTKXuXbeI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10277 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:03:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:03:47 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-E82FQMTI5n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10263 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:05:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:05:43 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-milrXzgsUj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10277 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:05:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:05:43 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-zw604IAymh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10276 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:07:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:07:21 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-CSWnHIlBJ9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|10206 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:07:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:07:21 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-UbIGrO7bfj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10276 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:21:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:21:50 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-QOehtXB6Ic@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: I found an possible issue: If the borrowernumber stored in the new field items.last_returned_by is deleted, the dbms raises an error: DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha_coderun`.`items`, CONSTRAINT `items_ibfk_4` FOREIGN KEY (`last_returned_by`) REFERENCES `borrowers` (`borrowernumber`)) at /home/koha/src/C4/Members.pm line 1819. You should add a "on delete cascade" option (set null ?) or remove this constraint. It is a dilemma: in one case we loose the information, in other one we loose the constraint :-/ Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:23:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:23:02 +0000 Subject: [Koha-bugs] [Bug 9426] Add itemtype description template plugin In-Reply-To: <bug-9426-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9426-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9426-70-ofdPiRkpOJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9426 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Same plugin was added by Bug 8215. Cool. *** This bug has been marked as a duplicate of bug 8215 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:23:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:23:02 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-NQuYDzkzAg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers at biblibre.co | |m --- Comment #143 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- *** Bug 9426 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:25:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:25:53 +0000 Subject: [Koha-bugs] [Bug 9370] use Library::CallNumber::LC when splitting LC call numbers for spine labels In-Reply-To: <bug-9370-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9370-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9370-70-UUPQcc18tS@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9370 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #8) > Just noting that as of today, the patch series still applies cleanly. Galen, yes but they depend on bug 6281 which fails qa. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:27:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:27:32 +0000 Subject: [Koha-bugs] [Bug 9014] Add time due to slips In-Reply-To: <bug-9014-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9014-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9014-70-X8cIZWEMyG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9014 --- Comment #39 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think we should not add the output of a time normal date fields. It's irritating to the users and not very helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:28:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:28:24 +0000 Subject: [Koha-bugs] [Bug 9425] Template plugins are missing utf8 encoding In-Reply-To: <bug-9425-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9425-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9425-70-3LyiFDzZ8T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8215 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:28:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:28:24 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-5m9Wzh95H1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9425 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:28:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:28:41 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-0xeEQoBFsX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #12 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #11) > You should add a "on delete cascade" option (set null ?) or remove this > constraint. > It is a dilemma: in one case we loose the information, in other one we loose > the constraint :-/ Not cascade, but set null, I don't see the dilemna: with cascade, you delete the item if the borrower is deleted. This is bad :\ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:29:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:29:03 +0000 Subject: [Koha-bugs] [Bug 9425] Template plugins are missing utf8 encoding In-Reply-To: <bug-9425-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9425-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9425-70-tuqBXYBcJl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 --- Comment #9 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Bug 8215 has introduced new template plugins with utf8 encoding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:31:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:31:42 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-JlEgedz5kK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #144 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- With this feature, we get new template plugins but are there not duplicated for : - authorised value : AuthorisedValues.pm / KohaAuthorisedValues.pm - branch name : Branches.pm / KohaBranchName.pm Should the old Koha*.pm ones be removed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:34:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:34:25 +0000 Subject: [Koha-bugs] [Bug 9014] Add time due to slips In-Reply-To: <bug-9014-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9014-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9014-70-ChGBwvpRcb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9014 --- Comment #40 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #39) > I think we should not add the output of a time normal date fields. It's > irritating to the users and not very helpful. My patch fixes that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:36:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:36:54 +0000 Subject: [Koha-bugs] [Bug 9425] Template plugins are missing utf8 encoding In-Reply-To: <bug-9425-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9425-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9425-70-8V7tN83alB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy at rijksmuseum.nl | --- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #9) > Bug 8215 has introduced new template plugins with utf8 encoding. With the revert of bug 6554 we are just messing around with encoding.. If you feel that this report now functions well, please set the status back to Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:36:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:36:57 +0000 Subject: [Koha-bugs] [Bug 9014] Add time due to slips In-Reply-To: <bug-9014-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9014-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9014-70-EjDbRgUNbc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9014 --- Comment #41 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Cool, I'm glad - thx Jonathan! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:38:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:38:18 +0000 Subject: [Koha-bugs] [Bug 10377] fix_unimarc_100 could be improved with 210$d values In-Reply-To: <bug-10377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10377-70-xMnAYFiP8n@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10377 --- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> --- (In reply to comment #3) > How about something in this style: sounds good > if ($s100a08 =~ /[abcdefghijku]/ && > $s100a09_12 =~ /\d{4}/ && > $s100a09_12 >= 1455 && > $s100a09_12 <= $year_now + 1) { # +1 just in case the is a next year date I really love the >= 1455 :D :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:38:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:38:27 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9011-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9011-70-PH1FZL7X8j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #12) > (In reply to comment #11) > > You should add a "on delete cascade" option (set null ?) or remove this > > constraint. > > It is a dilemma: in one case we loose the information, in other one we loose > > the constraint :-/ > Not cascade, but set null, I don't see the dilemna: with cascade, you delete > the item if the borrower is deleted. This is bad :\ Yes, not cascade, of course. But with set NULL, we loose the information. If the borrowernumber is kept in the last_returned_by field, we can retrieve it using the deletedborrowers table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:40:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:40:12 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10263-70-QeX1ALFQrx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10278 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:40:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:40:12 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10278-70-oYv8BwOSMe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10263 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:45:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:45:23 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-LZVNL2x7M7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #145 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #144) > With this feature, we get new template plugins but are there not duplicated > for : > - authorised value : AuthorisedValues.pm / KohaAuthorisedValues.pm > - branch name : Branches.pm / KohaBranchName.pm > > Should the old Koha*.pm ones be removed? Yep I think. Especially because Koha* plugins don't deal with encoding issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:47:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:47:46 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-0HXogsWwO3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- The 3.12 version of this patch has been pushed to 3.12.x, will be in 3.12.1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:48:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:48:11 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-Pc0TYolamq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18483|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:48:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:48:17 +0000 Subject: [Koha-bugs] [Bug 10367] Allow packages to work on debian wheezy In-Reply-To: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10367-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10367-70-4fCTICVQxu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10367 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:48:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:48:48 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10263-70-8p6Wc5ISpu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10206 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 15:48:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 13:48:48 +0000 Subject: [Koha-bugs] [Bug 10206] Add Koha TT Plugin In-Reply-To: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10206-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10206-70-oFlIkt6Nzu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10206 Kyle M Hall <kyle.m.hall at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10263 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:05:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:05:53 +0000 Subject: [Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian() In-Reply-To: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10277-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10277-70-CpTrAk9c0c@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18427|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18518&action=edit Bug 10277 - Add C4::Context->IsSuperLibrarian() The method of checking the logged in user for superlibrarian privileges is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least. The codebase is littered with these lines, with no explanation given. It would be much better if we had one subroutine that returned a boolean value to tell us if the logged in user is a superlibrarian or not. Test Plan: 1) Apply this patch 2) Verify superlibrarian behavior remains unchanged -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:06:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:06:13 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10276-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10276-70-xyeFORdoRr@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18479|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18519&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:06:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:06:22 +0000 Subject: [Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches In-Reply-To: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10278-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10278-70-3WTXqpQMX0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18420|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18520&action=edit Bug 10278 - Add ability to hide items and records from search results for Independent Branches For the staff intranet, enabling IndependentBranchesRecordsAndItems will automatically add a branch limit filter to the search results thus hiding all records without one or more items owned by the logged in library. In add addition, all items whose homebranch is not that libraries will be filtered and hidden from the search results and record details. This system preference will not affect the OPAC, unless the environment variable BRANCHCODE is defined in the koha-httpd.conf file. If it is defined, the same filters are applied to the OPAC, but based on the branchcode value of the environment variable BRANCHCODE, rather than the logged in branch. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Perform a search that will give results for both records which have items owned by the logged in library, and records which have no items owned by the logged in library. 4) Enable the new system preference IndependentBranchesRecordesAndItems 5) Perform the same search again, any records without items owned by the currently logged in library should not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:06:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:06:32 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10263-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10263-70-7MxsL5ssBD@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18480|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18521&action=edit Bug 10263 - Add ability to limit which branch can edit a bibliographic record ( IndependentBranchesMarcEditing ) Right now, it's possible to limit who can edit items by using IndependantBranches. However, Koha has no method of limiting who can edit bibliographic records, as they have no defined owner. This patch adds a new system preference IndependentBranchesMarcEditing. If this new syspref is enabled, a librarian can only edit or delete a bib record if his or her logged in branch code matches the branchcode in biblio.branchcode. This feature does not affect the ability to edit or delete items, as that functionality is determined by IndependantBranches. This patch adds the 'branches_optional' field to the authorised values pulldown for MARC fields and subfields in the MARC frameworks editor. 'branches_optional' behaves exactly like 'branches' except it includes an "empty" choice so the branch does not have to be set. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Map a nonrepeatable field/subfield to biblio.branchcode ( e.g. 951$o ) Pro-tip: Use the authorised value 'branches_optional' to get a pulldown of libraries instead of entering the branchcode manually. 4) Edit a record, and add a branchcode. 5) Log in as a non-superlibrarian with cataloging priveleges 6) Change the logged in branch to a branch other than the one you entered in the record. 7) You should note the 'edit' pulldown for the record is missing the "Edit record" and "Delete record" options. 8) Switch the logged in branch to match the branchcode of the record. 9) You should now see the edit and delete options for that record. 10) Attempt to edit a record with no branchcode defined, you should be able to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:13:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:13:56 +0000 Subject: [Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop In-Reply-To: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9505-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9505-70-mQtnMbrS2A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:21:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:21:14 +0000 Subject: [Koha-bugs] [Bug 10381] New: Hide basket links should be improved Message-ID: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10381 Bug ID: 10381 Summary: Hide basket links should be improved Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com Get back 2 patchs from bug 9824 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:21:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:21:26 +0000 Subject: [Koha-bugs] [Bug 10381] Hide basket links should be improved In-Reply-To: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10381-70-dgQ24yze8O@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10381 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:22:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:22:37 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-KpQwFt3a2U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18332|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:22:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:22:41 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-7il2NfOpcE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18506|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:23:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:23:12 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-SZycGTOzOO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18184|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:23:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:23:32 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-RSKv0vt6le@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18219|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:23:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:23:49 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-WS6xOVpDWe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18221|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:24:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:24:41 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-zhAEgYUisC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #75 from Jonathan Druart <jonathan.druart at biblibre.com> --- All 3 patches of this bug have been pushed to master and 3.12 branches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:24:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:24:50 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-sr4KU4VEuk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:25:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:25:18 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-04SYaU4PqJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:26:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:26:15 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-t2wsDqNm6K@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10381 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:26:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:26:15 +0000 Subject: [Koha-bugs] [Bug 10381] Hide basket links should be improved In-Reply-To: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10381-70-bMSLurgzJk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10381 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9824 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:27:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:27:50 +0000 Subject: [Koha-bugs] [Bug 10381] Hide basket links should be improved In-Reply-To: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10381-70-pFNI6rjSl5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10381 --- Comment #1 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18522&action=edit Bug 10381: POD lines of GetBasketsInfosByBookseller Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Cedric Vita <cedric.vita at dracenie.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:27:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:27:53 +0000 Subject: [Koha-bugs] [Bug 10381] Hide basket links should be improved In-Reply-To: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10381-70-QTPCelbMVW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10381 --- Comment #2 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18523&action=edit Bug 10381: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. With thanks to Owen for some rewording. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Pierre Angot <tredok.pierre at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:28:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:28:27 +0000 Subject: [Koha-bugs] [Bug 10381] Hide basket links should be improved In-Reply-To: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10381-70-Kl4QnaUGgU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10381 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:29:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:29:09 +0000 Subject: [Koha-bugs] [Bug 10381] Hide basket links should be improved In-Reply-To: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10381-70-dfBUoJq1Hx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10381 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- These 2 patches have been signed off on bug 9824 by C?dric Vita and Pierre Angot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:32:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:32:35 +0000 Subject: [Koha-bugs] [Bug 10381] Hide basket links should be improved In-Reply-To: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10381-70-RNRGrG6syg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10381 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- String patches. Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:32:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:32:58 +0000 Subject: [Koha-bugs] [Bug 10381] Hide basket links should be improved In-Reply-To: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10381-70-V0ERl68DGP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10381 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18522|0 |1 is obsolete| | Attachment #18523|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18524&action=edit Bug 10381: POD lines of GetBasketsInfosByBookseller Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Cedric Vita <cedric.vita at dracenie.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:33:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:33:02 +0000 Subject: [Koha-bugs] [Bug 10381] Hide basket links should be improved In-Reply-To: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10381-70-Fzslku1YLx@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10381 --- Comment #6 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18525&action=edit Bug 10381: Followup adding some text around Apply/cancel filter. The texts Apply/cancel filter did not need translation and were used to get this change into 3.12. For 3.12.X or 3.14 we can add some words to clarify its meaning. With thanks to Owen for some rewording. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Pierre Angot <tredok.pierre at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:34:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:34:18 +0000 Subject: [Koha-bugs] [Bug 10382] New: collection not returning to null when removed from course reserves Message-ID: <bug-10382-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Bug ID: 10382 Summary: collection not returning to null when removed from course reserves Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: kyle at bywatersolutions.com Reporter: nengard at gmail.com CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 8215 If an item that is on reserves did not have a collection code and one was added a the time of adding the reserve then when you remove the item from reserves the collection is not returned to NULL instead it stays as what it was set in reserves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:34:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:34:18 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-ibNhGB9AeK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Nicole C. Engard <nengard at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10382 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 16:56:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 14:56:28 +0000 Subject: [Koha-bugs] [Bug 8662] Remove unused famfamfam icons In-Reply-To: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8662-70-ijBnNFDfZ8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #9 from Jonathan Druart <jonathan.druart at biblibre.com> --- Owen, could you resubmit a rebased patch please? Applying: Bug 8662 - Remove unused famfamfam icons Using index info to reconstruct a base tree... error: patch failed: koha-tmpl/opac-tmpl/lib/famfamfam/mini/readme.txt:1 error: koha-tmpl/opac-tmpl/lib/famfamfam/mini/readme.txt: patch does not apply Did you hand edit your patch? It does not apply to blobs recorded in its index. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 17:01:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 15:01:02 +0000 Subject: [Koha-bugs] [Bug 8337] System preferences for longoverdue cron In-Reply-To: <bug-8337-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8337-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8337-70-2zVeZPYOWK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> --- QA comment: Didn't test the patch, but the 3 syspref are not added to updatedatabase.pl and sysprefs.sql Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 17:01:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 15:01:07 +0000 Subject: [Koha-bugs] [Bug 10383] New: printable version of bib record doesn't include subtitle in staff client Message-ID: <bug-10383-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10383 Bug ID: 10383 Summary: printable version of bib record doesn't include subtitle in staff client Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: nengard at gmail.com Created attachment 18526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18526&action=edit printable without subtitle When clicking the print button on a bib record the printed version doesn't have the subtitle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 17:12:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 15:12:28 +0000 Subject: [Koha-bugs] [Bug 6281] Bug in LCC sort routine In-Reply-To: <bug-6281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6281-70-ggetmcg5CZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6281 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 17:12:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 15:12:30 +0000 Subject: [Koha-bugs] [Bug 6281] Bug in LCC sort routine In-Reply-To: <bug-6281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6281-70-MQBIEMIOzu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6281 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14714|0 |1 is obsolete| | Attachment #14715|0 |1 is obsolete| | Attachment #14716|0 |1 is obsolete| | --- Comment #10 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18527&action=edit bug 6281: add test case for sorting LC call numbers correctly My thanks to Michael Flanagan of UCAR for providing some of these examples. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 17:13:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 15:13:03 +0000 Subject: [Koha-bugs] [Bug 6281] Bug in LCC sort routine In-Reply-To: <bug-6281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6281-70-AowogbcTZ3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6281 --- Comment #11 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18528&action=edit bug 6281: introduce LC::CallNumber::LC for sorting LC call numbers This replaces the previous hand-coded normalizer. Because LC::CallNumber::LC appears to reject strings that aren't valid LC call numbers, significant changes to the test cases were made as well -- however, the one that really counts is the last one which verifies the sorting. To recalculate the call number sort key for each item, it is necessary to run misc/maintenance/touch_all_items.pl To test, create item records with the following call numbers, setting the classification sort to 'lcc': QC100 .U57 NO. 555 1986 QC145 .A57 V.12 1980 QC145.45 .H4 D65 1998 QC995 .E29 1997 Next, make a report of them in the inventory tool. The items should be sorted in the above order. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 17:13:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 15:13:13 +0000 Subject: [Koha-bugs] [Bug 6281] Bug in LCC sort routine In-Reply-To: <bug-6281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6281-70-f7xbGyladw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6281 --- Comment #12 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18529&action=edit bug 6281: add Library::CallNumber::LC as a required Perl dependency This module is currently packaged by Debian for Wheezy and by Ubuntu for Precise and Quantal. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 17:13:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 15:13:56 +0000 Subject: [Koha-bugs] [Bug 6281] Bug in LCC sort routine In-Reply-To: <bug-6281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6281-70-4yBaWWXu9r@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6281 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 17:18:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 15:18:41 +0000 Subject: [Koha-bugs] [Bug 6281] Bug in LCC sort routine In-Reply-To: <bug-6281-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6281-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6281-70-l7zmGdPax0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6281 --- Comment #13 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #8) > I created an inventory with callnumber from QC100 .U57 NO. 555 1986 to QC995 > .E29 1997 and it returns items with the following order: > QC100 .U57 NO. 555 1986 > QC145.45 .H4 D65 1998 > QC145 .A57 V.12 1980 > QC20.45 .H4 D65 1998 > QC995 .E29 1997 > > It seems that QC145.45 .H4 D65 1998 and QC145 .A57 V.12 1980 are inverted. > > What I missed? I'm not seeing the problem. If you retest, please confirm that the items actually have cn_source set to 'lcc'. If you continue to run into the problem, please post the output of an SQL query that lists cn_source, cn_sort, and itemcallnumber for the relevant items. > Perhaps I didn't understand what you meant by "setting the classification > sort to 'lccl'". 'lccl' is a typo ? I have updated the patch series to fix the typo in the commit message and a trivial merge conflict in C4/PerlDepencies.pm, and set the status back to signed off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 17:33:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 15:33:30 +0000 Subject: [Koha-bugs] [Bug 8845] Add ability search patrons by date of birth In-Reply-To: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8845-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8845-70-3jM5M2S8z1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8845 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #32 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Kyle and Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 17:42:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 15:42:05 +0000 Subject: [Koha-bugs] [Bug 10381] Hide basket links should be improved In-Reply-To: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10381-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10381-70-CC4mZYtLJK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10381 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 17:42:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 15:42:49 +0000 Subject: [Koha-bugs] [Bug 10083] In Transit string doesn't get translated in the staff interface In-Reply-To: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10083-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10083-70-KfTcEN4Ia2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10083 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 18:08:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 16:08:00 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8215-70-rJS03IAl5v@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #146 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- *** Bug 9425 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 18:08:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 16:08:00 +0000 Subject: [Koha-bugs] [Bug 9425] Template plugins are missing utf8 encoding In-Reply-To: <bug-9425-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9425-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9425-70-W3BOT9XfMU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9425 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- This bug is obsolete due to Bug 8215 integration. *** This bug has been marked as a duplicate of bug 8215 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 19:04:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 17:04:39 +0000 Subject: [Koha-bugs] [Bug 10383] printable version of bib record doesn't include subtitle in staff client In-Reply-To: <bug-10383-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10383-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10383-70-1pzAdzlZ8h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10383 mathieu saby <mathieu.saby at univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 19:23:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 17:23:44 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-HnaxLgzUzq@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #25 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #22) > Just to know, what kind of records in Koha are not MARC records? I don't > understand. Patron records, loan records, vendor records, etc. The word 'record' by itself is about as nonspecific as you get can get when referring to entities in a DBMS-backed application, IMO. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 19:26:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 17:26:19 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-pwrgllG16p@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #26 from mathieu saby <mathieu.saby at univ-rennes2.fr> --- Of course! In french, record is translated by "notice" only for bib and auth record. For the other meanings, we use different words (fiche, enregistrement, etc), so I did not see it as so a wide concept... M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 19:29:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 17:29:11 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-yPznIY7Sf0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 --- Comment #27 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #21) > I've decided I'm attached to Koha::Record, because my reasoning behind using > it was that it would be nice to be able to merge non-MARC records, so I've > gone a bit further in a follow-up and made the class schema-sensitive, > moving the MARC-specific code to Koha::Util::MARC. For the reason expressed in my previous comment, 'Koha::Record' is still too non-specific for my taste. Would 'Koha::MetadataRecord' be acceptable to you? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 19:40:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 17:40:58 +0000 Subject: [Koha-bugs] [Bug 10218] In OPAC XSLT search results, add class to 'online access' In-Reply-To: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10218-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10218-70-7PWPCptnmF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #10 from Galen Charlton <gmcharlt at gmail.com> --- I pinged Magnus on IRC about this bug, as presumably the NORMARC stylesheets should be updated as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 20:45:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 18:45:24 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-DSf1IrhtWn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED --- Comment #76 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #75) > All 3 patches of this bug have been pushed to master and 3.12 branches No, this is not true. Somehow you obsoleted the two followups. I will try to recover them now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 20:45:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 18:45:53 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-ZYcW4gxDUg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 20:46:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 18:46:11 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-ktC5MaBhmL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18219|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 20:46:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 18:46:32 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-YrMchf6Lz3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18221|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 20:47:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 18:47:02 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-5jIoAjbjLu@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18332|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 20:47:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 18:47:48 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-BPsWUvp8PR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18506|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 20:48:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 18:48:28 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-p3nFa2T06Q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18506|Bug 9824: Followup adding |[SIGNED_OFF] Bug 9824: description|some text around |Followup adding some text |Apply/cancel filter. |around Apply/cancel filter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 20:48:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 18:48:41 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-DuuWU4iWbX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 20:48:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 18:48:54 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-qYtiVanv3Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 20:55:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 18:55:01 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-YlTBgI5JwC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #77 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- The two followups 18332 and 18506 are now signed off. They apply fine to current master. Although I wrote them, they are actually QA followups on the three patches pushed before. Since they only pertain to a small textual change and some POD lines, I am setting the status to Passed QA myself, herewith ending the confusion about the status of this report. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 20:57:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 18:57:13 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-zwhlamebIv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #78 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #76) > (In reply to comment #75) > > All 3 patches of this bug have been pushed to master and 3.12 branches > > No, this is not true. Somehow you obsoleted the two followups. > I will try to recover them now. And now I see the move of these patches to another report, aaaargggghhh. OK. Please add a comment if you do so. Will obsolete everything again.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 20:57:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 18:57:39 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-Oo7ZwMnS2z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18506|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 20:57:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 18:57:42 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-xMcKza4j67@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18332|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 21:07:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 19:07:10 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-BM254ETevk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18221|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 21:08:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 19:08:32 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-F6qyMayyhb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18219|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 21:09:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 19:09:44 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-9aXp1sIQlB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18184|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 21:13:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 19:13:19 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-DoqiRfzaym@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #79 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Restored the situation now where Jonathan left it. Learned something more about Bugzilla :) The two followups on these three reports are on bug 10381. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 21:18:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 19:18:29 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-VQXhFS7dpO@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #80 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #79) > The two followups on these three reports are on bug 10381. reports -> patches No confusion anymore now? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 21:20:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 19:20:06 +0000 Subject: [Koha-bugs] [Bug 9618] Add support for intranetuserjs to labels/spinelabel-print.pl In-Reply-To: <bug-9618-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9618-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9618-70-XamAvuWKn1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- > I think the jQuery lib should only be include if user had defined js code. That makes sense to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 21:38:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 19:38:02 +0000 Subject: [Koha-bugs] [Bug 10377] fix_unimarc_100 could be improved with 210$d values In-Reply-To: <bug-10377-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10377-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10377-70-g87nriSFE7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10377 --- Comment #5 from Janusz Kaczmarek <januszop at gmail.com> --- (In reply to comment #4) > I really love the >= 1455 :D :D Oh, yes, I know, I am sorry--it is very exclusive and europocentric... but not as much as the line 661 in the present version of the script ;^) Now seriously: I did not make an experiment but while flicking though the code it seems to me that the function in question is executed both for bibliographic adn authority records. If that was the case one should keep in mind that field 100 in UNIMARC authorities should be of the length of 24. So now field 100 in authorities would be always destroyed and incorrect in the zebra copy of the database... Could you confirm or deny my intuition? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 21:41:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 19:41:16 +0000 Subject: [Koha-bugs] [Bug 8662] Remove unused famfamfam icons In-Reply-To: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8662-70-JHKN3dxOe8@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 21:41:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 19:41:22 +0000 Subject: [Koha-bugs] [Bug 8662] Remove unused famfamfam icons In-Reply-To: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8662-70-K7vmIwTQgC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13940|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18530&action=edit [SIGNED-OFF] Bug 8662 - Remove unused famfamfam icons This patch removes images in the famfamfam directory which are unused by Koha. Files to delete were chosen based on a search of the Koha source. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 22:36:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 20:36:49 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: <bug-7973-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7973-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7973-70-Hjz0us6CgV@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 David Burke <dmbst32 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dmbst32 at gmail.com --- Comment #18 from David Burke <dmbst32 at gmail.com> --- I believe this change has broken ldap for me. I'm new to this so please correct me if I'm wrong. As stated the new way to authenticate in Koha 4.12 seems to work like this: 1 - LDAP anonymous bind; 2 - LDAP search entry for the given username; 3 - LDAP bind with the DN of the found entry + the given password. In my case with Active Directory it's possible to bind anonymously but the anon user is not allowed to search. So I get something this in step 2. (sAMAccountName=dburke) gets 0 hits, I reverted the patch and it works again. I also had to remove a return 0; on line 130 of Auth_with_ldap.pm. Not sure what this is about. I suspect this would break a good number of ldap set ups. I know Zentyal 3.0's openldap schema follows the same behavior of not allowing anon users to search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 23:37:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 21:37:55 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: <bug-7973-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7973-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7973-70-wBwSNVhBB5@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #19 from Chris Cormack <chris at bigballofwax.co.nz> --- (In reply to comment #18) > I believe this change has broken ldap for me. I'm new to this so please > correct me if I'm wrong. > > As stated the new way to authenticate in Koha 4.12 seems to work like this: > 1 - LDAP anonymous bind; > 2 - LDAP search entry for the given username; > 3 - LDAP bind with the DN of the found entry + the given password. > 3.12 right? > In my case with Active Directory it's possible to bind anonymously but the > anon user is not allowed to search. So I get something this in step 2. > > (sAMAccountName=dburke) gets 0 hits, > > I reverted the patch and it works again. I also had to remove a return 0; on > line 130 of Auth_with_ldap.pm. Not sure what this is about. > > I suspect this would break a good number of ldap set ups. I know Zentyal > 3.0's openldap schema follows the same behavior of not allowing anon users > to search. That sounds like a real valid issue, could you please open a new bug. With this bug report (id mark it critical maybe even blocker) And as much information as you can. My suggestion for a patch to fix it, would be to make the new behaviour configurable in the koha-conf.xml so that it can be turned on for those who want it. Off for those like yourself that it breaks. It would be even more awesome if you could that patch, I would buy you a beverage of your choice at Kohacon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu May 30 23:55:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 21:55:58 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: <bug-7973-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7973-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7973-70-KcRDIdKyVg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #20 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #18) > I suspect this would break a good number of ldap set ups. I know Zentyal > 3.0's openldap schema follows the same behavior of not allowing anon users > to search. And as part of exploring the option space and helping make sure that everybody ends up happy, does anybody know of specific (preferably FL/OSS) LDAP servers that by default *do* allow anon users to seearch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 01:46:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 23:46:56 +0000 Subject: [Koha-bugs] [Bug 9755] Record merge code needs to be refactored In-Reply-To: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9755-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9755-70-M58OavgcNh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18513|0 |1 is obsolete| | --- Comment #28 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18531 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18531&action=edit Bug 9755 QA follow-up: move MARC-specific functionality to utility class This follow-up moves all the MARC-specific functionality of Koha::Record (now renamed to Koha::MetadataRecord) to a Koha::Util::MARC utility class. To test, run relevant unit tests: > prove t/Koha_MetadataRecord.t t/Koha_Util_MARC.t t/db_dependent/Authority.t and optionally try to merge a record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 01:47:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 30 May 2013 23:47:09 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-5202-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5202-70-VYrWzrzZV4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Jared Camins-Esakov <jcamins at cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18516|0 |1 is obsolete| | --- Comment #7 from Jared Camins-Esakov <jcamins at cpbibliography.com> --- Created attachment 18532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18532&action=edit Bug 5202: merge authorities from the authority file and reservoir This patch gives Koha the ability to merge authority records using the same interface used by bibliographic records, though slightly different methods for selecting which records to merge. The two ways to select records are as follows: 1) Records can be selected from authority search results by clicking the "Merge" link for two records. 2) Authority records can be merged from the reservoir by clicking the merge-related links in the Manage staged MARC batch screen. To test: 1) Apply patch. 2) Do a search for an authority record that will turn up multiple identical records (or at least two records that you don't mind merging). 3) Click the "Merge" link for the first record. 4) Click the "Merge" link for the second record. 5) Choose which fields from which record you want to appear in the resulting record. 6) Confirm that those are the fields that exist in the resulting record. 7) Stage an authority record (for example, an authority record you saved from your catalog. 8) Search for a record to merge with it using the "Search for a record to merge in a new window" link. 9) Merge these records, confirming that the resulting record (after going through the entire merging process) matches your expectations. 10) Set up a matching rule for authorities, and export an authority from your catalog that will match based on that rule. For MARC21, the following is a good choice for a rule: Matching rule code: AUTHPER Description: Personal name main entry Match threshold: 999 Record type: Authority record [Match point 1:] Search index: mainmainentry Score: 1000 Tag: 100 Subfields: a 11) Stage the record you just exported, choosing the matching rule you just created. 12) Merge the record using the "Merge" link, confirming that the resulting record (after going through the entire merging process) matches your expectations. 13) Sign off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 05:06:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 03:06:08 +0000 Subject: [Koha-bugs] [Bug 10326] bulkmarcimport.pl turns off CataloguingLog sys pref In-Reply-To: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10326-70-VtJojeJXNs@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 05:06:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 03:06:10 +0000 Subject: [Koha-bugs] [Bug 10326] bulkmarcimport.pl turns off CataloguingLog sys pref In-Reply-To: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10326-70-p87VbrZJRU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18375|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18533&action=edit Bug 10326: bulkmarcimport.pl doesn't restore value of CataloguingLog syspref To test: 0) Don't apply the patch yet. 1) Have the CataloguingLog system preference set to 'Log'. 2) Import a file of bibliographic records with bulkmarcimport.pl. 3) Check the state of CataloguingLog system preference -- it will be set to 'Don't log'. 4) Apply the patch. 5) Repeat steps 1-3. The CataloguingLog system preference will be 'Log'. Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 05:28:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 03:28:15 +0000 Subject: [Koha-bugs] [Bug 9712] Add command line script to recalculate existing due dates based on current issuing rules and retroactively update the issues In-Reply-To: <bug-9712-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9712-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9712-70-MLak5jQc1k@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9712 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton <gmcharlt at gmail.com> --- What is the use case you see for this? Particularly in a production situation, retroactively changing due dates on patrons seems a bit drastic (particularly if the loan period gets shortened). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 05:32:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 03:32:15 +0000 Subject: [Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl In-Reply-To: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8436-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8436-70-Jedn48x8Hw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton <gmcharlt at gmail.com> --- Patch does not apply; please rebase and resubmit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 05:34:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 03:34:25 +0000 Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7288-70-KVNrFs39D3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gmcharlt at gmail.com --- Comment #3 from Galen Charlton <gmcharlt at gmail.com> --- Patch does not apply. Please rebase and resubmit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 05:35:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 03:35:56 +0000 Subject: [Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP In-Reply-To: <bug-9165-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9165-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9165-70-WboUVLDICg@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton <gmcharlt at gmail.com> --- Patch does not apply. Please rebase and resubmit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 05:39:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 03:39:11 +0000 Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support In-Reply-To: <bug-6273-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6273-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6273-70-acRlSGEpbn@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton <gmcharlt at gmail.com> --- The rebased patch no longer applies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 05:46:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 03:46:27 +0000 Subject: [Koha-bugs] [Bug 10296] UT: db schemas are useless In-Reply-To: <bug-10296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10296-70-cFKF81pmDe@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10296 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 05:46:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 03:46:29 +0000 Subject: [Koha-bugs] [Bug 10296] UT: db schemas are useless In-Reply-To: <bug-10296-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10296-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10296-70-w65kHES3fW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10296 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18266|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18534 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18534&action=edit Bug 10296: UT: t/data/db_schemas not needed Signed-off-by: Galen Charlton <gmc at esilibrary.com> These were added with the intention of writing some schema verification test cases, but if that idea gets picked up again in the future, fresher copies of kohastructure.sql can be obtained from Git. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 05:55:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 03:55:14 +0000 Subject: [Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP In-Reply-To: <bug-9165-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9165-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9165-70-27asAwGFBU@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13754|0 |1 is obsolete| | --- Comment #5 from Robin Sheat <robin at catalyst.net.nz> --- Created attachment 18535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18535&action=edit Bug 9165 - Prevent LDAP passwords being stored locally This adds a configuration option to LDAP that prevents it from storing user's passwords in the local database. This is useful when users of hosted Koha wish to prevent any form of offsite password storage for security reasons. Notes: * if the option is not included in the koha-conf.xml file, then the current default behaviour of saving the password locally is retained. * this has no impact on passwords that are already in the database. They will not be erased. To use: * edit the koha-conf.xml for a system that uses LDAP for authentication. * in the <ldapserver> configuration, add: <update_password>0</update_password> * feel a greater sense of security. To test: 1) have a Koha system that authenticates using LDAP. 2) note that when a user logs in, their password is saved (hashed) in the database. 2.5) it is important to note that, for whatever reason, a user's password is not stored on a login where their account is created, only when they log in after being created. Thus perhaps log in and log out a couple of times to be sure. 3) add the <update_password>0</update_password> option to the <ldapserver> section of koha-conf.xml. 4) login with a new user (or erase the password from the database for an existing user) and note that the password field is not populated. 5) log out and log back in just to be sure, check the password field again. Sponsored-By: National Institute of Water and Atmospheric Research (NIWA) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 05:55:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 03:55:43 +0000 Subject: [Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP In-Reply-To: <bug-9165-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9165-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9165-70-cKe8FyiJ6U@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165 Robin Sheat <robin at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Robin Sheat <robin at catalyst.net.nz> --- (In reply to comment #4) > Patch does not apply. Please rebase and resubmit. Done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 07:55:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 05:55:40 +0000 Subject: [Koha-bugs] [Bug 10300] Revert Bug 8781 - Access to Transfer page while "independent branches" is on In-Reply-To: <bug-10300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10300-70-tzHEHP4y5L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #2 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- I'm not trying to dispute, just want a confirmation - the problem you describe would occur only with independent branches. Is that a legitimate scenario to transfer between independent branches on daily bases? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 08:01:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 06:01:49 +0000 Subject: [Koha-bugs] [Bug 10320] Show results from library's OverDrive collection in OPAC search In-Reply-To: <bug-10320-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10320-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10320-70-4dO4x5rD2o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10320 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 08:29:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 06:29:57 +0000 Subject: [Koha-bugs] [Bug 10362] on return with reserve or transfer the alerts are not shown In-Reply-To: <bug-10362-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10362-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10362-70-WuX0nK1BKj@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10362 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18429|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic <srdjan at catalyst.net.nz> --- Created attachment 18536 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18536&action=edit Bug 10362 - on return with reserve or transfer the alerts are not shown When a return is performed on an item with a reserve or a transfer, the possible alert messages are not shown. These alerts are cases from errmsgloop like "NotIssued", "debarred" ... This patch changes the template to show both messages and alerts. Test plan : - Perform an checkout that will a checkin : * need a transfert (return in a different branch) * set user debarred (depends on issuing rules) - Perform check-in => You get tranfert message and debarment alert Signed-off-by: Srdjan <srdjan at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 08:32:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 06:32:34 +0000 Subject: [Koha-bugs] [Bug 10362] on return with reserve or transfer the alerts are not shown In-Reply-To: <bug-10362-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10362-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10362-70-drenWNbH95@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10362 Srdjan Jankovic <srdjan at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 09:27:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 07:27:17 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-dTIjH54GOf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #81 from Jonathan Druart <jonathan.druart at biblibre.com> --- Sorry Marcel, I should have add a comment in addition to the "see also" field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 09:48:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 07:48:56 +0000 Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7288-70-LomxCUvudP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 09:48:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 07:48:58 +0000 Subject: [Koha-bugs] [Bug 7288] Invoice improvements - Show only subscriptions In-Reply-To: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7288-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7288-70-vK7aiYl5A9@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7288 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13246|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18537&action=edit Bug 7288: Allow to display only subscriptions in the invoices table This patch adds a checkbox "Show only subscriptions" in the invoices table. If this checkbox is checked, a filter is added on the table in order to show only subscription invoices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 09:54:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 07:54:35 +0000 Subject: [Koha-bugs] [Bug 8662] Remove unused famfamfam icons In-Reply-To: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8662-70-vNHATPoNbH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 --- Comment #11 from Jonathan Druart <jonathan.druart at biblibre.com> --- Owen, I'm still getting the same error applying the last patch :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 09:55:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 07:55:23 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-o3euBne5EP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 --- Comment #4 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Created attachment 18538 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18538&action=edit Patch for occurence in request.pl Moves the display logic to the template. To Test place a hold use a oartial borrower name you should get a dropdown select list of borrowers and be able to select the borrower for the hold from there. The functionality should remain unimpaired after this patch is applied -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 10:12:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 08:12:23 +0000 Subject: [Koha-bugs] [Bug 10326] bulkmarcimport.pl turns off CataloguingLog sys pref In-Reply-To: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10326-70-geieGmf9n1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart at biblibre.com> --- sounds logical, marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 10:12:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 08:12:31 +0000 Subject: [Koha-bugs] [Bug 10326] bulkmarcimport.pl turns off CataloguingLog sys pref In-Reply-To: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10326-70-XrBL93aCxh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 10:13:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 08:13:19 +0000 Subject: [Koha-bugs] [Bug 10326] bulkmarcimport.pl turns off CataloguingLog sys pref In-Reply-To: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10326-70-u2XReIAH2T@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Jonathan Druart <jonathan.druart at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18533|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at biblibre.com> --- Created attachment 18539 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18539&action=edit Bug 10326: bulkmarcimport.pl doesn't restore value of CataloguingLog syspref To test: 0) Don't apply the patch yet. 1) Have the CataloguingLog system preference set to 'Log'. 2) Import a file of bibliographic records with bulkmarcimport.pl. 3) Check the state of CataloguingLog system preference -- it will be set to 'Don't log'. 4) Apply the patch. 5) Repeat steps 1-3. The CataloguingLog system preference will be 'Log'. Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 10:15:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 08:15:53 +0000 Subject: [Koha-bugs] [Bug 10384] New: Software error when LDAP connexion fails Message-ID: <bug-10384-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384 Bug ID: 10384 Summary: Software error when LDAP connexion fails Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com CC: dpavlin at rot13.org When using LDAP authentication, the authentication falls back to normal authentication if user does not exist in LDAP. Actually, if the LDAP server is down, you get a software error (even with mysql user) : Can't call method "bind" on an undefined value at /home/fsomers/workspace/versions/community_master/C4/Auth_with_ldap.pm line 134, <DATA> line 558. This error should be avoided to allow normal authentication when LDAP connexion fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 10:30:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 08:30:24 +0000 Subject: [Koha-bugs] [Bug 10384] Software error when LDAP connexion fails In-Reply-To: <bug-10384-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10384-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10384-70-CkTA4NFQjb@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 18540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18540&action=edit Proposed patch See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 10:30:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 08:30:31 +0000 Subject: [Koha-bugs] [Bug 10384] Software error when LDAP connexion fails In-Reply-To: <bug-10384-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10384-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10384-70-nvOgaCIrQC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 11:03:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 09:03:54 +0000 Subject: [Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl In-Reply-To: <bug-7307-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7307-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7307-70-1L9n6WdBBc@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8952 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 11:03:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 09:03:54 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-OvfAJJIAif@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7307, | |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7770 --- Comment #25 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Jonathan: With another patch, I face the same problem as we do here. Should we add http or https to OPACBaseURL? Note that this is reported under several other bugs too already. Could we separate your last patch from this report, and make it the solution for that problem? I am thinking that we could also add a preference. But if we do that, we could just as easy add http or https to OPACBaseURL and staff, and remove some hardcodes http's in a few templates. What do you think? Added two see also's. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 11:03:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 09:03:54 +0000 Subject: [Koha-bugs] [Bug 7770] usage of OPACBaseURL In-Reply-To: <bug-7770-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7770-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7770-70-4DDmP7m7Od@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7770 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8952 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 11:05:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 09:05:29 +0000 Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data In-Reply-To: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9836-70-BX93nXITiy@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18461|0 |1 is obsolete| | --- Comment #13 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 18541 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18541&action=edit Bug 9836 Filtering sort1 list according to patron category in patron data Hey Jean-Manuel, I corrected a displaying error on the modified sort1 criteria Olivier -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 11:13:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 09:13:37 +0000 Subject: [Koha-bugs] [Bug 9824] Hide basket with no expected items in basket list by bookseller In-Reply-To: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9824-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9824-70-GYXMJMfYal@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9824 --- Comment #82 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #81) > Sorry Marcel, I should have add a comment in addition to the "see also" > field. No problem. Just looking a little bit better could have helped me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 11:37:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 09:37:47 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-YAtIb4fL1Z@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 --- Comment #26 from Jonathan Druart <jonathan.druart at biblibre.com> --- (In reply to comment #25) > Jonathan: > With another patch, I face the same problem as we do here. Should we add > http or https to OPACBaseURL? > Note that this is reported under several other bugs too already. > Could we separate your last patch from this report, and make it the solution > for that problem? > I am thinking that we could also add a preference. But if we do that, we > could just as easy add http or https to OPACBaseURL and staff, and remove > some hardcodes http's in a few templates. > What do you think? > > Added two see also's. Yes maybe it is the solution. All what I know is that the behavior of this pref is not clearly defined and it is used in many places into Koha and certainly does not work everywhere (sometimes it is prefixed with 'http', sometimes not, depending where it is used...). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 12:47:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 10:47:08 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9032-70-qL6HFX5lxC@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #4 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18542 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18542&action=edit Bug 9032: Followup for new dependency Email::Valid Just adds this dependency to PerlDependencies hash. Test plan: You should see it now under About. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 12:47:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 10:47:12 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9032-70-i2NkLl42Sa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #5 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18543&action=edit Bug 9032: Share a list (dbrev for SHARE_INVITE notice) Adds notice in updatedatabase and sample_notices. Test plan: Do install or upgrade and verify that you have the new notice under Tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 14:25:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 12:25:02 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: <bug-7973-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7973-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7973-70-ZihsbpeltI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #21 from Dobrica Pavlinusic <dpavlin at rot13.org> --- We are using OpenLDAP (from Debian packages), but it depends on specific LDAP configuration and not on particular server. I'm not LDAP admin here, but I can ask for configuration settings if that's helpful. We have configuration which allows anonymous searching and returns *some* fields from LDAP but after auth if returns all user attributes (it's EduRoam configuration which is quite common in Europe). I tested this patch with auth by bind (which we use) so I feel somewhat guilty if we broke AD along the way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 14:35:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 12:35:19 +0000 Subject: [Koha-bugs] [Bug 9836] Filtering sort1 list according to patron category in patron data In-Reply-To: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9836-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9836-70-TwPxtDsUjA@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9836 jmbroust <jean-manuel.broust at univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from jmbroust <jean-manuel.broust at univ-lyon2.fr> --- tested on sandbox pro. Seems to work fine. Thanks for someone to do the QA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 14:41:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 12:41:23 +0000 Subject: [Koha-bugs] [Bug 9375] Logging in with LDAP creates duplicate users In-Reply-To: <bug-9375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9375-70-LQ7u1DUkBB@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9375 --- Comment #3 from Dobrica Pavlinusic <dpavlin at rot13.org> --- I can't reproduce this bug. I have created user in Koha with same login as LDAP user, but different password. I can login with both local password and ldap password and don't see any duplication of users (this is sub-optimal, but I'm not using replicate in my ldap config so this is expected behaviour). Having said all this, I do have duplicate users in our production installation which means that bug is valid, I just can't reproduce it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 14:51:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 12:51:30 +0000 Subject: [Koha-bugs] [Bug 9375] Logging in with LDAP creates duplicate users In-Reply-To: <bug-9375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9375-70-eoRplRokoX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9375 --- Comment #4 from Dobrica Pavlinusic <dpavlin at rot13.org> --- Forgot to mention, I tested 3.11.00.202 and 3.13.00.006 (current master) using OPAC login (but intranet uses same code, so it shouldn't matter) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:11:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:11:55 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9032-70-2Qby1XRvGQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #6 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Comment from Robin on dev list: On this note, it's also best to use modules that are packaged in Debian squeeze (which I figure we'll try to support as long as we can) where possible, just to save me the work in making packages for them :) Also, cpan modules that have no license that allows us to redistribute them are a no-no. This doesn't apply to libemail-valid-perl however, it's in squeeze already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:12:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:12:02 +0000 Subject: [Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined In-Reply-To: <bug-10354-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10354-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10354-70-IPoih4iX6A@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:12:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:12:04 +0000 Subject: [Koha-bugs] [Bug 10354] Don't show optgroup Libraries when no search groups are defined In-Reply-To: <bug-10354-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10354-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10354-70-cYUgp0yFxp@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10354 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18544 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18544&action=edit Bug 10354 - Don't show optgroup Libraries when no search groups are defined In the OPAC, if there are no search groups defined, there's no reason to embed library choices inside an <optgroup>. <optgroup> should only be used to differentiate the list of individual libraries from search groups. This patch removes the <optgroup> when no search groups are enabled. To test, apply the patch and: - Enable OpacAddMastheadLibraryPulldown. - Create a library search group in Administration -> Libraries and Groups and enable it by checking the "show in search pulldown" box. - View the library pulldown in the OPAC search bar. Libraries and groups should be separated into <optgroup>s. - Disable your library search group and refresh the OPAC page. The pulldown of libraries should now display libraries with no <optgroup>. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:12:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:12:07 +0000 Subject: [Koha-bugs] [Bug 8662] Remove unused famfamfam icons In-Reply-To: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8662-70-ZKWGGOCYst@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 --- Comment #12 from Jonathan Druart <jonathan.druart at biblibre.com> --- I got another error using --ignore-whitespace: # git am -3 --ignore-whitespace /tmp/BZ8662.patch Applying: Bug 8662 - Remove unused famfamfam icons error: corrupt binary patch at line 7593: z^9B<YSk|5uEYsxu!9bPB+;6=<UKb0;G`E{jgY|m- Using index info to reconstruct a base tree... error: corrupt binary patch at line 7593: z^9B<YSk|5uEYsxu!9bPB+;6=<UKb0;G`E{jgY|m- error: removal patch leaves file contents error: koha-tmpl/opac-tmpl/lib/famfamfam/silk/calculator.png: patch does not apply Did you hand edit your patch? It does not apply to blobs recorded in its index. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:14:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:14:51 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9351-70-64QYM0mI6u@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #2 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Created attachment 18545 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18545&action=edit Proposed patch See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:15:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:15:07 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9351-70-O8fWkKFmsk@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:15:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:15:42 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9032-70-hrfliMn5uH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18260|0 |1 is obsolete| | Attachment #18542|0 |1 is obsolete| | Attachment #18543|0 |1 is obsolete| | --- Comment #7 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18546&action=edit Bug 9032: Share a list (dbrev for SHARE_INVITE notice) Adds notice in updatedatabase and sample_notices. Test plan: Do install or upgrade and verify that you have the new notice under Tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:15:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:15:46 +0000 Subject: [Koha-bugs] [Bug 9032] Share a list In-Reply-To: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9032-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9032-70-p5FmQYbwV4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9032 --- Comment #8 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 18547 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18547&action=edit Bug 9032: Followup for new dependency Email::Valid Just adds this dependency to PerlDependencies module. Note from Robin: libemail-valid-perl is in squeeze already. Test plan: You should see Email::Valid now under About/Perl modules. If Email::Valid is not yet installed on your system, please do so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:15:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:15:45 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9351-70-aLpI59O9nE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:17:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:17:36 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9351-70-inB7OlQFwZ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #3 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- I set the importance to major because statistics are very important for libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:28:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:28:07 +0000 Subject: [Koha-bugs] [Bug 8662] Remove unused famfamfam icons In-Reply-To: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8662-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8662-70-LsnozdQM9i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8662 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18530|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18548&action=edit [SIGNED-OFF] Bug 8662 - Remove unused famfamfam icons This patch removes images in the famfamfam directory which are unused by Koha. Files to delete were chosen based on a search of the Koha source. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:32:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:32:51 +0000 Subject: [Koha-bugs] [Bug 10326] bulkmarcimport.pl turns off CataloguingLog sys pref In-Reply-To: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10326-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10326-70-xRlkgQRsO1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10326 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton <gmcharlt at gmail.com> --- Pushed to master. Thanks, Janusz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:39:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:39:25 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: <bug-7973-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7973-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7973-70-gDDYmjvnCh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #22 from Rolando Isidoro <rolando.isidoro at gmail.com> --- Dobrica, it's been sometime since I wrote the patch, but if I recall it correctly I didn't overwrite the old method for LDAP auth that worked for you. Have you tried setting ?auth_by_bind? to 0 in your koha-conf.xml? Let me know if it works for your that way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:45:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:45:09 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9351-70-tsRRv8bAdh@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 --- Comment #4 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #2) > Created attachment 18545 [details] [review] > Proposed patch > > See commit message Upon reading the patch, I think there's a problem -- it doesn't take the item-level_itypes system preference into account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:45:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:45:18 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9351-70-UHaQxxS04i@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:56:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:56:06 +0000 Subject: [Koha-bugs] [Bug 9712] Add command line script to recalculate existing due dates based on current issuing rules and retroactively update the issues In-Reply-To: <bug-9712-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9712-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9712-70-rd5eud99n0@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9712 --- Comment #6 from Kyle M Hall <kyle.m.hall at gmail.com> --- I agree, it is a drastic measure. This action has become necessary where bugs in Koha have caused loans to have an incorrect due date. Another good case is where a library has incorrectly set up circulation rules and needs to fix their due dates. Often in these cases, the correct due date has been stamped in the book, but the incorrect due date is set in Koha. (In reply to comment #5) > What is the use case you see for this? Particularly in a production > situation, retroactively changing due dates on patrons seems a bit drastic > (particularly if the loan period gets shortened). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:57:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:57:21 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: <bug-7973-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7973-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7973-70-jsm0lhpJkW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #23 from David Burke <dmbst32 at gmail.com> --- I did mean 3.12. I know from experience that Zentyal changed this from version 2.2 > 3.0. They used to allow anon searching. It broke quite a few things for me. In any case it seems reasonable not to allow anon users to see what users exist in LDAP. I'd be happy to test anything with my AD server. Thanks for being so responsive to the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 16:58:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 14:58:51 +0000 Subject: [Koha-bugs] [Bug 9712] Add command line script to recalculate existing due dates based on current issuing rules and retroactively update the issues In-Reply-To: <bug-9712-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9712-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9712-70-LwV177Kura@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9712 --- Comment #7 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #6) > I agree, it is a drastic measure. This action has become necessary where > bugs in Koha have caused loans to have an incorrect due date. Another good > case is where a library has incorrectly set up circulation rules and needs > to fix their due dates. Often in these cases, the correct due date has been > stamped in the book, but the incorrect due date is set in Koha. OK, that makes sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:04:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:04:27 +0000 Subject: [Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC In-Reply-To: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9665-70-k76a89VAvR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:08:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:08:32 +0000 Subject: [Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC In-Reply-To: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9665-70-mYN7hHSSu2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:08:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:08:34 +0000 Subject: [Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC In-Reply-To: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9665-70-tmhcHoVYZW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15651|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18549&action=edit Bug 9665 [Revised] Staff client bibliographic record export missing some options available in the OPAC The OPAC offers RIS and BIBTEX as choices for bibliographic downloads, but the staff client is missing these options. This patch adds them. To test, view a record in the staff client (detail.pl, MARCdetail.pl, etc.) and click the "Save..." toolbar button. BIBTEX and RIS should be available and functional. Revision reimplements the changes on the new Bootstrap version of the menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:25:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:25:35 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-2imGAl884o@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P2 |P5 - low Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:25:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:25:52 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-MCdXr5AnA3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:25:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:25:55 +0000 Subject: [Koha-bugs] [Bug 766] Use of CGI::scrolling_list prevents customization in template In-Reply-To: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-766-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-766-70-MpJ3jJgOkd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18538|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18550&action=edit [SIGNED-OFF] Bug 766 Remove CGI::scrolling_list from request.pl Let the template take care of generating the display. Lets at least part of request.pl be more succinct. To test, place a hold and search for the patron using a partial name. You should get a dropdown select list of patrons and be able to select the patron to hold for from there. The functionality should remain unimpaired after this patch is applied. Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:26:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:26:55 +0000 Subject: [Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC In-Reply-To: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9665-70-dbbaLdlEnE@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:27:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:27:06 +0000 Subject: [Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC In-Reply-To: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9665-70-s83QXNA53L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18549|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:29:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:29:53 +0000 Subject: [Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC In-Reply-To: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9665-70-a5fae7iaFM@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:29:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:29:55 +0000 Subject: [Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC In-Reply-To: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9665-70-bdvd0oWUD3@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18551&action=edit Bug 9665 [Revised] Staff client bibliographic record export missing some options available in the OPAC The OPAC offers RIS and BIBTEX as choices for bibliographic downloads, but the staff client is missing these options. This patch adds them. To test, view a record in the staff client (detail.pl, MARCdetail.pl, etc.) and click the "Save..." toolbar button. BIBTEX and RIS should be available and functional. Revision reimplements the changes on the new Bootstrap version of the menu and corrects a couple of typos. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:30:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:30:21 +0000 Subject: [Koha-bugs] [Bug 9665] Staff client bibliographic record export missing some options available in the OPAC In-Reply-To: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9665-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9665-70-CpQEA2lq1P@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9665 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10351 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:30:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:30:21 +0000 Subject: [Koha-bugs] [Bug 10351] Typo: Missing parenthesis in download options in staff detail pages In-Reply-To: <bug-10351-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10351-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10351-70-tp6AlaBIf1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10351 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9665 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- A fix for this is in the patch for Bug 9665. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:38:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:38:48 +0000 Subject: [Koha-bugs] [Bug 10350] Capitalization: Home Library column in staff detail items table In-Reply-To: <bug-10350-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10350-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10350-70-lG3hXsoo3j@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10350 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 17:38:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 15:38:50 +0000 Subject: [Koha-bugs] [Bug 10350] Capitalization: Home Library column in staff detail items table In-Reply-To: <bug-10350-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10350-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10350-70-oz1OTAAAUG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10350 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18552&action=edit Bug 10350 - Capitalization: Home Library column in staff detail items table "Home library" is incorrectly capitalized on the catalog detail page. This patch corrects it. To test, view the normal view of record in the staff client catalog. The "Home library" table header in the holdings table should be correctly capitalized. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:02:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:02:53 +0000 Subject: [Koha-bugs] [Bug 10350] Capitalization: Home Library column in staff detail items table In-Reply-To: <bug-10350-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10350-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10350-70-OrmskMOphY@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10350 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:03:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:03:01 +0000 Subject: [Koha-bugs] [Bug 10350] Capitalization: Home Library column in staff detail items table In-Reply-To: <bug-10350-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10350-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10350-70-KtCL4lGkJN@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10350 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:03:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:03:40 +0000 Subject: [Koha-bugs] [Bug 10350] Capitalization: Home Library column in staff detail items table In-Reply-To: <bug-10350-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10350-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10350-70-ttG67NN8tP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10350 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #2 from Galen Charlton <gmcharlt at gmail.com> --- Trivial typo fix, easily verified; pushing directly to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:09:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:09:42 +0000 Subject: [Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes tabs in OPAC and staff In-Reply-To: <bug-10349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10349-70-G4QbjrW1kR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18553&action=edit Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff The descriptions/title notes tab appears on the detail page in both staff client and OPAC even if there are no notes. This is probably a relic of the pre-T:T days when it wasn't possible to use || in an IF. This patch adds a check for the various variables which might trigger the display of the tab. To test, apply the patch and view records in the OPAC and staff client which do and do not have title notes attached (whether that be in the MARC reocrd or in the biblio.notes column). In the OPAC Syndetics content should also be tested if possible. The descriptions/title notes tab should only appear if there is content. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:09:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:09:40 +0000 Subject: [Koha-bugs] [Bug 10349] Don't show empty Descriptions/Title notes tabs in OPAC and staff In-Reply-To: <bug-10349-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10349-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10349-70-TRveL9qvZl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10349 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:22:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:22:25 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-eNqLYfHPAH@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #27 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #25) > Jonathan: > With another patch, I face the same problem as we do here. Should we add > http or https to OPACBaseURL? It's a valid configuration to make the OPAC available via both HTTP and HTTPS, so using OPACBaseURL to define the protocol gives me a bit of a twitch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:24:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:24:20 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8956-70-th59zxmkz6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16346|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18554 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18554&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 1 - Add fields to DB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:24:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:24:29 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8956-70-mG9Msnrg7h@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16347|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18555 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18555&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 2 - Store x, y and z in DB when generating new serials -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:24:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:24:38 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8956-70-Zky7o0wNeG@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16348|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18556 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18556&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 3 - Add date pickers to serials-edit.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:24:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:24:49 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8956-70-6TZrDjjmDf@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16349|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18557 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18557&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 4 - Add saving/editing of published end date for bound volumes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:24:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:24:58 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8956-70-TMz7Pl2Ix4@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16350|0 |1 is obsolete| | --- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18558 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18558&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 5 - Add label fields to subscription editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:25:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:25:08 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8956-70-czTuBXaVNX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16351|0 |1 is obsolete| | --- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18559&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 6 - Perltidy serials/subscription-add.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:25:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:25:17 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8956-70-MmkEBf0662@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16352|0 |1 is obsolete| | --- Comment #34 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18560&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 7 - Add backend processing of field labels. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:25:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:25:26 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8956-70-abyzVGkEXW@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16353|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 18561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18561&action=edit Bug 8956 - Split serials enumeration data into separate fields - Part 8 - Perltidy serials/subscription-add.pl again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:28:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:28:06 +0000 Subject: [Koha-bugs] [Bug 10348] When using SeparateHoldings OPAC shows number of items, but staff doesn't In-Reply-To: <bug-10348-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10348-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10348-70-aJp0NU9iQL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10348 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Templates Severity|trivial |enhancement --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- This isn't related to the SeparateHoldings preference. The staff client never shows a count of items in the holdings tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 18:31:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 16:31:46 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9351-70-Ekrqt0ugHJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Fridolyn SOMERS <fridolyn.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Fridolyn SOMERS <fridolyn.somers at biblibre.com> --- Indeed, but it works for both item and biblio level : In C4::Circualtion::AddIssue : my $item = GetItem('', $barcode) and C4::Items::GetItem sets itype with itemtype from items or biblioitems if needed. So $items->{'itype'} is used for both item and biblio level, like in many other places in C4::Circualtion. Maybe C4::Items::GetItem should use item-level_itypes system preference, but this would be a very sensitive modification with a huge test plan, it shall be for another bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 19:00:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 17:00:29 +0000 Subject: [Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use In-Reply-To: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9351-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9351-70-VWDoLbTJS2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #6 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #5) > Indeed, but it works for both item and biblio level : > In C4::Circualtion::AddIssue : > my $item = GetItem('', $barcode) > and C4::Items::GetItem sets itype with itemtype from items or biblioitems if > needed. Please take a look at CanBookBeIssued -- it fetches the item via GetItem, but also fetches the biblioitem and explicitly checks item-level_itypes. What GetItem does when fetchingitype isn't quite the same: it doesn't check the syspref, but it also assumes that one should fall back to the biblio item type if the item-level item type is blank. I'm not quite sure that's the correct behavior, but that discussion certainly belongs on a separate bug. > So $items->{'itype'} is used for both item and biblio level, like in many > other places in C4::Circualtion. But many other places in C4::Circulation explicitly check item-level_type, and I think the fix for this should be doing that explicit check. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 19:19:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 17:19:05 +0000 Subject: [Koha-bugs] [Bug 10385] New: item-level_itype checks need to be refactored Message-ID: <bug-10385-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10385 Bug ID: 10385 Summary: item-level_itype checks need to be refactored Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com Checks on the item-level_itypes system preference are scattered throughout the code, and there have been a large number of bugs concerning cases where such a check is missing. I propose checks of this system preference be moved as far down the stack as possible. Specifically, all routines that fetch items from the database should check the syspref to determine the correct item type column and return it via (say) an "item_type" key in the response, to distinguish it from 'itemtype' and 'itype'. The only code that would see 'itype' or 'itemtype' would be code directly related to modifying items. Further, the syspref would be checked in as few places as possible. I further propose pinning down the semantics of the item-level_itypes as follows: - when ON, the item type is *always* taken from items.itype for all display and circulation purposes - when OFF, the item type is *always* taken from biblioitems.itemtype In particular, the current behavior of GetItem (fetch the itype from the item if it's not blank, otherwise fall back to the biblioitem itemtype), would be modified. Related bugs include: - Bug 7491 - Bug 7492 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 19:29:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 17:29:13 +0000 Subject: [Koha-bugs] [Bug 10386] New: UT: VirtualShelves.t needs some more adjustments Message-ID: <bug-10386-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 Bug ID: 10386 Summary: UT: VirtualShelves.t needs some more adjustments Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: gmcharlt at gmail.com Reporter: m.de.rooy at rijksmuseum.nl Will build upon the changes proposed in bug 10290. IMO this unit test should not just delete all records at the start. (Why ruin my test database for lazy programming :) ? Furthermore, the unique name test for lists is not completely correct. Will also add two small new tests for AddShare from bug 9032. Note also that a test db may not even contain 10 borrowers.. And some room for more refinements, when working on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 19:29:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 17:29:25 +0000 Subject: [Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments In-Reply-To: <bug-10386-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10386-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10386-70-eYuXv5yPVR@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 19:29:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 17:29:46 +0000 Subject: [Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments In-Reply-To: <bug-10386-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10386-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10386-70-T27hu1TbuX@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10290 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 19:29:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 17:29:46 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10290-70-3xibouvinJ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10386 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 19:30:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 17:30:13 +0000 Subject: [Koha-bugs] [Bug 10290] UT: VirtualShelves.t needs to create its own data In-Reply-To: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10290-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10290-70-C5aBnAWPEP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10290 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10386 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 19:30:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 17:30:13 +0000 Subject: [Koha-bugs] [Bug 10386] UT: VirtualShelves.t needs some more adjustments In-Reply-To: <bug-10386-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10386-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10386-70-skd3XWX1nl@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10386 M. de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10290 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 19:51:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 17:51:22 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8952-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8952-70-ta0R9cETd7@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 --- Comment #28 from M. de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to comment #27) > (In reply to comment #25) > > Jonathan: > > With another patch, I face the same problem as we do here. Should we add > > http or https to OPACBaseURL? > > It's a valid configuration to make the OPAC available via both HTTP and > HTTPS, so using OPACBaseURL to define the protocol gives me a bit of a > twitch. Well, probably this is a misunderstanding. Currently, http or https should not be inserted into the pref. But Koha does add at some places http by default (which is wrong indeed) and at other places tries to know what to prefix (see using_https in Auth.pm). But the last test does not work correctly under Plack. What I did mean, was: If we let the user just once insert http or https for his server, and we do not prefix it anymore, we have a solution.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 20:03:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 18:03:37 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: <bug-10215-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10215-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10215-70-hQw3eJsO4L@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton <gmcharlt at gmail.com> --- Alas, it can't be quite that simple -- MySQL doesn't allow default values for text and blob columns: mysql> ALTER TABLE subscriptionhistory CHANGE librariannote librariannote TEXT NOT NULL DEFAULT ''; Query OK, 1 row affected, 1 warning (0.15 sec) Records: 1 Duplicates: 0 Warnings: 0 mysql> show warnings; +---------+------+-------------------------------------------------------------+ | Level | Code | Message | +---------+------+-------------------------------------------------------------+ | Warning | 1101 | BLOB/TEXT column 'librariannote' can't have a default value | +---------+------+-------------------------------------------------------------+ 1 row in set (0.00 sec) Admittedly, by default this is just a warning; MySQL will blithely supply a default value (of '') for text columns. However, if we ever feel inspired to turn on stricter modes like STRICT_TRANS_TABLES (which I believe MariaDB does by default), problems will occur. I think making those two columns TEXT (and nullable) is the way to go. There might be a bit of additional code warranted to make sure that the Apache error log doesn't display spurious warnings about undef opacnote and librariannote. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 20:24:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 18:24:22 +0000 Subject: [Koha-bugs] [Bug 9779] Remove global include of YUI assets from the staff client In-Reply-To: <bug-9779-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9779-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9779-70-gkEcI2hxhI@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 18562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18562&action=edit Bug 9779 - Remove global include of YUI assets from the staff client There are no pages in the staff client which use YUI JS assets other than basketgroups.tt. The links to YUI assets can therefore be removed from the global include and put directly into the basket groups template. To test, view the basketgroups page and confirm using a JS debugger that no JS errors are triggered. Perform various basket group options: Open, close, modify, drag-and-drop. Operations should complete successfully and without JS errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 20:24:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 18:24:21 +0000 Subject: [Koha-bugs] [Bug 9779] Remove global include of YUI assets from the staff client In-Reply-To: <bug-9779-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9779-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9779-70-k5JDS5rjUw@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9779 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 20:26:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 18:26:12 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: <bug-10325-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10325-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10325-70-M7yxPFIntK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 --- Comment #2 from Galen Charlton <gmcharlt at gmail.com> --- Comment on attachment 18374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18374 Bug 10325 - Allow system preferences to be overridable from koha-httpd.conf Review of attachment 18374: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10325&attachment=18374) ----------------------------------------------------------------- I can see the utility of this, and it would have applications for the command line, too. I can imagine an edge case, though -- there's nothing stopping one from using this in the *intranet* virtual host definitions (and I could imagine a Koha administrator wanting to do this to allow local admins access to system preferences while locking down ones such as 'marcflavour' that should never be changed). But that could really confuse somebody who is wondering why their system preference change isn't having the desired effect. Perhaps the system preference editor should be taught how to recognize overriden sysprefs? ::: C4/Context.pm @@ +548,5 @@ > > my $dbh = C4::Context->dbh or return 0; > > + my $value; > + if ( defined $ENV{"OVERRIDE_SYSPREF_$var"} ) { The test should be 'exists', no? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 20:34:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 18:34:24 +0000 Subject: [Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf In-Reply-To: <bug-10325-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10325-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10325-70-rQre2uiNnT@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #3 from Galen Charlton <gmcharlt at gmail.com> --- Another thing that occurred to me -- some system preference names contain hyphens and colons, neither of which can be used as part of environment variable names. Not a huge deal, but perhaps the override mechanism should do some normalization of the syspref name before checking the environment. For example, it could normalize hyphens and colons to underscores, so that $context->preference('ILS-DI:AuthorisedIPs') would check for an environment variable named OVERRIDE_SYSPREF_ILS_DI_AuthorisedIPs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 20:53:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 18:53:50 +0000 Subject: [Koha-bugs] [Bug 10387] New: checkauth and get_template_and_user have copy-pasta for setting template variables Message-ID: <bug-10387-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10387 Bug ID: 10387 Summary: checkauth and get_template_and_user have copy-pasta for setting template variables Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: gmcharlt at gmail.com Both checkauth and get_template_and_user set a bunch of template variables based on system preferences. For the vast majority of cases, creating a new default template variable means updating both routines; failing to do this results in bugs like bug 9541. Setting default template variables should be refactored into a common routine in order to avoid repetition. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 20:54:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 18:54:01 +0000 Subject: [Koha-bugs] [Bug 10387] checkauth and get_template_and_user have copy-pasta for setting template variables In-Reply-To: <bug-10387-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10387-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10387-70-oLYuFfPTIL@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10387 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9541 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 20:54:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 18:54:01 +0000 Subject: [Koha-bugs] [Bug 9541] Opac-user doesn't load correct CSS for multiple branches In-Reply-To: <bug-9541-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9541-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9541-70-NM6lV2ZpW1@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9541 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10387 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 20:58:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 18:58:01 +0000 Subject: [Koha-bugs] [Bug 9541] Opac-user doesn't load correct CSS for multiple branches In-Reply-To: <bug-9541-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9541-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9541-70-T0PKrSpb2g@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9541 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 20:58:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 18:58:03 +0000 Subject: [Koha-bugs] [Bug 9541] Opac-user doesn't load correct CSS for multiple branches In-Reply-To: <bug-9541-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9541-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9541-70-YO1lN1d6Nt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9541 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18038|0 |1 is obsolete| | --- Comment #5 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18563&action=edit Bug 9541 - Opac-user doesn't load correct CSS for multiple branches When clicking the login link for opac-user.pl in a multiple branch scenario the environment variable for OPAC_CSS_OVERRIDE is ignored from the koha-conf.xml file. It seems like is is working on every page in the opac except for the login page. Test Plan: 1) Set up a Koha server with 2 separate catalog configurations ( e.g. opac1.kohatest, opac2.kohatest ) 2) Set the OPAC_CSS_OVERRIDE directive for separate css files in each opac 3) Browse to the opac login page, note the css is not applied 4) Apply this patch 5) Reload the page, note the css is now applied Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 21:02:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 19:02:02 +0000 Subject: [Koha-bugs] [Bug 9890] Fix the new plugin system for package installs In-Reply-To: <bug-9890-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9890-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9890-70-0sped3JmfQ@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9890 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18417|0 |1 is obsolete| | --- Comment #19 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 18564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18564&action=edit Bug 9890 - Fix koha-create and koha-create-dirs As noted in the bug, there were three things to do: 1) koha-create: fill in __PLUGINS_DIR__ 2) leave the enable_plugins as off (at least for now) 3) koha-create-dirs: create the directory, set permissions (writeable by the koha user) - Fixed generate_config_file from koha-create so it correctly fills __PLUGINS_DIR__ in every installed file. - koha-create-dirs now creates the relevant dir. - enable_plugins is set to 0 currently, no action required here. Regarding the apache configurations, I'm not sure what you mean. Regards To+ Edit: got some minutes to test and re-check and found that the substitution didn't put the right data. Fixed Sponsored-by: Universidad Nacional de C?rdoba -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 21:02:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 19:02:10 +0000 Subject: [Koha-bugs] [Bug 8956] Split serials enumeration data into separate fields In-Reply-To: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8956-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8956-70-lwixnqUwVK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8956 paul.landers at ttuhsc.edu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.landers at ttuhsc.edu --- Comment #36 from paul.landers at ttuhsc.edu --- Kyle, after review by our serials staff I now sign off on this dev. Paul Landers Texas Tech University Health Sciences Center Library I.T. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 21:16:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 19:16:46 +0000 Subject: [Koha-bugs] [Bug 10300] Revert Bug 8781 - Access to Transfer page while "independent branches" is on In-Reply-To: <bug-10300-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10300-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10300-70-S7a9qadoFP@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Galen Charlton <gmcharlt at gmail.com> --- (In reply to comment #0) > This bug needs reverted, this explanation was given to me by a librarian: I don't think a revert is the way to do it, particularly since we're talking about a patch that's been pushed to several stable branches. Simply reverting would create a regression for the folks who filed bug 8781 in the first place. I think the key words in your customer's statement is "for our group". I suspect it is not every user of IndependentBranches who needs to "fix" items on a regular basis, but I certainly understand and appreciate that some do. To me, this situation calls for either a new user permission or YASP. Setting to "in discussion". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 21:25:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 19:25:11 +0000 Subject: [Koha-bugs] [Bug 10384] Software error when LDAP connexion fails In-Reply-To: <bug-10384-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10384-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10384-70-XdwEN1IN71@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10384 --- Comment #2 from Galen Charlton <gmcharlt at gmail.com> --- Comment on attachment 18540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18540 Proposed patch Review of attachment 18540: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10384&attachment=18540) ----------------------------------------------------------------- ::: C4/Auth_with_ldap.pm @@ +103,5 @@ > my ($dbh, $userid, $password) = @_; > my @hosts = split(',', $prefhost); > my $db = Net::LDAP->new(\@hosts); > + unless ( $db ) { > + $debug and warn "LDAP connexion failed"; I think this might be better as a plain warn -- being unable to connect to the LDAP server is an operational problem that should be logged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 21:46:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 19:46:04 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-5xMVAZSV8q@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 21:46:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 19:46:08 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-7143-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7143-70-9vgexoyGAa@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18337|0 |1 is obsolete| | --- Comment #93 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18565&action=edit Bug 7143: Release team 3.14 on about page Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 22:02:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 20:02:30 +0000 Subject: [Koha-bugs] [Bug 10378] Enable checked out items to be transferred without returning them In-Reply-To: <bug-10378-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-10378-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10378-70-mQbxpLtDuF@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10378 --- Comment #4 from Galen Charlton <gmcharlt at gmail.com> --- Exploring the consequences a bit ... the libraries in question are OK with the possibility that the loan might incur overdue fines while in transit back to the owning library? And they *always* want manual transits to not check the item in? If the answer to the second question is along the lines of "on a case-by-case basis", I wonder if the syspref should simply enable the _option_ of transiting without returning, in conjunction with a checkbox (and possibly a user permission) for a circ staffer to indicate that a particular loan should not be checked in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 22:06:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 20:06:30 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8375-70-bO6kL3Sps6@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Blocks|9854, 9856 | Depends on| |9854, 9856 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 22:06:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 20:06:30 +0000 Subject: [Koha-bugs] [Bug 9854] Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375) In-Reply-To: <bug-9854-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9854-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9854-70-jAAFdgZoOt@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8375 Depends on|8375 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 22:06:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 20:06:30 +0000 Subject: [Koha-bugs] [Bug 9856] Add TTF font path in a syspref instead of hardcoding, for labels printing (bug 8375) In-Reply-To: <bug-9856-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9856-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9856-70-lA2sGBNMrK@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9856 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8375 Depends on|8375 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 22:08:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 20:08:24 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-8375-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8375-70-kWDJ87qLfd@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #32 from Galen Charlton <gmcharlt at gmail.com> --- I've switched the dependencies around since folks are requesting patches for 9854 and 9856 before signing off on this one, although I wonder if all three bugs should just be merged. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 22:45:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 20:45:02 +0000 Subject: [Koha-bugs] [Bug 6399] tooltip for tags that says 'separate by comma' In-Reply-To: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-6399-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6399-70-0038QoT9Dv@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6399 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Pushed to 3.10.x, will be on 3.10.7 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 23:18:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 21:18:57 +0000 Subject: [Koha-bugs] [Bug 9854] Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375) In-Reply-To: <bug-9854-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9854-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9854-70-mIPct6Kdil@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 23:18:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 21:18:58 +0000 Subject: [Koha-bugs] [Bug 9854] Add 'ttf-dejavu*' packages to debian/control file, for label printing (bug 8375) In-Reply-To: <bug-9854-70@http.bugs.koha-community.org/bugzilla3/> References: <bug-9854-70@http.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9854-70-Y2w92AvaW2@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854 --- Comment #1 from Galen Charlton <gmcharlt at gmail.com> --- Created attachment 18566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18566&action=edit bug 9854: add ttf-dejavu as dependency for Debian packages ttf-dejavu (i.e., the core and extra DejaVu TrueType) fonts are used by the proposed fix for bug 8375. To test, build and install the Koha packages for Debian and verify that the ttf-dejavu package is installed. Signed-off-by: Galen Charlton <gmc at esilibrary.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri May 31 23:46:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 31 May 2013 21:46:21 +0000 Subject: [Koha-bugs] [Bug 10388] New: acq edited items showing 'null's Message-ID: <bug-10388-70@http.bugs.koha-community.org/bugzilla3/> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388 Bug ID: 10388 Summary: acq edited items showing 'null's Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com Created attachment 18567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18567&action=edit edited item says null When editing items on the receipt page in acquisitions you see 'null' in all fields that have no value. This used to be a blank - or clear column, but now in 3.10.x and 3.12 and master it's showing null. It should be blank instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.