[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

--- Comment #23 from Kyle M Hall <kyle.m.hall at gmail.com> ---
> As for the actual bug, I'm not sure that I could reproduce it. Before
> applying the patch, I used your test plan to the letter (expecting for my
> hold to disappear on a holiday), but when I set my "waiting date" to
> yesterday and ran "misc/cronjobs/holds/cancel_expired_holds.pl", it didn't
> clear out the reserve (regardless of the day being a holiday). If I set it
> for the day before yesterday (both as a holiday and not), I got:
> 
> DBD::mysql::st execute failed: Duplicate entry '60' for key 'PRIMARY' at
> dev/lib//C4/Reserves.pm line 1051.
> 
> It cleared out the entry from the reserves table, but that doesn't seem very
> elegant. Is that how it's supposed to look?

The test plan should have had "the day before yesterday" instead of
"yesterday". I don't know why you would be getting an error like that ( I get
no errors when I test this patch ), but it sounds like your reserves and
old_reserves tables are messed up. I think you may have duplicate reserve_id's
between the two tables, which would cause that error. I do not believe your
error has anything to do with this patch though.

-- 
You are receiving this mail because:
You are watching all bug changes.