[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #106 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to comment #104) 
> Here is my reaction on this action from you as new RM: 

I am also an _old_ RM, and stand by my decision on the following basis:

- This was reverted in 3.12.x.  Jared would have been perfectly in his rights
to revert in master as well.  If the patch series was too problematic to
include in the main release, it does not necessarily belong in master, either.
- Side-effects of this patch series were *getting in the way* of applying other
patches necessary for the 3.12.x release.
- The basis of the patch series relies on use of a flag to CGI.pm that it's own
documentation warns against.

Further, please bear in mind what I said:

"This should not be viewed as a permanent reversion"

And I mean it.  I do not disagree that the underlying bug needs to be dealt
with, but the number of side-effects shows that the current patch series is not
ready for prime time.  The integration branch will provide an opportunity for
more thorough testing.

> On the whole: This is very discouraging and highly unmotivating. Please
> communicate with other developers and team members instead of starting your
> RM term with one-sided actions like this one. Do you think that this makes
> me spend more time on the subject?

Considering the discussion and advance warning over IRC, I reject your
implication that this decision was not communicated.

The reversion is not meant as a personal slight against anybody.  I do
understand that you have put a lot of effort into this, and I understand that
having patches that one has worked on getting reverted stings.

I hope to encourage a different approach to patches and reversions: that they
be treated as experiments and learning opportunities, and that credit be given
to those who make the experiment, even if their patch doesn't end up getting
committed in its original form.  However, I acknowledge that this is not an
easy thing.

But I will also be blunt: I would not be doing my job as RM well if, when
necessary, I didn't exercise my own judgment.  

One of the things I've learned the hard way is that at times, it is necessary
to force a pause to recheck assumptions.  I believe this is one of the moments
for this bug.

I encourage you to work on the integration branch, but if you prefer to take a
break from this bug, I have every confidence that we will not lack for hands
and eyes to test.

-- 
You are receiving this mail because:
You are watching all bug changes.