[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #111 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to comment #108)
> (In reply to comment #103)
> > This should not be viewed as a permanent reversion,
> > although I have reservations about turning on CGI.pm's -utf8 switch across
> > the board -- but I have even stronger reservations about the ensuant game of
> > whack-a-mole we've been playing with new bugs arising from this patch.
> 
> Would you mind to elaborate your objections to CGI.pm's -utf8 switch? I
> think that it's cleaner to take extra care about code which uses file upload
> than to hand-decode every single parameter we are passing into Koha code.
> 
> This is only my personal preference, and I am fine with whatever solution
> gets eventually prefered, but I main question is if I should re-submit my
> patches without -utf8 in them.

>From the man page

-utf8

This makes CGI.pm treat all parameters as UTF-8 strings. Use this with care, as
it will interfere with the processing of binary uploads. It is better to
manually select which fields are expected to return utf-8 strings and convert
them using code like this:

            use Encode;
            my $arg = decode utf8=>param('foo');

-- 
You are receiving this mail because:
You are watching all bug changes.