[Koha-bugs] [Bug 7593] merging bib records loses connection to order line

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7593

--- Comment #40 from Jonathan Druart <jonathan.druart at biblibre.com> ---
(In reply to comment #38)
> Hello
> Thank you Jonathan for the fix.
> Are you sure of the "41" instead of "42" ? (I did not check)

% prove t/db_dependent/Acquisition.t
t/db_dependent/Acquisition.t .. ok                                              
All tests successful.
Files=1, Tests=41,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.40 cusr  0.02
csys =  0.44 CPU)
Result: PASS

(In reply to comment #39)
> In fact I wanted to check if the result is an array, and not something else
> (hash or scalar).
> Can you tell me why this line is wrong?
> isa_ok( ref @listorders, 'ARRAY','GetOrdersByBiblionumber : result is an
> array' );

The parameter should be a reference
(http://perldoc.perl.org/functions/ref.html).
Else the value is always an empty string.

> I don't know the meaning of "$#listorders ". what is it supposed to check?

$#array returns the max index of the array @array.

So in fact the test I proposed is false.
I will provide another patch (we just want to check if the returned value is
defined).

-- 
You are receiving this mail because:
You are watching all bug changes.