[Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Tue May 14 08:42:14 CEST 2013
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531
Katrin Fischer <katrin.fischer at bsz-bw.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Needs Signoff
CC| |katrin.fischer at bsz-bw.de
--- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Kyle,
could you perhaps provide a little follow up for the tabulation characters?
* C4/SIP/Sip/MsgType.pm
FAIL
pod OK
forbidden patterns FAIL
The patch introduces a forbidden pattern: tabulation character (869)
The patch introduces a forbidden pattern: tabulation character (793)
The patch introduces a forbidden pattern: tabulation character (781)
valid OK
critic OK
Apart from this all tests and the QA script pass.
SIP is hard to test and I am still not familiar with it. Therefore I would like
to call for a second sign off on this and then it can pass QA.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list