[Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030

--- Comment #9 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 18157
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18157&action=edit
Bug 10030: QA Followup for trivial false warning detected while testing

Moving the warn line below the line that returns if amount<=0.
If amount<=0, a false warn is now raised because of the return after it.
We should only warn here if we do not return.

Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
Tested with fines.pl on overdue.
Before this patch:
Reducing fine for item 199709 borrower 23 from 44 to -1 - MaxFine reached.
This did not happen however because of the return.
After this change: no false warning.

-- 
You are receiving this mail because:
You are watching all bug changes.