[Koha-bugs] [Bug 10135] Adding the ability to define customised basketgroups pdf layouts

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10135

--- Comment #8 from Jonathan Druart <jonathan.druart at biblibre.com> ---
A new type of this kind for syspref is not a best choice I think.
Why do you want to list the directory?
The value can be filled manually.

I agree with your changes in /acqui/basketgroup.pl

I think we just want:
-    if ($pdfformat eq 'pdfformat::layout3pages' || $pdfformat eq
'pdfformat::layout2pages'){
     eval {
         eval "require $pdfformat";
         import $pdfformat;
     };
     if ($@){
+           print $input->header;  
+           print $input->start_html;  # FIXME Should do a nicer page
+           print "<h1>Invalid PDF Format set</h1>";
+           print "Please go to the systempreferences and set a valid
pdfformat";
+           exit;
     }
-    }
-    else {
-    print $input->header;  
-    print $input->start_html;  # FIXME Should do a nicer page
-    print "<h1>Invalid PDF Format set</h1>";
-    print "Please go to the systempreferences and set a valid pdfformat";
-    exit;
-    }

I completely disagree with others changes.

-- 
You are receiving this mail because:
You are watching all bug changes.