[Koha-bugs] [Bug 10310] Prevent submit form pressing enter should be improved

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10310

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #10 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
My former QA comment still holds.
Good improvement.

Just curious about this line:
 $(e.target).attr('type') != "submit"
Is there a difference with using e.target.type?
Does jQuery not guarantee already that object e contains a 'which' and
'target'?
Note that you assume that in the lines before this line when you directly refer
to e.which and e.target.

This tiny inconsistency does not prevent me from passing QA on this patch
(second try). Just wait for Owen :)
This patch makes it work too on IE9 which did not work. I could not test on
earlier versions of IE. Not encouraging IE for staff at all btw..

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.