[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

--- Comment #30 from Kyle M Hall <kyle.m.hall at gmail.com> ---
Galen, if you feel strongly this is the way to go, I will do it that way. I'm
fully invested in making Koha the best ILS it can be!

Also, as far as the fines logic goes, for this I will do whatever is necessary
to make it function, but I'm still preparing a full-rewrite of the accounts
system, so I'll probably just shore this up with the minimum amount of code, as
the rewrite will replace it eventually.

It really does seem more logical to have CalcFine deal with all fine limiting
activities, rather than UpdateFine. However, there may be consequences I'm not
seeing.

Kyle

(In reply to comment #29)
> (In reply to comment #28)
> > > Perhaps we have fines logic in too many places. Maybe MaxFines logic needs
> > > to be moved to CalcFine as well.
> > 
> > I agree with Galen that moving them both out of the prefs would be great.
> > But adjusting a lot of troublesome circulation code would be great too.
> 
> The thing is, not taking the time to set a new circ policy switch at the
> right level of specificity just adds to the refactoring work that has to be
> done later.
> 
> Setting back to in discussion to ask the question of Kyle directly: are you
> willing to prepare a version of this patch that adds this limit as a
> issuingrules policy, not a system preference?

-- 
You are receiving this mail because:
You are watching all bug changes.