[Koha-bugs] [Bug 10262] fine calculation at checkin not respecting CircControl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10262

--- Comment #15 from Kyle M Hall <kyle.m.hall at gmail.com> ---
> First we'll have to figure out what we want _GetCircControlBranch to do. 
> However, it might be as simple as passing it an optional issues hash so that
> it handle the special PickupLibrary case for loans.

So, _GetCircControlBranch returns the following:

* If CircControl is set to "PickupLibrary", it returns the currently logged in
library branchcode.
* If CircControl is set to 'PatronLibrary', it returns the patron's home
library branchcode
* If CircControl is set to 'ItemHomeLibrary', it uses the system preference
HomeOrHoldingBranch to return either the item's homebranch or its
holdingbranch.

So _GetCircControlBranch is actually a bit more configurable than the other
code ( it behaves exactly the same except it can use either the hold or the
holding branch ). In addition, if CircControl is set to ItemHomeLibrary and
HomeOrHoldingBranch is set to "Holding branch" we will get very unexpected
behavior for some items, as we will have some code using the item's holding
branch, and some of the code using the item's home branch for circulation rule
purposes.

So, for _GetCircControlBranch, if we add $issue to the parameters list, and
returned the branchcode of the issuing library in cases where a) CircControl is
set to 'ItemHomeLibrary' and b) $issue is not undefined, I think everything
will be good.

-- 
You are receiving this mail because:
You are watching all bug changes.