[Koha-bugs] [Bug 9755] Record merge code needs to be refactored

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9755

--- Comment #20 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to comment #19)
> (In reply to comment #18)
> > - I think references to the 999 and 955 tags would be better handled by
> > looking up the tag that the MARC framework uses to store biblio.biblionumber
> > rather than using magic numbers.
> I fully agree with this !

I agree too, but this is not new in this patch, so I don't think that is a
valid reason for stopping it. The Class name might be though.

We've already discussed a followup for different MARC flavours that could be
extended to use the mappings instead. But I do think that this is a huge code
improvement over what we had, and that a follow up to change to using mappings
would be better outside of this refactoring patch anyway.

-- 
You are receiving this mail because:
You are watching all bug changes.