[Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18345|0                           |1
        is obsolete|                            |

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 18485
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18485&action=edit
Bug 10314 - CanItemBeReserved does not respect the holds policies

CanItemBeReserved will return 1 as long as the circulation rules have a
non-zero number of holds allowed and the patron hasn't reached his or
her "Holds allowed" count. However, the subroutine completely ignores
the holds policies which would contravene reserving the item even if the
patron has not reached the maximum holds allowed count.

Test Plan:
1) Place an item on hold for a patron
2) Clear any existing hold policies
3) Set the appropriate circ rule so that the patron should be allowed
4) Attempt to place am item-level hold for this item/patron, it should succeed
5) Create a hold policy rule that would stop this patron from placing
   a hold on this item
6) Attempt to place an item-level hold on this item/patron, it should
   fail, but instead it will succeed
7) Apply this patch
8) Repeat step 6, this time you should be unable to place a specific
   hold on this item

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.