[Koha-bugs] [Bug 9505] acqui/invoices.pl contains an unnecessary loop

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu May 30 11:10:33 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9505

--- Comment #9 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
(In reply to comment #8)
> Comment on attachment 18354 [details] [review]
> Amended Patch
> 
> Review of attachment 18354 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt
> @@ +92,4 @@
> >                [% IF ( invoicenumber ) %]
> >                  <li>Invoice no.: [% invoicenumber %]</li>
> >                [% END %]
> > +              [% IF booksellerid %]
> 
> I think this test can be removed. I don't find anywhere supplier was passed.
> Or perhaps should we check the supplierid variable. It is passed when we
> come from the acqui/supplier.pl page.

It gets passed from invoices.pl

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list