[Koha-bugs] [Bug 10277] Add C4::Context->IsSuperLibrarian()

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu May 30 16:05:53 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277

Kyle M Hall <kyle at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #18427|0                           |1
        is obsolete|                            |

--- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> ---
Created attachment 18518
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18518&action=edit
Bug 10277 - Add C4::Context->IsSuperLibrarian()

The method of checking the logged in user for superlibrarian privileges
is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least.
The codebase is littered with these lines, with no explanation given. It
would be much better if we had one subroutine that returned a boolean
value to tell us if the logged in user is a superlibrarian or not.

Test Plan:
1) Apply this patch
2) Verify superlibrarian behavior remains unchanged

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list