[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri May 31 19:00:29 CEST 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #6 from Galen Charlton <gmcharlt at gmail.com> ---
(In reply to comment #5)
> Indeed, but it works for both item and biblio level : 
> In C4::Circualtion::AddIssue : 
>   my $item = GetItem('', $barcode)
> and C4::Items::GetItem sets itype with itemtype from items or biblioitems if
> needed.

Please take a look at CanBookBeIssued -- it fetches the item via GetItem, but
also fetches the biblioitem and explicitly checks item-level_itypes.  

What GetItem does when fetchingitype isn't quite the same: it doesn't check the
syspref, but it also assumes that one should fall back to the biblio item type
if the item-level item type is blank.  I'm not quite sure that's the correct
behavior, but that discussion certainly belongs on a separate bug.

> So $items->{'itype'} is used for both item and biblio level, like in many
> other places in C4::Circualtion.

But many other places in C4::Circulation explicitly check item-level_type, and
I think the fix for this should be doing that explicit check.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list