[Koha-bugs] [Bug 10325] Allow system preferences to be overridable from koha-httpd.conf

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10325

--- Comment #2 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 18374
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18374
Bug 10325 - Allow system preferences to be overridable from koha-httpd.conf

Review of attachment 18374:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10325&attachment=18374)
-----------------------------------------------------------------

I can see the utility of this, and it would have applications for the command
line, too.

I can imagine an edge case, though -- there's nothing stopping one from using
this in the *intranet* virtual host definitions (and I could imagine a Koha
administrator wanting to do this to allow local admins access to system
preferences while locking down ones such as 'marcflavour' that should never be
changed).  But that could really confuse somebody who is wondering why their
system preference change isn't having the desired effect.

Perhaps the system preference editor should be taught how to recognize
overriden sysprefs?

::: C4/Context.pm
@@ +548,5 @@
>  
>      my $dbh  = C4::Context->dbh or return 0;
>  
> +    my $value;
> +    if ( defined $ENV{"OVERRIDE_SYSPREF_$var"} ) {

The test should be 'exists', no?

-- 
You are receiving this mail because:
You are watching all bug changes.