From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:00:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:00:39 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #191 from Galen Charlton --- Pushed to master after discussion with Katrin. Thanks, Kyle! That said, this still needs a lot of work, enough that this may end up getting an "experimental" label added to this feature prior to release. Things I've found: - As previously noted, there's no way to move an entire field with all of its subfields. - But if you try -- by specifying a tag but not a subfield -- you can *crash* it: data() is only for con trol fields (generally, just tags below 010) , use subfield() at /home/gmc/koha/Koha/SimpleMARC.pm - When moving/copying fields, it makes no attempt to put them in order. - I can't say I particularly care for the fact that the modification takes places during _staging_. It would be better if it could take place during committing (or at least have an option to do so, or to have a preview mode), to enable the user to adjust their modification rules without having the repeatedly stage the same file. - We need to be more consistent about where new stuff gets configured. There's no particularly good reason why the matching rules should be configured under admin and the modification templates under tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:00:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:00:59 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:23:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:23:47 +0000 Subject: [Koha-bugs] [Bug 11054] Creating a child record has problems with accented Latin characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11054 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #11 from Galen Charlton --- Pushed to master. Thanks, Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:24:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:24:48 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 --- Comment #78 from Galen Charlton --- Pushed all of these to master. Thanks, Nicole! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:24:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:24:52 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22657|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:24:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:24:55 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22658|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:25:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:25:00 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22648|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:25:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:25:04 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22650|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:25:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:25:08 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22651|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:25:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:25:13 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22652|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:25:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:25:17 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22653|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:25:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:25:41 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:27:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:27:12 +0000 Subject: [Koha-bugs] [Bug 10776] Subscription notification screen has awkward wording In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10776 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #6 from Galen Charlton --- Pushed to master. Thanks, Liz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:50:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:50:31 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #26 from Galen Charlton --- Pushed to master. Thanks, Jonathan! Being able to set item record values during receiving will be well received, but I must say that I am not a fan of how things have drifted: - It would be better to refer to item fields by their names, not how they happen to be mapped in a MARC framework. (By the way, I have an itch to stamp out the use of AddItemFromMarc and ModItemFromMarc, replacing it with direct calls to AddItem / ModItem, or their eventual DBIC equivalents. A helper routine to map a MARC field to an item should be used only when necessary -- during record import, primarily, and not item record editing). - It's not great that depending on what stage of the process you're dealing with, the configuration interface is either a syspref or the MARC frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:55:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2013 23:55:19 +0000 Subject: [Koha-bugs] [Bug 9218] intranet cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9218 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 01:02:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 00:02:36 +0000 Subject: [Koha-bugs] [Bug 9780] Restrict the right to suppress a record used in some order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9780 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #49 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 01:09:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 00:09:14 +0000 Subject: [Koha-bugs] [Bug 9374] In baskets, prices between 0 and 1 are displayed in red In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9374 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Galen Charlton --- Pushed to master, along with a follow-up adding the promised FIXME. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 01:26:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 00:26:07 +0000 Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #105 from Galen Charlton --- Pushed to master, along with a follow-up to fixes UTF-8 encoding issues in the CSV export. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 01:29:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 00:29:49 +0000 Subject: [Koha-bugs] [Bug 10720] Substitution term in overdue notices shouldn't be removed even if they don't match In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10720 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Sophie! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 01:33:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 00:33:20 +0000 Subject: [Koha-bugs] [Bug 11033] In basketgroup pages, Save button and Cancel link are hidden by chooselanguage bar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11033 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Mathieu! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 01:37:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 00:37:27 +0000 Subject: [Koha-bugs] [Bug 11111] The basket group is not displayed on the parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Patch no longer applies, and this close to string freeze I don't want to risk messing up the merge conflict resolution. Also, since this patch touches SearchOrders(), a unit test should be added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 01:43:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 00:43:12 +0000 Subject: [Koha-bugs] [Bug 11132] The results list is reset on adding a biblio to a list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11132 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 05:25:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 04:25:42 +0000 Subject: [Koha-bugs] [Bug 11156] check-url.pl is not utf friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11156 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 05:25:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 04:25:46 +0000 Subject: [Koha-bugs] [Bug 11156] check-url.pl is not utf friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11156 --- Comment #1 from Srdjan Jankovic --- Created attachment 22661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22661&action=edit bug_11156: binmode STDOUT, ':utf8' This is a noop. To test: * Run misc/cronjobs/check-url.pl If you *really* want to test, place some non-ascii bogus urls in 856 and observe absence of "wide character" warning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:10:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 07:10:07 +0000 Subject: [Koha-bugs] [Bug 11182] New: Warnings in circulation Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Bug ID: 11182 Summary: Warnings in circulation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Eliminate unnecessary warnings -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:25:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 07:25:48 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:25:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 07:25:50 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 --- Comment #1 from Srdjan Jankovic --- Created attachment 22662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22662&action=edit bug_11182: get rid of some warnings To testi - circulation: * For a child patron, check that "Upgrade to adult" link on the "More" drop-down is clickable * Set sys pref FineNotifyAtCheckin to yes (Notify), and check in an overdue item that attracts fine. Fine amount should be displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:39:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 07:39:52 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10501 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:39:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 07:39:52 +0000 Subject: [Koha-bugs] [Bug 10501] Can't order more than 1 when importing all from staged file (AcqCreateItem = on order) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10501 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7180 --- Comment #2 from Katrin Fischer --- I think the development for 7180 might fix this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:40:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 07:40:26 +0000 Subject: [Koha-bugs] [Bug 11173] Carriage returns are missing in email notification when content type is html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11173 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:03:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 08:03:15 +0000 Subject: [Koha-bugs] [Bug 11183] New: Warnings in opac Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Bug ID: 11183 Summary: Warnings in opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Get rid of some warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:10:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 08:10:04 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:10:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 08:10:07 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #1 from Srdjan Jankovic --- Created attachment 22663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22663&action=edit bug_11183: get rid of some warninngs To test in OPAC: * Set EnableOpacSearchHistory to yes (Keep). Do an advanced search with limits. Complete search with limits should show. * Have an item with Collection Code. Check that the Collection Code shows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:22:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 08:22:53 +0000 Subject: [Koha-bugs] [Bug 11184] New: Fix wrong attribute type cloning Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 Bug ID: 11184 Summary: Fix wrong attribute type cloning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When building attributes list for the patron maintenance list, cloning is performed in suboptimal way that generates warnings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:27:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 08:27:35 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:27:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 08:27:38 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 --- Comment #1 from Srdjan Jankovic --- Created attachment 22664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22664&action=edit bug_11184: correct attribute cloning for the maint screen To test - Patron details entry page: * Have ExtendedPatronAttributes enabled. Check that "Additional attributes and identifiers" section behaves. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:28:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 08:28:31 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 --- Comment #2 from Srdjan Jankovic --- Galen, can I ask you to scrutinise this one please. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:43:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 08:43:59 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #13 from Srdjan Jankovic --- Created attachment 22665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22665&action=edit bug_11077: get rid of some warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:47:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 08:47:59 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan at catalyst.net.nz --- Comment #14 from Srdjan Jankovic --- Tom?s, I also had a take on this one (found out for this bug report too late). Please feel free to combine as you find fit. You may take my patch and add your stuff, or take your patch and add $lasttime correction (I believe the rest overlaps). Cheers, Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 10:34:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 09:34:18 +0000 Subject: [Koha-bugs] [Bug 11156] check-url.pl is not utf friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11156 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- I can't reproduce this bug. I've tried with an URL containing ???. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 10:38:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 09:38:11 +0000 Subject: [Koha-bugs] [Bug 11185] New: check-url-quick.pl fails Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Bug ID: 11185 Summary: check-url-quick.pl fails Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org When running check-url-quick.pl, it fails due to AnyEvent::HTTP module bad loading. It comes from this commit: f88f11b4f805a70c9748bc3676cb1ce086db2ce8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 10:40:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 09:40:31 +0000 Subject: [Koha-bugs] [Bug 11185] check-url-quick.pl fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11185 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |frederic at tamil.fr --- Comment #1 from Fr?d?ric Demians --- Created attachment 22666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22666&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:21:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 11:21:54 +0000 Subject: [Koha-bugs] [Bug 10478] Do we need a sequential number generator? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10478 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com --- Comment #9 from Colin Campbell --- There are existing cpan modules to maintain sequences in a db agnostic way, e.g. DBIx::Sequence -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:49:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 13:49:39 +0000 Subject: [Koha-bugs] [Bug 11186] New: <> does not work as it appears in default notices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11186 Bug ID: 11186 Summary: <> does not work as it appears in default notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org One of the default notices (i believe it's DUE) says: "You have <> items due soon." But that doesn't actually work. An examination of the code finds that "<>" acts as a number label for some types of loops ( but not all ) in some notices and slips. For example, let's say a notice has a loop of items, the following: <>: <> Would produce something like the following 1: 1233454232 2: 2343242343 3: 3243243242 and so on We need to resolve this by fixing the default notice or by making <> work like it appears it should - a count of items due. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:03:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 14:03:37 +0000 Subject: [Koha-bugs] [Bug 10478] Do we need a sequential number generator? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10478 --- Comment #10 from M. Tompsett --- Colin, for your perusal. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454#c14 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:09:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 14:09:15 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #15 from M. Tompsett --- Created attachment 22667 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22667&action=edit Bug 11077 - Correct silent warnings in C4/Auth.pm This patch corrects a noisy ne condition. $userid = $retuserid if ( $retuserid ne ''); became $userid = $retuserid if ( $retuserid ); It also integrates Srdjan Jankovic's patch with Petter Goks?yr ?sen's patch, while correcting the problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:15:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 14:15:58 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 17:06:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 16:06:25 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from M. de Rooy --- In order to get these patches further, I would recommend adding a test plan to the commit messages of each individual patch. And please include some unit tests (in a followup) for the new or adjusted routines in modules to increase the chance of getting these patches pushed. Thank you very much. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 18:47:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 17:47:51 +0000 Subject: [Koha-bugs] [Bug 10027] Fine details not showing when printing a fine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10027 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 18:48:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 17:48:23 +0000 Subject: [Koha-bugs] [Bug 10619] sco.css missing for CCSR OPAC templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10619 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 18:48:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 17:48:45 +0000 Subject: [Koha-bugs] [Bug 9943] Pay fines page "Pay selected" button give invalid amount when nothing is selected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9943 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 20:01:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 19:01:58 +0000 Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com --- Comment #8 from M. Tompsett --- After finding that filer vs. filter typo, I had hopes for it working. However, this is some of my testing output: mtompset at ubuntu:~$ koha-list library mtompset at ubuntu:~$ koha-list --enabled grep: /etc/apache2/sites-available/library: Permission denied library mtompset at ubuntu:~$ koha-list --enabled grep: /etc/apache2/sites-available/library: Permission denied library mtompset at ubuntu:~$ koha-list --disabled grep: /etc/apache2/sites-available/library: Permission denied mtompset at ubuntu:~$ koha-list --disabled grep: /etc/apache2/sites-available/library: Permission denied mtompset at ubuntu:~$ sudo koha-disable grep: /etc/apache2/sites-available/library: Permission denied library grep: /etc/apache2/sites-available/library: Permission denied * Restarting web server apache2 apache2: Could not reliably determine the server's fully qualified domain name, using 127.0.1.1 for ServerName ... waiting apache2: Could not reliably determine the server's fully qualified domain name, using 127.0.1.1 for ServerName [ OK ] mtompset at ubuntu:~$ koha-list --disabled grep: /etc/apache2/sites-available/library: Permission denied mtompset at ubuntu:~$ koha-list --disabled grep: /etc/apache2/sites-available/library: Permission denied mtompset at ubuntu:~$ koha-list --enabled grep: /etc/apache2/sites-available/library: Permission denied library mtompset at ubuntu:~$ koha-list --enabled grep: /etc/apache2/sites-available/library: Permission denied library mtompset at ubuntu:~$ sudo koha-disable library Instance library already disabled. mtompset at ubuntu:~$ koha-list --enabled grep: /etc/apache2/sites-available/library: Permission denied library mtompset at ubuntu:~$ koha-list --enabled grep: /etc/apache2/sites-available/library: Permission denied library mtompset at ubuntu:~$ koha-list --disabled grep: /etc/apache2/sites-available/library: Permission denied mtompset at ubuntu:~$ koha-list --disabled grep: /etc/apache2/sites-available/library: Permission denied mtompset at ubuntu:~$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 22:52:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 21:52:39 +0000 Subject: [Koha-bugs] [Bug 11187] New: notices showing the --- if only one title Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11187 Bug ID: 11187 Summary: notices showing the --- if only one title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 22668 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22668&action=edit template See attached. On the checkout notice when you have multiple titles the --- translates in to 'show all titles' but if there is only one title then it shows the --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 22:52:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 21:52:53 +0000 Subject: [Koha-bugs] [Bug 11187] notices showing the --- if only one title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11187 --- Comment #1 from Nicole C. Engard --- Created attachment 22669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22669&action=edit output -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 23:17:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2013 22:17:17 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #79 from Nicole C. Engard --- Awesome! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 02:23:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2013 01:23:30 +0000 Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003 --- Comment #9 from M. Tompsett --- root at ubuntu:~# koha-enable --help Usage: grep [OPTION]... PATTERN [FILE]... Search for PATTERN in each FILE or standard input. PATTERN is, by default, a basic regular expression (BRE). Example: grep -i 'hello world' menu.h main.c Regexp selection and interpretation: -E, --extended-regexp PATTERN is an extended regular expression (ERE) -F, --fixed-strings PATTERN is a set of newline-separated fixed strings -G, --basic-regexp PATTERN is a basic regular expression (BRE) -P, --perl-regexp PATTERN is a Perl regular expression -e, --regexp=PATTERN use PATTERN for matching -f, --file=FILE obtain PATTERN from FILE -i, --ignore-case ignore case distinctions -w, --word-regexp force PATTERN to match only whole words -x, --line-regexp force PATTERN to match only whole lines -z, --null-data a data line ends in 0 byte, not newline Miscellaneous: -s, --no-messages suppress error messages -v, --invert-match select non-matching lines -V, --version print version information and exit --help display this help and exit --mmap ignored for backwards compatibility Output control: -m, --max-count=NUM stop after NUM matches -b, --byte-offset print the byte offset with output lines -n, --line-number print line number with output lines --line-buffered flush output on every line -H, --with-filename print the file name for each match -h, --no-filename suppress the file name prefix on output --label=LABEL use LABEL as the standard input file name prefix -o, --only-matching show only the part of a line matching PATTERN -q, --quiet, --silent suppress all normal output --binary-files=TYPE assume that binary files are TYPE; TYPE is `binary', `text', or `without-match' -a, --text equivalent to --binary-files=text -I equivalent to --binary-files=without-match -d, --directories=ACTION how to handle directories; ACTION is `read', `recurse', or `skip' -D, --devices=ACTION how to handle devices, FIFOs and sockets; ACTION is `read' or `skip' -R, -r, --recursive equivalent to --directories=recurse --include=FILE_PATTERN search only files that match FILE_PATTERN --exclude=FILE_PATTERN skip files and directories matching FILE_PATTERN --exclude-from=FILE skip files matching any file pattern from FILE --exclude-dir=PATTERN directories that match PATTERN will be skipped. -L, --files-without-match print only names of FILEs containing no match -l, --files-with-matches print only names of FILEs containing matches -c, --count print only a count of matching lines per FILE -T, --initial-tab make tabs line up (if needed) -Z, --null print 0 byte after FILE name Context control: -B, --before-context=NUM print NUM lines of leading context -A, --after-context=NUM print NUM lines of trailing context -C, --context=NUM print NUM lines of output context -NUM same as --context=NUM --color[=WHEN], --colour[=WHEN] use markers to highlight the matching strings; WHEN is `always', `never', or `auto' -U, --binary do not strip CR characters at EOL (MSDOS) -u, --unix-byte-offsets report offsets as if CRs were not there (MSDOS) `egrep' means `grep -E'. `fgrep' means `grep -F'. Direct invocation as either `egrep' or `fgrep' is deprecated. With no FILE, or when FILE is -, read standard input. If less than two FILEs are given, assume -h. Exit status is 0 if any line was selected, 1 otherwise; if any error occurs and -q was not given, the exit status is 2. Report bugs to: bug-grep at gnu.org GNU Grep home page: General help using GNU software: Usage: grep [OPTION]... PATTERN [FILE]... Search for PATTERN in each FILE or standard input. PATTERN is, by default, a basic regular expression (BRE). Example: grep -i 'hello world' menu.h main.c Regexp selection and interpretation: -E, --extended-regexp PATTERN is an extended regular expression (ERE) -F, --fixed-strings PATTERN is a set of newline-separated fixed strings -G, --basic-regexp PATTERN is a basic regular expression (BRE) -P, --perl-regexp PATTERN is a Perl regular expression -e, --regexp=PATTERN use PATTERN for matching -f, --file=FILE obtain PATTERN from FILE -i, --ignore-case ignore case distinctions -w, --word-regexp force PATTERN to match only whole words -x, --line-regexp force PATTERN to match only whole lines -z, --null-data a data line ends in 0 byte, not newline Miscellaneous: -s, --no-messages suppress error messages -v, --invert-match select non-matching lines -V, --version print version information and exit --help display this help and exit --mmap ignored for backwards compatibility Output control: -m, --max-count=NUM stop after NUM matches -b, --byte-offset print the byte offset with output lines -n, --line-number print line number with output lines --line-buffered flush output on every line -H, --with-filename print the file name for each match -h, --no-filename suppress the file name prefix on output --label=LABEL use LABEL as the standard input file name prefix -o, --only-matching show only the part of a line matching PATTERN -q, --quiet, --silent suppress all normal output --binary-files=TYPE assume that binary files are TYPE; TYPE is `binary', `text', or `without-match' -a, --text equivalent to --binary-files=text -I equivalent to --binary-files=without-match -d, --directories=ACTION how to handle directories; ACTION is `read', `recurse', or `skip' -D, --devices=ACTION how to handle devices, FIFOs and sockets; ACTION is `read' or `skip' -R, -r, --recursive equivalent to --directories=recurse --include=FILE_PATTERN search only files that match FILE_PATTERN --exclude=FILE_PATTERN skip files and directories matching FILE_PATTERN --exclude-from=FILE skip files matching any file pattern from FILE --exclude-dir=PATTERN directories that match PATTERN will be skipped. -L, --files-without-match print only names of FILEs containing no match -l, --files-with-matches print only names of FILEs containing matches -c, --count print only a count of matching lines per FILE -T, --initial-tab make tabs line up (if needed) -Z, --null print 0 byte after FILE name Context control: -B, --before-context=NUM print NUM lines of leading context -A, --after-context=NUM print NUM lines of trailing context -C, --context=NUM print NUM lines of output context -NUM same as --context=NUM --color[=WHEN], --colour[=WHEN] use markers to highlight the matching strings; WHEN is `always', `never', or `auto' -U, --binary do not strip CR characters at EOL (MSDOS) -u, --unix-byte-offsets report offsets as if CRs were not there (MSDOS) `egrep' means `grep -E'. `fgrep' means `grep -F'. Direct invocation as either `egrep' or `fgrep' is deprecated. With no FILE, or when FILE is -, read standard input. If less than two FILEs are given, assume -h. Exit status is 0 if any line was selected, 1 otherwise; if any error occurs and -q was not given, the exit status is 2. Report bugs to: bug-grep at gnu.org GNU Grep home page: General help using GNU software: grep: /etc/apache2/sites-available/--help: No such file or directory Instance --help already enabled. Not really a bug, but definitely a weird side-effect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 02:49:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2013 01:49:14 +0000 Subject: [Koha-bugs] [Bug 8688] Add a recall button to the biblio record details page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8688 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 03:55:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2013 02:55:00 +0000 Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003 --- Comment #10 from M. Tompsett --- root at ubuntu:~# koha-stop-zebra instance2 Stopping Zebra server for instance2 root at ubuntu:~# koha-stop-zebra instance2 Zebra already stopped for instance instance2. root at ubuntu:~# koha-stop-zebra instance2 Zebra already stopped for instance instance2. The tab completion came up with instance2 even though it was stopped already. Hmmm... my koha-restart-sip doesn't exist, I think that was bug 10622. Perhaps I built my .deb before including 10622. Any other tests I had issues with were NOT tab completion issues, but rather behaviour issues (--help vs. no parameter, what does disable really mean, feedback vs. no feedback). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 04:41:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2013 03:41:42 +0000 Subject: [Koha-bugs] [Bug 10003] koha-* scripts (packages) should provide tab-completion in bash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10003 --- Comment #11 from Tom?s Cohen Arazi --- (In reply to M. Tompsett from comment #10) > root at ubuntu:~# koha-stop-zebra instance2 > Stopping Zebra server for instance2 > root at ubuntu:~# koha-stop-zebra instance2 > Zebra already stopped for instance instance2. > root at ubuntu:~# koha-stop-zebra instance2 > Zebra already stopped for instance instance2. > > The tab completion came up with instance2 even though it was stopped already. > > Hmmm... my koha-restart-sip doesn't exist, I think that was bug 10622. > Perhaps I built my .deb before including 10622. > > Any other tests I had issues with were NOT tab completion issues, but rather > behaviour issues (--help vs. no parameter, what does disable really mean, > feedback vs. no feedback). All this is intended. tab completion just shows valid parameters for the command. You can call any of those koha-*-action commands with instances for such the task is not running and the result is that you got. Those scripts just check the instance is enabled. You shouldn't ask tab completion to provide things the commands themselves don't provide. Please don't paste the output of the grep command help, it just makes this bug unreadable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 17:17:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2013 16:17:46 +0000 Subject: [Koha-bugs] [Bug 9725] Add support to notices for hourly loans In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9725 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 18:50:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2013 17:50:09 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #16 from Fr?d?ric Demians --- The goal of embedding Schema.org microformat structured data into Koha OPAC biblio records is to improve catalog indexing by web crawlers like Google. Consequently wouldn't be interesting to provide to crawler a complete sitemap: http://sitemaps.org I have a script for that: https://metacpan.org/pod/release/FREDERICD/Koha-Contrib-Tamil-0.032/bin/koha-sitemap -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 18:51:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2013 17:51:09 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10830 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 18:51:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2013 17:51:09 +0000 Subject: [Koha-bugs] [Bug 10830] Add schema.org microdata for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10830 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6594 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 18:51:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2013 17:51:27 +0000 Subject: [Koha-bugs] [Bug 10830] Add schema.org microdata for UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10830 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 19:16:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2013 18:16:10 +0000 Subject: [Koha-bugs] [Bug 11188] New: Make gather_print_notices.pl die on failed open() Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188 Bug ID: 11188 Summary: Make gather_print_notices.pl die on failed open() Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Command-line Utilities Assignee: magnus at enger.priv.no Reporter: magnus at enger.priv.no QA Contact: testopia at bugs.koha-community.org Currently, gather_print_notices.pl tries to open a file to write notices to, but it does not check that the open() succeeded. This can result in the following error error, if you point at a location you do not have write access to: print() on closed filehandle $OUTPUT at /usr/share/koha/bin/cronjobs/gather_print_notices.pl line 129. But the script proceeds on its merry way, and marks the "pending" messages it found as "sent", which means you can't re-run the script with another location and gather up the notices you meant to gather up. I'll propose to replace the current "open(...)" with an "open(...) or die()". (I'll probably do a patch for this during training on Monday, so please don't fix it before that :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 19:19:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2013 18:19:09 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 --- Comment #17 from Magnus Enger --- (In reply to Fr?d?ric Demians from comment #16) > The goal of embedding Schema.org microformat structured data into Koha OPAC > biblio records is to improve catalog indexing by web crawlers like Google. > Consequently wouldn't be interesting to provide to crawler a complete > sitemap: That would be Very Cool! But on a new bug, I guess? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:35:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2013 21:35:49 +0000 Subject: [Koha-bugs] [Bug 11181] Koha geolocalization of OPAC users for better sort results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11181 --- Comment #1 from Pablo AB --- To make things easier it could use (also or instead) HTML5 Geolocation API, as "Library Finder" [0] (ResearchWorks from OCLC). [0] http://www.oclc.org/research/activities/researchworks.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 11:25:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 10:25:11 +0000 Subject: [Koha-bugs] [Bug 10766] Cataloging reservoir search broken if UseQueryParser is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10766 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |z.tajoli at cineca.it --- Comment #5 from Zeno Tajoli --- Cherry-picked to 3.12.x here: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=4309e5e6b4682b95db4ca26f7a49f96c2f6c2875 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 11:26:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 10:26:09 +0000 Subject: [Koha-bugs] [Bug 10766] Cataloging reservoir search broken if UseQueryParser is off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10766 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 12:25:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 11:25:36 +0000 Subject: [Koha-bugs] [Bug 11189] New: Remplace Print by Form of item in UNIMARC advanced search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 Bug ID: 11189 Summary: Remplace Print by Form of item in UNIMARC advanced search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr in unimarc advanced searcg on opac and staff interface, the string "Print" is ambiguous, as "Print" could be translated in french by "Imprimer" (verb) or "Impression" (noun), and is used elsewhere in templates in the "verb" meaning. We could be used instead of "Print" the official label for 106 field ("Form of item") or maybe "Type of print" M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 12:25:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 11:25:56 +0000 Subject: [Koha-bugs] [Bug 11189] Remplace Print by Form of item in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 12:47:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 11:47:42 +0000 Subject: [Koha-bugs] [Bug 11189] Remplace Print by Form of item in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 --- Comment #1 from mathieu saby --- Created attachment 22670 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22670&action=edit Bug 11189 : Rename Print label in UNIMARC advanced search "Print" label for search on 106 field is not correct in UNIMARC advanced search : - 106 field can be used for non printed ressources (manuscript...) - "Print" is ambiguous for translation tool, as it can be understood as a verb or a noun. The official label for 106 field is "Type of form". The offical label for 106$a subfield is "Medium designator". I think "Physical presentation" is the best way to describe the content of 106$a in a user understandable label. Test plan : Check the "Print" label is replaced with "Physical presentation" in OPAC and Staff Advanced Search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 12:47:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 11:47:51 +0000 Subject: [Koha-bugs] [Bug 11189] Remplace Print by Form of item in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mathieu.saby at univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 12:47:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 11:47:59 +0000 Subject: [Koha-bugs] [Bug 11189] Remplace Print by Form of item in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 12:48:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 11:48:22 +0000 Subject: [Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Remplace Print by Form of |Rename Print label in |item in UNIMARC advanced |UNIMARC advanced search |search | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 12:50:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 11:50:16 +0000 Subject: [Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 12:53:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 11:53:56 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #47 from mathieu saby --- The patch was signed off. I'm fixing the status. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 13:35:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 12:35:33 +0000 Subject: [Koha-bugs] [Bug 11190] New: koha-sitemap.pl -- Generate a Catalog sitemap Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Bug ID: 11190 Summary: koha-sitemap.pl -- Generate a Catalog sitemap Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt at gmail.com Reporter: frederic at tamil.fr QA Contact: testopia at bugs.koha-community.org Process all biblio records from a Koha instance and generate Sitemap files complying with this protocol as described on http://sitemaps.org. The goal of this script is to be able to provide to search engines direct access to biblio records. It avoid leaving search engine browsing Koha OPAC and so generating a lot of traffic, and workload, for a bad result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 13:36:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 12:36:33 +0000 Subject: [Koha-bugs] [Bug 6594] Add schema.org microdata In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6594 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11190 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 13:36:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 12:36:33 +0000 Subject: [Koha-bugs] [Bug 11190] koha-sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at enger.priv.no Depends on| |6594 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 13:37:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 12:37:05 +0000 Subject: [Koha-bugs] [Bug 11191] New: Errors and missing headings in MARC21 authority configuration file Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11191 Bug ID: 11191 Summary: Errors and missing headings in MARC21 authority configuration file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org 431 and 531 are used for "see also" forms of uniform titles, instead of 430 and 530 Chronological Term (new 2002) : 148, 448, 548 and Medium of Performance Term (new 2013) : 162, 462, 562 are not indexed in record.abs (and probably DOM conf files) for MARC21 authorities. See also forms subdivision headings (180-185) are not indexed Notes are not indexed M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 13:39:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 12:39:38 +0000 Subject: [Koha-bugs] [Bug 11191] Errors and missing headings in MARC21 authority configuration file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11191 --- Comment #1 from mathieu saby --- I'm wrong for 148-448-548 fields. They are indexed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 17:04:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 16:04:58 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|koha-sitemap.pl -- Generate |sitemap.pl -- Generate a |a Catalog sitemap |Catalog sitemap -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 17:12:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 16:12:21 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |frederic at tamil.fr --- Comment #1 from Fr?d?ric Demians --- Created attachment 22671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22671&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 18:08:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 17:08:37 +0000 Subject: [Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 --- Comment #2 from Fr?d?ric Demians --- > We could be used instead of "Print" the official label for 106 field ("Form > of item") or maybe "Type of print" +1 Could you propose a patch with subtypes_unimarc.inc modified also for Bootstrap theme? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 18:20:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 17:20:30 +0000 Subject: [Koha-bugs] [Bug 11192] New: Fix2 definitions in ccl.properties Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11192 Bug ID: 11192 Summary: Fix2 definitions in ccl.properties Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org Bug 8252 broke 2 definitions in ccl.properties : "ff7-02 1=87020" should be "ff7-02 1=8702" "lf 1=8833 lf fiction fic fiction" should be "lf 1=8833 fiction lf fic lf" M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 18:20:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 17:20:45 +0000 Subject: [Koha-bugs] [Bug 11192] Fix two definitions in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11192 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Fix2 definitions in |Fix two definitions in |ccl.properties |ccl.properties -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 18:36:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 17:36:54 +0000 Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range for fields 1xx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252 --- Comment #57 from mathieu saby --- Created attachment 22672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22672&action=edit [PATCH] Bug 8252 : edit Queryparser configuration to take changes into account This patch make some changes to queryparser.yaml, to take into account the changes made in ccl.properties I am not sure I understood well the behavior of this file, and of the best way for testing it... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 18:38:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 17:38:17 +0000 Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range for fields 1xx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252 --- Comment #58 from mathieu saby --- I cannot change the bug's status to "Need sign off", so I will create a new one. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 18:38:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 17:38:48 +0000 Subject: [Koha-bugs] [Bug 8252] Error in DOM biblio for UNIMARC (no range for fields 1xx) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22672|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 18:42:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 17:42:34 +0000 Subject: [Koha-bugs] [Bug 11193] New: Update Queryparser conf file to take into account changes made by bug 8252 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 Bug ID: 11193 Summary: Update Queryparser conf file to take into account changes made by bug 8252 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org Bug 8252 made some changes to ccl.properties and bib1.att. I suppose these changes should be ported to QP conf file. I am not sure of the best way to do that, but I have tried ;-) As Jared is the developer who best know QP, I would appreciate if he could take a look at this. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 18:56:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 17:56:48 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 --- Comment #1 from mathieu saby --- Created attachment 22673 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22673&action=edit [PATCH] Bug 11193 : edit Queryparser configuration to take changes of bug 8252 into account This patch make some changes to queryparser.yaml, to take into account the changes made in ccl.properties * new indexes : bio, char-encoding, country-publication, cumulative-index-availability, ff7-00, ff7-01, ff7-02, ff7-01-02, ff8-18, ff8-18-21, ff8-19, ff8-21, ff8-28,ff8-29,ff8-30,ff8-31, ta, lf, music-number, title-page-availability, script-title, tpubdate, rtype * deleted indexes : audience and ff8-22 (alias of ta), biography and ff-834 (alias of bio), format (alias of ff8-23), l-format (alias of ff7-01-02), illustration-code (alias of ff8-18-21), regularity-code, type-of-serial (alias of ff8-21), literature-code (alias of lf), music (alias of music-number), record-type (alias of rtype) * changed index : graphics-type, graphics-support, video-mt I am not sure if I understood well the behavior of this file, and of the best way for testing the changes made... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 18:57:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 17:57:04 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 18:57:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 17:57:32 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 18:57:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 17:57:52 +0000 Subject: [Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 19:10:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 18:10:04 +0000 Subject: [Koha-bugs] [Bug 11192] Fix two definitions in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11192 --- Comment #1 from mathieu saby --- Created attachment 22674 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22674&action=edit Bug 11192 : Fix lf and ff07-02 definition in ccl.properties ff7-02 1=87020 (position 2 of field 007 in MARC21) should be ff7-02 1=8702 lf 1=8833 lf fiction fic fiction should be lf 1=8833 fiction lf fic lf To test : 1. apply the patch 2. copy the modified ccl.properties into your active Zebra config directory 3. reindex zebra (rebuild_zebra.pl -b -x -r -v) 4. make some searches using the fixed indexes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 19:10:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 18:10:17 +0000 Subject: [Koha-bugs] [Bug 11192] Fix two definitions in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11192 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 19:10:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 18:10:26 +0000 Subject: [Koha-bugs] [Bug 11192] Fix two definitions in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11192 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 19:10:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 18:10:38 +0000 Subject: [Koha-bugs] [Bug 11192] Fix two definitions in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11192 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 19:16:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 18:16:35 +0000 Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than "any" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21986|0 |1 is obsolete| | --- Comment #25 from mathieu saby --- Created attachment 22675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22675&action=edit [PATCH 3/3] Bug 8962: Unimarc biblios and authorithies (GRS1) rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 19:16:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 18:16:54 +0000 Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than "any" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 19:20:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 18:20:41 +0000 Subject: [Koha-bugs] [Bug 10893] Location facet not working in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10893 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 19:27:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 18:27:16 +0000 Subject: [Koha-bugs] [Bug 11027] add a column for basketgroups in late orders table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11027 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #4 from mathieu saby --- Now it seems to apply cleanly Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 19:29:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 18:29:52 +0000 Subject: [Koha-bugs] [Bug 11194] New: Add a new index for edition of a document Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Bug ID: 11194 Summary: Add a new index for edition of a document Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org Edition of a document (205 in UNIMARC) could be indexed in a specific index. "Edition" index exists in bib1 for this purpose, but is not used in Koha M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 19:30:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 18:30:19 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 19:38:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 18:38:47 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22342|0 |1 is obsolete| | --- Comment #27 from mathieu saby --- Created attachment 22676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22676&action=edit [PATCH 2/2] Bug 10869 Followup : change DelOrder and adds UT rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 19:39:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 18:39:35 +0000 Subject: [Koha-bugs] [Bug 10869] can't delete order line if title deleted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 --- Comment #28 from mathieu saby --- Of course, UT cannot be tested on a sandbox, but the other aspects of the patch can. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 20:54:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 19:54:37 +0000 Subject: [Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #5 from mathieu saby --- Hi Jonathan, Hi Kyle I am trying to resolve conflict on Bug 10758, so I came to your change on this one. Don't you think the resulting routine could be make simpler ? I see "publishercode AS publisher" and aqorders.rrp AS unitpricesupplier, aqorders.ecost AS unitpricelib, aqorders.claims_count AS claims_count, aqorders.claimed_date AS claimed_date, I don't the the meaning of aqorders.claims_count AS claims_count, aqorders.claimed_date AS claimed_date, For aqorders.rrp AS unitpricesupplier, aqorders.ecost AS unitpricelib, and publishercode AS publisher Is this renaming made for avoiding confusion somewhere in code? By the way, I was trying to factorize some UT in Acquisition.t (not yet done), and one of my assumptions was that the fields returned by GetOrder were the same as each orders of GetOrderS and GetCancelledOrders. It was working, but of course it is no more the case. So I'm wondering if the fields added in the hased returned by GetOrder could be usefull too in GetOrderS and GetCancelledOrders. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 20:57:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 19:57:59 +0000 Subject: [Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723 --- Comment #6 from mathieu saby --- ARGH Sorry, I'm completely wrong ;-) What disturbs me is the change made to GetOrder, not to GetPendingOrders. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 21:51:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 20:51:39 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #92 from mathieu saby --- Hi Jonathan I am trying to resolve conflict on Bug 10758, so I came to the changes introduced in GetOrder by commit fd2c751a86fad7a388c57fcd51746dbc4592c807 (the main patch for bug 7298) Don't you think the resulting routine could be make simpler ? I don't see the use for: aqorders.claims_count AS claims_count, aqorders.claimed_date AS claimed_date, For aqorders.rrp AS unitpricesupplier, aqorders.ecost AS unitpricelib, and biblioitems.publishercode AS publisher aqbudgets.budget_name AS budget, Are these renaming really needed? Are they made for avoiding confusion somewhere in code? By the way, I was trying to factorize some UT in Acquisition.t (not yet done), and one of my assumptions was that the fields returned by GetOrder were the same as each orders of GetOrderS and GetCancelledOrders. It was working, but of course it is no more the case. So I'm wondering if the fields added in the hashe returned by GetOrder could be usefull too in GetOrderS and GetCancelledOrders. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 21:54:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 20:54:35 +0000 Subject: [Koha-bugs] [Bug 6762] show orderline numbers in the basket display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6762 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6463|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 21:57:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 20:57:12 +0000 Subject: [Koha-bugs] [Bug 6762] show orderline numbers in the basket display In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6762 --- Comment #3 from Katrin Fischer --- Checked against 3.14 beta - no order numbers are shown on the basket summary page - so this is still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 21:58:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 20:58:29 +0000 Subject: [Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22670|0 |1 is obsolete| | --- Comment #3 from mathieu saby --- Created attachment 22677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22677&action=edit [PATCH] Bug 11189 : Rename Print label in UNIMARC advanced search "Print" label for search on 106 field is not correct in UNIMARC advanced search : - 106 field can be used for non printed ressources (manuscript...) - "Print" is ambiguous for translation tool, as it can be understood as a verb or a noun. The official label for 106 field is "Type of form". The offical label for 106$a subfield is "Medium designator". I think "Physical presentation" is the best way to describe the content of 106$a in a user understandable label. Test plan : Check the "Print" label is replaced with "Physical presentation" in OPAC (prog theme and Bootstrap theme) and Staff Advanced Search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 21:58:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 20:58:42 +0000 Subject: [Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 --- Comment #4 from mathieu saby --- (In reply to Fr?d?ric Demians from comment #2) > > We could be used instead of "Print" the official label for 106 field ("Form > > of item") or maybe "Type of print" > > +1 > > Could you propose a patch with subtypes_unimarc.inc modified also for > Bootstrap theme? Hop l? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:06:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 21:06:38 +0000 Subject: [Koha-bugs] [Bug 11195] New: rename biblioitems.publishercode into publisher Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11195 Bug ID: 11195 Summary: rename biblioitems.publishercode into publisher Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org "publishercode" name is deceptive, as it does not contain a code, but a name. So it should be called "publisher" M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:12:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2013 23:12:55 +0000 Subject: [Koha-bugs] [Bug 11156] check-url.pl is not utf friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11156 --- Comment #3 from Srdjan Jankovic --- Then maybe it was not utf chars, maybe it was some Microsoft 1251. I'll try to find what exactly triggered it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 01:48:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 00:48:31 +0000 Subject: [Koha-bugs] [Bug 11196] New: SearchEngine pref not in sysprefs.sql Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 Bug ID: 11196 Summary: SearchEngine pref not in sysprefs.sql Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org SearchEngine pref was introduced in updatedatabase.pl, but not in sysprefs.sql, so new installs don't have it set by default -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 01:51:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 00:51:18 +0000 Subject: [Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8233 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 02:06:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 01:06:16 +0000 Subject: [Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 02:06:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 01:06:19 +0000 Subject: [Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 --- Comment #1 from Srdjan Jankovic --- Created attachment 22678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22678&action=edit bug_11196: put SearchEngine to sysprefs.sql Test: Check that sysprefs.sql runs correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 02:12:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 01:12:34 +0000 Subject: [Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 07:00:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 06:00:41 +0000 Subject: [Koha-bugs] [Bug 11156] check-url.pl is not utf friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11156 --- Comment #4 from Srdjan Jankovic --- This is what I had: http://www.minedu.govt.nz/educationSectors/M?oriEducation/AboutM?oriEducation/WhoWeAre/EngagementWithM?ori/HuiTaumataMatauranga/BetterRelationshipsForBetterLearning.aspx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 07:08:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 06:08:23 +0000 Subject: [Koha-bugs] [Bug 11156] check-url.pl is not utf friendly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11156 --- Comment #5 from Fr?d?ric Demians --- > This is what I had: > http://www.minedu.govt.nz/educationSectors/M?oriEducation/ > AboutM?oriEducation/WhoWeAre/EngagementWithM?ori/HuiTaumataMatauranga/ > BetterRelationshipsForBetterLearning.aspx Could you copy-paste here the original URL, as it is in your 856 field? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 07:30:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 06:30:33 +0000 Subject: [Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22671|0 |1 is obsolete| | --- Comment #2 from Fr?d?ric Demians --- Created attachment 22679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22679&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 08:22:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 07:22:00 +0000 Subject: [Koha-bugs] [Bug 11197] New: Allow holds to be automatically confirmed, when no transfer is needed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11197 Bug ID: 11197 Summary: Allow holds to be automatically confirmed, when no transfer is needed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: chris at bigballofwax.co.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Oftentimes, the staff person will scan an item that is on hold, stop to put on a sticker, and then go on to scan the next item without selecting confirm. We get distracted, the phone rings, a customer asks a question, we aren't paying attention... Also there are many times that I walk up to an unmanned computer and I see a message like the one below. If someone uses that workstation without confirming, then the hold shows as "available". Proposal: To add a systempreference, AutoHoldConfirm, that if on, will automatically mark holds as waiting at checkin. If they are on hold at the branch they are being checked in at. This should have no change in behaviour at all without this systempreference being enabled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 09:33:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 08:33:04 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 09:33:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 08:33:31 +0000 Subject: [Koha-bugs] [Bug 11111] The basket group is not displayed on the parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 09:33:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 08:33:34 +0000 Subject: [Koha-bugs] [Bug 11111] The basket group is not displayed on the parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22435|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 22680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22680&action=edit Bug 11111: The basket group is not display on the parcel page Test plan: Go on acqui/parcel.pl?invoiceid=XX page and verify the basket group name is displayed into the 2nd column. Signed-off-by: Ed Veal Signed-off-by: Katrin Fischer Changed basketgroup to basket group to match spelling on other pages. Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 09:33:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 08:33:45 +0000 Subject: [Koha-bugs] [Bug 11111] The basket group is not displayed on the parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111 --- Comment #6 from Jonathan Druart --- Created attachment 22681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22681&action=edit Bug 11111: UT: SearchOrders returns keys basketgroupid and basketgroupname -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 09:35:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 08:35:52 +0000 Subject: [Koha-bugs] [Bug 10740] date created and modified indexes in ccl.properties In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10740 --- Comment #22 from mathieu saby --- (In reply to Fridolyn SOMERS from comment #20) > (In reply to mathieu saby from comment #19) > > I don't know at all how to do this > I will provide a QP follow-up for this bug 10740, to add > "date-time-last-modified". > I noticed that in QP all indexes are lowercase. > So in the end I wonder why not use everywhere : "date-time-last-modified" > and not "Date/time-last-modified". In ccl.properties, there are a lot of aliases differing from the main index only in terms of capitalisation (Notes notes etc). I always wondered if it was necessary or not... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 09:35:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 08:35:53 +0000 Subject: [Koha-bugs] [Bug 11111] The basket group is not displayed on the parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22680|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 22682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22682&action=edit Bug 11111: The basket group is not display on the parcel page Test plan: Go on acqui/parcel.pl?invoiceid=XX page and verify the basket group name is displayed into the 2nd column. Signed-off-by: Ed Veal Signed-off-by: Katrin Fischer Changed basketgroup to basket group to match spelling on other pages. Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 09:36:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 08:36:00 +0000 Subject: [Koha-bugs] [Bug 11111] The basket group is not displayed on the parcel page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11111 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22681|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 22683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22683&action=edit Bug 11111: UT: SearchOrders returns keys basketgroupid and basketgroupname -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 09:42:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 08:42:03 +0000 Subject: [Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22677|0 |1 is obsolete| | --- Comment #5 from Fr?d?ric Demians --- Created attachment 22684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22684&action=edit Signed-off patch "Print" label for search on 106 field is not correct in UNIMARC advanced search: - 106 field can be used for non printed ressources (manuscript...) - "Print" is ambiguous for translation tool, as it can be understood as a verb or a noun. The official label for 106 field is "Type of form". The offical label for 106$a subfield is "Medium designator". I think "Physical presentation" is the best way to describe the content of 106$a in a user understandable label. Test plan : Check the "Print" label is replaced with "Physical presentation" in OPAC (prog theme and Bootstrap theme) and Staff Advanced Search Signed-off-by: Fr?d?ric Demians OK for me. Make sense for UNIMARC users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 09:42:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 08:42:14 +0000 Subject: [Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 10:04:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 09:04:04 +0000 Subject: [Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298 --- Comment #93 from Jonathan Druart --- (In reply to mathieu saby from comment #92) > Are these renaming really needed? Are they made for avoiding confusion > somewhere in code? I wrote this patch 18 months ago, so I don't know why I renamed these fields. Certainly I preferred to use "unitpricesupplier" rather than "rrp". But "unitpricelib" is not a good choice... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 10:24:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 09:24:13 +0000 Subject: [Koha-bugs] [Bug 11198] New: KOHA INSTALLATION Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11198 Bug ID: 11198 Summary: KOHA INSTALLATION Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt at gmail.com Reporter: shiju at virtusindia.com QA Contact: testopia at bugs.koha-community.org The Koha online catalog is offline for system maintenance. We'll be back soon! How -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:16:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 10:16:40 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Jonathan Druart --- back to need QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:55:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 10:55:32 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Small patch |Medium patch QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #49 from Jonathan Druart --- QA comment: Looks good. 3 remarks: 1/ format_date should be removed (use the TT plugin) - not introduced by these patches 2/ CURRENT_DATE is a mysqlism 3/ I would prefer GetReservesFromItemnumber returns only a reserve hashref (what I did for bug 8367). I will provide a followup for 1 and 2. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:58:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 10:58:22 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22643|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart --- Created attachment 22685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22685&action=edit Bug 9788: Improvements when calling GetReservesFromItemnumber Description: GetReservesFromItemnumber also returns waiting date. Simplifies some code. Improves item status display on catalogue detail, when placing a hold at opac-reserve and in staff, and on transfers to receive form. This patch builds on work from reports 9367 and 9761. Test plan: Place a future next-av. hold (enable future holds prefs), say 2 days ahead. Check item status on catalogue detail. Nothing to see. Enable ConfirmFutureHolds by inserting a number of days, say 2. Confirm earlier hold by checking it in. Look at item status again on detail. Switch to other opac user. Try to place a hold again. Check item status with item level hold info. Try to place hold in staff, check item level status. Make a transfer for that item. Switch branch. Look at transfers to receive. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:58:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 10:58:30 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22644|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart --- Created attachment 22686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22686&action=edit Bug 9788: Followup removing the alldates parameter Before bug 9788 the alldates parameter of GetReservesFromItemnumber was actually not used in the codebase. The first patch of bug 9788 did change that and passed true by default. But a closer look revealed that we do not really need it. The parameter is removed by this patch; the SQL statement is slightly adjusted: if reservedate<=now or a waitingdate is filled for the requested itemnumber, GetReservesFromItemnumber will return the reserve. This includes so-called future waits: a future hold that has been confirmed ahead of time with pref ConfirmFutureHolds > 0 days. Note that future item-level holds are not really interesting to return; this just corresponds to original behavior. Future next-available holds are not in view at all; they do not contain an item number. Test plan: Actually, the test plan of the first patch is valid. But for completeness I repeat it here: [1] Enable future holds and set ConfirmFutureHolds to 2 days. [2] Place a future next-available hold for 2 days ahead. [3] Check item status on catalogue detail. Available? That is fine. [4] Confirm the future hold by checking it in. ('future wait') [5] Look at item status again on catalogue detail. Must be Waiting now. [6] Switch to OPAC and login as another opac user. Goto Place a hold. [7] Check item status with item level hold info. Is it waiting? [8] Try to place hold in staff, check item level status again. Waiting? [9] Make a transfer for the item. Switch branch. Check hold status on Transfers to receive. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:58:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 10:58:36 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22645|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart --- Created attachment 22687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22687&action=edit Bug 9788: Followup for expirationdate in Letter.pm Pasting comment from the Bugzilla report: Looking bit longer at this code, it is kind of strange to find it there in the first place. Adding maxpickupdelay in Letters.pm should not be there, but it is.. Also this date is not used normally in the default HOLD Available for Pickup notice (that we are generating in this case). And if it would be undef, the expiration date should imo be empty instead of today+0. (before adding maxreservespickupdelay, you should test the allowexpire pref first) So it is an (invisible) bug on its own. Test plan: See former patch. Kyle just discovered this bug, apparently by deleting the maxpickupdelay pref.. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:58:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 10:58:42 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22646|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart --- Created attachment 22688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22688&action=edit Bug 9788: Unit tests for changed routine GetReservesFromItemnumber Adds three tests to Reserves.t for GetReservesFromItemnumber. We test if this routine does not return a future next available hold, a future item level hold. And if it does return a future wait (that is: a confirmed future hold, using ConfirmFutureHolds). Note that Holds.t does also contains some basic tests for this routine, but the additional tests seem to better located in the direct context of tests for bug 9761 for ConfirmFutureHolds. Test plan: Run both t/db_dependent/Holds.t and t/db_dependent/Reserves.t. Verify if both tests do not fail. Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:58:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 10:58:48 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #54 from Jonathan Druart --- Created attachment 22689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22689&action=edit Bug 9788: QA followup 1/ CURRENT_DATE is a mysql and should be replaced with CAST(now() AS date). 2/ The date formatting should be done in the template (using the TT plugin). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:24:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 11:24:33 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |jonathan.druart at biblibre.co | |m --- Comment #51 from Jonathan Druart --- QA comment: Works as described. There is a typo in updatedb (wthdrawn vs withdrawn). The itemlost date (itemlost_on value) should be display only if the itemlost value is set (!= ""). I will submit a followup. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:26:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 11:26:34 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21730|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart --- Created attachment 22690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22690&action=edit Bug 9673 - Track when items are marked as lost or withdrawn Add date fields to track when an item was marked as lost or withdrawn. Display those fields on catalogue/moredetail.pl Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Pick a record with items, browse to the 'items' tab ( moredetail.pl ) 4) Mark an item as lost, verify the field "Lost on:" displays below the "Lost status" field with todays date. 5) Mark the item as not lost, verify the field no longer displays 6) Repeat steps 4 and 5 with the Withdrawn field. Signed-off-by: Mathieu Saby Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:26:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 11:26:47 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21731|0 |1 is obsolete| | --- Comment #53 from Jonathan Druart --- Created attachment 22691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22691&action=edit Bug 9673: QA followup This followup fixes the wthdrawn typo exist in updatedatabase.pl and does not display the lostitem date if the lostitem value is not set (!= ""). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:28:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 11:28:12 +0000 Subject: [Koha-bugs] [Bug 9673] Track when items are marked as lost or withdrawn In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9673 --- Comment #54 from Jonathan Druart --- I forgot to mention: I squashed the 2 patches (second patch fixed the typo and was not useful for the history). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:33:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 11:33:28 +0000 Subject: [Koha-bugs] [Bug 11024] Transfer limits should be respected in the build_holds_queue.pl -script. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22324|0 |1 is obsolete| | --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 22692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22692&action=edit Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script. Depends on bug 11005 Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm Includes unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:33:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 11:33:50 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22689|0 |1 is obsolete| | --- Comment #55 from M. de Rooy --- Created attachment 22693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22693&action=edit Bug 9788: QA followup 1/ CURRENT_DATE is a mysql and should be replaced with CAST(now() AS date). 2/ The date formatting should be done in the template (using the TT plugin). Signed-off-by: Jonathan Druart Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:35:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 11:35:21 +0000 Subject: [Koha-bugs] [Bug 11024] Transfer limits should be respected in the build_holds_queue.pl -script. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11024 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22692|0 |1 is obsolete| | --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 22694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22694&action=edit Bug 11024 - Transfer limits should be respected in the build_holds_queue.pl -script. Depends on bug 11005 Adds the UseBranchTransferLimits-functionality to HoldsQueue.pm Includes unit tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:35:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 11:35:45 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 --- Comment #56 from M. de Rooy --- (In reply to Jonathan Druart from comment #49) > 1/ format_date should be removed (use the TT plugin) - not introduced by > these patches > 2/ CURRENT_DATE is a mysqlism > 3/ I would prefer GetReservesFromItemnumber returns only a reserve hashref > (what I did for bug 8367). > > I will provide a followup for 1 and 2. Thanks, Jonathan. I would suggest to open a new report for your third point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:36:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 11:36:19 +0000 Subject: [Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22684|0 |1 is obsolete| | CC| |jonathan.druart at biblibre.co | |m --- Comment #6 from Jonathan Druart --- Created attachment 22695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22695&action=edit Bug 11189 : Rename Print label in UNIMARC advanced search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:36:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 11:36:50 +0000 Subject: [Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Jonathan Druart --- QA comment: String patch. Will be for 3.16 Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:41:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 11:41:48 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22357|0 |1 is obsolete| | --- Comment #33 from Olli-Antti Kivilahti --- Created attachment 22696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22696&action=edit Bug 7376 - Transfer limits should be checked at check-in Extended UseBranchTransferLimits-check to the check-in case. Made it possible to override the check-in with circulation-permission if BranchTransfer is denied. Made unit tests for the C4/Circulation.pm and C4/SIP/t/08checkin.t *Also added override-functionality to Circulation::AddReturn() to override BranchTransferLimits. (+unit tests) *Renamed CanBookBeReturned to CanItemBeReturned since that function was referenced from AddReturn only. --This is because function name misguidingly references to a book/Biblio/Title-level, even if the functionality is strictly --Item dependent. *Removed duplicating code by making CanItemBeTransferred() call IsBranchTransferAllowed(). *Made a unit test library out of CanItemBeTransferred.t's environment initialization parts, so these need not be duplicated whenever UseBranchTransferLimits-related functionality is tested. *Documented SIP-testing hardships to C4/SIP/README -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:29:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 12:29:26 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:29:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 12:29:29 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21205|0 |1 is obsolete| | --- Comment #13 from M. de Rooy --- Created attachment 22697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22697&action=edit Bug 10648 - In records merge greatest field can not be added When merging 2 records (/cgi-bin/koha/cataloguing/merge.pl), the destination record is build using the fields and subfields checked in source records. When a field is checked, the javascript code searches in destination record a field with a greater tag number to insert new field before. When the new field tag number is greater than all existing field tag numbers, the field is not added. This patch corrects this by adding at end if no greater field tag number exists. Also adds a sort of fields by tag number because all mergo code is based on this. Test plan : - Add to a framework a repeatable field with the greater non existing tag number. For example 998. - Edit 2 records with this framework and add them a value in this tag. - Put those records is a list - Go to this list and check the two records - Click on "Merge selected" - Click on next - Go to second source record - Click on the greatest tag number. for example 998. => The field is added at the end of destination record Signed-off-by:Mathieu Saby Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:29:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 12:29:46 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:31:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 12:31:20 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from M. de Rooy --- QA Comment: Good catch. No string changes. Looks good to me. No complaints from qa tools. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:32:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 12:32:44 +0000 Subject: [Koha-bugs] [Bug 10648] In records merge greatest field can not be added In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Lists |Cataloging QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:20:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:20:27 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #46 from Paola Rossi --- against master 3.13.00.042: Applying: Bug 10855: New fields on adding/updating a subscription Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging serials/subscription-detail.pl Auto-merging serials/subscription-add.pl Auto-merging C4/Serials.pm CONFLICT (content): Merge conflict in C4/Serials.pm Failed to merge in the changes. Patch failed at 0001 Bug 10855: New fields on adding/updating a subscription So I pass the patch to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:33:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:33:43 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22604|0 |1 is obsolete| | --- Comment #47 from Jonathan Druart --- Created attachment 22698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22698&action=edit Bug 10855: New fields on adding/updating a subscription This patch adds the ability to add values for additional fields when adding/updating a subscription. Test plan (test the following on adding a new subscription and on editing an existent one): - add/edit a subscription. - verify all additional fields appears into the "Additional fields" block. - fill a value for af1 and af3. - fill others values if you are adding a new subscription. - save. - verify values appears on the detail of the subscription page. - verify the af2 field is automatically filled with the specified marc field of the notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:33:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:33:48 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22605|0 |1 is obsolete| | --- Comment #48 from Jonathan Druart --- Created attachment 22699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22699&action=edit Bug 10855: Search subscriptions by additional fields Now you will abble to search subscriptions by additional fields. The additional field values will be displayed in the table results. Test plan: - go on the subscriptions advanced search page (serials/serials-search.pl). - verify all searchable additional fields are displayed on the form. - combine 1 or more values and verify results are consistent. - verify the values are displayed in new columns of the table. - for field linked to an authorised value category, the description is displayed (not the code). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:33:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:33:53 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22606|0 |1 is obsolete| | --- Comment #49 from Jonathan Druart --- Created attachment 22700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22700&action=edit Bug 10855: Search subscriptions by additional fields on the claim page Test plan: - create some serials in late. - go on serials/claims.pl. - choose a vendor. - verify that additional fields are displayed in new columns. - try filters on columns. - verify there is no regression on this page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:33:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:33:59 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22607|0 |1 is obsolete| | --- Comment #50 from Jonathan Druart --- Created attachment 22701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22701&action=edit Bug 10855: FIX: Add additional fields for closed subscriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:34:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:34:05 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22608|0 |1 is obsolete| | --- Comment #51 from Jonathan Druart --- Created attachment 22702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22702&action=edit Bug 10855: Fix instance vs static method This patch fixes the error message. The 3 modified routines *are* static methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:34:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:34:10 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22616|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart --- Created attachment 22703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22703&action=edit Bug 10855: Update database entry Add 2 tables: additional_fields and additional_field_values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:34:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:34:28 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:47:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:47:49 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #3 from Kyle M Hall --- Created attachment 22704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22704&action=edit Update Schema Files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:47:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:47:59 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21922|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 22705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22705&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:53:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:53:45 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:53:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:53:48 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16256|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 22706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22706&action=edit Bug 9823: Refactor return from GetReservesFromBiblionumber The return from GetReservesFromBiblionumber contains an unnecessary extra variable. In scalar context an array returns its element count. Maintaing a separate count can lead to unforeseen bugs and imposes ugly constructions on the subroutine's users. Remove the useless count variable from the return This patch also changes the parameters: now the routine takes a hashref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:54:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:54:15 +0000 Subject: [Koha-bugs] [Bug 9823] Code optimization: Change prototype of GetReservesFromBiblionumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9823 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|8918 |9788 --- Comment #10 from Jonathan Druart --- I remove the dependencies on bug 8918. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:54:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:54:15 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|9823 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:54:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:54:15 +0000 Subject: [Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9823 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:54:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:54:41 +0000 Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:54:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:54:45 +0000 Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22660|0 |1 is obsolete| | --- Comment #16 from M. de Rooy --- Created attachment 22707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22707&action=edit Bug 10895 - Tests for C4::Items GetHiddenItems Bug 10589 introduces PatronSingleBranch and PatronEveryBranch system preferences. This ensures that the visibility of two dummy records matches expectations. OpacHiddenItems is set to hide 2 records. The system preferences are then toggled between four cases ('SPT','SS','','SS|SPT') cross multipled for the two system preferences to verify the correct visibility. This will fail for a system with bug 10589 not applied, since this tests the functionality of that patch. This will fail for a system with bug 10900 not applied, since the calling convention for set_userenv was fixed in C4::Context in this patch. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:59:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 13:59:52 +0000 Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895 --- Comment #17 from M. de Rooy --- Works as advertised. Impressive number of test cases. Needs the dependent reports. Note that these dependencies will make it harder to get everything in. I did not test the other one (10589) which might be more tricky.. Personally, I would not mind passing QA on this report, but more formally another QAer should do that ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:01:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:01:07 +0000 Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895 --- Comment #18 from M. de Rooy --- (In reply to M. de Rooy from comment #17) > Note that these dependencies will make it harder to get everything in. I did > not test the other one (10589) which might be more tricky.. Personally, I > would not mind passing QA on this report, but more formally another QAer > should do that ;) 10589 should be 10900 here.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:13:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:13:22 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22705|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 22708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22708&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:13:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:13:50 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22704|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 22709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22709&action=edit Update Schema Files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:14:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:14:00 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22708|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 22710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22710&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:17:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:17:55 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #8 from Kyle M Hall --- Also available at http://git.bywatersolutions.com/koha.git/shortlog/refs/heads/accounts_rewrite -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:19:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:19:24 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Small patch QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #38 from Jonathan Druart --- QA comment: The syspref makes sense for me. It works as described. The pref should not be filled (syspref.sql and updatedb): it will be displayed in English for everybody. Since a default message is defined in the template, the pref value should be empty. I will provide a followup for that and for 4 tab characters. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:21:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:21:05 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21816|0 |1 is obsolete| | Attachment #21855|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart --- Created attachment 22711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22711&action=edit Bug 10951 - Adding NoLoginInstructions to system preferences On a failed login, the default message is harcorded into opac-auth.tt. It would be preferable to allow for a preference to override that message (for example: ...Please bring an ID to t The changes modify -opac-auth.tt to allow for custom value -admin/preferences/opac.pref to add it to the preferences with a description -C4/Auth.pm for the loading of the preference -sysprefs.sql -updatedatabase.pl TESTING 1) in OPAC, logged out, try login in by entering no or wrong credentials. Acknowledge the "Don't have a p 2) Apply the patch 3) Regression Test: Redo step 1. Same (default) message should appear. 4) Log in to intranet, - select NoLoginInstructions in system preferences. - Enter new (xml) message. Possible:
Welcome to Koha, please bring your passport to the front office
- and save 5) refresh the OPAC, try login again with invalid credentials. The new message should appear. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:21:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:21:13 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 --- Comment #40 from Jonathan Druart --- Created attachment 22712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22712&action=edit Bug 10951 - Tweaked opac-auth.tt sentence. The change was causing issue with the next sentence. Adjusted the start (uppercase) and ending (dot) on self-registration invitation. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:21:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:21:18 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 --- Comment #41 from Jonathan Druart --- Created attachment 22713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22713&action=edit Bug 10951: The new pref NoLoginInstructions should be empty by default. We don't want to display an English message by default for everybody. The default message is in the template, so the pref should be empty. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:22:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:22:07 +0000 Subject: [Koha-bugs] [Bug 10951] Make the NoLoginInstructions a customizable field through preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10951 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #42 from Jonathan Druart --- Note for RM: maybe "patron" is better than "person" in the pref description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:35:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:35:03 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21759|0 |1 is obsolete| | --- Comment #17 from M. de Rooy --- Created attachment 22714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22714&action=edit Bug 9468 - Add ability to hide items from purchase suggestions forms Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Add some itemtypes to the new system pref SuggestionsHideItemTypes 4) Make a purchase suggestion 5) Verify those item types set in SuggestionsHideItemTypes do not appear in the pulldown menu for "Item type" Signed-off-by: Frederic Durand Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:35:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:35:10 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21760|0 |1 is obsolete| | --- Comment #18 from M. de Rooy --- Created attachment 22715 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22715&action=edit Bug 9468 - Add ability to hide itemtypes from purchase suggestions forms - QA Followup Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:37:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:37:05 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #19 from M. de Rooy --- QA Comments: Referring to Jonathan's comments and Kyle's replies: This works as advertised within its current limited implementation. Could be extended in the future. The function affects opac only now. Code looks good to me. No complaints from qa tools. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:37:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:37:35 +0000 Subject: [Koha-bugs] [Bug 9468] Add ability to hide itemtypes from purchase suggestions forms In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9468 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:41:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:41:51 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 --- Comment #80 from Jonathan Druart --- Nicole, The following files still contain the string "3.12", do you plan to change them? help/circ/branchoverdues.tt help/circ/branchtransfers.tt help/circ/circulation-home.tt help/circ/circulation.tt help/circ/overdue.tt help/circ/pendingreserves.tt help/circ/reserveratios.tt help/circ/returns.tt help/circ/selectbranchprinter.tt help/circ/transferstoreceive.tt help/circ/view_holdsqueue.tt help/circ/waitingreserves.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:44:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:44:23 +0000 Subject: [Koha-bugs] [Bug 9492] Children funds not clear if limited to my branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9492 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |z.tajoli at cineca.it --- Comment #2 from Zeno Tajoli --- Hi, It is possible to fix the situation with this change on line 63 of admin/aqbudgets.pl: From: my $show = $input->param('show') // 0; # SET TO 1, BY A FORM SUMBIT to: $show = $input->param('show') // 1; # SET TO 1 by default, group view. But the result is ok only if all budget are from one library/librarian. Not if your budget are of different libraries/librarians In fact we need to rethink the interface that now is a mix of cgi, js filter and css effects show/don't show. The problem is present in 3.8, 3.12 and master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:44:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:44:43 +0000 Subject: [Koha-bugs] [Bug 9492] Children funds not clear if limited to my branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9492 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.8 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:45:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 14:45:19 +0000 Subject: [Koha-bugs] [Bug 9492] Children funds not clear if limited to my branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9492 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 16:04:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 15:04:51 +0000 Subject: [Koha-bugs] [Bug 11198] KOHA INSTALLATION In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11198 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard --- Bug reports are not a good way to get support for Koha. You could try the Koha manual (http://koha-community.org/documentation/), Koha mailing lists (http://koha-community.org/support/koha-mailing-lists/), Koha IRC (http://koha-community.org/get-involved/irc/), or a support company (http://koha-community.org/support/paid-support/). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 16:11:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 15:11:07 +0000 Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 16:12:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 15:12:18 +0000 Subject: [Koha-bugs] [Bug 10729] Support phrases-icu.xml in install and upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10729 --- Comment #22 from mathieu saby --- It seems very interesting. Will it be in 3.14 ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:47:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 17:47:02 +0000 Subject: [Koha-bugs] [Bug 11199] New: 008 value builder skips invalid characters and collapses remaining data Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11199 Bug ID: 11199 Summary: 008 value builder skips invalid characters and collapses remaining data Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: eb at efdss.org QA Contact: testopia at bugs.koha-community.org CC: dpk at randomnotes.org, m.de.rooy at rijksmuseum.nl This is a problem with imported records where the # character is present instead of a blank (though it also seems to happen if there is any character present that is not in the available lists). It only happens if you open the 008 value builder to edit the field after the record has been imported. Here's an example of a problematic 008: 130515s2006####stka###gr#####000#0#eng#d If I edit the record and open the 008 value builder, Koha automatically changes it to: 130515s2006 It ignores all the # characters, and shifts everything over, thus changing characters that were valid in their original position into invalid characters (or incorrect characters, though valid) in their new positions. If a character in a new position is invalid, Koha ignores it as well and collapses the data. . . Because the invalid characters are still there (though they are ignored)if you try to edit the above 008 in the value builder, changes don't always end up where you think you put them. The only way to be certain all positions are entered correctly is to return to the MARC editing page, clear the contents of the 008 and start over. This is what it looks like after manually clearing the field and entering the information: 131030s2006 stka gr 000 0 eng d The # have all been turned into blanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 19:08:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 18:08:12 +0000 Subject: [Koha-bugs] [Bug 2193] Lost Item Fines - Editable if $0 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2193 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 19:12:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 18:12:41 +0000 Subject: [Koha-bugs] [Bug 10167] payment not showing what's paid for if not an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10167 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 22:00:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 21:00:52 +0000 Subject: [Koha-bugs] [Bug 6918] can't place holds on 'on order' items with AllowOnShelfHolds off In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6918 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 22:02:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2013 21:02:10 +0000 Subject: [Koha-bugs] [Bug 8952] Add http:// to url in social media links on opac-detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8952 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 04:21:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 03:21:51 +0000 Subject: [Koha-bugs] [Bug 11092] Need a processing fee and billing fee on late notices. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #4 from M. Tompsett --- Blou, you may wish to rebase this, because I can't apply this to master or 3.10.12. Your patches are also not git-bz friendly. Patch 2 bombs badly when attempting to manually apply. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 04:38:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 03:38:13 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 04:39:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 03:39:07 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 04:39:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 03:39:27 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 04:40:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 03:40:12 +0000 Subject: [Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 05:36:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 04:36:25 +0000 Subject: [Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 --- Comment #58 from Bob Birchall --- Where is this up to? Its marked 'Does not apply'. If it can be re-based, I'm up for testing it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:42:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 09:42:10 +0000 Subject: [Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 --- Comment #10 from Katrin Fischer --- I think we have run into this problem in 3.12 - maybe a candidate for a backport? Not sure if there are dependencies on other features in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:43:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 09:43:13 +0000 Subject: [Koha-bugs] [Bug 9024] Add additional sample data to German installer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9024 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 11:02:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 10:02:58 +0000 Subject: [Koha-bugs] [Bug 11200] New: Adding subfield without field in addbiblio.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11200 Bug ID: 11200 Summary: Adding subfield without field in addbiblio.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: nunyo at masmedios.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In addbiblio.pl, subfield is adding but don't check if field exist. if ($title) { # $field->add_subfields("$subfield"=>"[ ".ucfirst($title).ucfirst($firstname)." ".$number." ]"); $field->add_subfields( "$subfield" => ucfirst($title) . " " . ucfirst($firstname) . " " . $number ); } else { # $field->add_subfields("$subfield"=>"[ ".ucfirst($firstname).", ".ucfirst($lastname)." ]"); $field->add_subfields( "$subfield" => ucfirst($firstname) . ", " . ucfirst($lastname) ); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 11:32:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 10:32:57 +0000 Subject: [Koha-bugs] [Bug 11200] Adding subfield without field in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11200 Nu?o L?pez Ans?tegui changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |nunyo at masmedios.com Assignee|gmcharlt at gmail.com |nunyo at masmedios.com --- Comment #1 from Nu?o L?pez Ans?tegui --- Created attachment 22716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22716&action=edit Bug 11200 - Adding subfield without field in addbiblio.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:20:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 11:20:15 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21247|0 |1 is obsolete| | Attachment #21248|0 |1 is obsolete| | Attachment #21249|0 |1 is obsolete| | Attachment #21542|0 |1 is obsolete| | Attachment #21661|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 22717 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22717&action=edit Bug 10863: Add 2 circulation permissions: force_checkout and lift_restriction This patch adds 2 circulation permissions: force_checkout and lift_restriction. Both are added to existing patrons having circulation flags. force_checkout allows a librarian to force a checkout if a limitation occurred. lift_restriction allows a librarian to lift a restriction for a patron. Test plan: 1/ Find a debarred patron and go on the checkout page. The "Lift restriction" button should be present only if the logged librarian has the lift_restriction permission. 2/ If the force_checkout permission is set, a librarian should be allowed to check out in several cases: - age restriction - the item is issued to another patron - the item is not for loan - the patron has overdue items - the item is lost - the item is a high demand item - the item is reserved - another case ? Signed-off-by: Cedric Vita Bug 10863: The force checkout permission should not affect high holds - typo checkout => check out. - the force checkout permission does not affect high holds. Signed-off-by: Cedric Vita Bug 10863: Follow-up: Adding missing permissions to translated files This patch adds the 2 new permissions to all remaining sample files. If the permissions don't get installed, the problem is bigger than having an English description. Also adds back the question "Check out anyway?" for high demand items (HIGHHOLDS). Test xt/permissions.t passes now. Bug 10863: Rename lift_restriction with manage_restrictions The pref manage_restrictions now takes into account "Lost card" and "Gone no address" restrictions. Test plan: - log in with a user with manage_restrictions permission - verify you can set/unset restrictions when editing a patron - log in with a user without manage_restrictions permission - verify you cannot set/unset restrictions when editing a patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:21:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 11:21:54 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 --- Comment #29 from Jonathan Druart --- Bug 2720 breaks existing patches. I squashed them and rewrite a part of the original patches. Back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:22:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 11:22:42 +0000 Subject: [Koha-bugs] [Bug 10859] Alert if a patron already has an issue for the same biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #6 from Jonathan Druart --- I rebased bug 10863, this one applies cleanly now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:22:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 11:22:55 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2720 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:22:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 11:22:55 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10863 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:28:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 11:28:40 +0000 Subject: [Koha-bugs] [Bug 11201] New: List pending in-house uses Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Bug ID: 11201 Summary: List pending in-house uses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:29:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 11:29:07 +0000 Subject: [Koha-bugs] [Bug 11201] List pending in-house uses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |10860, 10859 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:29:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 11:29:07 +0000 Subject: [Koha-bugs] [Bug 10859] Alert if a patron already has an issue for the same biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10859 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11201 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:29:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 11:29:07 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11201 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:34:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 11:34:09 +0000 Subject: [Koha-bugs] [Bug 11201] List pending in-house uses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 --- Comment #1 from Jonathan Druart --- Created attachment 22718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22718&action=edit Bug 11201: Add a in-house use list pages The circulation page has a new entry: a link to a list of the pending in-house use. Bug 10860 introduces a new way for managing in-house uses. This patch adds a new page (from the circulation home page) to list all pending in-house uses. Test plan: Go on the circulation home page and click on the in-house use link. Verify all your in-house uses are listed and information are consistent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:34:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 11:34:29 +0000 Subject: [Koha-bugs] [Bug 11201] List pending in-house uses In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11201 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 14:02:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 13:02:25 +0000 Subject: [Koha-bugs] [Bug 11092] Need a processing fee and billing fee on late notices. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22158|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 14:02:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 13:02:41 +0000 Subject: [Koha-bugs] [Bug 11092] Need a processing fee and billing fee on late notices. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22159|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 14:04:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 13:04:13 +0000 Subject: [Koha-bugs] [Bug 11092] Need a processing fee and billing fee on late notices. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11092 Blou changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22160|0 |1 is obsolete| | --- Comment #5 from Blou --- Comment on attachment 22160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22160 Add a processing fee and billing fee on late notices I attached these for the benefit of kivi, but they cause too much confusion. I'll redo them cleanly in the master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 14:50:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 13:50:04 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #53 from Paola Rossi --- The patches are applied well against 3.13.00.042. Test plan "prove t/db_dependent/AdditionalField.t" results in a FAIL: t/db_dependent/AdditionalField.t .. 1/34 DBD::mysql::st execute failed: Column 'status' cannot be null at /var/root-koha/bug-10855/C4/Serials.pm line 1501. DBD::mysql::st execute failed: Column 'status' cannot be null at /var/root-koha/bug-10855/C4/Serials.pm line 1501. # Looks like you planned 34 tests but ran 20. # Looks like your test exited with 255 just after 20. t/db_dependent/AdditionalField.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 14/34 subtests Test Summary Report ------------------- t/db_dependent/AdditionalField.t (Wstat: 65280 Tests: 20 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 34 tests but ran 20. Files=1, Tests=20, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.37 cusr 0.16 csys = 0.55 CPU) Result: FAIL So I pass the patch to "Failed QA" status. NB. In my test case, af2 is 245, and the title of the subscribed notice is "Bulletin". Testing new fields on adding/updating a subscription, the af2 field is not filled with the specified marc field of the notice, i.e. there is no "Bulletin" on the left of the sentence "This value will be filled with the 245 subfield of the selected biblio.". Afterwards I set af2 to 245a and try again, but yet nothing appears. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 14:56:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 13:56:26 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_11180=5D__=E2=80=8B_IP_branch_attrib?= =?utf-8?q?ute_should_accept_CIDR_notation?= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11180 Pablo AB changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|IP branch attrib showld |? IP branch attribute |acept CIDR notation |should accept CIDR notation -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:04:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:04:47 +0000 Subject: [Koha-bugs] [Bug 9500] GetNormalizedISBN only ever checks the first populated ISBN field In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9500 Denise changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |d.gavio at aarome.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:15:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:15:54 +0000 Subject: [Koha-bugs] [Bug 11119] Silent zebra in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119 --- Comment #9 from mathieu saby --- Hello Paul I believe you regenerated DOM files from record.abs. This is maybe not a good idea, as the different files have now to live their own lives... I am writing a patch with a lot of little changes, I will include inside it the changes discussed here ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:17:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:17:04 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21333|0 |1 is obsolete| | --- Comment #47 from Julian Maurice --- Created attachment 22719 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22719&action=edit [SIGNED-OFF] Bug 7162: Factorize code for order cancellation Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:17:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:17:28 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21334|0 |1 is obsolete| | --- Comment #48 from Julian Maurice --- Created attachment 22720 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22720&action=edit [SIGNED-OFF] Bug 7162 [Follow-up] Fix referrer URL when coming from parcel.pl Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:17:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:17:42 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21335|0 |1 is obsolete| | --- Comment #49 from Julian Maurice --- Created attachment 22721 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22721&action=edit Bug 7162; Factorize code for order cancellation (QA fixes) Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:17:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:17:54 +0000 Subject: [Koha-bugs] [Bug 7162] Factorize code for order cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:31:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:31:44 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #54 from Jonathan Druart --- Created attachment 22722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22722&action=edit Bug 10855: FIX conflicts with bug 7688 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:33:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:33:30 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #55 from Jonathan Druart --- (In reply to Paola Rossi from comment #53) > NB. In my test case, af2 is 245, and the title of the subscribed notice is > "Bulletin". Testing new fields on adding/updating a subscription, the af2 > field is not filled with the specified marc field of the notice, i.e. there > is no "Bulletin" on the left of the sentence "This value will be filled with > the 245 subfield of the selected biblio.". Afterwards I set af2 to 245a and > try again, but yet nothing appears. Last patch fixes the UT. You have to save your subscription for filling the value linked to a marc field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:34:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:34:29 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21337|0 |1 is obsolete| | --- Comment #16 from Julian Maurice --- Created attachment 22723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22723&action=edit [SIGNED-OFF] Bug 8868: ILS-DI: CancelHold needs to take a reserve_id Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:34:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:34:41 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21338|0 |1 is obsolete| | --- Comment #17 from Julian Maurice --- Created attachment 22724 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22724&action=edit Bug 8868: ILS-DI: CancelHold needs to take a reserve_id (follow-up) Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:34:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:34:53 +0000 Subject: [Koha-bugs] [Bug 8868] ILS-DI: CancelHold needs to take a reserve_id In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8868 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:37:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:37:38 +0000 Subject: [Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22402|0 |1 is obsolete| | --- Comment #6 from M. de Rooy --- Created attachment 22725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22725&action=edit bug_10781: Removed ILSDI::Utility Test: This should be a noop. Regression testing required: /cgi-bin/koha/ilsdi.pl functioanality, in particuler: GetAvailability - ?service=Describe&verb=GetAvailability AuthenticatePatron - ?service=Describe&verb=AuthenticatePatron ILS-DI syspref must be turned on Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:40:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:40:22 +0000 Subject: [Koha-bugs] [Bug 10781] Remove C4::ILSDI::Utility In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10781 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Severity|enhancement |minor --- Comment #7 from M. de Rooy --- QA Comment: Tested both functions with ilsdi.pl. Works fine. Code looks good to me. No complaints from qa tools. Moving from enh to bugfix. No string changes. Still looks like a candidate for 3.14. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:44:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:44:57 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21340|0 |1 is obsolete| | --- Comment #19 from Julian Maurice --- Created attachment 22726 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22726&action=edit Bug 7957: Routing lists enhancements Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:46:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:46:28 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:58:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:58:05 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21341|0 |1 is obsolete| | --- Comment #54 from Julian Maurice --- Created attachment 22727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22727&action=edit [SIGNED-OFF] Bug 8296: Add descriptive (text) published date field for serials Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:58:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:58:26 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21342|0 |1 is obsolete| | --- Comment #55 from Julian Maurice --- Created attachment 22728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22728&action=edit [SIGNED-OFF] Bug 8296: set input maxlength to the same of sql field length Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:58:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:58:46 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21343|0 |1 is obsolete| | --- Comment #56 from Julian Maurice --- Created attachment 22729 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22729&action=edit [SIGNED-OFF] Bug 8296: Follow up for QA Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:58:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:58:58 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21344|0 |1 is obsolete| | --- Comment #57 from Julian Maurice --- Created attachment 22730 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22730&action=edit Bug 8296: Don't fill text field automatically Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:59:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 14:59:11 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:27:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 15:27:13 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21328|0 |1 is obsolete| | Attachment #21329|0 |1 is obsolete| | Attachment #21330|0 |1 is obsolete| | --- Comment #31 from Julian Maurice --- Created attachment 22731 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22731&action=edit Bug 8918: Calculate hold priority in AddReserve Priority was calculated outside of this sub, in separate places. Priority was not calculated when using ILS-DI. This patch factorize code by putting the priority calculation code into AddReserve. Test plan: 1/ Place multiple holds in staff interface and check the priority is incremented for each hold. 2/ Do the same in OPAC. 3/ Place multiple holds using ILS-DI HoldTitle service: /cgi-bin/koha/ilsdi.pl?service=HoldTitle&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER and check the priority is incremented for each hold. 4/ Do the same using HoldItem service: /cgi-bin/koha/ilsdi.pl?service=HoldItem&patron_id=BORROWERNUMBER&bib_id=BIBLIONUMBER&item_id=ITEMNUMBER Note: this is a squashed version of 3 previous patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:27:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 15:27:24 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 --- Comment #32 from Julian Maurice --- Created attachment 22732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22732&action=edit Bug 8918: Add a unit test for GetReserveNextRank -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:27:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 15:27:52 +0000 Subject: [Koha-bugs] [Bug 8918] ILS-DI: HoldTitle and HoldItem do not calculate rank of hold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8918 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:36:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 15:36:35 +0000 Subject: [Koha-bugs] [Bug 11202] New: Improve UNIMARC biblio indexing Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 Bug ID: 11202 Summary: Improve UNIMARC biblio indexing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:37:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 15:37:36 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #1 from mathieu saby --- Created attachment 22733 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22733&action=edit Improve UNIMARC biblio indexing This patch makes the following changes to UNIMARC biblio indexing : A. Changes to UNIMARC conf files 1. add comments to biblio-koha-indexdefs.xml 2. make biblio-koha-indexdefs.xml more compact by grouping some declarations Ex : 200$f and 200$g => one declaration for 200$fg 3. suppress unneeded declarations (indexing of some 4XX fields and 6XX fields not in unimarc format) 4. unindex some fields unneeded by most users (328, 207,230,210a,215) 6. replace Title-host with Host-item -- see bug 11119 7. index 208 in Material-Type -- see bug 11119 8. index 100 pos 8-9 and 9-12 in pubdate, but not in pubdate:s This change will only index 2 new fields, but not change the current sorting (made on 210$d) More work is needed for improving date management. 9. Index all subfields of note 318 and 327 in note index 10. Index 304 and 327 in title index as well as note index 327 can contain a list of titles included in a work 304 can contain the title of the original work in case of a translation 11. Index 314 in author index as well as note index 314 can contain authors not mentionned in 200$f/g (the 4th, 5th etc author) 12. Index 328 note in Dissertation-information as well as note B. Changes to ccl.properties : 1. add a new index Dissertation-information (1056) 2. fix EAN, pubdate and acqdate (they were not linked with bib1 attributes) C. Changes to Search.pm 1. add Dissertation-information and suppress Title-host and UPC D. Changes to QP config file queryparser.yaml 1. add Dissertation-information 2 fix EAN, pubdate and acqdate Test plan : If you cannot test in GRS1, test only in DOM, as GRS will be deprecated. 1. Apply the patch in a UNIMARC Koha running with DOM and ICU 2. copy src/etc/searchengine/queryparser.yaml into the main config directory of QP 2. copy src/etc/zebradb/* (all the tree) into the main config directory of Zebra 3. reindex biblios (rebuild_zebra.pl -r -b -x -v) 4. test note index : make some searches on 318$b or 327$b 5. test author index : make some searches on 314 field 6. test title index : make some searches on 304 and 327 field 7. test Dissertation-information index : make some searches on 328 field 8. In a record, put in the dates of 100 fields the values "1000" and "1001" ; try to search a book written in year 1000, you should find the record ; idem for year 1001 9. Regression test (with and without QP activated) : make some searches and sort by date. It should work (well or bad...) as before 10. Regression test (with and without QP activated) : make some searches on EAN (073). It should work as before -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:37:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 15:37:52 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:45:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 15:45:07 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #2 from mathieu saby --- something went wrong... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:57:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 15:57:21 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #16 from Julian Maurice --- The problem is that PROFESSION attribute has equivalent values with different cases. mysql> SELECT attribute FROM borrower_attributes WHERE code = 'PROFESSION' AND borrower_attributes.attribute is not null AND borrower_attributes.attribute LIKE 'Enseignant'; +------------+ | attribute | +------------+ | Enseignant | | enseignant | +------------+ The mysql GROUP BY clause is case insensitive, so in the process we lose one of those values mysql> SELECT attribute FROM borrower_attributes WHERE code = 'PROFESSION' AND borrower_attributes.attribute is not null AND borrower_attributes.attribute LIKE 'Enseignant' group by attribute; +------------+ | attribute | +------------+ | Enseignant | +------------+ The TOTAL takes into account 'Enseignant' and 'enseignant' values but does not display the 'enseignant' value because of that. I don't know what is the best way to solve this issue. Should we continue to display only one line but display all values in the same line? Or should we display multiple lines for every "case-variant"? Changing status to "In discussion". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:07:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:07:24 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it --- Comment #3 from Zeno Tajoli --- So, you prefer to refine the code ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:22:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:22:52 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #4 from mathieu saby --- (In reply to Zeno Tajoli from comment #3) > So, you prefer to refine the code ? What do you mean by that? I made a mistake, and forgot to join the zebra xsl file. I'm testing and correcting the patch in a few minutes. And I am considering making a date sort on 100 coded field instead of 210$d. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:23:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:23:28 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #8 from Jonathan Druart --- Created attachment 22734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22734&action=edit Bug 11023: Add the ability to specify fields from biblioitems table. Test plan: Same as before but try with fields from the biblioitems table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:23:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:23:56 +0000 Subject: [Koha-bugs] [Bug 11023] Toggle new status for items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023 --- Comment #9 from Jonathan Druart --- Created attachment 22735 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22735&action=edit Bug 11023: Add UT for C4::Items::ToggleNewStatus Test plan: prove t/db_dependent/Items/ToggleNewStatus.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:31:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:31:09 +0000 Subject: [Koha-bugs] [Bug 11203] New: Datatables on parcel.pl do not ignore "stopwords" in titles Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 Bug ID: 11203 Summary: Datatables on parcel.pl do not ignore "stopwords" in titles Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Sorting by the "summary" column does not produce the preferred results. Title beginning with 'a', 'an', or 'the' are sorted using those articles. Test plan: 1) Place an order for 2 items with the titles "Alpha" and "The Alpha", along with some other records with titles starting with something between 'a' and 't', and 't' and 'z' 2) Sort the "pending orders" table, note the incorrect sorting 3) Receive all the items 4) Sort the "already received" table, note the incorrect sorting 5) Apply the patch 6) Repeat steps 1-4, note the corrected sorting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:31:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:31:55 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables on parcel.pl do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:32:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:32:00 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables on parcel.pl do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 --- Comment #1 from Kyle M Hall --- Created attachment 22736 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22736&action=edit Bug 11203 - Datatables on parcel.pl do not ignore "stopwords" in titles Sorting by the "summary" column does not produce the preferred results. Title beginning with 'a', 'an', or 'the' are sorted using those articles. Test plan: 1) Place an order for 2 items with the titles "Alpha" and "The Alpha", along with some other records with titles starting with something between 'a' and 't', and 't' and 'z' 2) Sort the "pending orders" table, note the incorrect sorting 3) Receive all the items 4) Sort the "already received" table, note the incorrect sorting 5) Apply the patch 6) Repeat steps 1-4, note the corrected sorting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:32:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:32:25 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables on parcel.pl do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:34:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:34:41 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #5 from Zeno Tajoli --- Well, in fact it is strange to see 'In discussion' after only two comment with a patch attached. So I guess that you want to refine the patch for same motivation. Only this. We will try to sign it when you have finish. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:35:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:35:12 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #56 from Paola Rossi --- (In reply to Jonathan Druart from comment #55) > (In reply to Paola Rossi from comment #53) > > NB. In my test case, af2 is 245, and the title of the subscribed notice is > > "Bulletin". Testing new fields on adding/updating a subscription, the af2 > > field is not filled with the specified marc field of the notice, i.e. there > > is no "Bulletin" on the left of the sentence "This value will be filled with > > the 245 subfield of the selected biblio.". Afterwards I set af2 to 245a and > > try again, but yet nothing appears. > > Last patch fixes the UT. > > You have to save your subscription for filling the value linked to a marc > field. Thanks, Jonathan. I apply the last patch, and now the test is OK. Now I set the marc field to 245$a, instead of 245. After having saved the subscription, editing the subscription once more, now the value af2 is shown as desired (OK). In serials/subscription-detail.pl?subscriptionid=X, all the fields are displayed (OK). In subscriptions' advanced search page, all searchable additional fields are present on the form (OK). The subscriptions' advanced search works well (OK). All the added fields have the corresponding column in the table (OK). On the contrary, no value is displayed in these new columns of the table [so nor the description neither the code can be seen.] And searching from the bottom of these columns gives wrong results: the result is always zero. Testing the claim page, all the columns are displayed, and now the values too (OK)! On the contrary, searching from the bottom of the columns works bad: nothing is found (not even the library!) in the various columns. Except in the last column (the fourth added field, in my test case): everything is always found whatever I write (KO). So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:39:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:39:05 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #6 from mathieu saby --- (In reply to Zeno Tajoli from comment #5) > Well, in fact it is strange to see 'In discussion' after only two comment > with a patch attached. > So I guess that you want to refine the patch for same motivation. > Only this. > We will try to sign it when you have finish. Oh, ok. So, yes, refining and fixing ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:42:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:42:04 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #7 from mathieu saby --- By the way, could you tell me if 359 field is used in Italy? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:45:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:45:15 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #8 from Zeno Tajoli --- No, tag 359 is not wide used in Italy. Bye -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:47:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:47:34 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #57 from Jonathan Druart --- (In reply to Paola Rossi from comment #56) > On the contrary, searching from the bottom of the columns works bad: nothing > is found (not even the library!) in the various columns. Except in the last > column (the fourth added field, in my test case): everything is always found > whatever I write (KO). Could you confirm the filters work on master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:52:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:52:37 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:53:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:53:13 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22733|0 |1 is obsolete| | --- Comment #9 from mathieu saby --- Created attachment 22737 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22737&action=edit Improve UNIMARC biblio indexing This patch makes the following changes to UNIMARC biblio indexing : A. Changes to UNIMARC conf files 1. add comments to biblio-koha-indexdefs.xml 2. make biblio-koha-indexdefs.xml more compact by grouping some declarations Ex : 200$f and 200$g => one declaration for 200$fg 3. suppress unneeded declarations (indexing of some 4XX fields and 6XX fields not in unimarc format) 4. unindex some (sub)fields unneeded by most users (318, 207,230,210a,215, 4XXd) 5. change the way 308 field is indexed (no visible changes) 6. replace Title-host with Host-item -- see bug 11119 7. index 208 in Material-Type -- see bug 11119 8. index 100 pos 8-9 and 9-12 in pubdate:y and pubdate:n 9. index 100 pos 8-9 in pubdate:s instead of 210$d 10. Index all subfields of note 334 and 327 in note index 11. Index 304 and 327 in title index as well as note index 327 can contain a list of titles included in a work 304 can contain the title of the original work in case of a translation 12. Index 314 in author index as well as note index 314 can contain authors not mentionned in 200$f/g (the 4th, 5th etc author) 13. Index 328 note in Dissertation-information as well as note 14. Index 328$t in Title B. Changes to ccl.properties : 1. add a new index Dissertation-information (1056) 2. fix EAN, pubdate and acqdate (they were not linked with bib1 attributes) C. Changes to Search.pm 1. add Dissertation-information and suppress Title-host and UPC D. Changes to QP config file queryparser.yaml 1. add Dissertation-information 2 fix EAN, pubdate and acqdate Test plan : If you cannot test in GRS1, test only in DOM, as GRS will be deprecated. 1. Apply the patch in a UNIMARC Koha running with DOM and ICU 2. copy src/etc/searchengine/queryparser.yaml into the main config directory of QP 3. copy src/etc/zebradb/ccl.properties into the main config directory of Zebra 4. copy src/etc/zebradb/marc_defs/unimarc/biblio/* into the main config directory of Zebra 5. reindex biblios (rebuild_zebra.pl -r -b -x -v) 6. test note index : make some searches on 334$b or 327$b 7. test author index : make some searches on 314 field 8. test title index : make some searches on 304 and 327 field, make a search on 328$t subfield 9. test Dissertation-information index : make some searches on 328 field 10. In a record, put in the dates of 100 fields the values "1000" (1st date) and "1001" (2d date) ; try to search a book written in year 1000, you should find the record ; idem for year 1001 11. make some searches and sort by date. It should work better as before, especially if you have values like "c2009" or "impr. 2010" in 210 field 12. Regression test : make some searches on several indexes, like EAN, etc. It should work as before Test 10-12 with and without Queryparser activated. Of course, to test search and sort by dates, you need to have full records, with dates in 100 field as well as 210 field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:54:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:54:00 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #10 from mathieu saby --- I forgot to copy the number of the bug in the last attachment ;-) But it can be tested. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:54:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:54:06 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:58:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:58:07 +0000 Subject: [Koha-bugs] [Bug 11204] New: pendingreserves should use datatables.inc Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11204 Bug ID: 11204 Summary: pendingreserves should use datatables.inc Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org A JS error occurs on the pending reserves pages: ReferenceError: CONFIG_EXCLUDE_ARTICLES_FROM_SORT is not defined if(CONFIG_EXCLUDE_ARTICLES_FROM_SORT){ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:59:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:59:27 +0000 Subject: [Koha-bugs] [Bug 11204] pendingreserves should use datatables.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11204 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:59:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 16:59:30 +0000 Subject: [Koha-bugs] [Bug 11204] pendingreserves should use datatables.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11204 --- Comment #1 from Jonathan Druart --- Created attachment 22738 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22738&action=edit Bug 11204: pendingreserves should use datatables.inc A JS error occurs on the pending reserves pages: ReferenceError: CONFIG_EXCLUDE_ARTICLES_FROM_SORT is not defined if(CONFIG_EXCLUDE_ARTICLES_FROM_SORT){ Test plan: Apply the patch and verify the error does not appear anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:07:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 17:07:39 +0000 Subject: [Koha-bugs] [Bug 11205] New: The datatables filtering does not work when several tables exist Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Bug ID: 11205 Summary: The datatables filtering does not work when several tables exist Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org If there are more than 1 table on the same page, the datatable filters don't work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:08:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 17:08:24 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m Summary|The datatables filtering |The datatables filters |does not work when several |don't work when several |tables exist |tables exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:09:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 17:09:51 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:09:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 17:09:55 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 --- Comment #1 from Jonathan Druart --- Created attachment 22739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22739&action=edit Bug 11205: The datatables filtering does not work when several tables exist If there are more than 1 table on the same page, the datatable filters don't work. Test plan: 1/ Go on serials/serials-search.pl?searched=1 2/ filter on a column for opened subscriptions => the closed subscriptions should not be filtered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:11:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 17:11:12 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #58 from Jonathan Druart --- Paola, I find a bug on datatables filters (bug 11205). It is not introduced by these patches but maybe it will fix your issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:14:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 17:14:27 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:31:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 17:31:39 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:31:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 17:31:48 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 --- Comment #1 from Tom?s Cohen Arazi --- Created attachment 22740 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22740&action=edit Bug 9114: import/export routines should use UTF-8 Currently both the import_export_framework.pl script and the associated libs output data with Perl's default encoding, ISO-8859. This patch properly sets the binmode to UTF-8 for the CGI script, and makes the C4::ImportExportFramework routines apply the ":encoding(UTF-8)" layer to file descriptors. To test: Export step test - Use some non-ASCII character(s) in some field description in a chosen framework. - Export the framework at Administration > MARC frameworks - Run this to check the file is ISO-8859 encoded: $ file export_XXX.csv export_XXX.csv: ISO-8859 text, with very long lines (Note: try SQL and other output formats too. But not ODS) - Apply the patch - Export the framework again (change the name), and test encoding: $ file export_XXX_2.csv export_XXX_2.csv: UTF-8 Unicode text Import step test I assume you have two files, export_XXX.csv (ISO-8859 encoded) and export_XXX_2.csv (XXX will depend on your framework's code) - Reset your testing branch to master - Import export_XXX.csv - The string with non-ASCII chars is truncated at the first non-ASCII char's position (Note: this is the current behaviour). - Import export_XXX_2.csv - The non-ASCII chars are broken, the logs show errors on non-UNICODE chars. (Note: even thou UTF-8 is the expected encoding it is treated as ISO-8859). - Apply the patch - Import the good (UTF-8 as expected) file and check everything worked as expected. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:33:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 17:33:14 +0000 Subject: [Koha-bugs] [Bug 9114] exported MARC frameworks encoding should be UTF-8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9114 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Assignee|gmcharlt at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:39:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 17:39:32 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #17 from Paul Poulain --- isn't that a bug in the dataset ? Seems silly to me to have "enseignant" and "Enseignant" being 2 different values... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:46:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 17:46:39 +0000 Subject: [Koha-bugs] [Bug 11119] Silent zebra in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119 --- Comment #10 from Paul Poulain --- (In reply to mathieu saby from comment #9) > Hello Paul > I believe you regenerated DOM files from record.abs. This is maybe not a > good idea, as the different files have now to live their own lives... > I am writing a patch with a lot of little changes, I will include inside it > the changes discussed here ;-) > > Mathieu Shouldn't we close this one and mark it as a duplicate of your patch then ? ( I'm fine with it ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:08:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 18:08:22 +0000 Subject: [Koha-bugs] [Bug 11119] Silent zebra in UNIMARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11119 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |DUPLICATE --- Comment #11 from mathieu saby --- yes ;-) *** This bug has been marked as a duplicate of bug 11202 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:08:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 18:08:22 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #11 from mathieu saby --- *** Bug 11119 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:09:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 18:09:08 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #12 from mathieu saby --- *** Bug 11026 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:09:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 18:09:08 +0000 Subject: [Koha-bugs] [Bug 11026] in UNIMARC, pubdate index should be based on 100 field and not 210 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11026 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from mathieu saby --- *** This bug has been marked as a duplicate of bug 11202 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:44:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 18:44:07 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #140 from mathieu saby --- I forgot to set status in Failed QA after my last test. Tax management and handling of unitprice must be fixed before this patch can be signed off. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:58:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 18:58:33 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #13 from Zeno Tajoli --- Hi, how could I test Dissertation-information index ? It is not clear for me which option of 'Advanced Search' I need to use to search on Dissertation-information index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 21:01:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 20:01:28 +0000 Subject: [Koha-bugs] [Bug 9299] for loop in Auth_with_ldap.pm requires an extended patron attribute to be set or LDAP logins fail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9299 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.12 --- Comment #11 from Robin Sheat --- (In reply to Katrin Fischer from comment #10) > I think we have run into this problem in 3.12 - maybe a candidate for a > backport? Not sure if there are dependencies on other features in master. It is a problem on 3.12, I'll change the version setting to indicate that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 21:09:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 20:09:22 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 --- Comment #14 from mathieu saby --- Not in advanced search, but in normal search, try "Dissertation-information:xxxxx" Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 21:25:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 20:25:24 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 mshafer at ckls.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mshafer at ckls.org --- Comment #57 from mshafer at ckls.org --- I would like to send my encouragement on behalf of my 43 libraries. We would love to be able to have multiples holds on items on a single biblio! It would make book club ordering so much simpler! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 21:27:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 20:27:28 +0000 Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045 mshafer at ckls.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mshafer at ckls.org --- Comment #52 from mshafer at ckls.org --- With 43 libraries that have 43 different circ rules and holds limits, I am encouraging the further development of this issue. Some libraries need to limit the holds their patrons can place more than other libraries. M Shafer Central Kansas Library System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 21:29:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 20:29:25 +0000 Subject: [Koha-bugs] [Bug 10252] File Print of Checkout History Truncates Results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10252 mshafer at ckls.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mshafer at ckls.org --- Comment #1 from mshafer at ckls.org --- We used to be able to print directly from the checkout screen and get the full list of items checked out (in Firefox-->File-->Print). But now, when we got this way, it only prints the first 8 or so checkouts. We can use Print Summary which will give us the full list, but it does have the same info as on the checkout screen (Date checked out on--Library Checked out From). http://www.screencast.com/t/hWlTDW2V Is there a way to get back the File-->Print option we had before? Is this a Firefox change? Or is there a way to get all the info from the check out page on the Print Summary? M Shafer Central Kansas Library System -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 21:43:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 20:43:06 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22710|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 22741 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22741&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 23:15:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2013 22:15:33 +0000 Subject: [Koha-bugs] [Bug 8123] cronjob to pre-populate/Update patrons from ldap data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8123 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 06:01:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 05:01:31 +0000 Subject: [Koha-bugs] [Bug 9055] Mandumah.com's multiple branch search, multiple branch security mod In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9055 Waylon Robertson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21991|0 |1 is obsolete| | Attachment #21992|0 |1 is obsolete| | --- Comment #14 from Waylon Robertson --- Created attachment 22742 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22742&action=edit Bug 9055 full patch to Nov 1st 2013 master Patch to resolve M. Thompsett's comments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 06:45:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 05:45:17 +0000 Subject: [Koha-bugs] [Bug 11204] pendingreserves should use datatables.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11204 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 06:45:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 05:45:19 +0000 Subject: [Koha-bugs] [Bug 11204] pendingreserves should use datatables.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11204 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22738|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher --- Created attachment 22743 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22743&action=edit Bug 11204: pendingreserves should use datatables.inc A JS error occurs on the pending reserves pages: ReferenceError: CONFIG_EXCLUDE_ARTICLES_FROM_SORT is not defined if(CONFIG_EXCLUDE_ARTICLES_FROM_SORT){ Test plan: Apply the patch and verify the error does not appear anymore. Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 07:44:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 06:44:31 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 07:44:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 06:44:34 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Brendan Gallagher changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22739|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher --- Created attachment 22744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22744&action=edit [SIGNED-OFF] Bug 11205: The datatables filtering does not work when several tables exist If there are more than 1 table on the same page, the datatable filters don't work. Test plan: 1/ Go on serials/serials-search.pl?searched=1 2/ filter on a column for opened subscriptions => the closed subscriptions should not be filtered. Works! Signed-off-by: Brendan Gallagher -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 08:51:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 07:51:14 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #18 from Julian Maurice --- Created attachment 22745 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22745&action=edit Bug 7679: Group different case values in the same row/column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 08:53:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 07:53:29 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #19 from Julian Maurice --- This is a proposal patch for the first mentioned option : display only one line with all "case-variant" values in it. The 2nd option seems to require more work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 09:33:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 08:33:28 +0000 Subject: [Koha-bugs] [Bug 10857] Add facets cancellation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10857 --- Comment #34 from Jonathan Druart --- Created attachment 22746 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22746&action=edit Bug 10857: Encode 'limit' parameter values to allow facets with '&' character. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 09:47:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 08:47:33 +0000 Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl --- Comment #12 from Jacek Ablewicz --- I think you only need those two lines in etc/words-icu.xml: as all other Polish diacritics should behave correctly out of the box. Polish "l striked" is indeed somehow special (while it shouldn't - general consensus is that "?" is NOT a very different letter than "l" etc.). Problem is: long time ago, some person from Unicode Consortium involved in UCA (Unicode Collation Algorithm) development made rather questionable decision to not treat "?, ?" as wariants of "l, L". It became a major PITA from than on - for example, it does also affect mysql utf8_general_ci & utf8_unicode_ci collations, to name just a few side effects. BTW, I believe this got finally corrected in subsequent UCA revisions (in v5.2.0+, AFAIRC), so this workaround may be no longer necessary in Koha installations with more recent libicu versions (?). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:28:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 09:28:28 +0000 Subject: [Koha-bugs] [Bug 11206] New: Factorize code for getting orders in C4::Acquisitions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206 Bug ID: 11206 Summary: Factorize code for getting orders in C4::Acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org A lot of subs are used in C4::Acquisitions for doing basically the same thing : searching orders. Code can be factorized, to improve maintainability, build stronger unit tests, and make further improvements easier (like using DBIx::Class, or Bug 10758 ( Show bibliographic information of deleted records in acquisitions). First draft patch attached here. Fully testable, but can maybe be improved, and UT are not written yet. To test : make a full acquisition workflow, search orders, display uncertain prices, export baskets, basketgroups and late orders in CSV or PDF when possible. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:28:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 09:28:39 +0000 Subject: [Koha-bugs] [Bug 11206] Factorize code for getting orders in C4::Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mathieu.saby at univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:32:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 09:32:20 +0000 Subject: [Koha-bugs] [Bug 11206] Factorize code for getting orders in C4::Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206 --- Comment #1 from mathieu saby --- Created attachment 22747 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22747&action=edit [PATCH] Bug 11206 - Factorize code for getting orders in C4::Acquisitions This patch adds a new sub C4::Acquisition::_get_orders_with_params This sub is now called by - GetOrder - GetOrders - GetCancelledOrders - GetOrdersByBiblionumber - GetOrderFromItemnumber - SearchOrder It also makes changes to acqui/lateorders-export.pl, .../prog/en/modules/acqui/csv/lateorders.tt and .../prog/en/modules/acqui/lateorders.tt to take into account some variable renaming Next step : use it in GetLateOrders -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:32:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 09:32:28 +0000 Subject: [Koha-bugs] [Bug 11206] Factorize code for getting orders in C4::Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:33:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 09:33:56 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #30 from mathieu saby --- I think factorizing code would make things much easier. Katrin and Jonathan, could you take a look at Bug 11206 please? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:38:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 09:38:20 +0000 Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939 --- Comment #13 from mathieu saby --- (In reply to Jacek Ablewicz from comment #12) > I think you only need those two lines in etc/words-icu.xml: > > We are currently trying to improve this file in our library, and we use this solution (with other tricks) M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:40:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 09:40:25 +0000 Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939 --- Comment #14 from mathieu saby --- Fridolyn, we can have Polish records in a french or american catalog. So, why not improving the default etc/words-icu.xml for everybody? (same remarks for german umlauts, french ligatures etc) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:10:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 10:10:46 +0000 Subject: [Koha-bugs] [Bug 11206] Factorize code for getting orders in C4::Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Mathieu, Not sure it is a good idea to factorize like that. Now, some routines did 1, 2 or 3 join, with your patch, they will always do 8 join. That will increase the load in acquisition pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:26:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 10:26:16 +0000 Subject: [Koha-bugs] [Bug 11206] Factorize code for getting orders in C4::Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206 --- Comment #3 from mathieu saby --- (In reply to Jonathan Druart from comment #2) > Mathieu, > Not sure it is a good idea to factorize like that. > Now, some routines did 1, 2 or 3 join, with your patch, they will always do > 8 join. > That will increase the load in acquisition pages. In fact, what first disturbed me was that the same fields were not named in the same way in GetOrder and GetCancelledOrders and GetOrders (publishercode, rrp...). And working on that, I tried to factorize all the code. But you are right, in terms of performance it is not a good solution. Maybe the 2 subs which could be safely factorized are GetCancelledOrders and GetOrders, as they differ only by the exclusion of an order status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:33:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 11:33:47 +0000 Subject: [Koha-bugs] [Bug 11207] New: Impossibility to remove a sms number Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Bug ID: 11207 Summary: Impossibility to remove a sms number Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To reproduce: 1/ edit a patron 2/ set a sms alert number 3/ save 4/ edit the patron 5/ try to remove the sms alert number -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:33:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 11:33:57 +0000 Subject: [Koha-bugs] [Bug 11207] Impossibility to remove a sms number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:35:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 11:35:09 +0000 Subject: [Koha-bugs] [Bug 11207] Impossibility to remove a sms number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:35:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 11:35:13 +0000 Subject: [Koha-bugs] [Bug 11207] Impossibility to remove a sms number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 --- Comment #1 from Jonathan Druart --- Created attachment 22748 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22748&action=edit Bug 11207: No way to remove a sms alert number Test plan: 1/ edit a patron 2/ set a sms alert number 3/ save 4/ edit the patron 5/ set the sms alert number to a blank value 6/ save 7/ the sms number is now an empty string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:37:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 11:37:58 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 --- Comment #28 from Julian Maurice --- Created attachment 22749 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22749&action=edit Bug 8064: Change the way target record is built. Instead of copying/removing a piece of DOM in target record each time a checkbox is checked/unchecked, the target record is *entirely* rebuilt each time a checkbox is checked/unchecked. This is slower but allow for a more consistent and less error-prone behaviour. This patch also fix the mandatory check for subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:38:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 11:38:27 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:38:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 11:38:45 +0000 Subject: [Koha-bugs] [Bug 11207] Impossibility to remove a sms number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11207 --- Comment #2 from Jonathan Druart --- Note: I don't understand the other test $input->param('SMSnumber') ne $newdata{'mobile'} -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:44:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 11:44:19 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #59 from Paola Rossi --- (In reply to Jonathan Druart from comment #58) > Paola, I find a bug on datatables filters (bug 11205). It is not introduced > by these patches but maybe it will fix your issue. Thanks, Jonathan. Applying of 11205 is OK. In subscriptions' advanced search, yes, bug 11205 fixes the problem. Now the filters at the bottom of columns such as "ISSN", "Title", "Library", "Expiration date", work well. Staying that no value is displayed in the new columns of the table [so nor the description neither the code can be seen], nothing is found when I use the filters at the bottom of these columns. In Claims, no, bug 11205 doesn't fix the problem. The use of filters at the bottom of columns such as "Vendor", "Library", "Title", "Issue number", "Status", "af1", always results in a "No matching records found" answer. When I use the filter "From" and "To", the selection is nearby OK (range [x,y] selects "Since"' days between [x+1,y-1]). At the bottom of the table, whereas the "Select CSV profile" is only one ("issues to claim"), selecting "Download selected claims" always results in the error: "Please select at least one item to export". But no checkbox is displayed in the whole page in my test case. about comment 57: The master 042 has not filters in CLAIMS' table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:31:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 13:31:50 +0000 Subject: [Koha-bugs] [Bug 7255] Information on Holds Transfer Slips is Inconsistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255 Rafal changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkk0 at poczta.onet.pl --- Comment #10 from Rafal --- (In reply to Heather Braum from comment #9) > There was discussion on this bug more than a year ago--is it going to move > anywhere? What will it take for that to happen? I see Chris' comment that > there's a deeper issue going on. Just curious -- this issue is affecting our > libraries, too. In our library we are using solution that I've provided in patch for Bug 10770. So before printing in hold-transfer-slip.pl we call ModReserveAffect. Maybe it's not to good to call 2 times (in returns and hold-print-slip) this function for 1 reserve? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:00:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:00:11 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22737|0 |1 is obsolete| | --- Comment #15 from mathieu saby --- Created attachment 22750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22750&action=edit Improve UNIMARC biblio indexing New patch, 1 ligne changed (I had forgotten to replace a Title-host in record.abs). M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:15:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:15:35 +0000 Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939 --- Comment #15 from Fridolyn SOMERS --- (In reply to mathieu saby from comment #14) > So, why not improving the default etc/words-icu.xml for everybody? See comment 8. It may be rediscussed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:22:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:22:45 +0000 Subject: [Koha-bugs] [Bug 11208] New: Multi transport types: a sms message without sms number should be marked as failed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208 Bug ID: 11208 Summary: Multi transport types: a sms message without sms number should be marked as failed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:23:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:23:14 +0000 Subject: [Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:23:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:23:17 +0000 Subject: [Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208 --- Comment #1 from Jonathan Druart --- Created attachment 22751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22751&action=edit Bug 11208: If no smsalertnumber is defined, the message is marked as failed For DUE message (and PREDUE, etc.) there are no check before sending the message to the message_queue table. This check avoids to try to send again and again the same message. Now it is marked as "failed". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:23:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:23:27 +0000 Subject: [Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:23:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:23:32 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11208 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:23:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:23:32 +0000 Subject: [Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9016 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:24:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:24:34 +0000 Subject: [Koha-bugs] [Bug 11209] New: Multi transport types: same messages are sent for a patron Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Bug ID: 11209 Summary: Multi transport types: same messages are sent for a patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:27:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:27:00 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:27:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:27:04 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 --- Comment #1 from Jonathan Druart --- Created attachment 22752 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22752&action=edit Bug 11209: Don't sent the same message for the same user the same day For PREDUE messages, one message is sent to the message_queue table for each items in advanced. So the patron will receive the same message. The sms part for DUE and PREDUE should not contain dynamic parts, only a standard message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:27:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:27:18 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11208 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:27:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:27:18 +0000 Subject: [Koha-bugs] [Bug 11208] Multi transport types: a sms message without sms number should be marked as failed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11208 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11209 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:33:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:33:58 +0000 Subject: [Koha-bugs] [Bug 9531] Make SIP2 message terminator configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9531 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #14 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:34:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:34:36 +0000 Subject: [Koha-bugs] [Bug 10331] Little errors in unimarc_field_4XX.pl (punctuation) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10331 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Janusz! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:35:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:35:11 +0000 Subject: [Koha-bugs] [Bug 10564] use OPACURLOpenInNewWindow in UNIMARCslim2OPACResults.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10564 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:35:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 14:35:54 +0000 Subject: [Koha-bugs] [Bug 10817] SIPserver does not return holds info when requested In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10817 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #8 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:05:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 15:05:23 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13141|0 |1 is obsolete| | --- Comment #3 from Julian Maurice --- Created attachment 22753 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22753&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACHideOpenURLForItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are not in OPACHideOpenURLForItemTypes) 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" 9/ Repeat steps 5 to 7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:05:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 15:05:38 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:31:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 15:31:47 +0000 Subject: [Koha-bugs] [Bug 11204] pendingreserves should use datatables.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11204 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:31:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 15:31:50 +0000 Subject: [Koha-bugs] [Bug 11204] pendingreserves should use datatables.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11204 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22743|0 |1 is obsolete| | --- Comment #3 from M. de Rooy --- Created attachment 22754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22754&action=edit Bug 11204: pendingreserves should use datatables.inc A JS error occurs on the pending reserves pages: ReferenceError: CONFIG_EXCLUDE_ARTICLES_FROM_SORT is not defined if(CONFIG_EXCLUDE_ARTICLES_FROM_SORT){ Test plan: Apply the patch and verify the error does not appear anymore. Signed-off-by: Brendan Gallagher Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:32:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 15:32:10 +0000 Subject: [Koha-bugs] [Bug 11204] pendingreserves should use datatables.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11204 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:34:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 15:34:15 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:36:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 15:36:01 +0000 Subject: [Koha-bugs] [Bug 11204] pendingreserves should use datatables.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11204 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master and 3.14.x. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:44:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 15:44:38 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from M. de Rooy --- If I click on one of the titles in the table where expiration date is blank, the following error occurs: Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /usr/share/koha/testclone/C4/Serials.pm line 2380 Could you confirm? If so, we should open a new report for that one.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:51:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 15:51:41 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:51:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 15:51:45 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20057|0 |1 is obsolete| | Attachment #20733|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart --- Created attachment 22755 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22755&action=edit Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:51:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 15:51:53 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #21 from Jonathan Druart --- Created attachment 22756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22756&action=edit Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:56:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 15:56:15 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from M. de Rooy --- I have a hard time to reproduce the error :) Somehow the filter on Open and Closed seems to work (also after refreshing) with and without this patch. Could you please clarify what you exactly mean with "more than 1 table on the page"? Or provide some more detailed steps to reproduce the problem encountered? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:59:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 15:59:53 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 --- Comment #5 from Jonathan Druart --- Marcel, the only page with 2 tables is serials/serials-search.pl?searched=1 There are 2 tabs: opened and closed subscriptions. On each tabs there is a table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:00:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 16:00:42 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 --- Comment #6 from Jonathan Druart --- (In reply to M. de Rooy from comment #3) > If I click on one of the titles in the table where expiration date is blank, > the following error occurs: > > Date::Calc::PP::Delta_Days(): Usage: > Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at > /usr/share/koha/testclone/C4/Serials.pm line 2380 > > Could you confirm? If so, we should open a new report for that one.. I think it is not introduced by this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:26:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 16:26:10 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:30:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 16:30:58 +0000 Subject: [Koha-bugs] [Bug 10792] Amounts in funds table on acquisitions home page not sorting correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10792 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- Galen, this doesn't apply cleanly on 3.12.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:44:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 16:44:27 +0000 Subject: [Koha-bugs] [Bug 10718] items with no checkouts report does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10718 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Fridolyn! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:45:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 16:45:13 +0000 Subject: [Koha-bugs] [Bug 10810] Fix synopsis for -html option to overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10810 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 19:50:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 18:50:40 +0000 Subject: [Koha-bugs] [Bug 6681] When importing a biblio record via Z39.50, authority links also get imported In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 --- Comment #11 from Fr?d?rick Capovilla --- Having never worked with unimarc or normarc records and Z39.50 servers, we are not equipped to easily adapt our patch for it to work with these formats. Could anyone improve this patch so it becomes flexible enough for inclusion on master? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 22:04:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 21:04:14 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 22:04:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 21:04:17 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #1 from Kyle M Hall --- Created attachment 22757 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22757&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 22:04:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 21:04:41 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com Patch complexity|--- |Medium patch Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 22:09:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 21:09:49 +0000 Subject: [Koha-bugs] [Bug 7205] can't reverse manual credits In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7205 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 22:26:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 21:26:16 +0000 Subject: [Koha-bugs] [Bug 11210] New: Allow partial writeoff Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11210 Bug ID: 11210 Summary: Allow partial writeoff Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com it would be nice to make partial writeoff like a partial fine payment. Example: a fine of 3$ is charged because item was late of 3 days. But finaly on the three days, library was closed one day. I want to just writeoff 1$. Thanks, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 23:19:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 22:19:27 +0000 Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939 Julien Sicot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julien.sicot at gmail.com --- Comment #16 from Julien Sicot --- For information, ICU provide already a package for processing similar transliteration. With just one line in etc/words-icu.xml (and etc/phrases-icu.xml) : you can convert latin unicode to ascii. Normally, this works for all polish diacriticals. You can test icu rules here : http://demo.icu-project.org/icu-bin/translit or using yaz-icu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 00:14:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 23:14:14 +0000 Subject: [Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133 Jesse Weaver changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11211 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 00:14:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 23:14:14 +0000 Subject: [Koha-bugs] [Bug 11211] New: Move calculation code out of C4::Calendar Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Bug ID: 11211 Summary: Move calculation code out of C4::Calendar Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: jweaver at bywatersolutions.com Reporter: jweaver at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Blocks: 8133 Koha::Calendar should contain all of the calendar calculation code, and C4::Calendar should only have admin subs. Created to slim down bug 8133. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 00:24:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2013 23:24:12 +0000 Subject: [Koha-bugs] [Bug 11212] New: Using non english characters in patron category description causes double encoding Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11212 Bug ID: 11212 Summary: Using non english characters in patron category description causes double encoding Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: beyribey at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Using non english characters in patron category description causes double encoding as a result letters like ? looks like ?? etc. Steps to reproduce: 1. Create a new patron category. (cgi-bin/koha/admin/categorie.pl?op=add_form) 2. Use XYZ (or whatever) as category code. 3. Use non english characters in category description. (e.g ??????) 4. From system preferences, add ? ? ? ? ? ? to the alphabet. (A B C ? D E F G H I ? J K L M N O ? P Q R S ? T U ? V W X Y Z) 5. Visit patrons page. (cgi-bin/koha/members/members-home.pl) I could reproduce that on 3.12.06 (debian wheezy, packages from repository) and 3.12.05 I'm not sure if this is related to bug #6554 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 08:32:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 07:32:36 +0000 Subject: [Koha-bugs] [Bug 11213] New: GetItemsInfo() called twice Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Bug ID: 11213 Summary: GetItemsInfo() called twice Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: srdjan at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org Details pages opac/opac-detail.pl and catalogue/detail.pl call GetItemsInfo() on their own after it being called from XSLTParse4Display() (if OPACXSLTDetailsDisplay syspref and/or XSLTDetailsDisplay are set). That imposes severe performance penalty for biblio records with large number of items. The right way would be to pass the list to XSLTParse4Display(), however that interface is very complex as is. An alternative is to return the list from XSLTParse4Display(), which is not elegant at all. If no one cries foul in the next 24 hours, I'll proceed with changing the interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 08:32:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 07:32:56 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:00:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 08:00:45 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #7 from M. de Rooy --- It would have been helpful to be somewhat more descriptive than just say "filters don't work". This could save some time in understanding what exactly the problem is. Your problem apparently was: If I filter on for instance a title word on the first tab (Opened), this filter should not be applied to the second tab (Closed). Your patch does resolve this situation. Thanks for that. No complaints from qa tools too. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:02:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 08:02:01 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 --- Comment #8 from M. de Rooy --- Created attachment 22758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22758&action=edit Bug 11205: The datatables filtering does not work when several tables exist If there are more than 1 table on the same page, the datatable filters don't work. Test plan: 1/ Go on serials/serials-search.pl?searched=1 2/ filter on a column for opened subscriptions => the closed subscriptions should not be filtered. Works! Signed-off-by: Brendan Gallagher Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:02:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 08:02:56 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22744|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:03:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 08:03:05 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:09:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 08:09:54 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|gmcharlt at gmail.com |marc at msys.ch Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:14:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 08:14:44 +0000 Subject: [Koha-bugs] [Bug 11131] Authority search does not display summary while searching by all auth types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-11-07 last check this| | --- Comment #2 from I'm just a bot --- testing 1 commit(s) (applied to 5fa6168 'Bug 11204: make pendingreserves use d') OK C4/AuthoritiesMarc.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:17:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 08:17:19 +0000 Subject: [Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot at bugs.koha-community. | |org When did the bot| |2013-11-07 last check this| | --- Comment #2 from I'm just a bot --- testing 1 commit(s) (applied to 5fa6168 'Bug 11204: make pendingreserves use d') OK opac/opac-topissues.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:19:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 08:19:10 +0000 Subject: [Koha-bugs] [Bug 11131] Authority search does not display summary while searching by all auth types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11131 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz When did the bot|2013-11-07 00:00:00 | last check this| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:22:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 08:22:43 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 I'm just a bot changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-29 00:00:00 |2013-11-07 last check this| | --- Comment #10 from I'm just a bot --- Patch applied cleanly testing 2 commit(s) (applied to 5fa6168 'Bug 11204: make pendingreserves use d') OK acqui/invoice.pl OK koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:23:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 08:23:26 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from M. de Rooy --- I see the following change: - AND reserves.reservedate <= DATE_ADD(NOW(),INTERVAL ? DAY) + AND reserves.reservedate <= CAST(now() AS date) Fixing a so detested mysqlism should at least preserve functionality. These changes seem to be made in a hurry, since we are changing functionality here. Here you change a date_add with just a now. The parameter for adding a number of days is just ignored. This change was a red traffic light for me :) I did not look any further.. Please correct and add a (more detailed) test plan for this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:23:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 08:23:32 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:01:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:01:44 +0000 Subject: [Koha-bugs] [Bug 11148] 2 routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:01:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:01:47 +0000 Subject: [Koha-bugs] [Bug 11148] 2 routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22470|0 |1 is obsolete| | --- Comment #2 from M. de Rooy --- Created attachment 22759 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22759&action=edit Bug 11148: Two routines are useless in Koha::DateUtils There are 2 useless routines in the Koha::DateUtils module:output_pref_due and format_sqlduedatetime. We can call output_pref and format_datetime with dateonly = 0. format_sqlduedatetime is only used in one place: opac-reserve.pl Test plan: 1/ Verify on the opac-reserve.pl page that the date is correctly displayed for for onloan items (you should use the "specific copy" feature). 2/ Launch prove t/DateUtils.t UT file and verify all UT pass. Signed-off-by: Marcel de Rooy Due date on opac-reserve shown correctly. Unit tests pass. Did a grep on both function names. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:02:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:02:29 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Summary|2 routines are useless in |Two routines are useless in |Koha::DateUtils |Koha::DateUtils -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:08:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:08:14 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #23 from Jonathan Druart --- (In reply to M. de Rooy from comment #22) > I see the following change: > > - AND reserves.reservedate <= DATE_ADD(NOW(),INTERVAL ? DAY) > + AND reserves.reservedate <= CAST(now() AS date) > > Fixing a so detested mysqlism should at least preserve functionality. These > changes seem to be made in a hurry, since we are changing functionality here. No, not the changes, but the rebase yes. Only the last patch introduces this bad conflict merge. I consider after 3 rebase and 1 year, the rebase is not safe at all, there is here a good example... > Here you change a date_add with just a now. The parameter for adding a > number of days is just ignored. This change was a red traffic light for me > :) I did not look any further.. > > Please correct and add a (more detailed) test plan for this patch. There is no valid test plan. Check that the CUR_DATE(), CURRENT_DATE() mysql functions return the same as CAST(NOW() AS DATE) in your mysql cli. Your can verify, looking at the diff code, the patch is correct. If you want to test, you can play with reserves and holds queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:09:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:09:33 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:09:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:09:37 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22755|0 |1 is obsolete| | Attachment #22756|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart --- Created attachment 22760 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22760&action=edit Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:09:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:09:43 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 --- Comment #25 from Jonathan Druart --- Created attachment 22761 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22761&action=edit Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:22:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:22:15 +0000 Subject: [Koha-bugs] [Bug 11214] New: Allow create routing list in serial collection page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11214 Bug ID: 11214 Summary: Allow create routing list in serial collection page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When a subscription has no routing list yet, the page serials/subscription-detail.pl shows in left menu : "Create routing list". In serials/serials-collection.pl page, the link in table is always "Edit routing list", even when there is no routing list. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:24:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:24:36 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22752|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 22762 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22762&action=edit Bug 11209: Don't sent the same message for the same user the same day For PREDUE messages, one message is sent to the message_queue table for each items in advanced. So the patron will receive the same message. The sms part for DUE and PREDUE should not contain dynamic parts, only a standard message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:27:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:27:18 +0000 Subject: [Koha-bugs] [Bug 11214] Allow create routing list in serial collection page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11214 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |fridolyn.somers at biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 22763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22763&action=edit Bug 11214 - Allow create routing list in serial collection page See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:27:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:27:25 +0000 Subject: [Koha-bugs] [Bug 11214] Allow create routing list in serial collection page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11214 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:31:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:31:26 +0000 Subject: [Koha-bugs] [Bug 11215] New: Unresponsive script warning when booksellers.pl is loading a list of all vendors Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11215 Bug ID: 11215 Summary: Unresponsive script warning when booksellers.pl is loading a list of all vendors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Go to Acquisitions. Do not enter a vendor name, but just click Search. With a test db containing 400 vendors, I have an unresponsive script warning in Firefox: A script on this page may be busy, or it may have stopped responding. You can stop the script now, or you can continue to see if the script will complete. After clicking Continue twice, the script does complete. Should it take so much time to load a list of 400 vendors? Can we do this in a smarter way? :) As a comparison: I did the same in a 3.8.3 database with 500 vendors. It does not give the warnings and comes back much faster.. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:32:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:32:18 +0000 Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11215 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:32:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:32:18 +0000 Subject: [Koha-bugs] [Bug 11215] Unresponsive script warning when booksellers.pl is loading a list of all vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11215 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7791 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:32:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:32:57 +0000 Subject: [Koha-bugs] [Bug 10978] redirect to basket list of a supplier after deleting a baset In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10978 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7791 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:32:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:32:57 +0000 Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10978 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:33:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:33:33 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 --- Comment #9 from Jonathan Druart --- (In reply to M. de Rooy from comment #7) > It would have been helpful to be somewhat more descriptive than just say > "filters don't work". This could save some time in understanding what > exactly the problem is. Your problem apparently was: If I filter on for > instance a title word on the first tab (Opened), this filter should not be > applied to the second tab (Closed). > Your patch does resolve this situation. Thanks for that. Sorry Marcel, I thought step 2 of the test plan explained that clearly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:40:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 09:40:37 +0000 Subject: [Koha-bugs] [Bug 10939] ICU does not transliterate polish special characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10939 --- Comment #17 from Jacek Ablewicz --- Ouch, looks like problems with "?, ?' are not related to UCA < v5.2 quirks like I thought previously; not at all. Real problem here being that: NFD; [:Nonspacing Mark:] Remove; NFC apparently does not work for 'striked through' latin characters (same problem with: ?, ?, ?, ? etc., not just with ?, ?). I guess that's because NFD is not decomposing '?' to 'l + /' like it does for accented characters and so on. For ICU indexing to behave (more or less) like CHR (zebradb/etc/word-phrase-utf.chr) did, we can: 1) add something like that: to words-icu.xml, or: 2) as Julien suggested, we may use built-in Latin-ASCII ICU transliterator, i.e. add: Solution 2) looks much better IMO (it's more general-purpose) but it may not be ideal for everybody, as Latin-ASCII transliterator is not implemented in pre-4.6 ICU versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 11:28:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 10:28:53 +0000 Subject: [Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130 Mirko Tietgen changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |mirko at abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 11:28:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 10:28:57 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #141 from Jonathan Druart --- (In reply to mathieu saby from comment #122) > Thank you for corecting the discount > > > with the following: > > - syspref: price: 947$c > > - a biblio with 947$c=100 > > - a supplier with "list price include tax = 0", I got a rrp (include tax) = > > 94.79 (gst is 5.5%). > > - a supplier with "list price include tax = 1", I got a rrp (include tax) = > > 100 > > > > It is what is expected. See the test plan, step 6. > > I continue to find that strange. > For me, if the vendor price in 947c is 100 EUR and this price "does NOT > include tax", it means the book price is 100 EUR without tax, so 105.5 with > tax. > I cannot understand it in an other way... The value in 947$c *includes* the tax. The rrp and ecost values are calculated depending on the supplier configuration. I rewrite the algorithm: So, the imported file always contains: price = include tax with the discount discount = the discount ecost : unit price with discount RRP : unit price If the supplier includes tax: ecost = unit price with discount, tax include RRP = unit price, tax include If a discount exists in the file: ecost = price RRP = ecost/(1-discount) If no discount in the file: RRP = price ecost = price*(1-discount [from supplier]) If the supplier does not include tax: ecost = unit price with discount, tax exclude RRP = unit price, tax exclude If a discount exists in the file: ecost = price/(1+tax) RRP = ecost/1-discount If no discount in the file: RRP = price/(1+tax) ecost = RRP(1-discount [from supplier]) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:03:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 11:03:51 +0000 Subject: [Koha-bugs] [Bug 11215] Unresponsive script warning when booksellers.pl is loading a list of all vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11215 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- I think it is 'normal'. In 3.8 there is only 1 big table with all suppliers. Now one table (with datatables) is displayed for each supplier. Moreover, there are a lot of informations (about baskets) in master which don't exist in 3.8. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:11:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 11:11:12 +0000 Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #49 from Martin Renvoize --- OK.. I've been trying to narrow down the bug with requiring Plack::Middleware::Debug. I've narrowed it down to the following lines in koha.psgi: enable_if { $ENV{'KOHA_DEBUG'} } 'Debug', panels => [[ 'DBITrace', level => 1 ], @$panels ]; I think the logic here is flawed somehow. First up I think it should actually be: enable_if { $_[0]->{'KOHA_DEBUG'} } 'Debug', panels => [[ 'DBITrace', level => 1 ], @$panels ]; But this also doesn't work. I think the builder checks for the module availability even if it's not actually to be loaded as part of the enable_if. I'm baffled.. anyone got any idea's how to fix this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:18:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 11:18:57 +0000 Subject: [Koha-bugs] [Bug 11215] Unresponsive script warning when booksellers.pl is loading a list of all vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11215 --- Comment #2 from M. de Rooy --- (In reply to Jonathan Druart from comment #1) > I think it is 'normal'. > In 3.8 there is only 1 big table with all suppliers. > Now one table (with datatables) is displayed for each supplier. > Moreover, there are a lot of informations (about baskets) in master which > don't exist in 3.8. But should we be satisfied with current behavior? Or should we check at first if there is not too much data for building such a list? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:15:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 12:15:07 +0000 Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22091|0 |1 is obsolete| | --- Comment #35 from M. de Rooy --- Created attachment 22764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22764&action=edit Bug 7791 : Give the ability to delete records when deleting a basket Currently, when a basket is deleted, all the orders are deleted (there is a foreign key in aqorders table on basketno). This could be dangerous, and there is no warn. After the deletion, unused biblios are left in the catalogue. This patch - adds a more detailed message describing the consequences of deletion - give the choice of also deleting biblio records if possible To test : Test A : 1. create a basket with 4 orders: - an order from a new record A - an order from a record B which has already an item - an order from a record C used in a subscription - an order from a record D used in an other order 2. note the biblionumbers of the records used (or open them in other tabs in yout browser) 3. click on "Delete basket" 4. choose button "Delete basket and orders" 5. check the catalogue : records A,B,C,D must still be there Test B: 1. create a basket with 4 orders: - an order from a new record A - an order from a record B which has already an item - an order from a record C used in a subscription - an order from a record D used in an other order 2. note the biblionumbers of the records used (or open them in other tabs in yout browser) 3. click on "Delete basket" 4. choose button "Delete basket, orders and records" 5. check the catalogue : records B,C,D must still be there. Record A must be deleted Signed-off-by: Cedric Vita Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:15:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 12:15:14 +0000 Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22092|0 |1 is obsolete| | --- Comment #36 from M. de Rooy --- Created attachment 22765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22765&action=edit Bug 7791 Followup: delete warns, add missing curly braket and make a simpler message if basket is void This patch - delete warns - add a missing } - add a condition in template of avoiding asking to suppress orders or records if the basket is void To test : 1. Make the same tests as defined in test plan of main patch. It should behave the same way 2. Try to delete a basket with no records inside. You will only have a "Delete basket" button, with less warnings Signed-off-by: Cedric Vita Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:15:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 12:15:23 +0000 Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22093|0 |1 is obsolete| | --- Comment #37 from M. de Rooy --- Created attachment 22766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22766&action=edit Bug 7791 Followup: add warning after deletion if some records were not deleted This followup add some warnings after deletion if some items were not deleted. 4 types of messages are possible : - x item(s) attached. - x subscription(s) attached. - x order(s) attached. - Unknown error. To test : test a 1. create a basket with - an order using a record A which has already an item, which is used in a subscription, and in other order (in an other basket) - an order using a record B used nowhere elese 2. click on "Delete basket" 3. choose button "Delete basket, orders and records" 4. you must see a page anouncing basket deletion, and that record A was not deleted because of its item, subscription and order. 5. check the link around the title of record B takes you to the record 6. check the link under the warning box ("Click here to go back to booksellers page") takes you to booksellers page 5. check record B is deleted test b 1. suppress the subscription linked with record A 2. create an other basket using record A 3. delete the basket on the same way as for test a 4. you must see a page anouncing basket deletion, and that record A was not deleted because of its item and order test c 1. suppress the item attached under record A 2. create an other basket using record A 3. delete the basket on the same way as for test a 4. you must see a page anouncing basket deletion, and that record A was not deleted because of its orderBug 7791 Followup: add warning after deletion if some records were not deleted Content-Type: text/plain; charset="utf-8" This followup add some warnings after deletion if some items were not deleted. 4 types of messages are possible : - x item(s) attached. - x subscription(s) attached. - x order(s) attached. - Unknown error. To test : test a 1. create a basket with - an order using a record A which has already an item, which is used in a subscription, and in other order (in an other basket) - an order using a record B used nowhere elese 2. click on "Delete basket" 3. choose button "Delete basket, orders and records" 4. you must see a page anouncing basket deletion, and that record A was not deleted because of its item, subscription and order. 5. check the link around the title of record B takes you to the record 6. check the link under the warning box ("Click here to go back to booksellers page") takes you to booksellers page 5. check record B is deleted test b 1. suppress the subscription linked with record A 2. create an other basket using record A 3. delete the basket on the same way as for test a 4. you must see a page anouncing basket deletion, and that record A was not deleted because of its item and order test c 1. suppress the item attached under record A 2. create an other basket using record A 3. delete the basket on the same way as for test a 4. you must see a page anouncing basket deletion, and that record A was not deleted because of its order Signed-off-by: Chris Cormack Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:18:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 12:18:36 +0000 Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #50 from Martin Renvoize --- Created attachment 22767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22767&action=edit Bug 9316: Add ability to install/configure nginx - Followup Added ability to run plack without Plack::Middleware::Debug installed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:20:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 12:20:28 +0000 Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #51 from Martin Renvoize --- I worked through it and got koha.psgi into a state where Plack::Middleware::Debug is no longer required.. I am a little confused as to how to enable KOHA_DEBUG using nginx however.. any hints would be greatly appreciated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:42:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 12:42:05 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #60 from Jonathan Druart --- Created attachment 22768 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22768&action=edit Bug 10855: Fix typo addition_fields -> additional_fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:42:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 12:42:11 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #61 from Jonathan Druart --- Created attachment 22769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22769&action=edit Bug 10855: A partial search should return the subscriptions If a search on an additional fields is done using a partial string ("foo" and the defined value is "foobar"), the subscription should appear in the result list. Test plan: Try to search a part of the string for an additional field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:43:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 12:43:46 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #62 from Jonathan Druart --- (In reply to Paola Rossi from comment #59) > In Claims, no, bug 11205 doesn't fix the problem. The use of filters at the > bottom of columns such as "Vendor", "Library", "Title", "Issue number", > "Status", "af1", always results in a "No matching records found" answer. > When I use the filter "From" and "To", the selection is nearby OK (range > [x,y] selects "Since"' days between [x+1,y-1]). > At the bottom of the table, whereas the "Select CSV profile" is only one > ("issues to claim"), selecting "Download selected claims" always results in > the error: > "Please select at least one item to export". > But no checkbox is displayed in the whole page in my test case. I asked to Julian to try to reproduce your issue. He found 2 others issues but he did not reproduce what you describe. Did you get a JS error? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:46:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 12:46:52 +0000 Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Small patch |Medium patch Severity|critical |normal --- Comment #38 from M. de Rooy --- QA Comment: Works as advertised. Nice to have. No complaints from qa tools. Code looks good to me. Includes string changes, so candidate for 3.16. I am passing QA on these patches, but have some hesitations as to design and navigation, as described in the following points: 1) The design of the page showing that the basket has been deleted, but also listing a warning c/should look better (layman's perspective :) 2) This same error page gives me the link Go back to booksellers page (note the problems reported earlier about its performance). Since I came from a basket of a specific bookseller, I would rather go back to the basket list of THAT bookseller. You opened up a new report for that, I understand. I think that this set of patches would be even more attractive with such a link. 3) A successful deletion actually does the same and sends me back to all booksellers. Please give me my particular bookseller instead :) Thanks. PS I downgraded the bug severity. I can understand that you feel this is an important issue, but critical is really another category. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:47:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 12:47:09 +0000 Subject: [Koha-bugs] [Bug 11215] Unresponsive script warning when booksellers.pl is loading a list of all vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11215 --- Comment #3 from Jonathan Druart --- Yes, maybe should we raise a message containing something like "Your search returns a large amount of results and cannot be displayed". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:50:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 12:50:47 +0000 Subject: [Koha-bugs] [Bug 7791] Deleting basket should not delete all existing orders without warning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7791 --- Comment #39 from mathieu saby --- (In reply to M. de Rooy from comment #38) > QA Comment: > Works as advertised. Nice to have. > No complaints from qa tools. Code looks good to me. > Includes string changes, so candidate for 3.16. > I am passing QA on these patches, but have some hesitations as to design and > navigation, as described in the following points: > > 1) The design of the page showing that the basket has been deleted, but also > listing a warning c/should look better (layman's perspective :) > 2) This same error page gives me the link Go back to booksellers page (note > the problems reported earlier about its performance). Since I came from a > basket of a specific bookseller, I would rather go back to the basket list > of THAT bookseller. You opened up a new report for that, I understand. I > think that this set of patches would be even more attractive with such a > link. > 3) A successful deletion actually does the same and sends me back to all > booksellers. Please give me my particular bookseller instead :) > > Thanks. > > PS I downgraded the bug severity. I can understand that you feel this is an > important issue, but critical is really another category. Thank you For the points 1-3 it could be improved by other patches ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:14:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:14:46 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22757|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 22770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22770&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:16:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:16:29 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22770|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 22771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22771&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:20:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:20:34 +0000 Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:24:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:24:25 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22771|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 22772 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22772&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:31:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:31:07 +0000 Subject: [Koha-bugs] [Bug 7491] Description for item-level_itypes is misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7491 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:31:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:31:10 +0000 Subject: [Koha-bugs] [Bug 7491] Description for item-level_itypes is misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7491 --- Comment #2 from M. de Rooy --- Created attachment 22773 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22773&action=edit Bug 7491: Description for item-level_itypes is misleading Adding some text to the pref description referring to opac display. Test plan: Look at the new description in Cataloging preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:31:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:31:27 +0000 Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #24 from Jonathan Druart --- QA comment: The patch works as expected. The syspref makes sense for me. Some QA issues, I will provide a QA followup. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:31:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:31:48 +0000 Subject: [Koha-bugs] [Bug 7491] Description for item-level_itypes is misleading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7491 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Patch complexity|--- |String patch Assignee|paul.poulain at biblibre.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:32:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:32:18 +0000 Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21856|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 22774 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22774&action=edit Bugs 10986 - Limit the list of languages in advanced search In Advanced Search, the list of available language is long and will only get longer. For a library offering books in 2-3 languages, that is offering too much info to the user (most of the small libraries we deal with only offer documents in two languages). Code changes: Languages.pm: Extract getAllLanguages to make a more customizable getLanguages (have getAllLanguage call it, so rest of codebase is oblivious to the change). Build array returned based on system pref if corresponding argument is set. search.pl and opac-search.pl: call getLanguages instead of getAllLanguages. TESTING 0) All language codes are iso 639-2 (three characters) 1) in OPAC, Advanced search, open Language box, acknowledge 30+ items. 2) in Intranet, go to system preferences AdvancedSearchLanguages, enter "ita|eng" 3) back in OPAC, refresh screen, acknowledge only Italian and English are listed. 4) in Intranet, click Search then click "More options" to make the Language box appear. Acknowledge limited options. 5) Regression Test: Back to the preference, empty the field then save. Go back to the OPAC and Intranet search, refresh the page, then the Language drop-box will now contain 30+ items. Signed-off-by: Mathieu Saby Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:32:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:32:23 +0000 Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 --- Comment #26 from Jonathan Druart --- Created attachment 22775 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22775&action=edit Bug 10986: QA followup This patch fixes some qa issues: FAIL C4/Languages.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL installer/data/mysql/updatedatabase.pl FAIL forbidden patterns forbidden pattern: merge marker (<<<<<<<) (line 7157) FAIL installer/data/mysql/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs AdvancedSearchLanguages is bad placed (see bug 10610) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:32:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:32:52 +0000 Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22775|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 22776 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22776&action=edit Bug 10986: QA followup This patch fixes some qa issues: FAIL C4/Languages.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL installer/data/mysql/updatedatabase.pl FAIL forbidden patterns forbidden pattern: merge marker (<<<<<<<) (line 7157) FAIL installer/data/mysql/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs AdvancedSearchLanguages is bad placed (see bug 10610) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:34:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:34:55 +0000 Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22776|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 22777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22777&action=edit Bug 10986: QA followup This patch fixes some qa issues: FAIL C4/Languages.pm FAIL critic # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). FAIL installer/data/mysql/updatedatabase.pl FAIL forbidden patterns forbidden pattern: merge marker (<<<<<<<) (line 7157) FAIL installer/data/mysql/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs AdvancedSearchLanguages is bad placed (see bug 10610) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:35:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:35:33 +0000 Subject: [Koha-bugs] [Bug 10986] Limit the list of languages in advanced search through system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10986 --- Comment #29 from Jonathan Druart --- (forgot to remove the coma at the end of the syspref.sql file) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:41:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:41:12 +0000 Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Tom?s, the patch does not apply anymore, could you rebase it please? fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search-results.inc). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:41:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:41:52 +0000 Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #5 from Jonathan Druart --- I forgot the dependency! Sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:45:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:45:04 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:47:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 13:47:27 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22543|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 22778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22778&action=edit Bug 11126 - Make the holds system optionally give precedence to local holds This feature will allow libraries to specify that, when an item is returned, a local hold may be given priority for fulfillment even though it is of lower priority in the list of unfilled holds. This feature has three settings: * LocalHoldsPriority, which enables the feature * LocalHoldsPriorityPatronControl, which selects for either tha patron's home library, or the patron's pickup library for the hold * LocalHoldsPriorityItemControl, which selects for either the item's holding library, or home library. So, this feature can "give priority for filling holds to patrons whose (home library|pickup library) matches the item's (home library|holding library)" Test Plan: 1) Apply this patch 2) Run t/db_dependent/Holds/LocalHoldsPriority.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:10:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:10:14 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- I am a little bit disconcerted. The aqbasketgroup.tt is really dirty and it is not easy to do something in it. But this patch is not really clear: 1/ I don't know if to add a lot of simple comment is useful (in the pl file). 2/ The view "show" is not clear in the code. Personally, I don't understand anything. 3/ There is some useless loop: [% FOREACH billingplaceloo IN billingplaceloop %] [% IF ( billingplaceloo.selected ) %] [% billingplaceloo.branchname %] [% END %] [% END %] It is not a logic way to display an input. 4/ There is a mix between new code and indentation fixes (use the -w option for git show). 5/ There is no "show" view for the opened bg. And for the closed bd, the "show" view is accessible on click on a button. Why there is no a simple "show" op and a link on the bg name? I let someone else from the QA team to give his/her opinion on this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:16:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:16:57 +0000 Subject: [Koha-bugs] [Bug 10809] use template branches plugin in serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22024|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 22779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22779&action=edit Bug 10809 - use template branches plugin in serials search In serials-search.pl, branch name is computed using branch code and then passed to template. This patch uses the new template plugin now for this : Koha::Template::Plugin::Branches. Test plan : - Go to serials search - Perform a search that returns at least an open an a closed subscription having a branch defined => The branch name is displayed in "Library" column Signed-off-by: Pierre Angot Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:17:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:17:30 +0000 Subject: [Koha-bugs] [Bug 10809] use template branches plugin in serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- Simple patch, works as expected. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:17:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:17:34 +0000 Subject: [Koha-bugs] [Bug 10809] use template branches plugin in serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10809 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:20:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:20:00 +0000 Subject: [Koha-bugs] [Bug 11103] label authors in facets not easy selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11103 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED CC| |jonathan.druart at biblibre.co | |m Resolution|--- |DUPLICATE --- Comment #4 from Jonathan Druart --- Same patch already pushed to master. *** This bug has been marked as a duplicate of bug 11107 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:20:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:20:00 +0000 Subject: [Koha-bugs] [Bug 11107] Label in staff client - authors on facets not easily accessible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11107 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maddogwilsons at gmail.com --- Comment #5 from Jonathan Druart --- *** Bug 11103 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:22:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:22:21 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #12 from Matthias Meusburger --- Hello, Thanks Matin, for rebasing my patch, and providing a test plan :) One thing though, using $ENV{'SERVER_NAME'} is not such a good idea imho, because it won't work if koha is behind a reverse proxy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:30:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:30:38 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #9 from mathieu saby --- (In reply to Jonathan Druart from comment #8) > I am a little bit disconcerted. > The aqbasketgroup.tt is really dirty and it is not easy to do something in > it. => so true. it's horrible. And very hard to understand without reindenting... > But this patch is not really clear: > 1/ I don't know if to add a lot of simple comment is useful (in the pl file). It was usefull for me, to understand how the file was structured. But I can suppress comments if they are unneeded. > 4/ There is a mix between new code and indentation fixes (use the -w option > for git show). For me reindentation were logical, because I add a new condition in the template (l. 147: [% IF (closedbg) %] ), so I felt free to reindent For the other points, I cannot answer quickly, and must watch it closely. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:34:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:34:32 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #10 from mathieu saby --- > 2/ The view "show" is not clear in the code. Personally, I don't understand > anything. Could you specify what you call the view "show" ? I don't find the "show" word in my patch. > 3/ There is some useless loop: > [% FOREACH billingplaceloo IN billingplaceloop %] > [% IF ( billingplaceloo.selected ) %] > [% billingplaceloo.branchname %] > [% END %] > [% END %] > It is not a logic way to display an input. This unless loop was here before my patch. So I kept it here. It was not my goal to remove it. But it can be fixed later. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:39:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:39:56 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:42:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:42:40 +0000 Subject: [Koha-bugs] [Bug 2693] Tagging: Add filter by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m --- Comment #7 from Jonathan Druart --- QA comment: I reproduced the error described by David, but just one time. I don't think it is critical. However, the autocomplete is often dependent on the CircAutocompl pref (request.tt, patron search header), but not always (patron list, course reserve). Since we are not in the circulation module, maybe this pref should not be check. But I suppose this pref exists in order to avoid performance issue. I am leaning towards to mark as passed QA this patch but I let the last word to the RM (as always, of course ;)) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:43:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:43:05 +0000 Subject: [Koha-bugs] [Bug 2693] Tagging: Add filter by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2693 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22289|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 22780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22780&action=edit Bug 2693 - Tagging: Add filter by name If you want to filter results on the tags management page by the reviewer you have to know their borrowernumber. It would be better to be able to search by name, but in the meantime this patch adds an autocomplete widget to the form field so that you can do a name search and populate the field with the borrowernumber. To test you must have approved or rejected tags. From the tags review page (tags/review.pl), view all, approved, or rejected tags. Type a name in the "reviewer" form field in the left sidebar filter. You should get an autocomplete dropdown with names matching your search. When you select one the form field should be populated by the borrowernumber. Signed-off-by: David Cook Patch works as described. I'm not sure whether or not it would be better to be able to search by name, as that would involve either choosing between names after applying the filter or showing any possible matches, so this seems fine. -- Owen and I did observe that we were able to cause AJAX errors while using this autocomplete, but we are not 100% sure how we caused the error. In my case, I was able to occasionally cause it by typing in a name then backspacing rapidly. The ajaxError method is attached to every element in the DOM (yikes) so it's tough to say what exactly is the source of the error (which is signalled by a pop-up window that can be cancelled). The error is quite rare so I don't think it's necessarily a problem for us. One idea that Owen had was to remove the current error message, which is very unhelpful and replace it with an error like "Something went wrong. Try again." Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:44:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:44:29 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #11 from mathieu saby --- The closedbg variable passed to template is used to decide if the bg must be only displayed, or make editable. By the way, I've remarked a typo : "closedgb" for "closedbg". I'm writing a followup. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:48:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:48:14 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22023|0 |1 is obsolete| | --- Comment #12 from mathieu saby --- Created attachment 22781 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22781&action=edit [PATCH] Bug 9807 : Make possible to view a basketgroup without reopening it Main patch rebased (little conflict) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:49:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 14:49:51 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #13 from mathieu saby --- Created attachment 22782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22782&action=edit [PATCH 2] Bug 9807 : Followup fixing variable name Fixing closedbg name in template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:19:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 15:19:35 +0000 Subject: [Koha-bugs] [Bug 11216] New: Patron modification creates indefinite manual restriction Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 Bug ID: 11216 Summary: Patron modification creates indefinite manual restriction Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: dpavlin at rot13.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:20:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 15:20:04 +0000 Subject: [Koha-bugs] [Bug 11216] Patron modification creates indefinite manual restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |dpavlin at rot13.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:49:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 15:49:29 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22772|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 22783 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22783&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:52:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 15:52:27 +0000 Subject: [Koha-bugs] [Bug 10513] Light up a warning/message when returning a chosen item type. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10513 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:53:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 15:53:55 +0000 Subject: [Koha-bugs] [Bug 11202] Improve UNIMARC biblio indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11202 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi at cineca.it --- Comment #16 from Paola Rossi --- Kind Mathieu Saby, I install master 3.13.00.042 choosing ICU, DOM, unimarc, as required, and the Italian version of koha. A problem appears at 5-th step of the test plan, with this warning messagge: ./rebuild_zebra.pl -r -b -x -v Zebra configuration information ================================ Zebra biblio directory = /home/koha/bug-11202/var/lib/zebradb/biblios Zebra authorities directory = /home/koha/bug-11202/var/lib/zebradb/authorities Koha directory = /var/root-koha/bug-11202 BIBLIONUMBER in : 001$@ BIBLIOITEMNUMBER in : 090$a ================================ skipping authorities ==================== exporting biblio ==================== 1 Records exported: 1 ==================== REINDEXING zebra ==================== 16:35:52-07/11 zebraidx(9494) [warn] /home/koha/bug-11202/etc/zebradb/biblios/etc/dom-config.xml: could not parse xslt stylesheet /home/koha/bug-11202/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl 16:35:52-07/11 zebraidx(9494) [warn] /home/koha/bug-11202/etc/zebradb/biblios/etc/dom-config.xml: could not parse xslt stylesheet /home/koha/bug-11202/etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl ==================== CLEANING ==================== Then the search answers erroneously zero findings. Can you help me? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:03:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:03:10 +0000 Subject: [Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:09:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:09:15 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Joel Sasse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:09:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:09:28 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:09:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:09:36 +0000 Subject: [Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 22784 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22784&action=edit Bug 11126 - Make the holds system optionally give precedence to local holds This feature will allow libraries to specify that, when an item is returned, a local hold may be given priority for fulfillment even though it is of lower priority in the list of unfilled holds. This feature has three settings: * LocalHoldsPriority, which enables the feature * LocalHoldsPriorityPatronControl, which selects for either tha patron's home library, or the patron's pickup library for the hold * LocalHoldsPriorityItemControl, which selects for either the item's holding library, or home library. So, this feature can "give priority for filling holds to patrons whose (home library|pickup library) matches the item's (home library|holding library)" Test Plan: 1) Apply this patch 2) Run t/db_dependent/Holds/LocalHoldsPriority.t Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:10:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:10:06 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #22 from Jonathan Druart --- QA comment: I tested on a sandbox and did not find the link issue. Links for "see also" have the expected behavior. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:10:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:10:37 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 --- Comment #24 from Jonathan Druart --- Created attachment 22786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22786&action=edit Bug 10691: 5xx not properly linked by authid in authority search result list This patch changes the URL and data used to show the 'see also' links on the OPAC's authority search results page. Bonus points: makes some strings translatable. To test: - On your dev setup (master) create some authority records (i created personal name authorities). - Pick one of them and link 400$a to another one, do the same with 500$a - Add some other 400$a and 500$a without linking (i.e. plain text) - Make sure zebra is running and changes got indexed. - In the OPAC search for the authority that is linked to the others. - Check the 'see also:' link points to an authority search - Apply the patch - Reload/re-do the search - Check the 'see also:' link points to the authority id in the case of linked authorities, and to an authority search in the case of plain text names. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:10:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:10:32 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22213|0 |1 is obsolete| | Attachment #22214|0 |1 is obsolete| | Attachment #22215|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart --- Created attachment 22785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22785&action=edit Bug 10691: 5xx not properly linked by authid in authority search result list [Staff] This patch changes the URL and data used to show the 'see also' links on the Staff's authority search results page. Bonus points: makes some strings translatable. To test: - On your dev setup (master) create some authority records (i created personal name authorities). - Pick one of them and link 400$a to another one, do the same with 500$a - Add some other 400$a and 500$a entries with plain text (i.e. no linking) - Make sure zebra is running and changes got indexed. - In the staff interface search for the authority that is linked to the others. - Check the 'see also:' link points to an authority search - Apply the patch - Reload/re-do the search - Check the 'see also:' link points to the authority id for linked authorities, and to an authority search result in the case of plain text entries. - Check that the authority search from the cataloguing interface still works as usual. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Work as described. No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:10:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:10:42 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 --- Comment #25 from Jonathan Druart --- Created attachment 22787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22787&action=edit Bug 10691: Small glitch fixed A small glitch prevented 'see from' headings to show. Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:11:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:11:40 +0000 Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart --- Tested with bug 10691. Works great. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:11:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:11:44 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:11:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:11:46 +0000 Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:12:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:12:42 +0000 Subject: [Koha-bugs] [Bug 10987] Too many 'see also' and 'usedfor/see from' labels occurences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10987 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21897|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 22788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22788&action=edit Bug 10987: Too many 'see also' and 'see from' labels occurences If an authority record has more than one 4xx$a (or 5xx$a) entries the corresponding labels 'see also' and 'used for/see from' are repeated. To test: - Have authority records with more than one entry on the 4xx (or 5xx) fields. - Do a search, check "see also:" (or 'used for/see from') appear more than once. - Apply the patch - Reload and check it looks nicer :-D - Repeat for: staff auth search, opac using ccsr, opac using prog - Signoff Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Bernardo Gonzalez Kriegel Work as decribed. No koha-qa errors Nice view on staff and both opac Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:15:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:15:14 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #6 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Joel Sasse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:15:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:15:26 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22783|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:15:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:15:33 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #7 from sandboxes at biblibre.com --- Created attachment 22789 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22789&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:16:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:16:58 +0000 Subject: [Koha-bugs] [Bug 10691] 5xx not properly linked by authid in authority search result list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10691 --- Comment #26 from Jonathan Druart --- Tom?s, you will win a bonus point if you provide a patch for the bootstrap theme :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:23:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:23:30 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22789|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 22790 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22790&action=edit Bug 9303 - relative's checkouts in the opac This patch gives patrons the option of allowing other linked relatives to view his or her checkouts from opac-user.pl in a manner similiar to the patron's own checkouts tab. By default the setting is not enabled. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create three borrowers, link them as relatives 4) In the OPAC, go to "my privacy" and choose to allow relatives to view current checkouts for borrowers A and B 5) Check out some items to each borrower 6) Log into the OPAC as borrower A, you should see a "Relatives' checkouts" tab. In this tab you should see the checkouts for borrower B 7) Log into the OPAC as borrower C, you should be able to view the current checkouts for both borrower A and borrower B Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:35:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 16:35:06 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #9 from Jonathan Druart --- Kyle, why do you add the new field issue_id? You don't use it in your code. I mark this patch as failed QA. I did't test it but you modify the structure of the issues table without modifying the old_issues table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:21:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 17:21:26 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |olli-antti.kivilahti at jns.fi --- Comment #19 from Olli-Antti Kivilahti --- ----------------- -- Letters.t -- ----------------- All test complete! Awsum! ------------------ -- Overdues.t -- ------------------ "my" variable $mtts masks earlier declaration in same scope +++++ line 50: my $mtts = C4::Overdues::GetOverdueMessageTransportTypes('', 'PT', 1); Should be line 50: $mtts = C4::Overdues::GetOverdueMessageTransportTypes('', 'PT', 1); DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`kohadata`.`overduerules_transport_types`, CONSTRAINT `overduerules_fk` FOREIGN KEY (`branchcode`, `categorycode`) REFERENCES `overduerules` (`branchcode`, `categorycode`) ON DELETE CASCADE ON) at /home/kivilahtio/koha/kohaclone/t/db_dependent/Overdues.t line 23. +++++ koha.overduerules-table is missing the branchcode and patron.categorycode definitions you are trying to link to with line 24: INSERT INTO overduerules_transport_types( branchcode, categorycode, letternumber, message_transport_type ) VALUES ('CPL', 'PT', 1, 'email'), After adding a definition via tools/overduerules.pl for branch CPL for patron PT, the given SQL element works (not the whole clause). Should be included in the test case. ------------------- -- Overdues.pm -- ------------------- at GetOverdueMessageTransportTypes() "return a arrayref with message_transport_type for given branchcode, categorycode and letternumber(1,2 or 3)" Should be "return a arrayref with all message_transport_types for given branchcode, categorycode and letternumber(1,2 or 3)" Should GetOverdueMessageTransportTypes() also take into account the default values? When library branch specific rules are not set then the function could return the default values instead? ----------------------------- -- tools/overduerules.pl -- ----------------------------- Adding definitions seems to work pretty well. Will test more tomorrow. Good work with this one! Failed QA because Overdues.t needs improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:30:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 17:30:27 +0000 Subject: [Koha-bugs] [Bug 11217] New: The # in accountlines descriptions makes them un-writeoffable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11217 Bug ID: 11217 Summary: The # in accountlines descriptions makes them un-writeoffable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nengard at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The # symbol in a description for a fine/charge makes it so that clicking write off doesn't work. It will put a write off line in the table, but it won't clear the amount owed on the find line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:40:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 17:40:57 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21145|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 22791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22791&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group2 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply patches for bugs 10080 and 10206 2) Apply this patch 3) Run updatedatabase.pl 4) Enable IndependentBranches 5) Test independent branches, no changes should be noted 6) Navigate to admin/branches.pl 7) Create a new Independent library group 8) Add your library and some other libraries to that group 9) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:40:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 17:40:54 +0000 Subject: [Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:52:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 17:52:08 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Kyle M Hall --- (In reply to Jonathan Druart from comment #9) > Kyle, why do you add the new field issue_id? You don't use it in your code. > I mark this patch as failed QA. I did't test it but you modify the structure > of the issues table without modifying the old_issues table. The issue's table needs a primary key in order to fetch related rows via DBIx::Class. I'm not sure where you say I'm not modifying the old_issues table. I see my changes in both updastedatabase.pl and kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:55:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 17:55:11 +0000 Subject: [Koha-bugs] [Bug 9618] Add support for intranetuserjs to labels/spinelabel-print.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9618 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #15 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:55:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 17:55:39 +0000 Subject: [Koha-bugs] [Bug 10570] Show internal note from subscription in results on check expiration page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10570 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:56:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 17:56:47 +0000 Subject: [Koha-bugs] [Bug 8821] Receive shipment page should hide inactive funds like new order form does In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8821 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #12 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:57:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 17:57:28 +0000 Subject: [Koha-bugs] [Bug 10841] Edit/Delete item context links in items table are not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10841 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:57:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 17:57:56 +0000 Subject: [Koha-bugs] [Bug 9372] Automatic carriage return in message_queue where content_type is html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9372 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #16 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Sophie! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 20:06:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 19:06:59 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #14 from mathieu saby --- Jonathan, I will rewrite the patch without any reindenting. I think it will be more easy to understand for QA team. As reindenting is needed for code readabiliy, it will add a followup for it. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 20:57:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 19:57:16 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22781|0 |1 is obsolete| | --- Comment #15 from mathieu saby --- Created attachment 22792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22792&action=edit [PATCH ] Bug 9807 : Make possible to view a basketgroup without reopening it Patch rewritten to eliminate reindenting Should be more easy to understand. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 21:03:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 20:03:11 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22782|0 |1 is obsolete| | --- Comment #16 from mathieu saby --- Created attachment 22793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22793&action=edit [PATCH 2] Bug 9807 : Followup fixing variable name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 22:25:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 21:25:36 +0000 Subject: [Koha-bugs] [Bug 11218] New: Due notices broken / not generated Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Bug ID: 11218 Summary: Due notices broken / not generated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org After updating a library we found due notices (send on the date a book is due) are no longer being generated. This bug is in 3.12.5 and I confirmed it's also a valid bug in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 22:27:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 21:27:07 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9362 --- Comment #1 from Katrin Fischer --- As it worked before I tried tracking the problem down with git bisect - it came up with the changes from bug 9362 which looks plausible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 22:27:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 21:27:07 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11218 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 23:55:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 22:55:08 +0000 Subject: [Koha-bugs] [Bug 9362] Wrong query in GetUpcomingDueIssues (Circulation.pm) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer --- As the advance_notice.pl script also procudes the DUE notices, the assumption that issues due today should not be selected is not correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 00:28:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 23:28:36 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22663|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 22794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22794&action=edit bug_11183: get rid of some warninngs To test in OPAC: * Set EnableOpacSearchHistory to yes (Keep). Do an advanced search with limits. Complete search with limits should show. * Have an item with Collection Code. Check that the Collection Code shows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 00:43:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 23:43:33 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #2 from Katrin Fischer --- Created attachment 22795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22795&action=edit Bug 11218: Regression tests for Due notice generation Changes tests for GetUpcomingDueIssues: days_in_advance should be inclusive: 2 should find items due in 2 days from now. 1 should find items due tomorrow. 0 should only find items due today. Adds new tests for Bug 11218: As the advance_notices.pl, the only script using GetUpcomingDueIssues is not only used for PREDUE notices, but also for DUE notices, we need to also select items due today. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 00:44:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 23:44:10 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #3 from Katrin Fischer --- Created attachment 22796 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22796&action=edit Bug 11218: Due notices not being generated To test: - Check out 2 items, due dates should be today, sometime in the past and one day after tomorrow. - Edit the message options - activate DUE and PREDUE notices with days in advance = 2 - Run the advance_notices.pl script with -v -c Result: Only a PREDUE notice is generated - Run the advance_notices.pl script with -v -c -m 2 Result: Only the PREDUE message is generated correctly. - Run t/db_dependent/Circulation.t - without first patch: all tests pass. - with first patch: some tests will fail. Apply patch. - Rerun script, now PREDUE and DUE notices should be generated. - Run t/db_dependent/Circulation.t again, all tests should pass. Add more items with different due dates, rerun and check results. Run t/Circulation.t to confirm all tests pass. - Apply the patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 00:47:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2013 23:47:06 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | --- Comment #4 from Katrin Fischer --- In my tests this seems to work now with the patches applied, please test thorougly and feedback welcome. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 01:11:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 00:11:24 +0000 Subject: [Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 --- Comment #1 from Peggy Thrasher --- Created attachment 22797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22797&action=edit Test Plan for 11040 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 01:12:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 00:12:18 +0000 Subject: [Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |p.thrasher at dover.nh.gov |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 01:15:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 00:15:04 +0000 Subject: [Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 --- Comment #2 from Peggy Thrasher --- Created attachment 22798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22798&action=edit Bug 11040 Add option to print regular slip to CircAutoPrintQuickSlip -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 02:12:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 01:12:46 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 02:12:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 01:12:50 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22795|0 |1 is obsolete| | Attachment #22796|0 |1 is obsolete| | --- Comment #5 from Liz Rea --- Created attachment 22799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22799&action=edit Bug 11218: Regression tests for Due notice generation Changes tests for GetUpcomingDueIssues: days_in_advance should be inclusive: 2 should find items due in 2 days from now. 1 should find items due tomorrow. 0 should only find items due today. Adds new tests for Bug 11218: As the advance_notices.pl, the only script using GetUpcomingDueIssues is not only used for PREDUE notices, but also for DUE notices, we need to also select items due today. Bug 11218: Due notices not being generated To test: - Check out 2 items, due dates should be today, sometime in the past and one day after tomorrow. - Edit the message options - activate DUE and PREDUE notices with days in advance = 2 - Run the advance_notices.pl script with -v -c Result: Only a PREDUE notice is generated - Run the advance_notices.pl script with -v -c -m 2 Result: Only the PREDUE message is generated correctly. - Run t/db_dependent/Circulation.t - without first patch: all tests pass. - with first patch: some tests will fail. Apply patch. - Rerun script, now PREDUE and DUE notices should be generated. - Run t/db_dependent/Circulation.t again, all tests should pass. Add more items with different due dates, rerun and check results. Run t/Circulation.t to confirm all tests pass. - Apply the patch Signed-off-by: Liz Rea Passes functional and automated testing. Due notice functionality restored. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 04:16:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 03:16:09 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #1 from Srdjan Jankovic --- Created attachment 22800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22800&action=edit bug_11213: Changed XSLTParse4Display() interface The list of biblio items is passed on now, instead of GetItemsInfo() being called. This is because the callers already have the list ready, so the GetItemsInfo() call is being duplicated unnecessarily. Search::searchResults() builds items list from XML, and that one is passed instead. * XSLT::XSLTParse4Display() - supply the items list as input param - removed hidden items list param - hidden should not be in the items list - changed buildKohaItemsNamespace() accordingly * Items - removed GetItemsLocationInfo() - added sort_by input param to GetItemsInfo() - VirtualShelves::Page::shelfpage() - replaced GetItemsLocationInfo() call with GetItemsInfo() call, passing order_by "cn_sort" * catalogue/detail.pl, opac/opac-detail.pl, shelfpage() - added items list to the XSLTParse4Display() call * Search::searchResults() - include all available info when building items lists - added combined items list (available, on loan, other) to the XSLTParse4Display() call To test: This change is a noop, so following screens need to be checked against any changes: * Intranet: - catalogue/search.pl (results) - catalogue/detail.pl - virtualshelves/shelves.pl * Opac - opac-search.pl (results, hidelostitems syspref on and off) - opac-detail.pl - opac-shelves.pl The display should stay the same before and after patch. The speed should increase though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 04:16:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 03:16:06 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 04:33:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 03:33:57 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 --- Comment #2 from Srdjan Jankovic --- This may yield significant improvements in performance. Hairy spots: * I have removed GetItemsLocationInfo() in favour of GetItemsInfo(). In case of people not using XSLT, it may incur small penalty in virtual shelves because GetItemsInfo() is a tad heavier. However, it should be insignificant compared to the benefit when XSLT is used. * I wish I knew more about Koha internals. Because then I could have more confidence in saying that items info gathered in searchResults() is sufficient for building the display. It looked fine to me, but still I need someone more knowledgeable to confirm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 07:11:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 06:11:52 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #3 from M. Tompsett --- Created attachment 22801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22801&action=edit [SIGNED OFF] bug_11183: get rid of some warnings To test in OPAC: * With the OPAC System Preference EnableOpacSearchHistory set to Keep, a simple search triggers the warning patched on line 626 of opac-search.pl * Selecting a search result item with no Collection Code set triggers the warning patched on line 576 of opac-detail.pl * Collection Code is set by editing an item in the staff client (952$8) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 07:13:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 06:13:12 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22794|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 07:43:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 06:43:47 +0000 Subject: [Koha-bugs] [Bug 8396] back to results in catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8396 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 07:59:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 06:59:49 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:03:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 07:03:47 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtompset at hotmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:05:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 07:05:00 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22799|0 |1 is obsolete| | CC| |liz at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:05:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 07:05:18 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22796|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:05:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 07:05:46 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22795|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:07:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 07:07:15 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22795|0 |1 is obsolete| | --- Comment #6 from Liz Rea --- Created attachment 22802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22802&action=edit y# Attachment to Bug 11218 - Due notices broken / not generated Bug 11218: Regression tests for Due notice generation Changes tests for GetUpcomingDueIssues: days_in_advance should be inclusive: 2 should find items due in 2 days from now. 1 should find items due tomorrow. 0 should only find items due today. Adds new tests for Bug 11218: As the advance_notices.pl, the only script using GetUpcomingDueIssues is not only used for PREDUE notices, but also for DUE notices, we need to also select items due today. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:07:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 07:07:57 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #2 from M. Tompsett --- Refactored, Enhanced, and Fixed. I'm tempted to rename this to "Overhaul of News". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:08:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 07:08:52 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #7 from Liz Rea --- Created attachment 22803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22803&action=edit Bug 11218: Due notices not being generated To test: - Check out 2 items, due dates should be today, sometime in the past and one day after tomorrow. - Edit the message options - activate DUE and PREDUE notices with days in advance = 2 - Run the advance_notices.pl script with -v -c Result: Only a PREDUE notice is generated - Run the advance_notices.pl script with -v -c -m 2 Result: Only the PREDUE message is generated correctly. - Run t/db_dependent/Circulation.t - without first patch: all tests pass. - with first patch: some tests will fail. Apply patch. - Rerun script, now PREDUE and DUE notices should be generated. - Run t/db_dependent/Circulation.t again, all tests should pass. Add more items with different due dates, rerun and check results. Run t/Circulation.t to confirm all tests pass. - Apply the patch Signed-off-by: Liz Rea Passes functional tests and automated tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:09:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 07:09:24 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22796|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:39:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 07:39:26 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #8 from Katrin Fischer --- Created attachment 22804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22804&action=edit Bug 11218: QA follow-up - Fixing some whitespace and a variable declaration Fixing some things the QA script pointed out this morning: - whitespace - variable declaration -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:49:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 07:49:19 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22665|0 |1 is obsolete| | --- Comment #16 from Srdjan Jankovic --- Created attachment 22805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22805&action=edit bug_11077: get rid of some warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:55:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 07:55:26 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22667|0 |1 is obsolete| | --- Comment #17 from Srdjan Jankovic --- Created attachment 22806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22806&action=edit Bug 11077 - Correct silent warnings in C4/Auth.pm This patch corrects a noisy ne condition. $userid = $retuserid if ( $retuserid ne ''); became $userid = $retuserid if ( $retuserid ); It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's patch, while correcting the problems found. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 09:38:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 08:38:48 +0000 Subject: [Koha-bugs] [Bug 11175] Show the parent records child records (aka. component parts) in the detailed views. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11175 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |olli-antti.kivilahti at jns.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:08:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 09:08:59 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #13 from Martin Renvoize --- Hmm, I hadn't thought of the reverse proxy case.. have you run up against this problem? I assume using the OPACBaseURL syspref instead is a better approach? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:34:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 09:34:39 +0000 Subject: [Koha-bugs] [Bug 9316] Add Nginx install options with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9316 --- Comment #52 from Martin Renvoize --- This should probably be a separate bug.. but upon first run, the opac displays errors instead of the maintenance page (that's with debug enabled or disabled) Can't use an undefined value as an ARRAY reference at /usr/local/lib/perl/5.14.2/DBI.pm line 2064. at /home/koha/kohaclone/opac/maintenance.pl line 54 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:59:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 09:59:47 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 --- Comment #27 from Katrin Fischer --- I think the syspref description is a bit confusing: AcqItemSetSubfieldsWhenReceived Set subfields for item when items are created when receiving (e.g. o=5|a="foo bar") Shouldn't it be something like: Update subfields in items on receive when items are created when ordering (e.g. o=5|a="foo bar") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:11:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 10:11:54 +0000 Subject: [Koha-bugs] [Bug 11219] New: CAS authentication fails with URL parameters Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Bug ID: 11219 Summary: CAS authentication fails with URL parameters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Bug 10029 tries to fix the use of URL parameters in CAS authentication. But is does not work. The full URL must be used in all methods of C4::Auth_with_cas. Also, in checkpw_cas(), the 'ticket' parameter must be removed to find the original URL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:12:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 10:12:13 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10029 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:12:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 10:12:13 +0000 Subject: [Koha-bugs] [Bug 10029] CAS authentication fails in OPAC reserve In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10029 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11219 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:14:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 10:14:53 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |olli-antti.kivilahti at jns.fi --- Comment #8 from Olli-Antti Kivilahti --- ----------------------------------------------------------------------------- -- "git bz applying 10832" on top of "git bz apply all commits for 9016" -- ----------------------------------------------------------------------------- Auto-merging misc/cronjobs/overdue_notices.pl CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl Manually resolved the conflict. -------------------------- -- overdue_notices.pl -- -------------------------- overdue_notices.pl properly queues letters to koha.message_queue but the parse_letter() doesn't parse any letter placeholders <> atleast for email and sms transport type. Unsure if this is because of my merge. Placeholders work when triggering notifications from check-in/check-out for ex. Only tested the main path, unsure how to trigger secondary execution paths. Test plan works for the core test case. Yet to test the specific case, but based on my code review it should work :) Otherwise good work in such a complex application area. ------------------------- -- Failed QA because -- ------------------------- Merge conflict needs to be resolved. Placeholders do not work for some reason. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:21:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 10:21:13 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 22807 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22807&action=edit Bug 11219 - CAS authentication fails with URL parameters See commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:21:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 10:21:29 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:36:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 11:36:58 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16503|0 |1 is obsolete| | Status|Patch doesn't apply |Needs Signoff CC| |christophe.croullebois at bibl | |ibre.com Assignee|adrien.saurat at biblibre.com |christophe.croullebois at bibl | |ibre.com --- Comment #8 from Christophe Croullebois --- Created attachment 22808 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22808&action=edit proposed patch Hello Kyle, I have rebased the Adrien's patch, I think all is ok now. thx for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:39:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 11:39:05 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 --- Comment #9 from Christophe Croullebois --- Kyle, I include your suggest on : $msg = encode($encoding, $msg) if ( $encoding ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:05:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:05:01 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #11 from Kyle M Hall --- Created attachment 22809 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22809&action=edit Bug 9303 [QA Followup] - relative's checkouts in the opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:15:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:15:21 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:15:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:15:24 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22801|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 22810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22810&action=edit bug_11183: get rid of some warnings To test in OPAC: * With the OPAC System Preference EnableOpacSearchHistory set to Keep, a simple search triggers the warning patched on line 626 of opac-search.pl * Selecting a search result item with no Collection Code set triggers the warning patched on line 576 of opac-detail.pl * Collection Code is set by editing an item in the staff client (952$8) Signed-off-by: Mark Tompsett Signed-off-by: Kyle M Hall Passes koha-qa.pl, works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:19:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:19:49 +0000 Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:19:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:19:53 +0000 Subject: [Koha-bugs] [Bug 10895] Tests for C4::Items GetHiddenItems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10895 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22707|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 22811 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22811&action=edit Bug 10895 - Tests for C4::Items GetHiddenItems Bug 10589 introduces PatronSingleBranch and PatronEveryBranch system preferences. This ensures that the visibility of two dummy records matches expectations. OpacHiddenItems is set to hide 2 records. The system preferences are then toggled between four cases ('SPT','SS','','SS|SPT') cross multipled for the two system preferences to verify the correct visibility. This will fail for a system with bug 10589 not applied, since this tests the functionality of that patch. This will fail for a system with bug 10900 not applied, since the calling convention for set_userenv was fixed in C4::Context in this patch. Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall Passes koha-qa.pl, unit tests pass as well -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:42:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:42:41 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22792|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 22812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22812&action=edit Bug 9807 : Make possible to view a basketgroup without reopening it Patch rewritten to eliminate reindenting This patch make possible to view an individual closed basketgroup without reopening it. - It adds a new "View" button on closed basketgroup list - It creates a view for closed basketgroups, with 3 buttons (reopen, print, export) - It adds a "delete" button on standard "edit" view (for open basketgroup) To test : 1/ regression test : - create some empty basketgroups - create some basketgroups by closing baskets - in the list of basketgroups closed and opened, check you can use the buttons that existed before the patch (close and print, delete, export, print, reopen) - click on "Edit" to edit a opened basketgroup : check everything is like before : -- change the billing and delivery places, -- add a note, -- put some new baskets in the bg, -- remove baskets from it -- save it without checking "close" box => it must be save but kept open -- edit it again, and make other some changes (define a free delivery place for example) -- save it with checking "close" => it must be saved but closed 2/ new feature test - click on "view" button on top right column of some closed basketgroup - check all the displayed informations are correct (places, free place, note, list of baskets) - check you can not change anything - click on "print" button => check a pdf is created - click on "export" button => check a csv is created - click on "reopen" button => you must stay on the same basketgroup, but it is now open and you can make some changes - go back to the basketgroup list of the vendor. Check the reopened bg is in "open" tab - click on "edit" - click on new "delete" button => the bg must be deleted, and you are redirected to the bg list of the vendor. Signed-off-by: cedric.vita at dracenie.com Signed-off-by: Kyle M Hall Passes koha-qa.pl, t and xt. Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:42:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:42:54 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #18 from Kyle M Hall --- Created attachment 22813 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22813&action=edit Bug 9807 : Followup fixing variable name Fixing closedbg name in template Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:44:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:44:59 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com --- Comment #19 from Kyle M Hall --- I would like to note that the pdf print view is a "interesting" but certainly no reason to not pass qa. I think a long term future goal should be to enable Template Toolkit for slips and notices, and then perhaps switch print views such as this to being html views configurable via slips and notices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:45:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:45:07 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #20 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #19) > DBD::mysql::db do failed: Cannot add or update a child row: a foreign key > constraint fails (`kohadata`.`overduerules_transport_types`, CONSTRAINT > `overduerules_fk` FOREIGN KEY (`branchcode`, `categorycode`) REFERENCES > `overduerules` (`branchcode`, `categorycode`) ON DELETE CASCADE ON) at > /home/kivilahtio/koha/kohaclone/t/db_dependent/Overdues.t line 23. Yes, I forgot to insert the overdue rules. It will be fixed with a followup. > at GetOverdueMessageTransportTypes() > "return a arrayref with message_transport_type for given branchcode, > categorycode and letternumber(1,2 or 3)" > Should be > "return a arrayref with all message_transport_types for given branchcode, > categorycode and letternumber(1,2 or 3)" Will be fixed too. > Should GetOverdueMessageTransportTypes() also take into account the default > values? When library branch specific rules are not set then the function > could return the default values instead? No I don't think. It is the current behavior: if no specific rule is defined for a library, no data is displayed on the interface when this library is selected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:45:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:45:23 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:45:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:45:26 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 --- Comment #21 from Jonathan Druart --- Created attachment 22814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22814&action=edit Bug 9016: Fix unit tests The unit tests should insert overdue rules. + Fix the doc for GetOverdueMessageTransportTypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:50:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:50:47 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #20 from mathieu saby --- (In reply to Kyle M Hall from comment #19) > I would like to note that the pdf print view is a "interesting" but > certainly no reason to not pass qa. I think a long term future goal should > be to enable Template Toolkit for slips and notices, and then perhaps switch > print views such as this to being html views configurable via slips and > notices. Hi Not sure to understand your message. You mean generate the pdf from a HTML file, not with Perl PDF library? If so, yes it would be a good idea ;-) But my patch did not concern this part of code... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:52:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:52:34 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20819|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart --- Created attachment 22815 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22815&action=edit Bug 10832: Multi transport types for overdue notices Test plan: - define some complex overdue rules (tools/overduerules.pl). For example: First overdue from 2 to 5 days by sms and email with letter code L1 Second overdue from 5 to 15 days by email with letter code L2 Third overdue from 15 days by print with letter code L3 - defined a message for each transport type selected (tools/letters.pl). - select 3 patrons (P1, P2, P3) and 3 barcodes (B1, B2, B3). * checkout B1 to P1 with a due date = NOW + 3 days * checkout B2 to P2 with a due date = NOW + 10 days * checkout B3 to P3 with a due date = NOW + 20 days - into the mysql cli, note the value of unsent message: select count(*) from message_queue where status != "send"; - launch the cronjob: perl misc/cronjobs/overdue_notices.pl - retry the previous sql query, you should have X + 4 unsent messages (depending of current checkouts in your DB!). - view all unsent message: select borrowernumber, letter_code, message_transport_type, content from message_queue where status != "send"; You should see: 2 messages for P1, 1 for sms, 1 for email and the letter code L1 1 message for P2, 1 for email and the letter code L2 1 message for P3, 1 for print and the letter code L3 - Specific case: If a user don't have a smsalertnumber and a sms is required or if a user don't have an email defined and an email is required, a print notice is generated. A print notice is generated only 1 time per borrower and per level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:53:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 12:53:46 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 --- Comment #10 from Jonathan Druart --- (In reply to Olli-Antti Kivilahti from comment #8) > overdue_notices.pl properly queues letters to koha.message_queue but the > parse_letter() doesn't parse any letter placeholders <> > atleast for email and sms transport type. Unsure if this is because of my > merge. Placeholders work when triggering notifications from > check-in/check-out for ex. The placeholder is not branch.branchname but branches.branchname :) > Merge conflict needs to be resolved. Conflict resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:11:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 13:11:41 +0000 Subject: [Koha-bugs] [Bug 9303] relative's checkouts in the opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 --- Comment #12 from Jonathan Druart --- (In reply to Kyle M Hall from comment #10) > The issue's table needs a primary key in order to fetch related rows via > DBIx::Class. I'm not sure where you say I'm not modifying the old_issues > table. I see my changes in both updastedatabase.pl and kohastructure.sql Whaou, yes! I don't know what I did. Maybe I looked to an older patch (where there was no change on old_issues)... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:14:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 13:14:04 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22760|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall --- Created attachment 22816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22816&action=edit Bug 7802: Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:14:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 13:14:17 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22761|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall --- Created attachment 22817 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22817&action=edit Bug 7802: Followup Remove CUR_DATE() and CURRENT_DATE() MySQLisms, replace by CAST(now() AS date). Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:14:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 13:14:31 +0000 Subject: [Koha-bugs] [Bug 7802] A MySQLism is used to get the current date. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:48:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 13:48:00 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables on parcel.pl do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22736|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 22818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22818&action=edit Bug 11203 - Datatables in acqusitions do not ignore "stopwords" in titles Sorting by the "summary" column does not produce the preferred results. Title beginning with 'a', 'an', or 'the' are sorted using those articles. Test plan: 1) Place an order for 2 items with the titles "Alpha" and "The Alpha", along with some other records with titles starting with something between 'a' and 't', and 't' and 'z' 2) Sort the "pending orders" table, note the incorrect sorting 3) Receive all the items 4) Sort the "already received" table, note the incorrect sorting 5) Apply the patch 6) Repeat steps 1-4, note the corrected sorting 7) Check acqui/basket.pl for correct sorting 8) Check acqui/invoice.pl for correct sorting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:48:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 13:48:12 +0000 Subject: [Koha-bugs] [Bug 11203] Datatables in acqusitions do not ignore "stopwords" in titles In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11203 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Datatables on parcel.pl do |Datatables in acqusitions |not ignore "stopwords" in |do not ignore "stopwords" |titles |in titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:58:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 13:58:26 +0000 Subject: [Koha-bugs] [Bug 11216] Patron modification creates indefinite manual restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:58:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 13:58:29 +0000 Subject: [Koha-bugs] [Bug 11216] Patron modification creates indefinite manual restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 22819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22819&action=edit Bug 11216 - Patron modification creates indefinite manual restriction Editing partron data results in unintended adding of indefinite manual restriction to it. Reason for it is hidden field add_debarment which is wrongly initialized to 1 instead of 0. Also JavaScript code seems to want to toggle checkbox, and sice this field is hidden correct approach would be to change it's value to 1. Test scenario: 1. edit patron data 2. verify that debarrment is wrongly added 3. remove debarrment 3. apply this patch 4. edit patron again 5. verify that debarrment wasn't added 6. intentionally add debarrment and verify that it's saved -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:01:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:01:10 +0000 Subject: [Koha-bugs] [Bug 11216] Patron modification creates indefinite manual restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:01:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:01:57 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle at bywatersolutions.com --- Comment #48 from Kyle M Hall --- The patch does not have a sign-off line. Could whoever meant to sign it please do so. As the original author of MungeMarcPrice I fully endorse these changes. However, I'd really like to see some unit tests to test all these various price string situations. This sub should be one of the absolute easiest ones to write unit tests for since all it does is take in a price string and return a price string. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:03:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:03:45 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22541|0 |1 is obsolete| | --- Comment #49 from Kyle M Hall --- Created attachment 22820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22820&action=edit Bug 9593 Prices not imported correctly from a staged file Initial bug : When there's a round price with no decimals after it, or when the symbol is after the digits, the price is not captured by regular expression in MungeMarcPrice routine and the variable is not initialized. Enhancement : The MungeMarcPrice routine had been widely modified. It 's still possible to priority pick the active currency but unlike the previous mechanism that worked only for prices preceded by the currency sign, it's now valid wherever the symbol is situated. As symbol you may enter a pure currency sign as well as a string including it like '$US'. Moreover, an 'isocode' column had been added in currency table (editable in the pro interface from Administration/Currencies and exchange rates). So the active currency can be picked either through its symbol or through its iso code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:04:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:04:06 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 22821 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22821&action=edit Bug 11096: Take advantage of MARC::Field->as_string feature Avoid looping over the subfields for building the facets. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:27:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:27:22 +0000 Subject: [Koha-bugs] [Bug 11216] Patron modification creates indefinite manual restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:27:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:27:27 +0000 Subject: [Koha-bugs] [Bug 11216] Patron modification creates indefinite manual restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 --- Comment #2 from Owen Leonard --- Created attachment 22822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22822&action=edit [SIGNED-OFF] Bug 11216 - Patron modification creates indefinite manual restriction Editing partron data results in unintended adding of indefinite manual restriction to it. Reason for it is hidden field add_debarment which is wrongly initialized to 1 instead of 0. Also JavaScript code seems to want to toggle checkbox, and sice this field is hidden correct approach would be to change it's value to 1. Test scenario: 1. edit patron data 2. verify that debarrment is wrongly added 3. remove debarrment 3. apply this patch 4. edit patron again 5. verify that debarrment wasn't added 6. intentionally add debarrment and verify that it's saved Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:35:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:35:55 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22802|0 |1 is obsolete| | Attachment #22803|0 |1 is obsolete| | Attachment #22804|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 22823 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22823&action=edit Bug 11218: Regression tests for Due notice generation Changes tests for GetUpcomingDueIssues: days_in_advance should be inclusive: 2 should find items due in 2 days from now. 1 should find items due tomorrow. 0 should only find items due today. Adds new tests for Bug 11218: As the advance_notices.pl, the only script using GetUpcomingDueIssues is not only used for PREDUE notices, but also for DUE notices, we need to also select items due today. Signed-off-by: Liz Rea Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:36:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:36:01 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #10 from Kyle M Hall --- Created attachment 22824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22824&action=edit Bug 11218: Due notices not being generated To test: - Check out 2 items, due dates should be today, sometime in the past and one day after tomorrow. - Edit the message options - activate DUE and PREDUE notices with days in advance = 2 - Run the advance_notices.pl script with -v -c Result: Only a PREDUE notice is generated - Run the advance_notices.pl script with -v -c -m 2 Result: Only the PREDUE message is generated correctly. - Run t/db_dependent/Circulation.t - without first patch: all tests pass. - with first patch: some tests will fail. Apply patch. - Rerun script, now PREDUE and DUE notices should be generated. - Run t/db_dependent/Circulation.t again, all tests should pass. Add more items with different due dates, rerun and check results. Run t/Circulation.t to confirm all tests pass. - Apply the patch Signed-off-by: Liz Rea Passes functional tests and automated tests. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:36:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:36:06 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 --- Comment #11 from Kyle M Hall --- Created attachment 22825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22825&action=edit Bug 11218: QA follow-up - Fixing some whitespace and a variable declaration Fixing some things the QA script pointed out this morning: - whitespace - variable declaration Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:37:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:37:25 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com --- Comment #12 from Kyle M Hall --- Passes koha-qa.pl, t and xt. Great unit tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:49:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:49:53 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22793|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:50:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:50:55 +0000 Subject: [Koha-bugs] [Bug 11216] Patron modification creates indefinite manual restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22819|0 |1 is obsolete| | --- Comment #3 from Dobrica Pavlinusic --- Created attachment 22826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22826&action=edit Bug 11216 - Patron modification creates indefinite manual restriction Editing partron data results in unintended adding of indefinite manual restriction to it. Reason for it is hidden field add_debarment which is wrongly initialized to 1 instead of 0. Also JavaScript code seems to want to toggle checkbox, and sice this field is hidden correct approach would be to change it's value to 1. Test scenario: 1. edit patron data 2. verify that debarrment is wrongly added 3. remove debarrment 3. apply this patch 4. edit patron again 5. verify that debarrment wasn't added 6. intentionally add debarrment and verify that it's saved 7. add debarment, enter something in comment but press cancel and verify that debarment isn't added -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:51:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:51:24 +0000 Subject: [Koha-bugs] [Bug 11220] New: Patron edit process doesn't remember restriction selections Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11220 Bug ID: 11220 Summary: Patron edit process doesn't remember restriction selections Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If you are editing a patron who has an existing restriction or you are adding a manual restriction, the form doesn't remember your selections if the page is redisplayed after an error. The problem cannot be demonstrated by a validation error which is caught by the client-side validation. It has to be a server-side validation error in order to trigger the full refresh of the page after error. In my case the error was triggered because the existing patron's dateofbirth was '0000-00-00' in the database and Koha returned an error message because of this. To reproduce using a patron record which has no restrictions: 1. Start with a patron record which will trigger a server-side error message. 2. Add a manual restriction in the "Patron restrictions" section of the edit form. 3. Submit your changes. 4. After the page refreshes the form will be redisplayed with an error message at the top. Whatever data you entered for the manual restriction will be gone. To reproduce using a patron record which has restrictions: 1. Start with a patron record which will trigger a server-side error message. 2. Check the box next to the existing restriction you want to remove. 3. Submit your changes. 4. After the page refreshes the form will be redisplayed with an error message at the top. The checkbox you checked will be empty. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:51:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:51:32 +0000 Subject: [Koha-bugs] [Bug 11216] Patron modification creates indefinite manual restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:51:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:51:50 +0000 Subject: [Koha-bugs] [Bug 11216] Patron modification creates indefinite manual restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22822|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:52:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:52:31 +0000 Subject: [Koha-bugs] [Bug 11216] Patron modification creates indefinite manual restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216 --- Comment #4 from Dobrica Pavlinusic --- Sorry Owen, I found another place which needs care when canceling debarment, so I obsoleted your sign-off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:57:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 14:57:39 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #50 from mathieu saby --- It was signed off the 26th september by C.Croullebois, in comment 41, (attachment 21477), but a new patch was added the 21st october 'attachment.cgi?id=22151) without signoff line (see comment 44). I think Lyon 3 deleted by mistake the signoff line. Lyon 3, could you confirm that ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:20:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 15:20:04 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #21 from mathieu saby --- Created attachment 22827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22827&action=edit [PATCH 3] Bug 9807 : Reindent basketgroup template Subject: [PATCH 3/3] reindent basketgroup.tt Content-Type: text/plain; charset="utf-8" Basketgroup.tt is very hard to read This patch reindents it No visiable changes expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:20:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 15:20:49 +0000 Subject: [Koha-bugs] [Bug 9807] There should be a way to show the content of a basketgroup without reopening it In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff --- Comment #22 from mathieu saby --- Regression test : - check the list of opened and closed basketgroups for a vendor is displayed properly - check an individual basketgroup (closed and opened) is displayed properly - check you can edit a basketgroup and save changes - check you can print and export a basketgroup - check you can close and reopen a basketgroup The last attachment Needs signoff. The 2 firsts have passed QA M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:24:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 15:24:56 +0000 Subject: [Koha-bugs] [Bug 9865] Make SIP2 message encoding configurable via SIPconfig.xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9865 --- Comment #10 from Colin Campbell --- Christophe would it be a good idea to ensure that an encoding attribute exists in the Account object, set to q{} if none exists in the config file? That way existing sip configurations can be used without runtime warnings being generated because the encoding attribute is not present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:31:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 15:31:25 +0000 Subject: [Koha-bugs] [Bug 11167] Remove memcached config from koha-conf-site.xml.in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22614|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi --- Created attachment 22828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22828&action=edit Bug 11167 - Remove memcached config from koha-conf-site.xml.in Memcached-configuration is now done with environment variables or SetEnv in the Apache configs. Having remnants of the now obsolete configuration in koha-conf.xml might cause confusion as to where memcached is actually configured. This patch removes the two lines related to memcached from koha-conf-site.xml.in To test, the hard way: - Apply the patch - Build packages - Install package - Create instances and enable memcached - Check that memcached is used, even without the settings in koha-conf.xml To test, the easy way: - On an installation running off the packages, verify that memcached is actually configured through environment variables/SetEnv in the Apache configs, and not through koha-conf.xml Signed-off-by: Robin Sheat Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:31:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 15:31:43 +0000 Subject: [Koha-bugs] [Bug 11167] Remove memcached config from koha-conf-site.xml.in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11167 --- Comment #4 from Tom?s Cohen Arazi --- Created attachment 22829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22829&action=edit Bug 11167: QA-followup - C4::SQLHelper still used the koha-conf.xml entries There was still some use of the koha-conf.xml memcached_servers and memcached_namespace configuration in C4::SQLHelper. This followup removes that remaining bits. Regards To+ Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:45:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 15:45:38 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #18 from M. Tompsett --- Srdjan Jankovic, you undid some of my tweaks which fixed the following cases: q_userid = undef, s_userid is defined and not '' or 0. OR s_userid = undef, q_userid is defined and not '' or 0. That is the following on line 693: ($q_userid && $s_userid && $q_userid ne $s_userid) will not work exactly like the noisy ($q_userid ne $s_userid) This is why I put: my $q_userid = $query->param('userid') // ''; # (line 653) and $s_userid = $session->param('id') // ''; # (line 675) I'm attaching some test code to demonstrate. I've changed the status to ASSIGNED, since these pieces we have are a bit tangled up and messy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:46:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 15:46:37 +0000 Subject: [Koha-bugs] [Bug 11159] Small typo in catalogue/results.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11159 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|Trivial patch |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:46:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 15:46:39 +0000 Subject: [Koha-bugs] [Bug 11159] Small typo in catalogue/results.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11159 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22518|0 |1 is obsolete| | --- Comment #2 from M. de Rooy --- Created attachment 22830 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22830&action=edit Bug 11159 - Small typo in catalogue/results.tt In catalogue/results.tt, there is a small HTML error line 377 : [% ELSE %][% END %] The = is missing Test plan : - In intranet, test go to advanced search - Click on [More options] - Enter a term, check "Scan indexes" and click on "Search" - Look at HTML code of select "Indexed in" => option "Author" is correct : Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:47:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 15:47:21 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #19 from M. Tompsett --- Created attachment 22831 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22831&action=edit Sample Test Program to confirm behaviour of busted vs current patch vs suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:47:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 15:47:56 +0000 Subject: [Koha-bugs] [Bug 11159] Small typo in catalogue/results.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11159 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from M. de Rooy --- Taking the liberty for this trivial string patch to upgrade it to Passed QA. No string change, just html. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:48:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 15:48:14 +0000 Subject: [Koha-bugs] [Bug 11159] Small typo in catalogue/results.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11159 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:01:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:01:12 +0000 Subject: [Koha-bugs] [Bug 11221] New: New patrons are created with invalid dateofbirth value if field is left empty Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11221 Bug ID: 11221 Summary: New patrons are created with invalid dateofbirth value if field is left empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If you leave the date of birth field empty when you create a new patron an invalid value is saved to the database: '0000-00-00' instead of NULL. To reproduce: 1. Create a new patron. Leave dateofbirth empty. 2. Save the record. 3. Open the record for editing. 4. Save the record without making changes. 5. Koha gives you an error: "Date of birth is invalid." According to git bisect this bug was caused by the fix for Bug 10403. I assume it was this change to SQLHelper.pm since all other changes in that bug are related to acquisitions: --- a/C4/SQLHelper.pm +++ b/C4/SQLHelper.pm @@ -406,7 +406,7 @@ sub _filter_hash{ ## supposed to be a hash of simple values, hashes of arrays could be implemented $filter_input->{$field}=format_date_in_iso($filter_input->{$field}) if $columns->{$field}{Type}=~/date/ && - $filter_input->{$field} !~C4::Dates->regexp("iso"); + ($filter_input->{$field} && $filter_input->{$field} !~C4::Dates->regexp("iso")); my ($tmpkeys, $localvalues)=_Process_Operands($filter_input->{$field},"$tablename.$field",$searchtype,$columns); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:24:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:24:21 +0000 Subject: [Koha-bugs] [Bug 10935] CSV for basket and basketgroup are broken when translated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10935 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9189 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:24:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:24:21 +0000 Subject: [Koha-bugs] [Bug 9189] Translation process does not keep line feeds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9189 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10935 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:25:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:25:00 +0000 Subject: [Koha-bugs] [Bug 9189] Translation process does not keep line feeds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9189 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #5 from Fridolyn SOMERS --- Acq basket CSV export solved by Bug 10935 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:26:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:26:19 +0000 Subject: [Koha-bugs] [Bug 11218] Due notices broken / not generated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- Pushed to master and 3.14.x. Thanks, Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:27:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:27:54 +0000 Subject: [Koha-bugs] [Bug 11032] Validate passed records in Biblio.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11032 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22447|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 22832 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22832&action=edit Bug 11032: Check a valid MARC::Record passed to Biblio Intermittently problems in the calling environment cause a C4::Biblio to be called with and undefined MARC::Record object. This results in the process dieing and returning to the enduser a low level message such as 'cannot call method x on an undefined object' For exported subroutines taking a MARC::Record object check that object is defined otherwise return a logical return value and log a stack trace to the error log. A couple of cases were checking but dieing, this may have unwelcome results in a persistent environment so croak has been downgraded to carp Signed-off-by: Katrin Fischer Adds lots of checks for $record in various places, should not affect behaviour. Passed all tests and QA script, including new unit tests. Tested adding and saving a new record. Also tested detail and result pages without XSLT. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:28:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:28:05 +0000 Subject: [Koha-bugs] [Bug 11032] Validate passed records in Biblio.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11032 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:30:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:30:09 +0000 Subject: [Koha-bugs] [Bug 11159] Small typo in catalogue/results.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11159 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:35:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:35:23 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #5 from Galen Charlton --- Comment on attachment 22810 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22810 bug_11183: get rid of some warnings Review of attachment 22810: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11183&attachment=22810) ----------------------------------------------------------------- ::: opac/opac-detail.pl @@ +573,4 @@ > > # get collection code description, too > my $ccode = $itm->{'ccode'}; > + $itm->{'ccode'} = $collections->{$ccode} if $ccode && $collections && $collections->{$ccode}; I believe what was called for was just adding a check on whether $ccode was defined. Getting rid of the "defined($collections)" and "exists( $collections->{$ccode}" breaks things if the library happened to define "0" as a collection code. Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:35:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:35:33 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |gmcharlt at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:37:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:37:12 +0000 Subject: [Koha-bugs] [Bug 11101] Item Type label in OPAC not easily css selectable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11101 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:37:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:37:15 +0000 Subject: [Koha-bugs] [Bug 11101] Item Type label in OPAC not easily css selectable. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11101 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22440|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 22833 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22833&action=edit Bug 11101 - Item Types label in opac not easily css selectable. Verify that the facet label for item type is wrapped in a span Signed-off-by: Katrin Fischer Adds a CSS class to the Item types facet in OPAC. Works as described. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:46:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:46:51 +0000 Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11476|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 22834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22834&action=edit Bug 6273: Add support for recording SIP2 Fee Paid Payment Type Adds support for recording in Koha accountlines a different accounttype depending on how the fee was paid at the SIP2 station (cash, credit, etc) Adds a new param to recordpayment(), $sip_paytype, which is appended to the 'Pay' type if present. The payment descriptin is also appended with " (via SIP2)" if this is present. In order for other scripts to keep working as expected, "eq 'Pay'" needed to be replaced with a regex comparison "=~ /^Pay/", so that 'Pay' and 'Pay-##' would continue to group together. To test: 1. Make a payment over a SIP2 connection 2. Check the patron record in the staff client; you should see the modified description 3. Attempt to print a invoice or a reciept for the borrower; the payment should show up where expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:46:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:46:48 +0000 Subject: [Koha-bugs] [Bug 6273] SIP2 Fee Paid and Fee Paid Response support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6273 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:50:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:50:18 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18025|0 |1 is obsolete| | --- Comment #28 from Kyle M Hall --- Created attachment 22835 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22835&action=edit Bug 7882 - move or reorder 6xx and 7xx fields Adds jQueryUI sortable features to fields. Converts list items from div's to ul's Added Image files to be used for Drag and drop in frameworks added CSS changes for images To Test: Go into catalogging and choose to add a new item with your favorite framework. You should be able to move the fields and the subfields around After making your desired number of changes choose to save You should notice the marc record saved in the order that you arranged the fields Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:50:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:50:30 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:50:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:50:34 +0000 Subject: [Koha-bugs] [Bug 7882] move or reorder 6xx and 7xx fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18027|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall --- Created attachment 22836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22836&action=edit Bug 7882 - move or reorder 6xx and 7xx fields - Followup - Remove placeholder highlighting This followup removes the yellow placeholder box when moving fields. To me, it looks and behaves far more sensibly without it. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:51:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:51:45 +0000 Subject: [Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master for inclusion in 3.16. Thanks, Mathieu! I've got to say that I quibble with using "Physical presentation" when one of the options under that label is "electronic resource", but I agree that it's better than "Print". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:53:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:53:05 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #63 from Paola Rossi --- I re-installed the master again, and applied all the 13 patches. I create a new notice, i.e. a claim notice for serials issues. In the claim page, now table and filters are OK. The claim notice is mandatory, otherwise the first column [of checkboxes] of the table is missing. But koha doesn't force in the creation of this notice. About searching subscriptions by additional fields, I hypothesize not to exclude authorized values. So selecting these 4 cases in the form results in errors: category of the added field,"value",error: 1) CCODE,"FICTION",finds FICTION+NON FICTION 2) NOT_LOAN,"Not For Loan",finds "Ordered" 3) YES_NO,"NO",finds everything and looses the selection in form 4) HINGS_UT,"Information not available; Not applicable",find everything and looses the selection in form. NB: Some descriptions are part of other ones in the same category (i.e. "Fiction" in "Non Fiction" of CCODE, "Lost" in "Lost and Paid For" of LOST). But "Fiction" of CCODE finds erroneously, while "Lost" of LOST finds right. The 4 cases of errors in the form are the only errors I find now. I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:53:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:53:38 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21081|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 22837 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22837&action=edit Bug 10612 - Add ability to delete patrons with batch patron modification tool The batch patron deletion/anonymization does not allow for batch deletion of arbitrary lists of patrons. The batch patron modification tool allows for modification of arbitrary lists of patrons, but not deletion. If would be highly beneficial to add patron deletion to the batch patron modification tool. Test Plan: 1) Apply all dependencies for this patch 2) Apply this patch 3) Create a list of patrons with the new Patron Lists feature a) Include at least one patron owing fines b) Include at least one patron with items currently checked out c) Include at least one patron not falling into a) or b) 4) Browse to the batch patron modifications tool 5) Select your list from the pulldown, and submit 6) Check the "Delete patrons" checkbox, the click the submit button 7) You should a list of errors for the patrons with fines or issues and a table of patrons that were deleted successfully. 8) Click the link for a deleted patron, you should get a "patron not found" message. Signed-off-by: Nora Blake -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:53:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:53:48 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:53:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 16:53:51 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21446|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 22838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22838&action=edit Bug 10612 - Add ability to delete patrons with batch patron modification tool - QA Followup - Move member deletion related calls to DelMember -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:02:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:02:17 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #6 from M. Tompsett --- Created attachment 22839 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22839&action=edit Sample code demonstrating problem Galen found. It also includes a revision which should work. I know a code of '' isn't really possible, but that also fails. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:02:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:02:55 +0000 Subject: [Koha-bugs] [Bug 11189] Rename Print label in UNIMARC advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11189 --- Comment #9 from mathieu saby --- (In reply to Galen Charlton from comment #8) > Pushed to master for inclusion in 3.16. Thanks, Mathieu! > > I've got to say that I quibble with using "Physical presentation" when one > of the options under that label is "electronic resource", but I agree that > it's better than "Print". Not easy to find the best name for that field. We could change it later. Anyway, only a few very curious patrons use this "advanced advanced search"... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:04:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:04:16 +0000 Subject: [Koha-bugs] [Bug 9774] Search results shows "no holds allowed" for items "Waiting" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9774 Mickey Coalwell changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mcoalwell at nekls.org --- Comment #9 from Mickey Coalwell --- This appears to be a case where the message displayed in search.pl is erroneous, based on certain special cases. In addition to the cases documented by Heather, there appears to be another -- when there is a single item on the record, and it is IN TRANSIT. As Jorge noted in the original report, one CAN place holds on these items, regardless of the message displayed in search.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:05:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:05:46 +0000 Subject: [Koha-bugs] [Bug 11222] New: A regression on label-item-search.pl done by Bug 9239 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Bug ID: 11222 Summary: A regression on label-item-search.pl done by Bug 9239 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label printing Assignee: cnighswonger at foundations.edu Reporter: z.tajoli at cineca.it QA Contact: testopia at bugs.koha-community.org Hi to all, the commit http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=144c7f4e4e023f7a701a1e58524409628295343b for bug 9239 insert a regression on the search of items in print labels. In fact it an error only in one line, line 100. The patch is: - $ccl_query .= "acqdate,st-date-normalized,le=" . $datefrom->output("iso"); + $ccl_query .= "acqdate,st-date-normalized,le=" . $dateto->output("iso"); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:10:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:10:46 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21257|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 22840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22840&action=edit Bug 10500 - Improve isbn matching when importing records Test Plan: 1) Catalog a record with the ISBN "0394502884 (Random House)" 2) Export the record, edit it so the ISBN is now "0394502884 (UnRandomHouse)" 3) Using the record import tool, import this record with matching on ISBN. 4) You should not find a match 5) Apply this patch 6) Run updatedatabase.pl 7) Enable the new system preference AggressiveMatchOnISBN 8) Repeat step 3 9) The tool should now find a match Signed-off-by: Tom McMurdo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:10:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:10:55 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21258|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall --- Created attachment 22841 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22841&action=edit Bug 10500: Followup for UNIMARC In UNIMARC, the isbn index is ISBN. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:14:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:14:08 +0000 Subject: [Koha-bugs] [Bug 11222] A regression on label-item-search.pl done by Bug 9239 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #1 from Zeno Tajoli --- Created attachment 22842 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22842&action=edit Fix for bug 11222 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:18:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:18:48 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 --- Comment #20 from Kyle M Hall --- (In reply to Jonathan Druart from comment #16) > (In reply to Kyle M Hall from comment #15) > > Jonathan, I'm unable to reproduce your problem. > > Ok, I think I found the problem. I suspect you don't have a "Required match > checks" defined for your isbn matching rule. I have a check defined as the > matchpoint component (010$a, 0, 0) for source and target. > I don't know what is this match check and I don't know if your patch must > impact them. Thanks for the additional data. I don't think this is really a problem with this patch. When you add a match check, it's looking for exact values between two marc fields. I think it makes sense for the match to fail in this case, as you're causing the matching to be much for strict, while this patch is allowing for less strict matching. Does that make sense? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:19:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:19:03 +0000 Subject: [Koha-bugs] [Bug 10500] Improve isbn matching when importing records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10500 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:22:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:22:38 +0000 Subject: [Koha-bugs] [Bug 11222] A regression on label-item-search.pl done by Bug 9239 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Zeno Tajoli --- Test plan: 1)Start with an installation with bibliografic data and items information. 2)Check that in items there are values inside Accession Date Without the patch: a)Go in Home? Tools? Labels and click on 'New batch' b)Click on 'Add Item(s)' c)Try to select items with option "Added on or before date" d)You will receive an error With the patch: Redone points a),b), c) Now you don't receive an error and you can select items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:23:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:23:16 +0000 Subject: [Koha-bugs] [Bug 11222] A regression on label-item-search.pl done by Bug 9239 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11222 --- Comment #3 from Zeno Tajoli --- This bug is on 3.12, 3.14, master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:24:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:24:34 +0000 Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 --- Comment #22 from Kyle M Hall --- Created attachment 22843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22843&action=edit Bug 9261 - Allow librarians to make purchase suggestions for patrons - QA Followup 4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:24:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:24:50 +0000 Subject: [Koha-bugs] [Bug 9261] Allow librarians to make purchase suggestions for patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9261 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:36:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:36:30 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22806|0 |1 is obsolete| | --- Comment #20 from M. Tompsett --- Created attachment 22844 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22844&action=edit Bug 11077 - Correct silent warnings in C4/Auth.pm This patch corrects a noisy ne condition. $userid = $retuserid if ( $retuserid ne ''); became $userid = $retuserid if ( $retuserid ); It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's patch, while correcting the problems found. This includes: my $q_userid = $query->param('userid') // ''; along with: my $s_userid = ''; and: my $s_userid = $session->param('id') // ''; Indentation does not reflect actual scoping. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:36:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:36:56 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22831|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:58:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 17:58:42 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22821|0 |1 is obsolete| | --- Comment #8 from Tom?s Cohen Arazi --- Created attachment 22845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22845&action=edit Bug 11096: Take advantage of MARC::Field->as_string feature Avoid looping over the subfields for building the facets. pushes higher version dependencies for MARC::File::XML and MARC::Record. Apply on top of the other patches for this bug, facets should still show as usual. Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 19:13:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 18:13:35 +0000 Subject: [Koha-bugs] [Bug 11096] Koha cannot retreive big records from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11096 --- Comment #9 from Tom?s Cohen Arazi --- Created attachment 22846 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22846&action=edit Sample record (lots of items) This is a sample record with lots of items and note fields. To use download and do: - Import the record: $ misc/migration_tools/bulkmarcimport.pl -v -b -m=marcxml -file=sample_record.marcxml $ misc/migration_tools/rebuild_zebra.pl -b -a -z -v -x - Have zebrasrv running, for example like this: $ zebrasrv -f ~/koha-dev/etc/koha-conf.xml -k 10240000 -v "fatal,warn,log" - Do a search for "Arquitectura viva" You get no results - Apply the patch series - Re-do the search Voila -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 19:29:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 18:29:46 +0000 Subject: [Koha-bugs] [Bug 10667] ILS-DI: AuthenticatePatron should also work with cardnumber In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10667 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #13 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 19:30:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 18:30:48 +0000 Subject: [Koha-bugs] [Bug 10897] t/ILSDI_Services.t is db dependent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10897 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Galen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 20:05:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 19:05:53 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 Barry Cannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barry at oslo.ie --- Comment #2 from Barry Cannon --- Created attachment 22847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22847&action=edit Patch to resolve AllowOnShelfHolds conflict on available items. The 'AllowOnShelfHolds' seems to work to a certain extent. However, when enabled there was an least one case when Koha would allow a hold to be placed on an item that is on the shelf. This seems to stem from the item-level hold feature from the Staff client. A simple example with one bib and two attached items: if both items are on the shelf then the 'AllowOnShelfHolds' restriction would work, disabling the ability to place a hold. However, if one of these items was "checked out" the system would allow a hold to be placed based on the status of the one "checked-out" item. Some libraries may want to force the disabling of holds, via the OPAC, if ANY item is on the shelf. This patch adds a new SystemPref called 'PreventOPACHoldsAnyAvailableItem'. When this is enabled any item that Koha considers on the shelf (excluding withdrawn, lost etc) will be disabled from placing holds at the bib level. When 'PreventOPACHoldsAnyAvailableItem' is off the the original 'AllowOnShelfHolds' preference will enforce the restrictions, as they were. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 20:11:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 19:11:36 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 Barry Cannon changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 20:31:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 19:31:57 +0000 Subject: [Koha-bugs] [Bug 11223] New: Incorrect ind1 semantics for MARC21 785 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11223 Bug ID: 11223 Summary: Incorrect ind1 semantics for MARC21 785 Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: drigney at esilibrary.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The first indicator for MARC21 fields 76x-78x should control whether the entire field displays, not whether the $n subfield displays. To reproduce: view a record that includes a 785 field with indicator 1 set to '1' and the system preference OPACXSLTDetailsDisplay enabled. The 785 field will show up, but according to the standard no display should be generated when 785 indicator 1 is set to '1'. In the MARC21slim2intranetDetail.xsl, MARC21 field 785 are always displayed when present, and indicator 1 is used to determine whether or not to display and 785$n. This was fixed in the opac with bug id 4370. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 21:57:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 20:57:39 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #21 from M. Tompsett --- I think we're good now. I apologize, Srdjan I may not have put up my tweaks. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 22:43:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 21:43:59 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #3 from mathieu saby --- We remarked some problems of performance with biblios having a long list of items attached (serials for ex). Do you think your patch could be usefull for that? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 23:01:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2013 22:01:42 +0000 Subject: [Koha-bugs] [Bug 5296] Advanced item due notices spam patrons with a large number of items checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5296 Peggy Thrasher changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov --- Comment #4 from Peggy Thrasher --- The digest version simply states the number of items that will be due, it doesn't list the titles. So the patron either gets too much email, or too little information. Can we reopen this bug? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 12:46:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 11:46:28 +0000 Subject: [Koha-bugs] [Bug 10918] There should be 2 types of canceled orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10918 --- Comment #1 from mathieu saby --- Now that aqorders have an orderstatus field, we could define a new status "deleted" for orders deleted before the basket is sent to the vendor. This includes orders moved to an other basket (or maybe add a status "moved" for them). Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 14:35:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 13:35:34 +0000 Subject: [Koha-bugs] [Bug 11224] New: C4::Acquisition need more UT, and more robust ones. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11224 Bug ID: 11224 Summary: C4::Acquisition need more UT, and more robust ones. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 14:47:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 13:47:09 +0000 Subject: [Koha-bugs] [Bug 11224] C4::Acquisition need more UT, and more robust ones. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11224 --- Comment #1 from mathieu saby --- Created attachment 22848 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22848&action=edit [PATCH] Bug 11224 : Add UT to subs of C4::Acquisition returning order(s) C4::Acquisition need more UT, and more robust ones. This patch adds UT to - GetOrder - GetOrders - GetCancelledOrders - GetLateOrders It refactors UT for SearchOrders New UT use 2 new subs, used for check the list of fields returns by a sub. _check_fields_of_order _check_fields_of_orders These 2 subs could later be used by other UT _check_fields_of_order has its own UT (tests n?14,15,16). They should maybe be commented after this patch is QAed. to test : prove t/db_dependent/Acquisition.t -v -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 14:47:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 13:47:30 +0000 Subject: [Koha-bugs] [Bug 11224] C4::Acquisition need more UT, and more robust ones. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11224 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 14:48:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 13:48:08 +0000 Subject: [Koha-bugs] [Bug 11224] C4::Acquisition need more UT, and more robust ones. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11224 --- Comment #2 from mathieu saby --- When this patch is pushed, I will provide other bugs for improving C4::Acquisition subs Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 14:48:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 13:48:17 +0000 Subject: [Koha-bugs] [Bug 11224] C4::Acquisition need more UT, and more robust ones. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11224 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mathieu.saby at univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 14:51:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 13:51:11 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #31 from mathieu saby --- In fact, the 1st step is adding UT to current master. Then, I will work again on that bug. See Bug 11224 for new UTs Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 14:52:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 13:52:16 +0000 Subject: [Koha-bugs] [Bug 11206] Factorize code for getting orders in C4::Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206 --- Comment #4 from mathieu saby --- In fact, the 1st step is adding UT to current master. Then, I will maybe work again on that bug, and more surely on bug 10758. Setting this one in discussion See Bug 11224 for new UTs Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 14:52:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 13:52:25 +0000 Subject: [Koha-bugs] [Bug 11206] Factorize code for getting orders in C4::Acquisitions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 16:32:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 15:32:22 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #155 from M. Tompsett --- While we're waiting for a design suggestion to solve the test case I posted, could the original author please rebase his first two signed off patches? Thank you. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 16:33:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 15:33:09 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 --- Comment #11 from mathieu saby --- It is not working well, and most of all, improving the display of rrp and ecost price on invoices is maybe a loss of time. The prices that we MUST have on invoice page are the prices based on unitcost, aka the real cost of the item, entered at receipt stage. Other prices (rrp/ecost could be displayed but they are not needed) What we absolutely need in library is: - unitprice HT - tax on unitprice HT - unitprice TTC - quantity - unitprice TTC * quantity with clear labels on header of table to show at first glance is a price is with or without tax Here are my tests : 1st test : with no/no parameters, and an order for a book costing 100 euros in vendor's catalog (so 100 euros without tax), invoice gives me this : RRP : 100 Est : 90 Total : 90 => OK if RRP and Est are without taxes => KO if RRP and Est are WITH taxes in the bottom of the invoice table, I read that : Total tax exc. 100.00 1 90.00 Tax (5.50%) 5.50 5.50 Total tax inc. (EUR) 105.50 1 105.50 Total + shipment cost (EUR) 1 105.50 As we don't pay taxes, the taxes should not be displayed here. 2d test : with yes/yes parameters, and an order for a book costing 100 euros in vendor's catalog (so 100 euros including tax), invoice gives me this : Invoice details RRP Est. Qty. Total 100 90 1 90 We don't know if RRP and Est are with or without tax => OK if RRP and Est. are WITH tax => KO if RRP and Est. are WITHOUT tax in the bottom of the invoice table, I read that : Total tax exc. 94.79 1 94.79 Tax (5.50%) 5.21 5.21 Total tax inc. (EUR) 100.00 1 90.00 Total + shipment cost (EUR) 1 90.00 The total tax. exc. and the tax are the values calculated on public price (rrp). That's not good, Most of time, we don't need them at all. It could be displayed, but only as an indication, and with clear mention that it is based on RRP price. What we need here is the ecost price without tax. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 16:33:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 15:33:19 +0000 Subject: [Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 16:45:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 15:45:53 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle.m.hall at gmail.com |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 16:48:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 15:48:21 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #11 from mathieu saby --- I misread bug's status. It was not assigned. I take it and will propose a patch. For me some info about items and biblio MUST be recorded in this table. Because item location (like patron category) can change over time. The case occured in my library network (books moved from one library to one other), and it was complicated to get the original location. Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 16:54:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 15:54:21 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 --- Comment #12 from mathieu saby --- I will add for the item : - holdingbranch - homebranch - callnumber - location - dateaccessioned for the borrower - categorycode - branchcode - sex - sort1 - sort2 for the record - biblioitems.itemtype (as document_type) - biblio.serial Other interesting fields could be items.barcode items.price items.replacementprice items.issues items.renewal biblio.title biblio.author biblio.publicationyear biblio.publishercode and extended attributes of patrons Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 17:32:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 16:32:15 +0000 Subject: [Koha-bugs] [Bug 11205] The datatables filters don't work when several tables exist In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #10 from Galen Charlton --- Pushed to master and 3.14.x. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 20:30:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 19:30:59 +0000 Subject: [Koha-bugs] [Bug 11225] New: \n in translation strings should be removed Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 Bug ID: 11225 Summary: \n in translation strings should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Some strings in the serials module contain linebreaks \n that cause problems in translation. Example: "Cannot test prediction pattern for the following reason(s):\\n \\n -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 20:40:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 19:40:46 +0000 Subject: [Koha-bugs] [Bug 11226] New: Working with serials now requires admin (parameters) permission Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Bug ID: 11226 Summary: Working with serials now requires admin (parameters) permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Only staff with 'parameters' (administration module) permission can add new frequencies and numbering patterns. This makes it necessary to give serials librarians full permissions to the administration module. Serials permissions should be handled separately. Also, the links to manage frequencies and numbering patterns still show, when you don't have the appropriate permissions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 20:41:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 19:41:04 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7688 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 20:41:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 19:41:04 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11226 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 20:41:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 19:41:20 +0000 Subject: [Koha-bugs] [Bug 11225] \n in translation strings should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7688 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 20:41:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 19:41:20 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11225 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 20:54:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 19:54:41 +0000 Subject: [Koha-bugs] [Bug 11227] New: Staff po files contain lots of Javascript Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Bug ID: 11227 Summary: Staff po files contain lots of Javascript Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr The new staff po files contain a lot of Javascript strings: Example: authorities_js.inc "function mergeAuth(authid, summary) { var alreadySelected = $.cookie('auth_to_merge'); if (alreadySelected !== null) { alreadySelected = JSON.parse(alreadySelected); $.cookie('auth_to_merge', '', { 'path': '/', 'expires': -1 }); var refstring = \"\"; if (typeof alreadySelected.mergereference !== 'undefined') { refstring = \"&mergereference=\" + alreadySelected.mergereference; } window.location.href = \"/cgi-bin/koha/authorities/merge.pl?authid=\" + authid + \"&authid=\" + alreadySelected.authid + refstring; } else { $.cookie('auth_to_merge', JSON.stringify({ 'authid': authid, 'summary': summary }), { 'path' : '/' }); showMergingInProgress(); } } function showMergingInProgress() { var alreadySelected = $.cookie('auth_to_merge'); if (alreadySelected !== null) { alreadySelected = JSON.parse(alreadySelected); $('#merge_in_progress').html(_(\"Merging with authority: \") + \"" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 20:58:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 19:58:47 +0000 Subject: [Koha-bugs] [Bug 11227] Staff po files contain some Javascript In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11227 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Staff po files contain lots |Staff po files contain some |of Javascript |Javascript -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 22:49:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 21:49:34 +0000 Subject: [Koha-bugs] [Bug 11228] New: Explanation on 'patron notification' is not quite right Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11228 Bug ID: 11228 Summary: Explanation on 'patron notification' is not quite right Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Created attachment 22849 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22849&action=edit Screenshot of subscription add form The subscription details form states as explanation for the patron notifications pull down: "Select a notice and patrons on the routing list will be notified when new issues are received." This is not quite right, as the notices will only be sent out when you have subscribed to them from the OPAC. The routing list patrons won't receive the notice unless they have subscribed before. In that context the notices template named RLIST should be renamed too, so this is less confusing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 22:50:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 21:50:48 +0000 Subject: [Koha-bugs] [Bug 11229] New: Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Bug ID: 11229 Summary: Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com C4::Accounts::makepartialpayment save the transaction in statistics table, by calling UpdateStats. The fist given param is "$user". It should be "$branch" M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 23:09:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 22:09:58 +0000 Subject: [Koha-bugs] [Bug 11229] Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #1 from mathieu saby --- Same issue in makepartialpayment. Both subs are called by members/paycollect.pl We don't use fines, so I don't know if the branch to save is the homebranch of the user, or of the librarian. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 23:10:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 22:10:52 +0000 Subject: [Koha-bugs] [Bug 11229] Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #2 from mathieu saby --- I meant "makepayment" ;-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 23:11:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2013 22:11:04 +0000 Subject: [Koha-bugs] [Bug 11229] Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment and makepayment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Payments wrongly saved in |Payments wrongly saved in |Statistics table by |Statistics table by |C4::Accounts::makepartialpa |C4::Accounts::makepartialpa |yment |yment and makepayment -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 16:23:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 15:23:11 +0000 Subject: [Koha-bugs] [Bug 11230] New: Refactor C4::Stats::UpdateStats and add UT Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 Bug ID: 11230 Summary: Refactor C4::Stats::UpdateStats and add UT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com I am not sure of the right Component for this bug. I want to improve Statistics recording (adding some new fields, adding custom fields, etc). The first preliminary step is in this patch, which improves current code. An other patch will provide new features. This patch - refactors C4::Stats::UpdateStats (it now takes a hashref as unique parameter, instead of a list of parameters) - add UT for it - change the calls made to this sub in C4::Accounts and C4::Circulation Also : - adds POD to C4::Stats::TotalPaid - adds some comments to C4::Stats::TotalPaid (I think I found some errors in it) M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 16:23:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 15:23:36 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |mathieu.saby at univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 16:23:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 15:23:44 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 16:34:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 15:34:49 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 --- Comment #1 from mathieu saby --- Created attachment 22850 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22850&action=edit [PATCH] Bug 11230 - Refactor C4::Stats::UpdateStats and add UT This patch - refactors C4::Stats::UpdateStats (it now takes a hashref as unique parameter, instead of a list of parameters) - add UT for it - change the calls made to this sub in C4::Accounts and C4::Circulation Additionnaly it also - adds POD to C4::Stats::TotalPaid - adds some comments to C4::Stats::TotalPaid (I think I found some errors in it) To test : 1. run "prove t/db_dependant/Stats.t -v" 2. make some circulation operations (checkout, checkin, renew, localuse) check the operations are rightly recorded in Statistics table (with a SQL query like "SELECT * FROM statistics WHERE datetime LIKE "2013-11-15%", if you run your test on the 15th november) 3. make some fine payments operations (writeoff, payment) check the operations are rightly recorded in Statistics table (with a SQL query like "SELECT * FROM statistics WHERE datetime LIKE "2013-11-15%", if you run your test on the 15th november) Note that there is probably an issue to fix in Accounts.pm : the user is saved instead of the branch. But this is not the purpose of this patch, so I kept the previous behavior for the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 16:34:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 15:34:59 +0000 Subject: [Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 20:56:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 19:56:07 +0000 Subject: [Koha-bugs] [Bug 11231] New: notes should be reservenotes in pendingreserves.pl and reserveratios.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11231 Bug ID: 11231 Summary: notes should be reservenotes in pendingreserves.pl and reserveratios.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com In pendingreserves.pl and reserveratios.pl there is SQL query returning "notes". The only notes field in the query are from biblio and biblioitems table. I suppose the expected result is the note about the reserve. It is in "reserves.reservenote" M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 22:35:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 21:35:36 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #20 from Doug Kingston --- As noted in chat, these patches are built on those for bug 6435 on which this bug depends. Can you test these 2 together? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 22:38:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 21:38:20 +0000 Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #44 from Doug Kingston --- I addressed the recent QA issue on 10/28 with the updated patch. Can this be re-reviewed? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 22:59:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 21:59:11 +0000 Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 22:59:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 21:59:16 +0000 Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22457|0 |1 is obsolete| | --- Comment #45 from Chris Cormack --- Created attachment 22851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22851&action=edit Bug 6435 Add daemon mode to rebuild_zebra.pl This change adds code to check the zebraqueue table with a cheap SQL query and a daemon loop that checks for new entries and processes them incremantally before sleeping for a controllable number of seconds. The default is 5 seconds which provides a near realtime search index update. This is desirable particularly for libraries that are doing active catalogue updating. The query is adjusted based on whether -a, -b, or -a -b are specified. Help text updated. Tested against a live 3.12 system. Note that this fix will benefit from the fix to lack of locking (bug 11078) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 23:55:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 22:55:14 +0000 Subject: [Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 23:55:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 22:55:33 +0000 Subject: [Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 23:55:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 22:55:37 +0000 Subject: [Koha-bugs] [Bug 11040] Add option to print regular slip to CircAutoPrintQuickSlip In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11040 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22798|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 22852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22852&action=edit Bug 11040 Add option to print regular slip to CircAutoPrintQuickSlip Test plan: 1. Set the System Preference for CircAutoPrintQuickSlip to "clear the screen". Enter a borrower barcode for checkout Press Enter The screen should be cleared. 2. Set the System Preference for CircCircAutoPrintQuickSlip to "open a quick slip window" Enter a borrower barcode for checkout Press Enter A Quick slip is printed. 3. Apply the patch Update the database using UpdateDatabase.pl 4. Set the System Preference for CircAutoPrintQuickSlip to "clear the screen". Enter a borrower barcode for checkout Press Enter The screen should be cleared. 5. Set the System Preference for CircCircAutoPrintQuickSlip to "open a quick slip window" Enter a borrower barcode for checkout Press Enter A Quick slip is printed. 6. Set the System Preference for CircCircAutoPrintQuickSlip to "open a slip window" Enter a borrower barcode for checkout Press Enter A Slip is printed. 7. Reload the database using sysprefs.sql Set the System Preference for CircAutoPrintQuickSlip to "clear the screen". Enter a borrower barcode for checkout Press Enter The screen should be cleared. 8. Set the System Preference for CircCircAutoPrintQuickSlip to "open a quick slip window" Enter a borrower barcode for checkout Press Enter A Quick slip is printed. 9. Set the System Preference for CircCircAutoPrintQuickSlip to "open a slip window" Enter a borrower barcode for checkout Press Enter A Slip is printed. 10. Verify that the Checkout Help includes information about printing Slips. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 00:01:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 23:01:35 +0000 Subject: [Koha-bugs] [Bug 5296] Advanced item due notices spam patrons with a large number of items checked out In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5296 --- Comment #5 from Katrin Fischer --- Hi Peggy, you can list item information in the digests too - I think by using <>. I know we do it, but can't check the templates right now. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 00:08:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 23:08:16 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #4 from Srdjan Jankovic --- I believe that's exactly where it shows most benefits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 00:09:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 23:09:48 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #22 from Srdjan Jankovic --- No worries mate :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 00:13:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 23:13:00 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #23 from Tom?s Cohen Arazi --- (In reply to Srdjan Jankovic from comment #22) > No worries mate :) +1, I thought my signed-by-Petter patch was enough :-D, I welcome anything that makes this warnings away. I'm already focused in other stuff right now :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 00:15:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2013 23:15:38 +0000 Subject: [Koha-bugs] [Bug 10825] detail.tt displays duplicated enumchron values for serial items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10825 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |liz at catalyst.net.nz --- Comment #10 from Liz Rea --- I am actually seeing this bug - will get test data that can replicate to test the patch. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 01:13:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 00:13:13 +0000 Subject: [Koha-bugs] [Bug 11232] New: Retrieve facets from Zebra Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 Bug ID: 11232 Summary: Retrieve facets from Zebra Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org At Kohacon, a few of us (Jared, Paul P, Tomas, myself, and possibly others) looked at using Zebra's native facetting. After a bit of trial and error, in the final 15 minutes of the hackfest, we were able to get it working using queries in YAZ(high fives all around), but I'm not sure if anyone has followed up on that work (as I've been on holiday). I don't see any existing bug reports for adding this functionality to Koha, but I think it would be preferable to how we build facets at the moment (hence this bug). This method should be: 1) faster (since it is pulling the facets from the search results using indexes rather than iterating through every record); 2) more comprehensive (it is based on the full result set and not just the first 50 or so results [depending on your sysprefs]); 3) able to build facets for control fields and the leader (since it pulls data using indexes, we should be able to easily build facets for publication year, record type, etc.). In terms of customizability (bug 10891), it might be more difficult to change on the fly. This is because we need to explicitly define each facet index in our configuration files for Zebra. I'll need to look over my notes and do a few more experiments, but I'm quite certain this is the case. While we could add a mechanism for allowing users to specify which facets to retrieve and display (probably a good idea), we couldn't do the same for the static XML config file. So we would need to either include all the indexes in the XML config file or mark it as a place for local changes. I'm not sure about the cost/benefit of telling Zebra that every index could be used as a facet. I don't imagine it would be too much of a cost though, since the list of facets would be fed to Zebra on start up and not runtime. -- As I said, I'm not sure if anyone is working on the native facetting at the moment. I would like to but I'll have to look at my workload and chat to my boss. I'll be happy to post my notes in a comment tomorrow on how to get it to work. The config is slightly different for DOM and GRS1 but it works well for both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 01:51:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 00:51:54 +0000 Subject: [Koha-bugs] [Bug 10753] Creating suggestions for 'Any library' uses _ANY as branchcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10753 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz --- Comment #1 from Liz Rea --- Should we add a branch at install, that is the equivalent of any in the code, that cannot be deleted? Basically a shadow branch, just for this purpose? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 02:37:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 01:37:37 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 02:37:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 01:37:40 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22810|0 |1 is obsolete| | --- Comment #7 from Srdjan Jankovic --- Created attachment 22853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22853&action=edit bug_11183: get rid of some warninngs To test in OPAC: * Set EnableOpacSearchHistory to yes (Keep). Do an advanced search with limits. Complete search with limits should show. * Have an item with Collection Code. Check that the Collection Code shows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 02:53:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 01:53:17 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22844|0 |1 is obsolete| | --- Comment #24 from M. Tompsett --- Created attachment 22854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22854&action=edit Bug 11077 - Correct silent warnings in C4/Auth.pm This patch corrects a noisy ne condition. $userid = $retuserid if ( $retuserid ne ''); became $userid = $retuserid if ( $retuserid ); It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's patch, while correcting the problems found. This includes: my $q_userid = $query->param('userid') // ''; along with: my $s_userid = ''; and: my $s_userid = $session->param('id') // ''; Indentation does not reflect actual scoping. And the 'None' is changed to '', since that behaves properly in the undef case: my $pki_field = C4::Context->preference('AllowPKIAuth') // ''; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 03:50:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 02:50:23 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22853|0 |1 is obsolete| | --- Comment #8 from Srdjan Jankovic --- Created attachment 22855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22855&action=edit bug_11183: get rid of some warninngs To test in OPAC: * Set EnableOpacSearchHistory to yes (Keep). Do an advanced search with limits. Complete search with limits should show. * Have an item with Collection Code. Check that the Collection Code shows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 04:05:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 03:05:58 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #9 from M. Tompsett --- This is how I tested it: mtompset at ubuntu:~/kohaclone$ git reset --hard origin/master HEAD is now at 0d5f73d Merge branch 'new/bug11205' mtompset at ubuntu:~/kohaclone$ echo > ~/koha-dev/var/log/koha-opac-error_log #### I then did a simple search 'unhappy' #### and then clicked an entry know to not have the collection code set. mtompset at ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut -c85- | sort -u opac-detail.pl: Use of uninitialized value $ccode in exists at /home/mtompset/kohaclone/opac/opac-detail.pl line 576., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-search.pl?idx=&q=unhappy&branch_group_limit= opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=14206&query_desc=kw%2Cwrdl%3A%20happy%20life opac-search.pl: Use of uninitialized value $limit_desc in concatenation (.) or string at /home/mtompset/kohaclone/opac/opac-search.pl line 626., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=14206&query_desc=kw%2Cwrdl%3A%20happy%20life mtompset at ubuntu:~/kohaclone$ git bz apply 11183 Bug 11183 - Warnings in opac 22855 - bug_11183: get rid of some warninngs Apply? [(y)es, (n)o, (i)nteractive] y Applying: bug_11183: get rid of some warninngs mtompset at ubuntu:~/kohaclone$ echo > ~/koha-dev/var/log/koha-opac-error_log #### I then did a simple search 'unhappy' #### and then clicked an entry know to not have the collection code set. mtompset at ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut -c85- | sort -u opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=13896&query_desc=kw%2Cwrdl%3A%20unhappy mtompset at ubuntu:~/kohaclone$ Sorry, gmcharlt. I found a bug in MARC::Field. ;) But not this. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 04:11:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 03:11:03 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #10 from M. Tompsett --- Created attachment 22856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22856&action=edit [SIGNED OFF] bug_11183: get rid of some warnings To test in OPAC: * With the OPAC System Preference EnableOpacSearchHistory set to Keep, a simple search triggers the warning patched on line 626 of opac-search.pl * Selecting a search result item with no Collection Code set triggers the warning patched on line 576 of opac-detail.pl * Have an item with Collection Code. Check that the Collection Code shows. * Collection Code is set by editing an item in the staff client (952$8) Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 04:12:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 03:12:06 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22855|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 04:12:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 03:12:22 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22839|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 05:26:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 04:26:22 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #11 from M. Tompsett --- Okay, the 314 warning bugged me enough, and I hunted it down to line 1838 of the master's C4/Search.pm, which I will add a second patch to this, as the test case triggered the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 05:31:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 04:31:25 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #12 from M. Tompsett --- Created attachment 22857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22857&action=edit Bug 11183 - Warnings in opac This may affect staff as well. During testing of Srdjan Jankovic's patch, the following error message was triggered: opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314. This was traced to a bad call on subfields in C4::Search. By adding an if check around the call, this warning is no longer triggered. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 05:31:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 04:31:36 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #13 from Srdjan Jankovic --- I did something with Search.pm too on a different bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 05:49:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 04:49:23 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #14 from M. Tompsett --- The test plan is as given on the original patch: To test in OPAC: * With the OPAC System Preference EnableOpacSearchHistory set to Keep, a simple search triggers the warning patched on line 626 of opac-search.pl * Selecting a search result item with no Collection Code set triggers the warning patched on line 576 of opac-detail.pl * Have an item with Collection Code. Check that the Collection Code shows. * Collection Code is set by editing an item in the staff client (952$8) I happen to have two items with unhappy in the title, and so I gave one a collection code, while the other did not have one. 1) Search for unhappy in OPAC 2) Click link 1 3) Browser back 4) Click line 2 These steps are between the clearing of the error log and the viewing unique errors in the error log. The results of my testing: mtompset at ubuntu:~/kohaclone$ git reset --hard origin/master HEAD is now at 0d5f73d Merge branch 'new/bug11205' mtompset at ubuntu:~/kohaclone$ echo > ~/koha-dev/var/log/koha-opac-error_log mtompset at ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut -c85- | sort -u opac-detail.pl: Use of uninitialized value $ccode in exists at /home/mtompset/kohaclone/opac/opac-detail.pl line 576., referer: http://demo.library.kohasystem.ca/cgi-bin/koha/opac-search.pl?idx=&q=unhappy&branch_group_limit= opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314., referer: http://demo.library.kohasystem.ca/ opac-search.pl: Use of uninitialized value $limit_desc in concatenation (.) or string at /home/mtompset/kohaclone/opac/opac-search.pl line 626., referer: http://demo.library.kohasystem.ca/ mtompset at ubuntu:~/kohaclone$ git bz apply 11183 Bug 11183 - Warnings in opac 22856 - [SIGNED OFF] bug_11183: get rid of some warnings 22857 - Bug 11183 - Warnings in opac Apply? [(y)es, (n)o, (i)nteractive] y Applying: bug_11183: get rid of some warnings Applying: Bug 11183 - Warnings in opac mtompset at ubuntu:~/kohaclone$ echo > ~/koha-dev/var/log/koha-opac-error_log mtompset at ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut -c85- | sort -u mtompset at ubuntu:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 06:43:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 05:43:04 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |srdjan at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 06:44:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 05:44:13 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 06:44:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 05:44:42 +0000 Subject: [Koha-bugs] [Bug 11184] Fix wrong attribute type cloning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11184 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |srdjan at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 06:47:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 05:47:38 +0000 Subject: [Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |srdjan at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 07:55:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 06:55:40 +0000 Subject: [Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 --- Comment #2 from M. Tompsett --- Created attachment 22858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22858&action=edit [SIGNED OFF] bug_11196: put SearchEngine to sysprefs.sql Test: Check that sysprefs.sql runs correctly. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 07:55:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 06:55:59 +0000 Subject: [Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22678|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 08:11:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 07:11:46 +0000 Subject: [Koha-bugs] [Bug 11233] New: testing development Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11233 Bug ID: 11233 Summary: testing development Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt at gmail.com Reporter: vishal.patil at osslabs.biz QA Contact: testopia at bugs.koha-community.org creating patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 08:18:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 07:18:38 +0000 Subject: [Koha-bugs] [Bug 11233] testing development In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11233 vishal changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|All |PC OS|All |Linux -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 08:32:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 07:32:50 +0000 Subject: [Koha-bugs] [Bug 11196] SearchEngine pref not in sysprefs.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11196 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from M. Tompsett --- I dropped my koha database, and did a fresh install from master. Indeed it was missing. I changed the version number back to 3.6000000 in the systempreferences table and forced an upgrade. Lo and behold it appeared. I dropped my koha database again, applied the patch, and did a fresh install again. This time the system preference was there as expected. I even discovered Frameworksloaded, marcflavor, and Version are all created by the installer, when I deleted everything in the system preferences table and sourced the sql file directly. It was disorienting to see that the variable count had dropped. No worries, though. This all was a test system. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 09:47:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 08:47:42 +0000 Subject: [Koha-bugs] [Bug 9490] Show responsibility statement (245c) under title and move authors down in OPAC XSLT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9490 --- Comment #7 from M. de Rooy --- Saving a response from the dev list here: Is Bug 9490 - "Show responsibility statement (245c) under title and move authors down in OPAC XSLT" the best (only?) way to go? Or is there a "quick" (js?) way to show MARC 245$s (statement of responsibility) in the OPAC "normal view"? [Koha 3.8.5] It's a request from our cataloguers who held a "Koha workshop" with a number of users (university profs and students) earlier this week. Marcel's proposal seems to fit the requirement perfectly. Thanks and br, Paul A -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 10:23:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 09:23:56 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #5 from mathieu saby --- Some remarks about GetItemsInfo () : There are 5 SELECT. I suppose it would be better for performance to have a unique SELECT. And the last SELECT gets some informations which are not usefull in normal OPAC and staff display : It is used for finding the last 3 people who borrowed this item. Don't you think geting the info about the 3 last ppl who borrowed the item should be made optional (by adding a param to GetItemsInfo) ? M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 10:28:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 09:28:00 +0000 Subject: [Koha-bugs] [Bug 11234] New: Is returning biblioitems.marc field in C4::Biblio subs really necessary? Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11234 Bug ID: 11234 Summary: Is returning biblioitems.marc field in C4::Biblio subs really necessary? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org Most subs of C4::Biblio subs are returning raw MARC data from biblioitems.marc field. It's bad for performances and I don't think it id really necessary, except in a few cases (exporting records?). M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 11:18:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 10:18:33 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |z.tajoli at cineca.it Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 12:07:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 11:07:34 +0000 Subject: [Koha-bugs] [Bug 11235] New: Names for reports cut off when quotes are used Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11235 Bug ID: 11235 Summary: Names for reports cut off when quotes are used Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org If you use quotes in your report name, the report name is cut off just before the quotes. My example was: Benutzer mit "fehlgeschlagenen" Benachrichtigungen (Patrons with 'failed' notices). The report name saved as: Benutze mit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 12:10:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 11:10:45 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha.sekjal at gmail.com |barry at oslo.ie -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 12:54:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 11:54:40 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 12:59:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 11:59:53 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #1 from mathieu saby --- Hi Well, I will wait to see some patch attached here to know if bug 10891 should be closed, or maybe rethink on a different base (maybe just to hide unwanted facets, and not providing a real customization for example). Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:00:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 12:00:55 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 --- Comment #23 from mathieu saby --- I will wait to see some patch attached to bug 11232. It could make a big conflict with this one. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:09:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 12:09:01 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #2 from mathieu saby --- > > I'm not sure about the cost/benefit of telling Zebra that every index could > be used as a facet. I don't imagine it would be too much of a cost though, > since the list of facets would be fed to Zebra on start up and not runtime. Of course ;-) Just take a look at some library or bookseller's websites. Most fields must NOT be used as facets. For me facets should made on : - availability (make a distinction between items notforloan, items on loan, items available for loan) - date (on coded fields) - language - language of original material (for translations) - subject (with facets based on subfields of 6XX, not on complete fields : a facet for topic subjects, a facet for chronological, a facet for geographical etc) - type of document and carriage (various fields and coded fields in MARC21 and UNIMARC) - coded informations in 0XX MARC21 and 1XX UNIMARC fields - coded informations in label - authors and maybe titles, and series Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:09:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 12:09:34 +0000 Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:09:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 12:09:38 +0000 Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22851|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize --- Created attachment 22859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22859&action=edit Bug 6435 Add daemon mode to rebuild_zebra.pl This change adds code to check the zebraqueue table with a cheap SQL query and a daemon loop that checks for new entries and processes them incremantally before sleeping for a controllable number of seconds. The default is 5 seconds which provides a near realtime search index update. This is desirable particularly for libraries that are doing active catalogue updating. The query is adjusted based on whether -a, -b, or -a -b are specified. Help text updated. Tested against a live 3.12 system. Note that this fix will benefit from the fix to lack of locking (bug 11078) Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:14:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 12:14:43 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 --- Comment #3 from mathieu saby --- Note that there is currently a big issue for UNIMARC facets: the facet build on type of document (equivalent of 942 in MARC21) is not visible. That's because some libraries use 099$t for that, and others use other fields like 210$b that are not made for that. That was the main goal of my not-yet-written-patch for make facets customisable... But maybe it could be fixed by telling UNIMARC ppl that from 3.16 version onwards the type of document is stored in 099t, and provide a script for copying types of documents from other fields to this one for non standard configuration. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:00:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 13:00:37 +0000 Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #47 from Martin Renvoize --- I'm up and down on passing this one.. discussed it with Katrin.. 1. Passes QA script (after I fixed some minor white space errors - Doug, please take a look at http://blog.bigballofwax.co.nz/2011/12/15/fixing-whitespace-when-apply-patches-with-git/ to stop these in their tracks before they hit QA with future patches ;) ) 2. Tested with various combinations of options: -a -daemon, -b -daemon, -a -b -daemon, -a -b -x -daemon, all worked as expected along with not breaking existing options. One niggle worth discussing: The intention of this patch is clear, to allow regular rebuilds as a daemon.. However, the patch allows all/any params to be passed along with the daemon mode. This slightly scares me as it becomes rather easy to break the system using the wrong combination of options. (for instance, running with -r would mean that every time a catalogue update happens, the zebra index disappears moments later whilst a full rebuild is happening) I don't think it's a QA fail, but it may be worth documenting that certain options don't work well with a daemon model. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:00:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 13:00:48 +0000 Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:05:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 13:05:36 +0000 Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 --- Comment #48 from Martin Renvoize --- Follow-up note 1: I also tested the -sleep option and it worked well. Follow-up note 2: As an afterthought, should the -z be implied by daemon mode? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:33:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 14:33:59 +0000 Subject: [Koha-bugs] [Bug 11233] testing development In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11233 --- Comment #1 from Owen Leonard --- Is this a real bug report? If so, please make the title accurate and add a description. If it isn't a real bug report please mark it "resolved invalid." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:40:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 14:40:46 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:40:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 14:40:49 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22107|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 22860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22860&action=edit MT8122: Adds Shibboleth authentication - Use the shibbolethAuthentication syspref to enable Shibboleth authentication - Configure the shibbolethLoginAttribute to specify which shibboleth user attribute matches the koha login - Make sure the OPACBaseURL is correctly set MT8122, Follow-up: Adds Shibboleth authentication - Fix logout bug: shibboleth logout now occurs only when the session is a shibboleth one. - Do some refactoring: getting shibboleth username is now done in C4::Auth_with_Shibboleth.pm (get_login_shib function) MT8122, Follow-up: Adds Shibboleth authentication - Adds redirect to opac after logout MT8122, Follow-up: Adds Shibboleth authentication - Shibboleth is not compatible with basic http authentication in C4/Auth.pm. This patch fixes that. MT8122, Follow-up: Adds Shibboleth authentication - Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with multiple vhosts. MT8122, Follow-up: Adds Shibboleth authentication - Adds missing protocol for $ENV{'SERVER_NAME'} Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:43:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 14:43:28 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #15 from Martin Renvoize --- As suggested by Matthias I have updated the patch to use C4::Context->preference('OPACBaseURL') in place of $ENV{SERVER_NAME} within the Auth_with_Shibboleth script. This seems to work in my testing, though I didn't know how to reproduce the issue Matthias highlights so couldn't test that it actually fixes the issue. Setting back to 'Needs Signoff' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:54:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 14:54:07 +0000 Subject: [Koha-bugs] [Bug 10876] Fix opac-MARCdetail.pl partial hides In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10876 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10584 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:54:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 14:54:07 +0000 Subject: [Koha-bugs] [Bug 10584] Hide OPAC bibilo details if all items are hidden. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10584 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10876 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:00:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 15:00:24 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:13:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 15:13:12 +0000 Subject: [Koha-bugs] [Bug 10872] C4::Items GetHiddenItems fix and optimization In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10872 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:13:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 15:13:40 +0000 Subject: [Koha-bugs] [Bug 10731] IntranetSlipPrinterJS is not working for hold slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10731 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #11 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:14:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 15:14:08 +0000 Subject: [Koha-bugs] [Bug 10376] Printing cart does not work under IE9 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10376 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #9 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:14:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 15:14:48 +0000 Subject: [Koha-bugs] [Bug 10894] ID required for mainaddress fieldset in create new patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10894 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #5 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks David! Congratulations for your first commit! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:15:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 15:15:25 +0000 Subject: [Koha-bugs] [Bug 10871] Confirmation message for deleting news entries is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10871 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- This patch has been pushed to 3.12.x, will be in 3.12.7. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 17:09:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 16:09:48 +0000 Subject: [Koha-bugs] [Bug 8064] Merge several biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Paola Rossi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #29 from Paola Rossi --- Against master 3.13.00.042, updatedatabase.pl needs to be rebased. So I pass the patch to "Failed QA" status. If I install marc21, then 001/003/005/008 are always required by koha; The four fields are displayed and are unchecked, but they are not selectable in any way. So I can't merge the records in any way. If I install unimarc, I can merge. If a mandatory field of a merging record is unchecked by user, and it isn't a repeatable field, the user can't add it in any way: koha says "The field is non-repeatable and already exists in the destination record. Therefore, you cannot add it.". Now I can copy the LAST field of a merging record to the destination record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 19:08:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 18:08:13 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #81 from Nicole C. Engard --- There was a patch for those - http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22372&action=diff it says it was pushed. Do I need to do it again? Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 19:29:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 18:29:55 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|News by Library |News by Library: refactor, | |enhance, and fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:36:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 19:36:03 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:36:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 19:36:35 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:37:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 19:37:00 +0000 Subject: [Koha-bugs] [Bug 10865] Don't show list permissions when adding public lists/sharing lists is not allowed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10865 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:39:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 19:39:22 +0000 Subject: [Koha-bugs] [Bug 10877] Add "Order Record" processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:40:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 19:40:35 +0000 Subject: [Koha-bugs] [Bug 10881] Fast Add Framework has different item fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10881 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #1 from Nicole C. Engard --- Nonpublic notes never show during check in - even if they're on a framework other than the fast add. The fast add should have a different item form since it's a different framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:51:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 19:51:32 +0000 Subject: [Koha-bugs] [Bug 10891] Make facets customisable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10891 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:54:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 19:54:22 +0000 Subject: [Koha-bugs] [Bug 10907] Showing the staff members name who managed a suggestion should be optional In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10907 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:59:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 19:59:46 +0000 Subject: [Koha-bugs] [Bug 10928] Acq Note does not appear when receiving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10928 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 21:04:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 20:04:12 +0000 Subject: [Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 21:11:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 20:11:30 +0000 Subject: [Koha-bugs] [Bug 10963] Simplified creation of MARC21 sample frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10963 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 21:14:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 20:14:05 +0000 Subject: [Koha-bugs] [Bug 10215] Increase the size of opacnote and librariannote for table subscriptionhistory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10215 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 21:15:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 20:15:19 +0000 Subject: [Koha-bugs] [Bug 7728] subscription endddate is copied into subscription history histendate field during renew process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 21:50:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 20:50:15 +0000 Subject: [Koha-bugs] [Bug 11067] In serial home instead of 'Advanced search' on sx column it is better 'Filters on search results' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11067 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 22:27:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 21:27:43 +0000 Subject: [Koha-bugs] [Bug 10928] Acq Note does not appear when receiving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10928 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |mathieu.saby at univ-rennes2.f |ity.org |r --- Comment #1 from mathieu saby --- Created attachment 22861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22861&action=edit Bug 10928 - Make orders note visible when receiving an order notes field is used in biblio table as well as in aqorders table, so results are messed up. The SQL query in C4:Acquisitions:SearchOrders must be changed. This is also the case for timestamp field. This patch change C4:Acquisitions:SearchOrders: - biblio.* is replaced with all fields of biblio table - except for notes, returned as biblionotes and tilmestamp as bibliotimestamp Further improvements could be made later (as suppressing useless biblio.fields from the query). To test : create an order with an order note receive this order, and check the order note is visible in the textarea dedicated to that purpose -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 22:28:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 21:28:34 +0000 Subject: [Koha-bugs] [Bug 10928] Acq Note does not appear when receiving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10928 --- Comment #2 from mathieu saby --- Nicole, I see you add yourself to this bug. I made a little patch for it. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 22:30:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 21:30:09 +0000 Subject: [Koha-bugs] [Bug 10928] Acq Note does not appear when receiving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10928 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 22:30:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 21:30:49 +0000 Subject: [Koha-bugs] [Bug 8950] Patron Card Creator_Background Image and barcode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8950 --- Comment #1 from sophina0516 at gmail.com --- For the image, there is a way to change the display height, just wondering is there a way to adjust the barcode size too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 22:47:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 21:47:41 +0000 Subject: [Koha-bugs] [Bug 11232] Retrieve facets from Zebra In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11232 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 22:57:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 21:57:14 +0000 Subject: [Koha-bugs] [Bug 7728] subscription endddate is copied into subscription history histendate field during renew process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7728 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #1 from mathieu saby --- Hello Lyon3 We will soon renew subscriptions for next year. Can you tell me if it is still an issue? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 23:03:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2013 22:03:12 +0000 Subject: [Koha-bugs] [Bug 8876] branch not always stored in the stats table for payments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8876 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #3 from mathieu saby --- Hi I think it is a duplicate of bug 11229. Can you confirm that? Mathieu -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 01:11:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 00:11:14 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #6 from Srdjan Jankovic --- I totally agree, and I may go there in some other bug report. I'll just say that at this stage 5 calls are better than 10. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 01:23:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 00:23:33 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 01:23:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 00:23:35 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22857|0 |1 is obsolete| | --- Comment #15 from Srdjan Jankovic --- Created attachment 22862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22862&action=edit [SIGNED-OFF] Bug 11183 - Warnings in opac This may affect staff as well. During testing of Srdjan Jankovic's patch, the following error message was triggered: opac-search.pl: Use of uninitialized value $code_wanted in string eq at /usr/share/perl5/MARC/Field.pm line 314. This was traced to a bad call on subfields in C4::Search. By adding an if check around the call, this warning is no longer triggered. Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 06:46:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 05:46:04 +0000 Subject: [Koha-bugs] [Bug 7567] News by Library: refactor, enhance, and fix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 --- Comment #3 from M. Tompsett --- Created attachment 22863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22863&action=edit Bug 7567 - News by Branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 08:01:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 07:01:28 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22662|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic --- Created attachment 22864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22864&action=edit bug_11182: get rid of some warnings To test - circulation: * For a child patron, check that "Upgrade to adult" link on the "More" drop-down is clickable * Set sys pref FineNotifyAtCheckin to yes (Notify), and check in an overdue item that attracts fine. Fine amount should be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 08:15:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 07:15:51 +0000 Subject: [Koha-bugs] [Bug 11182] Warnings in circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11182 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22864|0 |1 is obsolete| | --- Comment #3 from Srdjan Jankovic --- Created attachment 22865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22865&action=edit bug_11182: get rid of some warnings To test - circulation: * For a child patron, check that "Upgrade to adult" link on the "More" drop-down is clickable * Set sys pref FineNotifyAtCheckin to yes (Notify), and check in an overdue item that attracts fine. Fine amount should be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 08:59:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 07:59:07 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 08:59:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 07:59:10 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #16 from Srdjan Jankovic --- Created attachment 22866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22866&action=edit bug_11183: Supress undef warning in opac-MARCdetail.pl To test: * Go to /cgi-bin/koha/opac-MARCdetail.pl?biblionumber= and confirm that pre and post patch page looks the same. An apology: I tried to find a syspref combination that displays opac-MARCdetail.pl links in OPAC search results, and failed. If anyone knows, the secret combination, please disclose. I resorted to entering the url by hand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:07:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 08:07:25 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22866|0 |1 is obsolete| | --- Comment #17 from Srdjan Jankovic --- Created attachment 22867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22867&action=edit bug_11183: Supress undef warning in opac-MARCdetail.pl To test: * Go to /cgi-bin/koha/opac-MARCdetail.pl?biblionumber= and confirm that pre and post patch page looks the same. An apology: I tried to find a syspref combination that displays opac-MARCdetail.pl links in OPAC search results, and failed. If anyone knows, the secret combination, please disclose. I resorted to entering the url by hand. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:26:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 08:26:44 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #7 from mathieu saby --- (In reply to Srdjan Jankovic from comment #6) > I totally agree, and I may go there in some other bug report. Good idea! And I'm sure I've seen dozen of places in C4 where useless queries are made, or useless fields retreived (like marc field in biblioitems, etc)... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:38:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 08:38:24 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 --- Comment #82 from Jonathan Druart --- (In reply to Nicole C. Engard from comment #81) > There was a patch for those - > http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22372&action=diff > it says it was pushed. Do I need to do it again? > > Nicole This patch has been lost, it does not exist in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:56:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 08:56:54 +0000 Subject: [Koha-bugs] [Bug 11236] New: callnumber no longer can be searched in serials Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11236 Bug ID: 11236 Summary: callnumber no longer can be searched in serials Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: Susanne.Jerger at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:59:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 08:59:38 +0000 Subject: [Koha-bugs] [Bug 11236] callnumber no longer can be searched in serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11236 --- Comment #1 from Susanne.Jerger at bsz-bw.de --- In 3.6 it was possible to search the callnumber in the subscriptions search in the title field. Now it's not possible anymore. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:17:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 09:17:06 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from Martin Renvoize --- Patch applies as specified over bug 6435. This all seems to still work as expected to me; however I'm not best placed for judging whether all Robins packages cases have yet been met.. Could you take another look now it applies again Robin.. remember it needs bug 6435 applying first? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:17:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 09:17:27 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6435 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:17:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 09:17:27 +0000 Subject: [Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11078 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:26:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 09:26:22 +0000 Subject: [Koha-bugs] [Bug 11237] New: Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 Bug ID: 11237 Summary: Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org The explanation for the pref AcqItemSetSubfieldsWhenReceived (introduced by bug 8307) is wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:26:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 09:26:36 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11237 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:26:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 09:26:36 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on| |8307 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:28:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 09:28:39 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:28:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 09:28:43 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 --- Comment #1 from Jonathan Druart --- Created attachment 22868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22868&action=edit Bug 11237: Update explanation for pref AcqItemSetSubfieldsWhenReceived Test plan: Update the updatedb entry and search the pref in the admin module. The explanation should have been updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:29:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 09:29:15 +0000 Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11237 | --- Comment #28 from Jonathan Druart --- (In reply to Katrin Fischer from comment #27) > I think the syspref description is a bit confusing: > > AcqItemSetSubfieldsWhenReceived > Set subfields for item when items are created when receiving (e.g. > o=5|a="foo bar") > > Shouldn't it be something like: > Update subfields in items on receive when items are created when ordering > (e.g. o=5|a="foo bar") Yes, you are right. I proposed a patch on bug 11237. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:29:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 09:29:15 +0000 Subject: [Koha-bugs] [Bug 11237] Clarify explanation for the new pref AcqItemSetSubfieldsWhenReceived In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11237 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|8307 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:30:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 09:30:06 +0000 Subject: [Koha-bugs] [Bug 10832] Multi transport types for overdue notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:50:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 09:50:12 +0000 Subject: [Koha-bugs] [Bug 7518] searches with quotation marks don't work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518 --- Comment #38 from Fridolyn SOMERS --- Can it be pushed in master ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:09:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 10:09:17 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #64 from Jonathan Druart --- (In reply to Paola Rossi from comment #63) > 3) YES_NO,"NO",finds everything and looses the selection in form Good catch! If the value of the authorised values is 0, the filter don't work. I will provide a new followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:09:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 10:09:49 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:09:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 10:09:54 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #65 from Jonathan Druart --- Created attachment 22869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22869&action=edit Bug 10855: Filtering on additional fields don't work if value is equal to 0 If you tried to filter on an additional field linked to an authorised value, that did not work if the value was 0. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 12:08:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 11:08:33 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #22 from Robin Sheat --- I don't know when I'll get the chance to test it, but from reading the code I'm pretty happy with how it looks and I'd rather get it into master sooner rather than later because I've been wanting file locking for approximately ever. So I'd say don't wait for my approval. I can always quickly push through a patch for the package-related stuff if we discover a problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 12:15:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 11:15:36 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #23 from Martin Renvoize --- Awesome, thanks for looking over the code Robin.. I'll do one last test (with packages as I'm currently learning how to build them and this'll be a good exercise). I'll check the various files end up where you've expressed they should and then sign off. Hopefully someone will QA it promptly after that.. I've also been wanting locking in mainstream forever.. Nice work Doug! Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:09:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:09:27 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22709|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 22870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22870&action=edit Update Schema Files -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:09:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:09:40 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22741|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 22871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22871&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:21:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:21:19 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22870|0 |1 is obsolete| | Attachment #22871|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 22872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22872&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:22:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:22:04 +0000 Subject: [Koha-bugs] [Bug 11213] GetItemsInfo() called twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #8 from mathieu saby --- (In reply to Srdjan Jankovic from comment #2) > This may yield significant improvements in performance. > > Hairy spots: > * I have removed GetItemsLocationInfo() in favour of GetItemsInfo(). In case > of people not using XSLT, it may incur small penalty in virtual shelves > because GetItemsInfo() is a tad heavier. However, it should be insignificant > compared to the benefit when XSLT is used. I thouht I had read somewhere that non-XSLT display were to be deprecated one day, but I cannot retreive the message. Maybe I dreamt? If so, I suppose that the small penality you are talking about won't be a problem. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:29:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:29:44 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22872|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 22873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22873&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:33:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:33:47 +0000 Subject: [Koha-bugs] [Bug 11225] \n in translation strings should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Katrin, What is the problem? When I update the po file, I get: msgid "Cannot test prediction pattern for the following reason(s):\\n\\n" I update the translation: msgstr "TEST TRANSLATION\n\n" I install the templates and I get: alert(_("TEST TRANSLATION:\n\n") + error_msg); I don't know how we could add a new line without \n. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:37:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:37:51 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22873|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 22874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22874&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:38:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:38:45 +0000 Subject: [Koha-bugs] [Bug 11225] \n in translation strings should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 --- Comment #2 from Katrin Fischer --- Hi Jonathan, did you translate the string using pootle or did you do it manually in the text file? It used to be a bug in Pootle causing problems with escaping (bug 4883) An easy way to solve it, and also not have the confusing \n in translation is concatenating: _("Cannot test prediction pattern for the following reason(s):") + "\\n\\n" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:39:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:39:16 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22874|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 22875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22875&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:42:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:42:00 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22875|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 22876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22876&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:43:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:43:16 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #82 from sandboxes at biblibre.com --- Patch tested with a sandbox, by Koha team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:43:33 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:43:33 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 sandboxes at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22635|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:43:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:43:40 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 --- Comment #83 from sandboxes at biblibre.com --- Created attachment 22877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22877&action=edit Bug 7825: Changed OPACItemHolds syspref to be no|tes|force choice Currently, the Koha system preference OPACItemHolds allows a library system to choose to allow patrons to place bib and item level holds from the OPAC, or to allow patrons only to place bib level holds only from the opac. This patch set adds a third option, "force", which *requires* that patrons place item level holds from the opac, with no option of making a bib level hold. This patch modifies the system preference OPACItemHolds to be of the type "Choice", with the choices being "no", "yes", "force". The patch does not alter the currently set value of OPACItemHolds for database updates, only adding the additional option. Test Plan: 1) Set OPACItemHolds to "no". Check that OPAC holds behave as it is now (no "Place On" column, no "Select a specific copy" table, making a reserve is successful) 2) Set OPACItemHolds to "yes". Check that OPAC holds behave as it is now ( "Place On" column is there, "Select a specific copy" table shows when "A specific copy" is selected, making a reserve is successful) 3) Set OPACItemHolds to "force". Check that OPAC holds behave as follows: - no "Place On" column is present - "Select a specific copy" table is opened - making a reserve is successful This patch is a squashed patch of the 3 following patches: Amended opac-reserve.tt accordingly Signed-off-by: Delaye Stephane Bug 7825: Followup prevent submission without choosing an item + Fix some ergonomic issues in opac-reserve Signed-off-by: Delaye Stephane Bug 7825: Updatedatabase should only change the type and options values. The value field should not be change. We have to keep '1' for 'yes' and '' for 'no'. Original patch is from Srdjan Jankovic. Signed-off-by: Koha team AMU -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:43:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:43:50 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:43:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 13:43:53 +0000 Subject: [Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226 --- Comment #1 from Jonathan Druart --- Created attachment 22878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22878&action=edit Bug 11226: subscription frequencies and numbering patterns should be editable with serials permissions Bug 7688 does now allow patrons with serials permissions to edit subscription frequencies/numbering patterns. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:14:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:14:54 +0000 Subject: [Koha-bugs] [Bug 11221] New patrons are created with invalid dateofbirth value if field is left empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11221 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:14:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:14:57 +0000 Subject: [Koha-bugs] [Bug 11221] New patrons are created with invalid dateofbirth value if field is left empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11221 --- Comment #1 from Jonathan Druart --- Created attachment 22879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22879&action=edit Bug 11221: SQLHelper::_filter_hash does not manage well dates The default values for date fields is undef, so if a date field contains an empty string, we should insert NULL in the DB. The format_date_in_iso routine should be only called if a date is defined, is not equal to an empty string and does not match the iso regex. Partial test plan: 1. Create a new patron. Leave dateofbirth empty. 2. Save the record. 3. Open the record for editing. 4. Save the record without making changes. 5. Koha gives no error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:15:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:15:31 +0000 Subject: [Koha-bugs] [Bug 11221] New patrons are created with invalid dateofbirth value if field is left empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11221 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |10403 --- Comment #2 from Jonathan Druart --- I think this patch is correct but I don't have the time to provide unit tests and I don't know how to foresee all side effects. We should have several looks at this patch! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:15:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:15:31 +0000 Subject: [Koha-bugs] [Bug 10403] Add ability to set fund/budget on receipt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10403 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11221 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:33:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:33:27 +0000 Subject: [Koha-bugs] [Bug 11225] \n in translation strings should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 --- Comment #3 from Jonathan Druart --- Created attachment 22880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22880&action=edit Bug 11225: \n in translation strings should be removed Some strings in the serials module contain linebreaks \n that cause problems in translation. Test plan: - Update your po file - Verify that strings in serials/subscription-add.tt and serials/subscription-numberpatterns.tt are present and don't contain "\n" character. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:33:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:33:51 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22876|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 22881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22881&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:34:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:34:55 +0000 Subject: [Koha-bugs] [Bug 11225] \n in translation strings should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #4 from Jonathan Druart --- (In reply to Katrin Fischer from comment #2) > Hi Jonathan, > > did you translate the string using pootle or did you do it manually in the > text file? It used to be a bug in Pootle causing problems with escaping (bug > 4883) Yes, manually! > An easy way to solve it, and also not have the confusing \n in translation > is concatenating: > > _("Cannot test prediction pattern for the following reason(s):") + "\\n\\n" Yep, of course. I provided a patch fixing strings introduced by bug 7688 with this way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:35:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:35:19 +0000 Subject: [Koha-bugs] [Bug 11225] \n in translation strings should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:36:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:36:55 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22420|1 |0 is obsolete| | --- Comment #83 from Nicole C. Engard --- Comment on attachment 22420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22420 Bug 10671: Update Circ Help Files Marking this as un-obsolete so that it gets in to Master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:37:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:37:03 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:37:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:37:14 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:37:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:37:21 +0000 Subject: [Koha-bugs] [Bug 10671] Koha 3.14 Help Files Update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10671 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:46:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:46:34 +0000 Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22263|0 |1 is obsolete| | --- Comment #11 from Koha Team Lyon 3 --- Created attachment 22882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22882&action=edit Bug 11059 Not possible to sort staged dates in metric format Here's a new patch using title-string type. Olivier Crouzet -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:46:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:46:42 +0000 Subject: [Koha-bugs] [Bug 11059] Not possible to sort staged dates in metric format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11059 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:46:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 14:46:59 +0000 Subject: [Koha-bugs] [Bug 8483] Borrower reading history should include deleted items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 --- Comment #2 from Heather Braum --- Is this bug still being worked on by Horowhenua? We are very interested in this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:00:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 15:00:20 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21080|0 |1 is obsolete| | --- Comment #23 from Koha Team Lyon 3 --- Created attachment 22883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22883&action=edit Bug 8231 Systematic warning at check in when borrower is debarred Patch redone taking into account changes introduced by bug 2720. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:00:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 15:00:35 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:12:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 15:12:35 +0000 Subject: [Koha-bugs] [Bug 9593] Prices not imported correctly from a staged file In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9593 --- Comment #51 from Koha Team Lyon 3 --- I know very few about unit test. Would something like that do the trick ? #!/usr/bin/perl use strict; use warnings; use C4::Biblio; use Test::More tests=>1; # start transaction my $dbh = C4::Context->dbh; $dbh->{AutoCommit} = 0; $dbh->{RaiseError} = 1; # set a test price string my $PRICE_STRING='25.5 EUR, $32, $LD35'; my $expectedout='32'; # set active currency test data my $CURRENCY = 'TEST'; my $SYMBOL = '$'; my $ISOCODE = 'USD'; my $RATE= 1; # disables existing active currency if necessary. my $active_currency = C4::Budgets->GetCurrency(); my $curr; if ($active_currency) { $curr = $active_currency->{'currency'}; $dbh->do("UPDATE currency set active = 0 where currency = '$curr'"); } $dbh->do("INSERT INTO currency ( currency,symbol,isocode,rate,active ) VALUES ('$CURRENCY','$SYMBOL','$ISOCODE','$RATE',1)"); my $mungemarcprice=MungeMarcPrice($PRICE_STRING); ok ($mungemarcprice eq $expectedout, "MungeMarcPrice returned $expectedout as expected"); # Cleanup $dbh->rollback; Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:35:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 15:35:19 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 --- Comment #18 from M. Tompsett --- The opac-MARCdetail.pl link is not in the search, but you can get to it by: 1) Search for something in OPAC 2) Click link, which will take you to the "Normal View" page (opac-detail.pl). 3) Click the "MARC detail" view link (opac-MARCdetail.pl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:38:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2013 15:38:15 +0000 Subject: [Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron modification tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #15 from Jonathan Druart --- Kyle, Why don't you use the Batch patron deletion? Maybe we could have a new entry "Delete patrons in the list Business layer validations as well. Unit tests: Serials enumeration and chronology filtering Items date and branch filtering Formatted using perltidy and Perl::Critic Sponsored by the Joensuu Regional Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:17:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 17:17:05 +0000 Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by default in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22570|0 |1 is obsolete| | --- Comment #9 from Olli-Antti Kivilahti --- Created attachment 23173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23173&action=edit Bug 6385 - All items should optionally be displayed by default in the OPAC Added a system preference "OPACmaxItemsOnDetail" to set a threshold after which only results from the users branch are displayed, or Items from the past year if homebranch cannot be defined. This tightly couples with bug 11129 which provides the filtering mechanism to display smaller result sets. Also added lots of complexity to define the warning messages based on is the filter used to override the "OPACmaxItemsOnDetail". Added a new "limit"-filter to C4::Items::GetItemsInfo() which adds the LIMIT-clause to the big SQL. Added a unit test for the filter to the Items.t Fixed a use-case where a user has no items in his branch, and the limited items set is emtpy. Now using items from past year if none available in the users branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:18:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 17:18:20 +0000 Subject: [Koha-bugs] [Bug 11308] New: RSS feed is slightly broken in bootstrap theme Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 Bug ID: 11308 Summary: RSS feed is slightly broken in bootstrap theme Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: chris at bigballofwax.co.nz QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:19:51 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 17:19:51 +0000 Subject: [Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:19:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 17:19:54 +0000 Subject: [Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 --- Comment #1 from Chris Cormack --- Created attachment 23174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23174&action=edit Bug 11308 : Fixing rss page in bootstrap To test: 1/ Do a search in the opac, click on the rss feed icon 2/ Notice the page renders, not like an rss feed should 3/ Apply the patch and refresh 4/ Page should now be (more) valid xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:42:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 17:42:15 +0000 Subject: [Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:42:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 17:42:19 +0000 Subject: [Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23169|0 |1 is obsolete| | Attachment #23170|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 23175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23175&action=edit [PASSED QA] Bug 11307 : Potential XSS attack in rss feed To test: 1/ Craft a url like /cgi-bin/koha/opac-search.pl?q=a&count=50"'

test

&sort_by=acqdate_dsc&format=rss2 2/ look at the source, notice 50"'

test

3/ apply the patch, and reload url 4/ source now contains 50"'<h1>test</h1> Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:43:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 17:43:24 +0000 Subject: [Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 --- Comment #7 from Martin Renvoize --- Created attachment 23176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23176&action=edit [PASSED QA] Bug 11307 : Follow up for bootstrap theme (master and 3.14.x only) To test: Same as first patch, but using bootstrap theme Signed-off-by: Mark Tompsett Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:57:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 17:57:10 +0000 Subject: [Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- All works as expected, passes QA script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 19:18:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 18:18:41 +0000 Subject: [Koha-bugs] [Bug 11307] Potential XSS attack vector in opac rss feed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11307 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master and 3.14.x. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 19:20:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 18:20:00 +0000 Subject: [Koha-bugs] [Bug 11309] New: Duplicated patterns when subscription table is updated Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 Bug ID: 11309 Summary: Duplicated patterns when subscription table is updated Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: nunyo at masmedios.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When you update the subscription table, checking patterns has a bad behaviour because this process compares patterns (new versus just created) without considering NULL values. The result is a lot of patterns duplicated in 'subscription_numberpatterns' table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 19:22:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 18:22:27 +0000 Subject: [Koha-bugs] [Bug 11309] Duplicated patterns when subscription table is updated In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11309 Nu?o L?pez Ans?tegui changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |nunyo at masmedios.com |ity.org | --- Comment #1 from Nu?o L?pez Ans?tegui --- Created attachment 23177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23177&action=edit Bug 11309 - Duplicated patterns when subscription table is updated This patch solves the bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 19:33:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 18:33:27 +0000 Subject: [Koha-bugs] [Bug 11290] members-home.pl displays badly if using non english templates and have a utf8 char in categorycode description In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11290 --- Comment #12 from Chris Cormack --- (In reply to Tom?s Cohen Arazi from comment #11) > (In reply to Jacek Ablewicz from comment #7) > > I think the underlying cause for this particular problem in members.pl and > > members-home.pl is that output()/utf8_arrayref()/utf8_hashref() subs in > > Templates.pm do not know what to do with objects / blessed hashrefs (they > > treat them as strings/scalars, actually calling utf8::is_utf8() on them > > etc.). > > Preparing for Reno i had tried even removing any call to those sub. I'd be > in favour of removing them and using template filters instead (I.e. less > loops traversing data structures and less probable double encoding > situations).. > I would prefer this situation also -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 19:40:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 18:40:19 +0000 Subject: [Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 --- Comment #2 from M. Tompsett --- Created attachment 23178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23178&action=edit [SIGNED OFF] Bug 11308 : Fixing rss page in bootstrap To test: 1/ Do a search in the opac, click on the rss feed icon 2/ Notice the page renders, not like an rss feed should 3/ Apply the patch and refresh 4/ Page should now be (more) valid xml Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 19:40:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 18:40:45 +0000 Subject: [Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23174|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 19:41:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 18:41:55 +0000 Subject: [Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtompset at hotmail.com --- Comment #3 from M. Tompsett --- I switched my theme to bootstrap (opacthemes system preference), and followed test plan in comment #1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 20:57:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 19:57:13 +0000 Subject: [Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 --- Comment #4 from M. Tompsett --- Created attachment 23179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23179&action=edit Bug 11253 - tools/inventory.pl output_pref ignores 'iso' parameter passed Took all the output_pref function calls and converted them to the newer hash format parameter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 21:41:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 20:41:27 +0000 Subject: [Koha-bugs] [Bug 11253] tools/inventory.pl output_pref ignores 'iso' parameter passed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11253 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23179|0 |1 is obsolete| | --- Comment #5 from M. Tompsett --- Created attachment 23180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23180&action=edit Bug 11253 - tools/inventory.pl output_pref ignores 'iso' parameter passed Took all the output_pref function calls and converted them to the newer hash format parameter. Added special case for dd-mm-yyyy calls, so dt_from_string works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 23:31:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 22:31:14 +0000 Subject: [Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed open() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 23:31:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2013 22:31:17 +0000 Subject: [Koha-bugs] [Bug 11188] Make gather_print_notices.pl die on failed open() In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11188 --- Comment #1 from Magnus Enger --- Created attachment 23181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23181&action=edit Bug 11188 - Make gather_print_notices.pl die on failed open() Problem: If you tell gather_print_notices.pl to write output to a location you do not have write access to, it will silently fail to write the data, but still mark unsent messages as sent. Solution: This patch adds two lines of defense: 1. Check that the location given for the output is writable 2. use "open() or die" instead of just "open()" when writing the output The first measure should catch most of the potential errors, but I guess a directory can be writable, but the open() still can fail because the disk is full or something similar. To test: - Make sure you have some unsent messages in the message_queue table, that do not have an email adress - Apply the patch - Run the script, pointing at a location you do not have access to write to. Check that the script exits with an appropriate error message, and that the unsent messages are still unsent. Do this both with and without the -s option. - To fake passing the first line of defence, comment out line 62 and put this in instead: if ( !$output_directory || !-d $output_directory ) { - Run the script again as above, check you get an appropriate error and that the message queue is not touched - Reset line 62 to how it was - Run the script against a directory you do have access to write to and check that output is produced as expected and that messages are marked as sent - Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 08:21:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 07:21:03 +0000 Subject: [Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 08:21:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 07:21:08 +0000 Subject: [Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23178|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 23182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23182&action=edit [PASSED QA] Bug 11308 : Fixing rss page in bootstrap To test: 1/ Do a search in the opac, click on the rss feed icon 2/ Notice the page renders, not like an rss feed should 3/ Apply the patch and refresh 4/ Page should now be (more) valid xml Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Small change, big difference. With the patch the content of the RSS feed renders like it does for the prog theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 08:28:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 07:28:27 +0000 Subject: [Koha-bugs] [Bug 11310] New: Update XSLT stylesheets in bootstrap theme Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Bug ID: 11310 Summary: Update XSLT stylesheets in bootstrap theme Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I noticed today that the "Continues:" label is missing a space after the label on the bootstrap theme. This has been fixed a while ago on the prog theme - I think easiest would be to copy the XSLT files, so both filesets are current. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 08:28:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 07:28:37 +0000 Subject: [Koha-bugs] [Bug 11310] Update XSLT stylesheets in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11310 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 08:31:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 07:31:42 +0000 Subject: [Koha-bugs] [Bug 11304] Bootstrap OPAC detail page doesn't display holding tabs properly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 08:31:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 07:31:45 +0000 Subject: [Koha-bugs] [Bug 11304] Bootstrap OPAC detail page doesn't display holding tabs properly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23159|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 23183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23183&action=edit [PASSED QA] Bug 11304 Bootstrap OPAC detail page doesn't display holding tabs properly Detail page tabs are not displayed properly because JavaScript is broken in French. This is due to _(' JS string construction used in place of _(". This patch fixes: - opac-detail.tt page - xt/single_quotes to test bootstrap theme Signed-off-by: Owen Leonard Tested by applying the patch, running translate update, then translate install. Saw no JavaScript error on the French detail page. Signed-off-by: Katrin Fischer Switches from single to double quotes for translatatable strings. Unit tests for xt/single_quotes passes now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 09:05:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 08:05:09 +0000 Subject: [Koha-bugs] [Bug 5202] Merge authority records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5202 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #26 from Fr?d?ric Demians --- It doesn't seem to work for UNIMARC. What happen to biblio records linked to deleted authority? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 09:28:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 08:28:03 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 --- Comment #15 from Katrin Fischer --- Hi Barry, I appreciate your work on this a lot, but I think we can't change existing behaviour like this. I think we really need to make your new behaviour a configuration option and keep the existing behaviour intact. It could work as a third option in the pull down of AllowOnShelfHolds, with some rephrasing. There is also another problem - GetReserveStatus doesn't work. See bug 10697. It's much better to use CheckReserves and it would probably also obsolete some of the checks you are doing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:02:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 10:02:26 +0000 Subject: [Koha-bugs] [Bug 11295] Serials manual history can no longer be added or edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11295 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #1 from Julian Maurice --- Hi Katrin, the manual history fields have moved into their own page. To access this page, go to the Planning tab on subscription page. There should be a link "Edit history" in front of "Manual History: Enabled". I think this was moved to lighten the subscription edit page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:21:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 10:21:21 +0000 Subject: [Koha-bugs] [Bug 11295] Serials manual history can no longer be added or edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11295 --- Comment #2 from Katrin Fischer --- Hi Julian, does the checkbox in the subscription have a meaning currently? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:21:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 10:21:35 +0000 Subject: [Koha-bugs] [Bug 11295] Serials manual history can no longer be added or edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11295 --- Comment #3 from Katrin Fischer --- And thx, I will try that as soon as I can. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:23:27 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 10:23:27 +0000 Subject: [Koha-bugs] [Bug 11296] Browse selected biblios - bootstrap In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11296 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23132|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 23184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23184&action=edit Bug 11296: Browse selected biblios - bootstrap Add the changes from bug 10858 to the bootstrap theme. Test plan: - Launch a search at the OPAC - Check some biblios - Go on another page - Check some biblios - Come back to the first page and check that already checked biblio is automatically checked. - Click on the "Browse selected biblios >>" link - Check that you are able to browse results you had checked. In addition to prog and ccsr templates, this patch allows to add selected biblios (from multiple pages) to the cart or a list. To test: - check some biblios from several pages - add them to the cart - add them to a list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:27:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 10:27:12 +0000 Subject: [Koha-bugs] [Bug 11295] Serials manual history can no longer be added or edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11295 --- Comment #4 from Julian Maurice --- > does the checkbox in the subscription have a meaning currently? Yes. If disabled, the "Edit history" link is not displayed. > And thx You're welcome ;) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:57:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 11:57:20 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 --- Comment #26 from Fridolyn SOMERS --- (In reply to Katrin Fischer from comment #24) > Hi Fridolin, thx for your hints - I think maybe using the SNC authority type > was the missing piece. Your welcome, its a team work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:31:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 13:31:08 +0000 Subject: [Koha-bugs] [Bug 11311] New: Browse selected authorities Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311 Bug ID: 11311 Summary: Browse selected authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:32:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 13:32:55 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 --- Comment #16 from Barry Cannon --- Hi Katrin, Thanks for the feedback, especially regarding GetReserves, I will take another look. Could you expand a bit on what you mean by change in behaviour? This patch should just fix up the initial bug and shouldn't add any new functionality or preferences. Have I inadvertently changed something I shouldn't have!? Barry -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:38:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 13:38:45 +0000 Subject: [Koha-bugs] [Bug 11311] Browse selected authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311 --- Comment #1 from Jonathan Druart --- Created attachment 23185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23185&action=edit Bug 11311: Browse selected authorities In the same way as the feature "Browse selected biblios", this one adds the same browse feature for authorities. After launching an authority search, some people would like to browse some results from several pages. This patch adds, at the OPAC, a link "Browse selected authorities >>" when at least one authority is checked. You can choose authorities from several page, not only the current one. In this way, checkboxes already checked become again checked when you come back on this results page. After clicking the link, the "Browse results" block is filled with selected authotiries. Test plan: - Launch an authority search at the OPAC - Check some authorities - Go on another page - Check some authorities - Come back to the first page and check that already checked authorities is automatically checked. - Click on the "Browse selected authorities >>" link - Check that you are able to browse results you had checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:38:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 13:38:42 +0000 Subject: [Koha-bugs] [Bug 11311] Browse selected authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:39:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 13:39:52 +0000 Subject: [Koha-bugs] [Bug 11311] Browse selected authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10858 Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:39:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 13:39:52 +0000 Subject: [Koha-bugs] [Bug 10858] Browse selected biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11311 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:40:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 13:40:50 +0000 Subject: [Koha-bugs] [Bug 11311] Browse selected authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311 --- Comment #2 from Jonathan Druart --- A patch for the bootstrap theme will be provided when bugs 10858 and 11296 will be pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:44:02 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 13:44:02 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 --- Comment #17 from Katrin Fischer --- The basic problem I see is that this might not qualify as a bug for some libraries, but as intended behaviour. So changing it to work like we want, will break it for others. By preserving existing behaviour we will avoid this conflict. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 15:01:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 14:01:11 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #18 from Nicole C. Engard --- I see this both ways. The preference reads: Allow/Don't allow hold requests to be placed on items that are not checked out. It specifically says 'items that are not checked out' so it doesn't say 'titles with any items checked out' The preference works as it says it works. I think the preference in this case should be changed to read: ___ hold requests to be placed on ___ not checked out. Allow/Don't allow items that are/titles where all items are That way we retain the old behavior and add the new desired behavior. I'm open to other wording, but do agree with Katrin that to maintain the current behavior we need to offer other options to the existing preference. In the end there are three choices: * The system allows on shelf hold regardless * The system allows on shelf holds if at least one item is checked out * The system does not allow on shelf holds if at least one item is checked out -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 15:10:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 14:10:09 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 --- Comment #19 from Katrin Fischer --- >* The system allows on shelf hold regardless >* The system allows on shelf holds if at least one item is checked out >* The system does not allow on shelf holds if at least one item is checked out I think maybe we coudl rephrase option 3 to read: * The system does not allow on shelf holds unless all items are checked out -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 15:10:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 14:10:54 +0000 Subject: [Koha-bugs] [Bug 6837] When AllowOnShelfHolds is OFF then holds on records with available items should not be possible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6837 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |kyle at bywatersolutions.com Severity|normal |enhancement --- Comment #20 from Kyle M Hall --- This is a massive change in holds behavior. There is no way this patch can be pushed without an option to retain the systems current behavior. I think it's a great enhancement idea, but I don't believe most users would consider the current behavior a bug, as it has been this way since AllowOnShelfHolds was first implemented. Another QA pont: This patch was submitted yesterday, but uses DBI instead of DBIx::Class ( Koha::Database ). Please modify the patch to use DBIC instead of DBI. You only use DBI in one area, so this request shouldn't be too onerous. I do think this is a great idea. If you can fix these issues I'm sure we can get this pushed! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 15:27:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 14:27:40 +0000 Subject: [Koha-bugs] [Bug 6427] Rewrite of the accounts system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23171|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall --- Created attachment 23186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23186&action=edit Bug 6427 - Rewrite of the accounts system - WIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 15:46:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 14:46:20 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 15:46:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 14:46:25 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23072|0 |1 is obsolete| | Attachment #23073|0 |1 is obsolete| | --- Comment #115 from Jonathan Druart --- Created attachment 23187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23187&action=edit Bug 7143: New release team for Koha 3.16 Note that the 3.8 RMaint should still be elected on the next meeting. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer No typos or problems found. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 15:47:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 14:47:01 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #116 from Jonathan Druart --- Created attachment 23188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23188&action=edit Bug 7143: Cleaning up docs/history.txt Sorting some lines on date Typo on date for Bernardo Kriegel Splitting one line in 2008 in two lines Replacing some tabs with spaces in October 2013 Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer No typos or problems found. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:06:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:06:04 +0000 Subject: [Koha-bugs] [Bug 11225] \n in translation strings should be removed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11225 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:12:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:12:49 +0000 Subject: [Koha-bugs] [Bug 11283] Restriction type is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:12:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:12:53 +0000 Subject: [Koha-bugs] [Bug 11283] Restriction type is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23117|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 23189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23189&action=edit Bug 11283 - Restriction type is not translatable The new restrictions system has different types: MANUAL, OVERDUES and SUSPENSION. Those are shown in the interface and seem to come directly from the database, so they are not translatable. As they are hardcoded translations should be possible and be handled in the template. Test Plan: 1) Create a patron with one of each type of restriction 2) Apply this patch 3) Note you see the type with only the first letter capitialized, this indicates you are seeing the translatable string Signed-off-by: Katrin Fischer Passes all tests and QA script. Strings now appear in updated po files: msgid "%s %s Manual %s Overdues %s Suspension %s " Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:14:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:14:43 +0000 Subject: [Koha-bugs] [Bug 2720] Overdues which debar automatically should undebar automatically when returned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11283 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:14:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:14:43 +0000 Subject: [Koha-bugs] [Bug 11283] Restriction type is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Patch complexity|--- |Trivial patch Depends on| |2720 Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:18:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:18:36 +0000 Subject: [Koha-bugs] [Bug 11105] label - opac - places on facets not easily css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11105 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:18:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:18:39 +0000 Subject: [Koha-bugs] [Bug 11105] label - opac - places on facets not easily css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11105 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23119|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 23190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23190&action=edit Bug 11105: created places span in opac To test: Verify places in the facets is wrapped in a span. Signed-off-by: Katrin Fischer Template change only, works as expected. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:20:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:20:10 +0000 Subject: [Koha-bugs] [Bug 11105] label - opac - places on facets not easily css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11105 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- I think we would like to have an id for each facets, I will add a new report for that. The patch will modify prog/bootstrap and intranet interfaces. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:23:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:23:38 +0000 Subject: [Koha-bugs] [Bug 11105] label - opac - places on facets not easily css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11105 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Staff Client |OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:26:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:26:14 +0000 Subject: [Koha-bugs] [Bug 11312] New: Add span to facets (for css selection) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Bug ID: 11312 Summary: Add span to facets (for css selection) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 11106, bug 8989, bug 11105 add an id for facets. It should be similar for staff and opac (prog and bootstrap). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:26:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:26:21 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:26:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:26:42 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11105 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:26:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:26:42 +0000 Subject: [Koha-bugs] [Bug 11105] label - opac - places on facets not easily css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11105 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11312 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:26:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:26:50 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:37:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:37:12 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:37:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:37:15 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #1 from Jonathan Druart --- Created attachment 23191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23191&action=edit Bug 11312: Facets should be selectable using an id [staff] Test plan: launch a search and verify all facet headers have an id. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:37:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:37:21 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #2 from Jonathan Druart --- Created attachment 23192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23192&action=edit Bug 11312: Facets should be selectable using an id [opac-prog] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:37:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:37:25 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 --- Comment #3 from Jonathan Druart --- Created attachment 23193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23193&action=edit Bug 11312: Facets should be selectable using an id [opac-bootstrap] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:37:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:37:41 +0000 Subject: [Koha-bugs] [Bug 11312] Add span to facets (for css selection) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11312 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11106 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:37:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:37:41 +0000 Subject: [Koha-bugs] [Bug 11106] Label item type facet in staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11106 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11312 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:39:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:39:20 +0000 Subject: [Koha-bugs] [Bug 11313] New: empty value in mandatory combobox in record edition Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11313 Bug ID: 11313 Summary: empty value in mandatory combobox in record edition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: fridolyn.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In biblio (or authority) record edition or creation, Bug 3727 added an empty value to combobox for subfield using itemtype authorized values, which is mandatory and does not have a default value. This to avoid selecting arbitrarily the first value of combo. This behavior must be extended to normal authorized values like CCODE, COUNTRY ... Also, when record already exists and has a defined value for the subfield this value will be selected in combobox so there is no need for an empty value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:39:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:39:36 +0000 Subject: [Koha-bugs] [Bug 11313] empty value in mandatory combobox in record edition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11313 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3727 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:39:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:39:36 +0000 Subject: [Koha-bugs] [Bug 3727] If item type is mandatory in marc editor, itemtype is autofilled In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3727 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11313 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:40:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:40:17 +0000 Subject: [Koha-bugs] [Bug 11284] Package related updates for the new release In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11284 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- I have pushed the master version of this patch (thanks!), but the 3.14.x version does not apply. Please correct that and attach the proper version for that branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:45:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:45:50 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #117 from Galen Charlton --- I've pushed the about.tt patch to master and the history.txt patch to both master and 3.14.x. Thanks, Marcel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:46:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:46:07 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23187|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:46:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:46:20 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:46:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:46:30 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:51:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:51:22 +0000 Subject: [Koha-bugs] [Bug 11275] make deleteditems.materials of type text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11275 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:51:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:51:25 +0000 Subject: [Koha-bugs] [Bug 11275] make deleteditems.materials of type text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11275 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23124|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 23194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23194&action=edit Bug 11275 - make deleteditems.materials of type text Bug 7278 has made items.materials of type text. It must be the same in deleteditems column. Signed-off-by: Katrin Fischer Passes all tests and QA script. Tested: - definition of materials now matches between items and deleteditems - database update works correctly Signed-off-by: Jonathan Druart The only difference between tables items and deleteditems is deleteditems.marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:53:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:53:09 +0000 Subject: [Koha-bugs] [Bug 11275] make deleteditems.materials of type text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11275 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- There is a problem with the patch! (SetVersion missing in updatedb). New patch coming... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:54:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:54:24 +0000 Subject: [Koha-bugs] [Bug 11275] make deleteditems.materials of type text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11275 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23194|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 23195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23195&action=edit Bug 11275 - make deleteditems.materials of type text Bug 7278 has made items.materials of type text. It must be the same in deleteditems column. Signed-off-by: Katrin Fischer Passes all tests and QA script. Tested: - definition of materials now matches between items and deleteditems - database update works correctly Signed-off-by: Jonathan Druart The only difference between tables items and deleteditems is deleteditems.marc Amended patch: Add a missing SetVersion in updatedb.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:55:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 15:55:46 +0000 Subject: [Koha-bugs] [Bug 11308] RSS feed is slightly broken in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11308 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #5 from Galen Charlton --- Pushed to master. Thanks, Chris! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:03:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 16:03:58 +0000 Subject: [Koha-bugs] [Bug 11313] empty value in mandatory combobox in record edition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11313 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |fridolyn.somers at biblibre.co | |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 23196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23196&action=edit Bug 11313 - empty value in mandatory combobox in record edition see commit message -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:04:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 16:04:04 +0000 Subject: [Koha-bugs] [Bug 11313] empty value in mandatory combobox in record edition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11313 Fridolyn SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:08:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 16:08:29 +0000 Subject: [Koha-bugs] [Bug 11275] make deleteditems.materials of type text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11275 --- Comment #7 from Katrin Fischer --- Ah, thx for catching that - probably my fault when fixing the conflict! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:48:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 16:48:22 +0000 Subject: [Koha-bugs] [Bug 11283] Restriction type is not translatable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11283 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:53:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 16:53:45 +0000 Subject: [Koha-bugs] [Bug 11304] Bootstrap OPAC detail page doesn't display holding tabs properly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11304 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Fr?d?ric! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:01:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:01:12 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:01:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:01:16 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22125|0 |1 is obsolete| | --- Comment #25 from M. de Rooy --- Created attachment 23197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23197&action=edit Bug 11077: Uninitialized value $pki_field warning During login at the Staff interface you get warnings in the logs regarding an uninitialized value for the $pki_field variable. To test: - tail -f /path/to/your-intranet-logs - Point your browser to your staff login page - Login - Three warnings are showed - Apply the patch - Log out - Log in - No new warnings, and you can still log in. Thanks To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Petter Goksoyr Asen Followed test plan; it works as advertised. Also works when I deleted AllowPKIAuth system pref. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:03:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:03:10 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23197|Bug 11077: Uninitialized |[PASSED_QA] Bug 11077: description|value $pki_field warning |Uninitialized value | |$pki_field warning CC| |m.de.rooy at rijksmuseum.nl --- Comment #26 from M. de Rooy --- Comment on attachment 23197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23197 [PASSED_QA] Bug 11077: Uninitialized value $pki_field warning First patch of Thomas passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:25:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:25:01 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22805|bug_11077: get rid of some |[FAILED_QA] Bug 11077: get description|warnings |rid of some warnings --- Comment #27 from M. de Rooy --- Comment on attachment 22805 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22805 [FAILED_QA] Bug 11077: get rid of some warnings Second patch of Srdjan contains this change: - elsif ( $lasttime < time() - $timeout ) { + elsif ( $lasttime && ($lasttime < time() - $timeout) ) { If lasttime was undefined, it will be interpreted as zero in the first condition and therefore the condition is true. In the second case it will become false. So we have a behavior change. The warning is gone btw :) Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:27:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:27:40 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22805|0 |1 is obsolete| | --- Comment #28 from M. de Rooy --- Created attachment 23198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23198&action=edit [FAILED_QA] bug_11077: get rid of some warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:28:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:28:42 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22854|0 |1 is obsolete| | --- Comment #29 from M. de Rooy --- Created attachment 23199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23199&action=edit Bug 11077 - Correct silent warnings in C4/Auth.pm This patch corrects a noisy ne condition. $userid = $retuserid if ( $retuserid ne ''); became $userid = $retuserid if ( $retuserid ); It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's patch, while correcting the problems found. This includes: my $q_userid = $query->param('userid') // ''; along with: my $s_userid = ''; and: my $s_userid = $session->param('id') // ''; Indentation does not reflect actual scoping. And the 'None' is changed to '', since that behaves properly in the undef case: my $pki_field = C4::Context->preference('AllowPKIAuth') // ''; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:29:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:29:10 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:40:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:40:00 +0000 Subject: [Koha-bugs] [Bug 11314] New: Restore ability to see only 5 entries on parcel.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11314 Bug ID: 11314 Summary: Restore ability to see only 5 entries on parcel.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Bug 9130 removed the ability to limit the tables on parcel.pl to 5 rows, as well as the "sticky" feature. It is trivial to restore this functionality. These datatables are already using bStateSave, so are they are "sticky" already. The only part left is to enable the ability to limit the table to 5 rows at a time. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:41:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:41:32 +0000 Subject: [Koha-bugs] [Bug 11314] Restore ability to see only 5 entries on parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11314 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:41:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:41:34 +0000 Subject: [Koha-bugs] [Bug 11314] Restore ability to see only 5 entries on parcel.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11314 --- Comment #1 from Kyle M Hall --- Created attachment 23200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23200&action=edit Bug 11314 - Restore ability to see only 5 entries on parcel.pl Bug 9130 removed the ability to limit the tables on parcel.pl to 5 rows, as well as the "sticky" feature. It is trivial to restore this functionality. These datatables are already using bStateSave, so are they are "sticky" already. The only part left is to enable the ability to limit the table to 5 rows at a time. Test Plan: 1) Apply this patch 2) Browse to parcel.pl 3) Note the default rows count is still 10 4) Note the option to limit the row count to 5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:43:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:43:20 +0000 Subject: [Koha-bugs] [Bug 11315] New: Add support for subfield deletion when doing authority merges. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Bug ID: 11315 Summary: Add support for subfield deletion when doing authority merges. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt at gmail.com Reporter: fcapovilla at live.ca QA Contact: testopia at bugs.koha-community.org Created attachment 23201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23201&action=edit Add the overwriteSubfieldsOnMerge preference. This patch adds the "overwriteSubfieldsOnMerge" preference. If it is activated, all of the biblio's subfields will be overwritten when doing an authority merge. This means that subfields that exist in the biblio, but not in the authority will be deleted in the biblio when doing the merge. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:45:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:45:29 +0000 Subject: [Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Medium patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:54:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:54:09 +0000 Subject: [Koha-bugs] [Bug 11275] make deleteditems.materials of type text In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11275 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #8 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 18:57:04 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 17:57:04 +0000 Subject: [Koha-bugs] [Bug 11105] label - opac - places on facets not easily css selectable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11105 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Rachel! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:04:43 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 18:04:43 +0000 Subject: [Koha-bugs] [Bug 11171] The basket group is not displayed on the supplier list page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11171 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #7 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:09:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 18:09:05 +0000 Subject: [Koha-bugs] [Bug 11286] Bug 10602 prevents to create new subfields in authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11286 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:12:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 18:12:35 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 --- Comment #26 from Ian Palko --- For clarification: The "duplicate bug" was mine. A search for terms never brought up this bug so it may be a good warning for future bug reports. Meaningful titles are important. As regards Capitalization: It certainly isn't a deal breaker for us. But the capitalization is not because of using non-standard Library of Congress numbers. LoC itself uses miniscule lettering after publication dates for editions. This is and has been standard practice, so far as I am aware. Thus that part (the easy fix) is a real bug. Regarding the non-standard breaking: It seems that one way of working with such non-standard numbers would be to add a label breaking routine to allow for a special breaking character or customized code. If a library would like a non-standard feature, they can put the work in to write the code for it. "Customized" means doing the work to make it so. If we want out-of-the-box to work, we had better plan on following standards. For us, this did cause some problems for reference books, but we were just recataloging this section. The solution for us was a combination of collection code (Reference), item type (Reference), and Reference stickers. In the end, that was better than the REF prefix. Perhaps that might give ideas for individual solutions to the labeling issue in the meantime. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:16:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 18:16:17 +0000 Subject: [Koha-bugs] [Bug 11316] New: plugin icon missing tooltip in addbiblio.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11316 Bug ID: 11316 Summary: plugin icon missing tooltip in addbiblio.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: mtompset at hotmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Home Search the catalog Type something and click Submit Click a result entry Click the Edit button Scroll down and click the 'Edit Record' In the various tabs there are "Clone this subfield", "Delete this subfield", "Repeat this Tag", "Delete this Tag" tooltip help popups when you hover over the icons to the right, but for the plug-in icone there is no tooltip. Looking at the page source, it is an HTML anchor with the text of "Tag editor", but there is no title attribute set to cause the tooltip popup. This will add the tooltip popup with the text "Tag editor". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:22:13 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 18:22:13 +0000 Subject: [Koha-bugs] [Bug 11316] plugin icon missing tooltip in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11316 --- Comment #1 from M. Tompsett --- Created attachment 23202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23202&action=edit Bug 11316 - plugin icon missing tooltip in addbiblio.pl By adding: title=\"Tag editor\" into the HTML generated in addbiblio, a tooltip displaying 'Tag editor' appears when the moust is hovered over the plugin icon. Test Plan: 1) Log into Staff client 2) Click the 'Search the catalog' tab 3) Type something which will generate results 4) Click the title of a result 5) Click the 'Edit' button 6) Scroll down and click the 'Edit Record' 7) Look through the various tabs and notice that all the plugin icons have no tooltip. 8) Apply the patch 9) Refresh the page 10) All the plugin icons should have the tooltip text of 'Tag editor'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:25:08 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 18:25:08 +0000 Subject: [Koha-bugs] [Bug 11214] Allow create routing list in serial collection page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11214 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Pushed to master. Thanks, Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:26:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 18:26:39 +0000 Subject: [Koha-bugs] [Bug 10956] Series of OPAC searches can cause a browser crash In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10956 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #2 from mathieu saby --- Don't you think this bug priority needs to be reevaluated? Random browser crashes are a really nasty issue... I suppose it is linked with the browser crashes I experienced each time I tried to test Jonathan Druart's patch made for making facets cancellable (Bug 10857) Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:27:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 18:27:45 +0000 Subject: [Koha-bugs] [Bug 11316] plugin icon missing tooltip in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11316 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:35:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 18:35:45 +0000 Subject: [Koha-bugs] [Bug 7484] Keeping typed values when searching for authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7484 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- Pushed to master. Thanks, Fridolin! However, I agree with Adrien that it would be better to use a set of radio buttons for the search type rather than tabs -- it is not quite idiomatic for a tabbed interface to preserve state when switching tabs like this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:50:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 18:50:31 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Whiteboard| |whiteboardtest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:51:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 18:51:59 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #30 from M. Tompsett --- My patch corrects the problem for which you failed Srdjan Jankovic's patch. You will notice that I changed: elsif ( $lasttime && ($lasttime < time() - $timeout) ) { into elsif ( !$lasttime || ($lasttime < time() - $timeout) ) { which does work. I did say, "It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's patch, while correcting the problems found," by which I meant that if you applied everything including my patch, everything should silence all the bugs and continue to work like before. Also, my patch depends on his, so should I squash our patches together, and get a single sign off? Should I correct mine after he corrects his? This is a very weird scenario to have with 3 pieces in 3 vastly different states. I'm happy to fix them any which way, but what is the best course of action? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:53:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 18:53:16 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| | Library::CallNumber::LC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:59:41 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 18:59:41 +0000 Subject: [Koha-bugs] [Bug 10821] label pdf adding in strange breaking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10821 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Whiteboard| Library::CallNumber::LC | --- Comment #27 from Chris Nighswonger --- (In reply to Ian Palko from comment #26) > For clarification: > > The "duplicate bug" was mine. A search for terms never brought up this bug > so it may be a good warning for future bug reports. Meaningful titles are > important. > Actually, it is more likely due to the fact that Bugzilla's simple search does not include bugs marked "RESOLVED." Otherwise a search on 'Library::CallNumber::LC' would have turned up this bug. FFR, typing the word 'ALL' befor the actual search term in the simple search box will search all bugs. So 'ALL Library::CallNumber::LC' returns a result set which includes this bug. HTH -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 20:02:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 19:02:32 +0000 Subject: [Koha-bugs] [Bug 11316] plugin icon missing tooltip in addbiblio.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11316 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 21:53:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 20:53:30 +0000 Subject: [Koha-bugs] [Bug 4292] deleting a budget leaves funds orphaned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4292 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Assignee|henridamien at koha-fr.org |koha-bugs at lists.koha-commun | |ity.org Severity|critical |major -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 21:53:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 20:53:46 +0000 Subject: [Koha-bugs] [Bug 4292] deleting a budget leaves funds orphaned In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4292 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |mathieu.saby at univ-rennes2.f |ity.org |r -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 23:03:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 22:03:06 +0000 Subject: [Koha-bugs] [Bug 11317] New: Add a way to access log files from the intranet. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Bug ID: 11317 Summary: Add a way to access log files from the intranet. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt at gmail.com Reporter: fcapovilla at live.ca QA Contact: testopia at bugs.koha-community.org Created attachment 23203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23203&action=edit Adds a page to access log files on the server from the intranet. This patch adds a new report section (Report/log files) that lets you access log files in a specific directory on the server. The directory to use can be specified by the "publiclogdir" config in koha-conf.xml : ... /var/log/koha-public ... With this feature, you can configure cron scripts so they create files in the publiclogdir directory, and these files will then be accessible in the intranet. This is useful when using the html export of overdue_notices.pl or the invalid_856u.sh script as a cron. Sponsored-by: CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 23:03:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 22:03:57 +0000 Subject: [Koha-bugs] [Bug 11317] Add a way to access log files from the intranet. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317 Fr?d?rick Capovilla changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 23:49:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 22:49:42 +0000 Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than "any" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11291 | Bot Control|Ignore this bug |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 23:49:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 22:49:42 +0000 Subject: [Koha-bugs] [Bug 11291] Change the behavior of any index in DOM indexing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11291 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|8962 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 00:02:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 23:02:39 +0000 Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than "any" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 --- Comment #31 from mathieu saby --- I've removed the dependency on bug 11291. It was not a "real" dependancy. I just want to wait for bugs 11291 and 11202 being pushed to master before writing the DOM followup for this patch. I also wait for this patch to be tested and signed off with the current indexing style (GRS1) before porting it for DOM. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 00:51:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2013 23:51:00 +0000 Subject: [Koha-bugs] [Bug 8962] Create a new index for OPAC simple search, more specific than "any" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8962 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21985|0 |1 is obsolete| | --- Comment #32 from mathieu saby --- Created attachment 23204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23204&action=edit [PATCH 1/3] Bug 8962: Changes to CCL.properties, bib1 for authorities, and templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 06:51:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 05:51:00 +0000 Subject: [Koha-bugs] [Bug 11318] New: Overdues won't send if first trigger lacks a delay value Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11318 Bug ID: 11318 Summary: Overdues won't send if first trigger lacks a delay value Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: dcook at prosentient.com.au QA Contact: testopia at bugs.koha-community.org Overdue notices will not send if the first overdue trigger lacks a delay value (i.e. if the delay1 field in the overduerules table table is null). It doesn't matter if your second and third triggers are set with notices and values. If you have a notice and no value for the first, that's it - nothing. This behaviour has a certain logic to it, I suppose, but as Katrin has pointed out, it could perhaps fail nicer and print a message saying there are other triggers set but they can't be reached since the first one is null. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 08:29:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 07:29:17 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #31 from M. de Rooy --- Hi Mark, I did not look at the third patch obviously :) Will have a look soon. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 10:25:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 09:25:24 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #32 from M. de Rooy --- (In reply to M. Tompsett from comment #30) > Also, my patch depends on his, so should I squash our patches together, and > get a single sign off? Should I correct mine after he corrects his? This is > a very weird scenario to have with 3 pieces in 3 vastly different states. > I'm happy to fix them any which way, but what is the best course of action? I agree with most changes, including the one where s_userid and q_userid are compared. I think the second patch should not be pushed in its current form, although the third patch resolves the situation. So I recommend to squash both patches and get a signoff on the new patch. If you can add a test plan too, go ahead :) One point remaining: I do not agree with the PKIAuth change in your last patch. If you do: + my $pki_field = C4::Context->preference('AllowPKIAuth') // ''; combined with: || $pki_field ne 'None', what is the result? An undef in AllowPKIAuth now makes None ne '' so the compare is true. The test should only be true if AllowPKIAuth is a value not equal to None or empty string (undef). So leaving it preference // None was correct. Thanks for your attention to these details! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 11:17:21 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 10:17:21 +0000 Subject: [Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #33 from Jonathan Druart --- (In reply to Galen Charlton from comment #32) > Kyle, Paul, Jonathan: do any of you have the wherewithal to run with that > idea for 3.16? I don't plan to work on that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 11:53:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 10:53:38 +0000 Subject: [Koha-bugs] [Bug 11129] Filtering Items based on type in opac-detail.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11129 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23172|0 |1 is obsolete| | --- Comment #8 from Olli-Antti Kivilahti --- Created attachment 23205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23205&action=edit Bug 11129 - Filtering Items based on type in opac-detail.pl Currently all Items are always shown on the opac-detail.pl. This is difficult when the amount of Items grows substantially large. Implemented a filter to limit the Items shown (and SELECTed from the DB) based on some typical filters, locationbranch, volume, number, issue, fromDate, toDate. Also streamlined how Serials-data is pulled from the DB to prevent substantial extra work in C4::Items::GetItemsInfo(). C4::Items::GetItemsInfo() extended to support various filters. All modifications: Item filter shown when there are over 50 items (lotsofitems-flag). Filter fields can be changed based on the Biblio type (isSerial-flag). -Volume + Issue + Number available only for serials. Can syspref if Issue-field is used in serial records. Can syspref a regexp to parse the Volume + Number + Issue from the enumeration or chronology field. FromDate and ToDate filter the serial.publisheddate when dealing with serials otherwise target the items.timestamp -column. C4::Items::GetItemsInfo() simplified to include the serial data in the BIG SQL. This makes filtering by publisheddate much more faster. User input validated using HTML5 Business layer validations as well. Unit tests: Serials enumeration and chronology filtering Items date and branch filtering Sponsored by the Joensuu Regional Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:34:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 11:34:29 +0000 Subject: [Koha-bugs] [Bug 11319] New: Marc modification templates improvements Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Bug ID: 11319 Summary: Marc modification templates improvements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt at gmail.com Reporter: jonathan.druart at biblibre.com QA Contact: testopia at bugs.koha-community.org Bug 8015 is pushed and I plan to take over bug 5725. The idea will be to provide a batch modification tools for records (biblios and authorities). But before, I have to prepare the ground: Koha::SimpleMARC does not split clearly fields and subfields manipulations. The API should provide routines like copy_field and copy_subfield for example. Later the UI will have to reflect this change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:38:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 11:38:36 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 --- Comment #1 from Jonathan Druart --- Created attachment 23206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23206&action=edit Bug 11319: POC Marc modification templates improvements This patch is a POC. Please give me your feedback on the implementation of the fields/subfields split. This patch only implements the delete and the read routines. See new UT at the end of t/SimpleMARC.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:40:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 11:40:09 +0000 Subject: [Koha-bugs] [Bug 11319] Marc modification templates improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |gmcharlt at gmail.com, | |kyle at bywatersolutions.com Depends on| |8015 Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- Kyle and Galen, I really would like to have your opinion on this patch please. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:40:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 11:40:09 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11319 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 13:01:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 12:01:32 +0000 Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by default in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23173|0 |1 is obsolete| | --- Comment #10 from Olli-Antti Kivilahti --- Created attachment 23207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23207&action=edit Bug 6385 - All items should optionally be displayed by default in the OPAC Added a system preference "OPACmaxItemsOnDetail" to set a threshold after which only results from the users branch are displayed, or Items from the past year if homebranch cannot be defined. This tightly couples with bug 11129 which provides the filtering mechanism to display smaller result sets. Also added lots of complexity to define the warning messages based on is the filter used to override the "OPACmaxItemsOnDetail". Added a new "limit"-filter to C4::Items::GetItemsInfo() which adds the LIMIT-clause to the big SQL. Added a unit test for the filter to the Items.t Fixed a use-case where a user has no items in his branch, and the limited items set is emtpy. Now using items from past year if none available in the users branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 13:12:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 12:12:36 +0000 Subject: [Koha-bugs] [Bug 6385] All items should optionally be displayed by default in the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6385 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23207|0 |1 is obsolete| | --- Comment #11 from Olli-Antti Kivilahti --- Created attachment 23208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23208&action=edit Bug 6385 - All items should optionally be displayed by default in the OPAC Added a system preference "OPACmaxItemsOnDetail" to set a threshold after which only results from the users branch are displayed, or Items from the past year if homebranch cannot be defined. This tightly couples with bug 11129 which provides the filtering mechanism to display smaller result sets. Also added lots of complexity to define the warning messages based on is the filter used to override the "OPACmaxItemsOnDetail". Added a new "limit"-filter to C4::Items::GetItemsInfo() which adds the LIMIT-clause to the big SQL. Added a unit test for the filter to the Items.t Fixed a use-case where a user has no items in his branch, and the limited items set is emtpy. Now using items from past year if none available in the users branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 13:27:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 12:27:56 +0000 Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for serials. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22571|0 |1 is obsolete| | --- Comment #18 from Olli-Antti Kivilahti --- Created attachment 23209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23209&action=edit Bug 11157 - Placing a simple item-level hold for serials in OPAC. For biblios marked as a serial or if the syspref: -OPACShowPlaceItemLevelHold or is enabled. Adds a "Place hold"-link after each item in the detailed biblio view. Uses the template parameter 'norequest', to disable the "Place hold"-link in the sidebar opac-detail-sidebar.inc for serials. Added a new parameter itemnumber to opac-reserve.pl/.tt. This causes the reserving module to display only the desired item, preselect it and hide unnecessary buttons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 13:28:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 12:28:58 +0000 Subject: [Koha-bugs] [Bug 11157] Placing a simple item-level hold for serials. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11157 Olli-Antti Kivilahti changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22572|0 |1 is obsolete| | --- Comment #19 from Olli-Antti Kivilahti --- Created attachment 23210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23210&action=edit Bug 11157 - Placing a simple item-level hold for serials in staff client. For biblios marked as a serial or if the syspref: -ShowPlaceItemLevelHold is enabled. Adds a "Place hold"-link after each item in the detailed biblio view. Added a new parameter itemnumber to reserve.pl/.tt. This causes the reserving module to display only the desired item, preselect it and hide unnecessary buttons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 14:41:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 13:41:15 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m QA Contact|testopia at bugs.koha-communit |jonathan.druart at biblibre.co |y.org |m --- Comment #9 from Jonathan Druart --- Looks good, the patch works as expected. No regression found. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 14:41:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 13:41:26 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20710|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 23211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23211&action=edit Bug 10774 - Allow individual holds to be suspended and resumed from the OPAC Right now, holds can only be suspended and resumed from the OPAC as a whole. It would be nice to be able to suspend and resume holds on a hold by hold basis from the OPAC. Test Plan: 1) Apply this patch 2) Log in to the OPAC 3) Place a number of holds 4) Browse to "my summary" and select the holds tab 5) From here, test the following actions a) Suspend a hold indefinitely ( no resume date ) b) Suspend a hold with a date to automatically resume c) Manually resume a suspended hold 6) Disable AutoResumeSuspendedHolds, ensure the suspend until date field is no longer visible. 7) Disable SuspendHoldsOpac, ensure all suspension related fields are no longer visible. Signed-off-by: Chris Rohde Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:14:00 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:14:00 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- Kyle, The patch works but don't you think it is easier to parse the variable value and assume it is a date if it matches YYYY-MM-DD or YYYY-MM-DD HH:MM:SS? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:15:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:15:06 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 --- Comment #11 from Jonathan Druart --- Created attachment 23212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23212&action=edit [ALT] Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:15:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:15:46 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23212|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:16:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:16:03 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 --- Comment #12 from Jonathan Druart --- Wrong bug number... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:16:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:16:30 +0000 Subject: [Koha-bugs] [Bug 11244] notices ignoring the dateformat preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11244 --- Comment #5 from Jonathan Druart --- Created attachment 23213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23213&action=edit [ALT] Bug 11244: notices ignoring the dateformat preference Overdue notices are using the MySQL date format and not the dateformat in the system preferences. Test Plan: 1) Enable checkout notices for a patron, make sure the date due is in the notice. 2) Check out an item to that patron, note the date is in the mysql datetime format 3) Apply this patch 4) Check out another item to the patron, not the date is now in the preferred date format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:18:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:18:52 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:34:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:34:53 +0000 Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins at cpbibliography.com --- Comment #6 from Jonathan Druart --- (In reply to Blou from comment #3) > Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced > it but I couldn't find ANY usage of it to fix. Same for me. Jared, could you confirm your development for Offline circulation (bug 10240) includes this js file but don't use it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:34:53 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:34:53 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23199|0 |1 is obsolete| | --- Comment #33 from M. Tompsett --- Created attachment 23214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23214&action=edit Bug 11077 - Correct silent warnings in C4/Auth.pm This patch corrects a noisy ne condition. $userid = $retuserid if ( $retuserid ne ''); became $userid = $retuserid if ( $retuserid ); It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's patch, while correcting the problems found. This includes: my $q_userid = $query->param('userid') // ''; along with: my $s_userid = ''; and: my $s_userid = $session->param('id') // ''; Indentation does not reflect actual scoping. And the 'None' is changed to '', since that behaves properly in the undef case: my $pki_field = C4::Context->preference('AllowPKIAuth'); if (!defined($pki_field)) { print STDERR "Error: Missing AllowPKIAuth System Preference!\n"; $pki_field = ''; } Because if it was set to 'None' in the undefined case, then 'None' ne 'None' is false, and the if case would not run. However, undef ne 'None' is true and runs with an error log entry. By putting the define check as a separate if clause, a meaningful error message can be given rather than a ubiquitous undef compare check failure message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:37:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:37:29 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #34 from M. Tompsett --- Created attachment 23215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23215&action=edit Confirmation of what I said regarding undef ne 'None' I believe this clarifies the problem even better, and this sample program demonstrates why I believe '' is the correct value to default in the undef case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:38:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:38:58 +0000 Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 --- Comment #7 from Jared Camins-Esakov --- (In reply to Jonathan Druart from comment #6) > (In reply to Blou from comment #3) > > Seems a new file circ/offline-mf.tt got added with hotkeys.js. I replaced > > it but I couldn't find ANY usage of it to fix. > > Same for me. Jared, could you confirm your development for Offline > circulation (bug 10240) includes this js file but don't use it? The offline circulation module includes the file via doc-head-close.inc. If the file is changed there, it must be changed in the manifest as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:43:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:43:17 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #35 from M. de Rooy --- (In reply to M. Tompsett from comment #34) > Created attachment 23215 [details] > Confirmation of what I said regarding undef ne 'None' > > I believe this clarifies the problem even better, and this sample program > demonstrates why I believe '' is the correct value to default in the undef > case. Maybe we have some misunderstanding? Correct me if I am wrong but if PKIAuth is None or undef, the if statement should not be run (so we should make the expr be false). Do you agree? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:48:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:48:29 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #36 from M. Tompsett --- (In reply to M. de Rooy from comment #35) > Maybe we have some misunderstanding? We may have some cross-talk. > Correct me if I am wrong but if PKIAuth is None or undef, the if statement > should not be run (so we should make the expr be false). > Do you agree? My sample program demonstrates how it currently works and does not make a judgement one way or another about how it should work. Using '' mimics current behaviour. And though that may not be correct in how it should behave, patches fixing one thing (floody logs) should not cause a behaviour change in another (how it does work). If the issue remains about how it should work (as compared to how it does work), that would be another bug fix in my opinion. Does that clarify where I am coming from? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:51:49 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:51:49 +0000 Subject: [Koha-bugs] [Bug 8753] Add forgot password link to OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #21 from Jonathan Druart --- Early QA comment: 1/ new routine needs unit tests 2/ remove tab characters 3/ perltidy new pl script 4/ use Modern::Perl; (you only use strict) 5/ only 1 syspref is added to sysprefs.sql 6/ why don't you sent the email using utf8? 7/ on generating the new password char, maybe should you use the alphabet syspref (+ numbers) 8/ why don't you use koha opac header for opac-send-password-recovery template file? 9/ use the tt plugin to access to syspref value (Koha.Preference("mypref")). 10/ what is the 'UNAUTHORIZ' check (in opac-password-recovery.pl)? 10 is a good number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 15:57:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 14:57:19 +0000 Subject: [Koha-bugs] [Bug 11035] Replace shortcut plugin jquery.hotkeys.min.js In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11035 --- Comment #8 from Jonathan Druart --- Haaa :) Thanks Jared for the clarification! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 16:59:32 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 15:59:32 +0000 Subject: [Koha-bugs] [Bug 9224] acqui/finishreceive.pl is not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 17:01:50 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 16:01:50 +0000 Subject: [Koha-bugs] [Bug 9224] acqui/finishreceive.pl is not Plack-compatible In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9224 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22020|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 23216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23216&action=edit Bug 9224: Make acqui/finishreceive.pl Plack-compatible Under Plack/mod_perl wrapping, sub update_item() will become a closure, so after the 1st run it will retain it's own private instances of the following variables: $booksellerid, $datereceived, $unitprice, $rrp, $biblionumber. I.e., in case update_item() gets invoked 2nd+ time (inside the same process, but for different-subsequent receives) it may incorrectly flag the (old, wrong) biblionumber for Zebra reindexing, and erronously modify the current item[s] with the previously used (wrong) values. This simple patch should make acqui/finishreceive.pl Plack-compatible. Test plan: Test patched acqui/finishreceive.pl script (create and receive some orders w/ items, etc.). Ensure items are gettting added and/or modified correctly during receiving process. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 18:52:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 17:52:23 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #37 from M. de Rooy --- (In reply to M. Tompsett from comment #36) > > Correct me if I am wrong but if PKIAuth is None or undef, the if statement > > should not be run (so we should make the expr be false). > > Do you agree? > > My sample program demonstrates how it currently works and does not make a > judgement one way or another about how it should work. Using '' mimics > current behaviour. And though that may not be correct in how it should > behave, patches fixing one thing (floody logs) should not cause a behaviour > change in another (how it does work). If the issue remains about how it > should work (as compared to how it does work), that would be another bug fix > in my opinion. Does that clarify where I am coming from? That makes sense. Actually, we are talking about functionality. But for such a fictive situation (you need to delete your AllowPKIAuth pref and have all other conditions be false), I think we do not need to open a new report. This "behavior change" is so minimal that touching this line and fixing it can be done rightaway. For the record, the behavior change is actually made in the first patch that has been signed off and passed qa and your third patch changes it back to current behavior with the latent undef-mini-minibug. But if you scroll through the code, you will see that in both cases the overall effect will be: userid=return=0, auth rejected. So no big deal. Just theory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 19:23:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 18:23:58 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #38 from M. Tompsett --- Created attachment 23217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23217&action=edit Bug 11077 - Fix indents to trace code more easily -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 19:35:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 18:35:52 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #39 from M. Tompsett --- Yes, my patch does change it back. I did as you suggested and looked at the code again. If we set the variable to 'None', it bypasses the if completely. If we set the variable to '', it goes through the elsif check, but runs the else which fail (due to a lack of userid). The return check fails, triggering the else which does nothings, because of the lack of userid. In the end, a lack of login is accomplished either way. Since 'None' was approved via the QA process, I'll change my patch to exclude that tweak. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 19:36:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 18:36:11 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23217|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 19:45:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 18:45:40 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23214|0 |1 is obsolete| | --- Comment #40 from M. Tompsett --- Created attachment 23218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23218&action=edit Bug 11077 - Correct silent warnings in C4/Auth.pm This patch corrects a noisy ne condition. $userid = $retuserid if ( $retuserid ne ''); became $userid = $retuserid if ( $retuserid ); It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's patch, while correcting the problems found. This includes: my $q_userid = $query->param('userid') // ''; along with: my $s_userid = ''; and: my $s_userid = $session->param('id') // ''; Indentation does not reflect actual scoping. A missing system preference would have triggered a ubiquitous undef compare check failure message. This makes the flooding message more useful, so as to help correct it. The change to accomplish this was: my $pki_field = C4::Context->preference('AllowPKIAuth'); if (!defined($pki_field)) { print STDERR "Error: Missing AllowPKIAuth System Preference!\n"; $pki_field = 'None'; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 19:46:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 18:46:44 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23215|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 20:04:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 19:04:39 +0000 Subject: [Koha-bugs] [Bug 8676] show vendor name in source of acquisition In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8676 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 20:07:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 19:07:56 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #41 from M. Tompsett --- Test Plan: - Go to staff client - Click the login button without typing anything - Type just a username without a password and click the login button - Backup DB - Delete the AllowPKIAuth System Preference - Restore DB Note the amount of noise. - Apply Patches (All three) - Go to staff client - Click the login button without typing anything - Type just a username without a password and click the login button - Backup DB - Delete the AllowPKIAuth System Preference - Restore DB The only noise should be the clarified error: ERROR: Missing system preference AllowPKIAuth. This makes the non-sensical flood clearer. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 20:25:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2013 19:25:57 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #42 from M. Tompsett --- (In reply to M. Tompsett from comment #41) > - Delete the AllowPKIAuth System Preference Oops... and click the login button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 03:45:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 02:45:47 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23218|0 |1 is obsolete| | --- Comment #43 from M. Tompsett --- Created attachment 23219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23219&action=edit Bug 11077 - Correct silent warnings in C4/Auth.pm This gets rid of some more warnings. It also corrects a noisy ne condition. $userid = $retuserid if ( $retuserid ne ''); became $userid = $retuserid if ( $retuserid ); It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's patch, while correcting the problems found. This includes: my $q_userid = $query->param('userid') // ''; along with: my $s_userid = ''; and: my $s_userid = $session->param('id') // ''; Indentation does not reflect actual scoping. A missing system preference would have triggered a ubiquitous undef compare check failure message. This makes the flooding message more useful, so as to help correct it. The change to accomplish this was: my $pki_field = C4::Context->preference('AllowPKIAuth'); if (!defined($pki_field)) { print STDERR "Error: Missing AllowPKIAuth System Preference!\n"; $pki_field = 'None'; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 03:46:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 02:46:17 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23198|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 03:50:25 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 02:50:25 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #44 from M. Tompsett --- Confirmed with Srdjan Jankovic that is was okay to squash our patches together. All should be good to go. Here is the latest test plan: - Go to staff client - Click the login button without typing anything - Type just a username without a password and click the login button - Backup DB - Delete the AllowPKIAuth System Preference, and refresh the staff client. - Restore DB Note the amount of noise. - Apply Patches (Both) - Go to staff client - Click the login button without typing anything - Type just a username without a password and click the login button - Backup DB - Delete the AllowPKIAuth System Preference, and refresh the staff client. - Restore DB The only noise should be the clarified error: ERROR: Missing system preference AllowPKIAuth. This makes the non-sensical flood clearer. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 08:24:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 07:24:59 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 Doug Kingston changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22458|0 |1 is obsolete| | Attachment #22506|0 |1 is obsolete| | Attachment #22508|0 |1 is obsolete| | Attachment #22532|0 |1 is obsolete| | Attachment #22985|0 |1 is obsolete| | Attachment #22992|0 |1 is obsolete| | --- Comment #33 from Doug Kingston --- Created attachment 23220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23220&action=edit Bug 11078 Add locking to rebuild_zebra (rollup 11/28) This patch is a rollup of earlier patches and moves the lockfile to a parallel directory to the other zebra lock files. This should address all the issues as to where this file should be indifferent cases. It now behaves just like the other zebra lock files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:09:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 08:09:55 +0000 Subject: [Koha-bugs] [Bug 11078] rebuild_zebra.pl can lose updates due to race condition during full rebuilds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11078 --- Comment #34 from Doug Kingston --- Created attachment 23221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23221&action=edit Minor fix to path used by rebuild_zebra for locking to match docs. Minor bug found in tests. Code worked but did not match docs or intent. Actually put the lockfile in ZEBRA_LOCK_DIR/rebuild/rebuild..LCK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:10:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 08:10:14 +0000 Subject: [Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219 --- Comment #5 from Fridolyn SOMERS --- (In reply to Katrin Fischer from comment #4) > Hi Fridolin and Team AMU, > is there a way to test this without a working CAS environment? I don't know. But I'd say same has Bug 10029. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:49:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 08:49:36 +0000 Subject: [Koha-bugs] [Bug 7565] Fee/fines receipt for printing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7565 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:51:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 08:51:35 +0000 Subject: [Koha-bugs] [Bug 8378] syntax not working on overdues anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8378 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 10:58:22 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 09:58:22 +0000 Subject: [Koha-bugs] [Bug 11246] Followup for Bug 10465 fields 780 and 785 in UNIMARC XSLT should be removed in bootstrap theme In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11246 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:29:01 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 10:29:01 +0000 Subject: [Koha-bugs] [Bug 11302] Template::output should deal with object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302 Petter Goks?yr ?sen changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros at gmail | |.com --- Comment #3 from Petter Goks?yr ?sen --- When I apply this patch, I get failure on the plugins page: http://localhost:8080/cgi-bin/koha/plugins/plugins-home.pl Software error: Not a HASH reference at /home/boutros/Projects/deichman/kohaclone/C4/Templates.pm line 158. Note that I have installed a plugin with non-ascii characters, so that might be why -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:57:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 10:57:48 +0000 Subject: [Koha-bugs] [Bug 7180] Order from staged file improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7180 --- Comment #142 from mathieu saby --- Hello I did not test, but made comments on your algorithm. I still have reserves on some points. Mathieu > > The value in 947$c *includes* the tax. > The rrp and ecost values are calculated depending on the supplier > configuration. I did not realize that... So if you have a RRP in 010$d and a price in 947$c, you recalculate RRP from the value of 947$c? Maybe it is useful for old books where the value of 010 is obsolete or written in Francs and not Euros? > > I rewrite the algorithm: > > So, the imported file always contains: Not always ;-) Only records from some vendors will contains price and discount. If those data are not provided, I suppose the behavior should be the same as before (ecost calculated from the value of the field containing RRP : 010$b and 345$d)? By the way, could you tell me if there will be a way to define the syspref to take a type of price (RRP or "price") from 2 fields, like "010 or 345" or "347 or 345". It is important, as DVD prices are only stored in 345 field, which is not important for books. So, currently, DVD are correctly taken into account by Koha, and it must still be the case with your patch. > price = include tax with the discount > discount = the discount > ecost : unit price with discount > RRP : unit price > > If the supplier includes tax: > ecost = unit price with discount, tax include > RRP = unit price, tax include > > If a discount exists in the file: > ecost = price > RRP = ecost/(1-discount) Just "translating" it with numeric values, to be sure I understand: price (in 347 field for ex.) : 94.95 ? incl. tax. discount (in some field): 10 ecost : calculated from price : 94.95 ? incl. tax. RRP : calculated from price : 105.5 ? (=94.95 / (1-0.10)) incl. tax. > > If no discount in the file: > RRP = price > ecost = price*(1-discount [from supplier]) > So when you say "no discount", you mean "no value of discount stored in some field" AND "no discount taken into account in the calculation of price asked by vendor". So you suppose that if, for ex. 969$h is void, 947 will contain a RRP price. Are we sure it should be an absolute rule? Maybe for some vendors, but we can probably imagine a vendor just giving us the discounted price in some field, without giving us the rate of the discount. > > If the supplier does not include tax: > ecost = unit price with discount, tax exclude > RRP = unit price, tax exclude > > If a discount exists in the file: > ecost = price/(1+tax) > RRP = ecost/1-discount price (in 347 field for ex.) : 90 ? excl. tax. discount (in some field): 10 ecost : calculated from price : 90 ? excl. tax. RRP : calculated from price : 100 ? (=94.95 / (1-0.10)) excl. tax. So, your RRP will be an excl. tax. RRP. But in 010$d the record may contain a incl. tax. RRP, which is used currenty by Koha. So you are changing Koha's behavior regarding RRP. That is what surprises me in my tests. And I still don't agree. I think we must be clear on *what* is exactly a RRP in Koha. Could RRP be with or without tax depending on the preferences? I don't like this idea, as RRP means "the price in any bookseller, outside the libraries". So RRP should not be with/without tax depending on library's preferences. I would prefer a rule saying "RRP is always with tax", so if it is calculated from a "vendor price" without tax, tax must be added. And if needed (to avoid rounding errors for ex), we can calcule and store an second version of RRP, without tax, that we may call "RRPe" > > If no discount in the file: > RRP = price/(1+tax) > ecost = RRP(1-discount [from supplier]) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 12:06:59 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 11:06:59 +0000 Subject: [Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077 --- Comment #45 from M. de Rooy --- Thanks, Mark. Since the patch still is on the name of Srdjan, I would like to ask him to test the patch again. After that please add your signoff, Mark. Since this looks good to me, QA will not take that much time any more :) Note that print STDERR could be a warn, and personally I do not think that it is really necessary to warn here but others think so. Fine with me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 13:01:14 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 12:01:14 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 13:14:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 12:14:34 +0000 Subject: [Koha-bugs] [Bug 9254] Problem with EnhancedMessagingPreferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9254 --- Comment #20 from Koha Team AMU --- We wanted to test this patch but it doesn't apply on a sandbox : "Applying: Bug 9254: Problem with EnhancedMessagingPreferences\nUsing index info to reconstruct a base tree...\nFalling back to patching base and 3-way merge...\nAuto-merging C4/Auth.pm Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl\nFailed to merge in the changes.\nPatch failed at 0001 Bug 9254: Problem with EnhancedMessagingPreferences\nWhen you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort".\nBug 9254 - Problem with EnhancedMessagingPreferences" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 13:33:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 12:33:37 +0000 Subject: [Koha-bugs] [Bug 11320] New: Ambiguous message when a duplicate record is detected Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11320 Bug ID: 11320 Summary: Ambiguous message when a duplicate record is detected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt at gmail.com Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When a duplicate record is detected, the text in the 'Yes' button is "Yes, Edit existing items". It should be "Yes, Edit existing record" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 13:45:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 12:45:12 +0000 Subject: [Koha-bugs] [Bug 3445] action_logs table needs some thought In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3445 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #4 from mathieu saby --- It needed a little rebase in updatedatabase, but it works. I sign off. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 13:45:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 12:45:20 +0000 Subject: [Koha-bugs] [Bug 3445] action_logs table needs some thought In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3445 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 13:47:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 12:47:07 +0000 Subject: [Koha-bugs] [Bug 3445] action_logs table needs some thought In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3445 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23024|0 |1 is obsolete| | --- Comment #5 from mathieu saby --- Created attachment 23222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23222&action=edit [PATCH]SIGNED OFF Bug 3445 - action_logs table needs indexes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 13:51:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 12:51:56 +0000 Subject: [Koha-bugs] [Bug 11302] Template::output should deal with object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302 --- Comment #4 from M. de Rooy --- First observation: If I put a diacritical char in the branchname, the staff home page will show a mangled char in the upper-right corner (directly after login). If you refresh after login or come back there, it will disappear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 13:57:10 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 12:57:10 +0000 Subject: [Koha-bugs] [Bug 11302] Template::output should deal with object In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11302 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from M. de Rooy --- Some (!) additional observations: Facets in staff search show mangled chars. Patron category (with latin diacritic and chinese char) on memberentry.pl mangled. Branch name mangled too on memberentry.pl Catalogue detail: mangled chars all over the place. Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 14:01:30 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 13:01:30 +0000 Subject: [Koha-bugs] [Bug 11249] Add db indexes on borrowers names In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11249 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23001|0 |1 is obsolete| | CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #3 from mathieu saby --- Created attachment 23223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23223&action=edit [PATCH][SIGNED OFF] Bug 11249 - Add db indexes on borrowers names It works, I sign off. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 14:09:09 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 13:09:09 +0000 Subject: [Koha-bugs] [Bug 10860] In-House Use In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #15 from mathieu saby --- Hi. I wanted to test, but I've got the following message. Maybe my VM is not clean, or it is something to fix in the patch? :1276: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: misc/cronjobs/bulk_transferts.pl Please move or remove them before you can merge. Aborting If it needs rebase, could you replace "13.00" by "15.00" in updatedatabase ? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:02:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 14:02:57 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #16 from Martin Renvoize --- Created attachment 23224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23224&action=edit Bug 8446: Ensure user is returned to requested page after auth Added querystring to the target path in shibboleth URL so that when a user is authenticated he/she is returned to the correct page they requested before authentication. (think clicking a link to opac-detail.pl?biblionumber=12345) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:33:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 14:33:26 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:34:29 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 14:34:29 +0000 Subject: [Koha-bugs] [Bug 10774] Allow individual holds to be suspended and resumed from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10774 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED CC| |gmcharlt at gmail.com --- Comment #13 from Galen Charlton --- Pushing back to submitter for more work -- this patch series doesn't yet cover the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:37:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 14:37:03 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 Koha Team AMU changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.aixmarseille at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:38:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 14:38:35 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22860|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize --- Created attachment 23225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23225&action=edit MT8122: Adds Shibboleth authentication - Use the shibbolethAuthentication syspref to enable Shibboleth authentication - Configure the shibbolethLoginAttribute to specify which shibboleth user attribute matches the koha login - Make sure the OPACBaseURL is correctly set MT8122, Follow-up: Adds Shibboleth authentication - Fix logout bug: shibboleth logout now occurs only when the session is a shibboleth one. - Do some refactoring: getting shibboleth username is now done in C4::Auth_with_Shibboleth.pm (get_login_shib function) MT8122, Follow-up: Adds Shibboleth authentication - Adds redirect to opac after logout MT8122, Follow-up: Adds Shibboleth authentication - Shibboleth is not compatible with basic http authentication in C4/Auth.pm. This patch fixes that. MT8122, Follow-up: Adds Shibboleth authentication - Use ENV{'SERVER_NAME'} instead of syspref OpacBaseURL in order to work with multiple vhosts. MT8122, Follow-up: Adds Shibboleth authentication - Adds missing protocol for $ENV{'SERVER_NAME'} Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:38:48 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 14:38:48 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23224|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize --- Created attachment 23226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23226&action=edit BUG8446, Follow up: Adds Shibboleth authentication - Use syspref OpacBaseURL instead of ENV{'SERVER_NAME'} as this wont work if koha is behind a reverse proxy. - To use multiple vhosts, set OpacBaseURL per vhost explicitly with 'SetEnv OpacBaseURL Value' as per Bug 10325 BUG8446, Follow up: Adds Shibboleth authentication - Ensure user is returned to requested page after authentication - Added querystring to the target path in shibboleth URL so that when a user is authenticated he/she is returned to the correct page they requested before authentication. Example where this is important: When a user clicks a direct biblio link of the form - /opac-detail.pl?biblionumber=12345 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:40:58 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 14:40:58 +0000 Subject: [Koha-bugs] [Bug 8446] Shibboleth authentication patch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446 --- Comment #19 from Martin Renvoize --- Re-based upon master and re-squashed the commits to better reflect their authors. First patch is all Matthias's work, and second patch are my two follow up fixes to that work. Hope we can find someone to test this, I'd love to see it in community. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:44:19 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 14:44:19 +0000 Subject: [Koha-bugs] [Bug 11183] Warnings in opac In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #24 from Galen Charlton --- Pushed to master. Thanks, Srdjan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:46:26 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 14:46:26 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 --- Comment #30 from Koha Team AMU --- I applied the patch on a sandbox and had the following message : The sandbox you've requested is not ready. Some problems occurred applying patches from bug 10863:

Something went wrong !

Applying: Bug 10863: Add 2 circulation permissions: force_checkout and lift_restriction Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/borrower_debarments.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Failed to merge in the changes. Patch failed at 0001 Bug 10863: Add 2 circulation permissions: force_checkout and lift_restriction When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 10863 - Add 2 circulation permissions: force_checkout and lift_restriction 22717 - Bug 10863: Add 2 circulation permissions: force_checkout and lift_restriction Apply? [(y)es, (n)o, (i)nteractive] Patch left in tmpBug-10863-Add-2-circulation-permissions-forcecheck-Vi1MDW.patch . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:54:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 14:54:57 +0000 Subject: [Koha-bugs] [Bug 11242] fix opac-MARCdetail.pl bizarre ordering of data and noisy warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11242 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #9 from Galen Charlton --- Pushed to master. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:03:46 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 15:03:46 +0000 Subject: [Koha-bugs] [Bug 2546] Description of charges: string hardcoded In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2546 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #12 from Galen Charlton --- (In reply to Kyle M Hall from comment #11) > Bug 6427 will also obviate this issue. I believe it will be pushed to master > before the 3.16 release, and would recommend *not* pushing this patch to > master. However, it should definitely be pushed for 3.14.x and earlier. The accounts rewrite is still very much a work in progress and will require more discussion and testing, so it is premature to consider it a blocker for patches that implement current fixes -- particularly as it is preferable that patches destined for backporting to a maintenance branch show up in master first. I don't see anything in Jonathan's patch that blocks anything proposed by the accounts rewrite. If there is something, Kyle, this is your opportunity to speak up about it (although since you have already indicated that you believe it suitable for maintenance branches, I would assume that you don't know of any such blocker). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:15:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 15:15:06 +0000 Subject: [Koha-bugs] [Bug 11321] New: "On hold" items can't be placed on hold with allowonshelfholds off Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11321 Bug ID: 11321 Summary: "On hold" items can't be placed on hold with allowonshelfholds off Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, Susanne.Jerger at bsz-bw.de When holds on items available items are not allowed (allowonshelfholds = don't allow), it's impossible to place holds on items that are 'on hold' (awaiting pickup). The item is not checked out yet, but unavailable to the patron and I think holds should be allowed in this case. To test: Set allowonshelfholds to don't allow 0) Search for a record with 1 available item Opac status: available No hold can be placed. 1) Check out item to user A Opac status: checked out 'Place hold' button is shown and holds can be placed. 2) Place a title level hold for user B Opac status: checked out 'Place hold' button is shown and holds can be placed. 3) Return item and confirm hold Opac status: on hold No hold can be placed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:15:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 15:15:47 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 Galen Charlton changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt at gmail.com --- Comment #4 from Galen Charlton --- Sure about this? dateonly => 1 is not exactly equivalent to what format_sqlduedatetime and output_pref_due output. This is most evident for hourly loans: Due date/time Current display in opac-reserves New display ----------------- -------------------------------- ----------- 2013-12-01 23:59 2013-12-01 2013-12-01 2013-12-01 13:25 2013-12-01 13:25 2013-12-01 IOW, this patch would cause a (minor) net loss of displayed information for patrons if hourly loans are being used. Changing status to have a discussion of the desired display of due times for hourly loans. I will note that I *do* think that output_pref_due and format_sqlduedatetime can be removed, but it may be advisable to add a display_as_due_date flag or similarly to output_pref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:29:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 15:29:54 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 --- Comment #3 from Fridolin SOMERS --- Created attachment 23227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23227&action=edit Bug 11242: fix opac-MARCdetail.pl display and warnings This patch improves the public catalog MARC view display of records that contain subfields that are not defined in the framework used by the bib record. To test: (RM note: it may be easier to find or create a MARC record that contains a subfield not present in the default framework, then load it, rather than fiddle with the MARC frameworks in your test database.) BACK UP YOUR DATABASE! 1) Search for an item in OPAC 2) Open OPAC detail 3) Click 'MARC View' link 4) Look for something with multiple lines (e.g. 260 or 942) 5) In another tab, Go to staff client and log in 6) Go to the staff client URL similar to: /cgi-bin/koha/catalogue/detail.pl?biblionumber=##### page where ##### is the biblionumber. 7) Edit -> record 8) Note the framework used. 9) More -> Administration 10) MARC bibliographic frameworks 11) Click 'MARC structure' for the framework used by the item shown in OPAC. 12) Find the tag (e.g. 260 or 942) and click 'Subfields' 13) Delete of the matching subfields (e.g. 260$b) shown in the OPAC tab 14) Clear your opac error log. 15) Refresh OPAC tab. The tag subfields are split. 16) There are opac-MARCdetail.pl warnings. 17) Apply patch 18) Clear your opac error log. 19) Refresh OPAC tab. The tag subfields are no longer split strangely. 20) There are no opac-MARCdetail.pl warnings. RESTORE YOUR DATABASE. This also silences a series of warnings triggered by catching undef hash references. Signed-off-by: Owen Leonard Signed-off-by: Kyle M Hall Signed-off-by: Galen Charlton -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:31:54 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 15:31:54 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23227|0 |1 is obsolete| | --- Comment #4 from Fridolin SOMERS --- Comment on attachment 23227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23227 Bug 11242: fix opac-MARCdetail.pl display and warnings Error, sorry I was experimenting git-bz. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:32:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 15:32:12 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 Fridolin SOMERS changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:39:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 15:39:56 +0000 Subject: [Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- In response to Galen's email to koha-devel: I think it would be less confusing to not display the 23:59 but just the date. Especially in libraries not using hourly loans the new display caused some confusion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:52:57 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 15:52:57 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #78 from Jacek Ablewicz --- Something seems to be not quite right with serials/serials-search.pl. When I'm searching subscriptions using regular fields - leaving additional fields inputs empty / set to 'All' for authorized ones, I'm allways getting 0 search results. This error seems to be related to patch 22869 (added define () in line 79). After changing it this way: 79c79,80 < if ( defined ( my $filter_value = $query->param('additional_field_' . $field->{id} . '_filter') ) ) { --- > my $filter_value = $query->param('additional_field_' . $field->{id} . '_filter'); > if ( defined( $filter_value ) && $filter_value ne '' ) { searching works again like it should. I'm not sure if that may be a proper fix, but it corrected this particular problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 17:22:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 16:22:28 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #31 from mathieu saby --- I'm testing the permission for restriction (with the different types of restrictions). It's working well, but I remarked that the description of the manage_restriction need to be updated in updatedatabase "Lift restriction for restricted accounts" (and its name could also be changed in the title of the patch, but it's cosmetic) And 13.00.XXX should now be 15.00.XXX in updatedatabase Now I'm testing the force_checkout permission. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 17:29:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 16:29:36 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 --- Comment #32 from mathieu saby --- It's not the purpose of this patch, but 2 UX remarks : - it could maybe be interesting to manage the 2 flags "lost card" and "gone no adress" as 2 kinds of restrictions, using the new restriction system. By the way, I don't know if "flag" is meaningful in english in this context, but in French the translation has always be difficult. - when a librarian has the rights to manage restrictions, he must click on restriction tab, or on "View restrictions" button to manage them, but Koha does not tell him that he will have the possibility to manage the restriction. Maybe the button "View restriction" should be p?rased "Manage restriction" when the librarian has the manage_restriction permission. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 17:42:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 16:42:24 +0000 Subject: [Koha-bugs] [Bug 10855] Additional fields for subscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 --- Comment #79 from Jacek Ablewicz --- (In reply to Jonathan Druart from comment #75) > > > 3) Any chances to support/allow arbitrary field names (with non-ascii > > characters, spaces etc.)? That will probably require an extra column (e.g. > > "label") in additional_fields table (?). > > Why? There are a free field and an id, I thought it was enough. It was enough, no need to extend additional_fields table.. Also, in case extra fields are really needed, one can always add additional fields to additional_fields using Koha::AdditionalFields ;). I had some problems with arbitrary additional field names, because of using field names in etc. isntead of field id - that's where I encountered aftermentioned problems. Another possibility is that while applying patches I simply may have missed one (or two).. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 17:51:56 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 16:51:56 +0000 Subject: [Koha-bugs] [Bug 3445] action_logs table needs some thought In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3445 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 18:22:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 17:22:24 +0000 Subject: [Koha-bugs] [Bug 10863] Add 2 circulation permissions: force_checkout and lift_restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10863 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from mathieu saby --- For force_checkout permission : I tried to play with some Circulation syprefs ( AllowFineOverride , IssueLostItem, OverduesBlockCirc ) and to make checkouts - of a lost item - of a not for loan item - of an item checked out to an other patron - of a document marked "PEGI 12" to a 4 year child - with a return date choosen in the past with the datepicker - to a patron with overdues - to a patron with fines exceding limit - to a patron with already the maximum number of documents on his card All these operations were possible with the permission (and with some choices in sysprefs), and not possible without, except one operation : checking out a document marked "PEGI 12" to a 4 year child (I mapped biblioitems.agerestricted with 301a field, set the preference AgeRestrictionMarker with "PEGI", and AgeRestrictionOverride to "Don't allow") I'm failing QA just for the last point. Maybe I misunderstood the expected behavior, but could you take a look at that please? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 18:31:36 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 17:31:36 +0000 Subject: [Koha-bugs] [Bug 11130] Change pl Place-publication index for Marc21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11130 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #2 from mathieu saby --- (In reply to Mirko Tietgen from comment #0) > According to ccl.properties, the pl Place-publication index is supposed to > include 008/15-17 and 260$a. In record.abs, we have the index include all > 260 fields. This patch removes the index for the whole field 260, leaving > only $a (and 008/15-17). Maybe it is in ccl.properties, but I believe it would be a bad idea to follow it on this point ;-) 008/15-17 is a coded information about a country 260$a is a plain text information about a town The 2 information should be in different indexes. In Unimarc, we use pl for 210 (the same as 260) and Country-publication for 102$a field (if I remember well) for the country. By the way, the "pl" index is completely useless for the average user in an academic or public library, at least according to my experience. Because I've never seen a reader looking for "a book published in London", or "All the books published in Paris". I think it's more a librarian-centered information. M. Saby -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 18:34:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 17:34:18 +0000 Subject: [Koha-bugs] [Bug 11122] publisher code and publication year not fetched in acq orders In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11122 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #5 from mathieu saby --- (In reply to Fridolin SOMERS from comment #0) > In acquisition, several templates try to display publisher code and > publication year : invoice.tt, parcel.tt, transferorder.tt. > Thoses pages use C4::Acquisition methods GetPendingOrders or > GetInvoiceDetails. > The bug is that in the SQL query of those methods, biblioitems.publishercode > and biblioitems.publicationyear. > In uncertainprice.pl those datas are fetch using GetBiblioData. > It whould be better to fetch them in GetPendingOrders and GetInvoiceDetails. "The bug is that in the SQL query of those methods, biblioitems.publishercode and biblioitems.publicationyear." I think your sentence was broken ;-) What's the bug exactly? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 18:39:18 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 17:39:18 +0000 Subject: [Koha-bugs] [Bug 11322] New: Suggestion "notes" field should be sanitized or escaped Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 Bug ID: 11322 Summary: Suggestion "notes" field should be sanitized or escaped Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: abl at biblos.pk.edu.pl QA Contact: testopia at bugs.koha-community.org It's possible for patron to make purchase suggestion from OPAC with html/javascript code within Notes: field. Such injected JS code will be stored in the database, and in certain circumstances (when managing suggestions in acquisition) it may got subsequently executed in staff WWW browser. Other suggestion fields may be affected as well, but the problem with 'notes' is potentially more severe because it's a long field - more elaborate "evil" script will fit into it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 18:40:15 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 17:40:15 +0000 Subject: [Koha-bugs] [Bug 11322] Suggestion "notes" field should be sanitized or escaped In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11322 Jacek Ablewicz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |abl at biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 18:57:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 17:57:17 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #70 from mathieu saby --- Hi Jonathan 3 remarks: - there is a little conflict (I solved it on my VM) - when I click on A to see all the patrons with name begining with A, I am automatically redirected to the card of the only patron whose name begins with A. Is it a wanted behavior? - when I try to sort the table according to names or cardnumber, the sorting is quite slow. It's surprizing, because I only have 10 patrons in my test base. So I fear the results will be worse with a real base. Maybe it's an issue of my computer, but do you think there is some part of code to optimize? - Is there a way to cancel a filter when it is too restrictive? or to cancel all filters? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 18:57:31 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 17:57:31 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 --- Comment #71 from mathieu saby --- 4 remarks in fact... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 18:59:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 17:59:52 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 19:21:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 18:21:35 +0000 Subject: [Koha-bugs] [Bug 5338] Serials in guided reports In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from mathieu saby --- Test made In Guided Reports, I selected the new 'Serial' value in modules list then I selected all the fields of the following tables: serial, serialitems, subscription, subscriptionhistory, subscriptionroutinglist I did not choose sorting, grouping or counting option The resulting report is: SELECT serial.serialid,serial.biblionumber,serial.subscriptionid,serial.serialseq,serial.status,serial.planneddate,serial.notes,serial.publisheddate,serial.claimdate,serial.routingnotes, serialitems.itemnumber,serialitems.serialid, subscription.biblionumber,subscription.subscriptionid,subscription.librarian,subscription.startdate,subscription.aqbooksellerid,subscription.cost,subscription.aqbudgetid,subscription.weeklength,subscription.monthlength,subscription.numberlength,subscription.periodicity,subscription.countissuesperunit,subscription.notes,subscription.status,subscription.lastvalue1,subscription.lastvalue2,subscription.innerloop1,subscription.innerloop2,subscription.innerloop3,subscription.lastvalue3,subscription.firstacquidate,subscription.manualhistory,subscription.irregularity,subscription.skip_serialseq,subscription.letter,subscription.numberpattern,subscription.locale,subscription.distributedto,subscription.internalnotes,subscription.callnumber,subscription.location,subscription.branchcode,subscription.lastbranch,subscription.serialsadditems,subscription.staffdisplaycount,subscription.opacdisplaycount,subscription.graceperiod,subscription.enddate,subscription.closed,subscription.reneweddate, subscrip tionhistory.biblionumber, subscriptionhistory.subscriptionid,subscriptionhistory.histstartdate,subscriptionhistory.histenddate,subscriptionhistory.missinglist,subscriptionhistory.recievedlist,subscriptionhistory.opacnote,subscriptionhistory.librariannote, subscriptionroutinglist.routingid,subscriptionroutinglist.borrowernumber,subscriptionroutinglist.ranking,subscriptionroutinglist.subscriptionid FROM biblio LEFT JOIN biblioitems on (biblio.biblionumber=biblioitems.biblionumber) LEFT JOIN serial on (biblioitems.biblionumber=serial.biblionumber) LEFT JOIN serialitems on (serial.serialid=serialitems.serialid) LEFT JOIN subscription on (serial.subscriptionid=subscription.subscriptionid) LEFT JOIN subscriptionhistory on (serial.subscriptionid=subscriptionhistory.subscriptionid) LEFT JOIN subscriptionroutinglist on (serial.subscriptionid=subscriptionroutinglist.subscriptionid) LEFT JOIN aqbooksellers on (subscription.aqbooksellerid=aqbooksellers.id) Koha accepted to run it and get 1311 results I only have 35 serials in my db. In fact the reports gets 1 line for each of my records :( So I fail QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 19:41:06 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 18:41:06 +0000 Subject: [Koha-bugs] [Bug 10415] Add course reserves to staff client home page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10415 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 19:41:38 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 18:41:38 +0000 Subject: [Koha-bugs] [Bug 10569] Course reserves do not show on OPAC detail page if OpacSeparateHoldings is in effect In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10569 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 19:42:16 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 18:42:16 +0000 Subject: [Koha-bugs] [Bug 4054] Double-clicking the 'place hold' button can result in duplicate holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4054 marjorie barry-vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 20:38:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 19:38:05 +0000 Subject: [Koha-bugs] [Bug 10985] Unimarc: Authority summary does not work as expected In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10985 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #4 from mathieu saby --- I put [200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn: 009*] in Authority types for "NP" without your patch, a search on authorities NP gives : 1483 -- Aim?e, Anouk -- -- NP -- : 1153 -- -- NP -- -- Aitchison, Jean (1925-....) : 1392 -- -- NP -- -- Alcal?-Zamora y Torres, Niceto (1877-1949) : 1579 -- Abraham, Daniel -- -- NP -- : 1011 -- -- NP -- -- ?, ? (1960-....) -- Yu, Hua (1960-....) : So, it is broken. with your patch, it gives: Aim?e, Anouk-- NP -- 1483 : Aitchison, Jean-- NP -- (1925-....) 1153 ppn: 031562558: Alcal?-Zamora y Torres, Niceto-- NP -- (1877-1949) 1392 ppn: 031603718: Abraham, Daniel-- NP -- 1579 : ?, ?-- NP -- (1960-....) 1011 ppn: 033893438: ? ? 1960-.... Yu Hua 1960-.... So, it works ;-) But I have a question for the last case. It is a record with two 200 fields, in chinese and in french. Is it normal to only have the chinese name on the first line (the line defined by "[200a][, 200b][ 200d][-- 152b --][ ; 200c][ (200f)] [001*] [ppn: 009*]") ? If it is normal, I will sign off. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 21:02:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 20:02:40 +0000 Subject: [Koha-bugs] [Bug 10852] Add 3 filters to the serials search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10852 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #4 from mathieu saby --- It works well, but - I thought the filter on expiration date was checking the exact date. It seems that it getting subscriptions ending BEFORE the given date. Am I right? So, could you rephrase the name of the filter, so that it be obvious for users? - Search on Callnumber is not very precise. I had a callnumber "XC BLA", and get the subscription with a search on callnumber "LA" or "X" I think callnumber filter should search for complete words, but I'm not sure it is the case elsewhere in Koha. I'm waiting for your reaction, and for the moment, I keep the bug in Needs Signoff status. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 21:05:47 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 20:05:47 +0000 Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when using QueryWeightFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #3 from mathieu saby --- Good idea. I'm testing it. But don't you think that after titles, "author" and "subject" could have a specific weight more important than other indexes? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 21:14:24 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 20:14:24 +0000 Subject: [Koha-bugs] [Bug 11069] increase title ranking in relevance when using QueryWeightFields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11069 --- Comment #4 from mathieu saby --- I'm not sure it is working. I entered "grands moderne" I had 3 record. The 1st is "Alberto Giacometti", in the series "Collection des grands peintres modernes" (field 225) and "Collection des grands peintres classiques" (field 410) The 2d is "Les grands courants de la linguistique moderne" The 3rd is "Miro" in the series "Collection des grands peintres modernes" (only in 225) Why the 2d isn't before the 1st? Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 21:25:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 20:25:17 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #40 from mathieu saby --- I tested with itemtypes and branches, with no filters Here are my results: Filtered on: =1 items.itype / items.homebranch BU bubis TOTAL CONC 0 DPC 0 DPN 0 TOTAL 0 0 0 I don't understand the "=1" And I have much more than "0" items of each category. So, failing QA for these 2 points. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 21:25:28 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 20:25:28 +0000 Subject: [Koha-bugs] [Bug 7683] statistic wizard: cataloging In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 21:27:39 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 20:27:39 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #61 from mathieu saby --- I still don't have a way to send mail with my VM, so please ask somebody else to test it. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:00:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:00:20 +0000 Subject: [Koha-bugs] [Bug 8334] Authority UNIMARC 100 field plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #14 from mathieu saby --- It works well, I sign off. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:02:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:02:12 +0000 Subject: [Koha-bugs] [Bug 8334] Authority UNIMARC 100 field plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21230|0 |1 is obsolete| | --- Comment #15 from mathieu saby --- Created attachment 23228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23228&action=edit [PATCH][SIGNED OFF] Bug 8334 - Authority UNIMARC 100 field plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:02:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:02:44 +0000 Subject: [Koha-bugs] [Bug 8334] Authority UNIMARC 100 field plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21116|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:02:55 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:02:55 +0000 Subject: [Koha-bugs] [Bug 8334] Authority UNIMARC 100 field plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21115|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:03:23 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:03:23 +0000 Subject: [Koha-bugs] [Bug 8334] Authority UNIMARC 100 field plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:03:34 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:03:34 +0000 Subject: [Koha-bugs] [Bug 8334] Authority UNIMARC 100 field plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:04:05 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:04:05 +0000 Subject: [Koha-bugs] [Bug 8334] Authority UNIMARC 100 field plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P2 --- Comment #16 from mathieu saby --- I lower a bit priority... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:04:20 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:04:20 +0000 Subject: [Koha-bugs] [Bug 8334] Authority UNIMARC 100 field plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:41:11 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:41:11 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #18 from mathieu saby --- Before the patch: name;surname;address1;address2;zipcode;city;country;email;itemcount;itemsinfo b?b?;saby;"15 rie";;;;;math.saby_15 at gmail.com;1;"22/11/2013 Palladio 013559A Lionello Puppi 2273 " thefirstname;thename;"rue X";"batiment 2";75000;PARIS;France;;1;"22/11/2013 Souvenirs d'enfance et de jeunesse 125305F Ernest Renan 2272 " mathieu;saby;;;;;;math.saby_15 at gmail.com;1;"07/11/2013 Lecture de Val?ry2 0281972092 par James R. Lawler 2301 " After the patch: name;surname;address1;address2;zipcode;city;country;email;phone;cardnumber;itemcount;itemsinfo;branchname;letternumber b?b?;saby;"15 rie";;;;;math.saby_15 at gmail.com;;6;1;"2273 29/11/2013 22/11/2013 Palladio 013559A Lionello Puppi W 11246 BU centrale ";"BU centrale";1 thefirstname;thename;"rue X";"batiment 2";75000;PARIS;France;;060606060606;3;1;"2272 29/11/2013 22/11/2013 Souvenirs d'enfance et de jeunesse 125305F Ernest Renan 605634 BU centrale ";"BU centrale";1 mathieu;saby;;;;;;math.saby_15 at gmail.com;;1;1;"2301 29/11/2013 07/11/2013 Lecture de Val?ry2 0281972092 par James R. Lawler 606395 BU centrale ";"BU centrale";3 It seems ok. Except there seems to be an extra linefeed before the closing " of the item information (but it was an existing bug before your patch). Regarding UTF-8 : I tried to put chinese text in my notices, and to generate it before your patch. Chinese text is displayed properly. After your patch also, but I don't see any change. Is utf8 display of notices broken in current master? I sign off, as this patch improves overdue_notices.pl without breaking anything. Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:45:37 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:45:37 +0000 Subject: [Koha-bugs] [Bug 8687] Improvements in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8687 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23150|0 |1 is obsolete| | --- Comment #19 from mathieu saby --- Created attachment 23229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23229&action=edit [PATCH][SIGNED OFF] Bug 8687: Improvements in overdue_notices.pl script (Newer version) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:46:12 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:46:12 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:46:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:46:17 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby at univ-rennes2.f | |r -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:46:45 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:46:45 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored --- Comment #22 from mathieu saby --- Sponsored by Rennes 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 22:49:44 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 21:49:44 +0000 Subject: [Koha-bugs] [Bug 7679] Statistics wizard: circulation (new filters) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7679 --- Comment #20 from mathieu saby --- (In reply to Paul Poulain from comment #17) > isn't that a bug in the dataset ? Seems silly to me to have "enseignant" and > "Enseignant" being 2 different values... Yes, that would be silly! Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 23:27:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2013 22:27:42 +0000 Subject: [Koha-bugs] [Bug 11209] Multi transport types: same messages are sent for a patron In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11209 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #3 from mathieu saby --- Before applying the patch: I set 2 items due on the 3rd December for the same patron. I ran $perl misc/cronjobs/advance_notices.pl -c I checked the message_queue table : there are 2 messages, one for each item. So, bug confirmed. But the patch does not apply. I got this message Applying: Bug 11209: Don't sent the same message for the same user the same day fatal: sha1 information is lacking or useless (C4/Letters.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. .... Mathieu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 30 11:48:03 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Nov 2013 10:48:03 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23055|0 |1 is obsolete| | CC| |mathieu.saby at univ-rennes2.f | |r --- Comment #3 from mathieu saby --- Created attachment 23230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23230&action=edit [PATCH][SIGNED OFF] Bug 6331 - Obsolete marc column in deleteditems -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 30 11:48:35 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Nov 2013 10:48:35 +0000 Subject: [Koha-bugs] [Bug 6331] Obsolete marc column in deleteditems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6331 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from mathieu saby --- Test : - suppressing an item, checking the deleted item is properly stored in deleteditems table - checking the column marc has been deleted from deleteditems table I sign off Mathieu -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 30 12:25:40 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Nov 2013 11:25:40 +0000 Subject: [Koha-bugs] [Bug 11323] New: AcqItemSetSubfieldsWhenReceived Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11323 Bug ID: 11323 Summary: AcqItemSetSubfieldsWhenReceived Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: mathieu.saby at univ-rennes2.fr QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 30 12:26:52 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Nov 2013 11:26:52 +0000 Subject: [Koha-bugs] [Bug 11323] AcqItemSetSubfieldsWhenReceived set to 0 on a fresh install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11323 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AcqItemSetSubfieldsWhenRece |AcqItemSetSubfieldsWhenRece |ived |ived set to 0 on a fresh | |install --- Comment #1 from mathieu saby --- On a fresh install, AcqItemSetSubfieldsWhenReceived preference is set to "0". I don't know if it is harmfull or not, but I suppose it should be blank. M. Saby -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 30 12:27:07 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Nov 2013 11:27:07 +0000 Subject: [Koha-bugs] [Bug 11323] AcqItemSetSubfieldsWhenReceived set to 0 on a fresh install In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11323 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 30 21:46:17 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Nov 2013 20:46:17 +0000 Subject: [Koha-bugs] [Bug 11324] New: "Delete All Items" fails except on "Normal Tab" 3.14 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11324 Bug ID: 11324 Summary: "Delete All Items" fails except on "Normal Tab" 3.14 Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: library at stas.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com "Delete all items" on Edit dropdown menu when viewing a biblio record will only delete records when in the "Normal" tab. When viewing another tab, clicking this command does nothing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 30 22:56:42 2013 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Nov 2013 21:56:42 +0000 Subject: [Koha-bugs] [Bug 9016] Multi transport types for notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016 mathieu saby changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #23 from mathieu saby --- Hi I made a fresh install, create some overdue rules, and apply the patch. I edited manually updatedatabase, to replace "13.00.XXX" with "15.00.XXX", then I ran updatedatabase. Some pages appears to be broken: cgi-bin/koha/tools/letter.pl?op=add_form&branchcode=&module=circulation&code=ODUE has lost the overdue template (the textarea is void) and the Koha Module (now "Catalogue" instead of "Circulation") http://pro.koha-msaby/cgi-bin/koha/tools/overduerules.pl has lost all the rules I have defined before the patch. and cannot retrieve any notice template in the dropdown list. I don't think it is linked with my manual operation on updatedatabase (the changes were made in db structures). So I must fail QA. Mathieu -- You are receiving this mail because: You are watching all bug changes.