[Koha-bugs] [Bug 10723] GetPendingOrders and SearchOrders can be merged

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10723

mathieu saby <mathieu.saby at univ-rennes2.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mathieu.saby at univ-rennes2.f
                   |                            |r

--- Comment #5 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi Jonathan, Hi Kyle

I am trying to resolve conflict on Bug 10758, so I came to your change on this
one.
Don't you think the resulting routine could be make simpler ?

I see "publishercode AS publisher"
and 
aqorders.rrp              AS unitpricesupplier,
aqorders.ecost            AS unitpricelib,
aqorders.claims_count     AS claims_count,
aqorders.claimed_date     AS claimed_date,

I don't the the meaning of 
aqorders.claims_count     AS claims_count,
aqorders.claimed_date     AS claimed_date,

For
aqorders.rrp              AS unitpricesupplier,
aqorders.ecost            AS unitpricelib,
and
publishercode AS publisher

Is this renaming made for avoiding confusion somewhere in code?

By the way, I was trying to factorize some UT in Acquisition.t (not yet done),
and one of my assumptions was that the fields returned by GetOrder were the
same as each orders of GetOrderS and GetCancelledOrders. It was working, but of
course it is no more the case. So I'm wondering if the fields added in the
hased returned by GetOrder could be usefull too in GetOrderS and
GetCancelledOrders.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.