[Koha-bugs] [Bug 7298] export late orders, with # of claims and claim dates

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

--- Comment #92 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
Hi Jonathan

I am trying to resolve conflict on Bug 10758, so I came to the changes
introduced in GetOrder by commit fd2c751a86fad7a388c57fcd51746dbc4592c807 (the
main patch for bug 7298)

Don't you think the resulting routine could be make simpler ?

I don't see the use for:
aqorders.claims_count     AS claims_count,
aqorders.claimed_date     AS claimed_date,

For
aqorders.rrp              AS unitpricesupplier,
aqorders.ecost            AS unitpricelib,
and
biblioitems.publishercode AS publisher
aqbudgets.budget_name     AS budget,

Are these renaming really needed? Are they made for avoiding confusion
somewhere in code?

By the way, I was trying to factorize some UT in Acquisition.t (not yet done),
and one of my assumptions was that the fields returned by GetOrder were the
same as each orders of GetOrderS and GetCancelledOrders. It was working, but of
course it is no more the case. So I'm wondering if the fields added in the
hashe returned by GetOrder could be usefull too in GetOrderS and
GetCancelledOrders.

Mathieu

-- 
You are receiving this mail because:
You are watching all bug changes.