[Koha-bugs] [Bug 9788] Improvements for calling GetReservesFromItemnumber

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9788

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22645|0                           |1
        is obsolete|                            |

--- Comment #52 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 22687
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22687&action=edit
Bug 9788: Followup for expirationdate in Letter.pm

Pasting comment from the Bugzilla report:
Looking bit longer at this code, it is kind of strange to find it there in the
first place. Adding maxpickupdelay in Letters.pm should not be there, but it
is..

Also this date is not used normally in the default HOLD Available for Pickup
notice (that we are generating in this case). And if it would be undef, the
expiration date should imo be empty instead of today+0. (before adding
maxreservespickupdelay, you should test the allowexpire pref first)
So it is an (invisible) bug on its own.

Test plan:
See former patch. Kyle just discovered this bug, apparently by deleting the
maxpickupdelay pref..

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart at biblibre.com>

-- 
You are receiving this mail because:
You are watching all bug changes.