[Koha-bugs] [Bug 11206] Factorize code for getting orders in C4::Acquisitions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11206

--- Comment #3 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(In reply to Jonathan Druart from comment #2)
> Mathieu,
> Not sure it is a good idea to factorize like that.
> Now, some routines did 1, 2 or 3 join, with your patch, they will always do
> 8 join.
> That will increase the load in acquisition pages.

In fact, what first disturbed me was that the same fields were not named in the
same way in GetOrder and GetCancelledOrders and GetOrders (publishercode,
rrp...). And working on that, I tried to factorize all the code.
But you are right, in terms of performance it is not a good solution.

Maybe the 2 subs which could be safely factorized are GetCancelledOrders and
GetOrders, as they differ only by the exclusion of an order status.

-- 
You are receiving this mail because:
You are watching all bug changes.