[Koha-bugs] [Bug 7802] A MySQLism is used to get the current date.

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7802

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #22 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
I see the following change:

-          AND reserves.reservedate <= DATE_ADD(NOW(),INTERVAL ? DAY)
+          AND reserves.reservedate <= CAST(now() AS date)

Fixing a so detested mysqlism should at least preserve functionality. These
changes seem to be made in a hurry, since we are changing functionality here.
Here you change a date_add with just a now. The parameter for adding a number
of days is just ignored. This change was a red traffic light for me :) I did
not look any further..

Please correct and add a (more detailed) test plan for this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.