[Koha-bugs] [Bug 9016] Multi transport types for notices

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9016

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #19 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
-----------------
--  Letters.t  --
-----------------

All test complete! Awsum!

------------------
--  Overdues.t  --
------------------
"my" variable $mtts masks earlier declaration in same scope
+++++
line 50: my $mtts = C4::Overdues::GetOverdueMessageTransportTypes('', 'PT', 1);
Should be
line 50: $mtts = C4::Overdues::GetOverdueMessageTransportTypes('', 'PT', 1);



DBD::mysql::db do failed: Cannot add or update a child row: a foreign key
constraint fails (`kohadata`.`overduerules_transport_types`, CONSTRAINT
`overduerules_fk` FOREIGN KEY (`branchcode`, `categorycode`) REFERENCES
`overduerules` (`branchcode`, `categorycode`) ON DELETE CASCADE ON) at
/home/kivilahtio/koha/kohaclone/t/db_dependent/Overdues.t line 23.
+++++
koha.overduerules-table is missing the branchcode and patron.categorycode
definitions you are trying to link to with 
line 24: INSERT INTO overduerules_transport_types( branchcode, categorycode,
letternumber, message_transport_type ) VALUES
    ('CPL', 'PT', 1, 'email'),

After adding a definition via tools/overduerules.pl for branch CPL for patron
PT, the given SQL element works (not the whole clause).
Should be included in the test case.


-------------------
--  Overdues.pm  --
-------------------
at GetOverdueMessageTransportTypes()
"return a arrayref with message_transport_type for given branchcode,
categorycode and letternumber(1,2 or 3)"
Should be 
"return a arrayref with all message_transport_types for given branchcode,
categorycode and letternumber(1,2 or 3)"

Should GetOverdueMessageTransportTypes() also take into account the default
values? When library branch specific rules are not set then the function could
return the default values instead?


-----------------------------
--  tools/overduerules.pl  --
-----------------------------

Adding definitions seems to work pretty well. Will test more tomorrow. Good
work with this one!


Failed QA because Overdues.t needs improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.