[Koha-bugs] [Bug 11218] Due notices broken / not generated

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11218

Liz Rea <liz at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22795|0                           |1
        is obsolete|                            |
  Attachment #22796|0                           |1
        is obsolete|                            |

--- Comment #5 from Liz Rea <liz at catalyst.net.nz> ---
Created attachment 22799
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22799&action=edit
Bug 11218: Regression tests for Due notice generation

Changes tests for GetUpcomingDueIssues:

days_in_advance should be inclusive:
 2 should find items due in 2 days from now.
 1 should find items due tomorrow.
 0 should only find items due today.

Adds new tests for Bug 11218:

As the advance_notices.pl, the only script using GetUpcomingDueIssues
is not only used for PREDUE notices, but also for
DUE notices, we need to also select items due today.

Bug 11218: Due notices not being generated

To test:
- Check out 2 items, due dates should be today, sometime in the past
  and one day after tomorrow.
- Edit the message options - activate DUE and PREDUE notices with
  days in advance = 2
- Run the advance_notices.pl script with -v -c
  Result: Only a PREDUE notice is generated
- Run the advance_notices.pl script with -v -c -m 2
  Result: Only the PREDUE message is generated correctly.
- Run t/db_dependent/Circulation.t
  - without first patch: all tests pass.
  - with first patch: some tests will fail.

Apply patch.

- Rerun script, now PREDUE and DUE notices should be
  generated.
- Run t/db_dependent/Circulation.t again, all tests should pass.

Add more items with different due dates, rerun and check results.

Run t/Circulation.t to confirm all tests pass.
- Apply the patch

Signed-off-by: Liz Rea <liz at catalyst.net.nz>
Passes functional and automated testing. Due notice functionality restored.
Thanks Katrin!

-- 
You are receiving this mail because:
You are watching all bug changes.