[Koha-bugs] [Bug 10832] Multi transport types for overdue notices

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832

Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |olli-antti.kivilahti at jns.fi

--- Comment #8 from Olli-Antti Kivilahti <olli-antti.kivilahti at jns.fi> ---
-----------------------------------------------------------------------------
--  "git bz applying 10832" on top of "git bz apply all commits for 9016"  --
-----------------------------------------------------------------------------

Auto-merging misc/cronjobs/overdue_notices.pl
CONFLICT (content): Merge conflict in misc/cronjobs/overdue_notices.pl

Manually resolved the conflict.


--------------------------
--  overdue_notices.pl  --
--------------------------

overdue_notices.pl properly queues letters to koha.message_queue but the
parse_letter() doesn't parse any letter placeholders <<branch.branchname>>
atleast for email and sms transport type. Unsure if this is because of my
merge. Placeholders work when triggering notifications from check-in/check-out
for ex.
Only tested the main path, unsure how to trigger secondary execution paths.
Test plan works for the core test case.

Yet to test the specific case, but based on my code review it should work :)


Otherwise good work in such a complex application area.


-------------------------
--  Failed QA because  --
-------------------------

Merge conflict needs to be resolved.
Placeholders do not work for some reason.

-- 
You are receiving this mail because:
You are watching all bug changes.