[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #18 from M. Tompsett <mtompset at hotmail.com> ---
Srdjan Jankovic, you undid some of my tweaks which fixed the following cases:
q_userid = undef, s_userid is defined and not '' or 0.
OR
s_userid = undef, q_userid is defined and not '' or 0.

That is the following on line 693:
($q_userid && $s_userid && $q_userid ne $s_userid)
will not work exactly like the noisy
($q_userid ne $s_userid)

This is why I put:
    my $q_userid = $query->param('userid') // ''; # (line 653)
and 
    $s_userid = $session->param('id') // ''; # (line 675)

I'm attaching some test code to demonstrate.
I've changed the status to ASSIGNED, since these pieces we have are a bit
tangled up and messy.

-- 
You are receiving this mail because:
You are watching all bug changes.