[Koha-bugs] [Bug 11183] Warnings in opac

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183

--- Comment #5 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 22810
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22810
bug_11183: get rid of some warnings

Review of attachment 22810:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11183&attachment=22810)
-----------------------------------------------------------------

::: opac/opac-detail.pl
@@ +573,4 @@
>  
>      # get collection code description, too
>      my $ccode = $itm->{'ccode'};
> +    $itm->{'ccode'} = $collections->{$ccode} if $ccode && $collections && $collections->{$ccode};

I believe what was called for was just adding a check on whether $ccode was
defined.  Getting rid of the "defined($collections)" and "exists(
$collections->{$ccode}" breaks things if the library happened to define "0" as
a collection code.

Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.