[Koha-bugs] [Bug 11183] Warnings in opac

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11183

--- Comment #14 from M. Tompsett <mtompset at hotmail.com> ---
The test plan is as given on the original patch:
To test in OPAC:
* With the OPAC System Preference EnableOpacSearchHistory set
  to Keep, a simple search triggers the warning patched on
  line 626 of opac-search.pl
* Selecting a search result item with no Collection Code
  set triggers the warning patched on line 576 of opac-detail.pl
* Have an item with Collection Code. Check that the Collection
  Code shows.
* Collection Code is set by editing an item in the staff client
  (952$8)

I happen to have two items with unhappy in the title, and so I gave one a
collection code, while the other did not have one.
1) Search for unhappy in OPAC
2) Click link 1
3) Browser back
4) Click line 2
These steps are between the clearing of the error log and the viewing unique
errors in the error log.

The results of my testing:
mtompset at ubuntu:~/kohaclone$ git reset --hard origin/master
HEAD is now at 0d5f73d Merge branch 'new/bug11205'
mtompset at ubuntu:~/kohaclone$ echo > ~/koha-dev/var/log/koha-opac-error_log
mtompset at ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut
-c85- | sort -u

 opac-detail.pl: Use of uninitialized value $ccode in exists at
/home/mtompset/kohaclone/opac/opac-detail.pl line 576., referer:
http://demo.library.kohasystem.ca/cgi-bin/koha/opac-search.pl?idx=&q=unhappy&branch_group_limit=
 opac-search.pl: Use of uninitialized value $code_wanted in string eq at
/usr/share/perl5/MARC/Field.pm line 314., referer:
http://demo.library.kohasystem.ca/
 opac-search.pl: Use of uninitialized value $limit_desc in concatenation (.) or
string at /home/mtompset/kohaclone/opac/opac-search.pl line 626., referer:
http://demo.library.kohasystem.ca/
mtompset at ubuntu:~/kohaclone$ git bz apply 11183
Bug 11183 - Warnings in opac

22856 - [SIGNED OFF] bug_11183: get rid of some warnings
22857 - Bug 11183 - Warnings in opac

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: bug_11183: get rid of some warnings
Applying: Bug 11183 - Warnings in opac
mtompset at ubuntu:~/kohaclone$ echo > ~/koha-dev/var/log/koha-opac-error_log
mtompset at ubuntu:~/kohaclone$ cat ~/koha-dev/var/log/koha-opac-error_log | cut
-c85- | sort -u

mtompset at ubuntu:~/kohaclone$

-- 
You are receiving this mail because:
You are watching all bug changes.