[Koha-bugs] [Bug 6435] [ENH] Added daemon mode parameters to rebuild_zebra.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6435

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

--- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I'm up and down on passing this one.. discussed it with Katrin..

1. Passes QA script (after I fixed some minor white space errors - Doug, please
take a look at
http://blog.bigballofwax.co.nz/2011/12/15/fixing-whitespace-when-apply-patches-with-git/
to stop these in their tracks before they hit QA with future patches ;) )

2. Tested with various combinations of options: -a -daemon, -b -daemon, -a -b
-daemon, -a -b -x -daemon, all worked as expected along with not breaking
existing options.


One niggle worth discussing: The intention of this patch is clear, to allow
regular rebuilds as a daemon.. However, the patch allows all/any params to be
passed along with the daemon mode. This slightly scares me as it becomes rather
easy to break the system using the wrong combination of options. (for instance,
running with -r would mean that every time a catalogue update happens, the
zebra index disappears moments later whilst a full rebuild is happening)  I
don't think it's a QA fail, but it may be worth documenting that certain
options don't work well with a daemon model.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.