[Koha-bugs] [Bug 11216] Patron modification creates indefinite manual restriction

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11216

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22826|0                           |1
        is obsolete|                            |

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 22890
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22890&action=edit
Bug 11216 - Patron modification creates indefinite manual restriction

Editing partron data results in unintended adding of indefinite manual
restriction to it. Reason for it is hidden field add_debarment which
is wrongly initialized to 1 instead of 0. Also JavaScript code seems
to want to toggle checkbox, and sice this field is hidden correct
approach would be to change it's value to 1.

Test scenario:

1. edit patron data
2. verify that debarrment is wrongly added
3. remove debarrment
3. apply this patch
4. edit patron again
5. verify that debarrment wasn't added
6. intentionally add debarrment and verify that it's saved
7. add debarment, enter something in comment but press cancel
   and verify that debarment isn't added

Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz>

This fixes this blocker, however, with or without the patch, the date
is not saved correctly. I will file a new bug for that

-- 
You are receiving this mail because:
You are watching all bug changes.