[Koha-bugs] [Bug 10648] In records merge greatest field can not be added

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

--- Comment #15 from Galen Charlton <gmcharlt at gmail.com> ---
Comment on attachment 22697
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22697
Bug 10648 - In records merge greatest field can not be added

Review of attachment 22697:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10648&attachment=22697)
-----------------------------------------------------------------

::: Koha/Util/MARC.pm
@@ +40,4 @@
>      my @array;
>      my @fields = $record->fields();
>  
> +    foreach my $field ( sort { $a->tag() <=> $b->tag() } @fields) {

This is actually a problem: in MARC21, at least, fields are not always meant to
be sorted in numeric tag order.

For example, for the 6XX fields for subject headings, you could have a 651
(geographic term) followed by a 650 (topical term).  That would signify that
the book was more about the geographic area expressed in the 651 than about the
topic expressed in the 650.

As another example, 5XX are not always meant to be sorted in numeric order.

For the purpose of the merge interface, it's sufficient that new tags be
inserted after the first field with a numerically lesser tag, or at the end of
the record as a fallback -- but it shouldn't reorder existing fields in the
target record.

-- 
You are receiving this mail because:
You are watching all bug changes.