[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi <paola.rossi at cineca.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #66 from Paola Rossi <paola.rossi at cineca.it> ---
(In reply to Jonathan Druart from comment #65)
> Created attachment 22869 [details] [review]
> Bug 10855: Filtering on additional fields don't work if value is equal to 0
> 
> If you tried to filter on an additional field linked to an authorised
> value, that did not work if the value was 0.

Thanks,Jonathan.

This last patch is wrong in searching: only modified subscriptions are found
now.
On the contrary, until now, advanced search found either modified subscriptions
or not yet modified subscriptions.

More over updatedatabase needs to be rebased (today I've tested against 043).

I beg your pardon I didn't realize before:

A) there is an old "Advanced search" tab on the left over "Claims", on
cgi-bin/koha/serials/serials-home.pl, whose form shows searchfields like
"Supplier", "Branch", "EAN" (?). In the new form for advanced search they are
"Vendor", "Library". I think you'd better delete the "old" tab.

B) there is an abnormal termination in modifying subscription on
/cgi-bin/koha/serials/subscription-add.pl. It occurs when an additional mark
field has been added, but it's an error, such as the non-existent 022$b. Koha
sends this error message:
Software error:
DBD::mysql::db do failed: Column 'value' cannot be null at
/var/root-koha/bug-10855/Koha/AdditionalField.pm line 107.

When a non-existent mark field is not a new one, but it's added modifying
another existent mark field by Action "Edit", modifying the subscription Koha
puts no value in the wrong additional field without sending error message.

So I pass the patch to "Failed QA" status.

-- 
You are receiving this mail because:
You are watching all bug changes.