[Koha-bugs] [Bug 10486] Allow external Z39.50 targets to be searched from the OPAC

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Sat Nov 23 00:08:18 CET 2013


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10486

--- Comment #26 from Chris Cormack <chris at bigballofwax.co.nz> ---
Comment on attachment 23112
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23112
Bug 10486 - Allow external Z39.50 targets to be searched from the OPAC

Review of attachment 23112:
 --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10486&attachment=23112)
-----------------------------------------------------------------

::: C4/XSLT.pm
@@ +42,4 @@
>      $VERSION = 3.07.00.049;
>      @ISA = qw(Exporter);
>      @EXPORT = qw(
> +        &XSLTGetFilename

We should add a unit test for this method

::: koha-tmpl/opac-tmpl/lib/pz2.js
@@ +1,2 @@
> +/*
> + * $Id: 3a9980787bb5d0fe966140b243a4a5eb6768913e $

What license is this under? Where did we get it from?

::: opac/opac-external-search.pl
@@ +14,5 @@
> +# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License along
> +# with Koha; if not, write to the Free Software Foundation, Inc.,
> +# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.

License and copyright header, These aren't correct are they?

::: opac/svc/pazpar2_init
@@ +6,5 @@
> +#
> +# Koha is free software; you can redistribute it and/or modify it under the
> +# terms of the GNU General Public License as published by the Free Software
> +# Foundation; either version 2 of the License, or (at your option) any later
> +# version.

We use GPL3+ now

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list