[Koha-bugs] [Bug 11219] CAS authentication fails with URL parameters

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11219

--- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> ---
Created attachment 23138
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23138&action=edit
Bug 11219 - CAS authentication fails with URL parameters

Bug 10029 tries to fix the use of URL parameters in CAS authentication.
But is does not work.
The full URL must be used in all methods of C4::Auth_with_cas.
Also, in checkpw_cas(), the 'ticket' parameter must be removed to find the
original URL.

This patch removes the 'ticket' parameter from query before calling
checkpw_cas() since the ticket is passed as method arguemnt.
In C4::Auth_with_cas, many methods use the same code to get the CAS handler and
the service URI. This patch adds a private method _get_cas_and_service() to do
the job.

Test plan :
Test plan :
- Enable CAS
- Go to opac without been logged-in
- Try to place hold on a record
=> You get to /cgi-bin/koha/opac-reserve.pl?biblionumber=XXX showing
authentication page
=> Check that CAS link contains query param "biblionumber"
- Click on CAS link and log in
=> Check you return well logged-in to reserve page with biblionumber param
- Check CAS loggout
- Check Proxy CAS auth

Signed-off-by: Koha team AMU <koha.aixmarseille at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.