[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22805|bug_11077: get rid of some  |[FAILED_QA] Bug 11077: get
        description|warnings                    |rid of some warnings

--- Comment #27 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Comment on attachment 22805
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22805
[FAILED_QA] Bug 11077: get rid of some warnings

Second patch of Srdjan contains this change:

-        elsif ( $lasttime < time() - $timeout ) {
+        elsif ( $lasttime && ($lasttime < time() - $timeout) ) {

If lasttime was undefined, it will be interpreted as zero in the first
condition and therefore the condition is true. In the second case it will
become false. So we have a behavior change. The warning is gone btw :)
Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.