[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #22854|0                           |1
        is obsolete|                            |

--- Comment #29 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 23199
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23199&action=edit
Bug 11077 - Correct silent warnings in C4/Auth.pm

This patch corrects a noisy ne condition.
    $userid = $retuserid if ( $retuserid ne '');
became
    $userid = $retuserid if ( $retuserid );

It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's
patch, while correcting the problems found.

This includes:
    my $q_userid = $query->param('userid') // '';
along with:
    my $s_userid = '';
and:
    my $s_userid = $session->param('id') // '';
Indentation does not reflect actual scoping.

And the 'None' is changed to '', since that behaves properly
in the undef case:
    my $pki_field = C4::Context->preference('AllowPKIAuth') // '';

-- 
You are receiving this mail because:
You are watching all bug changes.