[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

--- Comment #30 from M. Tompsett <mtompset at hotmail.com> ---
My patch corrects the problem for which you failed Srdjan Jankovic's patch. You
will notice that I changed:
       elsif ( $lasttime && ($lasttime < time() - $timeout) ) {
into
       elsif ( !$lasttime || ($lasttime < time() - $timeout) ) {
which does work.

I did say, "It also integrates Srdjan Jankovic's patch with Petter Goksoyrsen's
patch, while correcting the problems found," by which I meant that if you
applied everything including my patch, everything should silence all the bugs
and continue to work like before.

Also, my patch depends on his, so should I squash our patches together, and get
a single sign off? Should I correct mine after he corrects his? This is a very
weird scenario to have with 3 pieces in 3 vastly different states. I'm happy to
fix them any which way, but what is the best course of action?

-- 
You are receiving this mail because:
You are watching all bug changes.