[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

--- Comment #36 from M. Tompsett <mtompset at hotmail.com> ---
(In reply to M. de Rooy from comment #35)
> Maybe we have some misunderstanding?

We may have some cross-talk.


> Correct me if I am wrong but if PKIAuth is None or undef, the if statement
> should not be run (so we should make the expr be false).
> Do you agree?

My sample program demonstrates how it currently works and does not make a
judgement one way or another about how it should work. Using '' mimics current
behaviour. And though that may not be correct in how it should behave, patches
fixing one thing (floody logs) should not cause a behaviour change in another
(how it does work). If the issue remains about how it should work (as compared
to how it does work), that would be another bug fix in my opinion. Does that
clarify where I am coming from?

-- 
You are receiving this mail because:
You are watching all bug changes.