[Koha-bugs] [Bug 11077] Correct silent warnings in C4/Auth.pm

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11077

--- Comment #37 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to M. Tompsett from comment #36)
> > Correct me if I am wrong but if PKIAuth is None or undef, the if statement
> > should not be run (so we should make the expr be false).
> > Do you agree?
> 
> My sample program demonstrates how it currently works and does not make a
> judgement one way or another about how it should work. Using '' mimics
> current behaviour. And though that may not be correct in how it should
> behave, patches fixing one thing (floody logs) should not cause a behaviour
> change in another (how it does work). If the issue remains about how it
> should work (as compared to how it does work), that would be another bug fix
> in my opinion. Does that clarify where I am coming from?

That makes sense. Actually, we are talking about functionality. But for such a
fictive situation (you need to delete your AllowPKIAuth pref and have all other
conditions be false), I think we do not need to open a new report. This
"behavior change" is so minimal that touching this line and fixing it can be
done rightaway.
For the record, the behavior change is actually made in the first patch that
has been signed off and passed qa and your third patch changes it back to
current behavior with the latent undef-mini-minibug.

But if you scroll through the code, you will see that in both cases the overall
effect will be: userid=return=0, auth rejected. So no big deal. Just theory.

-- 
You are receiving this mail because:
You are watching all bug changes.