[Koha-bugs] [Bug 11148] Two routines are useless in Koha::DateUtils

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11148

Galen Charlton <gmcharlt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |gmcharlt at gmail.com

--- Comment #4 from Galen Charlton <gmcharlt at gmail.com> ---
Sure about this?  dateonly => 1 is not exactly equivalent to what
format_sqlduedatetime and output_pref_due output.  This is most evident for
hourly loans:

Due date/time      Current display in opac-reserves  New display
-----------------  --------------------------------  -----------
2013-12-01 23:59   2013-12-01                        2013-12-01
2013-12-01 13:25   2013-12-01 13:25                  2013-12-01

IOW, this patch would cause a (minor) net loss of displayed information for
patrons if hourly loans are being used.

Changing status to have a discussion of the desired display of due times for
hourly loans.  I will note that I *do* think that output_pref_due and
format_sqlduedatetime can be removed, but it may be advisable to add a
display_as_due_date flag or similarly to output_pref.

-- 
You are receiving this mail because:
You are watching all bug changes.