[Koha-bugs] [Bug 10855] Additional fields for subscriptions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

--- Comment #79 from Jacek Ablewicz <abl at biblos.pk.edu.pl> ---
(In reply to Jonathan Druart from comment #75)

> 
> > 3) Any chances to support/allow arbitrary field names (with non-ascii
> > characters, spaces etc.)? That will probably require an extra column (e.g.
> > "label") in additional_fields table (?).
> 
> Why? There are a free field and an id, I thought it was enough.

It was enough, no need to extend additional_fields table.. Also, in case extra
fields are really needed, one can always add additional fields to
additional_fields using Koha::AdditionalFields ;).

I had some problems with arbitrary additional field names, because of using
field names in <input name="..> and <select name=".." - my 1st tought was to
solve this by adding an extra column to additional_fields table, while of
course it's not necessary, when field id can be used for this purpose instead
on field name.
I just noticed you allready switched from using 'name' to using 'id' in patch
22701, but only (?) for serials-search.[pl|tt].

Yet subscription-add.* script & template are (?) still using field name for
<input name=""> etc. isntead of field id - that's where I encountered
aftermentioned problems. Another possibility is that while applying patches I
simply may have missed one (or two)..

-- 
You are receiving this mail because:
You are watching all bug changes.