[Koha-bugs] [Bug 5336] Acq history search

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5336

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #113 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Jonathan,

I am pretty impressed with this :) 

But there are some issues, that need fixing:

1) Database update - I end up with too many partials. My test cases:

 - New orders, basket still open
   NOT OK Expected: new, Result: partial
 - Ordered orders, basket and basketgroup closed
   NOT OK Expected: ordered, Result: partial 
 - Partially received orders
   OK Expected: partial/complete, Result: partial/complete
 - Received orders
   OK: Expected: complete, Result: complete
 - Cancelled orders
   * cancelled from open basket before order
   OK: Expected: cancelled, Result: cancelled
   * cancelled from closed basket before receive
   OK: Expected: cancelled, Result: cancelled

I have saved my 'pre-updatedatabase' and can repeat the test anytime you have a
follow up.

2) Testing search functionality

  a) Order search - result list
  Order search shows a new column, I think it would be a bit better if the
  status there was singular instead of plural - new order, partially received
  order etc. - maybe we could even leave out the 'order'? (minor)

  The column seems a bit lost in the middle, not sure where it would make more
  sense (just saying)

  b) Order search - advanced search form
  The advanced search form now shows a new filter: Order status
  All new status can be searched.
  - an "empty" search will find all but cancelled orders
  - searching for cancelled orders works correctly and shows results
  Search works correctly, no regressions found.

  When a search gives no results, there is no message. Also, all filters and
  fields are cleared so you can't modify or check you previous search
  (minor)

3) Testing setting of status after applying the patch

   a) Create a new order with 2 items - status is new. OK
   b) Close the basket - status is ordered. OK
   c) Receive both items - status is completed. OK
   d) Undo receipt - status is ordered. OK
   e) Receive only 1 item - order is split up into 2 orders:
       - status is partial OK
       - status is completed OK
   f) Undo receipt of received item - order is combined into 1 again
       - status is ordered OK!
   g) Receive only 1 item again - status ordered/partial.
   h) Delete order.
       - status is completed
       - status is cancelled
      OK!
   i) Undo receipt of 1 item again.
      Refresh page. Error message is shown:

Cannot cancel receipt. Possible reasons :
    The order line you trying to cancel was created from a partial receipt of
another order line which is already received. Try to cancel this one first and
retry.
    The order line you trying to cancel was created from a partial receipt of
another order line which has been deleted. Cancellation is not possible.

BUT: The receipt is undon, you are left with an order
     line with 2 items, a cancellation date and the status ordered.

Because of the cancellation date the order is not visible in pending orders.

Summary: The database update is not quite right yet and there is an edge case
where you are left with the wrong status. Also singulars in the orders search
result page would be nice.

Hope you can take another look - I like this.

-- 
You are receiving this mail because:
You are watching all bug changes.