[Koha-bugs] [Bug 10613] Gst is not calculated correctly on the invoice page

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10613

--- Comment #8 from mathieu saby <mathieu.saby at univ-rennes2.fr> ---
(my previous test was made on master, and I made a confusion between receipt
page and invoiced page, so forget it)

I tested with your patch
for all test, a basket with 1 book
- list price (the one I entered) : 10 eur
- tax : vat = 5,5%
- discount = 10%

I have made a complete acq workflow and found some weird things. Most of all
are are not related with your patch. Only the 4th step of each test (invoice
page) is directly related with it.
I made 4 full tests for all the possible vendor setting. 

My conclusion is : the more I test, the less I understand price management in
Koha, and the documentation about it is too poor, so I cannot be sure, but I
think your patch was not working well for test 1,2,3.
I also think there are some other bugs in baskets and receipt pages on current
master.

So all that I can do is Fail QA for the moment.

If I misunderstood price management, please correct me. If there are bugs to be
fixed in basket and receipt page, I would like to know it (And I would also
DREAM of a page on the wiki or on Koha documentation that explain precisely
what Koha is supposed to do with prices and taxes..., or maybe a kind of UT for
prices, but I don't know how it could be possible)

Mathieu

test 1 : 
vendor no (list price) / no (invoiced price).  The list price entered by the
librarian does NOT include tax, and the library does NOT pay tax

basket :
- RRP tax exc. : 10
- RRP tax inc. : 10.55
- ecost price tax exc. : 9
- ecost price tax inc. : 9.49
=> maybe KO, but out of the scope of this bug : if the library does not pay
tax, the total ecost price tax inc. should probably be the same as the total
price tax exc. Or the column "ecost tax inc." should be hidden if it means
nothing in this configuration.

receipt page :
- replacement : 10
- budgeted : 9
- actual cost : 9
=> maybe KO, but out of the scope (I suppose replacement price should be tax
included in remplacement cost)

receipt page (after reception, table "already received") :
- est cost : 9
- actual cost : 9
- total : 9
- Total tax inc. : 9.49
=> KO for "Total tax inc. : 9.49", Should be "9", but out of the scope of this
bug

invoice page :
- actual cost tax ecl : 9
- actual cost tax incl : 9.49
=> KO : we don't pay tax for this vendor, so actual cost tax incl should be "9"

=========
test 2:
vendor yes  (list price) / yes  (invoiced price).  The list price entered by
the librarian does include tax, and the library does pay tax

basket :
- RRP tax exc. : 9.48
- RRP tax inc. : 10
- total price tax exc. : 8.53
- total price tax inc. : 9
=> OK

receipt page :
- replacement : 10
- budgeted : 9
- actual cost : 9
=> OK

receipt page (after reception, table "already received") :
- est cost : 9
- actual cost : 9
- total : 9
- Total tax inc. : 9
=> OK

invoice page :
- actual cost tax ecl : 9
- actual cost tax incl : 9.49
=> KO : we should have "8.53" and "9"

======
Test 3:
vendor yes  (list price) / no  (invoiced price). The list price entered by the
librarian does include tax, and the library does NOT pay tax

basket :
- RRP tax exc. : 9.48
- RRP tax inc. : 10
- total price tax exc. : 8.53
- total price tax inc. : 9
=> maybe KO but out of the scope of the bug : If the library does not pay tax,
ecost tax inc. should be the same as tax exc. and the 2 equal 8.53 ? Or the
column should be hidden

receipt page :
- replacement : 9.48
- budgeted : 8.53
- actual cost : 8.53
=> maybe KO : replacement price must be tax inc. (I suppose so, if the aim is
to know the public price of the book to get it paid back by a reader who had
lost it). 

receipt page (after reception, table "already received") :
- est cost : 8.53
- actual cost : 8.53
- total : 8.53
- Total tax inc. : 9
=> KO. Total tax inc. should be "8.53" as we pay no tax

invoice page :
- actual cost tax ecl : 9
- actual cost tax incl : 9.49
=> KO : we should have "8.53" in both column

======
test 4:
vendor no  (list price) / yes  (invoiced price).  The list price entered by the
librarian does NOT include tax, and the library does pay tax

basket :
- RRP tax exc. : 10
- RRP tax inc. : 10.55
- total price tax exc. : 9
- total price tax inc. : 9.49
=> OK

receipt page :
- replacement : 10.55
- budgeted : 9.49
- actual cost : 9.49
=> OK

receipt page (after reception, table "already received") :
- est cost : 9.49
- actual cost : 9.49
- total : 9.49
- Total tax inc. (bottom of table) : 9.49
=> OK

invoice page :
- actual cost tax ecl : 9
- actual cost tax incl : 9.49
=> OK

-- 
You are receiving this mail because:
You are watching all bug changes.