[Koha-bugs] [Bug 10991] New: C4::ImportExportFramework has unnecessary temporary file and directory management code

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10991

            Bug ID: 10991
           Summary: C4::ImportExportFramework has unnecessary temporary
                    file and directory management code
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: minor
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: gmcharlt at gmail.com
          Reporter: gmcharlt at gmail.com
        QA Contact: testopia at bugs.koha-community.org

There is code in C4::ImportExportFramework that supplies alternative code if
the module File::Temp is not installed.  As File::Temp is both a core Perl
module and marked as a required dependency of Koha, that code only serves to
add unnecessary complexity to the module and (not that this is a core concern)
reduces portability to non-Unix-like platforms.

In particular, the _createTmpDir routine is unnecessary.  Removing it would
also remove a dependency on Digest::MD5.

Similarly, there's code that handles the case where File::Path is not present,
but this is also a core Perl module.

-- 
You are receiving this mail because:
You are watching all bug changes.