[Koha-bugs] [Bug 6554] Resolve encoding problems with corrected UTF8 handling in templates

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554

--- Comment #159 from Ketan Kulkarni <ketan at carvingit.com> ---
Hello Tomás,

I appreciate your concerns. I have read the web page. It's up to the QA and RM
to decide.

Nevertheless, the updates in the patch have been done in accordance with the
principle - decode the input and encode the output.

Although utf8::upgrade() is a temporary fix to "hide" the problems if any, does
fix things to a great extent. Besides, upgrade() is an inbuilt perl function.
And on production systems it's better we use upgrade() than just encode() if it
is going to break things. Once we have a plan in place, this will be replaced
by Encode::.... You see, there's talk about using Encode::... instead of
utf8::....
In the current scenario, utf8::upgrade() appears to be a decent (and forgiving)
way of handling errors in coding.

There's another bug related to writing a generic subroutine for utf-decoding
for input. The discussion is on.

Considering the size of the code-base, UTF handling related updates are going
to take time. The present patch tries to fix the problem that is there in the
stable release temporarily.

Regards,
Ketan

(In reply to Tomás Cohen Arazi from comment #158)
> Ketan,
> 
> (In reply to Ketan Kulkarni from comment #155)
> > Hello Tomás,
> > 
> > Yes, we should move from utf8::encode/decode to Encode::
> > This particular bug (6554) is about double encoding that happens in
> > Templates.pm.
> 
> Take a look at this work from Marcel:
> http://wiki.koha-community.org/wiki/Handling_UTF8_in_development
> 
> If we (currently) do things wrong inside Koha regarding encoding/decoding of
> UTF-8 data (double encoding means we are encoding wrong somewhere), then
> fixing those symptms will just hide the problem (using utf8::upgrade will
> avoid the consequences but not fix the root cause, it might even hide new
> bugs introduced by future patches).
> 
> It is up to the QA team and the RM to think of the best approach for
> tackling this so I'm just leaving this comment, also I appreciate you
> efforts and hope this gets fixed soon.

-- 
You are receiving this mail because:
You are watching all bug changes.