[Koha-bugs] [Bug 10363] There is no package for authorised values.
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Sun Oct 6 19:17:06 CEST 2013
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363
Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #18751|0 |1
is obsolete| |
--- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> ---
Created attachment 21833
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21833&action=edit
[SIGNED-OFF] Bug 10363: Add 2 packages for authorised values
Currently, the authorised values are anarchically managed :)
We have to have a better way to manage them.
I propose 2 packages in order to execute the sql queries into a package
instead of directly into the pl script.
This development adds:
- A new unique key (category and authorised values) for the
authorised_values table.
- 2 new packages Koha::AuthorisedValue and Koha::AuthorisedValues
- 1 new unit test file in order to test these 2 packages.
It is a code source evolution, but there is no change for the final user.
Test plan:
1/ Apply the patches
2/ Check that existing authorised values is displayed on your admin
page (admin/authorised_values.pl).
3/ Update an existing one
4/ Create a new category
5/ Create a new AV for this category
6/ Create another one with the same value, an error should be occur.
7/ Delete one AV.
8/ Click everywhere on the authorised values admin page and try to find
a bug.
9/ Launch t/db_dependent/AuthorisedValues.t and check that all tests
pass (1 sql error appears, it is normal).
Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel at gmail.com>
Just arrived to this trying to remove one scrolling_list
from a function on C4/Input.pm, and trying to find a module
for authorised values.
Re-tested adding, removing and updating authorised values
No koha-qa errors.
Unit test reports sucess
Think that this is a good module to have.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list